Re: HttpClient 4.5 feature release?

2015-02-17 Thread Michael Osipov
Am 2015-02-17 um 11:04 schrieb Oleg Kalnichevski: Folks It looks like the only proper way of resolving HTTPCLIENT-1613 [1] is to extend existing APIs, which (at least ideally) should require a new feature release and a full ALPHA / BETA development cycle. We, of course, could just cut 4.5 GA ri

Re: HttpClient 4.5 feature release?

2015-02-26 Thread Michael Osipov
Am 2015-02-17 um 11:04 schrieb Oleg Kalnichevski: Folks It looks like the only proper way of resolving HTTPCLIENT-1613 [1] is to extend existing APIs, which (at least ideally) should require a new feature release and a full ALPHA / BETA development cycle. We, of course, could just cut 4.5 GA ri

Assigning issues

2015-02-26 Thread Michael Osipov
Oleg, is there any reason why you don't assign issues to yourself if you planning to fix/already fixed them? Michael - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.

Re: Assigning issues

2015-02-27 Thread Michael Osipov
Am 2015-02-27 um 11:28 schrieb Oleg Kalnichevski: On Thu, 2015-02-26 at 21:16 +0100, Michael Osipov wrote: Oleg, is there any reason why you don't assign issues to yourself if you planning to fix/already fixed them? What would be the benefit of that other than extra noise on the ma

Update Jenkins jobs

2015-03-01 Thread Michael Osipov
Hi folks, can someone update job httpcomponents-client-4.4.x from trunk to branches/4.4.x and create a 4.5.x job from trunk? I am solely a dev on Jenkins. Michael - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For a

Re: Update Jenkins jobs

2015-03-01 Thread Michael Osipov
Am 2015-03-01 um 21:16 schrieb Oleg Kalnichevski: On Sun, 2015-03-01 at 20:26 +0100, Michael Osipov wrote: Hi folks, can someone update job httpcomponents-client-4.4.x from trunk to branches/4.4.x and create a 4.5.x job from trunk? Done. https://builds.apache.org/view/H-L/view

Need clarification on the auth backend design for HTTPCLIENT-1625

2015-03-01 Thread Michael Osipov
Hi folks, I need some design clarification on the HttpClient auth backend. Currently, I trying to figure out how I can plug in connection-based auth best into the code. From reading the docs and the code, this is what I understood now: Client receives a 401/407, looks up the best available Au

Re: Need clarification on the auth backend design for HTTPCLIENT-1625

2015-03-02 Thread Michael Osipov
Am 2015-03-02 um 12:31 schrieb Oleg Kalnichevski: On Sun, 2015-03-01 at 22:45 +0100, Michael Osipov wrote: Hi folks, I need some design clarification on the HttpClient auth backend. Currently, I trying to figure out how I can plug in connection-based auth best into the code. From reading the

Re: Need clarification on the auth backend design for HTTPCLIENT-1625

2015-03-13 Thread Michael Osipov
Hi Oleg, finally I am able to respond. Way too late. A cold has knocked me off for 10 days. Am 2015-03-03 um 18:54 schrieb Oleg Kalnichevski: On Tue, 2015-03-03 at 08:15 +0100, Michael Osipov wrote: Am 2015-03-02 um 12:31 schrieb Oleg Kalnichevski: On Sun, 2015-03-01 at 22:45 +0100

Re: Need clarification on the auth backend design for HTTPCLIENT-1625

2015-03-14 Thread Michael Osipov
Am 2015-03-13 um 18:05 schrieb Oleg Kalnichevski: On Fri, 2015-03-13 at 15:49 +0100, Michael Osipov wrote: Hi Oleg, finally I am able to respond. Way too late. A cold has knocked me off for 10 days. Same happened to me a month back. It was not fun. Take it easy. ... What about the

Re: Need clarification on the auth backend design for HTTPCLIENT-1625

2015-03-15 Thread Michael Osipov
Am 2015-03-15 um 15:15 schrieb Oleg Kalnichevski: On Sat, 2015-03-14 at 23:01 +0100, Michael Osipov wrote: Am 2015-03-13 um 18:05 schrieb Oleg Kalnichevski: On Fri, 2015-03-13 at 15:49 +0100, Michael Osipov wrote: ... That looks quite complex. Anyway, if you can think of a bit of

Re: Need clarification on the auth backend design for HTTPCLIENT-1625

2015-03-16 Thread Michael Osipov
Am 2015-03-15 um 23:00 schrieb Oleg Kalnichevski: On Sun, 2015-03-15 at 22:09 +0100, Michael Osipov wrote: Am 2015-03-15 um 15:15 schrieb Oleg Kalnichevski: On Sat, 2015-03-14 at 23:01 +0100, Michael Osipov wrote: Am 2015-03-13 um 18:05 schrieb Oleg Kalnichevski: On Fri, 2015-03-13 at 15:49

Progress of HTTPCLIENT-1625/open questions

2015-04-06 Thread Michael Osipov
Hi folks, I have finally started coding of that issue. While I was able to write a working prototype within an hour authenticating against Apache Tomcat and Apache Web Server, an issue arose I am not really clear about: Is a credentials provider always necessary for a target host? In other w

Re: Progress of HTTPCLIENT-1625/open questions

2015-04-06 Thread Michael Osipov
Am 2015-04-06 um 18:12 schrieb Oleg Kalnichevski: On Mon, 2015-04-06 at 16:26 +0200, Michael Osipov wrote: Hi folks, I have finally started coding of that issue. While I was able to write a working prototype within an hour authenticating against Apache Tomcat and Apache Web Server, an issue

Re: Progress of HTTPCLIENT-1625/open questions

2015-04-07 Thread Michael Osipov
Am 2015-04-07 um 12:04 schrieb Oleg Kalnichevski: On Mon, 2015-04-06 at 22:15 +0200, Michael Osipov wrote: Am 2015-04-06 um 18:12 schrieb Oleg Kalnichevski: On Mon, 2015-04-06 at 16:26 +0200, Michael Osipov wrote: Hi folks, I have finally started coding of that issue. While I was able to

Re: Progress of HTTPCLIENT-1625/open questions

2015-04-07 Thread Michael Osipov
Am 2015-04-07 um 14:05 schrieb Oleg Kalnichevski: On Tue, 2015-04-07 at 13:23 +0200, Michael Osipov wrote: ... Oh, Holy Mother. WWW-Authenticate in a 200 response? Really? Absolutely, it can happen on any response code, at least 2xx and 3xx because HTTP is crappy for that. ... I fear

Re: Progress of HTTPCLIENT-1625/open questions

2015-04-07 Thread Michael Osipov
Am 2015-04-07 um 14:42 schrieb Oleg Kalnichevski: On Tue, 2015-04-07 at 14:25 +0200, Michael Osipov wrote: Am 2015-04-07 um 14:05 schrieb Oleg Kalnichevski: On Tue, 2015-04-07 at 13:23 +0200, Michael Osipov wrote: ... Oh, Holy Mother. WWW-Authenticate in a 200 response? Really? Absolutely

Re: Progress of HTTPCLIENT-1625/open questions

2015-04-07 Thread Michael Osipov
Am 2015-04-07 um 14:42 schrieb Oleg Kalnichevski: On Tue, 2015-04-07 at 14:25 +0200, Michael Osipov wrote: Am 2015-04-07 um 14:05 schrieb Oleg Kalnichevski: On Tue, 2015-04-07 at 13:23 +0200, Michael Osipov wrote: ... Oh, Holy Mother. WWW-Authenticate in a 200 response? Really? Absolutely

Progress of HTTPCLIENT-1625 (2)

2015-04-13 Thread Michael Osipov
Hi folks, I'd like to you to update on the status of my rewrite challenge: It did not turn out to be as easy as I have assumed. I debugged a lot of stuff, read the code, etc. HttpClient is well implementing RFC 2617 auth schemes which are all request-based (stateless), challenge-response (ser

Re: Progress of HTTPCLIENT-1625 (2)

2015-04-17 Thread Michael Osipov
Am 2015-04-14 um 20:35 schrieb Oleg Kalnichevski: On Mon, 2015-04-13 at 22:46 +0200, Michael Osipov wrote: Hi folks, I'd like to you to update on the status of my rewrite challenge: It did not turn out to be as easy as I have assumed. I debugged a lot of stuff, read the code, etc. HttpC

Re: Progress of HTTPCLIENT-1625 (2)

2015-05-05 Thread Michael Osipov
Am 2015-04-17 um 16:47 schrieb Oleg Kalnichevski: On Fri, 2015-04-17 at 13:02 +0200, Michael Osipov wrote: Am 2015-04-14 um 20:35 schrieb Oleg Kalnichevski: On Mon, 2015-04-13 at 22:46 +0200, Michael Osipov wrote: Hi folks, ... Michael, Probably we have to move resolution of this issue

Some comments on recent auth API changes

2015-08-09 Thread Michael Osipov
Oleg, just have noticed that you started to rewrite the auth API, here are a few issues which need some improvement: 1. httpclient/src/main/java/org/apache/http/auth/AuthScheme.java: #getPrinciple That is supposed to be #getPricipal and not #getPrinciple. 2. Rename AuthState in AuthExch

Re: My part in auth APIs refactoring concluded; was Re: Some comments on recent auth API changes

2015-08-16 Thread Michael Osipov
Am 2015-08-12 um 16:25 schrieb Oleg Kalnichevski: On Sun, 2015-08-09 at 20:19 +0200, Oleg Kalnichevski wrote: On Sun, 2015-08-09 at 19:41 +0200, Michael Osipov wrote: Oleg, ... I was going to write everything up in a few days, post it to the list and basically pass everything over to you

Re: HC 5.0: co-location with HC 4.x

2015-11-19 Thread Michael Osipov
Am 2015-11-19 um 12:32 schrieb Oleg Kalnichevski: Folks I would like to start working on the first alpha releases of HC 5.0. There is one issue that still needs to be discussed though before I can proceed. We need to decide on how we intent to maintain compatibility with HC 4.x. It is pretty cl

Re: Re: HC 5.0: co-location with HC 4.x

2015-11-20 Thread Michael Osipov
> On Thu, 2015-11-19 at 23:27 +, sebb wrote: > > On 19 November 2015 at 21:17, Michael Osipov wrote: > > > Am 2015-11-19 um 12:32 schrieb Oleg Kalnichevski: > > ... > > > > > > > First of all, I wouldn't use any of those. (Currently referrin

Re: Re: Re: HC 5.0: co-location with HC 4.x

2015-11-20 Thread Michael Osipov
> On Fri, 2015-11-20 at 12:42 +0100, Michael Osipov wrote: > > > On Thu, 2015-11-19 at 23:27 +, sebb wrote: > > > > On 19 November 2015 at 21:17, Michael Osipov > > > > wrote: > > > > > Am 2015-11-19 um 12:32 schrieb Oleg Kalnichevski: >

Re: HC 5.0: co-location with HC 4.x

2015-11-20 Thread Michael Osipov
Am 2015-11-20 um 16:33 schrieb Oleg Kalnichevski: On Fri, 2015-11-20 at 15:13 +0100, Michael Osipov wrote: On Fri, 2015-11-20 at 12:42 +0100, Michael Osipov wrote: On Thu, 2015-11-19 at 23:27 +, sebb wrote: On 19 November 2015 at 21:17, Michael Osipov wrote: Am 2015-11-19 um 12:32

Re: HC 5.0: co-location with HC 4.x

2015-11-20 Thread Michael Osipov
Am 2015-11-20 um 19:38 schrieb Gary Gregory: On Fri, Nov 20, 2015 at 10:04 AM, Michael Osipov wrote: Am 2015-11-20 um 16:33 schrieb Oleg Kalnichevski: On Fri, 2015-11-20 at 15:13 +0100, Michael Osipov wrote: On Fri, 2015-11-20 at 12:42 +0100, Michael Osipov wrote: On Thu, 2015-11-19 at

Re: HC 5.0: co-location with HC 4.x

2015-11-20 Thread Michael Osipov
Am 2015-11-20 um 20:57 schrieb Oleg Kalnichevski: I also can well imagine SSL related components being in a separate namespace like 'org.apache.hc.core5.ssl' That would be ok. At the end, you propose: HC Core: org.apache.hc.http.core5 HC Client: org.apache.hc.http.client5 HC Async Cilent: org

Re: HC 5.0: package / module structure; Re: HC 5.0: co-location with HC 4.x

2015-11-21 Thread Michael Osipov
Am 2015-11-21 um 18:01 schrieb Oleg Kalnichevski: Folks I moved code to org.apache.hc.core5 namespace as the first step. Now I would like to move things around in order to make the package structure more consistent, reduce circular dependencies between packages and prepare for messaging code se

Re: HC 5.0: package / module structure; Re: HC 5.0: co-location with HC 4.x

2015-11-21 Thread Michael Osipov
Am 2015-11-21 um 19:52 schrieb Gary Gregory: +1. I would not mind using Java 8 too. Believe that is too early. We are using a company-wide, Eclipse RCP-based product which is on Eclipse 3.4/3.6 and still HttpClient 3.x. I highly doubt that the dev team will jump on e4 and Java 8 features. J

Re: HC 5.0: package / module structure; Re: HC 5.0: co-location with HC 4.x

2015-11-22 Thread Michael Osipov
Am 2015-11-22 um 20:11 schrieb Oleg Kalnichevski: On Sat, 2015-11-21 at 19:48 +0100, Michael Osipov wrote: Am 2015-11-21 um 18:01 schrieb Oleg Kalnichevski: Folks I moved code to org.apache.hc.core5 namespace as the first step. Now I would like to move things around in order to make the

Re: Re: HC 5.0: package / module structure; Re: HC 5.0: co-location with HC 4.x

2015-11-23 Thread Michael Osipov
> On Sun, Nov 22, 2015 at 3:10 PM, Jon Moore wrote: > > > On Sat, Nov 21, 2015 at 1:56 PM, Michael Osipov > > wrote: > > > > > Am 2015-11-21 um 19:52 schrieb Gary Gregory: > > > > > >> +1. > > >> > > >> I would n

Re: Re: Re: HC 5.0: package / module structure; Re: HC 5.0: co-location with HC 4.x

2015-11-23 Thread Michael Osipov
> On Mon, 2015-11-23 at 10:08 +0100, Michael Osipov wrote: > > > On Sun, Nov 22, 2015 at 3:10 PM, Jon Moore wrote: > > > > > > > On Sat, Nov 21, 2015 at 1:56 PM, Michael Osipov > > > > wrote: > > > > > > > > &

Re: Re: HC 5.0: package / module structure; Re: HC 5.0: co-location with HC 4.x

2015-11-23 Thread Michael Osipov
> On Sun, 2015-11-22 at 20:42 +0100, Michael Osipov wrote: > > Am 2015-11-22 um 20:11 schrieb Oleg Kalnichevski: > > > On Sat, 2015-11-21 at 19:48 +0100, Michael Osipov wrote: > > >> Am 2015-11-21 um 18:01 schrieb Oleg Kalnichevski: > > >>> Folks > &

Re: Re: Re: HC 5.0: package / module structure; Re: HC 5.0: co-location with HC 4.x

2015-11-23 Thread Michael Osipov
> On Mon, 2015-11-23 at 10:51 +0100, Michael Osipov wrote: > > > On Sun, 2015-11-22 at 20:42 +0100, Michael Osipov wrote: > > > > Am 2015-11-22 um 20:11 schrieb Oleg Kalnichevski: > > > > > On Sat, 2015-11-21 at 19:48 +0100, Michael Osipov wrote: > &g

Re: HC 5.0: artifact id; Re: HC 5.0: package / module structure; Re: HC 5.0: co-location with HC 4.x

2015-11-25 Thread Michael Osipov
Am 2015-11-25 um 17:36 schrieb Oleg Kalnichevski: Folks I made the first pass at re-arranging packages in HttpCore trunk and think it is presently good enough for 5.0-alpha1 Please feel free to take a look. Just checked. Looks like a tremendous move action. I will require a day or two to hav

Re: HC 5.0: artifact id; Re: HC 5.0: package / module structure; Re: HC 5.0: co-location with HC 4.x

2015-11-25 Thread Michael Osipov
Am 2015-11-25 um 21:07 schrieb Gary Gregory: [..] |- httpcore |- httpcore-ab |- httpcore-osgi We should always keep in mind that the artifact should be recognizable by its filname or id. Maybe httpcomponents-httpcore, -httpcore-ab, etc. would be better but they are, of course, longer. (imho)

Re: Better header API

2015-11-30 Thread Michael Osipov
Am 2015-11-30 um 19:53 schrieb Gary Gregory: I mean: Index: src/main/java/org/apache/hc/core5/http/HttpMessage.java === --- src/main/java/org/apache/hc/core5/http/HttpMessage.java (revision 1717301) +++ src/main/java/org/apache/hc/c

Re: Better header API

2015-12-01 Thread Michael Osipov
Am 2015-12-01 um 02:22 schrieb Gary Gregory: On Mon, Nov 30, 2015 at 1:43 PM, Michael Osipov wrote: Am 2015-11-30 um 19:53 schrieb Gary Gregory: I mean: Index: src/main/java/org/apache/hc/core5/http/HttpMessage.java

Re: HC 5.0: HttpCore 5.0 alpha1 release

2015-12-01 Thread Michael Osipov
Am 2015-12-01 um 14:35 schrieb Oleg Kalnichevski: Folks I would like to start cutting RC1 for HttpCore 5.0 alpha1 sometime soon. Could you please take a look at the latest snapshot and let me know if you find anything that might block the release or cause another RC build? While this is an al

Re: HC 5.0: HttpCore 5.0 alpha1 release

2015-12-01 Thread Michael Osipov
Am 2015-12-01 um 21:46 schrieb Oleg Kalnichevski: On Tue, 2015-12-01 at 21:29 +0100, Michael Osipov wrote: Am 2015-12-01 um 14:35 schrieb Oleg Kalnichevski: Folks I would like to start cutting RC1 for HttpCore 5.0 alpha1 sometime soon. Could you please take a look at the latest snapshot and

Re: HC 5.0: HttpCore 5.0 alpha1 release

2015-12-01 Thread Michael Osipov
Am 2015-12-01 um 21:52 schrieb Oleg Kalnichevski: On Tue, 2015-12-01 at 21:50 +0100, Michael Osipov wrote: Am 2015-12-01 um 21:46 schrieb Oleg Kalnichevski: On Tue, 2015-12-01 at 21:29 +0100, Michael Osipov wrote: Am 2015-12-01 um 14:35 schrieb Oleg Kalnichevski: Folks I would like to start

Disagreement on Log4J2

2017-05-03 Thread Michael Osipov
Hi folks, it recently has come to my attention that Commons Logging has been replaced with Log4J2. Well, I proposed almost two years ago to move to SLF4J for good reasons [1]. People disagreed that Commons Logging is good enough and this discussion has been held several times w/o any concensus

Re: [VOTE][Simple Majority] Migrate project source repository to Git

2017-05-04 Thread Michael Osipov
While I do say +1 the vote is incomplete: You missed to provide the target Git repo names. E.g., you won't name httpcomponents/project/ => project right? I'd propose the following: httpcomponents-core httpcomponents-client httpcomponents-parent httpcomponents-stylecheck httpcomponents-site It mi

Re: Git repo names; Re: [VOTE][Simple Majority] Migrate project source repository to Git

2017-05-04 Thread Michael Osipov
Am 2017-05-04 um 16:51 schrieb Oleg Kalnichevski: On Thu, 2017-05-04 at 15:59 +0200, Michael Osipov wrote: While I do say +1 the vote is incomplete: You missed to provide the target Git repo names. E.g., you won't name httpcomponents/project/ => project right? Does this need to b

Re: SSLContextBuilder.[use|set]Protocol(String)

2017-05-04 Thread Michael Osipov
Am 2017-05-05 um 02:02 schrieb Gary Gregory: Hi, In Core 4.4.x we have: SSLContextBuilder.useProtocol(String) and in 5.0, we have: SSLContextBuilder.setProtocol(String) How about adding SSLContextBuilder.setProtocol(String) to 4.4.x and deprecating useProtocol(String) to make porting easier?

Re: Git migration; Re: [VOTE][RESULT] Migrate project source repository to Git

2017-05-08 Thread Michael Osipov
> On Mon, 2017-05-08 at 09:41 +0200, Oleg Kalnichevski wrote: > > The vote to migrate active HttpComponents projects from SVN > > repository > > to a Git repository has passed with the following results > > > > +1  > > > > Oleg Kalnichevski

Re: Git repo naming

2017-05-08 Thread Michael Osipov
> On Mon, 2017-05-08 at 11:48 +0200, Michael Osipov wrote: > > Based on Daniel Gruno's answer, we should discuss repo names first. > > > > Michael > > > > OK. How about this? > > HttpCore -> httpcomponents-core > HttpClient -> http

Re: [PROPOSAL] Extending HttpClient content decoders

2017-05-08 Thread Michael Osipov
Am 2017-05-08 um 19:59 schrieb Gary Gregory: Hi All, We recently had a request to support Google's Brotli decompression algorithm. We decided NOT to add a dependency on the Brotli jar and I suggested that the patch be provided against Apache Commons Compress, which was kindly done and will be p

Re: Git repo naming

2017-05-08 Thread Michael Osipov
Am 2017-05-08 um 15:51 schrieb Oleg Kalnichevski: On Mon, 2017-05-08 at 14:54 +0200, Oleg Kalnichevski wrote: On Mon, 2017-05-08 at 14:12 +0200, Michael Osipov wrote: On Mon, 2017-05-08 at 11:48 +0200, Michael Osipov wrote: Based on Daniel Gruno's answer, we should discuss repo names

Re: Git repo naming

2017-05-08 Thread Michael Osipov
Am 2017-05-08 um 20:59 schrieb Oleg Kalnichevski: On Mon, 2017-05-08 at 20:34 +0200, Michael Osipov wrote: ... This was intentional. I would also like to use that repository to contain style check definitions and possibly other project global things. Can you live with it being

Re: [VOTE][RESULT] Migrate project source repository to Git

2017-05-09 Thread Michael Osipov
Please do not forget to rename trunk to master: https://git-wip-us.apache.org/repos/asf?p=httpcomponents-core.git;a=shortlog;h=refs/heads/trunk - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-ma

Re: Do not commit to HttpCore SVN!

2017-05-10 Thread Michael Osipov
Am 2017-05-10 um 09:59 schrieb Oleg Kalnichevski: I collected all your latest SVN commits and pushed them to the Git repo. Nothing should have been lost. One personal request. Do you think you could try to make your commits less granular and combine logically related changes into larger change

Git policies and practices

2017-05-10 Thread Michael Osipov
Hi folks, given that Oleg finally took up the chance migrating core and client to a Git-based repo, we should agree how we are going to work with in conformance with a good Git practice to avoid chaos on master. I'd like to provide an example first why a common practive is so necessary to mak

Re: Do not commit to HttpCore SVN!

2017-05-10 Thread Michael Osipov
Am 2017-05-10 um 20:52 schrieb Oleg Kalnichevski: On Wed, 2017-05-10 at 11:15 -0700, Gary Gregory wrote: On Wed, May 10, 2017 at 10:13 AM, Oleg Kalnichevski wrote: ... One personal request. Do you think you could try to make your commits less granular and combine logically related change

Re: Do not commit to HttpCore SVN!

2017-05-10 Thread Michael Osipov
Am 2017-05-10 um 21:16 schrieb Oleg Kalnichevski: On Wed, 2017-05-10 at 21:07 +0200, Michael Osipov wrote: Am 2017-05-10 um 20:52 schrieb Oleg Kalnichevski: On Wed, 2017-05-10 at 11:15 -0700, Gary Gregory wrote: On Wed, May 10, 2017 at 10:13 AM, Oleg Kalnichevski wrote: ... One

Re: Git policies and practices

2017-05-10 Thread Michael Osipov
Am 2017-05-10 um 21:22 schrieb Oleg Kalnichevski: On Wed, 2017-05-10 at 21:06 +0200, Michael Osipov wrote: Hi folks, given that Oleg finally took up the chance migrating core and client to a Git-based repo, we should agree how we are going to work with in conformance with a good Git practice

Re: Git policies and practices

2017-05-10 Thread Michael Osipov
Am 2017-05-10 um 21:31 schrieb Bindul Bhowmik: On Wed, May 10, 2017 at 1:25 PM, sebb wrote: It would be helpful to document this on the Wiki and/or website On 10 May 2017 at 20:22, Oleg Kalnichevski wrote: On Wed, 2017-05-10 at 21:06 +0200, Michael Osipov wrote: Hi folks, given that Oleg

One Git repo per major version

2017-05-10 Thread Michael Osipov
Folks, since there is still some disagreement on how an issue should be applied to 4.4.x and 5.0.x, I'd like to propose the following two ideas: Have one repo per major version and all pain will end: httpcomponents-core-4 httpcomponents-client-4 httpcomponents-core-5 httpcomponents-client-5

Re: Do not commit to HttpCore SVN!

2017-05-10 Thread Michael Osipov
Am 2017-05-10 um 21:42 schrieb Oleg Kalnichevski: On Wed, 2017-05-10 at 21:27 +0200, Michael Osipov wrote: Am 2017-05-10 um 21:16 schrieb Oleg Kalnichevski: On Wed, 2017-05-10 at 21:07 +0200, Michael Osipov wrote: Am 2017-05-10 um 20:52 schrieb Oleg Kalnichevski: On Wed, 2017-05-10 at 11:15

Re: Git policies and practices

2017-05-10 Thread Michael Osipov
Am 2017-05-10 um 21:52 schrieb Oleg Kalnichevski: On Wed, 2017-05-10 at 21:36 +0200, Michael Osipov wrote: ... I would still ask for master being mutable (rewritable) or abandon the concept of a master branch as inapplicable in favor of a release branch such as 5.0.x. One master per

Re: Do not commit to HttpCore SVN!

2017-05-10 Thread Michael Osipov
Am 2017-05-10 um 21:54 schrieb Oleg Kalnichevski: On Wed, 2017-05-10 at 21:45 +0200, Michael Osipov wrote: This will a problem anyway because all paths change (package names, etc.). Hopefully Git's similarity algorithm can detect this. No, it is not. Git is that great. It always amaz

Re: Do not commit to HttpCore SVN!

2017-05-10 Thread Michael Osipov
Am 2017-05-10 um 23:19 schrieb Oleg Kalnichevski: On Wed, 2017-05-10 at 22:00 +0200, Michael Osipov wrote: Am 2017-05-10 um 21:54 schrieb Oleg Kalnichevski: On Wed, 2017-05-10 at 21:45 +0200, Michael Osipov wrote: This will a problem anyway because all paths change (package names, etc

Re: Do not commit to HttpCore SVN!

2017-05-10 Thread Michael Osipov
Am 2017-05-10 um 23:48 schrieb Oleg Kalnichevski: On Wed, 2017-05-10 at 23:25 +0200, Michael Osipov wrote: ... But your answer is contrary to your previous statement -- cherry- picking shouldn't be a fuzz with two different repos. Can you explain why? My understanding is that c

Re: Do not commit to HttpCore SVN!

2017-05-15 Thread Michael Osipov
d "Git policies and practices". I don't want either the master/release branch to be rewritten. On Thu, May 11, 2017 at 9:23 AM, Oleg Kalnichevski wrote: On Thu, 2017-05-11 at 00:00 +0200, Michael Osipov wrote: Am 2017-05-10 um 23:48 schrieb Oleg Kalnichevski: On Wed, 2017

Re: Do not commit to HttpCore SVN!

2017-05-15 Thread Michael Osipov
Am 2017-05-15 um 13:13 schrieb Oleg Kalnichevski: On Mon, 2017-05-15 at 11:54 +0200, Julian Sedding wrote: Force pushing is considered a bad practice in Git for good reasons, thus rewriting history of published branches is IMHO a no-go. It makes everybody's life harder (and developers less exper

Re: Do not commit to HttpCore SVN!

2017-05-15 Thread Michael Osipov
Am 2017-05-15 um 15:05 schrieb Oleg Kalnichevski: On Mon, 2017-05-15 at 14:58 +0200, Michael Osipov wrote: Am 2017-05-15 um 13:13 schrieb Oleg Kalnichevski: On Mon, 2017-05-15 at 11:54 +0200, Julian Sedding wrote: Force pushing is considered a bad practice in Git for good reasons, thus

Re: Do not commit to HttpCore SVN!

2017-05-15 Thread Michael Osipov
Am 2017-05-15 um 16:00 schrieb Oleg Kalnichevski: On Mon, 2017-05-15 at 15:18 +0200, Michael Osipov wrote: ... Am 2017-05-15 um 15:05 schrieb Oleg Kalnichevski: I have _no_ intention of policing other committers. It is emotionally cheaper for me to take time to clean things up and than

Re: Do not commit to HttpCore SVN!

2017-05-15 Thread Michael Osipov
Am 2017-05-15 um 16:36 schrieb Oleg Kalnichevski: On Mon, 2017-05-15 at 16:18 +0200, Michael Osipov wrote: ... Am 2017-05-15 um 16:00 schrieb Oleg Kalnichevski: What benefit do you have if it is hard to follow the code paths? How much is "good" code worth if you don

Re: Do not commit to HttpCore SVN!

2017-05-15 Thread Michael Osipov
Am 2017-05-15 um 17:19 schrieb Gary Gregory: On Mon, May 15, 2017 at 8:04 AM, Michael Osipov wrote: Am 2017-05-15 um 16:36 schrieb Oleg Kalnichevski: On Mon, 2017-05-15 at 16:18 +0200, Michael Osipov wrote: ... Am 2017-05-15 um 16:00 schrieb Oleg Kalnichevski: What benefit do you

Re: Do not commit to HttpCore SVN!

2017-05-15 Thread Michael Osipov
Am 2017-05-15 um 17:19 schrieb Oleg Kalnichevski: On Mon, 2017-05-15 at 17:04 +0200, Michael Osipov wrote: Am 2017-05-15 um 16:36 schrieb Oleg Kalnichevski: On Mon, 2017-05-15 at 16:18 +0200, Michael Osipov wrote: ... I actually did: https://mail-archives.apache.org/mod_mbox/hc-dev

Re: Git policies and practices

2017-05-15 Thread Michael Osipov
Folks, I have updated the link based on the input and put it onto the wiki: https://wiki.apache.org/HttpComponents/GitGuidelines Here is verbatim copy: = Typical Issue Workflow = 1. Branch off master ({{{git checkout -b / master}}}) where {{{}}} is the branch you are going to apply the fix, e

Re: Fwd: [Httpcomponents Wiki] Update of "GitGuidelines" by MichaelOsipov

2017-05-15 Thread Michael Osipov
Am 2017-05-15 um 18:34 schrieb Gary Gregory: Hi, Thank you for kicking off this thread. I do not think "/" is good enough. At least when I tried it, EGit would not let me create a branch in a branch which makes sense. Which is what I used dev/4.4.x/HTTPCORE-466 in the HttpCore Git repo. This

Re: [Httpcomponents Wiki] Update of "GitGuidelines" by MichaelOsipov

2017-05-15 Thread Michael Osipov
Am 2017-05-15 um 18:43 schrieb Gary Gregory: Altassian has a plugin to handle (7) IIRC, we use something like that at work but for SVN. The plugin links a JIRA ticket to commits if the commit message includes the string [JIRA-ID]. There is also Altassian FishEye. I aware of that plugin. In fact

Re: [Httpcomponents Wiki] Update of "GitGuidelines" by MichaelOsipov

2017-05-15 Thread Michael Osipov
Am 2017-05-15 um 18:59 schrieb Michael Osipov: Am 2017-05-15 um 18:43 schrieb Gary Gregory: Altassian has a plugin to handle (7) IIRC, we use something like that at work but for SVN. The plugin links a JIRA ticket to commits if the commit message includes the string [JIRA-ID]. There is also

Re: Git policies and practices

2017-05-15 Thread Michael Osipov
l never be able to define the duration of temp, one day, week, months? The dev/ seems redundant to because 4.4.x -- note the X implies development on a bugfix branch. Michael On Mon, May 15, 2017 at 9:34 AM, Michael Osipov wrote: Folks, I have updated the link based on the input and put i

Re: Git policies and practices

2017-05-15 Thread Michael Osipov
Am 2017-05-15 um 19:35 schrieb Gary Gregory: On Mon, May 15, 2017 at 9:34 AM, Michael Osipov wrote: Folks, I have updated the link based on the input and put it onto the wiki: https://wiki.apache.org/HttpComponents/GitGuidelines Here is verbatim copy: = Typical Issue Workflow = 1. Branch

Re: Git policies and practices

2017-05-15 Thread Michael Osipov
Am 2017-05-15 um 20:18 schrieb Gary Gregory: On Mon, May 15, 2017 at 11:13 AM, Michael Osipov wrote: Am 2017-05-15 um 19:35 schrieb Gary Gregory: On Mon, May 15, 2017 at 9:34 AM, Michael Osipov wrote: Folks, I have updated the link based on the input and put it onto the wiki: https

Re: Git policies and practices

2017-05-15 Thread Michael Osipov
Am 2017-05-15 um 20:22 schrieb Oleg Kalnichevski: On Mon, 2017-05-15 at 20:13 +0200, Michael Osipov wrote: Am 2017-05-15 um 19:35 schrieb Gary Gregory: On Mon, May 15, 2017 at 9:34 AM, Michael Osipov ... Which of the paths should we pick: https://makandracards.com/makandra/527-squash

Re: Git policies and practices

2017-05-15 Thread Michael Osipov
Am 2017-05-15 um 20:18 schrieb Oleg Kalnichevski: On Mon, 2017-05-15 at 18:34 +0200, Michael Osipov wrote: Folks, I have updated the link based on the input and put it onto the wiki: https://wiki.apache.org/HttpComponents/GitGuidelines Here is verbatim copy: = Typical Issue Workflow = 1

Re: Git policies and practices

2017-05-15 Thread Michael Osipov
Am 2017-05-15 um 20:43 schrieb Gary Gregory: On Mon, May 15, 2017 at 11:37 AM, Michael Osipov wrote: Am 2017-05-15 um 20:18 schrieb Oleg Kalnichevski: On Mon, 2017-05-15 at 18:34 +0200, Michael Osipov wrote: Folks, I have updated the link based on the input and put it onto the wiki

Re: Git policies and practices / of tendency for good intentions to turn into s..t

2017-05-16 Thread Michael Osipov
Am 2017-05-16 um 09:22 schrieb Oleg Kalnichevski: So, I woke up this morning, took a look at my mail box and found two wonderful commit messages on top of the 4.4.x release branch saying 'oh, forgot this' and 'ah, forgot that' immediately after a dev branch merge. Shit like that will happen over

Re: Git policies and practices / of tendency for good intentions to turn into s..t

2017-05-17 Thread Michael Osipov
Hi Julian, Am 2017-05-17 um 09:30 schrieb Julian Sedding: Hi Oleg and Michael I understand your frustration with a messy commit log. Personally I strive to give context so that the commit can more easily be understood. Normally that includes a JIRA ID and the title. There are cases where I pre

Re: HttpCore / HttpClient fully migrated to Git

2017-05-18 Thread Michael Osipov
Am 2017-05-18 um 09:31 schrieb Oleg Kalnichevski: On Wed, 2017-05-17 at 09:12 -0700, Gary Gregory wrote: On May 17, 2017 6:54 AM, "Oleg Kalnichevski" wrote: Folks HttpCore / HttpClient have been fully migrated to Git, GitHub replication and all. Happy hacking, pushing and rebasing. We now n

Re: Git policies and practices / of tendency for good intentions to turn into s..t

2017-05-18 Thread Michael Osipov
Am 2017-05-18 um 09:38 schrieb Oleg Kalnichevski: On Wed, 2017-05-17 at 22:56 -0700, Gary Gregory wrote: Now that I am done with the branch dev/4.4.x/HTTPCORE-468 and the code is merged into 4.4.x, is it OK to delete the branch? Of course, once merged a dev branch should be deleted in the rem

Re: Git policies and practices

2017-05-19 Thread Michael Osipov
Since I haven't received anymore comments on the guidelines, I'll close the questioning and call a vote for commmitters and PMC members. Michael - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e

[VOTE] Git Guidelines

2017-05-21 Thread Michael Osipov
Hi folks, I am casting this vote for the previously discussed Git guidelines for all committers to make life easier for everyone. If the vote passes, every committer must abide to this. The guidelines: = Typical Issue Workflow = 1. Branch off a release branch (e.g., 4.4.x, 5.0.x) ({{{git ch

Re: [Httpcomponents Wiki] Update of "GitGuidelines" by MichaelOsipov

2017-05-21 Thread Michael Osipov
Am 2017-05-21 um 11:42 schrieb Oleg Kalnichevski: On Sun, 2017-05-21 at 08:52 +, Apache Wiki wrote: Dear Wiki user, You have subscribed to a wiki page or wiki category on "Httpcomponents Wiki" for change notification. The "GitGuidelines" page has been changed by MichaelOsipov: https://wiki

Re: [Httpcomponents Wiki] Update of "GitGuidelines" by MichaelOsipov

2017-05-21 Thread Michael Osipov
Am 2017-05-21 um 19:07 schrieb Oleg Kalnichevski: On Sun, 2017-05-21 at 17:27 +0200, Michael Osipov wrote: ... Am 2017-05-21 um 11:42 schrieb Oleg Kalnichevski: What is a timeframe you consider rewriting if necessary? A week? Three days? The shorter the timeframe the less likely it is

Re: [VOTE] Git Guidelines

2017-05-22 Thread Michael Osipov
if there a bug fix I just must have ASAP. On what do you exact Git steps? How to squash/rewrite? On a release? Maven Release Plugin does that for you On May 21, 2017 2:00 AM, "Michael Osipov" wrote: Hi folks, I am casting this vote for the previously discussed Git guidelines for al

Re: [Httpcomponents Wiki] Update of "GitGuidelines" by MichaelOsipov

2017-05-22 Thread Michael Osipov
Am 2017-05-22 um 09:59 schrieb Oleg Kalnichevski: On Sun, 2017-05-21 at 21:17 +0200, Michael Osipov wrote: Am 2017-05-21 um 19:07 schrieb Oleg Kalnichevski: On Sun, 2017-05-21 at 17:27 +0200, Michael Osipov wrote: ... Am 2017-05-21 um 11:42 schrieb Oleg Kalnichevski: What is a timeframe

Re: [VOTE] Git Guidelines

2017-05-22 Thread Michael Osipov
Am 2017-05-22 um 20:29 schrieb Gary Gregory: On Mon, May 22, 2017 at 11:16 AM, Michael Osipov wrote: Am 2017-05-22 um 06:46 schrieb Gary Gregory: I will follow whatever the community decides; my only request is that precise git instructions be provided for contributors and RMs. I'm

Re: Re: Git merges

2017-05-24 Thread Michael Osipov
> Hi Oleg, > > I'm sure we need no noise at all but I could not figure out how to clean it > up. > > I do know that got one cherry-picked commit right for one of the tickets. > > For the other, I could not get rid of the merge commits. If you can't merge properly, please ask for help before m

Re: Git merges

2017-05-24 Thread Michael Osipov
Am 2017-05-24 um 13:49 schrieb Oleg Kalnichevski: On Wed, 2017-05-24 at 11:51 +0200, Michael Osipov wrote: Hi Oleg, I'm sure we need no noise at all but I could not figure out how to clean it up. I do know that got one cherry-picked commit right for one of the tickets. For the other, I

Re: [VOTE] Git Guidelines

2017-05-24 Thread Michael Osipov
Am 2017-05-21 um 11:00 schrieb Michael Osipov: Vote is open until 2017-05-25 00:00 Etc/UTC. I am extending the vote until 2017-05-27 00:00 Etc/UTC due to low activity. [ ] +1 Committers must abide to these Git guidelines while working on the code [ ] -1 I do not agree with this guideline

Re: [VOTE] Git Guidelines

2017-05-24 Thread Michael Osipov
if there a bug fix I just must have ASAP. Do you intend to abstain from your vote? Or is this an indirect +1? Michael On May 21, 2017 2:00 AM, "Michael Osipov" wrote: Hi folks, I am casting this vote for the previously discussed Git guidelines for all committers to make life easier

Re: [VOTE] Git Guidelines

2017-05-24 Thread Michael Osipov
Am 2017-05-21 um 11:00 schrieb Michael Osipov: Hi folks, I am casting this vote for the previously discussed Git guidelines for all committers to make life easier for everyone. If the vote passes, every committer must abide to this. The guidelines: = Typical Issue Workflow = 1. Branch off a

Re: Git merges

2017-05-24 Thread Michael Osipov
Am 2017-05-24 um 18:55 schrieb Oleg Kalnichevski: . Michael, Is there anything holding back the vote? Not from my side. I did cast it (see [VOTE] Git Guidelines), but didn't receive no official votes. I will extend the period. Don't forget to cast your vote! Michael The subject of the v

[VOTE] Git Guidelines (2)

2017-05-24 Thread Michael Osipov
Hi folks, I am re-casting this vote for the previously discussed Git guidelines for all committers to make life easier for everyone. If the vote passes, every committer must abide to this. The guidelines: = Typical Issue Workflow = 1. Branch off a release branch (e.g., 4.4.x, 5.0.x) ({{{git

<    1   2   3   4   5   6   7   8   9   10   >