Re: new mod_include warnings

2001-09-02 Thread Justin Erenkrantz
[ Cliff sent me a note that mod_include is generating warnings... ] On Mon, Sep 03, 2001 at 12:17:38AM -0400, Cliff Woolley wrote: > On Sun, 2 Sep 2001, Justin Erenkrantz wrote: > > > On Mon, Sep 03, 2001 at 12:08:35AM -0400, Cliff Woolley wrote: > > > > > > mod_include.c: In function `find_star

Re: cvs commit: httpd-2.0/modules/http mod_mime.c

2001-09-02 Thread Joshua Slive
On Sun, 2 Sep 2001, Justin Erenkrantz wrote: > Yuck, yuck, yuck, yuck, yuck. (Did I mention I think this is yucky?) Let me propose something way out in left field. Feel free to shoot it down. Problem: filters configuration is damn confusing. I only have time to skim new-httpd (err, dev@httpd

Re: cvs commit: httpd-2.0/modules/http mod_mime.c

2001-09-02 Thread Justin Erenkrantz
On Sun, Sep 02, 2001 at 10:49:52PM -0500, William A. Rowe, Jr. wrote: > Not this way. No other mod_mime variable behaves the way you you are trying. > I'm not kidding about adding a Set{Input|Output}FilterByType/SetHandlerByType > so when we ask folks to rely upon mime types, they can actually do

Re: cvs commit: httpd-2.0/modules/http mod_mime.c

2001-09-02 Thread William A. Rowe, Jr.
From: "Justin Erenkrantz" <[EMAIL PROTECTED]> Sent: Sunday, September 02, 2001 10:40 PM > On Sun, Sep 02, 2001 at 10:17:46PM -0500, William A. Rowe, Jr. wrote: > > Thank you, first off, for catching my foobar. > > > > But -1 on the solution. This is contrary to the syntax of AddSomething. > >

Re: cvs commit: httpd-2.0/modules/http mod_mime.c

2001-09-02 Thread Justin Erenkrantz
On Sun, Sep 02, 2001 at 10:17:46PM -0500, William A. Rowe, Jr. wrote: > Thank you, first off, for catching my foobar. > > But -1 on the solution. This is contrary to the syntax of AddSomething. > AddSomething in mod_mime (and SetSomething in core) always _replaces_ the > prior declaration!!! If

Re: cvs commit: httpd-2.0/modules/http mod_mime.c

2001-09-02 Thread William A. Rowe, Jr.
> > AddOutputFilter GZ html (server-level) > > AddOutputFilter Includes html (directory-level) I think what you want is AddOutputFilter Includes html. SetOutputFilterByType gz text/* That syntax doesn't exist... yet :) Bill

Re: cvs commit: httpd-2.0/modules/http mod_mime.c

2001-09-02 Thread William A. Rowe, Jr.
Thank you, first off, for catching my foobar. But -1 on the solution. This is contrary to the syntax of AddSomething. AddSomething in mod_mime (and SetSomething in core) always _replaces_ the prior declaration!!! We are going to have 10,000,000 webserer users three years from now asking why don

Re: [PATCH] Add mod_gz to httpd-2.0

2001-09-02 Thread Pier Fumagalli
"Ryan Bloom" <[EMAIL PROTECTED]> wrote: > If you want to use gzip, then zip your data before putting it on-line. That > doesn't help generated pages, but perl can already do gzip, as can PHP. And Tomcat 4.x :) Pier

Re: [PATCH] Add mod_gz to httpd-2.0

2001-09-02 Thread Cliff Woolley
On Sun, 2 Sep 2001 [EMAIL PROTECTED] wrote: > Correct... and for a while the reason was because everyone thought the > module was using ZLIB and there has been a long standing aversion to > including ANY version of GNU ZLIB ( or any other GNU stuff ) into the > Apache tree. We have personal email

Re: [PATCH] Add mod_gz to httpd-2.0

2001-09-02 Thread Justin Erenkrantz
On Sun, Sep 02, 2001 at 01:59:16PM -0700, Ryan Bloom wrote: > This is not a 3 +1's and it's in issue. This is a topic currently under > discussion, and adding it to the server now would be rude. This is also > a large enough issue, that it really should be given at least three days for > people

Re: [PATCH] Add mod_gz to httpd-2.0

2001-09-02 Thread George Schlossnagle
> In contrast, with an 11,000-line implementation like mod_gzip, it's > much less likely that other developers will be able to troubleshoot > the code quickly if it breaks while the original authors are on > vacation. A quick perusal of thesource for the 1.3 version of mod_gzip (which I've been

Re: [PATCH] Add mod_gz to httpd-2.0

2001-09-02 Thread Brian Pane
[EMAIL PROTECTED] wrote: [...] >Ryan Bloom responded... > >>I have a few problems with this. 1) We have consistantly declined to >>accept the mod_Gzip from remote communications. >> > >Correct... and for a while the reason was because everyone thought the >module was using ZLIB and there has

Re: [PATCH] Add mod_gz to httpd-2.0

2001-09-02 Thread TOKILEY
Hello all... Kevin Kiley here... Here is a mixture of comment/response regarding mod_gzip and the ongoing conversation(s)... There is a (short) SUMMARY at the bottom. Justin ErenKrantz's original post... > Ian has posted his mod_gz filter before, now I'd like to give it a +1. > > I told him I

Re: [PATCH] RE: make distclean doesn't

2001-09-02 Thread Ryan Bloom
On Sunday 02 September 2001 10:28, Jim Winstead wrote: > On Sun, Sep 02, 2001 at 01:25:07PM -0400, Cliff Woolley wrote: > > On Sun, 2 Sep 2001, William A. Rowe, Jr. wrote: > > > Which means it has nothing to do with cleaning the tree to a > > > distribution state (or state 'ready for distribution'

Re: [PATCH] Add mod_gz to httpd-2.0

2001-09-02 Thread Ryan Bloom
On Sunday 02 September 2001 11:07, Justin Erenkrantz wrote: > On Sun, Sep 02, 2001 at 12:43:09PM -0500, William A. Rowe, Jr. wrote: > > > The gzip content encoding is part of the HTTP spec. > > > > By implementation, or reference? Sure Content-encoding is part of the > > spec, and it's defined to

Re: [PATCH] Add mod_gz to httpd-2.0

2001-09-02 Thread William A. Rowe, Jr.
From: "Rodent of Unusual Size" <[EMAIL PROTECTED]> Sent: Sunday, September 02, 2001 12:02 AM > On 2001-09-01 at 20h50, possibly To [EMAIL PROTECTED] et al., > the keyboard of "Ryan Bloom" chattered: > > > > Putting every module into the core is NOT the answer to this problem. > > True. > > >

RE: [PATCH] Add mod_gz to httpd-2.0

2001-09-02 Thread Peter J. Cranstone
>> So we need any gzip filter to drop out quick if 1. it knows this mime type should not be encoded; 2. it sees the >> content-encoding is already gz; 3. it sees the uri/filename whatever in a list of exclusions (that could be >> automagically grown when it hits files that _just_don't_compress_w

Re: [PATCH] Add mod_gz to httpd-2.0

2001-09-02 Thread Justin Erenkrantz
On Sun, Sep 02, 2001 at 12:43:09PM -0500, William A. Rowe, Jr. wrote: > > The gzip content encoding is part of the HTTP spec. > > By implementation, or reference? Sure Content-encoding is part of the spec, and > it's defined to allow authors to extend their support to any number of encodings, >

Re: [PATCH] Add mod_gz to httpd-2.0

2001-09-02 Thread William A. Rowe, Jr.
From: "Greg Stein" <[EMAIL PROTECTED]> Sent: Sunday, September 02, 2001 4:43 AM > On Sat, Sep 01, 2001 at 07:50:19PM -0700, Ryan Bloom wrote: > > On Saturday 01 September 2001 18:53, Cliff Woolley wrote: > > > On Sat, 1 Sep 2001, Ryan Bloom wrote: > >... > We ship code that uses it. zlib fixes t

Re: [PATCH] RE: make distclean doesn't

2001-09-02 Thread Jim Winstead
On Sun, Sep 02, 2001 at 01:25:07PM -0400, Cliff Woolley wrote: > On Sun, 2 Sep 2001, William A. Rowe, Jr. wrote: > > Which means it has nothing to do with cleaning the tree to a > > distribution state (or state 'ready for distribution'.) > > See, I think that's the difference of interpretation he

Re: [PATCH] RE: make distclean doesn't

2001-09-02 Thread Cliff Woolley
On Sun, 2 Sep 2001, William A. Rowe, Jr. wrote: > Which means it has nothing to do with cleaning the tree to a > distribution state (or state 'ready for distribution'.) See, I think that's the difference of interpretation here. *I* interpret distclean to mean not "ready for distribution" but "b

Re: [PATCH] RE: make distclean doesn't

2001-09-02 Thread William A. Rowe, Jr.
From: "Greg Stein" <[EMAIL PROTECTED]> Sent: Sunday, September 02, 2001 3:22 AM > I use distclean on my computer all the time. Along with extraclean. Neither > of those targets should toss config.nice. *That* is what I mean. > > To be clear: nothing in our build/config/whatever should remove co

Re: [PATCH] Add mod_gz to httpd-2.0

2001-09-02 Thread William A. Rowe, Jr.
From: "Ryan Bloom" <[EMAIL PROTECTED]> Sent: Saturday, September 01, 2001 10:50 PM > On Saturday 01 September 2001 20:10, Cliff Woolley wrote: > > > > Perhaps modules distributed through official httpd subprojects are more > > visible/more trusted, but we don't really know one way or the other o

Re: [PATCH] Add mod_gz to httpd-2.0

2001-09-02 Thread Rodent of Unusual Size
Ryan Bloom wrote: > > If we don't need it in the core, it shouldn't be there. Since there is no reason to drive 100+ MPH, auto manufacturers should not make vehicles capable of going that fast. 'Needed in the core' -- what of the current modules are 'needed by the core?' Nothing in the core ne

Re: [PATCH] Add mod_gz to httpd-2.0

2001-09-02 Thread Rodent of Unusual Size
Ryan Bloom wrote: > > I believe that putting a module into the core says that we > are willing to support it, and that we believe the quality of > the module is as high as the rest of the core. With that I can certainly agree. > I would like to make that statement as few times as possible. See

Re: [PATCH] Add mod_gz to httpd-2.0

2001-09-02 Thread William A. Rowe, Jr.
From: "Jerry Baker" <[EMAIL PROTECTED]> Sent: Saturday, September 01, 2001 10:32 PM > Ryan Bloom wrote: > > > > You know what's really funny? Every time this has been brought up before, > > the Apache core has always said, if you want to have gzip'ed data, then > > gzip it when you create the

RE: [PATCH] Add mod_gz to httpd-2.0

2001-09-02 Thread Günter Knauf
Hi, > A couple of other issues. > - Netware. With a little help this can be fixed. However the I will provide any help I can give; I'm able to compile and run the module, I've compiled the debug version and have already sent an output to Kevin; the issue is that the work files are always em

RE: [PATCH] Add mod_gz to httpd-2.0

2001-09-02 Thread Peter J. Cranstone
Hi All, I think Sander sum it up nicely. - It is part of the spec. Apache should implement the spec. - Almost all new browsers support IETF content encoding/transfer encoding. In testing with MSIE 6.x and Netscape 6.1 compression works fine. - The biggest users of mod_gzip are

RE: [PATCH] Add mod_gz to httpd-2.0

2001-09-02 Thread Günter Knauf
Hi, I was glad as Ian contributed his mod_gz; I tested it on Linux and Win32 and it works for me. The problem I see with 3rd party modules is not mainly that they are 'invisible', I've found tons of modules and often 3 or more for the same purpose, but many modules were only written for Unix a

Re: [PATCH] Add mod_gz to httpd-2.0

2001-09-02 Thread Daniel Veillard
On Sat, Sep 01, 2001 at 06:19:32PM -0700, Ryan Bloom wrote: > zlib has more memory leaks than a sieve. 3) I don't believe that we > should be adding every possible module to the core distribution. I > personally think we should leave the core as minimal as possible, and > only add more modules

RE: [PATCH] Add mod_gz to httpd-2.0

2001-09-02 Thread Sander Striker
Hi, >From what I have seen on the list I am on the +1 side of adding mod_gz(ip) to the distribution. Ofcourse, my vote doesn't count since I don't have httpd commit. I find the following arguments convincing (summarized): - The gzip content encoding is part of the HTTP spec. - Most clients s

Re: cvs commit: httpd-2.0/modules/filters mod_include.c

2001-09-02 Thread Greg Stein
Very cool patch! On Sun, Sep 02, 2001 at 08:43:23AM -, [EMAIL PROTECTED] wrote: >... > +module include_module; Hmm. That needs more stuff in there. I believe it should be: module AP_MODULE_DECLARE_DATA include_module; >... > +/* Sentinel value to store in subprocess_env for items that

Re: Bandwidth control

2001-09-02 Thread Alex Stewart
Charles Randall wrote: > You may want to look at the Zeus server to understand the features > that were product-worthy as one example. It appears that they've only > implemented this at the virtual server level. Good suggestion.. I don't think it'll be any harder with my current model to impl

Re: [PATCH] Add mod_gz to httpd-2.0

2001-09-02 Thread Greg Stein
On Sat, Sep 01, 2001 at 07:50:19PM -0700, Ryan Bloom wrote: > On Saturday 01 September 2001 18:53, Cliff Woolley wrote: > > On Sat, 1 Sep 2001, Ryan Bloom wrote: >... > > > 2) I keep hearing that zlib has more memory leaks than a sieve. > > > > Maybe it does, but that can be dealt with. Even so,

Re: [PATCH] lazy evaluation to speed up mod_include

2001-09-02 Thread Justin Erenkrantz
On Sun, Sep 02, 2001 at 12:07:44AM -0700, Brian Pane wrote: > (This is a repost. My original context diffs from August 23 won't > apply cleanly to the current code base (due to changes in some adjacent > code), so I've generated this new patch against the latest version of > mod_include.c in CVS.

Re: [PATCH] RE: make distclean doesn't

2001-09-02 Thread Justin Erenkrantz
On Sun, Sep 02, 2001 at 01:22:00AM -0700, Greg Stein wrote: > I use distclean on my computer all the time. Along with extraclean. Neither > of those targets should toss config.nice. *That* is what I mean. > > To be clear: nothing in our build/config/whatever should remove config.nice +1. -- jus

Re: [PATCH] RE: make distclean doesn't

2001-09-02 Thread Greg Stein
On Fri, Aug 31, 2001 at 09:16:15PM -0700, Ryan Bloom wrote: > On Friday 31 August 2001 19:31, William A. Rowe, Jr. wrote: > > From: "Greg Stein" <[EMAIL PROTECTED]> > > Sent: Friday, August 31, 2001 9:30 PM > > > > > On Fri, Aug 31, 2001 at 03:02:32PM -0700, Ryan Bloom wrote: > > > >... > > > > ex

Re: [PATCH] Add mod_gz to httpd-2.0

2001-09-02 Thread Eli Marmor
Justin Erenkrantz wrote: > mod_gzip implements the gzip algorithm. It also happens to be a 300k > source file (~11,000 lines). mod_gz is a 14k file and is 446 lines > and relies on zlib. > > Knowing the people on this list I will bet that the size of the file > went a long way for us not accep