Re: mod_serf is in trunk

2007-11-13 Thread Jim Jagielski
On Nov 12, 2007, at 11:34 PM, Paul Querna wrote: I've added mod_serf in r594425: http://svn.apache.org/viewvc?view=revrevision=594425 I've grown exceptionally... tired of looking at mod_proxy. mod_serf is nice and tight at 440 lines or so. With just a little more work, I think it could

Re: mod_serf is in trunk

2007-11-13 Thread Jim Jagielski
On Nov 13, 2007, at 8:55 AM, Axel-Stephane SMORGRAV wrote: Just out of curiosity, how would you do this with mod_serf: ProxyPass /foo http://127.0.0.1/ ProxyPassReverse /foo http://127.0.0.1/ ProxyPassReverse /foo http://localhost/ I think the idea is that mod_serf is not intended to be

Re: mod_serf is in trunk

2007-11-13 Thread Jim Jagielski
On Nov 13, 2007, at 10:39 AM, Justin Erenkrantz wrote: I find that mod_proxy is incredibly complex and doesn't even do the things that it claims to do properly. But it does NOT do the stuff it doesn't claim to do quite well :) Agreed that mod_proxy has the potential of joining the

Re: svn commit: r594659 - /httpd/httpd/trunk/modules/proxy/mod_lbmethod_rr.c

2007-11-13 Thread Jim Jagielski
On Nov 13, 2007, at 5:11 PM, Ruediger Pluem wrote: On 11/13/2007 10:55 PM, [EMAIL PROTECTED] wrote: Author: jim Isn't this an endless loop if all workers (standby *and* not standby) are in error mode? I guess it is reasonable to return NULL in this case and let mod_proxy_balancer

Re: svn commit: r594659 - /httpd/httpd/trunk/modules/proxy/mod_lbmethod_rr.c

2007-11-13 Thread Jim Jagielski
On Nov 13, 2007, at 5:14 PM, Jim Jagielski wrote: On Nov 13, 2007, at 5:11 PM, Ruediger Pluem wrote: On 11/13/2007 10:55 PM, [EMAIL PROTECTED] wrote: Author: jim Isn't this an endless loop if all workers (standby *and* not standby) are in error mode? I guess it is reasonable

Re: svn commit: r594659 - /httpd/httpd/trunk/modules/proxy/mod_lbmethod_rr.c

2007-11-14 Thread Jim Jagielski
On Nov 14, 2007, at 4:37 AM, Paul Querna wrote: [EMAIL PROTECTED] wrote: Author: jim Date: Tue Nov 13 13:55:05 2007 New Revision: 594659 URL: http://svn.apache.org/viewvc?rev=594659view=rev Log: Add extremely butt-ugly sub-mod that exists simply to show how to use providers in sub-mods to

Re: [PROPOSAL] Adoption of mod_dns to httpd?

2007-11-14 Thread Jim Jagielski
On Nov 14, 2007, at 9:06 AM, Issac Goldstand wrote: I'd like to offer up mod_dns (http://www.beamartyr.net/mod-dns-1.02.tar.bz2) for inclusion in the httpd project (either as a mod_ftp-like subproject, or as module with the standard distribution - whatever people prefer). Can people vote for

Re: [PROPOSAL] Adoption of mod_dns to httpd?

2007-11-14 Thread Jim Jagielski
On Nov 14, 2007, at 9:17 AM, Justin Erenkrantz wrote: On Nov 14, 2007 9:06 AM, Issac Goldstand [EMAIL PROTECTED] wrote: [ ] Immediate adoption as an included module (pending IP clearance via the incubator) [X] Immediate adoption as a subproject (pending IP clearance via the incubator) -

Re: httpd/sandbox/amsterdam/d/modules/proxy/mod_serf.c?revision=595110view=markup

2007-11-15 Thread Jim Jagielski
On Nov 15, 2007, at 7:02 AM, Plüm, Rüdiger, VF-Group wrote: @@ -567,8 +567,21 @@ return APR_SUCCESS; } -if (mode == AP_MODE_EATCRLF || mode == AP_MODE_EXHAUSTIVE || -mode == AP_MODE_SPECULATIVE) { +if (mode == AP_MODE_SPECULATIVE) { +const char *data; +

Re: httpd/sandbox/amsterdam/d/modules/proxy/mod_serf.c?revision=595110view=markup

2007-11-15 Thread Jim Jagielski
On Nov 15, 2007, at 7:02 AM, Plüm, Rüdiger, VF-Group wrote: -if (APR_BRIGADE_SENTINEL(ctx-bb)) { +if (APR_BRIGADE_EMPTY(ctx-bb)) { +*len = 0; +return APR_EOF; +} + +if (APR_BUCKET_IS_EOS(APR_BRIGADE_FIRST(ctx-bb)) || +

Re: httpd/sandbox/amsterdam/d/modules/proxy/mod_serf.c?revision=595110view=markup

2007-11-15 Thread Jim Jagielski
On Nov 15, 2007, at 12:17 PM, Ruediger Pluem wrote: I don't follow that, but I'm still not quite fully awake yet... Well, as far as I understand AP_MODE_SPECULATIVE its purpose is to read data and return it to the caller, but leave the data in the input filter chain such that a following

Re: svn commit: r595464 - /httpd/httpd/branches/1.3.x/src/main/http_main.c

2007-11-15 Thread Jim Jagielski
to actually detab? Or let float... I'm 0 either way. -- === Jim Jagielski [|] [EMAIL PROTECTED] [|] http://www.jaguNET.com/ Great is the guilt of an unnecessary war ~ John Adams

Re: 2.2.7 seems to come in sight: Digest of STATUS

2007-11-15 Thread Jim Jagielski
On Nov 15, 2007, at 4:22 PM, William A. Rowe, Jr. wrote: Ruediger Pluem wrote: Now that the TR of APR / APR-UTIL is in progress (Thanks Other Bill) httpd 2.2.7 seems to come in sight. There are about 10 backport proposals in the STATUS file that are only missing one vote. So come on it is

Re: svn commit: r596670 - /httpd/httpd/branches/2.2.x/STATUS

2007-11-20 Thread Jim Jagielski
On Nov 20, 2007, at 11:54 AM, Nick Kew wrote: On Tue, 20 Nov 2007 13:54:33 - [EMAIL PROTECTED] wrote: + -0: jim (how is this related to ap_send_interim_response above?) It relies on ap_send_interim_response. Were you planning to review that? Wouldn't it be best to combine

time for 1.3.40 and 2.2.7 ?

2007-11-27 Thread Jim Jagielski
With APR now out, I think we're close to releasing 1.3.40 and 2.2.7... Anyone opposed with that gameplan?

Re: memory leak in 2.2.x balancer?

2007-11-27 Thread Jim Jagielski
On Nov 27, 2007, at 8:20 AM, Jeff Trawick wrote: looks like a leak to me; what do you think? Index: modules/proxy/mod_proxy_balancer.c === --- modules/proxy/mod_proxy_balancer.c (revision 598305) +++

Re: memory leak in 2.2.x balancer?

2007-11-27 Thread Jim Jagielski
On Nov 27, 2007, at 10:16 AM, jean-frederic clere wrote: Jeff Trawick wrote: On Nov 27, 2007 8:47 AM, Plüm, Rüdiger, VF-Group [EMAIL PROTECTED] wrote: -Ursprüngliche Nachricht- Von: Jeff Trawick Gesendet: Dienstag, 27. November 2007 14:21 An: dev@httpd.apache.org Betreff: memory

Re: memory leak in 2.2.x balancer?

2007-11-28 Thread Jim Jagielski
On Nov 28, 2007, at 3:39 AM, jean-frederic clere wrote: One of the question is should we go on using scoreboard to store the balancers and workers information or should we already add a layer to a provider that will provide all the features we need to handle the balancers and workers

Re: memory leak in 2.2.x balancer?

2007-11-28 Thread Jim Jagielski
On Nov 28, 2007, at 10:04 AM, Mladen Turk wrote: Jim Jagielski wrote: On Nov 28, 2007, at 3:39 AM, jean-frederic clere wrote: One of the question is should we go on using scoreboard to store the balancers and workers information or should we already add a layer to a provider

Re: mod_ftp's ftp_limitlogin.c

2007-12-06 Thread Jim Jagielski
I'll take an effort in addressing them... I think the issues are due to the fact that the actual updates to the doccos lagged behind changes to the codebase... Realistically, I won't have cycles until mid-nextweek On Dec 5, 2007, at 4:03 PM, William A. Rowe, Jr. wrote: There seems to be

Re: svn commit: r601843 - in /httpd/mod_ftp/trunk: STATUS include/mod_ftp.h

2007-12-06 Thread Jim Jagielski
On Dec 6, 2007, at 3:40 PM, William A. Rowe, Jr. wrote: URL: http://svn.apache.org/viewvc?rev=601843view=rev Log: Come closer to a release by backing-up the version from Covalent- numbering series to an ASF numbering series, and prepare for the first GA release to be numbered 1.0.0.

http://svn.apache.org/viewvc?view=revrevision=602469

2007-12-08 Thread Jim Jagielski
I didn't see this patch in the commit list but did see it referred to in the 2.2 STATUS file... I'm reviewing the patch now but two things did stick out: -apr_brigade_cleanup(ctx-ctxbb); -APR_BUCKET_REMOVE(b); -APR_BRIGADE_INSERT_TAIL(passbb, b); -

Re: svn commit: r602485 - /httpd/httpd/branches/2.2.x/STATUS

2007-12-08 Thread Jim Jagielski
On Dec 8, 2007, at 10:44 AM, [EMAIL PROTECTED] wrote: +niq: You're missing my point. That this patch fixes a bug is + perfectly clear. But it does so by allocating (AP_IOBUFSIZE+1) + bytes. My point: isn't that likely to be horribly inefficient + if

Re: Enable persistence for SSL connections to the backend for reverse proxy

2007-12-08 Thread Jim Jagielski
On Dec 8, 2007, at 9:38 AM, Ruediger Pluem wrote: Thoughts, comments? A *real quick* review But so far, I see no issues (not tested yet though :) ) +1 +static apr_status_t socket_cleanup(proxy_conn_rec *conn) +{ +if (conn-sock) { +apr_socket_close(conn-sock); +

Re: Memory consumption of mod_substitute

2007-12-08 Thread Jim Jagielski
On Dec 7, 2007, at 7:09 AM, Plüm, Rüdiger, VF-Group wrote: -Ursprüngliche Nachricht- Von: [EMAIL PROTECTED] Gesendet: Freitag, 7. Dezember 2007 11:24 An: dev@httpd.apache.org Betreff: Re: Memory consumption of mod_substitute On Dec 5, 2007 8:36 AM, Plüm, Rüdiger, VF-Group [EMAIL

Re: http://svn.apache.org/viewvc?view=revrevision=602469

2007-12-08 Thread Jim Jagielski
On Dec 8, 2007, at 11:39 AM, Ruediger Pluem wrote: The reason why the current code handles FLUSH separately is though, yes, the ap_pass_brigade is done at the end of the while loop, that is *only* done when we're done handling the full brigade... The intent was to honor flushes in the brigade

Re: http://svn.apache.org/viewvc?view=revrevision=602469

2007-12-08 Thread Jim Jagielski
On Dec 8, 2007, at 11:39 AM, Ruediger Pluem wrote: In fact the patch does all this as it passes the passbb brigade down the chain after *each* processed bucket of the original brigade (the ap_pass_brigade is at *the end* of the while loop *not* after the while loop). I didn't catch that when

Re: Memory consumption of mod_substitute

2007-12-08 Thread Jim Jagielski
On Dec 5, 2007 8:36 AM, Plüm, Rüdiger, VF-Group [EMAIL PROTECTED] wrote: * My test case lead to the exceptional situation of a very large passbb bucket brigade (about 1,000,000 buckets) as a result of processing 4 MB of the file. So I add a flush bucket once I have more than

Re: Memory consumption of mod_substitute

2007-12-08 Thread Jim Jagielski
On Dec 8, 2007, at 2:31 PM, Ruediger Pluem wrote: On 12/08/2007 07:41 PM, Jim Jagielski wrote: On Dec 5, 2007 8:36 AM, Plüm, Rüdiger, VF-Group [EMAIL PROTECTED] wrote: * My test case lead to the exceptional situation of a very large passbb bucket brigade (about 1,000,000 buckets

Re: Enable persistence for SSL connections to the backend for reverse proxy

2007-12-08 Thread Jim Jagielski
On Dec 8, 2007, at 2:47 PM, Ruediger Pluem wrote: Index: modules/proxy/mod_proxy_http.c +if (is_ssl) { +ap_proxy_ssl_connection_cleanup(backend, r); +} + /* Step One: Determine Who To Connect To */ if ((status = ap_proxy_determine_connection(p, r, conf, worker,

Re: Enable persistence for SSL connections to the backend for reverse proxy

2007-12-08 Thread Jim Jagielski
On Dec 8, 2007, at 2:47 PM, Ruediger Pluem wrote: BTW: I have not tested with FTP proxing so far. By the by, found a few cycles to test the patch as is... so far, I see no issues... So +1 for folding it into -trunk and we'll address anything that may pop up in there :)

Re: time for 1.3.40 and 2.2.7 ?

2007-12-10 Thread Jim Jagielski
On Dec 9, 2007, at 10:30 AM, Ruediger Pluem wrote: On 12/08/2007 04:04 PM, Ruediger Pluem wrote: On 11/27/2007 07:26 PM, Jim Jagielski wrote: With APR now out, I think we're close to releasing 1.3.40 and 2.2.7... Anyone opposed with that gameplan? There are 9 backport proposals

Re: svn commit: r603502 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2007-12-12 Thread Jim Jagielski
On Dec 12, 2007, at 6:16 AM, Plüm, Rüdiger, VF-Group wrote: The connection memory pool was a different memory pool before. It was the memory pool of the front end connection. Now it is the memory pool of the backend connection pool connection. See also

Re: svn commit: r603502 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2007-12-12 Thread Jim Jagielski
On Dec 12, 2007, at 8:06 AM, Plüm, Rüdiger, VF-Group wrote: -Ursprüngliche Nachricht- Von: Jim Jagielski [mailto:[EMAIL PROTECTED] Gesendet: Mittwoch, 12. Dezember 2007 13:59 An: dev@httpd.apache.org Betreff: Re: svn commit: r603502 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

Re: time for 1.3.40 and 2.2.7 ?

2007-12-14 Thread Jim Jagielski
Anyone opposed to us shooting for a TR early next week? I offer to RM

Re: time for 1.3.40 and 2.2.7 ?

2007-12-14 Thread Jim Jagielski
On Dec 14, 2007, at 12:52 PM, William A. Rowe, Jr. wrote: Jim Jagielski wrote: Anyone opposed to us shooting for a TR early next week? If we can get a couple of security-related-but-not-really patches committed to 2.0 I'd like to see that as well. I'm offering, Sure... that would

Re: proxy returning apr_status_t to handler?

2007-12-17 Thread Jim Jagielski
On Dec 17, 2007, at 11:20 AM, Jeff Trawick wrote: On Dec 17, 2007 10:27 AM, Nick Kew [EMAIL PROTECTED] wrote: On Mon, 17 Dec 2007 10:22:02 -0500 Eric Covener [EMAIL PROTECTED] wrote: Thanks; Any particular concerns about the generic fix for 2.0.x? Haven't looked, but if it applies

Re: Integrity of Apache source code

2007-12-18 Thread Jim Jagielski
On Dec 17, 2007, at 6:22 PM, Andrew Beverley wrote: Hi, I hope that this is the correct mailing list for this question, and that you can easily provide a quick response. I am currently working within the UK Ministry of Defence, and am trying to get Apache web server accredited as

Re: [PATCH] Bug 36816: balancer_manager doesn't work if worker name contains port

2005-10-11 Thread Jim Jagielski
On Oct 10, 2005, at 5:13 PM, Ruediger Pluem wrote: On 10/10/2005 05:43 PM, Jim Jagielski wrote: For consideration: [..cut..] Thanks for your thoughts. BTW: It was a little bit tricky to apply the patch as my Mozilla seems to have changed things in the mail spaces / empty lines. So I

Re: [PATCH] Bug 36816: balancer_manager doesn't work if worker name contains port

2005-10-11 Thread Jim Jagielski
On Oct 10, 2005, at 5:13 PM, Ruediger Pluem wrote: 2. The xml output is currently broken as it only works with schema and hostname. I am not quite sure if 1. there is an xml schema already defined for this and needs to be adjusted 2. we need to parse the worker name and replace

Re: [PATCH] Bug 36816: balancer_manager doesn't work if worker name contains port

2005-10-11 Thread Jim Jagielski
On Oct 11, 2005, at 3:13 PM, Ruediger Pluem wrote: Sorry, too impatient again :-(. Nevertheless apart from the xml stuff, any comments about the latest version of the patch I attached yesterday? +1... I haven't looked to see if there's a better way to do the 'longest match' test, but

Re: [PATCH] Bug 36816: balancer_manager doesn't work if worker name

2005-10-11 Thread Jim Jagielski
Ruediger Pluem wrote: On 10/11/2005 09:56 PM, Jim Jagielski wrote: [..cut..] +1... I haven't looked to see if there's a better way to do the 'longest match' test, but that's nit picking :) Ok, thanks. I think I will commit it tomorrow to trunk and 2.2.x. I can do

Re: [PATCH] Bug 36816: balancer_manager doesn't work if worker name

2005-10-11 Thread Jim Jagielski
, but rarely :) -- === Jim Jagielski [|] [EMAIL PROTECTED] [|] http://www.jaguNET.com/ If you can dodge a wrench, you can dodge a ball.

Re: [PATCH] Bug 36816: balancer_manager doesn't work if worker name

2005-10-11 Thread Jim Jagielski
Ruediger Pluem wrote: On 10/11/2005 11:51 PM, Jim Jagielski wrote: I hate IRC. It's a real time sinkhole :) Plus, it avoids the danger of doing development on IRC instead of on the mailing lists where it belongs... I occasionally am on IM and IRC however, but rarely

Re: Notice of Intent: TR 1.3.34

2005-10-12 Thread Jim Jagielski
On Oct 11, 2005, at 11:48 PM, Glenn Strauss wrote: May I humbly request inclusion of a patch I wrote almost a year ago? http://issues.apache.org/bugzilla/show_bug.cgi?id=31858 |31858|New|Maj|2004-10-22|regular expression matching broken on amd64 It is not a feature request; it fixes a

Re: svn commit: r320832 - /httpd/httpd/branches/1.3.x/Announcement

2005-10-13 Thread Jim Jagielski
Announcement, and did not see anywhere in the Unix build which copied it to the install path. Bill -- === Jim Jagielski [|] [EMAIL PROTECTED] [|] http://www.jaguNET.com/ If you can dodge a wrench, you can

Apache HTTP Server 1.3.34 prerelease tarballs

2005-10-13 Thread Jim Jagielski
Look for the Apache HTTP Server 1.3.34 prerelease tarballs in: http://httpd.apache.org/dev/dist/ Please test :)

Re: 1.3 downloads broken

2005-10-17 Thread Jim Jagielski
Argf. I am planning on releasing late today or early tomorrow, btw On Oct 16, 2005, at 1:32 PM, Joshua Slive wrote: The download.cgi got updated to 1.3.34 before the release, so all 1.3 downloads are now broken (unless the downloader clicks on other files and goes exploring). I don't have

Re: [PATCH] PR37145: data loss with httpd-2.0.55 reverse proxy method=post

2005-10-21 Thread Jim Jagielski
vote as soon as you update STATUS :) -- === Jim Jagielski [|] [EMAIL PROTECTED] [|] http://www.jaguNET.com/ If you can dodge a wrench, you can dodge a ball.

Re: [PATCH] PR37145: data loss with httpd-2.0.55 reverse proxy method=post

2005-10-21 Thread Jim Jagielski
the same as a vote by a PMC member, but it cannot be simply discounted. -- === Jim Jagielski [|] [EMAIL PROTECTED] [|] http://www.jaguNET.com/ If you can dodge a wrench, you can dodge a ball.

Re: The 2.2.0 Process

2005-10-24 Thread Jim Jagielski
I agree with Jeff. The time between Beta and GM should ideally by longer that several days (depending on how you define several :) ). With 2.2, we should consider such terms as release candidate and make things easier for us and the community as well. So the process is: -dev - Beta - RC - GA

Re: [vote] 2.1.9 as beta

2005-10-31 Thread Jim Jagielski
There is a semi-known issue with the balancer code which mistakenly does a case-insensitive match on worker and URL. I have a patch that will be applied today. Not a show-stopper, IMO, but something that will need to be fixed :) On Oct 30, 2005, at 12:09 AM, Paul Querna wrote: 2.1.9-Beta is

Re: svn commit: r329849 - in /httpd/httpd/trunk: CHANGES modules/proxy/proxy_util.c

2005-11-01 Thread Jim Jagielski
; } worker++; } return max_worker; } Regards Rüdiger -- === Jim Jagielski [|] [EMAIL PROTECTED] [|] http://www.jaguNET.com/ If you can dodge a wrench, you can dodge a ball.

Re: svn commit: r329849 - in /httpd/httpd/trunk: CHANGES modules/proxy/proxy_util.c

2005-11-01 Thread Jim Jagielski
oriented solution. Ruediger Pluem wrote: On 11/01/2005 02:05 PM, Jim Jagielski wrote: I wanted to avoid making string copies when possible. Plus, we Ok. That was one point of my question as I saw the need to copy the string as a drawback compared to your approach. I was only unsure how

Re: svn commit: r329849 - in /httpd/httpd/trunk: CHANGES modules/proxy/proxy_util.c

2005-11-01 Thread Jim Jagielski
Ruediger Pluem wrote: On 11/01/2005 02:27 PM, Jim Jagielski wrote: Since this happens for each request, doing a string copy seems wasteful to me; it's extra overhead that is avoided with the current impl. Instead, we have an extra assignment and check, which is less expensive

Re: svn commit: r329849 - in /httpd/httpd/trunk: CHANGES modules/proxy/proxy_util.c

2005-11-01 Thread Jim Jagielski
, but lowering explicitly is done *outside* the for loop. strncasecmp is done *inside* the for loop. So we do this via strncasecmp multiple times on the same data. Whatever. Change it then. -- === Jim Jagielski

Re: svn commit: r329849 - in /httpd/httpd/trunk: CHANGES modules/proxy/proxy_util.c

2005-11-01 Thread Jim Jagielski
), which means requiring scheme://host is bogus. The current code does make that restriction, but yes, it may be too limiting... Of course, this means that the workers would also need to be not so restricted as well :) -- === Jim

Re: svn commit: r329849 - in /httpd/httpd/trunk: CHANGES modules/proxy/proxy_util.c

2005-11-01 Thread Jim Jagielski
Ruediger, would the below appease your sensibilities :) Index: modules/proxy/proxy_util.c === --- modules/proxy/proxy_util.c(revision 329779) +++ modules/proxy/proxy_util.c(working copy) @@ -1217,13 +1217,33 @@ int

Re: Head's Up: tab - space cleanup

2005-11-10 Thread Jim Jagielski
On Nov 10, 2005, at 8:56 AM, Colm MacCarthaigh wrote: On Thu, Nov 10, 2005 at 08:27:49AM -0500, Jim Jagielski wrote: Just a FYI that I'll be performing a TAB-8-SPACE cleanup on all the .c files in both httpd-trunk and httpd-2.2. We've gotten sloppy as far as that's concerned and we might

Re: Head's Up: tab - space cleanup

2005-11-10 Thread Jim Jagielski
William A. Rowe, Jr. wrote: Jim Jagielski wrote: Just a FYI that I'll be performing a TAB-8-SPACE cleanup on all the .c files in both httpd-trunk and httpd-2.2. We've gotten sloppy as far as that's concerned and we might as well bite the bullet and do the fixes now :) I noticed you

More code cleanups...

2005-11-10 Thread Jim Jagielski
In the Netware, OS2 and Win sections, there is prevalent use of '//' commenting... Should we convert them to real C comment style?

Re: ap_get_server_port differences

2005-11-13 Thread Jim Jagielski
... This is, I believe, still the right way to go, esp now since it requires an API change for 2.1/2.2/2.3. In fact, I think I still have the patch around here for that. -- === Jim Jagielski [|] [EMAIL PROTECTED] [|] http

Re: ap_get_server_port differences

2005-11-13 Thread Jim Jagielski
will affect those who are already using it... instead, we should provide both elements of functionality. -- === Jim Jagielski [|] [EMAIL PROTECTED] [|] http://www.jaguNET.com/ If you can dodge a wrench, you can

Re: ap_get_server_port differences

2005-11-14 Thread Jim Jagielski
I am thinking about something like the below: Index: server/core.c === --- server/core.c (revision 344120) +++ server/core.c (working copy) @@ -115,6 +115,7 @@ conf-accept_path_info = 3; conf-use_canonical_name

Re: ap_get_server_port differences

2005-11-14 Thread Jim Jagielski
On Nov 14, 2005, at 3:51 PM, Ruediger Pluem wrote: On 11/14/2005 03:49 PM, Jim Jagielski wrote: I am thinking about something like the below: As far as I understand the patch the default value will be UseCanonicalPhysicalPort off which is the 2.0 behaviour, correct? If yes, +1 from my

Re: svn commit: r344369 - in /httpd/httpd/trunk: ./ docs/manual/

2005-11-15 Thread Jim Jagielski
. -- === Jim Jagielski [|] [EMAIL PROTECTED] [|] http://www.jaguNET.com/ If you can dodge a wrench, you can dodge a ball.

Re: svn commit: r344416 - in /httpd/httpd/branches/2.2.x: CHANGES

2005-11-15 Thread Jim Jagielski
in the UseCanonicalPhysicalPort code, along with the docs changes (just source currently) This removes the showstopper, right? -- justin -- === Jim Jagielski [|] [EMAIL PROTECTED] [|] http://www.jaguNET.com/ If you can

Re: Small cleanup in /modules/mappers/mod_negotiation.c, in function

2005-11-20 Thread Jim Jagielski
log entry. So another comment please! In general, CHANGES is for any change/fix/addition which is user observable or significant enough to be brought out. Otherwise, it's being used as a substitute for svn log. -- === Jim

Re: [VOTE] 2.1.10 as GA

2005-11-20 Thread Jim Jagielski
community re-roll as GA. I would suggest: 2.1.10 as RC1 for 2.2.0 Release and announce it as such Get Feedback. THEN decide on whether it is GA -- === Jim Jagielski [|] [EMAIL PROTECTED] [|] http://www.jaguNET.com

Re: [VOTE] 2.1.10 as GA

2005-11-21 Thread Jim Jagielski
On Nov 20, 2005, at 1:51 PM, Justin Erenkrantz wrote: On Sun, Nov 20, 2005 at 08:48:20AM -0500, Jim Jagielski wrote: -1 for GA. We should have 2.1.10 as beta for at least a week, possibly 2, note it as a RC to the general public and the, after significant feedback from the user community re

Re: httpd-2.1.7 Connection-pooling Problem w/ ReverseProxy, Loadbalancer

2005-11-21 Thread Jim Jagielski
Thanks for the report: You said that you tested against 2.1.10-HEAD right? On Nov 21, 2005, at 10:25 AM, Hansjoerg Pehofer wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, I briefly tried httpd-2.1.10 today and still see this. (Same httpd.conf, only changed ServerRoot to

Re: Need for a Release Candidate status

2005-11-22 Thread Jim Jagielski
. Plus, as I've stated before, it adds a good procedure to our evolving release structure. -- === Jim Jagielski [|] [EMAIL PROTECTED] [|] http://www.jaguNET.com/ If you can dodge a wrench, you can dodge a ball.

Re: Need for a Release Candidate status

2005-11-22 Thread Jim Jagielski
of other communities; it is useful information. I don't feel strongly enough about it to try to push it anymore than I've already done, but if we were to do it, then now would be the time, and so I brought it up. -- === Jim Jagielski

Re: httpd-2.1.7 Connection-pooling Problem w/ ReverseProxy, Loadbalancer

2005-11-23 Thread Jim Jagielski
It seems to me that is_address_reusable should be assumed to be 0 if either (r-proxyreq == PROXYREQ_PROXY || r-proxyreq == PROXYREQ_REVERSE) As mentioned, we go ahead and force close the socket anyway, the problem is that conn-hostname still points to the wrong element. So: if

Re: httpd-2.1.7 Connection-pooling Problem w/ ReverseProxy, Loadbalancer

2005-11-23 Thread Jim Jagielski
Ruediger Pluem wrote: On 11/23/2005 06:11 PM, Jim Jagielski wrote: It seems to me that is_address_reusable should be assumed to be 0 if either (r-proxyreq == PROXYREQ_PROXY || r-proxyreq == PROXYREQ_REVERSE) As mentioned, we go ahead and force close the socket Does

Re: [vote] 2.2.0 tarballs

2005-11-29 Thread Jim Jagielski
-- === Jim Jagielski [|] [EMAIL PROTECTED] [|] http://www.jaguNET.com/ If you can dodge a wrench, you can dodge a ball.

Re: httpd-2.1.7 Connection-pooling Problem w/ ReverseProxy, Loadbalancer

2005-11-29 Thread Jim Jagielski
Can you try HEAD on httpd-trunk for a fix until something more robust as far as the connections are implemented...

Re: [vote] 2.2.0 tarballs

2005-11-29 Thread Jim Jagielski
refering to mod_dbd as something special enough to warrant special attention as a core enhancement or we fix it so it *is* one. -- === Jim Jagielski [|] [EMAIL PROTECTED] [|] http://www.jaguNET.com/ If you can

Re: [vote] 2.2.0 tarballs

2005-11-29 Thread Jim Jagielski
Justin Erenkrantz wrote: On Tue, Nov 29, 2005 at 10:16:04AM -0500, Jim Jagielski wrote: mod_dbd is explicitly mentioned as a new feature of 2.2 and, therefore, a compelling reason to upgrade. Either we stop refering to mod_dbd as something special enough to warrant special attention

Re: [vote] 2.2.0 tarballs

2005-11-29 Thread Jim Jagielski
On Nov 29, 2005, at 2:55 AM, Paul Querna wrote: These tarballs are Identical to 2.1.10 except for two changes: * include/ap_release.h Updated to be 2.2.0-release * The root directory was changed from httpd-2.1.10 to httpd-2.2.0 Available from:

Re: [vote] 2.2.0 tarballs

2005-11-29 Thread Jim Jagielski
On Nov 29, 2005, at 10:36 AM, Justin Erenkrantz wrote: On Tue, Nov 29, 2005 at 10:28:43AM -0500, Jim Jagielski wrote: I would agree, as long as we remove it for the What's New pages until it actually works and builds. My point, obviously, was that we can't have it both ways and say mod_dbd

Re: [vote] 2.2.0 tarballs

2005-11-29 Thread Jim Jagielski
Joe Orton wrote: On Tue, Nov 29, 2005 at 10:28:43AM -0500, Jim Jagielski wrote: Justin Erenkrantz wrote: On Tue, Nov 29, 2005 at 10:16:04AM -0500, Jim Jagielski wrote: mod_dbd is explicitly mentioned as a new feature of 2.2 and, therefore, a compelling reason to upgrade. Either

Re: [vote] 2.2.0 tarballs

2005-11-29 Thread Jim Jagielski
Justin Erenkrantz wrote: On Tue, Nov 29, 2005 at 10:46:55AM -0500, Jim Jagielski wrote: Either we: 1. Remove it from the feature list 2. Keep it in there, but document that it doesn't build under Win32 3. Someone who knows Win32 adds whatever magic is required

Re: httpd-2.1.7 Connection-pooling Problem w/ ReverseProxy,

2005-11-30 Thread Jim Jagielski
Ahh... no doubt conn-hostname is NULL Hansjoerg Pehofer wrote: Jim Jagielski [EMAIL PROTECTED] writes: Can you try HEAD on httpd-trunk for a fix until something more robust as far as the connections are implemented... It gets the backend-connections right, but segfaults in the new

Re: httpd-2.1.7 Connection-pooling Problem w/ ReverseProxy, Loadbalancer

2005-11-30 Thread Jim Jagielski
On Nov 29, 2005, at 4:55 PM, Ruediger Pluem wrote: On 11/29/2005 04:12 PM, Jim Jagielski wrote: Can you try HEAD on httpd-trunk for a fix until something more robust as far as the connections are implemented... Just for convenience: http://svn.apache.org/viewcvs?rev=349723view=rev Has

Re: Press release for httpd 2.2 (was Re: OT: performance FUD)

2005-11-30 Thread Jim Jagielski
... :) -- === Jim Jagielski [|] [EMAIL PROTECTED] [|] http://www.jaguNET.com/ If you can dodge a wrench, you can dodge a ball.

Re: httpd-2.1.7 Connection-pooling Problem w/ ReverseProxy, Loadbalancer

2005-12-01 Thread Jim Jagielski
On Nov 30, 2005, at 4:30 PM, Ruediger Pluem wrote: I believe the clearer approach would be to fetch the connection from the connection pool each time and do not use this module config method any longer. This would also resolve the problem of Hans-Joerg which you fixed with your recent

Re: [Fwd: [EMAIL PROTECTED] [announce] Apache HTTP Server 2.2.0 Released]

2005-12-01 Thread Jim Jagielski
still feel very happy and proud for this major release. -- === Jim Jagielski [|] [EMAIL PROTECTED] [|] http://www.jaguNET.com/ If you can dodge a wrench, you can dodge a ball.

Re: [Fwd: [EMAIL PROTECTED] [announce] Apache HTTP Server 2.2.0 Released]

2005-12-01 Thread Jim Jagielski
Brian Akins wrote: William A. Rowe, Jr. wrote: ++1! On to 2.4 :) you mean X right? :) How about dropping numbers totally and using colors? Apache HTTP Server Green :) -- === Jim Jagielski [|] [EMAIL

Re: [Fwd: [EMAIL PROTECTED] [announce] Apache HTTP Server 2.2.0 Released]

2005-12-01 Thread Jim Jagielski
William A. Rowe, Jr. wrote: Jim Jagielski wrote: I know I'm beating a dead horse here, but I still don't understand the reason for such a rushed release, when an extra few days would likely have resolved them... Because it's httpd-dev tradition, .0 releases are never ready, and most

Re: What do you want in HTTPD 2.4/3.0/X/GREEN?

2005-12-03 Thread Jim Jagielski
us improve other protocol handlers like mod_ftp and mod_smtpd. :) -- === Jim Jagielski [|] [EMAIL PROTECTED] [|] http://www.jaguNET.com/ If you can dodge a wrench, you can dodge a ball.

Re: Making MPMs DSOs

2005-12-03 Thread Jim Jagielski
. -- === Jim Jagielski [|] [EMAIL PROTECTED] [|] http://www.jaguNET.com/ If you can dodge a wrench, you can dodge a ball.

Re: 2.2 mod_http_proxy and partial pages

2005-12-06 Thread Jim Jagielski
On Dec 6, 2005, at 9:29 AM, Brian Akins wrote: I have a serious issue. It seems that if something happens during a proxy request after mod_http_proxy starts reading from the backend server, no error is reported. (IE, see what happens when ap_pass_brigade returns non success). The

Re: 2.2 mod_http_proxy and partial pages

2005-12-06 Thread Jim Jagielski
Brian Akins wrote: Jim Jagielski wrote: Hmmm. I haven't taken a look yet, but is seems to me that only complete responses should be cached, not partial, and as such we need some better mechanism in place for that Not Cache-able, Could be Cache-able and To-Be-Cached state tree

Re: 2.2 mod_http_proxy and partial pages

2005-12-06 Thread Jim Jagielski
to first abort the connection and then set that field. =) -- justin +1 to setting c-aborted to 1 in this case. -- === Jim Jagielski [|] [EMAIL PROTECTED] [|] http://www.jaguNET.com/ If you can dodge

Re: 2.2 mod_http_proxy and partial pages

2005-12-06 Thread Jim Jagielski
Brian Akins wrote: Justin Erenkrantz wrote: I do think we need to fix mod_proxy_http to return an error. So we need my patch and your patch, right? I'm a little medicated today... Yes, both. -- === Jim

Re: 2.2 mod_http_proxy and partial pages

2005-12-06 Thread Jim Jagielski
Brian Akins wrote: Jim Jagielski wrote: So we need my patch and your patch, right? I'm a little medicated today... Yes, both. Can we vote on this? I guess we do it for HEAD then for 2.2.1 (or something like that)? Just want to make sure this will make into stock code

Re: 2.2 mod_http_proxy and partial pages

2005-12-06 Thread Jim Jagielski
, but I can concur that it looks good. As Roy indicates, we may need to tweak this to return a 503 depending on the actual state of the proxied connection/response, but this is still looking v good. -- === Jim Jagielski [|] [EMAIL

Re: 2.2 mod_http_proxy and partial pages

2005-12-06 Thread Jim Jagielski
thinking about offering to be 2.2.1 RM... -- === Jim Jagielski [|] [EMAIL PROTECTED] [|] http://www.jaguNET.com/ If you can dodge a wrench, you can dodge a ball.

Re: 2.2 mod_http_proxy and partial pages

2005-12-06 Thread Jim Jagielski
Ruediger Pluem wrote: On 12/06/2005 10:53 PM, Jim Jagielski wrote: [..cut..] Well, there's an issue with the proxy balancer that needs to be addressed as well 1st, imo. Could you please give my memory a small hint what this issue is? Keepalives and multiple workers

<    1   2   3   4   5   6   7   8   9   10   >