Re: Moving to git?

> There is only one good rule though - no merge commmits in the history :) Ever. Do whatever you want beyond that. A clean, simple history for each branch is the only sensible use of Git I've seen. +1 > > - Mark > > > On Sat, May 30, 2015 at 9:00 AM Adrien Grand wrote: >> >> The main benefit I s

[JENKINS] Lucene-Solr-5.x-Windows (64bit/jdk1.7.0_80) - Build # 4755 - Failure!

Build: http://jenkins.thetaphi.de/job/Lucene-Solr-5.x-Windows/4755/ Java: 64bit/jdk1.7.0_80 -XX:-UseCompressedOops -XX:+UseParallelGC 1 tests failed. FAILED: org.apache.solr.search.mlt.CloudMLTQParserTest.test Error Message: java.lang.String cannot be cast to java.util.ArrayList Stack Trace: ja

[JENKINS] Lucene-Solr-5.x-Linux (64bit/jdk1.8.0_60-ea-b12) - Build # 12716 - Failure!

Build: http://jenkins.thetaphi.de/job/Lucene-Solr-5.x-Linux/12716/ Java: 64bit/jdk1.8.0_60-ea-b12 -XX:+UseCompressedOops -XX:+UseParallelGC 1 tests failed. FAILED: org.apache.solr.search.TestSearcherReuse.test Error Message: expected same: was not: Stack Trace: java.lang.AssertionError: expect

Re: Moving to git?

Hmmm. I pulled up this file in IntelliJ in my git checkout and viewed the history. It went back to March 17th 2010 (earlier than the 2012 you found) with git hash 3ee0ace1ba6b9bff3ffaa278c0bba07e6064057dwith a commit message of: git-svn-id: https://svn.apache.org/repos/asf/lucene/solr/branche

[jira] [Updated] (SOLR-7465) Flesh out solr/example/files

[ https://issues.apache.org/jira/browse/SOLR-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Esther Quansah updated SOLR-7465: - Attachment: SOLR-7465.patch Updated README - close to final. Edited FAQs, adjusted for new internat

[JENKINS] Lucene-Solr-Tests-trunk-Java8 - Build # 30 - Failure

Build: https://builds.apache.org/job/Lucene-Solr-Tests-trunk-Java8/30/ 1 tests failed. REGRESSION: org.apache.solr.cloud.TestRebalanceLeaders.test Error Message: No live SolrServers available to handle this request:[http://127.0.0.1:41068, http://127.0.0.1:52980, http://127.0.0.1:42251, http://

[jira] [Commented] (SOLR-7406) Support DV implementation in range faceting

[ https://issues.apache.org/jira/browse/SOLR-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566875#comment-14566875 ] Gregg Donovan commented on SOLR-7406: - Thanks, Tomás! > Support DV implementation in r

Re: [VOTE] 5.2.0 RC3

+1 SUCCESS! [0:22:21.631757] Steve On Sun, May 31, 2015 at 4:51 PM, Anshum Gupta wrote: > Please vote for the third release candidate for Apache Lucene/Solr 5.2.0. > > The artifacts can be downloaded from: > > https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-5.2.0-RC3-rev1682753 > >

[jira] [Updated] (SOLR-7124) Add "delconfig" command to zkcli

[ https://issues.apache.org/jira/browse/SOLR-7124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xu Zhang updated SOLR-7124: --- Attachment: SOLR-7124.patch Here is a quick implementation. When deleting configset, will check if any collect

Re: Moving to git?

And here is IndexWriter with initial revision in 2001, but again git still only stops at Feb 7, 2012. http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java?view=log Revision 149570 - (view) (download) (annotate) - [select for diffs] Added Tue S

Re: Moving to git?

On Sun, May 31, 2015 at 4:39 PM, david.w.smi...@gmail.com wrote: > > If we were to come up with a new git repo that doesn’t have the ‘.jar’s, > it’d be good to also streamline the history prior to the big Lucene + Solr > merge due to the paths in source control as to where the trunk, branches, > a

Re: Moving to git?

Regarding history, if we switch to git, our history will remain in svn, even if the branches are deleted, the history and old revisions are still there. Upayavira On Sun 2015, at 10:48 PM, Mark Miller wrote: > Having to agree on mechanics certainly is a downside of Git. > > There is only one goo

Re: Moving to git?

Having to agree on mechanics certainly is a downside of Git. There is only one good rule though - no merge commmits in the history :) Ever. Do whatever you want beyond that. A clean, simple history for each branch is the only sensible use of Git I've seen. - Mark On Sat, May 30, 2015 at 9:00 AM

Re: Moving to git?

I'm all for a small download size in all things, but personally, I download Git repos for a project about 1/20th as often as I download svn checkouts (one of the things I prefer about my Git usage) and I have fast internet. Not a sore spot here. - Mark On Sun, May 31, 2015 at 5:38 PM Steve Davids

Re: Moving to git?

There are also some rather large '.dat' files in the history as well, I found this by running on a job to delete all blobs > 5MB from the history via: $ java -jar ~/Downloads/bfg-1.12.3.jar --strip-blobs-bigger-than 5M --protect-blobs-from trunk,branch_5x,branch_4x lucene-solr-mirror > Deleted fi

[jira] [Commented] (LUCENE-6508) Simplify Directory/lock api

[ https://issues.apache.org/jira/browse/LUCENE-6508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566743#comment-14566743 ] Robert Muir commented on LUCENE-6508: - {quote} I wonder if we even need to pass a loc

[VOTE] 5.2.0 RC3

Please vote for the third release candidate for Apache Lucene/Solr 5.2.0. The artifacts can be downloaded from: https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-5.2.0-RC3-rev1682753 You can run the smoke tester directly with this command: python3 -u dev-tools/scripts/smokeTestRelease.p

Re: Moving to git?

I like where this is going! I also think history of source code is very important, but not history of ‘.jar’ files that shouldn’t have been in source control in the first place. I’m fiercely negative about large binaries or ‘jar’ files that can be downloaded by the build system (e.g. ivy) in sour

Re: Moving to git?

> I'd like to have full consolidated history, as much as possible, > connect-the-dots across whatever CVS/SVN/etc repos to the extent > maximally permitted by law, as Doug hints at. Just nuke the jars. I've done this (CVS->SVN->GIT) before. It wasn't that difficult. Eventually (for git) you script

Re: Moving to git?

On Sun, May 31, 2015 at 3:53 PM, Dawid Weiss wrote: >> Losing the jars would have a cost: those old >> branches wouldn't "work" out of box if you wanted to run tests on > > Yeah, I'd rather not have them at all than have them filtered and > crippled. It'll be confusing. > But my argument is that

Re: Moving to git?

> Losing the jars would have a cost: those old > branches wouldn't "work" out of box if you wanted to run tests on Yeah, I'd rather not have them at all than have them filtered and crippled. It'll be confusing. There's nothing wrong in preserving the SVN history (or even a full git import from SV

Re: Moving to git?

You just made my day with that CVS repo! :) Though I don't really get a vote -- +1 to your plan Robert. /polishes history degree -Doug On Sun, May 31, 2015 at 3:16 PM, Robert Muir wrote: > I totally agree Doug. Losing the jars would have a cost: those old > branches wouldn't "work" out of box

Re: Moving to git?

I totally agree Doug. Losing the jars would have a cost: those old branches wouldn't "work" out of box if you wanted to run tests on them. But I am not sure how bad that cost really is. It might be zero. I havent tried to run e.g. lucene 2.x tests with a modern java 7 or java 8, but i bet they pro

Re: Moving to git?

I have no dog in the svn vs git debate honestly. I want to say how important it is to keep healthy history. I recently went on a bit of code archeology dig recently to figure out why something in Lucene was done the way it was. It was handy that the history went as far back as it did, but I had to

Re: Moving to git?

On Sun, May 31, 2015 at 2:32 PM, Dawid Weiss wrote: > Yeah, but it misses the point -- history is history, if there were > jars in it, you shouldn't just strip them, it'd be confusing. > > How was it back when Lucene was merging with Solr? Didn't it just > initiate with a new clean repo? Maybe not

Re: Moving to git?

Yeah, but it misses the point -- history is history, if there were jars in it, you shouldn't just strip them, it'd be confusing. How was it back when Lucene was merging with Solr? Didn't it just initiate with a new clean repo? Maybe not all of the history is really needed -- if we limited ourselve

[JENKINS] Lucene-Solr-trunk-Linux (64bit/jdk1.8.0_60-ea-b12) - Build # 12887 - Failure!

Build: http://jenkins.thetaphi.de/job/Lucene-Solr-trunk-Linux/12887/ Java: 64bit/jdk1.8.0_60-ea-b12 -XX:+UseCompressedOops -XX:+UseParallelGC 1 tests failed. FAILED: org.apache.solr.cloud.CollectionsAPIAsyncDistributedZkTest.testSolrJAPICalls Error Message: Shard split did not complete. Last re

Re: Moving to git?

Nice! On Sun, May 31, 2015 at 1:31 PM Steve Davids wrote: > bq. Something needs to be done about all those jars in the source > history, I will not let this go. > > I went ahead and used the BFG Repo Cleaner > tool to drop all of the old > jars in the

Re: Moving to git?

bq. Something needs to be done about all those jars in the source history, I will not let this go. I went ahead and used the BFG Repo Cleaner tool to drop all of the old jars in the git history, here are the findings: $ git clone --mirror https://githu

[JENKINS] Lucene-Solr-NightlyTests-trunk - Build # 698 - Still Failing

Build: https://builds.apache.org/job/Lucene-Solr-NightlyTests-trunk/698/ 4 tests failed. REGRESSION: org.apache.solr.TestDistributedSearch.test Error Message: Address already in use Stack Trace: java.net.BindException: Address already in use at sun.nio.ch.Net.bind0(Native Method)

Re: Moving to git?

> You guys totally miss the point on clone. No, I think you miss our point. > The thing is that svn checkout gives you enough, to do what you need > to do. git clone --depth 1 does as well -- you work on your stuff, then you diff against the baseline, submit a patch. Like I said -- we differ in

Re: Moving to git?

In any case, decisions on these types of things are majority of PMC rules. No one has wanted to call a vote yet. Eventually we will and eventually we will move to git. I'm still in no hurry. - mark On Sun, May 31, 2015 at 9:59 AM Uwe Schindler wrote: > I also clone my SVN working copy locally. A

Re: [VOTE] 5.2.0 RC2

Guess it's time for an RC3! I'll re-spin. On Sat, May 30, 2015 at 9:43 PM, Tomás Fernández Löbbe < tomasflo...@gmail.com> wrote: > Unfortunately I imported log4j Logger instead of slf4j in SOLR-7406. I'll > fix this and merge it in the 5.2 branch. I think this should be a blocker > since it would

[JENKINS] Lucene-Solr-trunk-Windows (64bit/jdk1.8.0_45) - Build # 4876 - Failure!

Build: http://jenkins.thetaphi.de/job/Lucene-Solr-trunk-Windows/4876/ Java: 64bit/jdk1.8.0_45 -XX:-UseCompressedOops -XX:+UseParallelGC 1 tests failed. FAILED: org.apache.solr.update.AutoCommitTest.testMaxTime Error Message: Exception during query Stack Trace: java.lang.RuntimeException: Except

[JENKINS] Lucene-Solr-5.x-Linux (32bit/ibm-j9-jdk7) - Build # 12710 - Failure!

Build: http://jenkins.thetaphi.de/job/Lucene-Solr-5.x-Linux/12710/ Java: 32bit/ibm-j9-jdk7 -Xjit:exclude={org/apache/lucene/util/fst/FST.pack(IIF)Lorg/apache/lucene/util/fst/FST;} No tests ran. Build Log: [...truncated 300 lines...] ERROR: Publisher 'Publish JUnit test result report' failed: No

[JENKINS] Lucene-Solr-5.x-MacOSX (64bit/jdk1.7.0) - Build # 2320 - Failure!

Build: http://jenkins.thetaphi.de/job/Lucene-Solr-5.x-MacOSX/2320/ Java: 64bit/jdk1.7.0 -XX:-UseCompressedOops -XX:+UseG1GC 1 tests failed. FAILED: org.apache.solr.client.solrj.impl.CloudSolrClientTest.test Error Message: Error from server at http://127.0.0.1:57682/checkStateVerCol: no servers

[jira] [Updated] (SOLR-7614) Distributed Pivot Facet not thread safe

[ https://issues.apache.org/jira/browse/SOLR-7614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley updated SOLR-7614: --- Attachment: SOLR-7614.patch Here's a patch that moves the counter to FacetInfo. Since a new FacetInfo i

[jira] [Comment Edited] (SOLR-7614) Distributed Pivot Facet not thread safe

[ https://issues.apache.org/jira/browse/SOLR-7614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566557#comment-14566557 ] Yonik Seeley edited comment on SOLR-7614 at 5/31/15 2:53 PM: - T

[jira] [Commented] (SOLR-7614) Distributed Pivot Facet not thread safe

[ https://issues.apache.org/jira/browse/SOLR-7614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566557#comment-14566557 ] Yonik Seeley commented on SOLR-7614: This may be the root cause of SOLR-7605 > Distrib

[jira] [Created] (SOLR-7614) Distributed Pivot Facet not thread safe

Yonik Seeley created SOLR-7614: -- Summary: Distributed Pivot Facet not thread safe Key: SOLR-7614 URL: https://issues.apache.org/jira/browse/SOLR-7614 Project: Solr Issue Type: Bug Re

RE: Moving to git?

I also clone my SVN working copy locally. After that I just switch branch. Uwe - Uwe Schindler H.-H.-Meier-Allee 63, D-28213 Bremen http://www.thetaphi.de eMail: u...@thetaphi.de > -Original Message- > From: Yonik Seeley [mailto:ysee...@gmail.com] > Sent: Sunday, May 31, 2015 3:56 PM

Re: Moving to git?

On Sun, May 31, 2015 at 9:31 AM, Ramkumar R. Aiyengar wrote: > Personally, clone for me is 'rare', I did it once years back, and have never > done it since. log, diff and others I do on a daily basis. Yep, I find I need fewer different working directories with git, but when I do want an additiona

[JENKINS] Lucene-Solr-trunk-Linux (32bit/jdk1.9.0-ea-b60) - Build # 12884 - Still Failing!

Build: http://jenkins.thetaphi.de/job/Lucene-Solr-trunk-Linux/12884/ Java: 32bit/jdk1.9.0-ea-b60 -server -XX:+UseConcMarkSweepGC 1 tests failed. FAILED: org.apache.solr.cloud.TestCloudPivotFacet.test Error Message: init query failed: {main(facet=true&facet.pivot=%7B%21stats%3Dst3%7Ddense_pivot_

Re: Moving to git?

Don't assume your workflow is everyone else's workflow. And don't try to enforce your workflow on me. I don't use svn OR git in the way you describe. On Sun, May 31, 2015 at 9:31 AM, Ramkumar R. Aiyengar wrote: > Personally, clone for me is 'rare', I did it once years back, and have never > done

Re: Moving to git?

Personally, clone for me is 'rare', I did it once years back, and have never done it since. log, diff and others I do on a daily basis. Same with svn as well actually, you checkout just once usually.. I think the previous discussion had the agreement that this issue should focus on committers rath

Re: Moving to git?

You guys totally miss the point on clone. The thing is that svn checkout gives you enough, to do what you need to do. And yes it does network lookup for more rare things like history, but this works just fine in general. On the other hand git downloads gigabytes, before you can even get started.

[jira] [Assigned] (SOLR-7583) API to download snapshot files/restore via upload

[ https://issues.apache.org/jira/browse/SOLR-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller reassigned SOLR-7583: - Assignee: Mark Miller > API to download snapshot files/restore via upload > --

Re: Moving to git?

+1 for git, great for working on multiple things at once. Side note: git-svn is also not great btw for the kind of merging we need to do with every commit, it kind of works but with too many caveats. On the note that git clone is slow, sure, because it fetches a fair amount of history which svn d

[jira] [Commented] (LUCENE-6508) Simplify Directory/lock api

[ https://issues.apache.org/jira/browse/LUCENE-6508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566545#comment-14566545 ] ASF subversion and git services commented on LUCENE-6508: - Commit

[jira] [Comment Edited] (LUCENE-6508) Simplify Directory/lock api

[ https://issues.apache.org/jira/browse/LUCENE-6508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566544#comment-14566544 ] Uwe Schindler edited comment on LUCENE-6508 at 5/31/15 1:01 PM: ---

[jira] [Commented] (LUCENE-6508) Simplify Directory/lock api

[ https://issues.apache.org/jira/browse/LUCENE-6508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566544#comment-14566544 ] Uwe Schindler commented on LUCENE-6508: --- I started fixing HdfsLockFactory and Solr:

[jira] [Commented] (SOLR-7485) replace "shards.info" with ShardParams.SHARDS_INFO in TestTolerantSearch.java and CloudSolrClientTest.java, add ShardParamsTest.java

[ https://issues.apache.org/jira/browse/SOLR-7485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566539#comment-14566539 ] Ramkumar Aiyengar commented on SOLR-7485: - [~shalinmangar], does that address your

[jira] [Assigned] (SOLR-7485) replace "shards.info" with ShardParams.SHARDS_INFO in TestTolerantSearch.java and CloudSolrClientTest.java, add ShardParamsTest.java

[ https://issues.apache.org/jira/browse/SOLR-7485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ramkumar Aiyengar reassigned SOLR-7485: --- Assignee: Ramkumar Aiyengar > replace "shards.info" with ShardParams.SHARDS_INFO in Te

Re: Moving to git?

On Sat, May 30, 2015 at 4:20 PM, Dawid Weiss wrote: > # time git clone --depth 1 https://github.com/apache/lucene-solr.git This breaks rule #1 of using git, don't pass any options to any of the commands, or it shits itself. Git clone is slow, i think the reason is all the old jar files in the re

[jira] [Commented] (LUCENE-6508) Simplify Directory/lock api

[ https://issues.apache.org/jira/browse/LUCENE-6508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566535#comment-14566535 ] Robert Muir commented on LUCENE-6508: - {quote} We are not tracking openLocks anymore

[jira] [Resolved] (SOLR-7406) Support DV implementation in range faceting

[ https://issues.apache.org/jira/browse/SOLR-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomás Fernández Löbbe resolved SOLR-7406. - Resolution: Fixed Thanks for catching this issue [~greggny3] > Support DV implemen

[jira] [Commented] (LUCENE-6508) Simplify Directory/lock api

[ https://issues.apache.org/jira/browse/LUCENE-6508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566460#comment-14566460 ] Michael McCandless commented on LUCENE-6508: I love the "changed by an extern

[jira] [Commented] (LUCENE-6508) Simplify Directory/lock api

[ https://issues.apache.org/jira/browse/LUCENE-6508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566458#comment-14566458 ] Michael McCandless commented on LUCENE-6508: These tests are now angry: {nofo

[jira] [Commented] (LUCENE-6508) Simplify Directory/lock api

[ https://issues.apache.org/jira/browse/LUCENE-6508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566455#comment-14566455 ] ASF subversion and git services commented on LUCENE-6508: - Commit

[jira] [Commented] (LUCENE-6508) Simplify Directory/lock api

[ https://issues.apache.org/jira/browse/LUCENE-6508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566456#comment-14566456 ] ASF subversion and git services commented on LUCENE-6508: - Commit

[jira] [Commented] (LUCENE-6508) Simplify Directory/lock api

[ https://issues.apache.org/jira/browse/LUCENE-6508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566441#comment-14566441 ] ASF subversion and git services commented on LUCENE-6508: - Commit

[jira] [Comment Edited] (SOLR-7495) Unexpected docvalues type NUMERIC when grouping by a int facet

[ https://issues.apache.org/jira/browse/SOLR-7495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566096#comment-14566096 ] Xu Zhang edited comment on SOLR-7495 at 5/31/15 7:13 AM: - Currently