[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14052880#comment-14052880
]
Mark Miller commented on SOLR-5473:
---
Let’s forget the code for a minute. I have to review
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14052890#comment-14052890
]
Noble Paul commented on SOLR-5473:
--
bq. I don’t doubt we can come to agreement on how to
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14051326#comment-14051326
]
ASF subversion and git services commented on SOLR-5473:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14051330#comment-14051330
]
Noble Paul commented on SOLR-5473:
--
I have reverted the changes
We are working on
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14051377#comment-14051377
]
Mark Miller commented on SOLR-5473:
---
I'm personally frustrated as well. I feel like I've
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14051538#comment-14051538
]
Shalin Shekhar Mangar commented on SOLR-5473:
-
I think that's better but I
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050310#comment-14050310
]
ASF subversion and git services commented on SOLR-5473:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050330#comment-14050330
]
Mark Miller commented on SOLR-5473:
---
I see you addressed very little of what has come up.
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050346#comment-14050346
]
Mark Miller commented on SOLR-5473:
---
I already talked about a lot of the problems that
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050364#comment-14050364
]
Noble Paul commented on SOLR-5473:
--
bq. But a minimum, I have a firm negative -1 on the
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050372#comment-14050372
]
Mark Miller commented on SOLR-5473:
---
bq. But, till it exists , I admit , I did not have a
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050488#comment-14050488
]
Noble Paul commented on SOLR-5473:
--
is ClusterState referring to ZkStateReader the only
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050583#comment-14050583
]
Mark Miller commented on SOLR-5473:
---
Some things are better now.
Some of the most
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050597#comment-14050597
]
Noble Paul commented on SOLR-5473:
--
bq.Since we don't plan on supporting both modes
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050645#comment-14050645
]
Mark Miller commented on SOLR-5473:
---
bq. We have done extensive long running tests with
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050655#comment-14050655
]
Noble Paul commented on SOLR-5473:
--
bq.If we could just deprecate clusterstate now, why
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050656#comment-14050656
]
Shalin Shekhar Mangar commented on SOLR-5473:
-
Mark, we have to revert it if
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050665#comment-14050665
]
Mark Miller commented on SOLR-5473:
---
bq. It is crazy that it takes a commit to get your
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050680#comment-14050680
]
Mark Miller commented on SOLR-5473:
---
I'll also reiterate: Splitting the clusterstate.json
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050683#comment-14050683
]
Noble Paul commented on SOLR-5473:
--
bq.My point is not simply the ZkStateReader - thats
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050691#comment-14050691
]
Noble Paul commented on SOLR-5473:
--
bq.Finally, splitting the clusterstate by collection
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050698#comment-14050698
]
Shalin Shekhar Mangar commented on SOLR-5473:
-
bq. I think because you are
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050706#comment-14050706
]
Mark Miller commented on SOLR-5473:
---
bq. There is really no point in splitting the
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050717#comment-14050717
]
Mark Miller commented on SOLR-5473:
---
Anyway, no one is forcing you to take it a step at a
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050718#comment-14050718
]
Noble Paul commented on SOLR-5473:
--
bq.It would be a step along the path you are seeking
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050722#comment-14050722
]
Noble Paul commented on SOLR-5473:
--
bq.How do the API's need to change to get that
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050829#comment-14050829
]
Mark Miller commented on SOLR-5473:
---
I'm still calling for a revert. People will start
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050936#comment-14050936
]
Mark Miller commented on SOLR-5473:
---
bq. Just because of the fear of the unknown?
For
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14049038#comment-14049038
]
Noble Paul commented on SOLR-5473:
--
I'm planning to commit this to trunk in a day
Make
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14044620#comment-14044620
]
Shalin Shekhar Mangar commented on SOLR-5473:
-
+1
There has been a huge amount
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14044647#comment-14044647
]
Shawn Heisey commented on SOLR-5473:
I have not looked at the code or what this
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14044678#comment-14044678
]
Yago Riveiro commented on SOLR-5473:
[~elyograg] I can wrong, but I think that the 1MB
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042563#comment-14042563
]
Timothy Potter commented on SOLR-5473:
--
Applied patch to trunk and ran through the
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14037474#comment-14037474
]
ASF subversion and git services commented on SOLR-5473:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998695#comment-13998695
]
Noble Paul commented on SOLR-5473:
--
bq.If we want to make such a distinction in the code,
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13997480#comment-13997480
]
Noble Paul commented on SOLR-5473:
--
Thanks Shalin
On #1 I have fixed the assertion
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998408#comment-13998408
]
Mark Miller commented on SOLR-5473:
---
{quote}
Overall, I like the watched collection vs.
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13996829#comment-13996829
]
Shalin Shekhar Mangar commented on SOLR-5473:
-
The following feedback was
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998514#comment-13998514
]
Shalin Shekhar Mangar commented on SOLR-5473:
-
bq. I'm not sure which one is
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13997910#comment-13997910
]
Jessica Cheng commented on SOLR-5473:
-
{quote}
I'm not sure which one is right here. I
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13990742#comment-13990742
]
ASF subversion and git services commented on SOLR-5473:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13990821#comment-13990821
]
Mark Miller commented on SOLR-5473:
---
Thanks - this is very high on my list to contribute
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13985376#comment-13985376
]
ASF subversion and git services commented on SOLR-5473:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13984287#comment-13984287
]
Steve Rowe commented on SOLR-5473:
--
bq. Where r we going to create the new branch? SVN ?
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13984308#comment-13984308
]
ASF subversion and git services commented on SOLR-5473:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13984507#comment-13984507
]
Timothy Potter commented on SOLR-5473:
--
Hi Mark,
Just wanted to get your input on the
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13983733#comment-13983733
]
Mark Miller commented on SOLR-5473:
---
Any help needed on pulling this out? I think if we
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13983928#comment-13983928
]
Noble Paul commented on SOLR-5473:
--
I'm almost there . probably today or in the worst
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13982173#comment-13982173
]
Mark Miller commented on SOLR-5473:
---
Thanks for chiming in.
bq. Do we intend to support
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979630#comment-13979630
]
Mark Miller commented on SOLR-5473:
---
bq. The latest patch is not a final one .
I have to
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979969#comment-13979969
]
Noble Paul commented on SOLR-5473:
--
hi [~markrmil...@gmail.com] I'm work on a reverse
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979983#comment-13979983
]
Mark Miller commented on SOLR-5473:
---
Thank you.
bq. The idea of splitting the
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13980013#comment-13980013
]
Noble Paul commented on SOLR-5473:
--
bq.The external interface
bq. I've already gone into a
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13980053#comment-13980053
]
Timothy Potter commented on SOLR-5473:
--
Thought I'd add my 2 cents on this one as I've
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978454#comment-13978454
]
Mark Miller commented on SOLR-5473:
---
I'll take look asap.
I was just looking at the zk
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978545#comment-13978545
]
Noble Paul commented on SOLR-5473:
--
bq.Why is stateFormat in the collection
We are using
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978564#comment-13978564
]
Mark Miller commented on SOLR-5473:
---
bq. It is just a good practice to explicitly state
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979135#comment-13979135
]
Mark Miller commented on SOLR-5473:
---
I've started looking at this patch. It looks like
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979144#comment-13979144
]
Mark Miller commented on SOLR-5473:
---
{code}
if(collection !=null
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979177#comment-13979177
]
Mark Miller commented on SOLR-5473:
---
bq. externalWatchedCollections
What are these?
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979195#comment-13979195
]
Mark Miller commented on SOLR-5473:
---
bq. public Map ephemeralCollectionData;
This is not
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979201#comment-13979201
]
Mark Miller commented on SOLR-5473:
---
I also think this expanded usage of zkStateReader in
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979227#comment-13979227
]
Mark Miller commented on SOLR-5473:
---
I have to make an official -1 veto vote on this
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979259#comment-13979259
]
Noble Paul commented on SOLR-5473:
--
Before I comment of the comments I would like to lay
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13975436#comment-13975436
]
Noble Paul commented on SOLR-5473:
--
bq.I think more appropriate names are something along
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13975825#comment-13975825
]
Ryan Ernst commented on SOLR-5473:
--
bq. format2 is not self explanatory, but
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13975842#comment-13975842
]
Mark Miller commented on SOLR-5473:
---
bq. external/internal is just as cryptic.
Not only
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13975850#comment-13975850
]
Mark Miller commented on SOLR-5473:
---
I've reopened this for a bit - just until I can
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13976416#comment-13976416
]
Noble Paul commented on SOLR-5473:
--
[~markrmil...@gmail.com] plz apply the latest patch
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972853#comment-13972853
]
Noble Paul commented on SOLR-5473:
--
bq.There is still internal / external stuff in here
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972961#comment-13972961
]
Mark Miller commented on SOLR-5473:
---
Yeah, I know, but it should not be an internal thing
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973093#comment-13973093
]
Mark Miller commented on SOLR-5473:
---
There are important omissions on credit for this
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973106#comment-13973106
]
Mark Miller commented on SOLR-5473:
---
bq. The internal/external are not visible anywhere
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973121#comment-13973121
]
Mark Miller commented on SOLR-5473:
---
The following would be good to clean up in
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973123#comment-13973123
]
Mark Miller commented on SOLR-5473:
---
ClusterStater#getCachedCollection and
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973130#comment-13973130
]
Noble Paul commented on SOLR-5473:
--
bq. At a minimum, these methods should be well doc'd
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973454#comment-13973454
]
Mark Miller commented on SOLR-5473:
---
bq. I don't see a more appropriate method name for
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13970580#comment-13970580
]
ASF subversion and git services commented on SOLR-5473:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13970702#comment-13970702
]
ASF subversion and git services commented on SOLR-5473:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13971131#comment-13971131
]
Mark Miller commented on SOLR-5473:
---
Wow dude - huge fing patch and change to commit
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13971377#comment-13971377
]
Shalin Shekhar Mangar commented on SOLR-5473:
-
bq. Wow dude - huge fing patch
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13971381#comment-13971381
]
Mark Miller commented on SOLR-5473:
---
Thanks, I missed that - bummer. I've got some issues
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13971388#comment-13971388
]
Shalin Shekhar Mangar commented on SOLR-5473:
-
That's okay. This is only on
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13971390#comment-13971390
]
Mark Miller commented on SOLR-5473:
---
So I skimmed Nobles comment above about updating the
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13971392#comment-13971392
]
Noble Paul commented on SOLR-5473:
--
[~markrmil...@gmail.com] We can do a couple of
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13971428#comment-13971428
]
Mark Miller commented on SOLR-5473:
---
bq. I'd also like to setup a jenkins build which
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960885#comment-13960885
]
Mark Miller commented on SOLR-5473:
---
Does an 'external' collection also entail not
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960890#comment-13960890
]
Noble Paul commented on SOLR-5473:
--
Actually, the main clusterstate.json is watched
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960906#comment-13960906
]
Mark Miller commented on SOLR-5473:
---
If you have a clusterstate.json per collection,
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960949#comment-13960949
]
Noble Paul commented on SOLR-5473:
--
bq If you have a clusterstate.json per collection,
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13958743#comment-13958743
]
Mark Miller commented on SOLR-5473:
---
Personally, I'm not that big on this 'external'
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13958749#comment-13958749
]
Noble Paul commented on SOLR-5473:
--
Yes, I agree with you. But I would to like it to be
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13958754#comment-13958754
]
Mark Miller commented on SOLR-5473:
---
Yeah, I have no problem supporting both for back
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13958757#comment-13958757
]
Noble Paul commented on SOLR-5473:
--
Yeah , got your point,
Something like a
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13958767#comment-13958767
]
Alan Woodward commented on SOLR-5473:
-
How about an explicit version numbering system?
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13958771#comment-13958771
]
Noble Paul commented on SOLR-5473:
--
[~romseygeek] I guess we should go with that. In this
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13958799#comment-13958799
]
Mark Miller commented on SOLR-5473:
---
Yeah, moving to a version sounds good.
Make one
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13956774#comment-13956774
]
Shalin Shekhar Mangar commented on SOLR-5473:
-
Thanks Noble. All tests pass
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951642#comment-13951642
]
Anshum Gupta commented on SOLR-5473:
More comments:
# Removing the commented out code
[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949224#comment-13949224
]
Shalin Shekhar Mangar commented on SOLR-5473:
-
I think we should add the
1 - 100 of 128 matches
Mail list logo
