[jira] [Commented] (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-07-01 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13058549#comment-13058549 ] Michael McCandless commented on LUCENE-2883: +1, this is great Chris!

[jira] [Commented] (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-06-30 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13058142#comment-13058142 ] Robert Muir commented on LUCENE-2883: - Thanks for all your hard refactoring work here

[jira] [Commented] (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-06-22 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13053566#comment-13053566 ] Chris Male commented on LUCENE-2883: Rather than doing all the work in this issue,

[jira] [Commented] (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-05-20 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13036898#comment-13036898 ] Yonik Seeley commented on LUCENE-2883: -- bq. Sort instances are like Query

[jira] [Commented] (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-05-20 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13036906#comment-13036906 ] Michael McCandless commented on LUCENE-2883: OK I created branch

[jira] [Commented] (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-05-19 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13036479#comment-13036479 ] Michael McCandless commented on LUCENE-2883: {quote} bq. Hmm good question.

[jira] [Commented] (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-05-19 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13036501#comment-13036501 ] Yonik Seeley commented on LUCENE-2883: -- Regarding weighting - function queries can

[jira] [Commented] (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-05-19 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13036631#comment-13036631 ] Chris Male commented on LUCENE-2883: {quote} So the goal here is to make the

[jira] [Commented] (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-05-19 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13036633#comment-13036633 ] Chris Male commented on LUCENE-2883: Hey Yonik, Its super to hear from you on this,

[jira] [Commented] (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-05-19 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13036637#comment-13036637 ] Chris Male commented on LUCENE-2883: I've opened SOLR-2533 to look at ways to

[jira] [Commented] (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-05-19 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13036641#comment-13036641 ] Chris Male commented on LUCENE-2883: {quote} Is this desirable? IndexSearcher is

[jira] [Commented] (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-05-18 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13035331#comment-13035331 ] Chris Male commented on LUCENE-2883: Script needed to run to use patch: {code} svn

[jira] [Commented] (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-05-18 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13035508#comment-13035508 ] Michael McCandless commented on LUCENE-2883: Thanks Chris! The patch applies

[jira] [Commented] (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-05-18 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13035967#comment-13035967 ] Chris Male commented on LUCENE-2883: bq. I think we should move Mutable* over?

[jira] Commented: (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-01-27 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12987549#action_12987549 ] Grant Ingersoll commented on LUCENE-2883: - I think it makes sense to make function

[jira] Commented: (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-01-27 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12987550#action_12987550 ] Simon Willnauer commented on LUCENE-2883: - bq. Function queries (FQs) already have

[jira] Commented: (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-01-27 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12987557#action_12987557 ] Robert Muir commented on LUCENE-2883: - bq. but with the distinction that changes in

[jira] Commented: (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-01-27 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12987582#action_12987582 ] Grant Ingersoll commented on LUCENE-2883: - bq. I thought this was understood about

[jira] Commented: (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-01-27 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12987589#action_12987589 ] Michael McCandless commented on LUCENE-2883: bq. As such, I don't think it

[jira] Commented: (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-01-27 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12987595#action_12987595 ] Yonik Seeley commented on LUCENE-2883: -- bq. hopefully we didnt screw this up in

[jira] Commented: (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-01-27 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12987604#action_12987604 ] Grant Ingersoll commented on LUCENE-2883: - bq. Does that make sense? I think it

[jira] Commented: (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-01-27 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12987605#action_12987605 ] Robert Muir commented on LUCENE-2883: - {quote} The status and expectations for the

[jira] Commented: (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-01-27 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12987809#action_12987809 ] Chris Male commented on LUCENE-2883: .bq I would expect, for example, to be able to

[jira] Commented: (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-01-26 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12987146#action_12987146 ] Yonik Seeley commented on LUCENE-2883: -- One concern some people have had is that

[jira] Commented: (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-01-26 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12987162#action_12987162 ] Simon Willnauer commented on LUCENE-2883: - {quote} I'm not against modularizing

[jira] Commented: (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-01-26 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12987186#action_12987186 ] Yonik Seeley commented on LUCENE-2883: -- Let me try to recap my concerns here (2 main

[jira] Commented: (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-01-26 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12987197#action_12987197 ] Chris Male commented on LUCENE-2883: Hey Yonik, I'm just trying to understand what

[jira] Commented: (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-01-26 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12987204#action_12987204 ] Yonik Seeley commented on LUCENE-2883: -- Chris: #2 is just an attempted recap of this

[jira] Commented: (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-01-26 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12987207#action_12987207 ] Chris Male commented on LUCENE-2883: Hi, Hmm I don't really understand that part

[jira] Commented: (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-01-26 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12987262#action_12987262 ] Simon Willnauer commented on LUCENE-2883: - Really back in the days where stuff

[jira] Commented: (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-01-25 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12986502#action_12986502 ] Yonik Seeley commented on LUCENE-2883: -- One issue here is the different purposes for

[jira] Commented: (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-01-25 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12986529#action_12986529 ] Simon Willnauer commented on LUCENE-2883: - bq. One issue here is the different

[jira] Commented: (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-01-25 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12986558#action_12986558 ] Michael McCandless commented on LUCENE-2883: Can't we consolidate them under a

[jira] Commented: (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-01-25 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12986561#action_12986561 ] Yonik Seeley commented on LUCENE-2883: -- Not sure if I communicated the issue clearly:

[jira] Commented: (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-01-25 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12986569#action_12986569 ] Robert Muir commented on LUCENE-2883: - Wait, why again did we merge lucene and solr?

[jira] Commented: (LUCENE-2883) Consolidate Solr Lucene FunctionQuery into modules

2011-01-25 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12986571#action_12986571 ] Yonik Seeley commented on LUCENE-2883: -- bq. We can mark the classes as