--
> > Da: Enrico Olivelli
> > Date: mar 14 mag 2019, 13:58
> > Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0
> > To: Maven Developers List
> >
> >
> > Eric and Tibor,
> > Thank you so much for your effort in t
indows
>
> Enrico
>
> -- Forwarded message -
> Da: Enrico Olivelli
> Date: mar 14 mag 2019, 13:58
> Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0
> To: Maven Developers List
>
>
> Eric and Tibor,
> Thank you so much for your
Robert> According to the ASF the -sources.zip are the official release, not
the git tag
That's right
Robert>In this case you don't control the EOL, it is based on the OS of the
release manager.
Is it? I would disagree here.
For instance, Apache JMeter produces both -src.zip (CRLF), and
Keep in mind there's another important situation that you can't control it like
this.
According to the ASF the -sources.zip are the official release, not the git
tag. This means that you should unpack the zip and be able to verify it on all
OSes.
In this case you don't control the EOL, it is
Ah, thanks Vladimir, that's even better. I was not 100% sure it would be
possible to retain complete control over resulting line endings for those
files, regardless of user git settings of stuff like autocrlf = true and
whatnot, but it seems there is, that's great news. Thanks!
- Eric L
On Thu,
Eric>In that case, we should generate the test files (to
Eric>avoid git interfering), one with linux-style EOLs and one with
Eric>Windows-style EOLs and test with both.
You'd better have those files under Git control, and you could just specify
.gitattributes so the LF file is always LF, and CRLF
Hi Enrico!
If I remember correctly, a number of weeks ago I tried using Checkstyle
8.21 with maven-checkstyle-plugin (I had simply cloned the
maven-checkstyle-plugin repository) and it did solve the problem with the
test case discussed in this thread. However, as I recall there was another,
Just in case: I see you seem to be battling against CRLF
For instance: https://github.com/apache/maven-checkstyle-plugin/pull/16
Did you consider to add the relevant .gitattributes file to ensure Git
converts the files automatically?
With a proper .gitattributes file, it is just impossible to
Il mer 17 lug 2019, 13:28 Eric Lilja ha scritto:
> I believe, if we instead upgrade to Checkstyle 8.21 or later, we don't need
> to do any of those alternative approaches.
>
> https://github.com/checkstyle/checkstyle/issues/4073
Eric
I think it is the best idea
Do you have cycles to give it a
I believe, if we instead upgrade to Checkstyle 8.21 or later, we don't need
to do any of those alternative approaches.
https://github.com/checkstyle/checkstyle/issues/4073
- Eric L
On Wed, Jul 17, 2019 at 1:20 PM Vladimir Sitnikov <
sitnikov.vladi...@gmail.com> wrote:
> Robert>A clone from
Robert>A clone from Git succeeds, but the sources.zip fails.
Robert>The files in the zip are generated on a unix system, so all EOLs in
text files are LF
Robert>...
Robert>The fix: add a setup.groovy to the IT and rewrite the java files
with OS specific EOLs
Alternative approaches:
A) Provide
>>
> >
> https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/sun_checks.xml
> > >> > >
> > >> > >
> > >> >
> > >>
> >
> https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/goo
; >
> >> >
> >>
> https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/google_checks.xml
> >> > >
> >> > > I expected platform independence because my company used
> >> sun_checks.xml
> >> > on
> >>
gt;> sun_checks.xml
>> > on
>> > > Windows with Unix EOL in Git/IDE without this problem.
>> > > The company improved sun_checks.xml long time ago, so I realized that
>> > later
>> > > that it is slightly different XML and different
OL in Git/IDE without this problem.
> > > The company improved sun_checks.xml long time ago, so I realized that
> > later
> > > that it is slightly different XML and different experience. Sorry.
> > > Cheers
> > > Tibor17
> > >
> > >
ll get a windows box and try to reproduce.
> > > It is weird that on ASF Jenkins the build is passing even on windows
> > >
> > > Enrico
> > >
> > > -- Forwarded message -
> > > Da: Enrico Olivelli
> > > Date: mar 14
hat on ASF Jenkins the build is passing even on windows
> >
> > Enrico
> >
> > -- Forwarded message -----
> > Da: Enrico Olivelli
> > Date: mar 14 mag 2019, 13:58
> > Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin vers
- Hi,
-
- The vote has passed with the following result:
-
- +1 : Tibor Digana, Sylwester Lachiewicz, Hervé Boutemy, Karl Heinz Marbaise
-
- PMC quorum: reached
-
- I will promote the artifacts to the central repo.
Enrico
Il giorno dom 19 mag 2019 alle ore 11:44 Sylwester Lachiewicz <
+1
Sylwester
W dniu niedz., 19.05.2019 o 11:09 Hervé BOUTEMY
napisał(a):
> +1
>
> Regards,
>
> Hervé
>
> Le lundi 13 mai 2019, 11:52:30 CEST Enrico Olivelli a écrit :
> > Hi,
> >
> > We solved 13 issues:
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12342397
> >
+1
Regards,
Hervé
Le lundi 13 mai 2019, 11:52:30 CEST Enrico Olivelli a écrit :
> Hi,
>
> We solved 13 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12342397
> eName=Text=12317223
>
> Please note that this version now only supports CheckStyle 8+ and Java 8
> (as
+1
Thx Enrico for your work!
On Mon, May 13, 2019 at 11:52 AM Enrico Olivelli
wrote:
> Hi,
>
> We solved 13 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12342397=Text=12317223
>
> Please note that this version now only supports CheckStyle 8+ and Java 8
> (as
g even on windows
>
> Enrico
>
> -- Forwarded message -
> Da: Enrico Olivelli
> Date: mar 14 mag 2019, 13:58
> Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0
> To: Maven Developers List
>
>
> Eric and Tibor,
> Thank yo
t;
> > Enrico
> >
> >
> >
> >>
> >> Cheers
> >> Tibor
> >>
> >> On Tue, May 14, 2019 at 2:11 PM Enrico Olivelli
> >> wrote:
> >>
> >> > I will get a windows box and try to reproduce.
> >> > It
kstyle-plugin-3.1.0
>
>
>
>
>
> Enrico
>
>
>
>>
>> Cheers
>> Tibor
>>
>> On Tue, May 14, 2019 at 2:11 PM Enrico Olivelli
>> wrote:
>>
>> > I will get a windows box and try to reproduce.
>> > It is weird that on A
warded message -
> > Da: Enrico Olivelli
> > Date: mar 14 mag 2019, 13:58
> > Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0
> > To: Maven Developers List
> >
> >
> > Eric and Tibor,
> > Thank you so much for
on ASF Jenkins the build is passing even on windows
>
> Enrico
>
> -- Forwarded message -
> Da: Enrico Olivelli
> Date: mar 14 mag 2019, 13:58
> Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0
> To: Maven Developers List
>
>
&
>> > It is weird that on ASF Jenkins the build is passing even on windows
>> >
>> > Enrico
>> >
>> > -- Forwarded message -
>> > Da: Enrico Olivelli
>> > Date: mar 14 mag 2019, 13:58
>> > Subject: Re: [VOTE] Release
; Enrico
> >
> > ------ Forwarded message -
> > Da: Enrico Olivelli
> > Date: mar 14 mag 2019, 13:58
> > Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0
> > To: Maven Developers List
> >
> >
> > E
;>
>>> I will get a windows box and try to reproduce.
>>> It is weird that on ASF Jenkins the build is passing even on windows
>>>
>>> Enrico
>>>
>>> -- Forwarded message -
>>> Da: Enrico Olivelli
>>> Date: mar 14 mag 2019
---
>> Da: Enrico Olivelli
>> Date: mar 14 mag 2019, 13:58
>> Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0
>> To: Maven Developers List
>>
>>
>> Eric and Tibor,
>> Thank you so much for your effort in testing
Forwarded message -
> Da: Enrico Olivelli
> Date: mar 14 mag 2019, 13:58
> Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0
> To: Maven Developers List
>
>
> Eric and Tibor,
> Thank you so much for your effort in testing Maven Checkstyle Plug
-- Forwarded message -
> Da: Enrico Olivelli
> Date: mar 14 mag 2019, 13:58
> Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0
> To: Maven Developers List
>
>
> Eric and Tibor,
> Thank you so much for your effort in testing Maven Check
I will get a windows box and try to reproduce.
It is weird that on ASF Jenkins the build is passing even on windows
Enrico
-- Forwarded message -
Da: Enrico Olivelli
Date: mar 14 mag 2019, 13:58
Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0
To: Maven
Eric and Tibor,
Thank you so much for your effort in testing Maven Checkstyle Plugin.
This is the "official" VOTE thread, here we have to decide if the staged
artifacts are good to be released or not.
Feel free to cast a -1 if you think that the staged artifacts are not
"stable" or there is any
Tried overriding line.separator when running using -Dline.separator="\n",
but then the builds fails (early) in maven-plugin-plugin:
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor
(default-descriptor) on project maven-checkstyle-plugin: Execution
I tried bumping checkstyle to 8.20, plus a few of the plexus dependencies,
but that just brought an additional failure... (to
MCHECKSTYLE-70-multi-sourcefolder\pom.xml) :-)
I suppose the problem might be that the files has linux-style line breaks
(this is desired for me, I don't want to convert
I also see a failure for MCHECKSTYLE-54 on Windows. (Sorry, I didn't try
the source zip, just cloned master)
I tested on one of our corporate laptops:
Windows 10
Cygwin 64-bit (I use it to clone the repo and use Maven)
Maven 3.6.0
Java 8 update 202
The build log says:
[INFO] There are 2 errors
Il lun 13 mag 2019, 23:48 Tibor Digana ha scritto:
> Robert, I did *not* use the source zip.
>
IMHO we should vote on the staged zip
> git clone https://gitbox.apache.org/repos/asf/maven-checkstyle-plugin
> Oracle jdk 1.8.0u212, Maven 3.3.9, Windows 10
>
This is what CI does and tests are
Robert, I did *not* use the source zip.
git clone https://gitbox.apache.org/repos/asf/maven-checkstyle-plugin
Oracle jdk 1.8.0u212, Maven 3.3.9, Windows 10
I see there is a new line, but the checkstyle does not care if you put one
or two lines.
No idea why.
Even if you go to the target and run
This can happen when source-release.zip was created on a different OS
compared to the verifying OS.
With Git it will switch to the line endings of the operating system, but
with a zip that's not possible.
I'd say not blocking, but the IT needs to be fixed to handle these
situations.
I use the latest commit at Gitbox b1ad0bbbf077d5670cf679043076b9a1691ce4cc
I will try to add two newlines in the file.
On Mon, May 13, 2019 at 9:55 PM Enrico Olivelli wrote:
> Tibor
> It is strage all its are passing on CI.
> Are you sure you have correcly unpacked the package?
>
>
> Il lun 13
Tibor
It is strage all its are passing on CI.
Are you sure you have correcly unpacked the package?
Il lun 13 mag 2019, 21:23 Tibor Digana ha scritto:
> checked the sha512 of src zip, ok
> checked the build, failed (mvn verify -P run-its,quality-checks)
>
What is 'quality-checks' profile? I
Hi,
I have checked the SHA512 Ok...and unpacked the release and tested via:
mvn -Prun-its clean verify
Get a complete fine build without any issue on MacOS JDK11... Maven 3.6.1
so +1 from me...
Kind regards
Karl Heinz Marbaise
On 13.05.19 11:52, Enrico Olivelli wrote:
Hi,
We solved 13
checked the sha512 of src zip, ok
checked the build, failed (mvn verify -P run-its,quality-checks)
[INFO] Building: MCHECKSTYLE-54\pom.xml
[INFO] MCHECKSTYLE-54\pom.xml ... FAILED
(5.3 s)
*Mcheckstyle54.java:[1] (misc) NewlineAtEndOfFile: File does not end with
Hi,
We solved 13 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12342397=Text=12317223
Please note that this version now only supports CheckStyle 8+ and Java 8
(as required by latest Checkstyle)
There are still a couple of issues left in JIRA:
45 matches
Mail list logo
