---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24343/#review49699
---
src/master/master.hpp
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2286/changes
Changes:
[yujie.jay] Fixed two flaky tests in GarbageCollectorIntegrationTest.
[yan] Added a trailing space to _CheckFatal's output.
[vinodkone] Fixed docker validation and only run docker tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24356/#review49700
---
src/master/hierarchical_allocator_process.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24316/#review49707
---
Bad patch!
Reviews applied: [24316]
Failed command: git apply
See https://builds.apache.org/job/mesos-reviewbot/1283/
--
[...truncated 1740 lines...]
mv -f .deps/main.Tpo .deps/main.Po
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I..
-pthread -Wall -Wwrite-strings -Woverloaded-virtual
See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/252/changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24252/#review49738
---
Ship it!
Seems fine.
We should probably open a ticket to add
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23453/
---
(Updated Aug. 6, 2014, 4:33 p.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24343/#review49741
---
src/master/master.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24331/
---
(Updated Aug. 6, 2014, 9:41 a.m.)
Review request for mesos, Jie Yu and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24124/#review49744
---
Ship it!
src/slave/slave.cpp
On Aug. 6, 2014, 3:53 a.m., Ben Mahler wrote:
src/master/master.cpp, line 3466
https://reviews.apache.org/r/24286/diff/3/?file=653362#file653362line3466
I think we've been trying to name these with the _ as a suffix, akin to
prime notation: offer'
Done.
On Aug. 6, 2014, 3:53
On Aug. 6, 2014, 10:02 a.m., Jie Yu wrote:
src/master/hierarchical_allocator_process.hpp, lines 568-571
https://reviews.apache.org/r/24331/diff/3/?file=653875#file653875line568
Will this increase the logging a lot? Every time the framework launch
tasks with unused resources,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24331/
---
(Updated Aug. 6, 2014, 10:17 a.m.)
Review request for mesos, Jie Yu and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24331/#review49751
---
src/master/hierarchical_allocator_process.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23453/#review49752
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 6, 2014, 4:33 p.m.,
On Aug. 6, 2014, 5:19 p.m., Vinod Kone wrote:
Ship It!
@tim: want to commit this patch yourself with your new committer creds? let me
know if you need help on the right way to push upstream (e.g., no merge
commits).
- Vinod
---
On Aug. 6, 2014, 5:02 p.m., Jie Yu wrote:
src/master/hierarchical_allocator_process.hpp, lines 568-571
https://reviews.apache.org/r/24331/diff/3/?file=653875#file653875line568
Will this increase the logging a lot? Every time the framework launch
tasks with unused resources, we'll
On Aug. 6, 2014, 10:18 a.m., Jie Yu wrote:
src/master/hierarchical_allocator_process.hpp, lines 601-607
https://reviews.apache.org/r/24331/diff/3/?file=653875#file653875line601
What if 'frameworks' does not contain 'frameworkId'? What if
!slaves.contains(slaveId)?
nice catch!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24331/
---
(Updated Aug. 6, 2014, 10:31 a.m.)
Review request for mesos, Jie Yu and Vinod
On Aug. 6, 2014, 5:19 p.m., Vinod Kone wrote:
Ship It!
Vinod Kone wrote:
@tim: want to commit this patch yourself with your new committer creds?
let me know if you need help on the right way to push upstream (e.g., no
merge commits).
Sounds good! I need to finish my setup then
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24343/#review49761
---
include/mesos/mesos.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23772/#review49770
---
Ship it!
Ship It!
- Vinod Kone
On July 30, 2014, 9:14 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24331/#review49774
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 6, 2014, 5:31 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24331/#review49776
---
Ship it!
Ship It!
- Jie Yu
On Aug. 6, 2014, 5:31 p.m., Dominic
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24316/
---
(Updated Aug. 6, 2014, 6:52 p.m.)
Review request for mesos.
Changes
---
See https://builds.apache.org/job/mesos-reviewbot/1284/
--
[...truncated 5358 lines...]
rm -f tests/.deps/.dirstamp
rm -f log/tool/*.o
rm -f tests/.dirstamp
rm -f usage/.deps/.dirstamp
rm -f usage/.dirstamp
rm -f zookeeper/.deps/.dirstamp
rm -f
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24349/#review49786
---
Ship it!
include/mesos/mesos.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24349/
---
(Updated Aug. 6, 2014, 7:21 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24407/
---
Review request for mesos.
Repository: mesos-git
Description
---
If
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24407/
---
(Updated Aug. 6, 2014, 7:37 p.m.)
Review request for mesos and Timothy St.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24418/
---
Review request for mesos and Vinod Kone.
Bugs: MESOS-1677
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24419/
---
Review request for mesos and Vinod Kone.
Repository: mesos-git
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24418/#review49798
---
Ship it!
Ship It!
- Dominic Hamon
On Aug. 6, 2014, 12:55 p.m.,
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2287/changes
Changes:
[yujie.jay] Made ephemeral ports a resource and killed private resources.
[yujie.jay] Do not send ephemeral_ports resource to frameworks.
--
See https://builds.apache.org/job/mesos-reviewbot/1285/changes
Changes:
[yujie.jay] Made ephemeral ports a resource and killed private resources.
[yujie.jay] Do not send ephemeral_ports resource to frameworks.
[vinodkone] Create static mesos library.
[vinodkone] Re-enabled
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24418/#review49804
---
Ship it!
src/tests/allocator_tests.cpp
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2031/changes
Changes:
[yujie.jay] Made ephemeral ports a resource and killed private resources.
[yujie.jay] Do not send ephemeral_ports resource to frameworks.
[vinodkone] Create static mesos library.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24426/
---
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos-git
On Aug. 6, 2014, 9:01 p.m., Vinod Kone wrote:
src/tests/allocator_tests.cpp, lines 757-758
https://reviews.apache.org/r/24418/diff/1/?file=654066#file654066line757
calling process::teriminate() and ::wait() multiple times is safe i
assume?
Yes, it is.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24426/#review49809
---
Ship it!
Ship It!
- Dominic Hamon
On Aug. 6, 2014, 2:19 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24426/#review49811
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 6, 2014, 9:19 p.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24426/#review49813
---
Ship it!
3rdparty/libprocess/src/process.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24419/
---
(Updated Aug. 6, 2014, 9:43 p.m.)
Review request for mesos and Vinod Kone.
On Aug. 6, 2014, 6:37 a.m., Adam B wrote:
src/master/hierarchical_allocator_process.hpp, line 729
https://reviews.apache.org/r/24356/diff/1/?file=653338#file653338line729
In what order are you iterating through the slaves? What order should
it be?
Vinod Kone wrote:
good
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24356/
---
(Updated Aug. 6, 2014, 10:24 p.m.)
Review request for mesos, Adam B and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/
---
(Updated Aug. 6, 2014, 10:35 p.m.)
Review request for mesos and Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/#review49824
---
Ship it!
Cool. Mostly just a request for more comments so the next
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24356/
---
(Updated Aug. 6, 2014, 10:56 p.m.)
Review request for mesos, Adam B and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24316/#review49817
---
src/linux/cgroups.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24343/
---
(Updated Aug. 6, 2014, 4:13 p.m.)
Review request for mesos, Ben Mahler and
On Aug. 5, 2014, 11:25 p.m., Timothy Chen wrote:
src/master/master.hpp, line 766
https://reviews.apache.org/r/24343/diff/2/?file=653520#file653520line766
It also returns error when the rate limiter reachs its capacity too
right?
the rate limiter doesn't have a capacity.
-
On Aug. 6, 2014, 11:30 a.m., Vinod Kone wrote:
src/tests/rate_limiting_tests.cpp, lines 973-975
https://reviews.apache.org/r/24343/diff/2/?file=653522#file653522line973
Isn't this already done by StartMaster()?
Yes. I lost track of the change :)
On Aug. 6, 2014, 11:30 a.m.,
On Aug. 6, 2014, 9:38 a.m., Dominic Hamon wrote:
src/master/master.cpp, line 375
https://reviews.apache.org/r/24343/diff/2/?file=653521#file653521line375
Optionsize_t capacity;
if (limit_.has_capacity()) {
capacity = limit_.capacity();
}
should work
See https://builds.apache.org/job/mesos-reviewbot/1286/changes
Changes:
[yujie.jay] Changed socket closed while receiving to VLOG(2).
[yujie.jay] Fixed two flaky tests in AllocatorTest.
[tstclair] MESOS-1170 Unbundle glog
[vinodkone] Checked docker validation status code.
I committed a fix for these style errors:
https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=commit;h=9075ad6526d0b4e0e268f3df120a480fb6c21d4f
--
Jiang Yan Xu y...@jxu.me @xujyan http://twitter.com/xujyan
On Wed, Aug 6, 2014 at 4:22 PM, Apache Jenkins Server
jenk...@builds.apache.org wrote:
Hi guys,
I think it is in communities interest to lower the barrier to entry for new
contributors to the project. Not only in terms of process (as BenH has been
putting a lot of effort into - bravo!) but also in terms of making it
easier to understand the inner workings of Mesos.
So far, it is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24343/
---
(Updated Aug. 6, 2014, 4:37 p.m.)
Review request for mesos, Ben Mahler and
On Aug. 5, 2014, 2:29 p.m., Vinod Kone wrote:
src/slave/slave.cpp, lines 1330-1341
https://reviews.apache.org/r/23912/diff/3/?file=643812#file643812line1330
I would recommend pulling this logic outside 'if (executor == NULL)' to
#1326 to make it easy to reason about.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23912/
---
(Updated Aug. 6, 2014, 4:51 p.m.)
Review request for mesos.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24343/#review49831
---
src/master/master.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24430/
---
Review request for mesos, Adam B and Benjamin Hindman.
Repository: mesos-git
On Aug. 6, 2014, 10:44 p.m., Benjamin Hindman wrote:
src/Makefile.am, lines 977-978
https://reviews.apache.org/r/24264/diff/2/?file=652336#file652336line977
Just my ignorance here, but do you need to specify --dist-dir= twice?
Once for bdist_egg and once for bdist_wheel?
+1
On Wed, Aug 6, 2014 at 4:32 PM, Niklas Nielsen n...@qni.dk wrote:
Hi guys,
I think it is in communities interest to lower the barrier to entry for new
contributors to the project. Not only in terms of process (as BenH has been
putting a lot of effort into - bravo!) but also in terms of
On Aug. 6, 2014, 4:53 p.m., Dominic Hamon wrote:
src/master/master.hpp, line 770
https://reviews.apache.org/r/24343/diff/3/?file=654314#file654314line770
this should either be a uint64 (to match the proto) or the proto should
be a uint32 (to be reasonable). There's no real
+1
It would be great to also host the /help endpoint and also document all the
endpoints in it.
On Wed, Aug 6, 2014 at 5:05 PM, Vinod Kone vinodk...@gmail.com wrote:
+1
On Wed, Aug 6, 2014 at 4:32 PM, Niklas Nielsen n...@qni.dk wrote:
Hi guys,
I think it is in communities interest
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24343/
---
(Updated Aug. 6, 2014, 5:25 p.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24343/#review49844
---
Ship it!
src/master/master.hpp
See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/254/changes
Changes:
[vinodkone] Re-enabled HealthCheckTest.ConsecutiveFailures test.
[dhamon] Merge resourcesRecovered and resourcesUnused.
[yujie.jay] Added executor metrics for slave.
[yujie.jay] Changed socket closed while receiving
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24430/#review49852
---
Ship it!
Ship It!
- Adam B
On Aug. 6, 2014, 4:54 p.m., Niklas
+1 on comments on public classes/methods
+1 on auto-generating and hosting doxygen (on ASF or mesosphere or wherever)
I don't care what annotation style we use, as long as we're consistent
On Wed, Aug 6, 2014 at 5:18 PM, Julien Eid jei...@gmail.com wrote:
+1
It would be great to also host
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2288/changes
Changes:
[vinodkone] Create static mesos library.
[vinodkone] Re-enabled HealthCheckTest.ConsecutiveFailures test.
[dhamon] Merge resourcesRecovered and resourcesUnused.
[yujie.jay] Added
Cool!
I will try to look into how to host this if there are no objections by EOD
tomorrow.
Dave, do you know the next steps / a good place where we could do this?
Cheers,
Niklas
On Wed, Aug 6, 2014 at 6:29 PM, Adam Bordelon a...@mesosphere.io wrote:
+1 on comments on public classes/methods
I wonder if apache infra have anything for this?
Tim
Sent from my iPhone
On Aug 6, 2014, at 6:41 PM, Niklas Nielsen n...@qni.dk wrote:
Cool!
I will try to look into how to host this if there are no objections by EOD
tomorrow.
Dave, do you know the next steps / a good place where we
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2032/changes
Changes:
[vinodkone] Re-enabled HealthCheckTest.ConsecutiveFailures test.
[dhamon] Merge resourcesRecovered and resourcesUnused.
[yujie.jay] Added executor metrics for slave.
[yujie.jay] Changed
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24270/#review49857
---
Patch looks great!
Reviews applied: [24270]
All tests passed.
-
See https://builds.apache.org/job/mesos-reviewbot/1287/changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24440/
---
(Updated Aug. 7, 2014, 2:30 a.m.)
Review request for mesos, Benjamin Hindman
Niklas,
The docs currently rendered on the website are generated via tasks in a
Rakefile: http://svn.apache.org/repos/asf/mesos/site/Rakefile
You should be able to call doxygen from the command-line, similar to
how javadoc
is called.
Dave
On Wed, Aug 6, 2014 at 7:00 PM, Timothy Chen
Niklas,
The docs currently rendered on the website are generated via tasks in a
Rakefile: http://svn.apache.org/repos/asf/mesos/site/Rakefile
You should be able to call doxygen from the command-line, similar to
how javadoc
is called.
Dave
On Wed, Aug 6, 2014 at 7:00 PM, Timothy Chen
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2298/changes
Changes:
[yujie.jay] Changed socket closed while receiving to VLOG(2).
[yujie.jay] Fixed two flaky tests in AllocatorTest.
[tstclair] MESOS-1170 Unbundle glog
See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/255/changes
82 matches
Mail list logo
