That's true, if the scheduler waits until the control task is RUNNING before
doing anything else, this problem goes away. There's also then no need to rely
on the order tasks are launched on the executor.
Thanks everyone!
On Tue, Sep 30, 2014 at 5:51 PM, Benjamin Mahler
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26229/
---
Review request for mesos, Ben Mahler, Ian Downes, Jie Yu, and Till Toenshoff.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26229/#review55077
---
Patch looks great!
Reviews applied: [26229]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26229/#review55084
---
I'm curious why this is useful. Is there some code elsewhere that
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24536/#review55028
---
LGTM. The only concern I have is about the truncate() (see my
Thanks Henning!
- Original Message -
From: Henning Schmiedehausen henn...@schmiedehausen.org
To: mesos dev@mesos.apache.org, u...@mesos.apache.org
Sent: Tuesday, September 30, 2014 10:31:02 PM
Subject: Release of jesos 1.0 - pure java bindings for Apache Mesos
Hi,
I am happy to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26236/
---
Review request for mesos, Jie Yu and Cong Wang.
Bugs: mesos-1808
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26090/
---
(Updated Oct. 1, 2014, 6:01 p.m.)
Review request for mesos, Ian Downes, Jie
On Sept. 29, 2014, 5:25 p.m., Ian Downes wrote:
src/slave/containerizer/isolators/network/port_mapping.cpp, line 1752
https://reviews.apache.org/r/26090/diff/2/?file=707526#file707526line1752
Why the change in log message, it does't make sense now? e.g., The
launcher for updating
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26090/#review55100
---
Bad patch!
Reviews applied: [26236, 26090]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26236/#review55101
---
Ship it!
src/linux/routing/diagnosis/diagnosis.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26214/
---
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
(proserpina.apache.org) with id
20141001-012827-3176252227-55929-23806-0
I1001 01:28:30.389865 23825 registrar.cpp:421] Attempting to update the
'registry'
I1001 01:28:30.391315 23829 log.cpp:680] Attempting to append 323 bytes to
the log
I1001 01:28:30.391371 23829 coordinator.cpp:340] Coordinator attempting
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26214/#review55104
---
3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26214/#review55106
---
Bad patch!
Reviews applied: [24535, 24536, 24537, 26214]
Failed
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26236/
---
(Updated Oct. 1, 2014, 6:33 p.m.)
Review request for mesos, Jie Yu and Cong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23912/#review55092
---
src/slave/slave.cpp
On Oct. 1, 2014, 6:09 p.m., Mesos ReviewBot wrote:
Bad patch!
Reviews applied: [26236, 26090]
Failed command: ./support/mesos-style.py
Error:
Checking 510 files using filter
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26242/
---
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26159/#review55114
---
Ship it!
Ah much better.
I noticed some of the framework name
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26243/
---
Review request for mesos and Vinod Kone.
Bugs: MESOS-1854
On Sept. 29, 2014, 9:57 p.m., Niklas Nielsen wrote:
include/mesos/module.hpp.in, lines 46-47
https://reviews.apache.org/r/25848/diff/11/?file=708522#file708522line46
Can we use existing boost helpers for this? Something like
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26242/#review55126
---
Patch looks great!
Reviews applied: [26242]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26243/#review55128
---
Ship it!
Ship It!
- Vinod Kone
On Oct. 1, 2014, 7:20 p.m., Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/#review55065
---
include/mesos/module.hpp.in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26245/
---
Review request for mesos.
Repository: mesos-git
Description
---
With
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26247/
---
Review request for mesos.
Repository: mesos-git
Description
---
These
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26246/
---
Review request for mesos.
Repository: mesos-git
Description
---
With
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26245/#review55130
---
3rdparty/libprocess/3rdparty/stout/include/stout/list.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26245/
---
(Updated Oct. 1, 2014, 2:18 p.m.)
Review request for mesos and Dominic Hamon.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26245/#review55131
---
3rdparty/libprocess/3rdparty/stout/include/stout/list.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26198/#review55136
---
Ship it!
Ship It!
- Vinod Kone
On Sept. 30, 2014, 11:30 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26246/#review55133
---
3rdparty/libprocess/include/process/async.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26246/
---
(Updated Oct. 1, 2014, 2:26 p.m.)
Review request for mesos and Dominic Hamon.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26247/#review55140
---
src/slave/containerizer/docker.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26247/
---
(Updated Oct. 1, 2014, 2:30 p.m.)
Review request for mesos and Dominic Hamon.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26200/#review55141
---
Ship it!
src/master/master.cpp
On Sept. 22, 2014, 7:19 p.m., Ben Mahler wrote:
docs/mesos-c++-style-guide.md, lines 96-99
https://reviews.apache.org/r/25622/diff/3/?file=699636#file699636line96
Why would the iterator be called `containerizer`?
s/containerizer/iterator/ ?
Dominic Hamon wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26090/#review55134
---
The test looks good. See my comments.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26201/#review55144
---
Ship it!
src/messages/messages.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26246/#review55138
---
3rdparty/libprocess/include/process/async.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26202/#review55145
---
Ship it!
Ship It!
- Vinod Kone
On Sept. 30, 2014, 11:30 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26203/#review55146
---
Ship it!
Ship It!
- Vinod Kone
On Sept. 30, 2014, 11:30 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26247/#review55147
---
Bad patch!
Reviews applied: [26247]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26204/#review55148
---
Ship it!
src/master/master.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26205/#review55149
---
Ship it!
Ship It!
- Vinod Kone
On Sept. 30, 2014, 11:31 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26246/#review55151
---
Bad patch!
Reviews applied: [26246]
Failed command:
Greetings Folks -
I'm on the docket for ApacheCon EU, and was planning on giving a
state-of-the-state talk for Mesos seeing how I didn't see others on the
schedule.
I'd be happy to collaborate on the content if there are certain features folks
wanted to highlight, or if you're just
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26206/#review55152
---
Ship it!
src/slave/slave.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26207/#review55155
---
Ship it!
Ship It!
- Vinod Kone
On Sept. 30, 2014, 11:31 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26199/#review55156
---
Ship it!
src/master/master.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26208/#review55157
---
Ship it!
src/tests/master_slave_reconciliation_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/
---
(Updated Oct. 1, 2014, 7:18 p.m.)
Review request for mesos, Benjamin Hindman,
On Oct. 1, 2014, 4:35 p.m., Benjamin Hindman wrote:
include/mesos/module.hpp.in, line 42
https://reviews.apache.org/r/25848/diff/12/?file=709880#file709880line42
Why aren't we just using MESOS_VERSION from mesos/mesos.hpp(.in)? I
don't like the idea of introducing another macro
On Oct. 1, 2014, 1:35 p.m., Benjamin Hindman wrote:
src/module/manager.cpp, line 59
https://reviews.apache.org/r/25848/diff/12/?file=709886#file709886line59
Maybe I'm just getting a big grumpy, but I'm really not in favor of
overloading the term 'role' here. We've overloaded
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26253/
---
Review request for mesos and Jay Buffington.
Bugs: MESOS-1835
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2409/changes
master.cpp:1320] Authorizing framework principal
'test-principal' to receive offers for role '*'
I1001 23:42:16.975977 28257 master.cpp:1419] Registering framework
20141001-234216-3193029443-50480-28228- at
scheduler-0f164a3b-ec86-4e26-b556-5bf2ac8e7553@67.195.81.190:50480
I1001 23:42
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25818/#review55162
---
Ship it!
Looks great. I can add the blank line and commit it.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26253/#review55163
---
Patch looks great!
Reviews applied: [26253]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26125/
---
(Updated Oct. 2, 2014, 12:19 a.m.)
Review request for mesos.
Changes
---
On Sept. 30, 2014, 9:16 p.m., Niklas Nielsen wrote:
src/webui/master/static/framework.html, lines 22-23
https://reviews.apache.org/r/26125/diff/1/?file=707772#file707772line22
Will this be shown no matter if the framework announced a framework
webui or not? Can we make it
A bit worried that slave-resources() could be confused with
slave-info.resources().
Maybe slave-allocated() feels better to you?
Callers will have the type available at the call-site, since we have static
typing to force them to understand what type is being returned:
hashmapFrameworkID,
On Oct. 1, 2014, 11:05 p.m., Vinod Kone wrote:
src/master/master.cpp, line 4293
https://reviews.apache.org/r/26199/diff/1/?file=709864#file709864line4293
hmmm. slave-used() doesn't really tell what is being returned here.
how about calling it slave-resources() instead. do you
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26254/#review55174
---
Patch looks great!
Reviews applied: [26254]
All tests passed.
-
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2139/changes
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2140/changes
Changes:
[adam] Switched path::join() to be variadic
--
[...truncated 234 lines...]
3rdparty/Makefile.am:145: but option 'subdir-objects' is disabled
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26256/
---
Review request for mesos, Adam B and Vinod Kone.
Bugs: MESOS-1857
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26125/#review55182
---
Patch looks great!
Reviews applied: [26125]
All tests passed.
-
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2411/changes
Changes:
[adam] Switched path::join() to be variadic
--
[...truncated 48978 lines...]
I1002 02:47:01.653427 16003
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26253/
---
(Updated Oct. 2, 2014, 3:36 a.m.)
Review request for mesos and Jay Buffington.
On Oct. 2, 2014, 12:29 a.m., Timothy Chen wrote:
3rdparty/libprocess/src/process.cpp, line 1546
https://reviews.apache.org/r/26253/diff/1/?file=710390#file710390line1546
I assume this is tested on a big-endian system?
Sorry for that. Unfortunately I don't have a big-endian machine.
On Oct. 2, 2014, 12:24 a.m., Jay Buffington wrote:
3rdparty/libprocess/src/process.cpp, line 1546
https://reviews.apache.org/r/26253/diff/1/?file=710390#file710390line1546
If inet_ntop returns NULL you should log a PLOG(FATAL) message.
Thank you for pointing that out.
- Evelina
73 matches
Mail list logo