Re: scheduler.killExecutor()

2014-10-01 Thread Tom Arnfeld
That's true, if the scheduler waits until the control task is RUNNING before doing anything else, this problem goes away. There's also then no need to rely on the order tasks are launched on the executor. Thanks everyone! On Tue, Sep 30, 2014 at 5:51 PM, Benjamin Mahler

Review Request 26229: Expose poll interval from the reaper.

2014-10-01 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26229/ --- Review request for mesos, Ben Mahler, Ian Downes, Jie Yu, and Till Toenshoff.

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26229/#review55077 --- Patch looks great! Reviews applied: [26229] All tests passed. -

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-01 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26229/#review55084 --- I'm curious why this is useful. Is there some code elsewhere that

Re: Review Request 24536: Added DIFF to the replicated log state storage implementation.

2014-10-01 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24536/#review55028 --- LGTM. The only concern I have is about the truncate() (see my

Re: Release of jesos 1.0 - pure java bindings for Apache Mesos

2014-10-01 Thread Tim St Clair
Thanks Henning! - Original Message - From: Henning Schmiedehausen henn...@schmiedehausen.org To: mesos dev@mesos.apache.org, u...@mesos.apache.org Sent: Tuesday, September 30, 2014 10:31:02 PM Subject: Release of jesos 1.0 - pure java bindings for Apache Mesos Hi, I am happy to

Review Request 26236: routing::diagnositics: Changed State from enum to int so they can be bitwiseor'ed together.

2014-10-01 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26236/ --- Review request for mesos, Jie Yu and Cong Wang. Bugs: mesos-1808

Re: Review Request 26090: PortMappingIsolator: added support to include RTT and RTTvar in the statistics.

2014-10-01 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26090/ --- (Updated Oct. 1, 2014, 6:01 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 26090: PortMappingIsolator: added support to include RTT and RTTvar in the statistics.

2014-10-01 Thread Chi Zhang
On Sept. 29, 2014, 5:25 p.m., Ian Downes wrote: src/slave/containerizer/isolators/network/port_mapping.cpp, line 1752 https://reviews.apache.org/r/26090/diff/2/?file=707526#file707526line1752 Why the change in log message, it does't make sense now? e.g., The launcher for updating

Re: Review Request 26090: PortMappingIsolator: added support to include RTT and RTTvar in the statistics.

2014-10-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26090/#review55100 --- Bad patch! Reviews applied: [26236, 26090] Failed command:

Re: Review Request 26236: routing::diagnositics: Changed State from enum to int so they can be bitwiseor'ed together.

2014-10-01 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26236/#review55101 --- Ship it! src/linux/routing/diagnosis/diagnosis.hpp

Review Request 26214: Add apr and svn to configure.ac

2014-10-01 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26214/ --- Review request for mesos and Benjamin Hindman. Repository: mesos-git

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2408

2014-10-01 Thread Benjamin Mahler
(proserpina.apache.org) with id 20141001-012827-3176252227-55929-23806-0 I1001 01:28:30.389865 23825 registrar.cpp:421] Attempting to update the 'registry' I1001 01:28:30.391315 23829 log.cpp:680] Attempting to append 323 bytes to the log I1001 01:28:30.391371 23829 coordinator.cpp:340] Coordinator attempting

Re: Review Request 26214: Add apr and svn to configure.ac

2014-10-01 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26214/#review55104 --- 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp

Re: Review Request 26214: Add apr and svn to configure.ac

2014-10-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26214/#review55106 --- Bad patch! Reviews applied: [24535, 24536, 24537, 26214] Failed

Re: Review Request 26236: routing::diagnositics: Changed State from enum to int so they can be bitwiseor'ed together.

2014-10-01 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26236/ --- (Updated Oct. 1, 2014, 6:33 p.m.) Review request for mesos, Jie Yu and Cong

Re: Review Request 23912: Fix MESOS-947: Slave should properly handle a killTask() that arrives between runTask() and _runTask()

2014-10-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23912/#review55092 --- src/slave/slave.cpp

Re: Review Request 26090: PortMappingIsolator: added support to include RTT and RTTvar in the statistics.

2014-10-01 Thread Chi Zhang
On Oct. 1, 2014, 6:09 p.m., Mesos ReviewBot wrote: Bad patch! Reviews applied: [26236, 26090] Failed command: ./support/mesos-style.py Error: Checking 510 files using filter

Review Request 26242: Changed checkpoint logging from LOG(INFO) to VLOG(1).

2014-10-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26242/ --- Review request for mesos and Ben Mahler. Repository: mesos-git Description

Re: Review Request 26159: Fixed framework logging in master.cpp.

2014-10-01 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26159/#review55114 --- Ship it! Ah much better. I noticed some of the framework name

Review Request 26243: Fixed the flaky SlaveRecoverTest.MultipleSlaves.

2014-10-01 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26243/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-1854

Re: Review Request 25848: Introducing mesos modules.

2014-10-01 Thread Timothy St. Clair
On Sept. 29, 2014, 9:57 p.m., Niklas Nielsen wrote: include/mesos/module.hpp.in, lines 46-47 https://reviews.apache.org/r/25848/diff/11/?file=708522#file708522line46 Can we use existing boost helpers for this? Something like

Re: Review Request 26242: Changed checkpoint logging from LOG(INFO) to VLOG(1).

2014-10-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26242/#review55126 --- Patch looks great! Reviews applied: [26242] All tests passed. -

Re: Review Request 26243: Fixed the flaky SlaveRecoverTest.MultipleSlaves.

2014-10-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26243/#review55128 --- Ship it! Ship It! - Vinod Kone On Oct. 1, 2014, 7:20 p.m., Ben

Re: Review Request 25848: Introducing mesos modules.

2014-10-01 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25848/#review55065 --- include/mesos/module.hpp.in

Review Request 26245: Remove usage of stout/preprocessor.hpp from stout.

2014-10-01 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26245/ --- Review request for mesos. Repository: mesos-git Description --- With

Review Request 26247: Remove usage of stout/preprocessor.hpp from mesos.

2014-10-01 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26247/ --- Review request for mesos. Repository: mesos-git Description --- These

Review Request 26246: Remove usage of stout/preprocessor.hpp from libprocess.

2014-10-01 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26246/ --- Review request for mesos. Repository: mesos-git Description --- With

Re: Review Request 26245: Remove usage of stout/preprocessor.hpp from stout.

2014-10-01 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26245/#review55130 --- 3rdparty/libprocess/3rdparty/stout/include/stout/list.hpp

Re: Review Request 26245: Remove usage of stout/preprocessor.hpp from stout.

2014-10-01 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26245/ --- (Updated Oct. 1, 2014, 2:18 p.m.) Review request for mesos and Dominic Hamon.

Re: Review Request 26245: Remove usage of stout/preprocessor.hpp from stout.

2014-10-01 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26245/#review55131 --- 3rdparty/libprocess/3rdparty/stout/include/stout/list.hpp

Re: Review Request 26198: Fixed a log line in the master.

2014-10-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26198/#review55136 --- Ship it! Ship It! - Vinod Kone On Sept. 30, 2014, 11:30 p.m.,

Re: Review Request 26246: Remove usage of stout/preprocessor.hpp from libprocess.

2014-10-01 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26246/#review55133 --- 3rdparty/libprocess/include/process/async.hpp

Re: Review Request 26246: Remove usage of stout/preprocessor.hpp from libprocess.

2014-10-01 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26246/ --- (Updated Oct. 1, 2014, 2:26 p.m.) Review request for mesos and Dominic Hamon.

Re: Review Request 26247: Remove usage of stout/preprocessor.hpp from mesos.

2014-10-01 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26247/#review55140 --- src/slave/containerizer/docker.cpp

Re: Review Request 26247: Remove usage of stout/preprocessor.hpp from mesos.

2014-10-01 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26247/ --- (Updated Oct. 1, 2014, 2:30 p.m.) Review request for mesos and Dominic Hamon.

Re: Review Request 26200: Added validation for missing ExecutorInfo::framework_id.

2014-10-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26200/#review55141 --- Ship it! src/master/master.cpp

Re: Review Request 25622: Update the Mesos Style Guide with C++11 and naming notes.

2014-10-01 Thread Cody Maloney
On Sept. 22, 2014, 7:19 p.m., Ben Mahler wrote: docs/mesos-c++-style-guide.md, lines 96-99 https://reviews.apache.org/r/25622/diff/3/?file=699636#file699636line96 Why would the iterator be called `containerizer`? s/containerizer/iterator/ ? Dominic Hamon wrote:

Re: Review Request 26090: PortMappingIsolator: added support to include RTT and RTTvar in the statistics.

2014-10-01 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26090/#review55134 --- The test looks good. See my comments.

Re: Review Request 26201: Properly deprecated ReregisterSlaveMessage::slave_id.

2014-10-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26201/#review55144 --- Ship it! src/messages/messages.proto

Re: Review Request 26246: Remove usage of stout/preprocessor.hpp from libprocess.

2014-10-01 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26246/#review55138 --- 3rdparty/libprocess/include/process/async.hpp

Re: Review Request 26202: Introduced a version during slave (re-)registration.

2014-10-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26202/#review55145 --- Ship it! Ship It! - Vinod Kone On Sept. 30, 2014, 11:30 p.m.,

Re: Review Request 26203: Removed redundant logging in the Master.

2014-10-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26203/#review55146 --- Ship it! Ship It! - Vinod Kone On Sept. 30, 2014, 11:30 p.m.,

Re: Review Request 26247: Remove usage of stout/preprocessor.hpp from mesos.

2014-10-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26247/#review55147 --- Bad patch! Reviews applied: [26247] Failed command:

Re: Review Request 26204: Removed the need for Master::readdSlave.

2014-10-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26204/#review55148 --- Ship it! src/master/master.cpp

Re: Review Request 26205: Cleaned up Master::addFramework.

2014-10-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26205/#review55149 --- Ship it! Ship It! - Vinod Kone On Sept. 30, 2014, 11:31 p.m.,

Re: Review Request 26246: Remove usage of stout/preprocessor.hpp from libprocess.

2014-10-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26246/#review55151 --- Bad patch! Reviews applied: [26246] Failed command:

ApacheCon EU - Mesos Talk

2014-10-01 Thread Tim St Clair
Greetings Folks - I'm on the docket for ApacheCon EU, and was planning on giving a state-of-the-state talk for Mesos seeing how I didn't see others on the schedule. I'd be happy to collaborate on the content if there are certain features folks wanted to highlight, or if you're just

Re: Review Request 26206: Introduced Master - Slave reconciliation.

2014-10-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26206/#review55152 --- Ship it! src/slave/slave.cpp

Re: Review Request 26207: Split out partition and reconciliation tests from FaultTolerace tests.

2014-10-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26207/#review55155 --- Ship it! Ship It! - Vinod Kone On Sept. 30, 2014, 11:31 p.m.,

Re: Review Request 26199: Eliminated redundant resource accounting in the master.

2014-10-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26199/#review55156 --- Ship it! src/master/master.cpp

Re: Review Request 26208: Added a test for the Master - Slave reconciliation race.

2014-10-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26208/#review55157 --- Ship it! src/tests/master_slave_reconciliation_tests.cpp

Re: Review Request 25848: Introducing mesos modules.

2014-10-01 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25848/ --- (Updated Oct. 1, 2014, 7:18 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 25848: Introducing mesos modules.

2014-10-01 Thread Kapil Arya
On Oct. 1, 2014, 4:35 p.m., Benjamin Hindman wrote: include/mesos/module.hpp.in, line 42 https://reviews.apache.org/r/25848/diff/12/?file=709880#file709880line42 Why aren't we just using MESOS_VERSION from mesos/mesos.hpp(.in)? I don't like the idea of introducing another macro

Re: Review Request 25848: Introducing mesos modules.

2014-10-01 Thread Niklas Nielsen
On Oct. 1, 2014, 1:35 p.m., Benjamin Hindman wrote: src/module/manager.cpp, line 59 https://reviews.apache.org/r/25848/diff/12/?file=709886#file709886line59 Maybe I'm just getting a big grumpy, but I'm really not in favor of overloading the term 'role' here. We've overloaded

Review Request 26253: Check for IP address being localhost not platform independent

2014-10-01 Thread Evelina Dumitrescu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26253/ --- Review request for mesos and Jay Buffington. Bugs: MESOS-1835

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2409

2014-10-01 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2409/changes

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2138

2014-10-01 Thread Apache Jenkins Server
master.cpp:1320] Authorizing framework principal 'test-principal' to receive offers for role '*' I1001 23:42:16.975977 28257 master.cpp:1419] Registering framework 20141001-234216-3193029443-50480-28228- at scheduler-0f164a3b-ec86-4e26-b556-5bf2ac8e7553@67.195.81.190:50480 I1001 23:42

Re: Review Request 25818: Switch path::join() to be variadic

2014-10-01 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25818/#review55162 --- Ship it! Looks great. I can add the blank line and commit it.

Re: Review Request 26253: Check for IP address being localhost not platform independent

2014-10-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26253/#review55163 --- Patch looks great! Reviews applied: [26253] All tests passed. -

Re: Review Request 26125: Add webui_url to FrameworkInfo and web UI

2014-10-01 Thread Tobi Knaup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26125/ --- (Updated Oct. 2, 2014, 12:19 a.m.) Review request for mesos. Changes ---

Re: Review Request 26125: Add webui_url to FrameworkInfo and web UI

2014-10-01 Thread Tobi Knaup
On Sept. 30, 2014, 9:16 p.m., Niklas Nielsen wrote: src/webui/master/static/framework.html, lines 22-23 https://reviews.apache.org/r/26125/diff/1/?file=707772#file707772line22 Will this be shown no matter if the framework announced a framework webui or not? Can we make it

Re: Review Request 26199: Eliminated redundant resource accounting in the master.

2014-10-01 Thread Benjamin Mahler
A bit worried that slave-resources() could be confused with slave-info.resources(). Maybe slave-allocated() feels better to you? Callers will have the type available at the call-site, since we have static typing to force them to understand what type is being returned: hashmapFrameworkID,

Re: Review Request 26199: Eliminated redundant resource accounting in the master.

2014-10-01 Thread Vinod Kone
On Oct. 1, 2014, 11:05 p.m., Vinod Kone wrote: src/master/master.cpp, line 4293 https://reviews.apache.org/r/26199/diff/1/?file=709864#file709864line4293 hmmm. slave-used() doesn't really tell what is being returned here. how about calling it slave-resources() instead. do you

Re: Review Request 26254: Replaced default port value for mesos master in documentation

2014-10-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26254/#review55174 --- Patch looks great! Reviews applied: [26254] All tests passed. -

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2139

2014-10-01 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2139/changes

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2140

2014-10-01 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2140/changes Changes: [adam] Switched path::join() to be variadic -- [...truncated 234 lines...] 3rdparty/Makefile.am:145: but option 'subdir-objects' is disabled

Review Request 26256: MESOS-1857 Fix path::join() on older libstdc++ which lack back()

2014-10-01 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26256/ --- Review request for mesos, Adam B and Vinod Kone. Bugs: MESOS-1857

Re: Review Request 26125: Add webui_url to FrameworkInfo and web UI

2014-10-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26125/#review55182 --- Patch looks great! Reviews applied: [26125] All tests passed. -

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2411

2014-10-01 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2411/changes Changes: [adam] Switched path::join() to be variadic -- [...truncated 48978 lines...] I1002 02:47:01.653427 16003

Re: Review Request 26253: Check for IP address being localhost not platform independent

2014-10-01 Thread Evelina Dumitrescu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26253/ --- (Updated Oct. 2, 2014, 3:36 a.m.) Review request for mesos and Jay Buffington.

Re: Review Request 26253: Check for IP address being localhost not platform independent

2014-10-01 Thread Evelina Dumitrescu
On Oct. 2, 2014, 12:29 a.m., Timothy Chen wrote: 3rdparty/libprocess/src/process.cpp, line 1546 https://reviews.apache.org/r/26253/diff/1/?file=710390#file710390line1546 I assume this is tested on a big-endian system? Sorry for that. Unfortunately I don't have a big-endian machine.

Re: Review Request 26253: Check for IP address being localhost not platform independent

2014-10-01 Thread Evelina Dumitrescu
On Oct. 2, 2014, 12:24 a.m., Jay Buffington wrote: 3rdparty/libprocess/src/process.cpp, line 1546 https://reviews.apache.org/r/26253/diff/1/?file=710390#file710390line1546 If inet_ntop returns NULL you should log a PLOG(FATAL) message. Thank you for pointing that out. - Evelina