---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26622/#review57997
---
src/slave/slave.cpp
On Oct. 14, 2014, 9:06 p.m., Timothy St. Clair wrote:
configure.ac, line 281
https://reviews.apache.org/r/26426/diff/1/?file=714874#file714874line281
Is there a reason you want to leave debug symbols out of optimized
builds?
cmake has the pattern correct imho:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26766/
---
(Updated Oct. 23, 2014, 4:52 p.m.)
Review request for mesos, Ben Mahler and
On Oct. 17, 2014, 7:33 a.m., Timothy Chen wrote:
src/files/files.cpp, line 59
https://reviews.apache.org/r/26767/diff/1/?file=722434#file722434line59
path asAbsolute as I remember is just sticking a / in front if it
doesn't exist. It seems like it's only relevant in this query
On Oct. 16, 2014, 4:38 a.m., Timothy Chen wrote:
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp, line 25
https://reviews.apache.org/r/26766/diff/1/?file=722432#file722432line25
Without starting to look at what RoundTrip does I really have no clue
what it means, since it
On Oct. 17, 2014, 9:01 p.m., Ben Mahler wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, line 33
https://reviews.apache.org/r/26766/diff/1/?file=722431#file722431line33
Hm.. what is asAbsolute doing? I would have expected this to be
equivalent to `realpath()`
On Oct. 17, 2014, 12:54 a.m., Vinod Kone wrote:
support/mesos_split.py, line 27
https://reviews.apache.org/r/26825/diff/1/?file=723339#file723339line27
It's weird that this script talks about commits but takes a list of
files. Why not have it take it a commit sha and let it
On Oct. 22, 2014, 8:44 a.m., Adam B wrote:
support/mesos_split.py, line 63
https://reviews.apache.org/r/26825/diff/2/?file=728014#file728014line63
Did you intend to have two spaces before the %s? I would think a single
space would be enough.
The goal is that they are visibly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26825/
---
(Updated Oct. 23, 2014, 5:17 p.m.)
Review request for mesos, Adam B and Vinod
On Oct. 23, 2014, 11:03 a.m., Timothy Chen wrote:
src/slave/slave.cpp, line 2567
https://reviews.apache.org/r/26622/diff/2/?file=719277#file719277line2567
Thanks for the fix! I wonder if we should just fix the command executor
instead?
I usually don't like mingling
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25861/
---
(Updated Oct. 23, 2014, 10:39 a.m.)
Review request for mesos, Jie Yu and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24177/
---
(Updated Oct. 23, 2014, 10:40 a.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27090/
---
Review request for mesos and Jie Yu.
Repository: mesos-git
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26767/#review58025
---
Patch looks great!
Reviews applied: [26766, 26767]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27092/
---
Review request for mesos, Ben Mahler and Jie Yu.
Repository: mesos-git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27091/
---
Review request for mesos, Ben Mahler and Jie Yu.
Repository: mesos-git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25966/
---
(Updated Oct. 23, 2014, 10:46 a.m.)
Review request for mesos, Jie Yu and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25966/
---
(Updated Oct. 23, 2014, 10:48 a.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25865/
---
(Updated Oct. 23, 2014, 10:48 a.m.)
Review request for mesos, Jie Yu and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25865/
---
(Updated Oct. 23, 2014, 10:49 a.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25865/
---
(Updated Oct. 23, 2014, 10:48 a.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20423/
---
(Updated Oct. 23, 2014, 10:51 a.m.)
Review request for mesos and Benjamin
Apologies for the delay in sending this out .. we were having some JIRA
issues.
Link to sprint board
https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=35
Isolation
- /tmp isolation
- replacing freezer with PID namespaces
Reconciliation
- fixing some edge-cases
-
Taking a look.
On Wed, Oct 22, 2014 at 4:50 PM, Apache Jenkins Server
jenk...@builds.apache.org wrote:
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2473/changes
Changes:
[dhamon] Differentiate between slave and offer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26796/#review58040
---
Ship it!
Ship It!
- Niklas Nielsen
On Oct. 22, 2014, 12:50
Looks like there was a complete stall in the test, based on the logging
timestamps. Also note the out-of-order timestamps:
1022 *23:49:59*.147037 28617 slave.cpp:2197] Handling status update
TASK_FINISHED (UUID: 9eedb006-7959-48e3-bd57-b460298fc842) for task 0
of framework
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26150/
---
(Updated Oct. 23, 2014, 6:50 p.m.)
Review request for mesos and Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26825/#review58057
---
Patch looks great!
Reviews applied: [26825]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27094/
---
Review request for mesos.
Bugs: MESOS-1971
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27105/
---
Review request for mesos, Jie Yu and Cong Wang.
Bugs: mesos-1967
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27102/
---
Review request for mesos, Ben Mahler and Dominic Hamon.
Bugs: MESOS-1972
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25966/#review58058
---
Bad patch!
Reviews applied: [27091, 25865]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27102/#review58060
---
src/master/master.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27105/#review58062
---
src/linux/routing/utils.cpp
Hi,
I'd like some feedback on switching the default of cgroups_limit_swap
flag to true in 0.21.0.
Currently we're not limiting swap per default when doing a memory
limit. That means that when swap is available the process could use up
more memory (by swapping) than it's limited to do.
We've
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20423/#review58071
---
Why are some definitions in .hpp and some in .cpp? Why not all in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23912/#review58074
---
src/slave/slave.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26150/#review58076
---
Ship it!
Ship It!
- Niklas Nielsen
On Oct. 23, 2014, 11:50
On Oct. 23, 2014, 12:46 p.m., Vinod Kone wrote:
Why are some definitions in .hpp and some in .cpp? Why not all in .cpp?
Also, it's not clear to me how this split would help in unit testing?
AFAICT, all these visitors take Master or Framework or Slave which needs
bringing up a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27094/#review58078
---
Bad patch!
Reviews applied: [27094]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26797/#review58081
---
Ship it!
Modulo the request for comment
src/tests/flags.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26797/#review58086
---
Ship it!
Ship It!
- Till Toenshoff
On Oct. 22, 2014, 7:50 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26775/#review58095
---
Ship it!
Ship It!
- Niklas Nielsen
On Oct. 21, 2014, 7:39 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26797/
---
(Updated Oct. 23, 2014, 4:40 p.m.)
Review request for mesos, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26150/
---
(Updated Oct. 23, 2014, 8:40 p.m.)
Review request for mesos and Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27051/
---
(Updated Oct. 23, 2014, 4:47 p.m.)
Review request for mesos, Benjamin Hindman,
On Wed, Oct 22, 2014 at 4:09 PM, Dominic Hamon dha...@twopensource.com
wrote:
Thanks for the thorough breakdown.
I think we should have -O0 -g1 for a default as people building will be
expecting good backtraces and to be able to run gdb without a recompile.
Packaged builds should enable the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27102/
---
(Updated Oct. 23, 2014, 8:57 p.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26426/
---
(Updated Oct. 23, 2014, 8:59 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27102/#review58101
---
Patch looks great!
Reviews applied: [27102]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27111/
---
Review request for mesos, Benjamin Hindman and Ian Downes.
Bugs: MESOS-1977
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26775/
---
(Updated Oct. 23, 2014, 9:06 p.m.)
Review request for mesos, Kapil Arya and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27051/#review58083
---
include/mesos/module.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26797/
---
(Updated Oct. 23, 2014, 5:06 p.m.)
Review request for mesos, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26622/#review58102
---
src/slave/slave.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27105/#review58105
---
Ship it!
src/linux/routing/utils.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26426/#review58108
---
Ship it!
Just noting that in our code base we've about picked
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27111/#review58109
---
Bad patch!
Reviews applied: [27111]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26426/
---
(Updated Oct. 23, 2014, 9:20 p.m.)
Review request for mesos, Benjamin Hindman,
On Oct. 23, 2014, 4:11 p.m., Timothy Chen wrote:
src/tests/slave_tests.cpp, line 420
https://reviews.apache.org/r/26622/diff/2/?file=719278#file719278line420
bells and whistles doesn't seem to be a good description of what you're
trying to do. Perhaps just say you're setting
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26797/
---
(Updated Oct. 23, 2014, 5:28 p.m.)
Review request for mesos, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27105/#review58114
---
I'm curious if we can make the kernel + libnl version checking
On Oct. 23, 2014, 9:37 p.m., Ben Mahler wrote:
I'm curious if we can make the kernel + libnl version checking explicit at
configure time.
It would be nice to tell them when running ./configure that their kernel or
libnl version are not valid for enabling network isolation, rather
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26766/#review58113
---
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26426/#review58118
---
configure.ac
https://reviews.apache.org/r/26426/#comment99023
On Oct. 23, 2014, 9:37 p.m., Ben Mahler wrote:
I'm curious if we can make the kernel + libnl version checking explicit at
configure time.
It would be nice to tell them when running ./configure that their kernel or
libnl version are not valid for enabling network isolation, rather
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27051/
---
(Updated Oct. 23, 2014, 5:51 p.m.)
Review request for mesos, Benjamin Hindman,
On Oct. 23, 2014, 9:37 p.m., Ben Mahler wrote:
I'm curious if we can make the kernel + libnl version checking explicit at
configure time.
It would be nice to tell them when running ./configure that their kernel or
libnl version are not valid for enabling network isolation, rather
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27113/
---
Review request for mesos, Ben Mahler and Niklas Nielsen.
Bugs: MESOS-1980
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27051/
---
(Updated Oct. 23, 2014, 5:55 p.m.)
Review request for mesos, Benjamin Hindman,
On Oct. 23, 2014, 5:06 p.m., Niklas Nielsen wrote:
src/examples/example_module_impl.cpp, line 34
https://reviews.apache.org/r/27051/diff/1/?file=728879#file728879line34
Why not do this in the constructor?
We want to catch the failure and return a NULL pointer. If we do it in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27102/#review58122
---
src/master/master.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27111/
---
(Updated Oct. 23, 2014, 9:58 p.m.)
Review request for mesos, Benjamin Hindman
On Oct. 23, 2014, 9:37 p.m., Ben Mahler wrote:
I'm curious if we can make the kernel + libnl version checking explicit at
configure time.
It would be nice to tell them when running ./configure that their kernel or
libnl version are not valid for enabling network isolation, rather
On Oct. 23, 2014, 9:11 p.m., Timothy Chen wrote:
src/tests/slave_tests.cpp, line 420
https://reviews.apache.org/r/26622/diff/2/?file=719278#file719278line420
bells and whistles doesn't seem to be a good description of what you're
trying to do. Perhaps just say you're setting
On Oct. 23, 2014, 9:11 p.m., Timothy Chen wrote:
src/tests/slave_tests.cpp, line 420
https://reviews.apache.org/r/26622/diff/2/?file=719278#file719278line420
bells and whistles doesn't seem to be a good description of what you're
trying to do. Perhaps just say you're setting
On Oct. 23, 2014, 4:11 p.m., Timothy Chen wrote:
src/tests/slave_tests.cpp, line 420
https://reviews.apache.org/r/26622/diff/2/?file=719278#file719278line420
bells and whistles doesn't seem to be a good description of what you're
trying to do. Perhaps just say you're setting
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27113/#review58124
---
Thanks for following up Joris!
Initial pass, have not looked at
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27051/#review58137
---
Patch looks great!
Reviews applied: [26727, 26796, 26797, 27051]
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27105/
---
(Updated Oct. 23, 2014, 10:21 p.m.)
Review request for mesos, Jie Yu and Cong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26423/#review58153
---
Ship it!
docs/network-monitoring.md
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20423/
---
(Updated Oct. 23, 2014, 3:48 p.m.)
Review request for mesos and Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26622/#review58149
---
src/slave/slave.cpp
On Oct. 23, 2014, 5:48 p.m., Jie Yu wrote:
src/tests/slave_tests.cpp, lines 431-436
https://reviews.apache.org/r/26622/diff/2/?file=719278#file719278line431
It would be great if you can write an end-to-end test so that we can
verify that the 'command' actually runs correctly with
On Oct. 23, 2014, 10:48 p.m., Jie Yu wrote:
src/tests/slave_tests.cpp, lines 431-436
https://reviews.apache.org/r/26622/diff/2/?file=719278#file719278line431
It would be great if you can write an end-to-end test so that we can
verify that the 'command' actually runs correctly
On Oct. 23, 2014, 10:48 p.m., Jie Yu wrote:
src/slave/slave.cpp, lines 2558-2561
https://reviews.apache.org/r/26622/diff/2/?file=719277#file719277line2558
The comments here are confusing. We need to explictly call out that the
reason we copying uris, environments and user is
On Oct. 23, 2014, 5:48 p.m., Jie Yu wrote:
src/tests/slave_tests.cpp, lines 431-436
https://reviews.apache.org/r/26622/diff/2/?file=719278#file719278line431
It would be great if you can write an end-to-end test so that we can
verify that the 'command' actually runs correctly with
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27116/
---
Review request for mesos, Niklas Nielsen and Till Toenshoff.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27116/#review58167
---
Ship it!
Ship It!
- Till Toenshoff
On Oct. 23, 2014, 11:17
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27102/
---
(Updated Oct. 23, 2014, 11:32 p.m.)
Review request for mesos, Ben Mahler and
On Oct. 23, 2014, 9:57 p.m., Dominic Hamon wrote:
src/master/master.cpp, line 1906
https://reviews.apache.org/r/27102/diff/2/?file=731201#file731201line1906
is it ok for an executor to not have a framework id attached?
yea, it's an optional field.
On Oct. 23, 2014, 9:57 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26423/
---
(Updated Oct. 23, 2014, 11:53 p.m.)
Review request for mesos, Ian Downes, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25448/#review58173
---
Ship it!
Ship It!
- Vinod Kone
On Oct. 22, 2014, 9:25 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27105/#review58177
---
Patch looks great!
Reviews applied: [27105]
All tests passed.
-
On Oct. 23, 2014, 5:48 p.m., Jie Yu wrote:
src/tests/slave_tests.cpp, lines 431-436
https://reviews.apache.org/r/26622/diff/2/?file=719278#file719278line431
It would be great if you can write an end-to-end test so that we can
verify that the 'command' actually runs correctly with
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27120/#review58181
---
Ship it!
I'll commit this once you address the comments.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27115/#review58184
---
Ship it!
Ship It!
- Ben Mahler
On Oct. 23, 2014, 11:15 p.m.,
Fantastic, just one question:
Still a bit confused about -g1. From the GCC page, it seems to say that -g1
provides line number tables, is that not the case for the backtraces from
glog? Does -g1 have any impact on line numbers within a core dump?
On Oct. 23, 2014, 10:48 p.m., Jie Yu wrote:
src/tests/slave_tests.cpp, lines 431-436
https://reviews.apache.org/r/26622/diff/2/?file=719278#file719278line431
It would be great if you can write an end-to-end test so that we can
verify that the 'command' actually runs correctly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27092/#review58191
---
Ship it!
Ship It!
- Ben Mahler
On Oct. 23, 2014, 5:45 p.m., Ian
1 - 100 of 121 matches
Mail list logo
