Review Request 33090: Removed unmaintained frameworks code.

2015-04-21 Thread Jiang Yan Xu
/torque/torquesched.py c22ef9180c3aaf447c0288ee4948d0c8067791b7 frameworks/torque/torquesched.sh a40c7eafd71a11c8f974aa49a612fa81d0016102 Diff: https://reviews.apache.org/r/33090/diff/ Testing --- make check Thanks, Jiang Yan Xu

Re: Review Request 30784: Fixed flaky test MasterAllocatorTest/0.OutOfOrderDispatch.

2015-02-09 Thread Jiang Yan Xu
s.cpp 1eebefd2e423e4bb89d76ed7b7d8acc9d1bb7760 Diff: https://reviews.apache.org/r/30784/diff/ Testing --- make -j check GTEST_FILTER=MasterAllocatorTest/0.OutOfOrderDispatch Thanks, Jiang Yan Xu

Review Request 30784: Fixed flaky test MasterAllocatorTest/0.OutOfOrderDispatch.

2015-02-08 Thread Jiang Yan Xu
--- make -j check GTEST_FILTER=MasterAllocatorTest/0.OutOfOrderDispatch Thanks, Jiang Yan Xu

Re: Review Request 30511: Moved framework related rate limiters into Master::Frameworks.

2015-02-03 Thread Jiang Yan Xu
ed e-mail. To reply, visit: > https://reviews.apache.org/r/30511/ > --- > > (Updated Feb. 2, 2015, 10:39 a.m.) > > > Review request for mesos, Ben Mahler and Jiang Yan Xu. > > > Bugs: MESOS-1148 > htt

Re: Review Request 30511: Moved framework related rate limiters into Master::Frameworks.

2015-02-02 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30511/#review70601 --- Ship it! Ship It! - Jiang Yan Xu On Feb. 2, 2015, 10:39 a.m

Re: Review Request 27832: Fixed MasterAuthorizationTest.DuplicateReregistration test.

2014-11-10 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27832/#review60709 --- Ship it! Ship It! - Jiang Yan Xu On Nov. 10, 2014, 2:48 p.m

Re: Review Request 26571: Fixed ZooKeeper 3.4.5 OSX Yosemite build.

2014-10-16 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26571/#review56957 --- Ship it! Thanks Till! - Jiang Yan Xu On Oct. 16, 2014, 3:13 a.m

Re: Review Request 26571: Fixed ZooKeeper 3.4.5 OSX Yosemite build.

2014-10-12 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26571/#review56380 --- LGTM. Let's see how ZOOKEEPER-2049 is going. - Jiang Yan Xu

Re: Review Request 25663: MESOS-1392: MasterDetector now returns a None when it cannot read the content of the ZNode it has detected.

2014-09-17 Thread Jiang Yan Xu
--- make check. Thanks, Jiang Yan Xu

Re: Review Request 25663: MESOS-1392: MasterDetector now returns a None when it cannot read the content of the ZNode it has detected.

2014-09-17 Thread Jiang Yan Xu
e-mail. To reply, visit: https://reviews.apache.org/r/25663/#review53558 --- On Sept. 17, 2014, 11:12 a.m., Jiang Yan Xu wrote: > > --- > This is an automatically generated e-

Re: Review Request 25663: MESOS-1392: MasterDetector now returns a None when it cannot read the content of the ZNode it has detected.

2014-09-17 Thread Jiang Yan Xu
per/group.cpp 58491c01052b68ddaee6af32f33192d5a1f20e58 Diff: https://reviews.apache.org/r/25663/diff/ Testing --- make check. Thanks, Jiang Yan Xu

Review Request 25663: MESOS-1392: MasterDetector now returns a None when it cannot read the content of the ZNode it has detected.

2014-09-15 Thread Jiang Yan Xu
://issues.apache.org/jira/browse/MESOS-1392 Repository: mesos-git Description --- See summary. Diffs - src/master/detector.cpp 6436b8ee7e1ab6451a6b999a1cfbb2f79190e6ca Diff: https://reviews.apache.org/r/25663/diff/ Testing --- make check. Thanks, Jiang Yan Xu

Re: Review Request 25588: Fixed flaky MasterTest.LaunchDuplicateOfferTest.

2014-09-12 Thread Jiang Yan Xu
- > > (Updated Sept. 12, 2014, 10:46 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: mesos-1783 > https://issues.apache.org/jira/browse/mesos-1783 > > > Repository: mesos-git > > > Description > --- > > A coupl

Re: Review Request 25516: Fixed authorization tests to properly deal with registration retries.

2014-09-10 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25516/#review52960 --- Ship it! Ship It! - Jiang Yan Xu On Sept. 10, 2014, 12:55 p.m

Review Request 25511: Pulled the log line in ZooKeeperTestServer::shutdownNetwork() to above the shutdown call.

2014-09-10 Thread Jiang Yan Xu
-- src/tests/zookeeper_test_server.cpp a8c9b1cd8a546abdeb4d89a8fe9ebc3b3d577665 Diff: https://reviews.apache.org/r/25511/diff/ Testing --- make check. Thanks, Jiang Yan Xu

Re: Review Request 25487: Increased session timeouts for ZooKeeper related tests.

2014-09-10 Thread Jiang Yan Xu
d there is none. Diffs (updated) - src/tests/master_contender_detector_tests.cpp 9ac59aa446a132e734238e0e55801117c4ef31b4 src/tests/zookeeper.cpp e45f956e1486e952a4efeb123e15568518fb53fe Diff: https://reviews.apache.org/r/25487/diff/ Testing --- make check. Thanks, Jiang Yan Xu

Review Request 25487: Increased session timeouts for ZooKeeper related tests.

2014-09-09 Thread Jiang Yan Xu
32e734238e0e55801117c4ef31b4 src/tests/zookeeper.cpp e45f956e1486e952a4efeb123e15568518fb53fe Diff: https://reviews.apache.org/r/25487/diff/ Testing --- make check. Thanks, Jiang Yan Xu

Re: Review Request 25304: Removed an unnecessarily introduced Option.

2014-09-03 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25304/#review52209 --- Ship it! Ship It! - Jiang Yan Xu On Sept. 3, 2014, 10:21 a.m

Re: Review Request 25303: Fixed a bug in the staging tasks metric.

2014-09-03 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25303/#review52206 --- Ship it! Ship It! - Jiang Yan Xu On Sept. 3, 2014, 10:21 a.m

Re: Review Request 25302: Count pending tasks as staging in the slave.

2014-09-03 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25302/#review52204 --- Ship it! Ship It! - Jiang Yan Xu On Sept. 3, 2014, 10:21 a.m

Review Request 25195: Fixed MasterZooKeeperTest.LostZooKeeperCluster

2014-08-29 Thread Jiang Yan Xu
MasterZooKeeperTest.LostZooKeeperCluster 1000 for iterations. Thanks, Jiang Yan Xu

Re: Review Request 24667: Added a user doc for framework rate limiting.

2014-08-14 Thread Jiang Yan Xu
://gist.github.com/xujyan/d2bdd2052fac489fb1a9 Thanks, Jiang Yan Xu

Re: Review Request 24667: Added a user doc for framework rate limiting.

2014-08-14 Thread Jiang Yan Xu
t; See summary. > > > Diffs > - > > docs/framework-rate-limiting.md PRE-CREATION > > Diff: https://reviews.apache.org/r/24667/diff/ > > > Testing > --- > > Rendered version: https://gist.github.com/xujyan/d2bdd2052fac489fb1a9 > > > Thanks, > > Jiang Yan Xu > >

Review Request 24667: Added a user doc for framework rate limiting.

2014-08-13 Thread Jiang Yan Xu
Thanks, Jiang Yan Xu

Re: Review Request 24583: Added a missing test target in Makefile.am.

2014-08-11 Thread Jiang Yan Xu
run before? - Jiang Yan Xu On Aug. 11, 2014, 4:32 p.m., Ben Mahler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revi

Re: Review Request 24582: Removed unused test file 'process_spawn.cpp'.

2014-08-11 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24582/#review50265 --- Ship it! Ship It! - Jiang Yan Xu On Aug. 11, 2014, 4:32 p.m

Re: Review Request 24343: Improved framework rate limiting by imposing the max number of outstanding messages per framework principal.

2014-08-07 Thread Jiang Yan Xu
> Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1578 > https://issues.apache.org/jira/browse/MESOS-1578 > > > Repository: mesos-git > > > Description > --- > > See summary. > > > Diffs > - > > include/mesos/mesos.proto 628cce12d2fae645d2ef55e4809631ca03a56207 > src/examples/load_generator_framework.cpp > 7d94c49cf91bf327ac80f04d9f1a7370996b6ba4 > src/master/master.hpp d8a4d9e04ecff60020b99ea6447055787d187797 > src/master/master.cpp 97e4340f7949a261558f09ea533aac0bbb0e40f6 > src/tests/rate_limiting_tests.cpp fc23a1946ad1a78e699552440df2193ea10dc472 > > Diff: https://reviews.apache.org/r/24343/diff/ > > > Testing > --- > > make check > > ./bin/mesos-tests.sh --verbose --gtest_filter=*RateLimit* --gtest_repeat=1000 > > > Thanks, > > Jiang Yan Xu > >

Re: Review Request 23700: Added 'timed_tests.sh' script to help investigate the cause of hanging tests.

2014-08-07 Thread Jiang Yan Xu
view49961 --- On Aug. 7, 2014, 11:27 a.m., Jiang Yan Xu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 23700: Added 'timed_tests.sh' script to help investigate the cause of hanging tests.

2014-08-07 Thread Jiang Yan Xu
Diffs (updated) - support/timed_tests.sh PRE-CREATION Diff: https://reviews.apache.org/r/23700/diff/ Testing --- Tested on Linux with and without Jenkins. Thanks, Jiang Yan Xu

Re: Review Request 24343: Improved framework rate limiting by imposing the max number of outstanding messages per framework principal.

2014-08-06 Thread Jiang Yan Xu
Diff: https://reviews.apache.org/r/24343/diff/ Testing --- make check ./bin/mesos-tests.sh --verbose --gtest_filter=*RateLimit* --gtest_repeat=1000 Thanks, Jiang Yan Xu

Re: Review Request 24343: Improved framework rate limiting by imposing the max number of outstanding messages per framework principal.

2014-08-06 Thread Jiang Yan Xu
/rate_limiting_tests.cpp fc23a1946ad1a78e699552440df2193ea10dc472 Diff: https://reviews.apache.org/r/24343/diff/ Testing --- make check ./bin/mesos-tests.sh --verbose --gtest_filter=*RateLimit* --gtest_repeat=1000 Thanks, Jiang Yan Xu

Re: Review Request 24343: Improved framework rate limiting by imposing the max number of outstanding messages per framework principal.

2014-08-06 Thread Jiang Yan Xu
ore future proof and the style guide says "When in doubt, choose a larger type" :) - Jiang Yan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24343/#review49831 -

Re: Review Request 24343: Improved framework rate limiting by imposing the max number of outstanding messages per framework principal.

2014-08-06 Thread Jiang Yan Xu
fc23a1946ad1a78e699552440df2193ea10dc472 Diff: https://reviews.apache.org/r/24343/diff/ Testing --- make check ./bin/mesos-tests.sh --verbose --gtest_filter=*RateLimit* --gtest_repeat=1000 Thanks, Jiang Yan Xu

Re: Review Request 24343: Improved framework rate limiting by imposing the max number of outstanding messages per framework principal.

2014-08-06 Thread Jiang Yan Xu
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24343/#review49741 --- On Aug. 6, 2014, 4:13 p.m., Jiang Yan Xu wrote: >

Re: Review Request 24343: Improved framework rate limiting by imposing the max number of outstanding messages per framework principal.

2014-08-06 Thread Jiang Yan Xu
ssed). Should there be more comment to explain this? - Jiang Yan ----------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24343/#review49761 -

Re: Review Request 24343: Improved framework rate limiting by imposing the max number of outstanding messages per framework principal.

2014-08-06 Thread Jiang Yan Xu
right? the rate limiter doesn't have a capacity. - Jiang Yan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24343/#review49699 ----------- On

Re: Review Request 24343: Improved framework rate limiting by imposing the max number of outstanding messages per framework principal.

2014-08-06 Thread Jiang Yan Xu
fc23a1946ad1a78e699552440df2193ea10dc472 Diff: https://reviews.apache.org/r/24343/diff/ Testing --- make check ./bin/mesos-tests.sh --verbose --gtest_filter=*RateLimit* --gtest_repeat=1000 Thanks, Jiang Yan Xu

Re: Review Request 24343: Improved framework rate limiting by imposing the max number of outstanding messages per framework principal.

2014-08-05 Thread Jiang Yan Xu
https://reviews.apache.org/r/24343/diff/ Testing --- make check ./bin/mesos-tests.sh --verbose --gtest_filter=*RateLimit* --gtest_repeat=1000 Thanks, Jiang Yan Xu

Re: Review Request 24343: Improved framework rate limiting by imposing the max number of outstanding messages per framework principal.

2014-08-05 Thread Jiang Yan Xu
incipal as I think it should be very clear to the framework what its own principal is (if it sets it in FrameworkInfo) and it could be empty (if it doesn't set it). "capacity" on the other hand is configured on the master so I think it's useful information. -

Review Request 24355: Added a trailing space to _CheckFatal's output.

2014-08-05 Thread Jiang Yan Xu
/p/google-glog/source/browse/trunk/src/glog/logging.h.in#561 Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 4b93aa082c9a312a5a7a15193512587088ea3d4c Diff: https://reviews.apache.org/r/24355/diff/ Testing --- make check Thanks, Jiang Yan Xu

Review Request 24343: Improved framework rate limiting by imposing the max number of outstanding messages per framework principal.

2014-08-05 Thread Jiang Yan Xu
--gtest_filter=*RateLimit* --gtest_repeat=1000 Thanks, Jiang Yan Xu

Re: Review Request 23868: Added a ping timeout in the slave to trigger a re-detection.

2014-08-04 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23868/#review49508 --- Ship it! Ship It! - Jiang Yan Xu On Aug. 4, 2014, 12:25 p.m

Re: Review Request 23700: Added 'timed_tests.sh' script to help investigate the cause of hanging tests.

2014-08-01 Thread Jiang Yan Xu
pport/timed_tests.sh PRE-CREATION Diff: https://reviews.apache.org/r/23700/diff/ Testing --- Tested on Linux with and without Jenkins. Thanks, Jiang Yan Xu

Re: Review Request 24123: Fixed a flaky test: ZooKeeperTest.LeaderDetectorTimeoutHandling

2014-08-01 Thread Jiang Yan Xu
s an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24123/#review49368 --- On July 31, 2014, 11:23 p.m., Jiang Yan Xu wrote: > > --- > This is a

Re: Review Request 23700: Added 'timed_tests.sh' script to help investigate the cause of hanging tests.

2014-08-01 Thread Jiang Yan Xu
> On July 30, 2014, 11:18 a.m., Jiang Yan Xu wrote: > > Talked to Jie. This script looks for the newest (most recently started) > > process in this session and this may sometimes be not what we want. If some > > tests themselves fork subprocesses and depending o

Re: Review Request 23700: Added 'timed_tests.sh' script to help investigate the cause of hanging tests.

2014-08-01 Thread Jiang Yan Xu
sion. Diffs (updated) - support/timed_tests.sh PRE-CREATION Diff: https://reviews.apache.org/r/23700/diff/ Testing --- Tested on Linux with and without Jenkins. Thanks, Jiang Yan Xu

Re: Review Request 24123: Fixed a flaky test: ZooKeeperTest.LeaderDetectorTimeoutHandling

2014-08-01 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24123/#review49186 ----------- On July 31, 2014, 11:23 p.m., Jiang Yan Xu wrote: > > --

Re: Review Request 24123: Fixed a flaky test: ZooKeeperTest.LeaderDetectorTimeoutHandling

2014-07-31 Thread Jiang Yan Xu
s.cpp be9fa06818b96e5170c68810fe16cc472f1f8b28 Diff: https://reviews.apache.org/r/24123/diff/ Testing (updated) --- Ran the test for 2000 iterations. Thanks, Jiang Yan Xu

Re: Review Request 24123: Fixed a flaky test: ZooKeeperTest.LeaderDetectorTimeoutHandling.

2014-07-30 Thread Jiang Yan Xu
https://reviews.apache.org/r/24123/diff/ Testing --- Ran the test for 350 iterations so far and it didn't fail. Thanks, Jiang Yan Xu

Re: Review Request 24123: Fixed a flaky test: ZooKeeperTest.LeaderDetectorTimeoutHandling - The original ZK session timeout was the same as AWAIT_READY timeout so it's possible that AWAIT_READY timed

2014-07-30 Thread Jiang Yan Xu
Testing --- Ran the test for 350 iterations so far and it didn't fail. Thanks, Jiang Yan Xu

Review Request 24123: Fixed a flaky test: ZooKeeperTest.LeaderDetectorTimeoutHandling

2014-07-30 Thread Jiang Yan Xu
ng 10 seconds clock time on this wait so I reduced the timeout. Diffs - src/tests/zookeeper_tests.cpp be9fa06818b96e5170c68810fe16cc472f1f8b28 Diff: https://reviews.apache.org/r/24123/diff/ Testing --- Ran the test for 350 iterations so far and it didn't fail. Thanks, Jiang Yan Xu

Re: Review Request 23700: Added 'timed_tests.sh' script to help investigate the cause of hanging tests.

2014-07-30 Thread Jiang Yan Xu
all the ancestor processes of the newest process and I think this works better. Still, this script tries to be useful in a generic manner with best effort. I imagine there are other cases where the script needs to be tailored depending on where the anticipated bug is. - Jiang Yan Xu On July 29

Re: Review Request 23997: Patch for MESOS-1635

2014-07-29 Thread Jiang Yan Xu
> On July 29, 2014, 3:06 p.m., Jiang Yan Xu wrote: > > src/master/contender.cpp, line 79 > > <https://reviews.apache.org/r/23997/diff/3/?file=644484#file644484line79> > > > > Master detector and contender already support --zk=file://, in the > >

Re: Review Request 23997: Patch for MESOS-1635

2014-07-29 Thread Jiang Yan Xu
nst std::string& url)" directly. src/master/detector.cpp <https://reviews.apache.org/r/23997/#comment85866> Ditto src/master/main.cpp <https://reviews.apache.org/r/23997/#comment85867> This is no longer a TODO as it's done now, right? - J

Re: Review Request 23700: Added 'timed_tests.sh' script to help investigate the cause of hanging tests.

2014-07-29 Thread Jiang Yan Xu
imed_tests.sh PRE-CREATION Diff: https://reviews.apache.org/r/23700/diff/ Testing --- Tested on Linux with and without Jenkins. Thanks, Jiang Yan Xu

Re: Review Request 23700: Added 'timed_tests.sh' script to help investigate the cause of hanging tests.

2014-07-29 Thread Jiang Yan Xu
, of course these are use cases that no one else requested but I took the liberty to add them while figuring out the process hierarchy of the tests. - Jiang Yan --- This is an automatically generated e-mail. To reply, v

Review Request 24061: Fixed a bug that caused 'make dist' unable to patch leveldb.

2014-07-29 Thread Jiang Yan Xu
https://issues.apache.org/jira/browse/MESOS-1624 Repository: mesos-git Description --- See summary. Diffs - 3rdparty/Makefile.am cfeaac7a23f469295196da72c80b2501a29e1633 Diff: https://reviews.apache.org/r/24061/diff/ Testing --- make distcheck Thanks, Jiang Yan Xu

Re: Review Request 23700: Added 'timed_tests.sh' script to help investigate the cause of hanging tests.

2014-07-28 Thread Jiang Yan Xu
all subprocesses are in this new session. Diffs (updated) - support/timed_tests.sh PRE-CREATION Diff: https://reviews.apache.org/r/23700/diff/ Testing (updated) --- Tested on Linux with and without Jenkins. Thanks, Jiang Yan Xu

Re: Review Request 23695: Allowed LoadGeneratorFramework to read password from a file.

2014-07-25 Thread Jiang Yan Xu
https://reviews.apache.org/r/23695/diff/ Testing --- Ran the program and had it read a password file. Thanks, Jiang Yan Xu

Re: Review Request 23934: Add missing whitespace to coverage script

2014-07-25 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23934/#review48744 --- Ship it! Ship It! - Jiang Yan Xu On July 25, 2014, 10:19 a.m

Review Request 23916: Fixed a memory leak in limiter.hpp.

2014-07-24 Thread Jiang Yan Xu
://issues.apache.org/jira/browse/MESOS-1639 Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/include/process/limiter.hpp 846ec09d5baee642cf3233550d926ea446fd0eaa Diff: https://reviews.apache.org/r/23916/diff/ Testing --- make check Thanks, Jiang Yan

Re: Review Request 23867: Handle discards on the master detection futures.

2014-07-24 Thread Jiang Yan Xu
> > (Updated July 23, 2014, 7:55 p.m.) > > > Review request for mesos, Jie Yu and Jiang Yan Xu. > > > Bugs: MESOS-1529 > https://issues.apache.org/jira/browse/MESOS-1529 > > > Repository: mesos-git > > > Descr

Re: Review Request 23874: Removed unused code from future.hpp.

2014-07-24 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23874/#review48689 --- Ship it! Ship It! - Jiang Yan Xu On July 23, 2014, 7:55 p.m

Re: Review Request 23868: Added a ping timeout in the slave to trigger a re-detection.

2014-07-24 Thread Jiang Yan Xu
pingTimer.timeout().expired()?" If the slave receives a ping before the timer times out but its queue backed up and thus the timer isn't cancelled. The timer then times out and dispatches a redetect() that is executed after ping(), we don't really need to redetect right?

Re: Review Request 23866: Master detector cleanups.

2014-07-24 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23866/#review48664 --- Ship it! Ship It! - Jiang Yan Xu On July 23, 2014, 7:55 p.m

Re: Review Request 23875: Made WeakFuture::get a const operation.

2014-07-24 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23875/#review48663 --- Ship it! Ship It! - Jiang Yan Xu On July 23, 2014, 7:55 p.m

Re: Review Request 23874: Removed unused code from future.hpp.

2014-07-24 Thread Jiang Yan Xu
t now so maybe this can be done together later (without removing fail(futures) now)? - Jiang Yan Xu On July 23, 2014, 7:55 p.m., Ben Mahler wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 23873: Add back declaration of stream operator.

2014-07-23 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23873/#review48590 --- Ship it! Ship It! - Jiang Yan Xu On July 23, 2014, 5:29 p.m

Re: Review Request 23873: Add back declaration of stream operator.

2014-07-23 Thread Jiang Yan Xu
873/#comment85300> s/resource/resources - Jiang Yan Xu On July 23, 2014, 5:25 p.m., Dominic Hamon wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 23866: Master detector cleanups.

2014-07-23 Thread Jiang Yan Xu
futures, maybe we can add these methods for promises there as well? - Jiang Yan Xu On July 23, 2014, 4:18 p.m., Ben Mahler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 23696: Made LoadGeneratorFramework a check program instead of a bin program.

2014-07-18 Thread Jiang Yan Xu
: https://reviews.apache.org/r/23696/diff/ Testing --- Ran this tarball package as an Aurora job with the following command: LD_LIBRARY_PATH=. ./load-generator-framework \ --master=zk:// \ --qps=5000 \ --secret= \ --authenticate \ --duration=1mins Thanks, Jiang Yan Xu

Review Request 23695: Allowed LoadGeneratorFramework to read password from a file.

2014-07-18 Thread Jiang Yan Xu
password file. Thanks, Jiang Yan Xu

Re: Review Request 23250: Created an example LoadGeneratorScheduler to test Master's framework rate limiting feature.

2014-07-03 Thread Jiang Yan Xu
erate() makes the logic more clear. - Jiang Yan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23250/#review47321 ----------- On July 3, 2014, 1:50 p.m., Jiang Yan Xu wrote: > > -

Re: Review Request 23250: Created an example LoadGeneratorScheduler to test Master's framework rate limiting feature.

2014-07-03 Thread Jiang Yan Xu
src/Makefile.am 64389391e04d12f09737ff56a1cc88c4543e63ad src/examples/load_generator_framework.cpp PRE-CREATION Diff: https://reviews.apache.org/r/23250/diff/ Testing --- Used the binary in distributed tests. Thanks, Jiang Yan Xu

Re: Review Request 23250: Created an example LoadGeneratorScheduler to test Master's framework rate limiting feature.

2014-07-03 Thread Jiang Yan Xu
- Used the binary in distributed tests. Thanks, Jiang Yan Xu

Review Request 23250: Created an example LoadGeneratorScheduler to test Master's framework rate limiting feature.

2014-07-02 Thread Jiang Yan Xu
d. I am open to suggestions. Diffs - src/Makefile.am 64389391e04d12f09737ff56a1cc88c4543e63ad src/examples/load_generator_framework.cpp PRE-CREATION Diff: https://reviews.apache.org/r/23250/diff/ Testing --- Used the binary in distributed tests. Thanks, Jiang Yan Xu

Re: Review Request 23220: Fixed and renamed AllocatorZooKeeper tests.

2014-07-02 Thread Jiang Yan Xu
iterations and no Gmock warning is shown now? - Jiang Yan Xu On July 1, 2014, 5:49 p.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 22857: Made sure Cluster::Masters::start() returns when the Master is ready for incoming requests. i.e., after it has finished executing _recover().

2014-07-01 Thread Jiang Yan Xu
. Changes --- Add reviewers Repository: mesos-git Description --- See summary. Diffs - src/tests/cluster.hpp 1c96ee7d27d1f2f277bc4617f9e17092460d7191 Diff: https://reviews.apache.org/r/22857/diff/ Testing (updated) --- make check. Thanks, Jiang Yan Xu

Re: Review Request 23187: Fixed a regression in ExecutorInfoChecker to allow an executor with the same id but different executor info as long as it is on a different slave.

2014-07-01 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23187/#review47109 --- Ship it! Ship It! - Jiang Yan Xu On June 30, 2014, 5:21 p.m

Re: Review Request 22947: Fixed FaultToleranceTest.SlaveReregisterTerminatedExecutor test.

2014-06-24 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22947/#review46598 --- Ship it! Ship It! - Jiang Yan Xu On June 24, 2014, 4:51 p.m

Re: Review Request 22945: Fixed FrameworkReregistersFirst and SlaveReregistersFirst allocator tests.

2014-06-24 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22945/#review46586 --- Ship it! Ship It! - Jiang Yan Xu On June 24, 2014, 2:50 p.m

Re: Review Request 22777: Added support for optionally throttling the frameworks not specified in RateLimits config.

2014-06-23 Thread Jiang Yan Xu
bb370bf696 src/master/master.cpp 00152f5b889a2d10255835779b66c9ed26df9a2b src/tests/rate_limiting_tests.cpp 9a544618e70e7ce3091fa303597eb1bb3d161bf9 Diff: https://reviews.apache.org/r/22777/diff/ Testing --- Added/modified tests for the default limiter. make check. Thanks, Jiang Yan Xu

Re: Review Request 22777: Added support for optionally throttling the frameworks not specified in RateLimits config.

2014-06-22 Thread Jiang Yan Xu
696 src/master/master.cpp 00152f5b889a2d10255835779b66c9ed26df9a2b src/tests/rate_limiting_tests.cpp 9a544618e70e7ce3091fa303597eb1bb3d161bf9 Diff: https://reviews.apache.org/r/22777/diff/ Testing --- Added/modified tests for the default limiter. make check. Thanks, Jiang Yan Xu

Re: Review Request 22777: Added support for optionally throttling the frameworks not specified in RateLimits config.

2014-06-22 Thread Jiang Yan Xu
r.cpp 00152f5b889a2d10255835779b66c9ed26df9a2b src/tests/rate_limiting_tests.cpp 9a544618e70e7ce3091fa303597eb1bb3d161bf9 Diff: https://reviews.apache.org/r/22777/diff/ Testing --- Added/modified tests for the default limiter. make check. Thanks, Jiang Yan Xu

Re: Review Request 22758: Added flags::parse() overload for RateLimits protobuf.

2014-06-22 Thread Jiang Yan Xu
--- make check. Thanks, Jiang Yan Xu

Review Request 22856: Removed the wait in StartMaster() for the master to get elected before returning because it's no longer necessary.

2014-06-22 Thread Jiang Yan Xu
s.cpp 10374201121e376f3a1de33278dfd0ea92edd7b2 Diff: https://reviews.apache.org/r/22856/diff/ Testing --- make check. Thanks, Jiang Yan Xu

Re: Review Request 22740: Added more tests for framework rate limiting.

2014-06-22 Thread Jiang Yan Xu
omatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22740/#review46349 ----------- On June 22, 2014, 8:49 p.m., Jiang Yan Xu wrote: > > --- > This is an automatically gener

Re: Review Request 22740: Added more tests for framework rate limiting.

2014-06-22 Thread Jiang Yan Xu
dated) - src/tests/rate_limiting_tests.cpp 9a544618e70e7ce3091fa303597eb1bb3d161bf9 Diff: https://reviews.apache.org/r/22740/diff/ Testing --- make check all test and *RateLimitingTest* for high iterations. Thanks, Jiang Yan Xu

Re: Review Request 22740: Added more tests for framework rate limiting.

2014-06-20 Thread Jiang Yan Xu
s.cpp 9a544618e70e7ce3091fa303597eb1bb3d161bf9 Diff: https://reviews.apache.org/r/22740/diff/ Testing --- make check all test and *RateLimitingTest* for high iterations. Thanks, Jiang Yan Xu

Re: Review Request 22740: Added more tests for framework rate limiting.

2014-06-20 Thread Jiang Yan Xu
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22740/#review46243 --- On June 19, 2014, 12:03 p.m., Jiang Yan Xu wrote: > > --- > Thi

Re: Review Request 22777: Added support for optionally throttling the frameworks not specified in RateLimits config.

2014-06-20 Thread Jiang Yan Xu
omatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22777/#review46284 ------- On June 19, 2014, 12:30 p.m., Jiang Yan Xu wrote: > > ---

Review Request 22777: Added support for optionally throttling the frameworks not specified in RateLimits config.

2014-06-19 Thread Jiang Yan Xu
tests/rate_limiting_tests.cpp 9a544618e70e7ce3091fa303597eb1bb3d161bf9 Diff: https://reviews.apache.org/r/22777/diff/ Testing --- Added/modified tests for the default limiter. make check. Thanks, Jiang Yan Xu

Re: Review Request 22740: Added more tests for framework rate limiting.

2014-06-19 Thread Jiang Yan Xu
://reviews.apache.org/r/22740/diff/ Testing --- make check all test and *RateLimitingTest* for high iterations. Thanks, Jiang Yan Xu

Re: Review Request 22740: Added more tests for framework rate limiting.

2014-06-19 Thread Jiang Yan Xu
--- make check all test and *RateLimitingTest* for high iterations. Thanks, Jiang Yan Xu

Re: Review Request 22639: Refactored the querying and parsing of metrics snapshot into a MACRO.

2014-06-19 Thread Jiang Yan Xu
://reviews.apache.org/r/22639/diff/ Testing --- make check. Thanks, Jiang Yan Xu

Review Request 22758: Added flags::parse() overload for RateLimits protobuf.

2014-06-18 Thread Jiang Yan Xu
47bb0dc04504fc847cc02fa97eb0d045a8835c9e src/master/master.cpp 888657dd4bc50085882382908e3c48ccb857c621 src/tests/rate_limiting_tests.cpp 9a544618e70e7ce3091fa303597eb1bb3d161bf9 Diff: https://reviews.apache.org/r/22758/diff/ Testing --- make check. Thanks, Jiang Yan Xu

Review Request 22745: Added a log line to indicate framework rate limiting is enabled.

2014-06-18 Thread Jiang Yan Xu
--- Oops... accidentally removed this line while addressing Vinod's comment in https://reviews.apache.org/r/22427 Diffs - src/master/master.cpp 888657dd4bc50085882382908e3c48ccb857c621 Diff: https://reviews.apache.org/r/22745/diff/ Testing --- make check. Thanks, Jian

Re: Review Request 22740: Added more tests for framework rate limiting.

2014-06-18 Thread Jiang Yan Xu
g/r/22740/#comment81269> I am still using the METRICS_SNAPSHOT macro from https://reviews.apache.org/r/22639/ Will address the comments in r22639 soon. - Jiang Yan Xu On June 18, 2014, 11:30 a.m., Jiang Yan Xu

Review Request 22740: Added more tests for framework rate limiting.

2014-06-18 Thread Jiang Yan Xu
*RateLimitingTest* for high iterations. Thanks, Jiang Yan Xu

Re: Review Request 22427: Implemented framework API rate limiting.

2014-06-17 Thread Jiang Yan Xu
https://reviews.apache.org/r/22427/diff/ Testing --- Added a test for MESOS-1444. Will add more for MESOS-1445 Thanks, Jiang Yan Xu

  1   2   3   4   5   6   >