Re: Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22316/#review45992 --- Patch looks great! Reviews applied: [22316] All tests passed. - M

Re: Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22316/ --- (Updated June 17, 2014, 1:55 p.m.) Review request for mesos, Ben Mahler, Domini

Re: Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22316/#review45879 --- Ship it! src/master/master.hpp

Re: Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22316/#review45872 --- Ship it! Ship It! - Dominic Hamon On June 16, 2014, 5:17 p.m., J

Re: Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22316/ --- (Updated June 16, 2014, 5:17 p.m.) Review request for mesos, Ben Mahler, Domini

Re: Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.

> On June 16, 2014, 10:39 a.m., Dominic Hamon wrote: > > src/master/master.cpp, line 763 > > > > > > is this simpler? > > > > metrics.frameworks.get(principal.get()).get()->messages_received++; > > > > I

Re: Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22316/#review45779 --- src/master/master.hpp

Re: Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22316/#review45668 --- src/master/master.hpp

Re: Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22316/ --- (Updated June 13, 2014, 3:48 p.m.) Review request for mesos, Ben Mahler, Domini

Re: Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22316/#review45428 --- >From the review meeting with Vinod and BenM. src/master/master.hp

Re: Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22316/#review45487 --- Patch looks great! Reviews applied: [22316] All tests passed. - M

Re: Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.

> On June 10, 2014, 11:30 a.m., Dominic Hamon wrote: > > src/master/master.hpp, line 530 > > > > > > Are we going to add more of these? It might make sense to combine them: > > > > struct PerFrameworkPrincipal

Re: Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22316/ --- (Updated June 11, 2014, 1:49 p.m.) Review request for mesos, Ben Mahler, Domini

Re: Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.

> On June 11, 2014, 10:55 a.m., Vinod Kone wrote: > > src/master/master.cpp, lines 3316-3317 > > > > > > Why is this Owned and on a heap? It can't be an plain object because Counter doesn't have a default constructor

Re: Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.

> On June 11, 2014, 10:57 a.m., Vinod Kone wrote: > > src/tests/rate_limiting_tests.cpp, lines 512-513 > > > > > > there is no throttling because rate limiting is not setup correct? Yeah I meant to add it to the frame

Re: Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22316/#review45400 --- src/tests/rate_limiting_tests.cpp

Re: Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22316/#review45320 --- src/master/master.hpp

Re: Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.

> On June 10, 2014, 11:30 a.m., Dominic Hamon wrote: > > src/master/master.hpp, line 530 > > > > > > Are we going to add more of these? It might make sense to combine them: > > > > struct PerFrameworkPrincipal

Re: Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22316/ --- (Updated June 11, 2014, 10:39 a.m.) Review request for mesos, Ben Mahler, Domin

Re: Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22316/#review45261 --- src/Makefile.am

Re: Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22316/ --- (Updated June 10, 2014, 11:04 a.m.) Review request for mesos, Ben Mahler, Domin

Re: Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22316/#review45034 --- Patch looks great! Reviews applied: [22250, 22316] All tests passe

Re: Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22316/#review44994 --- This patch is implicitly designed on the fact that rate limiting is

Re: Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.

> On June 6, 2014, 2:21 p.m., Dominic Hamon wrote: > > src/master/master.cpp, lines 3278-3296 > > > > > > ownership is very confusing here. > > > > In the first stanza you set the metrics.framework_messages e

Re: Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.

> On June 6, 2014, 2:21 p.m., Dominic Hamon wrote: > > src/master/master.cpp, lines 3278-3296 > > > > > > ownership is very confusing here. > > > > In the first stanza you set the metrics.framework_messages e

Re: Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22316/#review44972 --- src/master/master.cpp

Re: Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.

> On June 6, 2014, 2:21 p.m., Dominic Hamon wrote: > > src/master/master.cpp, lines 3278-3296 > > > > > > ownership is very confusing here. > > > > In the first stanza you set the metrics.framework_messages e

Re: Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22316/#review44965 --- src/master/master.hpp

Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22316/ --- Review request for mesos, Ben Mahler, Dominic Hamon, and Vinod Kone. Bugs: MESO