Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review78222 --- Ship it! Ship It! - Vinod Kone On March 28, 2015, 2:25 a.m., Til

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review78149 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/ --- (Updated March 28, 2015, 2:25 a.m.) Review request for mesos, Adam B, Kapil Ary

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On March 27, 2015, 10:46 p.m., Adam B wrote: > > Fix looks good to me. Buildbot, please take another look. ;) > > Vinod Kone wrote: > Can you or @till let me know what the race and temporal issue here was? > And how this fixes it? > > Till Toenshoff wrote: > There was one major probl

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On March 27, 2015, 10:46 p.m., Adam B wrote: > > Fix looks good to me. Buildbot, please take another look. ;) > > Vinod Kone wrote: > Can you or @till let me know what the race and temporal issue here was? > And how this fixes it? There was one major problem in these lines: ``` // Start

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On March 27, 2015, 10:46 p.m., Adam B wrote: > > Fix looks good to me. Buildbot, please take another look. ;) Can you or @till let me know what the race and temporal issue here was? And how this fixes it? - Vinod --- This is an autom

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review78123 --- Fix looks good to me. Buildbot, please take another look. ;) - Adam

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/ --- (Updated March 25, 2015, 11:35 p.m.) Review request for mesos, Adam B, Kapil Ar

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On March 11, 2015, 9:42 p.m., Vinod Kone wrote: > > src/master/master.cpp, lines 3858-3861 > > > > > > Send a FrameworkError message (instead of AuthenticationError) here to > > avoid retries? > > Till Toenshoff

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/ --- (Updated March 20, 2015, 10:21 p.m.) Review request for mesos, Adam B, Kapil Ar

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On March 16, 2015, 9:41 p.m., Vinod Kone wrote: > > src/authentication/cram_md5/authenticator.cpp, lines 552-554 > > > > > > Why is this an initialization error? The previous semantics are that if > > credentials w

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review76642 --- src/authentication/cram_md5/authenticator.cpp

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On March 11, 2015, 2:42 p.m., Vinod Kone wrote: > > src/master/master.cpp, lines 3858-3861 > > > > > > Send a FrameworkError message (instead of AuthenticationError) here to > > avoid retries? > > Till Toenshoff

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On March 11, 2015, 9:42 p.m., Vinod Kone wrote: > > src/master/master.cpp, lines 3858-3861 > > > > > > Send a FrameworkError message (instead of AuthenticationError) here to > > avoid retries? The `Authentication

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On March 11, 2015, 9:42 p.m., Vinod Kone wrote: > > src/authentication/cram_md5/authenticator.hpp, lines 79-82 > > > > > > i wish this move was done in its own review (w/o functional changes), > > so that we can com

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/ --- (Updated March 12, 2015, 12:32 a.m.) Review request for mesos, Adam B, Kapil Ar

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review76090 --- src/authentication/cram_md5/authenticator.hpp

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review75995 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/ --- (Updated March 10, 2015, 7:30 p.m.) Review request for mesos, Adam B, Kapil Ary

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On Feb. 20, 2015, 2:19 p.m., Vinod Kone wrote: > > src/master/master.cpp, lines 3897-3898 > > > > > > Why do we need this 'onAny'? Why can't 'authenticated' be set in > > __authenticate()? > > Till Toenshoff wrot

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On Feb. 20, 2015, 10:19 p.m., Vinod Kone wrote: > > src/authentication/cram_md5/authenticator.cpp, line 449 > > > > > > Shouldn't this be protected by once() to avoid 2 different threads > > loading secrets at the

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review75436 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/ --- (Updated March 5, 2015, 7:22 p.m.) Review request for mesos, Adam B, Kapil Arya

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On Feb. 20, 2015, 10:19 p.m., Vinod Kone wrote: > > src/authentication/cram_md5/authenticator.cpp, line 449 > > > > > > Shouldn't this be protected by once() to avoid 2 different threads > > loading secrets at the

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review75119 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/ --- (Updated March 3, 2015, 2:58 p.m.) Review request for mesos, Adam B, Kapil Arya

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On Feb. 20, 2015, 10:19 p.m., Vinod Kone wrote: > > src/authentication/cram_md5/authenticator.cpp, line 449 > > > > > > Shouldn't this be protected by once() to avoid 2 different threads > > loading secrets at the

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On Feb. 20, 2015, 10:19 p.m., Vinod Kone wrote: > > src/authentication/cram_md5/authenticator.cpp, line 449 > > > > > > Shouldn't this be protected by once() to avoid 2 different threads > > loading secrets at the

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On Feb. 25, 2015, 4:01 p.m., Niklas Nielsen wrote: > > Hey Till, > > > > Can you rebase this? :) > > Niklas Nielsen wrote: > Vinod, think that this is only awaiting responses from you on a few > questions/answers above :) Would love to get this in. @vinodkone Ready for you to take anoth

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review74439 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/ --- (Updated Feb. 27, 2015, 2:28 a.m.) Review request for mesos, Adam B, Kapil Arya

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On Feb. 25, 2015, 4:01 p.m., Niklas Nielsen wrote: > > Hey Till, > > > > Can you rebase this? :) Vinod, think that this is only awaiting responses from you on a few questions/answers above :) Would love to get this in. - Niklas ---

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review74158 --- Hey Till, Can you rebase this? :) - Niklas Nielsen On Feb. 22, 2

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On Feb. 20, 2015, 10:19 p.m., Vinod Kone wrote: > > src/authentication/cram_md5/authenticator.cpp, line 449 > > > > > > Shouldn't this be protected by once() to avoid 2 different threads > > loading secrets at the

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73465 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On Feb. 22, 2015, 7:11 a.m., Adam B wrote: > > src/master/master.cpp, line 453 > > > > > > Maybe do a `CHECK_SOME(authenticator)`? The current code-path to this use of authenticator does not permit anything but

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/ --- (Updated Feb. 22, 2015, 10:03 p.m.) Review request for mesos, Adam B, Kapil Ary

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73446 --- LGTM, pending the other open issues. src/master/master.cpp

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73422 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/ --- (Updated Feb. 21, 2015, 10:16 p.m.) Review request for mesos, Adam B, Kapil Ary

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On Feb. 20, 2015, 10:19 p.m., Vinod Kone wrote: > > src/master/master.cpp, lines 3870-3873 > > > > > > Did you mix up "inner" and "outer" here? > > Till Toenshoff wrote: > I rephrased it, maybe this is better?

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On Jan. 28, 2015, 8:33 p.m., Vinod Kone wrote: > > src/master/master.cpp, lines 4193-4203 > > > > > > IIRC, sending an AuthenticationErrorMessage here causes the driver to > > simply retry the authentication and t

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On Feb. 20, 2015, 2:19 p.m., Vinod Kone wrote: > > src/master/master.cpp, lines 466-467 > > > > > > why this if condition for logging? > > Till Toenshoff wrote: > Not sure I understand. Did you see the comment

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On Feb. 20, 2015, 10:19 p.m., Vinod Kone wrote: > > Thanks a bunch for your thorrough review Vinod - much appreciated. > On Feb. 20, 2015, 10:19 p.m., Vinod Kone wrote: > > src/authentication/cram_md5/authenticator.cpp, line 449 > >

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73310 --- src/authentication/cram_md5/authenticator.hpp

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73298 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73292 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73285 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73262 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73258 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73251 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73236 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73216 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73189 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73177 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73167 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73157 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73145 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/ --- (Updated Feb. 19, 2015, 2:02 p.m.) Review request for mesos, Adam B, Kapil Arya

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73138 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On Feb. 18, 2015, 10:50 a.m., Adam B wrote: > > src/authentication/cram_md5/authenticator.cpp, line 44 > > > > > > I'm still confused about what this log line is supposed to mean.. that > > we're inside "[CRAMMD5Aut

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73135 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/ --- (Updated Feb. 19, 2015, 11:42 a.m.) Review request for mesos, Adam B, Kapil Ary

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73123 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73106 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73102 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73093 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73092 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73089 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73083 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73047 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73021 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73011 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review72995 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On Jan. 28, 2015, 8:33 p.m., Vinod Kone wrote: > > src/master/master.cpp, lines 4193-4203 > > > > > > IIRC, sending an AuthenticationErrorMessage here causes the driver to > > simply retry the authentication and t

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review72974 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review72970 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review72967 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review72963 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review72942 --- src/master/master.cpp

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On Feb. 16, 2015, 11:37 p.m., Adam B wrote: > > src/authentication/cram_md5/authenticator.hpp, line 533 > > > > > > Should this still `process::terminate(process, false)` if the short > > term fix is now in `~CRAMM

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On Jan. 28, 2015, 12:33 p.m., Vinod Kone wrote: > > src/master/master.cpp, lines 4193-4203 > > > > > > IIRC, sending an AuthenticationErrorMessage here causes the driver to > > simply retry the authentication and

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review72932 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review72921 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review72912 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On Jan. 28, 2015, 8:33 p.m., Vinod Kone wrote: > > src/master/master.cpp, lines 4173-4190 > > > > > > Hmm. I think this is a serious enough error that the master should fail > > during initilization rather than se

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/ --- (Updated Feb. 18, 2015, 3:57 a.m.) Review request for mesos, Adam B, Kapil Arya

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On Feb. 17, 2015, 7:37 a.m., Adam B wrote: > > Looks much cleaner on first pass, but I'm still trying to figure out if you > > really need the whole > > Authenticator->AuthenticatorProcess->AuthenticatorSession->AuthenticatorSessionProcess > > hierarchy, or if just 2-3 of those would suffice

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review72680 --- Looks much cleaner on first pass, but I'm still trying to figure out

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On Jan. 28, 2015, 8:33 p.m., Vinod Kone wrote: > > Can you expand description on why you designed the authenticator inteface > > this way? Particularly, expand on "The initial design and implementation of > > the authenticator module interface caused issues and was not optimal for > > heavy

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On Feb. 4, 2015, 2:29 a.m., Adam B wrote: > > src/tests/cram_md5_authentication_tests.cpp, line 277 > > > > > > Did you mean "cancel the authentication process"? How about > > "discard..."? No I actually meant

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On Feb. 3, 2015, 8:56 p.m., Vinod Kone wrote: > > src/authentication/cram_md5/authenticator.hpp, lines 517-526 > > > > > > Instead of terminate() (or making it public) why not have an onDiscard > > handler on th

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/ --- (Updated Feb. 13, 2015, 3:20 p.m.) Review request for mesos, Adam B, Kapil Arya

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review70863 --- src/authentication/cram_md5/authenticator.hpp

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review70822 --- src/authentication/authenticator.hpp

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review70733 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/ --- (Updated Feb. 3, 2015, 11:05 a.m.) Review request for mesos, Adam B, Kapil Arya

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On Jan. 28, 2015, 12:33 p.m., Vinod Kone wrote: > > Can you expand description on why you designed the authenticator inteface > > this way? Particularly, expand on "The initial design and implementation of > > the authenticator module interface caused issues and was not optimal for > > heavy

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review70051 --- Can you expand description on why you designed the authenticator int

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On Jan. 28, 2015, noon, Adam B wrote: > > I think this is ready to commit now. > > @vinodkone, @bmahler, @karya, @nnielsen: Make any objecions ASAP, or I'll > > go ahead and commit this so it gets into 0.22. i'll take a look today. thanks for pinging. - Vinod -

  1   2   >