more CPU the amortized cost of the idle executors would not
be such a big deal.
—
*Joris Van Remoortere*
Mesosphere
On Mon, Dec 19, 2016 at 11:26 AM, Timothy Chen wrote:
> Hi Chawla,
>
> One possible reason is that Mesos fine grain mode also takes up cores
> to run the executor per
tting the impression that it's reasonable to make this change without
a deprecation cycle. Please let me know if you (anyone) disagrees.
—
*Joris Van Remoortere*
Mesosphere
On Mon, Dec 19, 2016 at 2:17 PM, Zameer Manji wrote:
> I believe this thread_local support is in XCode 8.2. From
is not too high for current developers on Apple systems then this is
a pretty easy fix :-)
Joris
—
*Joris Van Remoortere*
Mesosphere
On Tue, Dec 20, 2016 at 5:02 PM, Vinod Kone wrote:
> A consequence of using `__thread` on Apple is that initializers for thread
> locals are require
tps://reviews.apache.org/r/29526/#comment113892>
Just a note. We can replace this with the default bind once
https://reviews.apache.org/r/28485/ lands.
- Joris Van Remoortere
On Jan. 2, 2015, 4:45 a.m., Benjamin Hindman wrote:
>
> ---
/network.hpp
<https://reviews.apache.org/r/29527/#comment113897>
"Failed to bind on: "?
3rdparty/libprocess/include/process/network.hpp
<https://reviews.apache.org/r/29527/#comment113898>
"Failed to connect to: "?
- Joris Van Remoortere
On Jan. 2, 2015, 4
t;
Same as comment on line 87.
3rdparty/libprocess/src/socket.cpp
<https://reviews.apache.org/r/29528/#comment113917>
re l85: new Socket(socket())?
- Joris Van Remoortere
On Jan. 21, 2015, 5:42 p.m., Benjamin Hindman wrote:
>
> -
t using the Socket*?
3rdparty/libprocess/src/http.cpp
<https://reviews.apache.org/r/29529/#comment113929>
Why the choice of -1 versus the default of the function that reads till EOF?
- Joris Van Remoortere
On Jan. 2, 2015, 4:46 a.m.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29530/#review69291
---
Ship it!
Ship It!
- Joris Van Remoortere
On Jan. 2, 2015, 4:46
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29531/#review69293
---
Ship it!
Ship It!
- Joris Van Remoortere
On Jan. 21, 2015, 5:43
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29532/#review69294
---
Ship it!
Ship It!
- Joris Van Remoortere
On Jan. 2, 2015, 4:46
aracter.
For example, if we had an overload for std::pair in stringify, then
we could pass the hashmap to the string::join('&', url.query) function.
We might also want to support a strings::join for iterable that appends to
the stream (like the templated ver
This is the same (painful) code as in the URL streamer. Maybe this can be
factored out?
- Joris Van Remoortere
On Jan. 21, 2015, 5:45 p.m., Benjamin Hindman wrote:
>
> ---
> This is an automatically generated e-m
in the chain even for successful
futures. This will degrade performance of healthy systems.
Can we refactor this such that the callback is only called when we are
actually in a failure scenario?
- Joris Van Remoortere
On Jan. 21, 2015, 5:47 p.m., Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29536/#review69310
---
Ship it!
Ship It!
- Joris Van Remoortere
On Jan. 2, 2015, 4:46
comment that we should either improve the performance
around this, or that it's not meant to be used lightly?
Especially, the constness of the function suggests it might be really cheap
(as if we had stored a cached Address object upon bind).
- Joris Van Remoortere
On Jan. 21, 2015,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29540/#review69313
---
Ship it!
Ship It!
- Joris Van Remoortere
On Jan. 2, 2015, 4:46
terminated so we don't have to memset the char array?
- Joris Van Remoortere
On Jan. 21, 2015, 5:56 p.m., Benjamin Hindman wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
is more resilient to change, and removes the implicit knowledge that
we're picking on this element in the union because we know it to be the largest
one.
- Joris Van Remoortere
On Jan. 26, 2015, 6:56 p.m., Evelina Dumitrescu wrote:
>
> --
(inet_pton(AF_INET, value.c_str(), &in.inAddr_) == 0) {
if (inet_pton(AF_INET6, value.c_str(), &in.inAddr6_) {
error...
}
return IP::InAddrStorage(in.inAddr6_);
} else {
return IP::InAddrStorage(in.inAddr_);
}
```
- Joris Van Remoor
t; This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> ---
>
> (Updated Jan. 26, 2015, 6:56 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van
> Remoortere, and Niklas Nielsen.
>
lt;https://reviews.apache.org/r/29288/#comment114662>
indentation as above.
- Joris Van Remoortere
On Jan. 27, 2015, 4:58 p.m., Evelina Dumitrescu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, vi
.apache.org/r/29288/#comment114697>
Indentation.
3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp
<https://reviews.apache.org/r/29288/#comment114698>
Can you check the indentation here?
- Joris Van Remoortere
On Jan. 27, 2015, 4:58 p.m., Evelina Dumitrescu wrote:
>
> On Jan. 27, 2015, 6:32 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 259
> > <https://reviews.apache.org/r/29288/diff/9-10/?file=834346#file834346line259>
> >
> > I think the pattern here is 2 spaces,
> On Jan. 27, 2015, 8:14 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 853
> > <https://reviews.apache.org/r/29288/diff/10/?file=836987#file836987line853>
> >
> > Fix indentation.
>
> Evelina Dumi
tps://reviews.apache.org/r/29288/#comment114756>
Missing a default case.
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
<https://reviews.apache.org/r/29288/#comment114757>
Missing a default case.
- Joris Van Remoortere
On Jan. 27, 2015, 11:05 p.m., Evelina Dumi
> On Jan. 27, 2015, 8:14 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 1030
> > <https://reviews.apache.org/r/29288/diff/10/?file=836987#file836987line1030>
> >
> > Might be worth pulling this out as a
> On Jan. 27, 2015, 8:14 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 1030
> > <https://reviews.apache.org/r/29288/diff/10/?file=836987#file836987line1030>
> >
> > Might be worth pulling this out as a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29538/#review70141
---
Ship it!
Ship It!
- Joris Van Remoortere
On Jan. 21, 2015, 5:49
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29526/#review70425
---
Ship it!
Ship It!
- Joris Van Remoortere
On Jan. 2, 2015, 4:45
: https://reviews.apache.org/r/28763/diff/
Testing
---
configure with '--enable-libevent --enable--ssl' and without.
Thanks,
Joris Van Remoortere
---
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
/
Testing
---
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
tps://reviews.apache.org/r/29406/#comment117272>
Turn this into non-c++11 lambda
- Joris Van Remoortere
On Feb. 6, 2015, 11:43 p.m., Joris Van Remoortere wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
oring changes.
Thanks,
Joris Van Remoortere
g/r/30808/#comment117590>
return None() if we don't want to fire.
- Joris Van Remoortere
On Feb. 9, 2015, 11:21 p.m., Joris Van Remoortere wrote:
>
> ---
> This is an automatically generated e-mail. To r
ample listed in MESOS-2325. Constructed
many timers in decrementing time (i.e. 500, 499,498, etc.). CPU utilization
during this test went down greatly and is on par with code prior to the clock
refactoring changes.
Thanks,
Joris Van Remoortere
g/r/30808/#comment11>
Re-organize this to keep next() simple. Introduce a schedule() to uses next
and manipulates the global.
Return an Option rather than duration so there is no information loss.
- Joris Van Remoortere
On Feb. 10, 2015, 2:22 a.m., Joris Van Remoortere
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30884/#review71998
---
Ship it!
Ship It!
- Joris Van Remoortere
On Feb. 11, 2015, 6:40
this test with 25K timers, with 10 firing every millisecond. ~3% cpu usage
on a macbook.
Thanks,
Joris Van Remoortere
-line case statements?
```c++
switch (val) {
case 1: {
...
break;
}
case 1: {
...
break;
}
}
```
- Joris Van Remoortere
On Feb. 13, 2015, 6:54 p.m., Isabel Jimenez wrote:
>
> -
On Jan. 31, 2015, 11:27 p.m., Joris Van Remoortere wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28763/
> ---
g/r/30808/#comment118878>
Do this in clock::pause() once instead of multiple places. improves
readability. Here and below.
- Joris Van Remoortere
On Feb. 12, 2015, 11:14 p.m., Joris Van Remoortere wrote:
>
> ---
> This is a
rocess/src/libev.cpp 0e8d44cdc1daa258faafc30b5caf4a827ce6cbc1
3rdparty/libprocess/src/libevent.cpp 28c2cf7f49cc153158f2a470a1812e35f7d4b93a
Diff: https://reviews.apache.org/r/31139/diff/
Testing
---
make check.
Thanks,
Joris Van Remoortere
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31141/#review72888
---
Ship it!
Ship It!
- Joris Van Remoortere
On Feb. 18, 2015, 3:11
advance / update as
opposed to moving it up to paused?
- Joris Van Remoortere
On Feb. 18, 2015, 3:12 a.m., Ben Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/diff/
Testing
---
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
://reviews.apache.org/r/29406/diff/
Testing
---
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
s/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
Diff: https://reviews.apache.org/r/29406/diff/
Testing
---
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
- connect an ssl slave
- connect an ssl framework
Thanks,
Joris Van Remoortere
--tool=massif
Thanks,
Joris Van Remoortere
- Joris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31218/#review73254
---
On Feb. 20, 2015, 4:31 a.m., Joris Van Remoort
ocket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
g/r/29406/#comment123548>
Use the verify flag correctly. Currently it is being ignored and we always
verify the cert if provided.
- Joris Van Remoortere
On Feb. 20, 2015, 7:24 a.m., Joris Van Remoortere wrote:
>
> ---
e4082ea203f
Diff: https://reviews.apache.org/r/29406/diff/
Testing
---
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
these to None() to signify EOF.
3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/31930/#comment123820>
Can you leave a comment as to why you took a copy before calling 'close()'?
(To remove constness).
Here and below.
3rdparty/libprocess/src/tests/http_tests.cpp
&l
668647fdfc0e203fcde59263256659ba14e29960
src/java/jni/org_apache_mesos_MesosNativeLibrary.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/32151/diff/
Testing
---
Thanks,
Joris Van Remoortere
1accc8a498a68b7cfd9e39dc1f3ce01c8bfd219f
src/java/src/org/apache/mesos/state/AbstractState.java
c66bf0519e7fc671d1e167ccd1e778dc65d3d8e6
Diff: https://reviews.apache.org/r/32152/diff/
Testing
---
Thanks,
Joris Van Remoortere
?
- Joris Van Remoortere
On Nov. 20, 2014, 12:54 a.m., Cody Maloney wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29541/#review77068
---
@benh: is this still relevant?
- Joris Van Remoortere
On Jan. 31
---
make check
Thanks,
Joris Van Remoortere
://reviews.apache.org/r/28485/diff/
Testing
---
make check
Thanks,
Joris Van Remoortere
2c4258775bd90f91f1922a3cf2bb4ddf5c334881
3rdparty/libprocess/src/process.cpp e7b029ba97e640c2102548c190ba62b30602f43d
Diff: https://reviews.apache.org/r/28485/diff/
Testing
---
make check
Thanks,
Joris Van Remoortere
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28485/#review77122
-------
On March 20, 2015, 6:24 p.m., Joris Van Remoortere wrote:
>
> -
/jni/org_apache_mesos_MesosNativeLibrary.cpp PRE-CREATION
src/tests/common/version_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/32151/diff/
Testing
---
Thanks,
Joris Van Remoortere
() and minor() (http://man.he.net/man3/gnu_dev_major)
Diffs
-
3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp
090fcf09dd96538a8748cf4443d150911e2c0d27
Diff: https://reviews.apache.org/r/32550/diff/
Testing
---
Thanks,
Joris Van Remoortere
1accc8a498a68b7cfd9e39dc1f3ce01c8bfd219f
src/java/src/org/apache/mesos/state/AbstractState.java
c66bf0519e7fc671d1e167ccd1e778dc65d3d8e6
Diff: https://reviews.apache.org/r/32152/diff/
Testing
---
Thanks,
Joris Van Remoortere
/version_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/32151/diff/
Testing
---
Thanks,
Joris Van Remoortere
Diff: https://reviews.apache.org/r/32152/diff/
Testing
---
Thanks,
Joris Van Remoortere
--------------
On March 27, 2015, 10:43 p.m., Joris Van Remoortere wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32152/
>
mporary.md PRE-CREATION
Diff: https://reviews.apache.org/r/32630/diff/
Testing
---
The 'output' in the proposal shows the problem.
Thanks,
Joris Van Remoortere
I would like to propose we disallow capturing temporaries using a constant
reference:
const T& val = f();
*The reasons, and examples for this are outlined in the proposal here:*
[Review Board]: https://reviews.apache.org/r/32630/
[original markdown version]:
https://gist.github.com/jmlvanre/8a3de5
ate proposal / patch.
- Joris Van Remoortere
On March 27, 2015, 1:21 a.m., Cody Maloney wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> ht
583/#comment127658>
Add deprecated tag to indicate that no one should use this going forward.
It doesn't affect the C++ code and only adds @deprecated for Java.
optional FrameworkID framework_id = 1 [deprecated = true];
- Joris Van Remoortere
On April 1, 2015, 7:34 p.m.,
tps://reviews.apache.org/r/32911/#comment128199>
Can we remove the capture by reference here? I know it's not in the style
guide yet, but it will likely be accepted.
- Joris Van Remoortere
On April 7, 2015, 12:40 a.m., Niklas Ni
for you :-)
- Joris Van Remoortere
On April 6, 2015, 9:19 p.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
s/src/tests/benchmarks.cpp
a927e4ecd8c8955cd9f85e716173a73a9a21c6cd
Diff: https://reviews.apache.org/r/27113/diff/
Testing
---
make check
Thanks,
Joris Van Remoortere
+1
On Thu, Apr 9, 2015 at 2:14 PM, Cody Maloney wrote:
> As discussed in the last community meeting, we'd like to bump the minimum
> required compiler version from GCC 4.4 to GCC 4.8.
>
> The overall goals are to make Mesos development safer, faster, and reduce
> the maintenance burden. Currentl
tests/benchmarks.cpp
a927e4ecd8c8955cd9f85e716173a73a9a21c6cd
Diff: https://reviews.apache.org/r/27113/diff/
Testing
---
make check
Thanks,
Joris Van Remoortere
https://reviews.apache.org/r/32961/diff/
Testing
---
make check.
re-registered no_executor_framework with different 'name', 'hostname',
'failover_timeout', and 'webui_url'
Thanks,
Joris Van Remoortere
src/tests/mesos.hpp 42e42ac425a448fcc5e93db1cef1112cbf5e67c4
Diff: https://reviews.apache.org/r/33159/diff/
Testing
---
make check
Thanks,
Joris Van Remoortere
a005d55a36880e3
src/master/master.cpp 44b0a0147f5354824d86332a67b30018634c9a36
Diff: https://reviews.apache.org/r/32961/diff/
Testing
---
make check.
re-registered no_executor_framework with different 'name', 'hostname',
'failover_timeout', and 'webui_url'
Thanks,
Joris Van Remoortere
We have a dedicated IRC channel for this: "mesos-oversubscription". Feel
free to drop in and chat.
On Tue, Apr 14, 2015 at 11:09 AM, Niklas Nielsen
wrote:
> Hi everyone,
>
> In context of some of the recent discussions on 'Resource overcommittal',
> we are very interested and invested in enablin
/src/tests/benchmarks.cpp
a927e4ecd8c8955cd9f85e716173a73a9a21c6cd
Diff: https://reviews.apache.org/r/27113/diff/
Testing
---
make check
Thanks,
Joris Van Remoortere
I think the plan is to cut a new RC by sometime tomorrow. The spreadsheet
is up-to-date, just need to cherry-pick and modify the change-log.
Joris
On Tue, Apr 14, 2015 at 5:37 PM, Benjamin Mahler
wrote:
> Hey Nik, any progress on this? Is the spreadsheet up-to-date?
>
> On Wed, Apr 8, 2015 at 1
67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
Diff: https://reviews.apache.org/r/29406/diff/
Testing
---
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van
org/r/27113/diff/
Testing
---
make check
Thanks,
Joris Van Remoortere
> > figure out how we can make it more easily understandable :)
Take a look at the updated review. I'll let you mark this as fixed if you
approve :-)
- Joris
---
This is an automatically generated e-mail. To reply,
heck the style guide for includes here?
src/master/framework.cpp
<https://reviews.apache.org/r/33376/#comment131065>
Can we split out any code changes into a seperate review (with a JIRA)?
Here and elsewhere. See my high-level comment at the top of the review.
src/master/master.hpp
&l
rize and move on here.
> >
> > Proposal out on April 9, 2015. Current status (as of April 21, 2015):
> >
> >
> > +1 (Binding)
> > --
> > Vinod Kone
> > Timothy Chen
> > Yan Xu
> > Brenden Matthews
> &
> On April 21, 2015, 3:27 a.m., Joris Van Remoortere wrote:
> > Hey Marco, great first patch!
> > Some high level comments:
> > - Can you check your editor settings to make sure you don't modify lines
> > you don't intend?
> > - Just do a quick look
We had an internal discussion about this. White-listing constexpr is fine
by us.
I think technically the google style guide allows c++11 features that are
not explicitly disallowed, but it doesn't hurt to add it to the style guide
:-)
Joris
On Thu, May 28, 2015 at 4:27 PM, Paul Brett
wrote:
> D
015 at 4:45 PM, Joris Van Remoortere >
> wrote:
>
> > We had an internal discussion about this. White-listing constexpr is fine
> > by us.
> > I think technically the google style guide allows c++11 features that are
> > not explicitly disallowed, but it doesn&#
These 2 JIRAs might be helpful:
https://issues.apache.org/jira/browse/MESOS-786
https://issues.apache.org/jira/browse/MESOS-6249
—
*Joris Van Remoortere*
Mesosphere
On Tue, Jan 17, 2017 at 5:31 PM, Zhitao Li wrote:
> Hi,
>
> I'm helping a scheduler author to deal with a prob
derstanding whether you mean leaving the message unset, or
the field?
—
*Joris Van Remoortere*
Mesosphere
On Thu, Feb 2, 2017 at 3:06 PM, Yan Xu wrote:
> With protobuf you can specify custom default values for scalar types
> (proto2 at least) but not message types, e.g.,
>
>
This looks interesting.
I would recommend creating a JIRA and attaching it to the review.
One preliminary question: Can we not probe the filesystem to identify
whether it is a RAM_FS? Why do we need to add administrator flags for this?
—
*Joris Van Remoortere*
Mesosphere
On Wed, Dec 28, 2016
file reduces the compile time.
A good example of heave .o files are the mesos tests that scan close to all
of stout / libprocess for each test file.
—
*Joris Van Remoortere*
Mesosphere
On Tue, Feb 14, 2017 at 4:49 PM, Jeff Coffler <
jeff.coff...@microsoft.com.invalid> wrote:
> Hi Neil,
&
Hello developers,
It has come that time again where our review backlog got too long.
As we have done previously, I've discarded older reviews. This time all
reviews that had been inactive for over 2 months.
If I discarded one of your reviews you should have received an e-mail
directed at the addr
As if you
don't plan on following up on this yourself in the near future?
—
*Joris Van Remoortere*
Mesosphere
On Mon, Mar 27, 2017 at 4:03 PM, Jeff Coffler <
jeff.coff...@microsoft.com.invalid> wrote:
> I had previously send an E-Mail to the Mesos DEV list on Tue 2/14/2017
> 1
/include/stout/strings.hpp a1702cd
3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 51008e5
Diff: https://reviews.apache.org/r/25789/diff/
Testing
---
Ran make check for stout. Added test cases for join as these were missing.
Thanks,
Joris Van Remoortere
> On Sept. 12, 2014, 7:03 p.m., Ben Mahler wrote:
> > Thanks for doing this! A few higher level comments:
> >
> > (1) We have strings::join in stout. Have you considered implementing this
> > TLineHelper as a generic Joiner in stout/strings.hpp? Seems like it belongs
> > there instead of a new
101 - 200 of 471 matches
Mail list logo
