Re: Review Request 30952: Adding scheduler validations to master

952/#comment122779> Is there a test for this? If not, can you write one? Also add a TODO in the old driver to remove this code. src/master/validation.cpp <https://reviews.apache.org/r/30952/#comment122775> Can this made a CHECK now? - Vinod Kone On March 3, 2015, 6:32

Re: Build failed in Jenkins: mesos-reviewbot #4464

this just seems to be a connection issue? On Fri, Mar 6, 2015 at 9:51 AM, Niklas Nielsen wrote: > Still the python clean up issue ( > https://issues.apache.org/jira/browse/MESOS-2362) > > Niklas > > On 6 March 2015 at 09:24, Apache Jenkins Server > > wrote: > > > See

Design doc for Mesos HTTP API

Hi, As you might've observed from the JIRA activity (MESOS-2288 ), we have embarked on the design of a new HTTP API for Mesos. The link for the design doc is here

Re: Design doc for Mesos HTTP API

r 9, 2015 at 2:31 PM, Vinod Kone wrote: > >> Hi, >> >> As you might've observed from the JIRA activity (MESOS-2288 >> <https://issues.apache.org/jira/browse/MESOS-2288>), we have embarked on >> the design of a new HTTP API for Mesos. The link for the desig

Review Request 31872: Fixed process::initialize() to correctly deal with 127.0.0.1 address.

--- make check Balloon framework passes now. Thanks, Vinod Kone

Review Request 31905: Fixed protobuf comparisons by accounting for new fields.

://reviews.apache.org/r/31905/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 31905: Fixed protobuf comparisons by accounting for new fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31905/#review75922 --- On March 10, 2015, 6:27 p.m., Vinod Kone wrote: > > --- &g

Re: Review Request 31905: Fixed protobuf comparisons by accounting for new fields.

reply, visit: https://reviews.apache.org/r/31905/#review75936 --- On March 10, 2015, 6:27 p.m., Vinod Kone wrote: > > --- > This is an automatically generated e-m

Re: Review Request 31905: Fixed protobuf comparisons by accounting for new fields.

ver. I'll send a review out for those tests in a subsequent review. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31905/#review75925 ------

Re: Review Request 31905: Fixed protobuf comparisons by accounting for new fields.

/common/type_utils.cpp a1704c67d04d19f65d94dbe56a61bb28561e5bf3 Diff: https://reviews.apache.org/r/31905/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

views.apache.org/r/27760/#comment123585> Per our offline discussion, I think we can get rid of this promise altogether now. please send a dependent review for that. src/master/master.cpp <https://reviews.apache.org/r/27760/#comment123503> N

Re: Review Request 31960: Added concurrency protection within the SASL auxprop plugin code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31960/#review76164 --- Ship it! Ship It! - Vinod Kone On March 11, 2015, 11:06 p.m

Re: Review Request 31961: Split cram_md5 authenticator into declaration and implementation without functional changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31961/#review76176 --- Ship it! Thanks for the split! - Vinod Kone On March 12, 2015

Review Request 31904: Fixed comparison of protobufs with optional fields.

a1704c67d04d19f65d94dbe56a61bb28561e5bf3 Diff: https://reviews.apache.org/r/31904/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 31951: Added test for long lived executors.

; move this to just above detector.appoint() - Vinod Kone On March 11, 2015, 6:43 p.m., Niklas Nielsen wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 31905: Fixed protobuf comparisons by accounting for new fields.

ommon/type_utils.cpp a1704c67d04d19f65d94dbe56a61bb28561e5bf3 Diff: https://reviews.apache.org/r/31905/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 31905: Fixed protobuf comparisons by accounting for new fields.

w. I will fix this as part of: https://issues.apache.org/jira/browse/MESOS-2487 - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31905/#review76084 ---

Re: Review Request 31905: Fixed protobuf comparisons by accounting for new fields.

> On March 10, 2015, 6:40 p.m., Zameer Manji wrote: > > src/common/type_utils.cpp, line 56 > > <https://reviews.apache.org/r/31905/diff/1/?file=890459#file890459line56> > > > > Would it be possible to add some sort of test or tooling to prevent >

Re: Review Request 32002: Add doc for slave_removal_rate_limit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32002/#review76315 --- Ship it! Ship It! - Vinod Kone On March 12, 2015, 8:42 p.m

Re: Review Request 32034: Fixed unused comparisons on the == operator for TaskStatus.

034/#comment123938> oops. thanks for fixing! - Vinod Kone On March 13, 2015, 10:56 a.m., Alexander Rojas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: How to sizing memory in mesos

The only way you can increase or decrease memory for an executor is by launching/killing tasks. So you could presumably use no-op tasks to achieve what you want. On Fri, Mar 13, 2015 at 7:51 AM, haosdent wrote: > Hello, I write a redis service based on Mesos. And I have a problem: when > I launc

Re: executor source not set

It is enforced by the slave to be future proof (a future where there will be no executor driver). https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L2491 On Sun, Mar 15, 2015 at 11:45 AM, James DeFelice wrote: > Is there a reason that the native executor driver bindings don't chec

Re: executor source not set

;m observing this on 0.21.0. > > On Sun, Mar 15, 2015 at 9:55 PM, Vinod Kone wrote: > > > It is enforced by the slave to be future proof (a future where there will > > be no executor driver). > > > > https://github.com/apache/mesos/blob/master/src/slave/slav

Re: executor source not set

liation > > processes. For example: > > > > > reason="REASON_RECONCILIATION",source="SOURCE_MASTER",state="TASK_RUNNING" > > > > But for status updates generated by my executor, the scheduler sees this: > > > > reason="

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

.cpp <https://reviews.apache.org/r/27760/#comment124240> see my comments in CramMD5Authenticator::initialize(). No credentials didn't lead to AuthenticationErrorMessage before but rather refusal of authentication. - Vinod Kone

Re: Review Request 32130: Ensured TaskStatus::source field is set for executor status updates.

t; Pull this to the top. // Make a copy to set source. StatusUpdate update = update_; src/slave/slave.cpp <https://reviews.apache.org/r/32130/#comment124408> pull this down to where it's first used, #2517. - Vinod Kone On March 16, 2015

Re: Review Request 32130: Ensured TaskStatus::source field is set for executor status updates.

> On March 17, 2015, 5:59 p.m., Vinod Kone wrote: > > > > Alexander Rukletsov wrote: > Vinod, we can avoid all these dances if we pass update by value. I would > prefer this approach, but it's with our codebase, therefore I went for a > copy. What

Re: Build failed in Jenkins: mesos-reviewbot #4651

Newly added 'cloud-slave' jenkin nodes do not seem to have the prereqs to build mesos. Adjusted the job label to not land on them. On Tue, Mar 17, 2015 at 12:56 PM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See > > --

Re: Review Request 32130: Ensured TaskStatus::source field is set for executor status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32130/#review76830 --- Ship it! modulo nik's comments. - Vinod Kone On March 17,

Review Request 32179: Deleted intermediate Call/Event based scheduler driver.

5222b6d5e66736495b743367b5731bb9094410fd src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657 Diff: https://reviews.apache.org/r/32179/diff/ Testing --- make check Thanks, Vinod Kone

Review Request 32180: Updated scheduler Event/Call protobufs.

783a63ad1cc0edd86605d638046fb959cb6e97e8 src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1 src/sched/sched.cpp 66fd2b3146568900356cc48e0f17c6720665ae80 Diff: https://reviews.apache.org/r/32180/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 31985: Mesos container ID available to the executor through an environment variable.

rote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31985/ > --- > > (Updated March 20, 2015, 9:27 a.m.

Re: [jira] [Created] (MESOS-2524) Mesos-containerizer not linked from main documentation page.

No reason. Feel free to fix. On Fri, Mar 20, 2015 at 6:02 AM, Joerg Schad (JIRA) wrote: > Joerg Schad created MESOS-2524: > -- > > Summary: Mesos-containerizer not linked from main > documentation page. > Key: MESOS-2524 >

Re: Review Request 31985: Mesos container ID available to the executor through an environment variable.

t as a > way to extract the specific container. > 3. I am not sure, then, what would be considered mesos private info and > info which can be shared. For example, why can the framework id and the > executor id be shared but no the container id? > > Vinod Kone wrote: >

Re: Review Request 29329: Add executor for docker containerizer

ed in understanding how the shortcomings you discussed in the doc will be addressed for custom executor scenarios. Also, can you create a JIRA ticket and attach? - Vinod Kone On Jan. 17, 2015, 1:26 a.m., Timothy Chen wrote: > > --- &

Re: Review Request 32405: Fixed the non-POD global variables in port mapping isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32405/#review77439 --- Ship it! Ship It! - Vinod Kone On March 23, 2015, 5:05 p.m

Re: jira assignments and shepherding

added you to contributors list. you should be able to assign tickets to yourself now. On Tue, Mar 24, 2015 at 10:49 AM, James Peach wrote: > Hi all, > > I would like to contribute patches for: > > MESOS-2545 > MESOS-2537 > > Could a committer please assign those to me (my JIRA us

Re: Review Request 32426: Symlink the namespace handle with ContainerID for the port mapping isolator.

rizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/32426/#comment125758> s/older versions/older (pre 0.23.0) versions/ - Vinod Kone On March 24, 2015, 2:44 a.m., Jie Yu wrote: > > --- > This is an au

Re: Review Request 32336: Moved http::Request::accepts from header into cpp file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32336/#review77633 --- Ship it! Ship It! - Vinod Kone On March 20, 2015, 11:51 p.m

Re: Review Request 32337: Moved http::initialize from header to .cpp file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32337/#review77635 --- Ship it! Ship It! - Vinod Kone On March 20, 2015, 11:51 p.m

Re: Review Request 32338: Moved http encode/decode from header to .cpp file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32338/#review77636 --- Ship it! Ship It! - Vinod Kone On March 20, 2015, 11:51 p.m

Re: Review Request 32339: Moved http::path::parse from header to .cpp file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32339/#review77637 --- Ship it! Ship It! - Vinod Kone On March 20, 2015, 11:51 p.m

Re: Review Request 32340: Moved http::URL output operator from header to .cpp file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32340/#review77638 --- Ship it! Ship It! - Vinod Kone On March 20, 2015, 11:51 p.m

Re: Review Request 32341: Fixed a copy/paste naming mistake in decoder_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32341/#review77640 --- Ship it! Ship It! - Vinod Kone On March 20, 2015, 11:51 p.m

Re: Review Request 32342: Updated the http-parser upgrade TODO.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32342/#review77641 --- Ship it! Ship It! - Vinod Kone On March 20, 2015, 11:51 p.m

Re: Review Request 32343: Re-ordered decoder callbacks to be in execution order.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32343/#review77642 --- Ship it! Ship It! - Vinod Kone On March 20, 2015, 11:51 p.m

Re: Review Request 32345: Removed use of 'assert' in decoder.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32345/#review77643 --- Ship it! Ship It! - Vinod Kone On March 20, 2015, 11:51 p.m

Re: Review Request 32348: Re-ordered and updated documentation for http::get/post/put.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32348/#review77645 --- Ship it! Ship It! - Vinod Kone On March 20, 2015, 11:51 p.m

Re: Review Request 32349: Removed http::put and added a TODO.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32349/#review77646 --- Ship it! Ship It! - Vinod Kone On March 20, 2015, 11:51 p.m

Re: Review Request 32350: Added a wrapper for HttpProcess to prevent segfaults during test failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32350/#review77647 --- Ship it! Ship It! - Vinod Kone On March 20, 2015, 11:51 p.m

Review Request 32454: Fixed flaky MesosContainerizerDestroyTest tests.

, Vinod Kone

Review Request 32500: Removed LAUNCH call from scheduler.proto.

4a89a7a88b50bb8c254f5076661ce07ac9fc7657 Diff: https://reviews.apache.org/r/32500/diff/ Testing --- make check Thanks, Vinod Kone

Review Request 32501: Removed REQUEST call from scheduler.proto.

/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a Diff: https://reviews.apache.org/r/32501/diff/ Testing --- make check Thanks, Vinod Kone

Review Request 32502: Updated RECONCILE call to always specifiy slave id.

, Vinod Kone

Review Request 32504: Removed MasterInfo from REGISTER and REREGISTER scheduler calls.

r.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a Diff: https://reviews.apache.org/r/32504/diff/ Testing --- make check Thanks, Vinod Kone

Review Request 32505: Added SHUTDOWN scheduler call.

src/slave/slave.hpp 19e6b44bc344c0ca509674803f401cbb4e1f47ae src/slave/slave.cpp c7e65a6c095963feaa9d5fdbb519c68f8f761d16 src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657 Diff: https://reviews.apache.org/r/32505/diff/ Testing --- make check Thanks, Vinod Kone

Review Request 32506: Added output stream operators for scheduler Calls and Events.

://issues.apache.org/jira/browse/MESOS-1127 Repository: mesos Description --- For readable output in logs. Diffs - include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45 Diff: https://reviews.apache.org/r/32506/diff/ Testing --- make check Thanks, Vinod Kone

Review Request 32507: Moved REGISTER and REREGISTER out of scheduler Calls.

66fd2b3146568900356cc48e0f17c6720665ae80 src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657 Diff: https://reviews.apache.org/r/32507/diff/ Testing --- make check Thanks, Vinod Kone

Review Request 32508: Added version to the scheduler protobufs.

/low_level_scheduler_pthread.cpp 6d1f938660c02db75bfcbf7c8de0d941cff1920d src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657 Diff: https://reviews.apache.org/r/32508/diff/ Testing --- make check Thanks, Vinod Kone

Review Request 32509: Documented the scheduler Event/Call protobufs.

://issues.apache.org/jira/browse/MESOS-1127 Repository: mesos Description --- See summary. Diffs - include/mesos/scheduler/scheduler.proto 783a63ad1cc0edd86605d638046fb959cb6e97e8 Diff: https://reviews.apache.org/r/32509/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 32426: Symlink the namespace handle with ContainerID for the port mapping isolator.

t;. src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/32426/#comment125991> s/later/in 0.23.0/ src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32426/#comment125994> s/mount file/mount file or its symlink/ ? src/tests/

Re: Review Request 30952: Adding scheduler validations to master

org/r/30952/#comment126285> Also add a TODO in sched.cpp to remove this validation in 0.24.0. - Vinod Kone On March 23, 2015, 2:34 a.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 32463: Improved testing around state.json endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32463/#review77933 --- Ship it! lgtm modulo alex's comments. - Vinod Kone On Mar

Re: Review Request 32426: Symlink the namespace handle with ContainerID for the port mapping isolator.

r/32426/#comment126338> When do the namespace handles and veth links for these get cleaned up? src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/32426/#comment126339> Shouldn

Re: Review Request 32555: Fixed the rate limiting of slave removals during master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32555/#review77980 --- Ship it! Ship It! - Vinod Kone On March 26, 2015, 11:54 p.m

Re: Review Request 32506: Added output stream operators for scheduler Calls and Events.

/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1 Diff: https://reviews.apache.org/r/32506/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 32507: Moved REGISTER and REREGISTER out of scheduler Calls.

/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 32509: Documented the scheduler Event/Call protobufs.

783a63ad1cc0edd86605d638046fb959cb6e97e8 Diff: https://reviews.apache.org/r/32509/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 32426: Symlink the namespace handle with ContainerID for the port mapping isolator.

/port_mapping.cpp <https://reviews.apache.org/r/32426/#comment126371> s/root/that have valid veth links and namespace handles/ src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/32426/#comment126370> s/NOTE/Note/ - Vinod Kone On March 27, 2015, 12:

Splitting reviews and build emails into their own mailing lists

Hi, What do you guys think about moving the review and build (CI) emails to their own mailing lists (reviews@ and builds@). Quite a few people that I have talked to have mentioned that there is too much noise on our dev list to get at the signal (dev discussions, release announcements, API change

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

s an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27760/ > --- > > (Updated March 25, 2015, 11:35 p.m.) > > > Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Vinod Kon

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review78222 --- Ship it! Ship It! - Vinod Kone On March 28, 2015, 2:25 a.m

Re: Review Request 31838: Fixed authentication failure triggered slave crash.

running tasks and executors if authentication fails. I think that is dangerous. For example if the master is misconfigured with wrong credentials, this could potentially shut down the whole cluster! I think the safer thing to do is to EXIT(1) in _authenticate() instead of shutdown(). - Vinod Kone

Re: Review Request 32500: Removed LAUNCH call from scheduler.proto.

/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657 Diff: https://reviews.apache.org/r/32500/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 32500: Removed LAUNCH call from scheduler.proto.

cally generated e-mail. To reply, visit: https://reviews.apache.org/r/32500/#review77836 --- On March 25, 2015, 11:06 p.m., Vinod Kone wrote: > > --- >

Re: Review Request 32501: Removed REQUEST call from scheduler.proto.

.proto. Thanks. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32501/#review77842 --- On March 25, 2015, 11:

Re: Review Request 32501: Removed REQUEST call from scheduler.proto.

--- make check Thanks, Vinod Kone

Re: Review Request 32502: Updated RECONCILE call to always specifiy slave id.

eduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657 Diff: https://reviews.apache.org/r/32502/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 32501: Removed REQUEST call from scheduler.proto.

> On March 26, 2015, 1:32 a.m., Ben Mahler wrote: > > Should you be adding a TODO on 'Request' to remove it when the old driver > > goes away? Or is there a reason to leave it indefinitely? > > Vinod Kone wrote: > Added TODOs in master.hpp and mes

Re: Review Request 32504: Removed MasterInfo from REGISTER and REREGISTER scheduler calls.

thread.cpp 6d1f938660c02db75bfcbf7c8de0d941cff1920d src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a Diff: https://reviews.apache.org/r/32504/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 32505: Added SHUTDOWN scheduler call.

https://reviews.apache.org/r/32505/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 32506: Added output stream operators for scheduler Calls and Events.

618db68ee4163b06e479cf3413eda4b63c9c5a4b Diff: https://reviews.apache.org/r/32506/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 32505: Added SHUTDOWN scheduler call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32505/#review78050 ------- On March 31, 2015, 12:09 a.m., Vinod Kone wrote: > >

Re: Review Request 32507: Moved REGISTER and REREGISTER out of scheduler Calls.

/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 32508: Added version to the scheduler protobufs.

4a89a7a88b50bb8c254f5076661ce07ac9fc7657 Diff: https://reviews.apache.org/r/32508/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 32509: Documented the scheduler Event/Call protobufs.

/r/32509/diff/ Testing --- make check Thanks, Vinod Kone

Re: Facing issues submit review requests using support/post_review.py

Are you still having issue with this? I've seen this issue before when my branch depends on a file that was recently committed. The mesos repo used by ReviewBoard is a mirror of the canonical mesos repo and there is sometimes lag in the commits from the latter reaching the former. But the issue us

Re: Review Request 31775: Removed Master::Flags dependency from Allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31775/#review78689 --- Ship it! Ship It! - Vinod Kone On April 1, 2015, 2:24 p.m

Re: Review Request 31776: Moved allocator to public headers.

tps://reviews.apache.org/r/31776/#comment127643> Since allocator is within the same Unix process as Master, what is the compatibility issue here? src/Makefile.am <https://reviews.apache.org/r/31776/#comment127644> not yours, but can you kill the trailing white space here? - Vinod Kone

Re: Review Request 31266: Added support for allocator modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31266/#review78693 --- Ship it! Ship It! - Vinod Kone On April 1, 2015, 2:26 p.m

Re: Review Request 31267: Added a test allocator module.

267/#comment127646> s/drf// to be consistent (e.g., we didn't name libtestauthentication.la as libcrammd5authentication.la) src/tests/module.cpp <https://reviews.apache.org/r/31267/#comment127647> s/drf// - Vinod Kone On April 1, 2015, 2:26 p.m., Alexande

Re: Review Request 31262: Moved allocator actions before TestAllocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31262/#review78696 --- Ship it! Ship It! - Vinod Kone On April 1, 2015, 2:27 p.m

Re: Review Request 31263: Refactored TestAllocator and allocator text fixture.

} void destroy() { delete allocator; allocator = NULL; } virtual void TearDown() { destroy(); MeosTest::TearDown(); } private: TestAllocator* allocator; }; ``` - Vinod Kone On April 1, 2015, 2:27

Re: Review Request 31265: Provided a factory for allocator in tests.

tps://reviews.apache.org/r/31265/#comment127667> Do you still want the constructor public? - Vinod Kone On April 1, 2015, 2:28 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 31268: Wired up test allocator to allocator tests.

! Made reviewing it such a pleasure. - Vinod Kone On April 1, 2015, 2:29 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32805: Terminated the perf subprocess once the parent exits.

his child runs the perf command. src/linux/perf.cpp <https://reviews.apache.org/r/32805/#comment127842> Comment that the parent blocks until the child (i.e., perf command) exits. src/linux/perf.cpp <https://reviews.apache.org/r/32805/#comment127834> Comment here too. - Vi

Re: Review Request 32833: Added os::signals::install to install signal handlers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32833/#review78836 --- Ship it! Ship It! - Vinod Kone On April 3, 2015, 9:28 p.m., Jie

Re: Review Request 32832: Added CHANGELOG for 0.22.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32832/#review78855 --- Ship it! Ship It! - Vinod Kone On April 3, 2015, 10:58 p.m

Re: Review Request 32502: Updated RECONCILE call to always specifiy slave id.

gt; On March 31, 2015, 9:49 p.m., Ben Mahler wrote: > > src/tests/scheduler_tests.cpp, line 298 > > <https://reviews.apache.org/r/32502/diff/2/?file=910153#file910153line298> > > > > newline here? done - Vinod -------

Re: Review Request 32502: Updated RECONCILE call to always specifiy slave id.

ster/master.cpp 618db68ee4163b06e479cf3413eda4b63c9c5a4b src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657 Diff: https://reviews.apache.org/r/32502/diff/ Testing --- make check Thanks, Vinod Kone

<    1   2   3   4   5   6   7   8   9   10   >