Re: Review Request 59523: RANGER-689 - "For Solr plugin, use resources folders for adding Ranger properties".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59523/#review194153 --- Ship it! Ship It! - Alejandro Fernandez On May 24, 2017, 11

Re: Review Request 64323: RANGER-1915:Optimize the code and keep the code style consistent in the RangerAdminRESTClient class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64323/#review192807 --- Ship it! Ship It! - Alejandro Fernandez On Dec. 5, 2017, 2

Re: Review Request 63987: RANGER-1905 : fix maven assembly creation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63987/#review191611 --- Ship it! Ship It! - Alejandro Fernandez On Nov. 21, 2017, 4

Re: Review Request 63981: RANGER-1903:Simplify hdfs-agent dependency management in pom.xml

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63981/#review191571 --- Ship it! Ship It! - Alejandro Fernandez On Nov. 21, 2017, 9

Re: Review Request 63921: RANGER-1896 : Remove deprecated extractedCommonCriterias call from the SearchUtil and fix the UserREST controller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63921/#review191525 --- Ship it! Ship It! - Alejandro Fernandez On Nov. 17, 2017, 4

Re: Review Request 63949: RANGER-1898 - Simplify Knox plugin dependency management

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63949/#review191524 --- Ship it! Ship It! - Alejandro Fernandez On Nov. 20, 2017, 1

Re: Review Request 63789: RANGER-1887:serviceDef.getResources().get(0).getName(); case IndexOutOfBoundsException in RangerServiceTag.class And print error in RangerServiceStorm

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63789/#review191374 --- Ship it! Ship It! - Alejandro Fernandez On Nov. 17, 2017, 6

Re: Review Request 63870: RANGER-1861:There are errors when the "ranger-kms start" command was executed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63870/#review191209 --- Ship it! Ship It! - Alejandro Fernandez On Nov. 16, 2017

Re: Review Request 63182: RANGER-1849 - Remove PasswordGenerator and FileStoreUtil

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63182/#review191208 --- Ship it! Ship It! - Alejandro Fernandez On Nov. 16, 2017

Re: Review Request 63785: RANGER-1884 : Default Policy is not created for Ranger KMS and Tag service

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63785/#review190976 --- Ship it! Ship It! - Alejandro Fernandez On Nov. 14, 2017, 4

Re: Review Request 63699: RANGER-1882 - Compilation error in kms module with Hadoop 2.8.x

/KMSAuthenticationFilter.java Line 74 (original), 73 (patched) <https://reviews.apache.org/r/63699/#comment268127> Which other versions of Hadoop are supported? - Alejandro Fernandez On Nov. 9, 2017, 1:17 p.m., Colm O hEigeartaigh

Re: Review Request 63686: TagSync update to process TRAIT_UPDATE notification from Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63686/#review190506 --- Ship it! Ship It! - Alejandro Fernandez On Nov. 8, 2017, 11

Re: Review Request 63627: RANGER-1876 - Incorrect conf dir location for Yarn install script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63627/#review190346 --- Ship it! Ship It! - Alejandro Fernandez On Nov. 7, 2017, 3

Re: Review Request 63461: Good coding practice in Ranger recommended by static code analysis

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63461/#review190192 --- Ship it! Ship It! - Alejandro Fernandez On Nov. 1, 2017, 12

Re: Review Request 63405: RANGER-1864: Resources are not rendering correctly in policy create/edit page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63405/#review189634 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 30, 2017

Re: Review Request 63352: RANGER-1860:Provide a new service interface prompt function framework to resolved the defect of the current service interface, increase the flexibility of the function, impro

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63352/#review189633 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 30, 2017, 6

Re: Review Request 63403: RANGER-1862:generalName.get(1) cause IndexOutOfBoundsException in NiFiClient

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63403/#review189630 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 30, 2017, 3

Re: Review Request 63404: RANGER-1863:Optimize the code and keep the code style consistent, remove the invalid code in the RemoteUnixLoginModule class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63404/#review189629 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 30, 2017, 6

Re: Review Request 63351: RANGER-1859:Fix new findBugs in HdfsClient.java

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63351/#review189439 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 27, 2017, 9

Re: Review Request 62882: Good coding practice-add additional headers in ranger

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62882/#review189112 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 17, 2017

Re: Review Request 63225: Additional back-end work with more ServiceDef validations for Policy create/edit form should display only relevant accesses based on the user-selected resource

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63225/#review189003 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 23, 2017

Re: Review Request 63225: Additional back-end work with more ServiceDef validations for Policy create/edit form should display only relevant accesses based on the user-selected resource

r.java Lines 601 (patched) <https://reviews.apache.org/r/63225/#comment265930> Add some JavaDoc for this function - Alejandro Fernandez On Oct. 23, 2017, 9:45 p.m., Abhay Kulkarni wrote: > > --- > This is an automatic

Re: Review Request 63142: Ranger admin support hdfs HA configuration when creating hdfs service.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63142/#review188855 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 20, 2017, 6

Re: Review Request 63145: This JAVA_VERSION_REQUIRED configuration item is invalid in security admin installer, we should enable it to control the necessary java version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63145/#review188803 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 20, 2017, 2

Re: Review Request 63147: RANGER-1845 - Add support to configure JWT signature algorithms

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63147/#review188714 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 19, 2017, 1

Re: Review Request 63145: This JAVA_VERSION_REQUIRED configuration item is invalid in security admin installer, we should enable it to control the necessary java version.

!= "$JAVA_VERSION_REQUIRED" ]]; then ... - Alejandro Fernandez On Oct. 19, 2017, 1 p.m., pengjianhua wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request 63142: Ranger admin support hdfs HA configuration when creating hdfs service.

/HdfsClient.java Lines 300 (patched) <https://reviews.apache.org/r/63142/#comment265718> Doesn't this also have to set dfs.namenode.http-address.$cluster.$nn_id ? and potentially https instead if SSL is enabled. - Alejandro Fernandez On Oct. 19, 2017, 11:41 a.m., Qiang

Re: Review Request 63085: Tag enricher performance improvement in identifying tags for resource being accessed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63085/#review188547 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 18, 2017, 6

Re: Review Request 63115: RANGER-1820: Updated optimized db schema script for SQLServer DB

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63115/#review188532 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 18, 2017, 5

Re: Review Request 63085: Tag enricher performance improvement in identifying tags for resource being accessed

/ranger/plugin/contextenricher/RangerTagEnricher.java Lines 155 (patched) <https://reviews.apache.org/r/63085/#comment265527> Please add JavaDoc to new classes & methods. - Alejandro Fernandez On Oct. 18, 2017, 1:03 a.m., Abhay Kulk

Re: Review Request 62882: Good coding practice-add additional headers in ranger

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62882/#review188343 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 17, 2017

Re: Review Request 63068: RANGER-1842 - Don't catch Throwables in the test code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63068/#review188342 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 17, 2017

Re: Review Request 63055: Audit log records for 'use dbName' and 'show databases' hive commands contain large number of tags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63055/#review188244 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 16, 2017

Re: Review Request 62483: Service should not be renamed if tagged service resources exist for it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62483/#review188190 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 16, 2017, 6

Re: Review Request 63030: RANGER-1839 - Add the ability to specify SSO token audiences

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63030/#review188177 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 16, 2017, 2

Re: Review Request 62971: LOG class is imported error for RangerServiceService class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62971/#review187987 --- What testing was done? - Alejandro Fernandez On Oct. 13, 2017

Re: Review Request 62967: RANGER-1835:The installer of the security admin should not repeatedly add a user to the same group.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62967/#review187986 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 13, 2017, 3

Re: Review Request 62850: RANGER-1827: microbenchmark for policy evaluation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62850/#review187867 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 12, 2017, 8

Re: Review Request 62947: Update Ranger to use 0.8.1 Atlas version

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62947/#review187858 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 12, 2017, 7

Re: Review Request 62882: Good coding practice-add additional headers in ranger

/filter/RangerSecurityContextFormationFilter.java Lines 144 (patched) <https://reviews.apache.org/r/62882/#comment264870> This should include "includeSubDomains" https://www.owasp.org/index.php/HTTP_Strict_Transport_Security_Cheat_Sheet - Alejandro Fernandez On Oct. 12

Re: Review Request 62724: RANGER-1822 - Remove ssoEnabled accessors in RangerSSOAuthenticationFilter

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62724/#review187613 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 2, 2017, 2

Re: Review Request 62850: RANGER-1827: microbenchmark for policy evaluation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62850/#review187572 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 10, 2017

Re: Review Request 62850: RANGER-1827: microbenchmark for policy evaluation

(patched) <https://reviews.apache.org/r/62850/#comment264457> Please add JavaDoc to all new classes and important methods - Alejandro Fernandez On Oct. 9, 2017, 9:19 p.m., Endre Zoltan Kovacs wrote: > > --- > This is an automatic

Re: Review Request 62686: RANGER-1816:When the error occurs, the system does not record the error message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62686/#review187428 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 9, 2017, 2

Re: Review Request 62714: RANGER-1819: Not able to delete group that is having special character(ampersand) from ranger admin.

/ranger/rest/XUserREST.java Line 373 (original), 373 (patched) <https://reviews.apache.org/r/62714/#comment264040> Should use StringUtils.isNotBlank(userName) - Alejandro Fernandez On Oct. 4, 2017, 10:38 a.m., Nitin Galave

Re: Review Request 62751: RANGER-1824 - Upgrade Spring Framework to 3.2.18

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62751/#review186951 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 3, 2017, 2

Re: Review Request 62710: RANGER-1810:Ranger supports plugin to enable, monitor and manage apache Sqoop2

> On Oct. 2, 2017, 6:13 p.m., Alejandro Fernandez wrote: > > Awesome contribution. - Alejandro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62710/#rev

Re: Review Request 62710: RANGER-1810:Ranger supports plugin to enable, monitor and manage apache Sqoop2

opConnectorResponse.java Lines 21 (patched) <https://reviews.apache.org/r/62710/#comment263706> Add JavaDoc - Alejandro Fernandez On Sept. 30, 2017, 8:34 a.m., Qiang Zhang wrote: > > --- > This is an automatically gen

Re: Review Request 62713: RANGER 1818: Good coding practice in Ranger recommended by static code analysis

/apache/ranger/authentication/PasswordValidator.java Line 117 (original), 117 (patched) <https://reviews.apache.org/r/62713/#comment263698> Put a space after the "," - Alejandro Fernandez On Sept. 30, 2017, 10:17 a.m., F

Re: Review Request 62657: The drop-down box name "database" is not showing full when edit hive policy

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62657/#review186595 --- Ship it! Ship It! - Alejandro Fernandez On Sept. 28, 2017

Re: Review Request 62657: The drop-down box name "database" is not showing full when edit hive policy

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62657/#review186596 --- Which browsers was this tested on? - Alejandro Fernandez

Re: Review Request 62662: Fix invalid code and error logic for the BaseDao class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62662/#review186594 --- Any testing done on this? - Alejandro Fernandez On Sept. 28

Re: Review Request 62659: RANGER-1814 : Move the reader into a local variable in LocalFileLogBuffer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62659/#review186584 --- Ship it! Ship It! - Alejandro Fernandez On Sept. 28, 2017

Re: Review Request 62436: RANGER-1779 : last resource gets duplicated during update policy if policy is created through public api rest call

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62436/#review186486 --- Ship it! Ship It! - Alejandro Fernandez On Sept. 27, 2017

Re: Review Request 62024: RANGER-1756: Handle role related restrictions for users having User role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62024/#review186458 --- Ship it! Ship It! - Alejandro Fernandez On Sept. 27, 2017

Re: Review Request 62437: RANGER-1779 : last resource gets duplicated during update policy if policy is created through public api rest call

/PatchForNifiResourceUpdateExclude_J10011.java Lines 108 (patched) <https://reviews.apache.org/r/62437/#comment263006> Might want to add some javadoc - Alejandro Fernandez On Sept. 27, 2017, 10:11 a.m., Nikhil P

Re: Review Request 62520: Here is a error in getStatusResponse() when post data exception for AtlasClient class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62520/#review186451 --- Ship it! Ship It! - Alejandro Fernandez On Sept. 27, 2017

Re: Review Request 62567: RANGER-1727 : Ranger allows user to change an external user's password with 'null' old password

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62567/#review186450 --- Ship it! Ship It! - Alejandro Fernandez On Sept. 26, 2017

Re: Review Request 62555: RANGER-1801: group user mapping updates to ranger admin fail when the mapping is already existed in ranger DB

/ranger/biz/XUserMgr.java Lines 589 (patched) <https://reviews.apache.org/r/62555/#comment262822> Small nitpick here, there are 2 spaces after "groupname =" - Alejandro Fernandez On Sept. 26, 2017, 8:35 p.m., Sailaja

Re: Review Request 62519: RANGER-1800: Usersync fails to update users and groups during incremental sync with nested groups and group first search enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62519/#review186316 --- Ship it! Ship It! - Alejandro Fernandez On Sept. 22, 2017

Re: Review Request 62436: RANGER-1779 : last resource gets duplicated during update policy if policy is created through public api rest call

/ranger/patch/PatchForNifiResourceUpdateExclude_J10010.java Lines 43 (patched) <https://reviews.apache.org/r/62436/#comment262770> Please add some Javadoc for what this class does. - Alejandro Fernandez On Sept. 26, 2017, 4:27 p.m., Nikhil P

Re: Review Request 62024: RANGER-1756: Handle role related restrictions for users having User role.

/ranger/rest/XUserREST.java Line 358 (original), 367 (patched) <https://reviews.apache.org/r/62024/#comment262769> Nitpick here, but should have a space before and after = sign. Same in line 353 and 382 - Alejandro Fernandez On Sept. 25, 2017, 5:05 a.m., Nitin Galave

Re: Review Request 62398: From the ease of use point of view, Select / Deselect All and other checkbox should be associated in add/edit permissions pop window.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62398/#review186292 --- Ship it! Ship It! - Alejandro Fernandez On Sept. 21, 2017

Re: Review Request 62490: Updated masking policy for hive to support for deny/allowException/denyExceptions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62490/#review186290 --- Ship it! Ship It! - Alejandro Fernandez On Sept. 26, 2017

Re: Review Request 62555: RANGER-1801: group user mapping updates to ranger admin fail when the mapping is already existed in ranger DB

check using StringUtils.isNotBlank instead of just null? security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java Line 86 (original), 86 (patched) <https://reviews.apache.org/r/62555/#comment262635> Can remove unnecessary var. - Alejandro Fernandez On Sept. 26, 2017, 1

[jira] [Updated] (RANGER-1780) Allow AuditSummaryQueue to aggregate events in the same directory

[ https://issues.apache.org/jira/browse/RANGER-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alejandro Fernandez updated RANGER-1780: Description: AuditSummaryQueue already has logic to enable the summarization

[jira] [Updated] (RANGER-1780) Allow AuditSummaryQueue to aggregate events in the same directory

[ https://issues.apache.org/jira/browse/RANGER-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alejandro Fernandez updated RANGER-1780: Attachment: ranger_summary.png > Allow AuditSummaryQueue to aggregate eve

[jira] [Updated] (RANGER-1780) Allow AuditSummaryQueue to aggregate events in the same directory

[ https://issues.apache.org/jira/browse/RANGER-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alejandro Fernandez updated RANGER-1780: Description: AuditSummaryQueue already has logic to enable the summarization

[jira] [Updated] (RANGER-1780) Allow AuditSummaryQueue to aggregate events in the same directory

[ https://issues.apache.org/jira/browse/RANGER-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alejandro Fernandez updated RANGER-1780: Summary: Allow AuditSummaryQueue to aggregate events in the same directory

[jira] [Created] (RANGER-1780) Optimize Audit Logging by Aggregating/Skipping similar AuthzAuditEvents

Alejandro Fernandez created RANGER-1780: --- Summary: Optimize Audit Logging by Aggregating/Skipping similar AuthzAuditEvents Key: RANGER-1780 URL: https://issues.apache.org/jira/browse/RANGER-1780