Done.
Welcome to the Sentry community Haley.
On Thu, Jan 3, 2019 at 4:32 PM Haley Reeve
wrote:
> Forgot my id: hreeve
>
> On Thu, Jan 3, 2019 at 10:45 AM Haley Reeve wrote:
>
> > Hello,
> >
> > I've recently begun working on Sentry and would like to be added as a
> > contributor so I can pick
------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69620/#review211584
---
On Dec. 21, 2018, 5:39 p.m., Sergio Pena wrote:
>
> -
I just added you as a contributor.
Welcome to the community.
On Fri, Dec 21, 2018 at 10:04 AM Tristan Stevens
wrote:
> Hi,
> I’ve been working on https://issues.apache.org/jira/browse/SENTRY-2482.
> Please could I be added to the JIRA project so that I can assign the JIRA
> to myself (or can som
Diff: https://reviews.apache.org/r/69620/diff/1/
Testing
---
Thanks,
Sergio Pena
e the original hiveAuthzBinding
> > binding = hiveAuthzBinding;
> > }
> > =======
>
> Sergio Pena wrote:
> I'm not sure about it. The cache binding is generated on every filter
&
mproved to allow this.
- Sergio
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69586/#review211470
---
On Dec. 20, 2018, 3:45 p.
s here?
- Sergio
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69586/#review211469
---
On Dec. 20, 2018, 3:45 p.m., Sergio Pena wrote:
---------
On Dec. 20, 2018, 3:45 p.m., Sergio Pena wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69586/
>
/common/Subject.java
bcd1fa2351f7e7928f5499aa5f86906640f62504
Diff: https://reviews.apache.org/r/69586/diff/3/
Changes: https://reviews.apache.org/r/69586/diff/2-3/
Testing
---
Added unit tests for the SentryMetaStoreFilterHook.
Thanks,
Sergio Pena
Diff: https://reviews.apache.org/r/69586/diff/2/
Changes: https://reviews.apache.org/r/69586/diff/1-2/
Testing
---
Added unit tests for the SentryMetaStoreFilterHook.
Thanks,
Sergio Pena
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69586/#review211412
---
On Dec. 18, 2018, 7:28 p.m., Sergio Pena wrote:
>
> -
SentryMetaStoreFilterHook.
Thanks,
Sergio Pena
Congrats Na Li!
- Sergio
On Fri, Dec 14, 2018 at 2:17 AM Alex Kolbasov wrote:
> We have a new Apache Sentry PMC member - Na Li - Congratulations!
>
> - Alex Kolbasov
>
Hey team, the Sentry project is part of the git-wip.
Do we want to move sooner and or later?
- Sergio
-- Forwarded message -
From: Daniel Gruno
Date: Fri, Dec 7, 2018 at 10:53 AM
Subject: [NOTICE] Mandatory relocation of Apache git repositories on
git-wip-us.apache.org
To: us...@
better to pass
the snapshotID as parameter instead? You can get the snapshotID once from the
...Core() method.
- Sergio Pena
On Dec. 11, 2018, 8:16 p.m., Arjun Mishra wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69087/#review211191
---
Ship it!
Ship It!
- Sergio Pena
On Nov. 29, 2018, 10:14 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69352/#review26
---
Ship it!
Ship It!
- Sergio Pena
On Dec. 7, 2018, 3:14 p.m
> On Dec. 6, 2018, 4:13 p.m., Sergio Pena wrote:
> > sentry-service/sentry-service-api/src/main/resources/sentry_policy_service.thrift
> > Line 298 (original), 298 (patched)
> > <https://reviews.apache.org/r/69352/diff/3/?file=2112272#file2112272line298>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69484/#review22
---
Ship it!
Ship It!
- Sergio Pena
On Dec. 6, 2018, 9:19 p.m
essor too would be helpful.
- Sergio Pena
On Nov. 15, 2018, 9:06 p.m., kalyan kumar kalvagadda wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
nal), 1332 (patched)
<https://reviews.apache.org/r/69352/#comment296013>
request.getAuthorizables() may return a null value as this is optional in
thrift.
- Sergio Pena
On Dec. 5, 2018, 11:23 p.m., kalyan kumar kalvagadda wrote:
>
> ---
> This
<https://reviews.apache.org/r/69484/#comment296006>
Isn't it better to run resourcePath.toUri().toString() once and keep the
value in a string before starting the tests? It is more readable + the string
is not being generated every time
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69285/#review211003
---
Ship it!
Ship It!
- Sergio Pena
On Nov. 19, 2018, 4:32 p.m
reviews.apache.org/r/69415/
> ---
>
> (Updated Nov. 30, 2018, 5:21 p.m.)
>
>
> Review request for sentry, Haley Reeve, kalyan kumar kalvagadda, Na Li, and
> Sergio Pena.
>
>
> Bugs: SENTRY-2463
> https:/
econds?).
- Sergio Pena
On Nov. 26, 2018, 7:36 p.m., Arjun Mishra wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69448/
>
/e2e/dbprovider/TestConcurrentClients.java
2da6c6b8231ff2e59c302c1ecc857f852d7a28ee
Diff: https://reviews.apache.org/r/69349/diff/1/
Testing
---
Thanks,
Sergio Pena
18b62652a11dfee6683cb8f24944ccd3d344dc9f
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryWebServerWithKerberos.java
5d94d4bc6a2a47189e69556a5e4d9bdee05952a7
Diff: https://reviews.apache.org/r/69212/diff/2/
Testing
---
Thanks,
Sergio
s://reviews.apache.org/r/69212/#review210262
-------
On Oct. 30, 2018, 2:16 a.m., Sergio Pena wrote:
>
> ---
> This is an automatically generated e-mail.
5d94d4bc6a2a47189e69556a5e4d9bdee05952a7
Diff: https://reviews.apache.org/r/69212/diff/2/
Changes: https://reviews.apache.org/r/69212/diff/1-2/
Testing
---
Thanks,
Sergio Pena
- Sergio
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69212/#review210253
---
On Oct. 30, 2018, 2:16 a.m., S
Lines 3327 (patched)
<https://reviews.apache.org/r/69087/#comment294886>
Why can't the MPath used here?
- Sergio Pena
On Oct. 31, 2018, 11:28 p.m., kalyan kumar kalvagadda wrote:
>
> ---
> This is an automatically
odel/package.jdo
Lines 303-311 (patched)
<https://reviews.apache.org/r/69087/#comment294878>
There are weird characters at the end of these lines.
- Sergio Pena
On Oct. 31, 2018, 11:28 p.m., kalyan kumar kalvagadda wrote:
>
> --
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69201/#review210172
---
Ship it!
Ship It!
- Sergio Pena
On Oct. 29, 2018, 4:45 p.m
://reviews.apache.org/r/69212/diff/1/
Testing
---
Thanks,
Sergio Pena
a> [image: Cloudera
> on LinkedIn] <https://www.linkedin.com/company/cloudera>
> --
>
>
> On Fri, Oct 26, 2018 at 3:25 PM Sergio Pena
> wrote:
>
> > Thanks Kalyan.
> >
> > I don't think we need the hadoop jars to be deployed to Sentry as it uses
> &
> [image:
> Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: Cloudera
> on LinkedIn] <https://www.linkedin.com/company/cloudera>
> --
>
>
> On Fri, Oct 26, 2018 at 12:23 PM Sergio Pena
> wrote:
>
> >
> >
>
oop jars are they?
>
> > On Oct 26, 2018, at 9:43 AM, Sergio Pena
> wrote:
> >
> > I see several hadoop jars in the final Sentry package.
> >
> > Do we really need those jars be available in the final Sentry .tar.gz?
> > Should we exclude them?
> >
> > - Sergio
>
>
I see several hadoop jars in the final Sentry package.
Do we really need those jars be available in the final Sentry .tar.gz?
Should we exclude them?
- Sergio
: https://reviews.apache.org/r/68926/diff/5/
Changes: https://reviews.apache.org/r/68926/diff/4-5/
Testing
---
Thanks,
Sergio Pena
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68926/#review209866
-------
On Oct. 20, 2018, 7:06 p.m., Sergio Pena wrote:
>
>
service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
Lines 5106-5112 (patched)
<https://reviews.apache.org/r/68973/#comment294482>
How often does this code get ID conflicts while persisting in a threaded
process? Isn't this going to make the
/sentry/api/service/thrift/TestSentryPolicyStoreProcessor.java
16ff79e2e4258c20a46ffcf162872b5b20d97aba
Diff: https://reviews.apache.org/r/68926/diff/4/
Changes: https://reviews.apache.org/r/68926/diff/3-4/
Testing
---
Thanks,
Sergio Pena
-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryPolicyStoreProcessor.java
16ff79e2e4258c20a46ffcf162872b5b20d97aba
Diff: https://reviews.apache.org/r/68926/diff/3/
Changes: https://reviews.apache.org/r/68926/diff/2-3/
Testing
---
Thanks,
Sergio
and may slow the
fetch process as there is one message per task executed. There can be thousands
or even millions of tasks (one per databse, one per table, one per 100
partitions).
Is there another way to print a progress instead of two messages per task?
- Sergio Pena
On Oct. 18, 2018, 9:29
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69074/#review209759
---
Ship it!
Ship It!
- Sergio Pena
On Oct. 18, 2018, 8:24 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69030/#review209718
---
Ship it!
Ship It!
- Sergio Pena
On Oct. 16, 2018, 4:17 p.m
progress message in a method?
The code has two parts with the same duplicatd message and math calculations.
- Sergio Pena
On Oct. 16, 2018, 9:55 p.m., Arjun Mishra wrote:
>
> ---
> This is an automatically generated e-mail. To rep
vice/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
Lines 3463 (patched)
<https://reviews.apache.org/r/68958/#comment294164>
Agree, the timestamp is already part of the log message, so this is just
duplicating a value.
- Sergio P
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68918/#review209363
---
Ship it!
Looks good
- Sergio Pena
On Oct. 3, 2018, 8:24 p.m
t help users to understand what objects are being persisted.
- Sergio Pena
On Oct. 8, 2018, 10:16 p.m., Arjun Mishra wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68958/
>
s called
when a cache is not valid.
- Sergio Pena
On Oct. 5, 2018, 7:11 p.m., Arjun Mishra wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
25f94fa05b05abf8c1dbc33e97e5e88ae01794e4
Diff: https://reviews.apache.org/r/68926/diff/2/
Changes: https://reviews.apache.org/r/68926/diff/1-2/
Testing
---
Thanks,
Sergio Pena
/1/
Testing
---
Thanks,
Sergio Pena
reviews.apache.org/r/68547/#comment293521>
Why do we need the sequence# and image# here? Those are already checked in
the DbUpdateForward class. I think the cache invalidation here should be done
by looking at the current snapshot ID on the SentryStore and comparing it with
the one st
Hi Guang,
There are no plans or discussions yet about supporting partitions in
Sentry. I noticed that Hive/HMS has this support in its original
authorization support, so perhaps it would be good to add it in Sentry as
well.
I look forward to seeing this contribution to Sentry.
- Sergio
On Mon, O
Wooo!, Thanks Lina
On Tue, Oct 2, 2018 at 11:01 AM Alexander Kolbasov
wrote:
> Fantastic! Thank you Lina for doing the release!
>
> > On Oct 2, 2018, at 08:57, Na Li wrote:
> >
> > The Apache Sentry team is happy to announce the release of version 2.1.0.
> > Apache Sentry is a system to enforce
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68779/#review209149
---
Ship it!
Ship It!
- Sergio Pena
On Oct. 1, 2018, 9:23 p.m
> On Sept. 28, 2018, 4:56 p.m., Sergio Pena wrote:
> > What if NN does not request full images anymore? How can the cache be
> > released from memory to avoid unused cache for the rest of the process life?
>
> Arjun Mishra wrote:
> Sergio, the cache is releases as
if they're cache, then it returns the
ones from the cache.
- Sergio Pena
On Sept. 27, 2018, 10:29 p.m., Arjun Mishra wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
t;
> > Sorry, I did not list it in previous email.
> >
> > Thanks,
> >
> > Lina
> >
> > On Thu, Sep 27, 2018 at 9:20 AM Sergio Pena
> > wrote:
> >
> >> Lina, where are the .tar.gz packages for 2.1.0 located?
> >>
> >>
?
2. Could you run a benchmark with and without this patch to see the improvement
in numbers?
- Sergio Pena
On Sept. 24, 2018, 10:28 p.m., kalyan kumar kalvagadda wrote:
>
> ---
> This is an automatically generated e-mail. To re
Lina, where are the .tar.gz packages for 2.1.0 located?
- Sergio
On Tue, Sep 25, 2018 at 1:24 PM Na Li wrote:
> This is the release of Apache Sentry, version 2.1.0.
> It fixes the following issues:
>
> https://issues.apache.org/jira/projects/SENTRY/versions/12342213
>
>
> Maven artifacts are av
this new API?
- Sergio Pena
On Sept. 23, 2018, 8:52 p.m., Hao Hao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java
Lines 891 (patched)
<https://reviews.apache.org/r/68822/#comment293212>
shouldn't be principalName?
- Sergio Pena
On Sept. 23
gs. I think this logic should go there instead of
> > SentryPolicyStoreProcessor.
>
> Sergio Pena wrote:
> I agree, but then we'll need to have the configuration in all the
> bindings. Hive, Impala (and next SparkSQL) will need this configuration
> otherwise they will
589acbed12855ff09309a04c9214f8daf87ea1de
Diff: https://reviews.apache.org/r/68823/diff/1/
Testing
---
Thanks,
Sergio Pena
--------
On Sept. 21, 2018, 2:24 p.m., Sergio Pena wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68788/
> --
788/diff/2/
Changes: https://reviews.apache.org/r/68788/diff/1-2/
Testing
---
Unit tests added.
Thanks,
Sergio Pena
> On Sept. 20, 2018, 2:20 p.m., Sergio Pena wrote:
> > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java
> > Lines 725 (patched)
> > <https://reviews.apache.org/r/68779/diff/1/?file=2090407#file2090407line725>
Testing
---
Unit tests added.
Thanks,
Sergio Pena
the if() condition you also call
!isPartitionLocatedWithinTableLocation(), then that should make the rest of the
code work without too many changes.
- Sergio Pena
On Sept. 17, 2018, 3:07 p.m., kalyan kumar kalvagadda wrote:
>
> -
;
Aren't we running this test case in other parts of this class? Seems
redundant to test that the ALTER TABLE fails with a table that does not exist.
I prefer to see different methods for each test case you're trying to
validate instead of putting several into
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68753/#review208775
---
Ship it!
Ship It!
- Sergio Pena
On Sept. 18, 2018, 9:45 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68716/#review208706
---
Ship it!
Ship It!
- Sergio Pena
On Sept. 14, 2018, 1:22 p.m
'Preparing for 2.2.0-SNAPSHOT
release'
- Sergio Pena
On Sept. 14, 2018, 6:56 p.m., Na Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
Thanks Lina
On Fri, Sep 14, 2018 at 12:14 PM Na Li wrote:
> Hi,
>
> Branch-2.1.0 is available at
> https://github.com/apache/sentry/commits/branch-2.1.0. You can commit
> changes to https://github.com/apache/sentry now.
>
> Thanks,
>
> Lina
>
> On Thu, Sep 13, 2018 at 1:55 PM, Na Li wrote:
>
>
e working too.
- Sergio
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68689/#review208559
---
On Sept. 11, 2018, 8:5
/diff/2/
Changes: https://reviews.apache.org/r/68689/diff/1-2/
Testing
---
Thanks,
Sergio Pena
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68689/#review208525
---
On Sept. 11, 2018, 5:08 p.m., Sergio Pena wrote:
>
> -
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryUpgradeOrder.java
PRE-CREATION
Diff: https://reviews.apache.org/r/68689/diff/1/
Testing
---
Thanks,
Sergio Pena
ze.
- Sergio
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68669/#review208452
---
On Sept. 7, 2018, 5:01 p.m., Sergio Pena wrot
Analyze uses CREATEVIEW which the only way to know
it as an ALTERVIEW_AS was by setting the boolean value in the preAnalyze.
- Sergio Pena
On Sept. 7, 2018, 5:01 p.m., Sergio Pena wrote:
>
> ---
> This is an automatically gener
42971d846f9344282f434b9cb720c7c74c592135
Diff: https://reviews.apache.org/r/68669/diff/1/
Testing
---
Thanks,
Sergio Pena
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68661/#review208449
---
Ship it!
Ship It!
- Sergio Pena
On Sept. 6, 2018, 10:02 p.m
lly generated e-mail. To reply, visit:
https://reviews.apache.org/r/68657/#review208414
-------
On Sept. 6, 2018, 2:57 p.m., Sergio Pena wrote:
>
> ---
> This is an aut
/SentryPolicyStoreProcessor.java
008a48efc0b1a2a8703a301c85cf0068dd171f38
Diff: https://reviews.apache.org/r/68657/diff/1/
Testing
---
Thanks,
Sergio Pena
nt option",
> > what happens?
Done, I added the new tests. They were no errors.
- Sergio
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68624/#review208362
-
: https://reviews.apache.org/r/68624/diff/2/
Changes: https://reviews.apache.org/r/68624/diff/1-2/
Testing
---
Thanks,
Sergio Pena
t;
> >
> > if action is ALL or ACTION_ALL, SHOULD you continue? Before calling
> > this function, if the action to grant is all, and all is already granted,
> > we can do nothing
>
> Sergio Pena wrote:
> No. This part of the code drops the privileges before
is is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68624/#review208323
---
On Sept. 4, 2018, 7:02 p.m., Sergio Pena wrote:
>
> --
wrote:
> >
> >> Sergio,
> >>
> >> We could add profiles for to multiple version of Hive till the point we
> >> want to support multiple versions. We should also consider supporting
> >> Hadoop-3 as well.
> >> We could take similar approach t
-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
6b732ea5a89dafd94a6a3ae9c423747118352d84
Diff: https://reviews.apache.org/r/68624/diff/1/
Testing
---
Thanks,
Sergio Pena
sentry-tests/sentry-tests-hive/pom.xml
a167e76ba11692351e1150c13efbf48f25530cad
Diff: https://reviews.apache.org/r/68623/diff/1/
Testing
---
Thanks,
Sergio Pena
Hi All,
The new feature that adds owner privileges to Hive databases and tables is
finally done (see SENTRY-2151). Now that we have more improvements and
fixes, I think is time to start planning the next Sentry release 2.1.0.
- Sergio
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68585/#review208198
---
Ship it!
Ship It!
- Sergio Pena
On Aug. 31, 2018, 3:32 p.m
Done.
Welcome to the Sentry community.
- Sergio
On Fri, Aug 31, 2018 at 10:46 AM Morio Ramdenbourg
wrote:
> Hi,
>
>
> My Apache username is *mramdenbourg.* Could I have contributor access to
> the Sentry project?
>
>
> Thanks,
>
> Morio Ramdenbourg
>
Hi All,
I'd like to discuss how we can start integrating Apache Hive 3.x and future
4.x into our Sentry versions. I've noticed that Hive has released two
versions of 3.x this year (3.0 on May/18, 3.1 on Jul/18), and the current
version development is 4.0.
Currently, Sentry supports only the Hive
c835292790dbc31b164dc1668c860a3f58aeda6b
sentry-tests/sentry-tests-hive/pom.xml
c753acf31580d9ff553da35076a523552b54b244
Diff: https://reviews.apache.org/r/68487/diff/2/
Changes: https://reviews.apache.org/r/68487/diff/1-2/
Testing
---
Thanks,
Sergio Pena
03bc57453922d99c45f8e2bca8bdb532a6115170
sentry-tests/sentry-tests-solr/pom.xml
cc0969aebadb69e08f830a5a97d95962a3258da3
Diff: https://reviews.apache.org/r/68487/diff/1/
Testing
---
Thanks,
Sergio Pena
> On Aug. 21, 2018, 7:52 p.m., Sergio Pena wrote:
> > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java
> > Lines 265-268 (original), 265-268 (patched)
> > <https://reviews.apache.org/r/68
1 - 100 of 678 matches
Mail list logo
