Re: Review Request 69620: SENTRY-2483: Implement HMS PreReadEvent support in MetastoreAuthzBinding

> On Dec. 31, 2018, 4:48 a.m., Na Li wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > > Lines 284 (patched) > > > > > > I don't think

Review Request 69620: SENTRY-2483: Implement HMS PreReadEvent support in MetastoreAuthzBinding

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69620/ --- Review request for sentry and Na Li. Bugs: sentry-2483 https://issues.apach

Re: Review Request 69586: SENTRY-2481: Filter HMS server-side objects based on HMS user authorization

> On Dec. 20, 2018, 6:07 p.m., Arjun Mishra wrote: > > Sergio I don't see the binding instantiated with privilege cache. Can you > > please implement it? It really speeds up performance. Thoughts? > > > > ==

Re: Review Request 69586: SENTRY-2481: Filter HMS server-side objects based on HMS user authorization

> On Dec. 20, 2018, 6:12 p.m., Arjun Mishra wrote: > > Sergio, seems like we are authorizing one database or one table at a time > > and then adding it to the list of filtered entities. Can we authorize them > > collectively in a single transacation? This would be a good idea to improve, but t

Re: Review Request 69586: SENTRY-2481: Filter HMS server-side objects based on HMS user authorization

> On Dec. 20, 2018, 6:07 p.m., Arjun Mishra wrote: > > Sergio I don't see the binding instantiated with privilege cache. Can you > > please implement it? It really speeds up performance. Thoughts? > > > > ==

Re: Review Request 69586: SENTRY-2481: Filter HMS server-side objects based on HMS user authorization

> On Dec. 20, 2018, 6:06 p.m., Arjun Mishra wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/MetastoreAuthzObjectFilter.java > > Lines 184 (patched) > > > > > > We shou

Re: Review Request 69586: SENTRY-2481: Filter HMS server-side objects based on HMS user authorization

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69586/ --- (Updated Dec. 20, 2018, 3:45 p.m.) Review request for sentry, Arjun Mishra, kal

Re: Review Request 69586: SENTRY-2481: Filter HMS server-side objects based on HMS user authorization

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69586/ --- (Updated Dec. 19, 2018, 3:24 p.m.) Review request for sentry, Arjun Mishra, kal

Re: Review Request 69586: SENTRY-2481: Filter HMS server-side objects based on HMS user authorization

> On Dec. 18, 2018, 7:52 p.m., Na Li wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryValidator.java > > Lines 67 (patched) > > > > > > If the object is not

Review Request 69586: SENTRY-2481: Filter HMS server-side objects based on HMS user authorization

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69586/ --- Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li. Bu

Re: Review Request 69530: SENTRY-2476: Optimize deleting specific paths for objects

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69530/#review211208 --- Besides the questions below, I have extra feedback about: - add co

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review211191 --- Ship it! Ship It! - Sergio Pena On Nov. 29, 2018, 10:14 p.m.

Re: Review Request 69352: SENTRY-2452: Change the thrift interface to send the list of authorizable to sentry server

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69352/#review26 --- Ship it! Ship It! - Sergio Pena On Dec. 7, 2018, 3:14 p.m.,

Re: Review Request 69352: SENTRY-2452: Change the thrift interface to send the list of authorizable to sentry server

> On Dec. 6, 2018, 4:13 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-api/src/main/resources/sentry_policy_service.thrift > > Line 298 (original), 298 (patched) > > > > > > Are you making this incompatib

Re: Review Request 69484: SENTRY-2460: Export sentry permission information to HDFS location

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69484/#review22 --- Ship it! Ship It! - Sergio Pena On Dec. 6, 2018, 9:19 p.m.,

Re: Review Request 69353: SENTRY-2454: Add new sentrys tore api to gather the privileges for a list of authorizables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69353/#review211096 --- I'd like to see the part of the SentryPolicyStoreProcessor with th

Re: Review Request 69352: SENTRY-2452: Change the thrift interface to send the list of authorizable to sentry server

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69352/#review211095 --- sentry-service/sentry-service-api/src/main/java/org/apache/sentry

Re: Review Request 69484: SENTRY-2460: Export sentry permission information to HDFS location

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69484/#review211094 --- sentry-binding/sentry-binding-hive-common/src/main/java/org/apach

Re: Review Request 69285: Signal Handle Unregister

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69285/#review211003 --- Ship it! Ship It! - Sergio Pena On Nov. 19, 2018, 4:32 p.m.,

Re: Review Request 69415: SENTRY-2463: Revoking ALL or * should revoke any other privilege on the entity

> On Nov. 30, 2018, 5:46 p.m., kalyan kumar kalvagadda wrote: > > I understand there is a gap here but we should be carefull in changing the > > current behavior.I assume, the idea here is to find a way to remove all the > > privileges granted to an authrozable(server/database/table) > > > > U

Re: Review Request 69448: SENTRY-2464: Catch exception thrown on first reload for UpdatableCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69448/#review210902 --- Fix it, then Ship it! It looks good, just add to the warning me

Review Request 69349: SENTRY-2457: Reuse connection objects on TestConcurrentClients#testConcurrentHS2Client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69349/ --- Review request for sentry and Arjun Mishra. Bugs: semtry-2457 https://issue

Re: Review Request 69212: SENTRY-2329: Integrate sentry with Hadoop 3.1.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69212/ --- (Updated Nov. 5, 2018, 8 p.m.) Review request for sentry and kalyan kumar kalva

Re: Review Request 69212: SENTRY-2329: Integrate sentry with Hadoop 3.1.1

> On Nov. 1, 2018, 9:26 p.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/PathsUpdate.java > > Line 143 (original) > > > > > > why do you remove it? Is it impossible to throw

Re: Review Request 69212: SENTRY-2329: Integrate sentry with Hadoop 3.1.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69212/ --- (Updated Nov. 2, 2018, 6:40 p.m.) Review request for sentry and kalyan kumar ka

Re: Review Request 69212: SENTRY-2329: Integrate sentry with Hadoop 3.1.1

> On Nov. 1, 2018, 1:39 p.m., kalyan kumar kalvagadda wrote: > > pom.xml > > Lines 216-231 (patched) > > > > > > I think hadoop-minicluster can be made a test only dependency as it is > > used only for testing by ch

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review210254 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review210252 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 69201: SENTRY-2436 Add annotations for classes that are used in binding as public

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69201/#review210172 --- Ship it! Ship It! - Sergio Pena On Oct. 29, 2018, 4:45 p.m.,

Review Request 69212: SENTRY-2329: Integrate sentry with Hadoop 3.1.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69212/ --- Review request for sentry and kalyan kumar kalvagadda. Bugs: sentry-2329 ht

Re: Review Request 68926: SENTRY-2372: SentryStore should not implement grantOptionCheck

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68926/ --- (Updated Oct. 22, 2018, 7:16 p.m.) Review request for sentry and kalyan kumar k

Re: Review Request 68926: SENTRY-2372: SentryStore should not implement grantOptionCheck

> On Oct. 22, 2018, 3:40 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > > Lines 356 (patched) > > > > > > is it possib

Re: Review Request 68973: SENTRY-2305: Optimize time taken for persistence HMS snapshot by persisting in parallel

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68973/#review209865 --- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/se

Re: Review Request 68926: SENTRY-2372: SentryStore should not implement grantOptionCheck

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68926/ --- (Updated Oct. 20, 2018, 7:06 p.m.) Review request for sentry and kalyan kumar k

Re: Review Request 68926: SENTRY-2372: SentryStore should not implement grantOptionCheck

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68926/ --- (Updated Oct. 20, 2018, 1:58 a.m.) Review request for sentry and kalyan kumar k

Re: Review Request 69076: SENTRY-2301: Log where sentry stands in the snapshot fetching process, periodically

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69076/#review209797 --- I did a quick look and I feel this logging will be too verbose and

Re: Review Request 69074: SENTRY-2429: Transfer database owner drops table owner

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69074/#review209759 --- Ship it! Ship It! - Sergio Pena On Oct. 18, 2018, 8:24 p.m.,

Re: Review Request 69030: SENTRY-2427: Use Hadoop KerberosName class to derive shortName

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69030/#review209718 --- Ship it! Ship It! - Sergio Pena On Oct. 16, 2018, 4:17 p.m.,

Re: Review Request 68958: SENTRY-2419: Log where sentry stands in the process of persisting the snpashot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68958/#review209701 --- Ship it! Looks good. Just one quick fix, can you put the progre

Re: Review Request 68958: SENTRY-2419: Log where sentry stands in the process of persisting the snpashot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68958/#review209627 --- Could you test this log message and paste the real messages here?

Re: Review Request 68918: SENTRY-2423: Increase the allocation size for auto-increment of id's for Snapshot tables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68918/#review209363 --- Ship it! Looks good - Sergio Pena On Oct. 3, 2018, 8:24 p.m.

Re: Review Request 68958: SENTRY-2419: Log where sentry stands in the process of persisting the snpashot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68958/#review209360 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 68547: SENTRY-2370: Create a cache of PathUpdates to send to NN

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68547/#review209315 --- Did you look at the Guava cache? Read this part of using soft val

Re: Review Request 68926: SENTRY-2372: SentryStore should not implement grantOptionCheck

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68926/ --- (Updated Oct. 5, 2018, 2:23 p.m.) Review request for sentry and kalyan kumar ka

Review Request 68926: SENTRY-2372: SentryStore should not implement grantOptionCheck

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68926/ --- Review request for sentry and kalyan kumar kalvagadda. Bugs: SENTRY-2372 ht

Re: Review Request 68547: SENTRY-2370: Create a cache of PathUpdates to send to NN

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68547/#review209184 --- The same PathImageRetriever feedback applies to PermissionImageRet

Re: Review Request 68779: SENTRY-2409: ALTER TABLE SET OWNER does not allow to change the table if using only the table name

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68779/#review209149 --- Ship it! Ship It! - Sergio Pena On Oct. 1, 2018, 9:23 p.m.,

Re: Review Request 68547: SENTRY-2370: Create a cache of PathUpdates to send to NN

> On Sept. 28, 2018, 4:56 p.m., Sergio Pena wrote: > > What if NN does not request full images anymore? How can the cache be > > released from memory to avoid unused cache for the rest of the process life? > > Arjun Mishra wrote: > Sergio, the cache is releases as soon as Deltas are being s

Re: Review Request 68547: SENTRY-2370: Create a cache of PathUpdates to send to NN

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68547/#review209098 --- What if NN does not request full images anymore? How can the cache

Re: Review Request 68727: SENTRY-2306: Reduce the HMS snapshot size by ignoring partitions at default locations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68727/#review209067 --- Changes look good. But I'd like to know two things before approvin

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68822/#review208950 --- Btw, are you going to have another JIRA for the client to call thi

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68822/#review208947 --- Fix it, then Ship it! It looks good. Just change the entityNam

Re: Review Request 68788: SENTRY-2413: Provide a configuration option to permit specific DB privileges to be granted explicitly

> On Sept. 21, 2018, 5:18 p.m., kalyan kumar kalvagadda wrote: > > Sergio, > > > > Sentry server is policy store and does not need to understand the > > action.Let's keep it that way. Logic of validiting the actions is present > > in the sentry bindings. I think this logic should go there inst

Review Request 68823: SENTRY-2416: FullUpdateInitializer metrics are not reset for each new HMS snapshot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68823/ --- Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li. Bu

Re: Review Request 68788: SENTRY-2413: Provide a configuration option to permit specific DB privileges to be granted explicitly

> On Sept. 21, 2018, 5:18 p.m., kalyan kumar kalvagadda wrote: > > Sergio, > > > > Sentry server is policy store and does not need to understand the > > action.Let's keep it that way. Logic of validiting the actions is present > > in the sentry bindings. I think this logic should go there inst

Re: Review Request 68788: SENTRY-2413: Provide a configuration option to permit specific DB privileges to be granted explicitly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68788/ --- (Updated Sept. 21, 2018, 2:24 p.m.) Review request for sentry. Bugs: sentry-2

Re: Review Request 68779: SENTRY-2409: ALTER TABLE SET OWNER does not allow to change the table if using only the table name

> On Sept. 20, 2018, 2:20 p.m., Sergio Pena wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java > > Lines 725 (patched) > > > > > > This line fails

Review Request 68788: SENTRY-2413: Provide a configuration option to permit specific DB privileges to be granted explicitly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68788/ --- Review request for sentry. Bugs: sentry-2413 https://issues.apache.org/jira

Re: Review Request 68727: SENTRY-2306: Reduce the HMS snapshot size by ignoring partitions at default locations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68727/#review208797 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 68779: SENTRY-2409: ALTER TABLE SET OWNER does not allow to change the table if using only the table name

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68779/#review208796 --- sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentr

Re: Review Request 68753: SENTRY-2407: SentrySchemaInfo and SQL scripts do not have the new 2.2.0 version

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68753/#review208775 --- Ship it! Ship It! - Sergio Pena On Sept. 18, 2018, 9:45 p.m.

Re: Review Request 68716: SENTRY-2403: Incorrect naming in RollingFileWithoutDeleteAppender

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68716/#review208706 --- Ship it! Ship It! - Sergio Pena On Sept. 14, 2018, 1:22 p.m.

Re: Review Request 68721: SENTRY-2388: Update the pom file in master branch after release 2.1.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68721/#review208635 --- Ship it! Looks good, can you just update the title to be 'Prepa

Re: Review Request 68689: SENTRY-2398: Support multiple target versions on single source versions during schema upgrades

> On Sept. 12, 2018, 1:57 p.m., kalyan kumar kalvagadda wrote: > > I'm reviewing the code. Just thinking if this logic can be simplified. I > > will put more comments later today. What's wrong with my logic? The code works, all test cases are working too. - Sergio --

Re: Review Request 68689: SENTRY-2398: Support multiple target versions on single source versions during schema upgrades

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68689/ --- (Updated Sept. 11, 2018, 8:56 p.m.) Review request for sentry and kalyan kumar

Re: Review Request 68689: SENTRY-2398: Support multiple target versions on single source versions during schema upgrades

> On Sept. 11, 2018, 8:22 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryUpgradeOrder.java > > Lines 31 (patched) > > > > > > Can y

Review Request 68689: SENTRY-2398: Support multiple target versions on single source versions during schema upgrades

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68689/ --- Review request for sentry and kalyan kumar kalvagadda. Bugs: sentry-2398 ht

Re: Review Request 68669: SENTRY-2395: ALTER VIEW AS SELECT is asking for CREATE privileges instead of ALTER

> On Sept. 7, 2018, 5:51 p.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > > Lines 152 (patched) > > > > > > I don't

Re: Review Request 68669: SENTRY-2395: ALTER VIEW AS SELECT is asking for CREATE privileges instead of ALTER

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68669/#review208458 --- sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentr

Review Request 68669: SENTRY-2395: ALTER VIEW AS SELECT is asking for CREATE privileges instead of ALTER

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68669/ --- Review request for sentry. Bugs: SENTRY-2395 https://issues.apache.org/jira

Re: Review Request 68661: SENTRY-2394: Fixed typo in sentry-site.xml.service.template

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68661/#review208449 --- Ship it! Ship It! - Sergio Pena On Sept. 6, 2018, 10:02 p.m.

Re: Review Request 68657: SENTRY-2392: Add metrics statistics to list_user_privileges and list_role_privileges API

> On Sept. 6, 2018, 5:56 p.m., Steve Moist wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > > Line 1397 (original), 1397 (patched) > >

Review Request 68657: SENTRY-2392: Add metrics statistics to list_user_privileges and list_role_privileges API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68657/ --- Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li. Bu

Re: Review Request 68624: SENTRY-2315: The grant all operation is not dropping the create/alter/drop/index/lock privileges.

> On Sept. 5, 2018, 4:28 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > > Lines 927 (patched) > > > > > > Can you add

Re: Review Request 68624: SENTRY-2315: The grant all operation is not dropping the create/alter/drop/index/lock privileges.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68624/ --- (Updated Sept. 5, 2018, 4:57 p.m.) Review request for sentry, Arjun Mishra, kal

Re: Review Request 68624: SENTRY-2315: The grant all operation is not dropping the create/alter/drop/index/lock privileges.

> On Sept. 4, 2018, 9:49 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 866 (patched) > > > > > > if action is AL

Re: Review Request 68624: SENTRY-2315: The grant all operation is not dropping the create/alter/drop/index/lock privileges.

> On Sept. 4, 2018, 9:49 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Line 818 (original), 818 (patched) > > > > > >

Review Request 68624: SENTRY-2315: The grant all operation is not dropping the create/alter/drop/index/lock privileges.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68624/ --- Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li. Bu

Review Request 68623: SENTRY-2376: Bump Jackson libraries versions to 1.9.13 and 2.9.6

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68623/ --- Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li. Bu

Re: Review Request 68585: SENTRY-2374: Add dependencies for Lombok development assistance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68585/#review208198 --- Ship it! Ship It! - Sergio Pena On Aug. 31, 2018, 3:32 p.m.,

Re: Review Request 68487: SENTRY-2366: Exclude jackson transitive dependencies

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68487/ --- (Updated Aug. 23, 2018, 7:20 p.m.) Review request for sentry, Arjun Mishra, kal

Review Request 68487: SENTRY-2366: Exclude jackson transitive dependencies

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68487/ --- Review request for sentry. Bugs: sentry-2366 https://issues.apache.org/jira

Re: Review Request 68444: SENTRY-2318: Sentry listener should log the failure if grant/revoke of owner privilege fails

> On Aug. 21, 2018, 7:52 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java > > Lines 265-268 (original), 265-268 (patched) > >

Re: Review Request 68456: SENTRY-2360: Update the pom file in 2.0 branch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68456/#review207738 --- Ship it! Ship It! - Sergio Pena On Aug. 21, 2018, 9:33 p.m.,

Re: Review Request 68444: SENTRY-2318: Sentry listener should log the failure if grant/revoke of owner privilege fails

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68444/#review207688 --- sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentr

Re: Review Request 68433: SENTRY-2356: Sentry Server should provide API for Sentry Client to get Owner Privilege Type

> On Aug. 21, 2018, 1:34 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-api/src/main/resources/sentry_policy_service.thrift > > Lines 469-470 (patched) > > > > > > I think we should make a generic call to

Re: Review Request 68433: SENTRY-2356: Sentry Server should provide API for Sentry Client to get Owner Privilege Type

> On Aug. 21, 2018, 1:34 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-api/src/main/resources/sentry_policy_service.thrift > > Lines 469-470 (patched) > > > > > > I think we should make a generic call to

Re: Review Request 68433: SENTRY-2356: Sentry Server should provide API for Sentry Client to get Owner Privilege Type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68433/#review207660 --- sentry-service/sentry-service-api/src/main/resources/sentry_polic

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/#review207532 --- Ship it! Ship It! - Sergio Pena On Aug. 17, 2018, 7:01 p.m.,

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

> On Aug. 17, 2018, 3:01 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > > Lines 244 (patched) > > > > >

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/#review207496 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 68394: SENTRY-2355: Merge the DB owner privileges configurations into one enum configuration

> On Aug. 17, 2018, 4:57 a.m., Na Li wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java > > Line 890 (original), 894 (patched) > > > > > > should you

Re: Review Request 68394: SENTRY-2355: Merge the DB owner privileges configurations into one enum configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68394/ --- (Updated Aug. 17, 2018, 2:47 p.m.) Review request for sentry, Arjun Mishra, kal

Review Request 68394: SENTRY-2355: Merge the DB owner privileges configurations into one enum configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68394/ --- Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li. Bu

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/#review207430 --- What's the expected performance improvement we're getting with thi

Re: Review Request 68367: SENTRY-2354: Beeline error message only shows first required permission that failed access check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68367/#review207428 --- sentry-binding/sentry-binding-hive-common/src/main/java/org/apach

Re: Review Request 67888: SENTRY-2308: Create privilege on table has no use case

> On Aug. 8, 2018, 8:07 p.m., Na Li wrote: > > can you add test case for this change? The new patch has a new test case for this. - Sergio --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6788

Re: Review Request 67888: SENTRY-2308: Create privilege on table has no use case

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67888/ --- (Updated Aug. 16, 2018, 4:18 p.m.) Review request for sentry and Arjun Mishra.

Re: Review Request 68332: SENTRY-2352: User roles with ALTER on a table can not show or describe the table on which they have ALTER

> On Aug. 13, 2018, 11:25 p.m., Na Li wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBindingHookBase.java > > Line 104 (original), 104 (patched) > > > > > >

Review Request 68332: SENTRY-2352: User roles with ALTER on a table can not show or describe the table on which they have ALTER

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68332/ --- Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li. Bu

  1   2   3   4   >