---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1179/
---
(Updated 2011-08-12 19:02:33.931983)
Review request for shindig.
Changes
On 2011-08-02 11:05:39, Paul Lindner wrote:
been trying to apply this patch but I'm seeing endtoend tests fail.. just
me?
Just got back from vacation, I'm still building fine after updating. I did
need to build clean first though.
Can you try again?
- Dan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1179/#review1322
---
still failing for me..
Looks like the shindig and opensocial vars
On 2011-08-08 18:38:40, Paul Lindner wrote:
still failing for me..
Looks like the shindig and opensocial vars are not coming as part of the js
payload.
perhaps closure is stripping that out?
Not sure...
shindig.closure.compile.level=simple
That should be setting it to
/2011 14:53
Subject:Re: Review Request: Enable closure compiler by default
On 2011-08-08 18:38:40, Paul Lindner wrote:
still failing for me..
Looks like the shindig and opensocial vars are not coming as part of
the js payload.
perhaps closure is stripping that out
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1179/
---
(Updated 2011-08-08 19:53:10.247898)
Review request for shindig.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1179/#review1327
---
Still seeing this with latest patch... weird:
Tests run: 30,
,
Date: 08/08/2011 16:31
Subject:Re: Review Request: Enable closure compiler by default
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1179/#review1327
/IBM@Lotus, Paul Lindner lind...@inuus.com
Date: 08/08/2011 05:16 PM
Subject:Re: Review Request: Enable closure compiler by default
I'm going to chalk this up to a timing issue (or other weird issue) when
running the tests. I can build on two different machines, both updated to
Trunk
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1179/#review1264
---
been trying to apply this patch but I'm seeing endtoend tests fail..
I'm seeing this as well. I'll look into this today.
From: Paul Lindner lind...@inuus.com
To: shindig dev@shindig.apache.org, Dan Dumont/Westford/IBM@Lotus,
Paul Lindner lind...@inuus.com,
Date: 08/02/2011 07:05
Subject:Re: Review Request: Enable closure compiler by default
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1179/#review1269
---
Looks pretty good to me, w/ the caveat that Shindig's default JDK
On 2011-08-02 20:06:10, johnfargo wrote:
Looks pretty good to me, w/ the caveat that Shindig's default JDK still is
1.5 :|
Were you able to compile it without any test failures?
Paul and Stanton both said they had end-to-end test failures after applying the
patch. I had no errors
Re: testing, I haven't done so -- just commenting on the code alone. Re:
var, removing it probably fixes our issue. I'm checking it out ;)
On Tue, Aug 2, 2011 at 1:38 PM, Dan Dumont ddum...@us.ibm.com wrote:
On 2011-08-02 20:06:10, johnfargo wrote:
Looks pretty good to me, w/ the caveat
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1179/
---
(Updated 2011-07-26 14:11:17.099192)
Review request for shindig.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1179/#review1178
---
almost there!
On 2011-07-22 02:20:04, Paul Lindner wrote:
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/globals/globals.js,
line 23
https://reviews.apache.org/r/1179/diff/1/?file=26756#file26756line23
curious why you removed the var...
I was being
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1179/
---
Review request for shindig.
Summary
---
Enable closure with simple
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1179/#review1164
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1179/#review1165
---
Some initial nits -- please consult with fargo about this...
- Paul
20 matches
Mail list logo
