[jira] [Commented] (STORM-1526) Improve Storm core performance

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135629#comment-15135629 ] ASF GitHub Bot commented on STORM-1526: --- Github user abhishekagarwal87 commented on

[GitHub] storm pull request: STORM-1526 Improve Storm core performance

2016-02-05 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1080#discussion_r52098435 --- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj --- @@ -58,7 +58,7 @@ (.prepare grouping context (GlobalStreamId. component-

[jira] [Commented] (STORM-1516) Topology workers are not getting killed when a topology is killed.

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135618#comment-15135618 ] ASF GitHub Bot commented on STORM-1516: --- Github user arunmahadevan commented on the

[GitHub] storm pull request: STORM-1516 Fixed issue in writing pids with di...

2016-02-05 Thread arunmahadevan
Github user arunmahadevan commented on the pull request: https://github.com/apache/storm/pull/1084#issuecomment-180695960 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52098122 --- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj --- @@ -42,7 +42,9 @@ (:require [metrics.gauges :refer [defgauge]]) (:requi

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135608#comment-15135608 ] ASF GitHub Bot commented on STORM-1336: --- Github user jerrypeng commented on a diff i

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135610#comment-15135610 ] ASF GitHub Bot commented on STORM-1336: --- Github user jerrypeng commented on a diff i

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52098115 --- Diff: conf/defaults.yaml --- @@ -281,3 +281,16 @@ pacemaker.thread.timeout: 10 pacemaker.childopts: "-Xmx1024m" pacemaker.auth.method: "NONE"

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135603#comment-15135603 ] ASF GitHub Bot commented on STORM-1336: --- Github user jerrypeng commented on a diff i

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52098093 --- Diff: storm-core/test/clj/org/apache/storm/supervisor_test.clj --- @@ -335,8 +334,8 @@ mock-storm-id

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52098096 --- Diff: storm-core/test/clj/org/apache/storm/supervisor_test.clj --- @@ -362,8 +361,8 @@ mock-storm-id

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135604#comment-15135604 ] ASF GitHub Bot commented on STORM-1336: --- Github user jerrypeng commented on a diff i

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135599#comment-15135599 ] ASF GitHub Bot commented on STORM-1336: --- Github user jerrypeng commented on a diff i

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52098065 --- Diff: storm-core/src/jvm/org/apache/storm/container/cgroup/SystemOperation.java --- @@ -0,0 +1,65 @@ +/** + * Licensed to the Apache Software Fo

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135597#comment-15135597 ] ASF GitHub Bot commented on STORM-1336: --- Github user jerrypeng commented on a diff i

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52098057 --- Diff: storm-core/src/jvm/org/apache/storm/container/cgroup/SystemOperation.java --- @@ -0,0 +1,65 @@ +/** + * Licensed to the Apache Software Fo

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52098040 --- Diff: storm-core/src/jvm/org/apache/storm/container/cgroup/SubSystem.java --- @@ -0,0 +1,78 @@ +/** + * Licensed to the Apache Software Foundati

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135596#comment-15135596 ] ASF GitHub Bot commented on STORM-1336: --- Github user jerrypeng commented on a diff i

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52097950 --- Diff: storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCommon.java --- @@ -0,0 +1,226 @@ +/** + * Licensed to the Apache Software Foun

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135593#comment-15135593 ] ASF GitHub Bot commented on STORM-1336: --- Github user jerrypeng commented on a diff i

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52097932 --- Diff: storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java --- @@ -0,0 +1,232 @@ +/** + * Licensed to the Apache Software Foun

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135592#comment-15135592 ] ASF GitHub Bot commented on STORM-1336: --- Github user jerrypeng commented on a diff i

[jira] [Commented] (STORM-1515) LocalState corruption after hard reboot on Windows

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135280#comment-15135280 ] ASF GitHub Bot commented on STORM-1515: --- Github user frison commented on the pull re

[GitHub] storm pull request: STORM-1515: Reset LocalState if corrupted afte...

2016-02-05 Thread frison
Github user frison commented on the pull request: https://github.com/apache/storm/pull/1067#issuecomment-180625941 I see no way that CI failed because of this commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52084693 --- Diff: storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupOperation.java --- @@ -0,0 +1,46 @@ +/** + * Licensed to the Apache Software Fo

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135210#comment-15135210 ] ASF GitHub Bot commented on STORM-1336: --- Github user jerrypeng commented on a diff i

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135198#comment-15135198 ] ASF GitHub Bot commented on STORM-1336: --- Github user d2r commented on a diff in the

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52083925 --- Diff: storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java --- @@ -0,0 +1,232 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135196#comment-15135196 ] ASF GitHub Bot commented on STORM-1336: --- Github user jerrypeng commented on a diff i

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52083814 --- Diff: storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupUtils.java --- @@ -0,0 +1,133 @@ +/** + * Licensed to the Apache Software Found

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135193#comment-15135193 ] ASF GitHub Bot commented on STORM-1336: --- Github user jerrypeng commented on a diff i

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135195#comment-15135195 ] ASF GitHub Bot commented on STORM-1336: --- Github user d2r commented on a diff in the

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52083786 --- Diff: storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupUtils.java --- @@ -0,0 +1,133 @@ +/** + * Licensed to the Apache Software Found

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52083808 --- Diff: storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java --- @@ -0,0 +1,232 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135180#comment-15135180 ] ASF GitHub Bot commented on STORM-1336: --- Github user jerrypeng commented on a diff i

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52082924 --- Diff: storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupUtils.java --- @@ -0,0 +1,133 @@ +/** + * Licensed to the Apache Software Found

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135171#comment-15135171 ] ASF GitHub Bot commented on STORM-1336: --- Github user jerrypeng commented on a diff i

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52082237 --- Diff: storm-core/src/jvm/org/apache/storm/container/cgroup/Constants.java --- @@ -0,0 +1,30 @@ +/** + * Licensed to the Apache Software Foundati

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52079760 --- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj --- @@ -301,7 +303,9 @@ (try (rmpath (ConfigUtils/workerPidPa

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135130#comment-15135130 ] ASF GitHub Bot commented on STORM-1336: --- Github user jerrypeng commented on a diff i

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135124#comment-15135124 ] ASF GitHub Bot commented on STORM-1336: --- Github user knusbaum commented on a diff in

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135122#comment-15135122 ] ASF GitHub Bot commented on STORM-1336: --- Github user knusbaum commented on a diff in

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52079318 --- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java --- @@ -1367,12 +1367,67 @@ public static int toPositive(int number) { return numb

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52079277 --- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java --- @@ -1367,12 +1367,67 @@ public static int toPositive(int number) { return numb

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135101#comment-15135101 ] ASF GitHub Bot commented on STORM-1336: --- Github user kishorvpatil commented on the p

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/1053#issuecomment-180583768 Secondly, I don't necessarily like the idea of `ResourceIsolationInterface` taking up responsibility for starting and stopping workers.. This would be moving a lot

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135065#comment-15135065 ] ASF GitHub Bot commented on STORM-1336: --- Github user kishorvpatil commented on the p

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/1053#issuecomment-180571721 The proposed changes are launching commands using `exec.command` which may not work in multi-tenant setup ( for killing workers etc.). It will not work in multi-ten

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135057#comment-15135057 ] ASF GitHub Bot commented on STORM-1336: --- Github user jerrypeng commented on a diff i

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52076438 --- Diff: storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupUtils.java --- @@ -0,0 +1,133 @@ +/** + * Licensed to the Apache Software Found

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52075801 --- Diff: storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupUtils.java --- @@ -0,0 +1,133 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135049#comment-15135049 ] ASF GitHub Bot commented on STORM-1336: --- Github user d2r commented on a diff in the

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135044#comment-15135044 ] ASF GitHub Bot commented on STORM-1336: --- Github user d2r commented on a diff in the

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52075387 --- Diff: storm-core/src/jvm/org/apache/storm/container/cgroup/Hierarchy.java --- @@ -0,0 +1,117 @@ +/** + * Licensed to the Apache Software Foundation (A

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135038#comment-15135038 ] ASF GitHub Bot commented on STORM-1336: --- Github user jerrypeng commented on a diff i

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52075177 --- Diff: storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java --- @@ -0,0 +1,232 @@ +/** + * Licensed to the Apache Software Foun

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135027#comment-15135027 ] ASF GitHub Bot commented on STORM-1336: --- Github user d2r commented on a diff in the

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52074621 --- Diff: storm-core/src/jvm/org/apache/storm/container/cgroup/SubSystemType.java --- @@ -0,0 +1,58 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135025#comment-15135025 ] ASF GitHub Bot commented on STORM-1336: --- Github user d2r commented on a diff in the

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52074497 --- Diff: storm-core/src/jvm/org/apache/storm/container/cgroup/SubSystemType.java --- @@ -0,0 +1,58 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135013#comment-15135013 ] ASF GitHub Bot commented on STORM-1336: --- Github user d2r commented on a diff in the

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52073695 --- Diff: storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java --- @@ -0,0 +1,232 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135001#comment-15135001 ] ASF GitHub Bot commented on STORM-1336: --- Github user jerrypeng commented on a diff i

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52073012 --- Diff: storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java --- @@ -0,0 +1,232 @@ +/** + * Licensed to the Apache Software Foun

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134999#comment-15134999 ] ASF GitHub Bot commented on STORM-1336: --- Github user jerrypeng commented on a diff i

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52072956 --- Diff: storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java --- @@ -0,0 +1,232 @@ +/** + * Licensed to the Apache Software Foun

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134996#comment-15134996 ] ASF GitHub Bot commented on STORM-1336: --- Github user d2r commented on a diff in the

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134997#comment-15134997 ] ASF GitHub Bot commented on STORM-1336: --- Github user jerrypeng commented on a diff i

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52072760 --- Diff: conf/defaults.yaml --- @@ -281,3 +281,16 @@ pacemaker.thread.timeout: 10 pacemaker.childopts: "-Xmx1024m" pacemaker.auth.method: "NONE" pa

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52072773 --- Diff: storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java --- @@ -0,0 +1,232 @@ +/** + * Licensed to the Apache Software Foun

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134989#comment-15134989 ] ASF GitHub Bot commented on STORM-1336: --- Github user d2r commented on a diff in the

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52072424 --- Diff: storm-core/src/jvm/org/apache/storm/Config.java --- @@ -2155,6 +2156,63 @@ @isString public static final Object CLIENT_JAR_TRANSFORMER

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134981#comment-15134981 ] ASF GitHub Bot commented on STORM-1336: --- Github user d2r commented on a diff in the

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52072165 --- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj --- @@ -1178,7 +1212,7 @@ (FileUtils/copyDirectory (File. (.getFile url)) (File.

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134980#comment-15134980 ] ASF GitHub Bot commented on STORM-1336: --- Github user jerrypeng commented on a diff i

[jira] [Commented] (STORM-828) HdfsBolt takes a lot of configuration, need good defaults

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134978#comment-15134978 ] ASF GitHub Bot commented on STORM-828: -- Github user dossett commented on the pull requ

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52072010 --- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj --- @@ -344,6 +348,12 @@ :sync-retry (atom 0) :download-lock (Object.)

[GitHub] storm pull request: STORM-828 HdfsBolt takes a lot of configuratio...

2016-02-05 Thread dossett
Github user dossett commented on the pull request: https://github.com/apache/storm/pull/668#issuecomment-180552919 @redsanket Are you still working on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (STORM-602) HdfsBolt dies when the hadoop node is not available

2016-02-05 Thread Aaron Dossett (JIRA)
[ https://issues.apache.org/jira/browse/STORM-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134975#comment-15134975 ] Aaron Dossett commented on STORM-602: - If nobody objects, I will close this ticket as "

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134970#comment-15134970 ] ASF GitHub Bot commented on STORM-1336: --- Github user d2r commented on a diff in the

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52071474 --- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj --- @@ -1088,8 +1104,26 @@ (str "file:///" st

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52070982 --- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj --- @@ -1062,9 +1072,15 @@ (add-to-classpath [stormjar])

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134955#comment-15134955 ] ASF GitHub Bot commented on STORM-1336: --- Github user d2r commented on a diff in the

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134957#comment-15134957 ] ASF GitHub Bot commented on STORM-1336: --- Github user d2r commented on a diff in the

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52070908 --- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj --- @@ -1062,9 +1072,15 @@ (add-to-classpath [stormjar])

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134943#comment-15134943 ] ASF GitHub Bot commented on STORM-1336: --- Github user d2r commented on a diff in the

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52070018 --- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj --- @@ -381,7 +391,7 @@ (:storm-id assignment) port

[jira] [Commented] (STORM-1528) Fix CsvPreparableReporter log directory

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134940#comment-15134940 ] ASF GitHub Bot commented on STORM-1528: --- Github user d2r commented on the pull reque

[GitHub] storm pull request: [STORM-1528] Fixing MetricsUtils csv directory...

2016-02-05 Thread d2r
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/1085#issuecomment-180547552 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[GitHub] storm pull request: [STORM-1528] Fixing MetricsUtils csv directory...

2016-02-05 Thread kishorvpatil
GitHub user kishorvpatil opened a pull request: https://github.com/apache/storm/pull/1085 [STORM-1528] Fixing MetricsUtils csv directory location I was calling `ConfigUtils.absoluteHealthCheckDir` instead of `ConfigUtils.absoluteStormLocalDir`. I need to be more careful.. You can m

[jira] [Commented] (STORM-1528) Fix CsvPreparableReporter log directory

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134936#comment-15134936 ] ASF GitHub Bot commented on STORM-1528: --- GitHub user kishorvpatil opened a pull requ

[jira] [Created] (STORM-1528) Fix CsvPreparableReporter log directory

2016-02-05 Thread Kishor Patil (JIRA)
Kishor Patil created STORM-1528: --- Summary: Fix CsvPreparableReporter log directory Key: STORM-1528 URL: https://issues.apache.org/jira/browse/STORM-1528 Project: Apache Storm Issue Type: Bug

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134930#comment-15134930 ] ASF GitHub Bot commented on STORM-1336: --- Github user d2r commented on a diff in the

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52069255 --- Diff: storm-core/src/jvm/org/apache/storm/container/ResourceIsolationInterface.java --- @@ -0,0 +1,43 @@ +/** + * Licensed to the Apache Software Fou

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134934#comment-15134934 ] ASF GitHub Bot commented on STORM-1336: --- Github user d2r commented on a diff in the

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52069182 --- Diff: storm-core/src/jvm/org/apache/storm/container/ResourceIsolationInterface.java --- @@ -0,0 +1,43 @@ +/** + * Licensed to the Apache Software Fou

[jira] [Resolved] (STORM-1524) Make Storm daemon function statistics reporter pluggable

2016-02-05 Thread Kishor Patil (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kishor Patil resolved STORM-1524. - Resolution: Fixed Fix Version/s: 1.0.0 > Make Storm daemon function statistics reporter plu

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134917#comment-15134917 ] ASF GitHub Bot commented on STORM-1336: --- Github user d2r commented on a diff in the

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52068522 --- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj --- @@ -42,7 +42,9 @@ (:require [metrics.gauges :refer [defgauge]]) (:require [me

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-05 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52068474 --- Diff: conf/cgconfig.conf.example --- @@ -0,0 +1,41 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor licens

  1   2   3   >