Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2798
@HeartSaVioR heres the master port -
https://github.com/apache/storm/pull/2801
I guess sooner we release 2.0 and stick to master branch for even minor
feature development the better.
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2801
STORM-3184: Mask the plaintext passwords from the logs
Introduce a `Password` config annotation and use it to mark configs that are
sensitive and mask the values while logging.
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2798
@HeartSaVioR , i had a quick look and its not straightforward to port this
patch to master. The Configs are now split into Config and DaemonConfig and
quite a lot of refactoring has happened. I
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2798
ping @arunmahadevan
---
Github user govind-menon commented on the issue:
https://github.com/apache/storm/pull/2799
@HeartSaVioR Fixed the component page.
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209381686
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4716,4 +4744,206 @@ public IScheduler getForcedScheduler() {
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2764
cachedSummary shouldn't be refreshed too often based on current
implementation. So I don't think we should risk the race condition just for
negligible gain in performance.
---
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209367723
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4716,4 +4744,206 @@ public IScheduler getForcedScheduler() {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209367613
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4716,4 +4744,206 @@ public IScheduler getForcedScheduler() {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209367421
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4716,4 +4744,206 @@ public IScheduler getForcedScheduler() {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209367121
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4716,4 +4744,206 @@ public IScheduler getForcedScheduler() {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209366165
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4716,4 +4744,206 @@ public IScheduler getForcedScheduler() {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209365696
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4716,4 +4744,206 @@ public IScheduler getForcedScheduler() {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209363589
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4716,4 +4744,206 @@ public IScheduler getForcedScheduler() {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209354005
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4716,4 +4744,206 @@ public IScheduler getForcedScheduler() {
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2764
What do you think @srdo
---
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2764
Added clarifications to ClusterSummaryMetricSet
---
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209348428
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4716,4 +4745,194 @@ public IScheduler getForcedScheduler() {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209341987
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2865,16 +2890,14 @@ public void launchServer() throws Exception {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209337293
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4716,4 +4746,186 @@ public IScheduler getForcedScheduler() {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209336348
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2905,6 +2929,10 @@ public void launchServer() throws Exception {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209335050
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2905,6 +2929,10 @@ public void launchServer() throws Exception {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209333494
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2905,6 +2929,10 @@ public void launchServer() throws Exception {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209333088
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4716,4 +4746,186 @@ public IScheduler getForcedScheduler() {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209331742
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4716,4 +4746,186 @@ public IScheduler getForcedScheduler() {
GitHub user zd-project opened a pull request:
https://github.com/apache/storm/pull/2800
STORM-3162: Fix concurrent modification bug
See: https://issues.apache.org/jira/browse/STORM-3162
I managed to alter the Java implementation and it seems to be passing
storm-server test.
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2789
sure. Take your time please.
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2754
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2789
Once the two PRs with new metrics are merged, I'll try to update the
non-static branch and get a PR opened. It might take me a little while.
---
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2789
That's right. Will take a look at non-static registry after #2764 and #2764
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2789
Before spending too long on it, consider if we should fix this issue and
https://github.com/apache/storm/pull/2714 by making the metrics registry
non-static instead (https://github.com/apache/storm/pull
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2754
+1. Please squash and we can merge.
---
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2789
Tested it manually on a single-node cluster. `nimbus:num-shutdown-calls`
was flushed now with this patch. Still need to figure out travis build failure
before merging this in.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2764
I'd like https://github.com/apache/storm/pull/2754 to go in first, so we're
sure the review from there is reflected here. When that one is merged, I'd like
to take another look at these changes.
---
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209315575
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1984,11 +2052,12 @@ private int fragmentedCpu() {
Clu
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2764
All nits addressed?
---
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209312212
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4723,4 +4754,192 @@ public IScheduler getForcedScheduler() {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209311621
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4729,4 +4760,192 @@ public IScheduler getForcedScheduler() {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209311727
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2826,21 +2882,27 @@ public void launchServer() throws Exception {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209311534
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1984,11 +2052,12 @@ private int fragmentedCpu() {
Cluster c
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209311426
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4652,4 +4745,192 @@ public IScheduler getForcedScheduler() {
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2754
All nits should have been addressed as of now.
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209306763
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4652,4 +4745,192 @@ public IScheduler getForcedScheduler() {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209305519
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -142,30 +154,41 @@ public void run() {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209305125
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4652,4 +4745,192 @@ public IScheduler getForcedScheduler() {
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2789
I am also getting `
org.apache.maven.surefire.booter.SurefireBooterForkException: Error occurred in
starting fork, check output in log` on my VM. And the tests passed without this
patch. Still need
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209304885
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4652,4 +4745,192 @@ public IScheduler getForcedScheduler() {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209304694
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -142,30 +154,41 @@ public void run() {
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2789#discussion_r209274375
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -96,4 +99,10 @@ public static void startMetricsReporters(Map to
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2789#discussion_r209269207
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/metrics/reporters/ConsolePreparableReporter.java
---
@@ -18,16 +18,12 @@
import java.util.
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2789#discussion_r209274273
--- Diff:
storm-server/src/main/java/org/apache/storm/pacemaker/Pacemaker.java ---
@@ -49,7 +49,7 @@ public Pacemaker(Map conf) {
heartbeats = n
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2789#discussion_r209301643
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Supervisor.java
---
@@ -316,7 +317,7 @@ public void launchDaemon() {
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2789#discussion_r209271682
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/metrics/reporters/JmxPreparableReporter.java
---
@@ -22,9 +22,9 @@
import org.slf4j.Logger
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209303917
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/webapp/LogviewerResource.java
---
@@ -255,8 +302,16 @@ public Response deepSearch(@PathP
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209303203
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4652,4 +4745,192 @@ public IScheduler getForcedScheduler() {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209302512
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4729,4 +4760,192 @@ public IScheduler getForcedScheduler() {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209301707
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -142,30 +154,41 @@ public void run() {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209301358
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -223,8 +246,8 @@ void cleanupEmptyTopoDirectory(File
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209299849
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogPageHandler.java
---
@@ -61,18 +63,21 @@
import org.apach
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209298650
--- Diff:
storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandlerTest.java
---
@@ -627,6 +627,7 @@ public void tes
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209298109
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/webapp/LogviewerResource.java
---
@@ -255,8 +302,16 @@ public Response deepSearch(
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209297840
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/webapp/LogviewerResource.java
---
@@ -255,8 +302,16 @@ public Response deepSearch(
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209296760
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -253,12 +276,11 @@ private long lastModifiedTimeWorke
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209296628
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -235,7 +258,7 @@ FileFilter mkFileFilterForLogCleanup
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2799
https://user-images.githubusercontent.com/1317309/43955215-21c167e0-9cda-11e8-818a-6bbf8b65ed5b.png";>
Looks like there is still some missed spot: could you check with this?
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2797
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2794
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2796
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2795
---
69 matches
Mail list logo
