Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1920
@HeartSaVioR done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/1933
STORM-2240: STORM PMML Bolt - Add Support to Load Models from Blob Store
- Created factory to create ModelRunner and ModelOutputs from Blobstore
- Updated example topology to support loading
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1832
@srdo I was also caught up in a couple of things. I will finish reviewing
this tonight.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1832#discussion_r100935401
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Time.java ---
@@ -42,10 +46,10 @@ public SimulatedTime() {
public SimulatedTime(Number ms
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1832#discussion_r100938344
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Time.java ---
@@ -88,59 +92,97 @@ public static boolean isSimulating() {
public static
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1832#discussion_r100937801
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Time.java ---
@@ -162,9 +204,13 @@ public static long deltaMs(long timeInMilliseconds
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1832#discussion_r100937812
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Time.java ---
@@ -162,9 +204,13 @@ public static long deltaMs(long timeInMilliseconds
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1832
+1 for all the KafkaSpout related code
+1 also for the SimulatedTime changes in the sense that the minor
refactoring of this class does not change the semantics of the pre-existing
code
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1941
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1924
@srdo Thanks for the note. I will take a look later today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/1958
STORM-2374: Storm Kafka Client Test Topologies Must be Serializable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hmcl/storm-apache
1.x
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/1959
STORM-2374: Storm Kafka Client Test Topologies Must be Serializable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hmcl/storm-apache
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1959
@revans2 yes, I knew what was the problem. However, it's very strong and
dangerous (as for backwards compatibility) to enforce base types (e.g
interfaces) to implement `java.io.Serializable`.
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1959
@revans2 done. @ptgoetz this should be ready to merge. There is also a PR
for 1.x-branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1958
@revans2 done. @ptgoetz this should be ready to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1924
@srdo is this patch still relevant in face of the other patches that got
merged in ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1924
@srdo what you mean is that if `numUncommittedOffsets > max
UncommittedOffsets` the Spout should still emit the retries, but not poll new
records. Is that it ?
---
If your project is set up for
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1924#discussion_r103353882
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -329,11 +328,13 @@ private Builder(Builder
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1924#discussion_r103352827
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -268,12 +268,11 @@ private Builder(Builder
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1977
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1924
@srdo apologies for a little delay. Had a lot of deadlines for last week. I
will finish reviewing this today.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/1995
STORM-2407: KafkaTridentSpoutOpaque Doesn't Poll Data From All Topic-â¦
â¦Partitions When Parallelism Hint Not a Multiple Total Topic-Partitions
- Introduce logic to poll data fro
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1993
@sakanaou I am just about to commit a fix that gives the option to emit or
not emit null tuples as configured in `KafkaSpoutConfig`. The case of non
processable records is already supported if you
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/1999
STORM-2409: Storm-Kafka-Client KafkaSpout Support for Failed and NullTuples
- Created config property to make emit null tuples configurable
- Ack directly null tuples that are not emitted
You
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1924
@HeartSaVioR @srdo reviewing this right now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1924
@srdo I am reading through your detailed explanation again and will let you
know my opinion concerning the need, or no need, for the parameter
`maxUncommittedOffsets`, based on all the facts you state
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/2007
Logger output Pattern for Integration-Tests/cluster.xml Matching
log42/cluster.xml
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hmcl/storm
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2007
Please backport to 1.x-branch as well. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1999#discussion_r106280062
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -383,23 +403,24 @@ private void
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1999
@srdo the changes proposed in this PR handle null tuples in identical
fashion that what is done in the old Kafka Spout as can be seen in the
following links.
https://github.com/apache/storm
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1999#discussion_r106291741
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -383,23 +403,24 @@ private void
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1999
@srdo we can make de default emit null. That's a trivial change. As I said,
I decided not to emit null because that is the default behavior in the old
spout, and users are either happy, or used
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1999#discussion_r106299675
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -383,23 +403,24 @@ private void
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1999
@srdo so what will we decide to do as far as null? send or not send by
default ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/2008
STORM-2409: Storm-Kafka-Client KafkaSpout Support for Failed and NullTuples
- Created config property to make emit null tuples configurable
- Ack directly null tuples that are not emitted
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2009
@harshach can you please review. This is the master branch equivalent to
https://github.com/apache/storm/pull/1995
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/2009
STORM-2407: KafkaTridentSpoutOpaque Doesn't Poll Data From All Topic-â¦
â¦Partitions When Parallelism Hint Not a Multiple Total Topic-Partitions
- Introduce logic to poll data fro
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/2010
STORM-2240: STORM PMML Bolt - Add Support to Load Models from Blob Store
- Created factory to create ModelRunner and ModelOutputs from Blobstore
- Updated example topology to support loading
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1933
@satishd please find it here: https://github.com/apache/storm/pull/2010
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2010
@satishd this is the 1.x-branch equivalent to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1924#discussion_r106547911
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -270,17 +272,40 @@ public void setWaitingToEmit
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1924#discussion_r106541885
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/builders/SingleTopicKafkaSpoutConfiguration.java
---
@@ -41,31 +41,22
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1924#discussion_r106557594
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -270,17 +272,40 @@ public void setWaitingToEmit
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1924#discussion_r106559751
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -270,17 +272,40 @@ public void setWaitingToEmit
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1924#discussion_r106532445
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -404,6 +407,14 @@ private Builder(Builder
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1924#discussion_r106531182
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -268,12 +268,12 @@ private Builder(Builder
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1924#discussion_r106542400
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/builders/SingleTopicKafkaSpoutConfiguration.java
---
@@ -41,31 +41,22
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1924#discussion_r106541357
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutRetryExponentialBackoff.java
---
@@ -54,21 +55,28
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1924
@srdo @HeartSaVioR I will do the last pass on this first thing in the
morning such that we can merge this in.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1924#discussion_r107537729
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutRetryExponentialBackoff.java
---
@@ -172,19 +174,20 @@ public
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1924#discussion_r107537760
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutRetryService.java
---
@@ -54,10 +55,11 @@
boolean
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1924#discussion_r107536862
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/SingleTopicKafkaSpoutTest.java
---
@@ -266,4 +269,36 @@ public void
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1924#discussion_r107531160
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutRetryService.java
---
@@ -54,10 +55,11 @@
boolean
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1924#discussion_r107455723
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutRetryExponentialBackoff.java
---
@@ -60,17 +61,19 @@ public int
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1924#discussion_r107529960
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -273,11 +273,9 @@ public void setWaitingToEmit
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1924#discussion_r107532327
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/MaxUncommittedOffsetTest.java
---
@@ -57,10 +57,9 @@
//Current tests
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1924
+1.
@srdo I forgot to say in the last review. Can you please squash the
commits. Once that is done as I am concerned, this patch is ready to merge.
@HeartSaVioR can you please do
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/2027
STORM-2432: Storm-Kafka-Client Trident Spout Seeks Incorrect Offset With
UNCOMMITTED_LATEST Strategy
- Add check to execute first poll offset strategy only for the first
poll rather than always
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2027
This patch must be ported onto master branch as well. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2027
@satishd Done!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user hmcl closed the pull request at:
https://github.com/apache/storm/pull/2027
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2027
This PR has already been merged by @satishd on commit
38f866c64c9bb1c55109a122c8ea3dc1a3b4b09b
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user hmcl closed the pull request at:
https://github.com/apache/storm/pull/1831
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2088
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2104#discussion_r115305431
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/OffsetManager.java
---
@@ -49,10 +51,14 @@ public OffsetManager
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2104#discussion_r115317728
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/OffsetManager.java
---
@@ -113,6 +140,15 @@ public long commit
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2104#discussion_r115310456
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/OffsetManager.java
---
@@ -68,13 +74,34 @@ public OffsetAndMetadata
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2104#discussion_r115305869
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/OffsetManager.java
---
@@ -68,13 +74,34 @@ public OffsetAndMetadata
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2104#discussion_r115316343
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/OffsetManager.java
---
@@ -68,13 +74,34 @@ public OffsetAndMetadata
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2071#discussion_r115320207
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java
---
@@ -119,7 +117,12 @@ public void prepare(Map stormConf
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/2147
STORM-2538: New kafka spout emits duplicate tuples
- Refactored TimeInterval out of KafkaSpoutRetryExponentialBackoff
- Configurable pre-fetch tasks to be run before spout starts processing
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2147
This patch is WIP, needs fixing unit test failures. Submitting for initial
review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2147#discussion_r119413232
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -127,12 +132,19 @@ public void open(Map conf
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2147#discussion_r119413655
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -74,7 +79,7 @@
private transient
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2147#discussion_r119420992
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -252,14 +289,16 @@ private boolean commit
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2147#discussion_r119421886
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/TimeInterval.java
---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2147#discussion_r119421827
--- Diff:
examples/storm-kafka-examples/src/main/java/org/apache/storm/kafka/trident/KafkaProducerTopology.java
---
@@ -54,7 +54,7 @@ public static
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2147#discussion_r119423603
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -48,13 +33,33 @@
import
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2147
@srdo I agree that this is not the ideal solution, and that's precisely the
reason why the pre-fetch tasks are pluggable. There are better approaches to do
this, but this one fixes some imme
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2147#discussion_r119429199
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -252,14 +289,16 @@ private boolean commit
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2147#discussion_r119429686
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -170,10 +182,13 @@ private void initialize(Collection
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2152
@askprasanna what do you mean by "topic void" ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2151
@srdo was this agreed upon ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2159
@askprasanna Why does it have to be serializable? It seems that it has been
working until now. What changed that is enforcing this class to be serializable?
---
If your project is set up for it, you
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2156
@srdo I am reviewing this. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2169
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2159#discussion_r123357809
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutMessageId.java
---
@@ -21,7 +21,9 @@
import
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2159
+1. LGTM. As @srdo mentioned earlier, I wish there was a backwards
compatible way to enforce messageId to be serializable. The documentation is
nice and clear, but the same way it happened in here, I
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/2174
STORM-2554: Trident Kafka Spout Refactoring to Include Manual Partition
Assignment
- Support manual partition assignment with changes in STORM-2541
- Improve rebalance pause/resume logic
You
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2150#discussion_r123868726
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/TopicFilter.java
---
@@ -0,0 +1,38 @@
+/*
+ * Copyright 2017 The
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2150#discussion_r123868742
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/PatternTopicFilter.java
---
@@ -0,0 +1,59 @@
+/*
+ * Copyright 2017
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2150#discussion_r123868570
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/ManualPartitionSubscription.java
---
@@ -58,21 +51,21 @@ public
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2150#discussion_r123886463
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/PatternTopicFilter.java
---
@@ -0,0 +1,59 @@
+/*
+ * Copyright 2017
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2177#discussion_r123886555
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/NamedSubscription.java
---
@@ -56,6 +57,6 @@ public NamedSubscription(String
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2177
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2150#discussion_r124323706
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/PatternTopicFilter.java
---
@@ -0,0 +1,59 @@
+/*
+ * Copyright 2017
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2150
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2155#discussion_r124580583
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -116,217 +141,57 @@
private boolean
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2155#discussion_r124572749
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -79,16 +78,46
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2155#discussion_r124594357
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -116,217 +141,57 @@
private boolean
701 - 800 of 813 matches
Mail list logo
