Is there a reason why 'map' method in the Flow doesn't support instances of the
superclass mapper?
Current signature:
Flow map(Mapper mapper);
better:
Flow map(Mapper mapper);
otherwise you can't write super mapper like , , ...
map(numberToString) ...
Also other methods could be improve
Denis Stepanov: +1 (non-binding)
Apr 25, 2013 v 11:56 AM, Alejandro Scandroli :
> i: +1 (non-binding)
It would be nice if someone would apply the patch from
https://issues.apache.org/jira/browse/TAP5-2084 and include it in T5.3.7.
Good candidate could be https://issues.apache.org/jira/browse/TAP5-2051 reduces
memory footprint, it's already applied in 5.4.
Denis
Apr 1, 2013 v 8:12 PM, Lenny Pri
of simplifying
> stuff.
I understand, for me it's more simplistic to have a different event than
switching behaviour by an annotation.
Should be 404 raised in a case, when there are less parameters that there are
required?
Denis
Feb 14, 2013 v 12:16 PM, Thiago H de Paula Figueiredo :
I like the idea also but implementation is not perfect.
- You're using instanceof to check if context is empty, but I would say correct
way is to check the size of the context.
- Not-handled response logic should be abstract, what if someone wants a
different response code or a different behavio
Sorry, it looked like discussion is over and it will stay this way.
Denis
Jan 15, 2013 v 1:41 PM, Taha Siddiqi :
> Hi Denis
>
> You have made your point and everybody agrees with you but your tone has not
> been polite.
>
> regards
> Taha
>
> On Jan 15, 2013,
nnecessary.
>>>> There are also most likely locking going on just to get to the per thread
>>>> access to the field even before the session gets accessed.
>>>> I view is change as a performance killer as well with no benefits
>>>> whatsoever.
>>>&
Changes introduced in https://issues.apache.org/jira/browse/TAP5-2049 bring
some bad consequences.
Now, if your request accesses the session every other request will wait to
access the session until the previous request is done, it means long running
request could block all other requests, this
We have a similiar application architecture, pages with a lot of ajax
components, biggest page reloading takes ~ 5s.
Michael, make sure you don't have a debug enabled on the root logger, it could
slow things down.
System.out.println(org.slf4j.LoggerFactory.getLogger("xyz123abcRandomLogger").isD
h no warning or feedback at all. Instead, I'm trying to
> enforce one release minimum of warning before stripping them out entirely.
>
>
> On Fri, Jan 4, 2013 at 4:04 AM, Denis Stepanov
> wrote:
>
>> Looking into 5.4 code with deprecated component parameters using th
I can't remember what drove the need to cloak I think it was
> there were multiple unexpected things in the Environment, interacting
> poorly and the cloak approach was the clean way to approach the problem.
>
>
> On Fri, Jan 4, 2013 at 3:49 AM, Denis Stepanov
> wrote:
&
Looking into 5.4 code with deprecated component parameters using the
DeprecationWarning service and I have a few suggestions:
Could it be implemented by introducing a new annotation
@IgnoreDeprecatedParametersWarning({"visible", "update"}) on the component
class or using the @DeprecatedParamete
I like the concept of Environment, but Howard did broke it by introducing
cloak/decloak. You would think you could just add new environmental service in
the filter or somewhere else and assume it would be available everywhere during
rendering of the request, but it is not true, cloaking will hid
on't know whether the gain in
> functionality outweighs the
> effort. Thoughts?
>
> Cheers,
>
> Uli
>
> On 19.11.2012 12:38, Denis Stepanov wrote:
>> It looks more like a cookie writer than a builder.
>>
>> It would be better to create an interface a.p.
It looks more like a cookie writer than a builder.
It would be better to create an interface a.p.t.s.Cookie alternative to the
javax.servlet.http.Cookie so it would be possible to modify current cookie
value without using the servlet api, all setters could return Cookie instance
to support meth
It would it be better to create it under a github organization e.g. Tapestry5
or ApacheTapestry rather than a personal account.
Denis
Nov 2, 2012 v 2:56 PM, Howard Lewis Ship :
> On Fri, Nov 2, 2012 at 1:19 AM, Ulrich Stärk wrote:
>> -1.
>>
>> We didn't even have a discussion about this, let
> I thought you didn't like that? Yes, I'm doing many small modules.
Separating javascript doesn't necessary mean modules, every file contributing
into the main context e.g. jQuery
https://github.com/jquery/jquery/tree/master/src
If there will be server side modules in the future version you ca
I'm differently against SPI and all that javascript abstraction.
In my opinion, if you write javascript clean:
use coffeescript
separate different functionality into own files
no .ajax, console. wrappers use provided framework functionality
if you need to acknowledge an error throw an exception
> See notes before; the last thing I want to do is add yet more layers
> of abstraction! ClientBehaviorSupport was a mistake from the start.
>
> If you don't want something that works like ProgressiveDisplay, write
> your own. What's nice now is just how minimal it is; there's almost
> nothing l
I'm looking into current changes and I have few suggestions.
Some time ago I have rewritten the javascript part of Tapestry using
CoffeScript and pure jQuery, I would like to use it in the future with minimal
changes, to do so there should be an abstract layer between core components and
client
29, 2012 at 3:08 AM, Denis Stepanov
> wrote:
>> Bing returns the same description.
>>
>> Denis
>>
>>
>> Aug 29, 2012 v 11:27 AM, Denis Stepanov :
>>
>>> From http://support.google.com/webmasters/bin/answer.py?hl=en&answer=35624
Bing returns the same description.
Denis
Aug 29, 2012 v 11:27 AM, Denis Stepanov :
> From http://support.google.com/webmasters/bin/answer.py?hl=en&answer=35624
> page needs to have a meta description tag and http://tapestry.apache.org/
> doesn't have one.
>
>
&
From http://support.google.com/webmasters/bin/answer.py?hl=en&answer=35624 page
needs to have a meta description tag and http://tapestry.apache.org/ doesn't
have one.
Denis
Aug 28, 2012 v 2:42 PM, Denis Stepanov :
> Google "tapestry" and the first result is a ta
Denis
On 29.8.2012, at 9:16, Massimo Lusetti wrote:
> On Tue, Aug 28, 2012 at 2:42 PM, Denis Stepanov
> wrote:
>
>> Google "tapestry" and the first result is a tapestry homepage with a
>> description:
>>
>> "Organizes web applications development
Google "tapestry" and the first result is a tapestry homepage with a
description:
"Organizes web applications development into component-based framework.
Requires Servlet API 2.2 and JDK 1.2. [LGPL]"
Is that like 10 years old description?
Denis
I have just discovered that page instance could not be reloaded when there is a
request in progress. It could be simply reproduced by using ProgressiveDisplay
and Thread.sleep inside the onProgressiveDisplay event. During the event
request the page could not be modified by changing its template,
What about library's "assets" folder(org.myapp.assets), will it be supported?
Denis
Jul 22, 2012 v 8:43 PM, Howard Lewis Ship :
> Just a note on where I'm heading with the 5.4 code.
>
> In Tapestry 5.3 and earlier, classpath assets were allowed to be
> anywhere on the classpath, as long as the
I don't think 'META-INF' is the right location for all assets, its supposed to
store internal Java meta information or configuration files, web resources do
not belong there. We can just use '/assets', I would also support
{lib-path}/assets (org.apache.tapestry5.corelib.assets for core lib).
De
Denis Stepanov: +1 (non binding)
Jul 16, 2012 v 6:06 PM, Howard Lewis Ship:
> Just waiting for a 3rd binding vote ... might be time to vote in some
> new PMC members!
>
> On Mon, Jul 16, 2012 at 9:01 AM, Jochen Frey wrote:
>> Jochen frey: +1 (non binding)
>>
>> -
Denis Stepanov +1 (non-binding)
Denis
It's just not implemented, SpringModuleDef can check for @InjectService or
@ServiceId and use getBean(name, type).
Denis
Jun 29, 2012 v 4:33 PM, Igor Drobiazko:
> Can anyone remind me please why we don't support injection of Spring beans
> by id when multiple beans of the same interface are ava
Gradle's eclipse plugin doesn't include provided project dependencies, you need
to add them manualy (Java Build Path - Projects - Add tapestry-test). Plugin
also generates root eclipse project, delete ".project" in the root folder and
then you can import all projects at once.
Denis
May 11, 201
Honestly, I'm not convinced about modules, Tapestry doesn't have so much
javascript to benefit from parallel/lazy script loading suggested in the
presentation, one minified file should be faster.
I like the idea of separating tapestry.js into more files: ZoneManager,
Effects, Validation, Form
-1
Javascript onException call missing exception argument, almost impossible to
track what when wrong:
https://issues.apache.org/jira/browse/TAP5-1873
Denis
On 18.4.2012, at 8:56, Dmitry Gusev wrote:
> Kalle, thanks for your reply.
>
> As I understood from Howard's report and release notes -
mbiguation.
>
> On Thu, Mar 22, 2012 at 10:55 AM, Denis Stepanov
> wrote:
>> You didn't understand me, I have only one implementation with the @Primary,
>> the problem is when you are accesing the service without it.
>>
>> Example:
>>
>
e placed on a single
> implementation, not all of them. The most frequent use case is a service
> which is implemented as a chain or a strategy.
>
> On Thu, Mar 22, 2012 at 1:55 PM, Denis Stepanov
> wrote:
>
>> Would be possible to change the default behaviour to selec
Would be possible to change the default behaviour to select a service marked
@Primary when there are multiple occurrences of the same interface? I'm finding
that it's complicated to add a service with the same interface, I need to find
all occurrences of the interface and mark them @Primary and
Steve suggested on the mailing list the same improvement, why it doesn't count?
Denis
Mar 8, 2012 v 2:28 PM, Thiago H. de Paula Figueiredo:
> On Thu, 08 Mar 2012 09:44:50 -0300, Denis Stepanov
> wrote:
>
>> I can change it to use the @Order, but I'm not sure Tapestry d
URL: https://issues.apache.org/jira/browse/TAP5-1842
>>Project: Tapestry 5
>> Issue Type: Improvement
>> Components: tapestry-ioc
>> Reporter: Denis Stepanov
>>
>> It would be nice to have something like:
>> @Start
> Doesn't contributing to the RegistryStartup service, which has an ordered
> configuration, does exactly what's been asked here?
Yes it does, but it is a lot messier, you need an inner class, and so on.
Specialy when you are using @Startup and then you need an order.
Whole purpose of the @Star
I would like to improve @Startup annotation to support the id and the
constraints attributes, jira issue
https://issues.apache.org/jira/browse/TAP5-1842
See my implementation:
https://github.com/dstepanov/tapestry5/commit/21f90340d98e3aa778f65ca6a46767ad7662c8ff
If there is someone who thinks
Field injection could actually avoid the circular dependency problem, it
doesn't need to have all services ready for injection, constructor injection
can't avoid it so only way is to use proxies there.
Denis
Feb 16, 2012 v 10:50 PM, Thiago H. de Paula Figueiredo:
> On Thu, 16 Feb 2012 18:20:29
Hello,
Is there a way how circular dependencies of non-interface instances could be
supported by Tapestry IOC?
It seems that a service without an interface is not proxied and it leads to the
stack overflow(https://issues.apache.org/jira/browse/TAP5-1772), I know that
Hibernate can create a pro
>> Zone with an id generated randomly(ajax request) is useless
>
> It isn't (I've explained it in this thread:
> http://www.mail-archive.com/users@tapestry.apache.org/msg57958.html),
> otherwise Tapestry committers wouldn't care to implement.
You have only explained why there are random ids, I'
r holds the old instance because it holds the
> proxy which delegates to per-thread instances of MultipartDecoderImpl.
>
> On Wed, Nov 30, 2011 at 2:56 PM, Denis Stepanov
> wrote:
>
>> There is no problem with the code, problem is that it doesn't work how it
>> s
new thread.
> The consequence is that the injected MultipartDecoderImpl instance is
> autobuild for every new request.
>
> I see no problems with that code.
>
> On Wed, Nov 30, 2011 at 1:27 PM, Denis Stepanov
> wrote:
>
>> Hi,
>>
>> It seems that instan
Hi,
It seems that instance created with @Autobuild will have default scope,
perthread is not honored at all, see folowing code from Upload project:
@Scope(ScopeConstants.PERTHREAD)
public static MultipartDecoder buildMultipartDecoder(PerthreadManager
perthreadManager,
Just upgraded our app, one major issue I see is the environment cloaking change
see my post, more people could see unexpected behaviour after upgrade, well
maybe not everyone I must say our app is pretty complex.
Everything else works fine I have discovered only few minor issues there are
alrea
Hello,
5.3 adds Environment cloaking which breaks some 5.2 stuff, I would like to
consider this as a bug.
In our app I have discoverd two cases when there is a problem:
First, I have a ComponentEventRequestFilter which triggers events to a
component, if event handler add something into Environ
Hello,
Is there a right place in ordered configuration where to put
ComponentClassTransformWorker2 which adds event handlers using the
addEventHandler?
I had a trasform with a configuration:
"after:SetupRender","after:CleanupRender", "before:Parameter", "before:onEvent"
but there was some weir
Guys,
I'm kinda disappointed here, I came here with a valid issue and no one seems to
see a problem here, I don't want to fix it in my project we are already using
ifNotNull component I just want a syntax option improvement which will avoid
some behavior/performace issues.
It could pretty muc
> Definitely. I'd rather add the Object -> Boolean and appropriate other
> coercions instead of adding a feature to the property expressions.
>
> I'm adding them to my personal project now. I'll be happy to add them
> to the framework once the dust of this thread settles :)
I'm afraid it will bre
> Is there any reason for Tapestry-IoC or Tapestry-core themselves not
> providing a direct Object -> Boolean coercion?
There is, let say "address" is a Boolean then you can't check for null, because
if it is null it will return false and if it isn't could be false too.
It will not work for defa
> Or do something like user?.address?.property
Would it be better to use just "user?.address?" without contributing coercion
for every object in a project? :)
We already have ifNotNull component I'm just trying to make Tapestry better :)
Text search revealed that we have 99 matches of
> "X doesn't do what I want" is not a strong argument. In order to convince
> someone to apply the patch, you need to make more efforts to describe you
> issue. After reading all of your mails I'm still not sure what is the issue
> with existing syntax. Please explain exactly your use case. As alwa
debug purposes and can be slow.
Denis
Aug 24, 2011 v 3:39 PM, Thiago H. de Paula Figueiredo:
> On Wed, 24 Aug 2011 07:36:38 -0300, Denis Stepanov
> wrote:
>
>> I have implemented null check see:
>>
>> https://issues.apache.org/jira/browse/TAP5-1615
>>
>&
is
Aug 24, 2011 v 10:32 AM, Andreas Andreou:
> I'm away on vacations so i didn't commit any code to apache svn.
>
> But you can take a look of what's involved at
> https://github.com/andyhot/tapestry5/commits/trunk
>
> On Tue, Aug 23, 2011 at 13:44, Denis Stepano
I have implemented null check see:
https://issues.apache.org/jira/browse/TAP5-1615
can be used with propertyChain expressions: "prop?", "prop.a.b?.c?",
"method()?".
Denis
> I think a more useful extension would be the Groovy :? operator
>
> expression ?: default-value
>
> This could even be combined with the safe de-reference:
>
> foo?.bar?.baz ?: computeFooBarBaz()
Elvis operator is a nice feature to have too, but it's something different, I
just would like
ty to prevent a NPE.
Maybe even better syntax would be:
> value="prop?"
> value="prop.a.b.c?"
> value="prop?.a?.b?.c?"
Denis
Aug 23, 2011 v 1:26 PM, Igor Drobiazko:
> How does it differ from existing syntax? See the examples here:
>
> http://tapestry.
Hello,
I would like to suggest a new syntax for checking if the property expression
value is a null:
> value="?prop"
will return false if property "prop" is null or true if not
> value="?prop.a.b.c"
will return false if property "c" is null or true if not
> value="?prop?.a?.b?.c"
will ret
I would like to have a zone param support for Chechbox and RadioGroup in 5.3.
Will you manage to finish the refactoring into this version?
Denis
Aug 16, 2011 v 11:41 PM, Andreas Andreou:
> :) Your patch is ok - it's basically a copy of the Select code that
> did the same thing - but
> what i'd
> So, anyway, i'd like to provide the zone parameter to all
> AbstractField subclasses
> since i don't see the need to special-case it to a particular component
> and in fact i've gotten it to work quite nicely.
I don't think it's a good idea.
Not all form fields support zone update, TextField do
It would be better to have core components more flexible to external changes.
I'm looking into ContextMenuGridCell and I would rather see extended
PropertyOverrides and extension points concept.
For example a Grid would provide default extending point for a row:
> ..<
then PropertyOverrides c
ly offer the
>>>>> zone parameter
>>>>> to their users (this can still be the case) - it's just they will have
>>>>> implemented that through
>>>>> a mixin.
>>>>>
>>>>> The context parameter
11, at 22:30, Thiago H. de Paula Figueiredo wrote:
> On Fri, 12 Aug 2011 15:49:05 -0300, Denis Stepanov
> wrote:
>
>> I understand mixin concept and code separation but in this case I don't
>> think we need discuss so much about a few lines of code.
>
> I di
> Autocomplete is a mixin, not logic embedded inside TextField, maybe more than
> 99% used just with TextField and people still manage to find and use it. It's
> just a matter of documentation. With a promise of backward compatibility so
> important as it is to Tapestry, we always have to use th
can't be
reused for other components and tapestry users will probably look for a zone
parameter on the Checkbox component rather than studing all mixins.
Denis
On Aug 12, 2011, at 5:37 PM, Thiago H. de Paula Figueiredo wrote:
> On Fri, 12 Aug 2011 06:03:38 -0300, Denis Stepanov
> wrote:
;> Perhaps the patch should be to make select component do it as a mixin ;)
>>
>> On Thu, Aug 11, 2011 at 1:01 PM, Denis Stepanov
>> wrote:
>>>> What about a mixin instead of changing the component themselves? That's
>>>> what I'd do.
>>&g
omponent can't.
Denis
On 11.8.2011, at 21:46, Thiago H. de Paula Figueiredo wrote:
> On Thu, 11 Aug 2011 14:41:59 -0300, Denis Stepanov
> wrote:
>
>> Anyone?
>
> What about a mixin instead of changing the component themselves? That's what
> I'd do.
>
Anyone?
On 10.8.2011, at 13:40, Denis Stepanov wrote:
> https://issues.apache.org/jira/browse/TAP5-1602
>
> Someone with commit access please review the patch.
>
> Denis
>
> On Aug 8, 2011, at 11:20 AM, Denis Stepanov wrote:
>
>> Thanks, I have implemented thi
Tests failing on my mac laptop too:
> AlertsTest: com.thoughtworks.selenium.SeleniumException: window.$$ is not a
> function
> FormTests: java.lang.AssertionError: expected:<28> but was:<27>
> at
> org.apache.tapestry5.integration.app1.FormTests.datefield_select_newmonth_samedate(FormTes
https://issues.apache.org/jira/browse/TAP5-1602
Someone with commit access please review the patch.
Denis
On Aug 8, 2011, at 11:20 AM, Denis Stepanov wrote:
> Thanks, I have implemented this by using a mixin in our code.
>
> I just what to have native support for Radio and
Thanks, I have implemented this by using a mixin in our code.
I just what to have native support for Radio and Checkbox valueChaned event in
the next Tapestry version.
Denis
On Aug 8, 2011, at 10:39 AM, Михаил Слободянюк wrote:
>>
>> If you want use radio as like select try this
>> http://cod
Hi,
I would like to add support for the valueChanged event from RadioGroup and
Checkbox component just like it is in Select component, is there anyone who
thinks it should be done and eventually will accept a patch?
Denis
-
To
Hi Thiago!
Do you have a commit access? It would be nice to have these changes in the next
release, you seems to be the only one who is interested :).
Denis
On Jul 22, 2011, at 11:28 PM, Thiago H. de Paula Figueiredo wrote:
> On Wed, 20 Jul 2011 06:34:04 -0300, Denis Stepanov
>
Hi,
It would be nice if there was a way how to trigger a multi zone update on the
client side, waiting for all zone updates to render in one request could take
too long and sometimes it's better to display refreshing zones to the user.
Our simple implementation returns JS code which then trigg
Hi,
It could be LabelProvider.
ValueLabelProvider because of ValueEncoder and similiar use-case of extracting
something from a value.
Denis
On 22.7.2011, at 23:28, Thiago H. de Paula Figueiredo wrote:
> On Wed, 20 Jul 2011 06:34:04 -0300, Denis Stepanov
> wrote:
>
>> Hel
Hello all,
I have improved coercion from List to SelectModel, right now you need to create
SelectModel for Select component, but in the situation when we know how to
display an object from the list we can do it just by binding collection to the
model parameter.
There is a new interface ValueL
It seems that Howard fixed it by TAP5-1581.
Denis
On Jul 19, 2011, at 4:14 PM, Denis Stepanov wrote:
> Hi Igor,
>
> 1) Some devs are using git, so I thought it's ok.
> 2) You're right! It should be assigned after the change.
>
> Denis
>
> On Jul 19, 2011
e invocation of removeListener() method is
> currently between lines:
>
> listeners = CollectionFactory.newList(listeners);
>
> and
>
> listeners.remove(listener);
>
> Regards
>
> On Tue, Jul 19, 2011 at 11:53 AM, Denis Stepanov
> wrote:
>
>> Hi al
Hi all,
I had noticed that in MarkupWriterImpl every time when element event start/end
is fired, collection of listeners is recreated, probably to prevent CME, better
would be recreate it only when it is modified, see the issue with a patch:
https://issues.apache.org/jira/browse/TAP5-1532.
Den
I understand :), it would be nice to have the easiest way to contribute, I can
see how github is way ahead on it.
Denis
On Jul 12, 2011, at 3:19 PM, Thiago H. de Paula Figueiredo wrote:
> On Tue, 12 Jul 2011 10:14:30 -0300, Denis Stepanov
> wrote:
>
>> I can relate to your
I can relate to your feeling, I had submitted two patches one almost three
months ago and no response :) I don't feel motivated to try to contribute
anymore.
Denis
On Jul 12, 2011, at 1:25 AM, Taha Hafeez wrote:
> Somebody :)
>
> regards
> Taha
>
> On Fri, Jul 8, 2011 at 4:05 PM, Taha Hafee
Hi,
can someone please take a look at issues submited by me including patches:
https://issues.apache.org/jira/browse/TAP5-1446
https://issues.apache.org/jira/browse/TAP5-1532
Thanks,
Denis
ating with Tapestry
- UI suppor/fixes for mobile devices
What is the policy and conditions to be listed in the "Who uses Tapestry"
section?
Thanks for reply,
Denis Stepanov
Can someone please take a look at this patch.
Thanks,
Denis
On 21.4.2011, at 11:25, Denis Stepanov (JIRA) wrote:
>
>[
> https://issues.apache.org/jira/browse/TAP5-1446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022696#com
87 matches
Mail list logo
