GitHub user uint opened a pull request:
https://github.com/apache/thrift/pull/1410
Common Lisp support
This adds Common Lisp support - library, generator, cross-tests, tutorial
code, etc. Currently only SBCL is supported.
The minimal requirements are fulfilled. Cross-tests
[
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reopened THRIFT-82:
--
> Common Lisp support
> ---
>
> Key: THRIFT-82
>
[
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237622#comment-16237622
]
James E. King, III commented on THRIFT-82:
--
A pull request was submitted today imp
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1410
Some initial thoughts, before I review all of the files individually:
1. Please squash.
2. Please add [THRIFT-82] at the beginning of the commit description and
the pull request descript
[
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237624#comment-16237624
]
ASF GitHub Bot commented on THRIFT-82:
--
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1410
@jfarrell for some reason there is no recorded Travis CI build for this
pull request. When the author squashes and resubmits hopefully this will kick
off a proper build?
---
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1410#discussion_r148789088
--- Diff: compiler/cpp/src/thrift/generate/t_cl_generator.cc ---
@@ -0,0 +1,544 @@
+// Copyright (c) 2008- Patrick Collison
--- End diff --
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1410#discussion_r148791220
--- Diff: lib/cl/binary-protocol.lisp ---
@@ -0,0 +1,255 @@
+(in-package #:org.apache.thrift.implementation)
+
+ This file defines the concre
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1410#discussion_r148790488
--- Diff: lib/cl/externals/software/alexandria-20170830-git/.boring ---
@@ -0,0 +1,13 @@
+# Boring file regexps:
--- End diff --
If you chec
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1410#discussion_r148790890
--- Diff:
lib/cl/externals/software/usocket-0.7.0.1/vendor/OpenTransportUDP.lisp ---
@@ -0,0 +1,146 @@
+;;;-*-Mode: LISP; Package: CCL -*-
--- End d
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1410#discussion_r148791102
--- Diff: lib/cl/framed-transport.lisp ---
@@ -0,0 +1,136 @@
+(in-package #:org.apache.thrift.implementation)
+
+ Copyright 2017 Rigetti Comp
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1410#discussion_r148790161
--- Diff: lib/cl/externals/bundle.lisp ---
@@ -0,0 +1,161 @@
+(cl:in-package #:cl-user)
--- End diff --
Missing license statement.
---
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1410#discussion_r148790023
--- Diff: lib/cl/externals/bundle-info.sexp ---
@@ -0,0 +1,14 @@
+(:CREATION-TIME #A((20) BASE-CHAR . "2017-10-31T11:49:23Z")
:REQUESTED-SYSTEMS
---
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1410#discussion_r148790668
--- Diff: lib/cl/externals/software/bordeaux-threads-v0.8.5/.travis.yml ---
@@ -0,0 +1,44 @@
+language: lisp
--- End diff --
If you checked
[
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237642#comment-16237642
]
James E. King, III commented on THRIFT-82:
--
[~jfarrell] consider adding "Common Li
[
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reassigned THRIFT-82:
Assignee: James E. King, III
> Common Lisp support
> ---
>
>
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1382#discussion_r148793389
--- Diff: lib/go/test/tests/client_error_test.go ---
@@ -411,7 +411,7 @@ func TestClientReportTTransportErrors(t *testing.T) {
if !prepareCli
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1382#discussion_r148793005
--- Diff: build/docker/ubuntu-trusty/Dockerfile ---
@@ -217,6 +217,62 @@ RUN rm -rf /var/cache/apt/* && \
rm -rf /tmp/* && \
rm -rf /var/tm
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237646#comment-16237646
]
ASF GitHub Bot commented on THRIFT-4285:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237645#comment-16237645
]
ASF GitHub Bot commented on THRIFT-4285:
Github user jeking3 commented on a diff
Github user dcelasun commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1382#discussion_r148796351
--- Diff: build/docker/ubuntu-trusty/Dockerfile ---
@@ -217,6 +217,62 @@ RUN rm -rf /var/cache/apt/* && \
rm -rf /tmp/* && \
rm -rf /var/t
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237657#comment-16237657
]
ASF GitHub Bot commented on THRIFT-4285:
Github user dcelasun commented on a diff
Github user dkochmanski commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1410#discussion_r148796969
--- Diff: lib/cl/externals/bundle-info.sexp ---
@@ -0,0 +1,14 @@
+(:CREATION-TIME #A((20) BASE-CHAR . "2017-10-31T11:49:23Z")
:REQUESTED-SYSTEMS
Github user dcelasun commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1382#discussion_r148797018
--- Diff: lib/go/test/tests/client_error_test.go ---
@@ -411,7 +411,7 @@ func TestClientReportTTransportErrors(t *testing.T) {
if !prepareCl
Github user dkochmanski commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1410#discussion_r148797236
--- Diff: lib/cl/framed-transport.lisp ---
@@ -0,0 +1,136 @@
+(in-package #:org.apache.thrift.implementation)
+
+ Copyright 2017 Rigetti
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237661#comment-16237661
]
ASF GitHub Bot commented on THRIFT-4285:
Github user dcelasun commented on a diff
Github user dkochmanski commented on the issue:
https://github.com/apache/thrift/pull/1410
Thank you for taking your time for the review
---
Github user dcelasun commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1382#discussion_r148798731
--- Diff: build/docker/ubuntu-trusty/Dockerfile ---
@@ -217,6 +217,62 @@ RUN rm -rf /var/cache/apt/* && \
rm -rf /tmp/* && \
rm -rf /var/t
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237666#comment-16237666
]
ASF GitHub Bot commented on THRIFT-4285:
Github user dcelasun commented on a diff
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1382#discussion_r148808038
--- Diff: lib/go/test/tests/client_error_test.go ---
@@ -411,7 +411,7 @@ func TestClientReportTTransportErrors(t *testing.T) {
if !prepareCli
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237709#comment-16237709
]
ASF GitHub Bot commented on THRIFT-4285:
Github user jeking3 commented on a diff
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1382#discussion_r148808549
--- Diff: build/docker/ubuntu-trusty/Dockerfile ---
@@ -221,3 +221,4 @@ ENV THRIFT_ROOT /thrift
RUN mkdir -p $THRIFT_ROOT/src
COPY Dockerfile $THRI
Github user dcelasun commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1382#discussion_r148808675
--- Diff: lib/go/test/tests/client_error_test.go ---
@@ -411,7 +411,7 @@ func TestClientReportTTransportErrors(t *testing.T) {
if !prepareCl
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237712#comment-16237712
]
ASF GitHub Bot commented on THRIFT-4285:
Github user jeking3 commented on a diff
Github user dcelasun commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1382#discussion_r148808724
--- Diff: build/docker/ubuntu-trusty/Dockerfile ---
@@ -221,3 +221,4 @@ ENV THRIFT_ROOT /thrift
RUN mkdir -p $THRIFT_ROOT/src
COPY Dockerfile $THR
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237714#comment-16237714
]
ASF GitHub Bot commented on THRIFT-4285:
Github user dcelasun commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237713#comment-16237713
]
ASF GitHub Bot commented on THRIFT-4285:
Github user dcelasun commented on a diff
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1382
@jeking3 All done! I think we are good to merge, what do you think?
---
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Can Celasun reassigned THRIFT-4285:
---
Assignee: Can Celasun (was: Chris Bannister)
> Pull generated send/recv into library to all
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238360#comment-16238360
]
ASF GitHub Bot commented on THRIFT-4285:
Github user dcelasun commented on the is
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1382
Excellent, I will merge this, and we'll get it into 0.11.0 - so yay! We
can consider the backwards-compatible construction adapter to be deprecated so
that it can be removed in the follow-on releas
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238674#comment-16238674
]
ASF GitHub Bot commented on THRIFT-4285:
Github user jeking3 commented on the iss
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1382
---
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4285.
Resolution: Fixed
Fix Version/s: 0.11.0
Committed - thanks everyone for your
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238675#comment-16238675
]
ASF GitHub Bot commented on THRIFT-4285:
Github user asfgit closed the pull reque
45 matches
Mail list logo
