Github user becrux closed the pull request at:
https://github.com/apache/thrift/pull/628
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user becrux commented on the pull request:
https://github.com/apache/thrift/pull/628#issuecomment-168705173
Hi @nsuke,
really sorry for the delay, I was very busy during last month.
I've prepared a new patch, according to your suggestions. How can I clean
this
Github user becrux commented on the pull request:
https://github.com/apache/thrift/pull/628#issuecomment-168751457
Well, maybe it's better to start from the actual master revision ... do you
agree?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/628#issuecomment-168750912
@becrux Thanks for that !
You can push your changes to the original branch of this pull request (in
your case it seems master branch of your fork) and the changes will
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/628#issuecomment-168758978
yes, that would indeed be better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user becrux commented on the pull request:
https://github.com/apache/thrift/pull/628#issuecomment-168759296
Great. So, I could clean this pull request? Should I create a new one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/628#issuecomment-168761555
It may not be necessary because it will be updated automatically as you
update your branch.
But it's also totally fine to close this one and create new one.
---
If
Github user becrux commented on a diff in the pull request:
https://github.com/apache/thrift/pull/628#discussion_r45579147
--- Diff: lib/cpp/test/qt/TQTcpServerTest.cpp ---
@@ -1,18 +1,23 @@
#define BOOST_TEST_MODULE TQTcpServerTest
#include
-#include
+
Github user becrux commented on a diff in the pull request:
https://github.com/apache/thrift/pull/628#discussion_r45581352
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1105,10 +1113,17 @@ void TNonblockingServer::listenSocket(THRIFT_SOCKET
s) {
Github user becrux commented on the pull request:
https://github.com/apache/thrift/pull/628#issuecomment-158879513
@nsuke, thanks for all your reviews.
Shall I perform a new patch, according to your suggestion?
Thanks,
A.
---
If your project is set up for it,
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/628#discussion_r45580689
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1105,10 +1113,17 @@ void TNonblockingServer::listenSocket(THRIFT_SOCKET
s) {
Github user becrux commented on a diff in the pull request:
https://github.com/apache/thrift/pull/628#discussion_r45579299
--- Diff: lib/cpp/test/SecurityTest.cpp ---
@@ -108,8 +108,13 @@ struct SecurityFixture : public TestPortFixture
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/628#discussion_r45579296
--- Diff: lib/cpp/test/qt/TQTcpServerTest.cpp ---
@@ -1,18 +1,23 @@
#define BOOST_TEST_MODULE TQTcpServerTest
#include
-#include
+
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/628#discussion_r45579512
--- Diff: lib/cpp/test/SecurityTest.cpp ---
@@ -108,8 +108,13 @@ struct SecurityFixture : public TestPortFixture
Github user becrux commented on a diff in the pull request:
https://github.com/apache/thrift/pull/628#discussion_r45580255
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1105,10 +1113,17 @@ void TNonblockingServer::listenSocket(THRIFT_SOCKET
s) {
Github user becrux commented on a diff in the pull request:
https://github.com/apache/thrift/pull/628#discussion_r45579380
--- Diff: lib/cpp/test/TFileTransportTest.cpp ---
@@ -91,19 +99,35 @@ class FsyncLog {
class TempFile {
public:
TempFile(const char*
Github user becrux commented on a diff in the pull request:
https://github.com/apache/thrift/pull/628#discussion_r45579221
--- Diff: lib/cpp/test/CMakeLists.txt ---
@@ -25,6 +25,10 @@ include_directories(SYSTEM "${Boost_INCLUDE_DIRS}")
#Make sure gen-cpp files can be included
Github user becrux commented on a diff in the pull request:
https://github.com/apache/thrift/pull/628#discussion_r45579441
--- Diff: lib/cpp/src/thrift/windows/GetTimeOfDay.cpp ---
@@ -23,17 +23,28 @@
// win32
#include
+#if defined(__MINGW32__)
+ #include
Github user becrux commented on a diff in the pull request:
https://github.com/apache/thrift/pull/628#discussion_r45579517
--- Diff: lib/cpp/test/OpenSSLManualInitTest.cpp ---
@@ -67,6 +67,22 @@ void test_openssl_availability() {
openssl_cleanup();
}
--- End
Github user becrux commented on a diff in the pull request:
https://github.com/apache/thrift/pull/628#discussion_r45579754
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1105,10 +1113,17 @@ void TNonblockingServer::listenSocket(THRIFT_SOCKET
s) {
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/628#discussion_r45580084
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1105,10 +1113,17 @@ void TNonblockingServer::listenSocket(THRIFT_SOCKET
s) {
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/628#issuecomment-158881753
@becrux, yes, it would be great !
Thank you for contributing, it will help others using the platform a lot.
---
If your project is set up for it, you can reply to
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/628#discussion_r45576725
--- Diff: lib/cpp/test/qt/TQTcpServerTest.cpp ---
@@ -1,18 +1,23 @@
#define BOOST_TEST_MODULE TQTcpServerTest
#include
-#include
+
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/628#discussion_r45577051
--- Diff: lib/cpp/test/OpenSSLManualInitTest.cpp ---
@@ -67,6 +67,22 @@ void test_openssl_availability() {
openssl_cleanup();
}
--- End
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/628#discussion_r45576872
--- Diff: lib/cpp/test/SecurityTest.cpp ---
@@ -108,8 +108,13 @@ struct SecurityFixture : public TestPortFixture
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/628#discussion_r45577368
--- Diff: lib/cpp/test/TFileTransportTest.cpp ---
@@ -91,19 +99,35 @@ class FsyncLog {
class TempFile {
public:
TempFile(const char* directory,
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/628#discussion_r45576807
--- Diff: lib/cpp/test/CMakeLists.txt ---
@@ -25,6 +25,10 @@ include_directories(SYSTEM "${Boost_INCLUDE_DIRS}")
#Make sure gen-cpp files can be included
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/628#discussion_r45576978
--- Diff: lib/cpp/src/thrift/windows/GetTimeOfDay.cpp ---
@@ -23,17 +23,28 @@
// win32
#include
+#if defined(__MINGW32__)
+ #include
28 matches
Mail list logo
