Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/343
OK :)
---
Github user solomax closed the pull request at:
https://github.com/apache/wicket/pull/343
---
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/343
@svenmeier Should this be merged into 7.x?
---
GitHub user solomax opened a pull request:
https://github.com/apache/wicket/pull/344
[WICKET-6620] deprecated classes/methods are removed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/wicket WICKET-6620-remove
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/343#discussion_r238202582
--- Diff:
wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
---
@@ -2116,10 +2116,15 @@
// Adds
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/343#discussion_r238121519
--- Diff:
wicket-core/src/main/java/org/apache/wicket/markup/html/internal/HtmlHeaderContainer.java
---
@@ -161,19 +161,19 @@ public final void
GitHub user solomax opened a pull request:
https://github.com/apache/wicket/pull/343
[WICKET-6617] headers are added to header-items if specified
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/wicket WICKET-6617-header
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/340
I would not change `tab` with 2 spaces for whole project
Even this markup can have `tab` and will be readable if CSS will be in
separate file
my 2c
---
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/300
It would be impossible to call `pageSavingThread.join();` to ensure Thread
is stopped
Would it be OK?
---
GitHub user solomax opened a pull request:
https://github.com/apache/wicket/pull/300
[WICKET-6603] Asypc page/data store destroyed without hanging
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/wicket WICKET-6603
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/294#discussion_r220426844
--- Diff:
wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
---
@@ -2301,6 +2302,10
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/290
@SubrahmanyamSistha it seems you are trying to merge fix for wicket-9 to
wicket-8 branch ...
I believe this PR need to be closed and corrected
---
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/287
+1 from me :)
---
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/288#discussion_r206803641
--- Diff:
wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java ---
@@ -22,7 +22,7 @@
* Provides Base64 encoding and decoding with URL
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/287#discussion_r206493340
--- Diff:
wicket-util/src/test/java/org/apache/wicket/util/collections/IntHashMapTest.java
---
@@ -48,9 +46,9 @@ public void serialize() throws IOException
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/287#discussion_r206492111
--- Diff:
wicket-core/src/main/java/org/apache/wicket/util/tester/WicketTester.java ---
@@ -54,14 +38,24 @@
import
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/287#discussion_r206493069
--- Diff:
wicket-util/src/main/java/org/apache/wicket/util/markup/xhtml/WellFormedXmlTestCase.java
---
@@ -16,23 +16,18 @@
*/
package
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/275
@klopfdreh can you create wicketstuff module?
---
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/275
I believe we can add browser detection as wicketstuff module and/or as
confluence example
Should be easy and useful
---
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/279
Could you please fix spaces to be tabs?
---
Github user solomax closed the pull request at:
https://github.com/apache/wicket/pull/269
---
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/269
OK, let's close this one :)
---
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/275#discussion_r182993206
--- Diff:
wicket-core/src/test/java/org/apache/wicket/protocol/http/request/WebClientInfoTest.java
---
@@ -59,9 +58,52 @@ public void before
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/275#discussion_r181297750
--- Diff:
wicket-core/src/test/java/org/apache/wicket/protocol/http/request/WebClientInfoTest.java
---
@@ -59,9 +58,52 @@ public void before
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/275#discussion_r181294275
--- Diff:
wicket-core/src/test/java/org/apache/wicket/protocol/http/request/WebClientInfoTest.java
---
@@ -59,9 +58,52 @@ public void before
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/275#discussion_r181293918
--- Diff:
wicket-core/src/test/java/org/apache/wicket/protocol/http/request/WebClientInfoTest.java
---
@@ -59,9 +58,52 @@ public void before
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/275#discussion_r181293591
--- Diff:
wicket-core/src/test/java/org/apache/wicket/protocol/http/request/WebClientInfoTest.java
---
@@ -59,9 +58,52 @@ public void before
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/275#discussion_r181293350
--- Diff:
wicket-core/src/main/java/org/apache/wicket/protocol/http/request/WebClientInfo.java
---
@@ -147,6 +149,93 @@ private String getUserAgentStringLc
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/275#discussion_r181293318
--- Diff:
wicket-core/src/main/java/org/apache/wicket/protocol/http/request/WebClientInfo.java
---
@@ -147,6 +149,93 @@ private String getUserAgentStringLc
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/275#discussion_r181282823
--- Diff:
wicket-core/src/main/java/org/apache/wicket/protocol/http/request/WebClientInfo.java
---
@@ -193,165 +198,117 @@ protected String getRemoteAddr
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/275#discussion_r181282313
--- Diff:
wicket-core/src/main/java/org/apache/wicket/protocol/http/request/WebClientInfo.java
---
@@ -193,165 +198,117 @@ protected String getRemoteAddr
GitHub user solomax opened a pull request:
https://github.com/apache/wicket/pull/274
[WICKET-6546] HTML comments are removed from inline CSS
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/wicket WICKET-6546-no-css
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/273#discussion_r178463264
--- Diff:
wicket-core/src/main/java/org/apache/wicket/markup/head/CssHeaderItem.java ---
@@ -200,7 +207,13 @@ public static CssReferenceHeaderItem
GitHub user solomax opened a pull request:
https://github.com/apache/wicket/pull/270
[WICKET-6533] Unicode non-characters are skipped
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/wicket WICKET-6533-non-characters
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/269#discussion_r176132347
--- Diff:
wicket-core/src/test/java/org/apache/wicket/protocol/http/request/WebClientInfoTest.java
---
@@ -680,6 +708,35 @@ public void konqueror
GitHub user solomax opened a pull request:
https://github.com/apache/wicket/pull/269
[WICKET-6544] mobile browser detection is improved
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/wicket WICKET-6544-mobile-browsers
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/261
The code looks good to me
Our main application also seems to work as expected with this version
+1
---
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/258
Thanks @svenmeier, my bad, I should investigate deeper.
+1 for merging this PR, everything works as expected :)))
---
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/258
It seems I should use `git rebase` while merging
---
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/258
Thanks @svenmeier , `Auto mode` seems to work :)
I have updated https://github.com/solomax/repeater-with-events with case
that fails in deferred mode
I'll try to check this from my side
---
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/258
Hello @svenmeier
Finally I was able to create quick-start
https://github.com/solomax/repeater-with-events,
The issue is reproducible using latest wicket-core from master branch
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/258
@svenmeier
here is incomplete investigation: I can see same errors using latest
8.0.0-SNAPSHOT from master branch :(
I have checked commit-by-commit and this behavior caused by this
https
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/258
Will try to create quickstart
Might take some time .
---
Github user solomax closed the pull request at:
https://github.com/apache/wicket/pull/260
---
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/260#discussion_r164051979
--- Diff:
wicket-core/src/main/java/org/apache/wicket/ajax/AbstractAjaxTimerBehavior.java
---
@@ -92,6 +95,35 @@ public void renderHead(Component component
GitHub user solomax opened a pull request:
https://github.com/apache/wicket/pull/260
[WICKET-6523] unique suffix is added if more than 1 timer behaviour iâ¦
â¦s added for the component
You can merge this pull request into a Git repository by running:
$ git pull https
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/258#discussion_r164029616
--- Diff:
wicket-examples/src/main/java/org/apache/wicket/examples/ajax/builtin/AjaxApplication.java
---
@@ -44,6 +46,11 @@ protected void init
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/258#discussion_r164029599
--- Diff:
wicket-core/src/test/java/org/apache/wicket/markup/head/filter/FilteringHeaderResponseTest.java
---
@@ -74,4 +75,22 @@ protected Response
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/253
Sure :) no rush, just would like to check if everyone happy with this PR :)
---
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/253
Thanks a lot @svenmeier!
All tests are green now :)
Shall we merge?
---
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/256#discussion_r161435444
--- Diff:
wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
---
@@ -643,11 +643,6 @@
we.publish
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/253#discussion_r161372957
--- Diff:
wicket-core/src/main/java/org/apache/wicket/markup/head/filter/FilteringHeaderResponse.java
---
@@ -263,14 +262,12 @@ public void markRendered
GitHub user solomax opened a pull request:
https://github.com/apache/wicket/pull/257
[WICKET-6518] Log4j is replaced with logback
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/wicket WICKET-6518-quickstart-logback
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/253#discussion_r161220021
--- Diff:
wicket-core/src/main/java/org/apache/wicket/markup/head/ResourceAggregator.java
---
@@ -337,24 +338,27 @@ private void renderCombinedEventScripts
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/253#discussion_r161151287
--- Diff:
wicket-core/src/main/java/org/apache/wicket/ajax/AbstractDefaultAjaxBehavior.java
---
@@ -106,8 +107,7 @@ public void renderHead(final Component
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/253#discussion_r161151470
--- Diff:
wicket-core/src/main/java/org/apache/wicket/markup/head/OnDomReadyHeaderItem.java
---
@@ -86,8 +86,8 @@ public void render(Response response
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/253#discussion_r161121472
--- Diff:
wicket-core/src/main/java/org/apache/wicket/ajax/AbstractDefaultAjaxBehavior.java
---
@@ -106,8 +107,7 @@ public void renderHead(final Component
GitHub user solomax opened a pull request:
https://github.com/apache/wicket/pull/252
[WICKET-6512] feedbackMessages, style, pageId, sequence and temporaryâ¦
â¦SessionAttributes are not being dropped while session replacement
You can merge this pull request into a Git repository
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/249#discussion_r155466396
--- Diff:
wicket-core/src/main/java/org/apache/wicket/core/util/string/ComponentRenderer.java
---
@@ -16,35 +16,321 @@
*/
package
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/249
We are currently using WicketTester for this, I'll try this later tonight
and will give huge +1 :))
---
GitHub user solomax opened a pull request:
https://github.com/apache/wicket/pull/248
[WICKET-6501] storeSettings.isAsynchronous() is honored
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/wicket WICKET-6501-store
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/246
I believe this can be closed
@theigl could you please close this PR?
---
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/247
@svenmeier I'll merge if you have no objections :)
---
GitHub user solomax opened a pull request:
https://github.com/apache/wicket/pull/247
[WICKET-6497] wicket-event-jquery.js and wicket-ajax-jquery.js are meâ¦
â¦rged, references are updated
Surprisingly huge PR
You can merge this pull request into a Git repository
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/246#discussion_r152173556
--- Diff:
wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/PropertyValidator_fr.properties.xml
---
@@ -26,6 +26,8 @@
Le champ
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/246#discussion_r152042763
--- Diff:
wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/PropertyValidator_fr.properties.xml
---
@@ -26,6 +26,8 @@
Le champ
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/246#discussion_r151932467
--- Diff:
wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/PropertyValidator_fr.properties.xml
---
@@ -26,6 +26,8 @@
Le champ
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/246#discussion_r151861578
--- Diff:
wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/PropertyValidator.java
---
@@ -208,24 +206,29 @@ public void detach
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/246#discussion_r151861201
--- Diff:
wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/PropertyValidator.java
---
@@ -208,24 +206,28 @@ public void detach
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/246#discussion_r151861199
--- Diff:
wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/PropertyValidator.java
---
@@ -208,24 +206,28 @@ public void detach
GitHub user solomax opened a pull request:
https://github.com/apache/wicket/pull/245
[WICKET-6492] minified js/css files are bundled
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/wicket WICKET-6492-minify-fix
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/244
Is it OK to merge this PR?
---
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/244
@svenmeier I reverted my changes to AjaxDownloadBehavior.java, thanks for
catching this :)
---
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/244#discussion_r150018189
--- Diff:
wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/AjaxDownloadBehavior.java
---
@@ -323,10 +323,30 @@ private String getName
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/244#discussion_r150012308
--- Diff:
wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/AjaxDownloadBehavior.java
---
@@ -323,10 +323,30 @@ private String getName
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/244#discussion_r149991409
--- Diff:
wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/wicket-ajaxdownload.js
---
@@ -108,29 +108,32
GitHub user solomax opened a pull request:
https://github.com/apache/wicket/pull/244
[WICKET-6491] ajax download seems to work under both IE11 and Edge
I would appreciate if someone can review my changes
You can merge this pull request into a Git repository by running:
$ git
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/235
Hello All,
Are we happy with these changes? Is it time to merge? :)
---
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/235
Hello @svenmeier maybe I can help with the changes need to be done?
I really need M8 to be released :))
---
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/235
This issue is too silent :(((
Is it time to merge? Or maybe another review cycle?
---
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/235
Everything seems to work :)
Time for another (final?) review? :))
---
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/235
IDateConverter is removed, Will try to add additional tests as soon as I
get more free time
BTW how are you running wicket-examples? it fail to start for me :(
`mvn jetty:run
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/235
I did homework (partially) and added some tests :)
Could you please check them and maybe add some more? :))
---
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/236
Should this change be cherry-picked to other branches?
---
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/236
@martin-g Should I merge then delete the branch? Is the process of merging
documented somewhere?
---
GitHub user solomax opened a pull request:
https://github.com/apache/wicket/pull/236
[WICKET-6476] check is added while setting filter path to prevent excâ¦
â¦eption
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/wicket
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/235
I'll create `org.apache.wicket.examples.datetime` later tonight taking
`org.apache.wicket.examples.captcha` as reference :)
---
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/235
old date examples are still available at wicketstuff, what is "example's
compref"?
---
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/235#discussion_r142088563
--- Diff:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/DateTimeField.java
---
@@ -0,0 +1,278
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/235#discussion_r142088478
--- Diff:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/DateLabel.java
---
@@ -227,14 +216,10 @@ public DateLabel
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/235#discussion_r142076722
--- Diff:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/DateTimeField.java
---
@@ -0,0 +1,288
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/235#discussion_r142076750
--- Diff:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/IDateConverter.java
---
@@ -0,0 +1,53
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/235#discussion_r142076776
--- Diff:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/StyleTimeConverter.java
---
@@ -0,0 +1,118
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/235#discussion_r142076656
--- Diff: pom.xml ---
@@ -89,7 +89,6 @@
wicket
wicket-core
wicket-util
- wicket-datetime
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/235#discussion_r142076708
--- Diff:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/DateTimeField.java
---
@@ -0,0 +1,288
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/235
Is it time to merge this PR and pack M8? ;)
---
GitHub user solomax opened a pull request:
https://github.com/apache/wicket/pull/235
Wicket 6105 java.time
- datetime module is moved to wicketstuff
- all references to joda-time are removed
- The build is fixed
You can merge this pull request into a Git repository
GitHub user solomax opened a pull request:
https://github.com/apache/wicket/pull/228
WICKET-6437: Library versions are updated
I was unable to update
org.jglue.cdi-unit:cdi-unit and wildfly
It seems code/build modifications are required for this :(
You can merge
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/227#discussion_r131064919
--- Diff:
wicket-experimental/wicket-http2/wicket-http2-core/src/main/java/org/apache/wicket/http2/markup/head/PushHeaderItem.java
---
@@ -361,7 +366,32
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/219#discussion_r30572
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/FileSystemResource.java ---
@@ -95,7 +95,9 @@ protected ResourceResponse
1 - 100 of 113 matches
Mail list logo
