> -Original Message-
> From: Brian J. Johnson
> Sent: Friday, May 10, 2024 1:58 PM
> To: r...@edk2.groups.io; pedro.falc...@gmail.com; Kinney, Michael D
>
> Cc: devel@edk2.groups.io; Leif Lindholm ; Andrew Fish
> (af...@apple.com)
> Subject: Re: [edk2-rfc] [edk2-devel] Proposal to
On 5/3/24 12:38, Pedro Falcato wrote:
On Thu, May 2, 2024 at 7:17 PM Kinney, Michael D
wrote:
-Original Message-
From: r...@edk2.groups.io On Behalf Of Pedro Falcato
Sent: Thursday, May 2, 2024 10:51 AM
To: devel@edk2.groups.io; Kinney, Michael D
Cc: r...@edk2.groups.io; Leif
Internal Use - Confidential
On 2024-05-01 18:43, Michael D Kinney wrote:
> Hello,
>
> I would like to propose that TianoCore move all code review from email
> based code reviews to GitHub Pull Requests based code reviews.
>
> The proposed date to switch would be immediately after the next stable
On Mon, 6 May 2024 at 17:57, Kinney, Michael D
wrote:
>
> Hi Ard,
>
> Thais is an attribute of Mergify. I do not see a way to change that
> behavior.
>
> I do not know if using the GitHub merge capability or other merge services
> provides different behavior here or not.
>
> This specific
Hi Ard,
Thais is an attribute of Mergify. I do not see a way to change that
behavior.
I do not know if using the GitHub merge capability or other merge services
provides different behavior here or not.
This specific request is not related to the change to GitHub PRs
for code review. There is
On Mon, 6 May 2024 at 17:11, Kinney, Michael D
wrote:
>
> That information is in GitHub in the PR conversation.
>
> If you follow the link from the commit to the PR, the PR conversation shows
> who set the 'push' label.
>
But that is GitHub proprietary metadata, no? Is it not possible to set
the
That information is in GitHub in the PR conversation.
If you follow the link from the commit to the PR, the PR conversation shows
who set the 'push' label.
Mike
> -Original Message-
> From: r...@edk2.groups.io On Behalf Of Ard
> Biesheuvel
> Sent: Monday, May 6, 2024 3:01 AM
> To:
This reminds me: would it be possible to keep track of who merged a
PR? (i.e., the person that set the 'push' label)
Currently, commits just appear on the branch with the original author
and the committer field set to something non-descript, e.g.,
commit 275d0a39c42ad73a6e4929822f56f5d8c16ede96
On Sat, May 4, 2024 at 1:57 AM Michael Kubacki
wrote:
>
> On 5/3/2024 4:38 PM, Michael D Kinney wrote:
> >
> >
> >> -Original Message-
> >> From: Kinney, Michael D
> >> Sent: Friday, May 3, 2024 1:13 PM
> >> To: Pedro Falcato
> >> Cc: r...@edk2.groups.io; devel@edk2.groups.io; Leif
On 5/3/2024 4:38 PM, Michael D Kinney wrote:
-Original Message-
From: Kinney, Michael D
Sent: Friday, May 3, 2024 1:13 PM
To: Pedro Falcato
Cc: r...@edk2.groups.io; devel@edk2.groups.io; Leif Lindholm
; Andrew Fish (af...@apple.com) ;
Kinney, Michael D
Subject: RE: [edk2-rfc]
> -Original Message-
> From: Kinney, Michael D
> Sent: Friday, May 3, 2024 1:13 PM
> To: Pedro Falcato
> Cc: r...@edk2.groups.io; devel@edk2.groups.io; Leif Lindholm
> ; Andrew Fish (af...@apple.com) ;
> Kinney, Michael D
> Subject: RE: [edk2-rfc] [edk2-devel] Proposal to switch
> -Original Message-
> From: Pedro Falcato
> Sent: Friday, May 3, 2024 10:39 AM
> To: Kinney, Michael D
> Cc: r...@edk2.groups.io; devel@edk2.groups.io; Leif Lindholm
> ; Andrew Fish (af...@apple.com)
> Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code
> Review
Yes. Many options on transition. I would suggest we consider the
following steps.
1) Define a manual process where Maintainers/Reviewers look for
new PRs and make sure all the required maintainers/reviewers
are invited to the review. Current process has many manual
steps. Having
On Thu, May 2, 2024 at 7:17 PM Kinney, Michael D
wrote:
>
>
>
> > -Original Message-
> > From: r...@edk2.groups.io On Behalf Of Pedro Falcato
> > Sent: Thursday, May 2, 2024 10:51 AM
> > To: devel@edk2.groups.io; Kinney, Michael D
> > Cc: r...@edk2.groups.io; Leif Lindholm ; Andrew Fish
Hi Mike,
I've seen that repo in that past.
Are the steps defined for what's needed to move to CODEWONERS (and
REVIEWERS) in terms of technical and process changes needed?
For example, could we start with CODEOWNERS manually synced to
Maintainers.txt, Maintainers.txt dropped, and then add
On 5/2/2024 12:37 PM, Kinney, Michael D wrote:
-Original Message-
From: Leif Lindholm
Sent: Thursday, May 2, 2024 3:57 AM
To: devel@edk2.groups.io; mikub...@linux.microsoft.com; Kinney, Michael
D ; r...@edk2.groups.io
Cc: Andrew Fish (af...@apple.com)
Subject: Re: [edk2-devel]
On 5/2/2024 6:57 AM, Leif Lindholm wrote:
On 2024-05-02 04:08, Michael Kubacki wrote:
Thank you for this proposal. We've been anticipating this change for
years and are excited to help support it.
Here's some items we'd like to raise for feedback that we could help
implement. Many could
On 5/2/2024 9:14 AM, Michael Kubacki wrote:
[2] https://github.com/tianocore/edk2/pull/4835
I can't believe there's no UI for this, but in case anyone else is
wondering: the diff can be downloaded by adding ".diff" or ".patch" onto
the end of the URL - e.g.
> -Original Message-
> From: r...@edk2.groups.io On Behalf Of Pedro Falcato
> Sent: Thursday, May 2, 2024 10:51 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> Cc: r...@edk2.groups.io; Leif Lindholm ; Andrew Fish
> (af...@apple.com)
> Subject: Re: [edk2-rfc] [edk2-devel] Proposal
On Wed, May 1, 2024 at 6:44 PM Michael D Kinney via groups.io
wrote:
>
> Hello,
>
> I would like to propose that TianoCore move all code review from email
> based code reviews to GitHub Pull Requests based code reviews.
>
> The proposed date to switch would be immediately after the next stable
>
> -Original Message-
> From: Leif Lindholm
> Sent: Thursday, May 2, 2024 3:57 AM
> To: devel@edk2.groups.io; mikub...@linux.microsoft.com; Kinney, Michael
> D ; r...@edk2.groups.io
> Cc: Andrew Fish (af...@apple.com)
> Subject: Re: [edk2-devel] Proposal to switch TianoCore Code Review
> -Original Message-
> From: r...@edk2.groups.io On Behalf Of Brian J.
> Johnson
> Sent: Thursday, May 2, 2024 8:59 AM
> To: devel@edk2.groups.io; dionnagl...@google.com;
> quic_llind...@quicinc.com
> Cc: Kinney, Michael D ; r...@edk2.groups.io;
> Andrew Fish (af...@apple.com)
>
Hi Michael,
I have a version of the auto assignment working, but needs to be
migrated to TianoCore and synced with the latest Maintainers.txt.
My experience getting this running even as a POC was that it took a lot
of effort to make sure the best security practices were followed and
to
On Thu, May 2, 2024 at 8:59 AM Brian J. Johnson wrote:
>
> On 5/1/24 18:19, Dionna Glaze via groups.io wrote:
> > On Wed, May 1, 2024 at 11:12 AM Leif Lindholm via groups.io
> > wrote:
> >>
> >> On 2024-05-01 18:43, Michael D Kinney wrote:
> >>> Hello,
> >>>
> >>> I would like to propose that
On 5/1/24 18:19, Dionna Glaze via groups.io wrote:
On Wed, May 1, 2024 at 11:12 AM Leif Lindholm via groups.io
wrote:
On 2024-05-01 18:43, Michael D Kinney wrote:
Hello,
I would like to propose that TianoCore move all code review from email
based code reviews to GitHub Pull Requests based
On 5/2/2024 6:34 AM, Leif Lindholm wrote:
On 2024-05-02 07:33, Marcin Juszkiewicz wrote:
W dniu 1.05.2024 o 19:43, Michael D Kinney via groups.io pisze:
I would like to propose that TianoCore move all code review from email
based code reviews to GitHub Pull Requests based code reviews.
The
On 5/2/2024 5:37 AM, Ard Biesheuvel wrote:
On Wed, 1 May 2024 at 19:44, Michael D Kinney
wrote:
Hello,
I would like to propose that TianoCore move all code review from email
based code reviews to GitHub Pull Requests based code reviews.
The proposed date to switch would be immediately after
On 2024-05-02 04:08, Michael Kubacki wrote:
Thank you for this proposal. We've been anticipating this change for
years and are excited to help support it.
Here's some items we'd like to raise for feedback that we could help
implement. Many could likely be done in time for the transition.
1.
On 2024-05-02 07:33, Marcin Juszkiewicz wrote:
W dniu 1.05.2024 o 19:43, Michael D Kinney via groups.io pisze:
I would like to propose that TianoCore move all code review from email
based code reviews to GitHub Pull Requests based code reviews.
The proposed date to switch would be immediately
On 2024-05-02 02:28, Rebecca Cran wrote:
On Wed, May 1, 2024, at 11:43 AM, Michael D Kinney wrote:
* The Pull Request submitter is required to invite the required
maintainers and reviewers to the pull request. This is the same
set of maintainers and reviewers that are required to be
On Wed, 1 May 2024 at 19:44, Michael D Kinney
wrote:
>
> Hello,
>
> I would like to propose that TianoCore move all code review from email
> based code reviews to GitHub Pull Requests based code reviews.
>
> The proposed date to switch would be immediately after the next stable
> tag which is
W dniu 1.05.2024 o 19:43, Michael D Kinney via groups.io pisze:
I would like to propose that TianoCore move all code review from email
based code reviews to GitHub Pull Requests based code reviews.
The proposed date to switch would be immediately after the next stable
tag which is currently
Thank you for this proposal. We've been anticipating this change for
years and are excited to help support it.
Here's some items we'd like to raise for feedback that we could help
implement. Many could likely be done in time for the transition.
1. Automate reviewers - We've discussed
On Wed, May 1, 2024, at 11:43 AM, Michael D Kinney wrote:
> * The Pull Request submitter is required to invite the required
> maintainers and reviewers to the pull request. This is the same
> set of maintainers and reviewers that are required to be listed in
> Cc: tags in today's process.
On Wed, May 1, 2024 at 11:12 AM Leif Lindholm via groups.io
wrote:
>
> On 2024-05-01 18:43, Michael D Kinney wrote:
> > Hello,
> >
> > I would like to propose that TianoCore move all code review from email
> > based code reviews to GitHub Pull Requests based code reviews.
> >
> > The proposed
On 2024-05-01 18:43, Michael D Kinney wrote:
Hello,
I would like to propose that TianoCore move all code review from email
based code reviews to GitHub Pull Requests based code reviews.
The proposed date to switch would be immediately after the next stable
tag which is currently scheduled for
Hello,
I would like to propose that TianoCore move all code review from email
based code reviews to GitHub Pull Requests based code reviews.
The proposed date to switch would be immediately after the next stable
tag which is currently scheduled for May 24, 2024.
Updates to the following Wiki
37 matches
Mail list logo
