Re: CURL review request

2011-08-31 Thread Ary Manzana
On 8/31/11 11:29 PM, David Nadlinger wrote: On 8/25/11 8:53 AM, Jacob Carlborg wrote: On 2011-08-24 20:36, jdrewsen wrote: One way that may improve this would be to move the static methods outside the class and make them into module functions instead. The drawbacks of this is: 1, When import

Re: CURL review request

2011-08-31 Thread David Nadlinger
On 8/25/11 8:53 AM, Jacob Carlborg wrote: On 2011-08-24 20:36, jdrewsen wrote: One way that may improve this would be to move the static methods outside the class and make them into module functions instead. The drawbacks of this is: 1, When importing the module there would be more symbols po

Re: CURL review request

2011-08-24 Thread Jacob Carlborg
On 2011-08-24 20:36, jdrewsen wrote: One way that may improve this would be to move the static methods outside the class and make them into module functions instead. The drawbacks of this is: 1, When importing the module there would be more symbols polluting the namespace. 2, We would have to

Re: CURL review request

2011-08-24 Thread dsimcha
== Quote from jdrewsen (jdrew...@nospam.com)'s article > One way that may improve this would be to move the static methods > outside the class and make them into module functions instead. > The drawbacks of this is: > 1, When importing the module there would be more symbols polluting the > namespac

Re: CURL review request

2011-08-24 Thread Adam Ruppe
For what it's worth, my little curl.d module has one magic function that just kinda does it all: string curl(string url, string postData = null, string postDataContentType = "application/x-www-form-data"); (or whatever the content type is) This does simple stuff, then there's other ways to do fan

Re: CURL review request

2011-08-24 Thread jdrewsen
Den 24-08-2011 13:04, Johannes Pfau skrev: dav1d wrote: Jonas Drewsen Wrote: Hi all, This is a review request for the curl wrapper. Please read the "known issues" in the top of the source file and if possible suggest a solution. We also need somebody for running the review process. Anyo

Re: CURL review request

2011-08-24 Thread Johannes Pfau
dav1d wrote: >Jonas Drewsen Wrote: > >> Hi all, >> >> This is a review request for the curl wrapper. Please read the >> "known issues" in the top of the source file and if possible suggest >> a solution. >> >> We also need somebody for running the review process. Anyone? >> >> Code: >>

Re: CURL review request

2011-08-24 Thread dav1d
Jonas Drewsen Wrote: > Hi all, > > This is a review request for the curl wrapper. Please read the > "known issues" in the top of the source file and if possible suggest a > solution. > > We also need somebody for running the review process. Anyone? > > Code: > https://github.com/jcd

Re: CURL review request

2011-08-20 Thread Timon Gehr
On 08/20/2011 02:06 AM, Jonathan M Davis wrote: On Friday, August 19, 2011 15:27 Timon Gehr wrote: On 08/19/2011 10:36 PM, Jonathan M Davis wrote: On Friday, August 19, 2011 04:58 Timon Gehr wrote: On 08/19/2011 01:50 AM, Jonathan M Davis wrote: On Thursday, August 18, 2011 16:00 Timon Gehr w

Re: CURL review request

2011-08-19 Thread Jonathan M Davis
On Friday, August 19, 2011 15:27 Timon Gehr wrote: > On 08/19/2011 10:36 PM, Jonathan M Davis wrote: > > On Friday, August 19, 2011 04:58 Timon Gehr wrote: > >> On 08/19/2011 01:50 AM, Jonathan M Davis wrote: > >>> On Thursday, August 18, 2011 16:00 Timon Gehr wrote: > On 08/19/2011 12:35 AM,

Re: CURL review request

2011-08-19 Thread Timon Gehr
On 08/19/2011 10:36 PM, Jonathan M Davis wrote: On Friday, August 19, 2011 04:58 Timon Gehr wrote: On 08/19/2011 01:50 AM, Jonathan M Davis wrote: On Thursday, August 18, 2011 16:00 Timon Gehr wrote: On 08/19/2011 12:35 AM, Jonathan M Davis wrote: On Thursday, August 18, 2011 14:33 jdrewsen w

Re: CURL review request

2011-08-19 Thread Jonathan M Davis
On Friday, August 19, 2011 04:58 Timon Gehr wrote: > On 08/19/2011 01:50 AM, Jonathan M Davis wrote: > > On Thursday, August 18, 2011 16:00 Timon Gehr wrote: > >> On 08/19/2011 12:35 AM, Jonathan M Davis wrote: > >>> On Thursday, August 18, 2011 14:33 jdrewsen wrote: > Den 17-08-2011 18:21, Ti

Re: CURL review request

2011-08-19 Thread jdrewsen
Den 18-08-2011 20:12, Martin Nowak skrev: On Tue, 16 Aug 2011 13:48:57 +0200, Jonas Drewsen wrote: Hi all, This is a review request for the curl wrapper. Please read the "known issues" in the top of the source file and if possible suggest a solution. We also need somebody for running the rev

Re: CURL review request

2011-08-19 Thread jdrewsen
Den 19-08-2011 00:55, Timon Gehr skrev: On 08/18/2011 11:33 PM, jdrewsen wrote: Den 17-08-2011 18:21, Timon Gehr skrev: On 08/17/2011 05:58 PM, Jonathan M Davis wrote: On Wednesday, August 17, 2011 11:30:06 Steven Schveighoffer wrote: On Wed, 17 Aug 2011 11:05:56 -0400, jdrewsen wrote: Den 1

Re: CURL review request

2011-08-19 Thread Timon Gehr
On 08/19/2011 01:50 AM, Jonathan M Davis wrote: On Thursday, August 18, 2011 16:00 Timon Gehr wrote: On 08/19/2011 12:35 AM, Jonathan M Davis wrote: On Thursday, August 18, 2011 14:33 jdrewsen wrote: Den 17-08-2011 18:21, Timon Gehr skrev: On 08/17/2011 05:58 PM, Jonathan M Davis wrote: On W

Re: CURL review request

2011-08-18 Thread Long Chang
http://gool.googlecode.com/files/libcurl_7.21.7.zip this libcurl static lib is build by dmc , with openssl support . On 16 August 2011 19:48, Jonas Drewsen wrote: > Hi all, > > This is a review request for the curl wrapper. Please read the "known > issues" in the top of the source file and if

Re: CURL review request

2011-08-18 Thread Marco Leise
Am 18.08.2011, 14:16 Uhr, schrieb bearophile : Jonathan M Davis: It increases the size of the zip file unnecessarily for the majority of users, and anyone using anything other than Windows definitely won't need it.< This is a silly argument. Have you seen the size of the binary distribu

Re: CURL review request

2011-08-18 Thread Jonathan M Davis
On Thursday, August 18, 2011 16:50 Jonathan M Davis wrote: > On Thursday, August 18, 2011 16:00 Timon Gehr wrote: > > On 08/19/2011 12:35 AM, Jonathan M Davis wrote: > > > On Thursday, August 18, 2011 14:33 jdrewsen wrote: > > >> Den 17-08-2011 18:21, Timon Gehr skrev: > > >>> On 08/17/2011 05:58 P

Re: CURL review request

2011-08-18 Thread Jonathan M Davis
On Thursday, August 18, 2011 16:00 Timon Gehr wrote: > On 08/19/2011 12:35 AM, Jonathan M Davis wrote: > > On Thursday, August 18, 2011 14:33 jdrewsen wrote: > >> Den 17-08-2011 18:21, Timon Gehr skrev: > >>> On 08/17/2011 05:58 PM, Jonathan M Davis wrote: > On Wednesday, August 17, 2011 11:30

Re: CURL review request

2011-08-18 Thread Timon Gehr
On 08/19/2011 12:35 AM, Jonathan M Davis wrote: On Thursday, August 18, 2011 14:33 jdrewsen wrote: Den 17-08-2011 18:21, Timon Gehr skrev: On 08/17/2011 05:58 PM, Jonathan M Davis wrote: On Wednesday, August 17, 2011 11:30:06 Steven Schveighoffer wrote: On Wed, 17 Aug 2011 11:05:56 -0400, jdr

Re: CURL review request

2011-08-18 Thread Timon Gehr
On 08/18/2011 11:33 PM, jdrewsen wrote: Den 17-08-2011 18:21, Timon Gehr skrev: On 08/17/2011 05:58 PM, Jonathan M Davis wrote: On Wednesday, August 17, 2011 11:30:06 Steven Schveighoffer wrote: On Wed, 17 Aug 2011 11:05:56 -0400, jdrewsen wrote: Den 17-08-2011 15:51, Steven Schveighoffer skr

Re: CURL review request

2011-08-18 Thread Jonathan M Davis
On Thursday, August 18, 2011 14:33 jdrewsen wrote: > Den 17-08-2011 18:21, Timon Gehr skrev: > > On 08/17/2011 05:58 PM, Jonathan M Davis wrote: > >> On Wednesday, August 17, 2011 11:30:06 Steven Schveighoffer wrote: > >>> On Wed, 17 Aug 2011 11:05:56 -0400, jdrewsen wrote: > Den 17-08-2011 15

Re: CURL review request

2011-08-18 Thread jdrewsen
Den 17-08-2011 18:21, Timon Gehr skrev: On 08/17/2011 05:58 PM, Jonathan M Davis wrote: On Wednesday, August 17, 2011 11:30:06 Steven Schveighoffer wrote: On Wed, 17 Aug 2011 11:05:56 -0400, jdrewsen wrote: Den 17-08-2011 15:51, Steven Schveighoffer skrev: On Wed, 17 Aug 2011 05:43:00 -0400,

Re: CURL review request

2011-08-18 Thread Martin Nowak
On Tue, 16 Aug 2011 13:48:57 +0200, Jonas Drewsen wrote: Hi all, This is a review request for the curl wrapper. Please read the "known issues" in the top of the source file and if possible suggest a solution. We also need somebody for running the review process. Anyone? Code:

Re: CURL review request

2011-08-18 Thread kennytm
Andrei Alexandrescu wrote: > I think we need to include curl with the Windows distribution. It's > reasonable to assume connectivity is a broadly needed feature. We must > solve the zip bloating issue for Unix people by breaking the zip per > platform. Next to nobody ever wants to have Windows, L

Re: CURL review request

2011-08-18 Thread Andrej Mitrovic
On 8/18/11, dsimcha wrote: > ...That and we could get the zip file size back down by using > OS-specific zips. You know what Linux users really don't need? Windows > DMD and Phobos binaries. > And vice versa.

Re: CURL review request

2011-08-18 Thread Andrei Alexandrescu
On 8/18/11 6:48 AM, Jacob Carlborg wrote: On 2011-08-18 10:37, bearophile wrote: Jonas Drewsen: If a decent package management tool was added to D which could handle downloading the binary lib for you then wouldn't that be an okey solition for you?< What I think is acceptable is to put now t

Re: CURL review request

2011-08-18 Thread dsimcha
On 8/18/2011 8:16 AM, bearophile wrote: Jonathan M Davis: It increases the size of the zip file unnecessarily for the majority of users, and anyone using anything other than Windows definitely won't need it.< This is a silly argument. Have you seen the size of the binary distributions of Py

Re: CURL review request

2011-08-18 Thread bearophile
Jonathan M Davis: >It increases the size of the zip file unnecessarily for the majority of users, >and anyone using anything other than Windows definitely won't need it.< This is a silly argument. Have you seen the size of the binary distributions of Python, Java, DotNet? The Haskell installer

Re: CURL review request

2011-08-18 Thread Jacob Carlborg
On 2011-08-18 10:37, bearophile wrote: Jonas Drewsen: If a decent package management tool was added to D which could handle downloading the binary lib for you then wouldn't that be an okey solition for you?< What I think is acceptable is to put now the binary of the Windows library inside t

Re: CURL review request

2011-08-18 Thread Jonathan M Davis
On Thursday, August 18, 2011 04:37:20 bearophile wrote: > Jonas Drewsen: > >If a decent package management tool was added to D which could handle > >downloading the binary lib for you then wouldn't that be an okey solition > >for you?< > What I think is acceptable is to put now the binary of the Wi

Re: CURL review request

2011-08-18 Thread Josh Simmons
On Thu, Aug 18, 2011 at 6:37 PM, bearophile wrote: > Jonas Drewsen: > >>If a decent package management tool was added to D which could handle >>downloading the binary lib for you then wouldn't that be an okey solition for >>you?< > > What I think is acceptable is to put now the binary of the Win

Re: CURL review request

2011-08-18 Thread bearophile
Jonas Drewsen: >If a decent package management tool was added to D which could handle >downloading the binary lib for you then wouldn't that be an okey solition for >you?< What I think is acceptable is to put now the binary of the Windows library inside the zip of the DMD distribution. Once th

Re: CURL review request

2011-08-17 Thread Jimmy Cao
On Wed, Aug 17, 2011 at 10:41 PM, dsimcha wrote: > On 8/16/2011 7:48 AM, Jonas Drewsen wrote: > >> Hi all, >> >> This is a review request for the curl wrapper. Please read the "known >> issues" in the top of the source file and if possible suggest a solution. >> >> We also need somebody for runni

Re: CURL review request

2011-08-17 Thread dsimcha
On 8/16/2011 7:48 AM, Jonas Drewsen wrote: Hi all, This is a review request for the curl wrapper. Please read the "known issues" in the top of the source file and if possible suggest a solution. We also need somebody for running the review process. Anyone? Code: https://github.com/jcd/phobos/b

Re: CURL review request

2011-08-17 Thread Jonathan M Davis
On Wednesday, August 17, 2011 15:48 Timon Gehr wrote: > On 08/17/2011 11:09 PM, Jonathan M Davis wrote: > > On Wednesday, August 17, 2011 13:31 Martin Nowak wrote: > >> Not wanting to drift too far off topic I'll add one last point. > >> given: > >> immutable(int[]) data = assumeUnique(myints); > >

Re: CURL review request

2011-08-17 Thread Timon Gehr
On 08/17/2011 11:09 PM, Jonathan M Davis wrote: On Wednesday, August 17, 2011 13:31 Martin Nowak wrote: Not wanting to drift too far off topic I'll add one last point. given: immutable(int[]) data = assumeUnique(myints); send(cast(int[])data); writeln(data[0]); A compiler implementation could d

Re: CURL review request

2011-08-17 Thread Jonathan M Davis
On Wednesday, August 17, 2011 13:31 Martin Nowak wrote: > Not wanting to drift too far off topic I'll add one last point. > given: > immutable(int[]) data = assumeUnique(myints); > send(cast(int[])data); > writeln(data[0]); > > A compiler implementation could deduce data won't change between > ini

Re: CURL review request

2011-08-17 Thread Martin Nowak
On Wed, 17 Aug 2011 18:21:00 +0200, Timon Gehr wrote: On 08/17/2011 05:58 PM, Jonathan M Davis wrote: On Wednesday, August 17, 2011 11:30:06 Steven Schveighoffer wrote: On Wed, 17 Aug 2011 11:05:56 -0400, jdrewsen wrote: Den 17-08-2011 15:51, Steven Schveighoffer skrev: On Wed, 17 Aug 201

Re: CURL review request

2011-08-17 Thread jdrewsen
Den 17-08-2011 00:17, Alix Pexton skrev: On 16/08/2011 20:55, jdrewsen wrote: Den 16-08-2011 16:43, Alix Pexton skrev: On 16/08/2011 12:48, Jonas Drewsen wrote: Hi all, This is a review request for the curl wrapper. Please read the "known issues" in the top of the source file and if possible

Re: CURL review request

2011-08-17 Thread Jacob Carlborg
On 2011-08-17 09:13, Jonathan M Davis wrote: On Wednesday, August 17, 2011 09:01:02 Jacob Carlborg wrote: On 2011-08-16 22:01, Jonathan M Davis wrote: On Tuesday, August 16, 2011 18:47:44 Jacob Carlborg wrote: BTW, do we have style guides for abbreviations like this? No. The style guide says

Re: CURL review request

2011-08-17 Thread Timon Gehr
On 08/17/2011 05:58 PM, Jonathan M Davis wrote: On Wednesday, August 17, 2011 11:30:06 Steven Schveighoffer wrote: On Wed, 17 Aug 2011 11:05:56 -0400, jdrewsen wrote: Den 17-08-2011 15:51, Steven Schveighoffer skrev: On Wed, 17 Aug 2011 05:43:00 -0400, Jonas Drewsen wrote: On 17/08/11 00.2

Re: CURL review request

2011-08-17 Thread Jonathan M Davis
On Wednesday, August 17, 2011 11:30:06 Steven Schveighoffer wrote: > On Wed, 17 Aug 2011 11:05:56 -0400, jdrewsen wrote: > > Den 17-08-2011 15:51, Steven Schveighoffer skrev: > >> On Wed, 17 Aug 2011 05:43:00 -0400, Jonas Drewsen > >> > >> > >> wrote: > >>> On 17/08/11 00.21, Jonathan M Davis wr

Re: CURL review request

2011-08-17 Thread Steven Schveighoffer
On Wed, 17 Aug 2011 11:05:56 -0400, jdrewsen wrote: Den 17-08-2011 15:51, Steven Schveighoffer skrev: On Wed, 17 Aug 2011 05:43:00 -0400, Jonas Drewsen wrote: On 17/08/11 00.21, Jonathan M Davis wrote: On Tuesday, August 16, 2011 12:32 Martin Nowak wrote: On Tue, 16 Aug 2011 20:48:51 +020

Re: CURL review request

2011-08-17 Thread Timon Gehr
On 08/17/2011 05:05 PM, jdrewsen wrote: Den 17-08-2011 15:51, Steven Schveighoffer skrev: On Wed, 17 Aug 2011 05:43:00 -0400, Jonas Drewsen wrote: On 17/08/11 00.21, Jonathan M Davis wrote: On Tuesday, August 16, 2011 12:32 Martin Nowak wrote: On Tue, 16 Aug 2011 20:48:51 +0200, jdrewsen wr

Re: CURL review request

2011-08-17 Thread jdrewsen
Den 17-08-2011 15:51, Steven Schveighoffer skrev: On Wed, 17 Aug 2011 05:43:00 -0400, Jonas Drewsen wrote: On 17/08/11 00.21, Jonathan M Davis wrote: On Tuesday, August 16, 2011 12:32 Martin Nowak wrote: On Tue, 16 Aug 2011 20:48:51 +0200, jdrewsen wrote: Den 16-08-2011 18:55, Martin Nowak

Re: CURL review request

2011-08-17 Thread Steven Schveighoffer
On Wed, 17 Aug 2011 05:43:00 -0400, Jonas Drewsen wrote: On 17/08/11 00.21, Jonathan M Davis wrote: On Tuesday, August 16, 2011 12:32 Martin Nowak wrote: On Tue, 16 Aug 2011 20:48:51 +0200, jdrewsen wrote: Den 16-08-2011 18:55, Martin Nowak skrev: On Tue, 16 Aug 2011 15:13:40 +0200, dsim

Re: CURL review request

2011-08-17 Thread Jonas Drewsen
On 17/08/11 00.21, Jonathan M Davis wrote: On Tuesday, August 16, 2011 12:32 Martin Nowak wrote: On Tue, 16 Aug 2011 20:48:51 +0200, jdrewsen wrote: Den 16-08-2011 18:55, Martin Nowak skrev: On Tue, 16 Aug 2011 15:13:40 +0200, dsimcha wrote: On 8/16/2011 7:48 AM, Jonas Drewsen wrote: Hi al

Re: CURL review request

2011-08-17 Thread Jonas Drewsen
On 16/08/11 22.39, bearophile wrote: jdrewsen: etc.c.curl is already in phobos and no binary library for curl is in. I see. I didn't know this. Then it's the good moment to improve this situation. I disagree on this one though. But please see my reply to jonathan as to how I see final solu

Re: CURL review request

2011-08-17 Thread Jonathan M Davis
On Wednesday, August 17, 2011 09:01:02 Jacob Carlborg wrote: > On 2011-08-16 22:01, Jonathan M Davis wrote: > > On Tuesday, August 16, 2011 18:47:44 Jacob Carlborg wrote: > >> BTW, do we have style guides for abbreviations like this? > > > > No. The style guide says camelcase, but it doesn't speci

Re: CURL review request

2011-08-17 Thread Jacob Carlborg
On 2011-08-16 22:01, Jonathan M Davis wrote: On Tuesday, August 16, 2011 18:47:44 Jacob Carlborg wrote: BTW, do we have style guides for abbreviations like this? No. The style guide says camelcase, but it doesn't specify how to deal with abbreviations. Personally, I think that it should be dea

Re: CURL review request

2011-08-16 Thread Jonathan M Davis
On Tuesday, August 16, 2011 17:08:26 David Nadlinger wrote: > Seems like the reviews are already coming in steadily, but we still have > no review manager – if nobody else steps up until tomorrow, I'd > volunteer so we can get the formal review process going. I'd volunteered previously before std.

Re: CURL review request

2011-08-16 Thread Jesse Phillips
On Tue, 16 Aug 2011 16:39:36 -0400, bearophile wrote: > jdrewsen: > >> etc.c.curl is already in phobos and no binary library for curl is in. > > I see. I didn't know this. Then it's the good moment to improve this > situation. > > >> I disagree on this one though. But please see my reply to jo

Re: CURL review request

2011-08-16 Thread Jonathan M Davis
On Tuesday, August 16, 2011 12:32 Martin Nowak wrote: > On Tue, 16 Aug 2011 20:48:51 +0200, jdrewsen wrote: > > Den 16-08-2011 18:55, Martin Nowak skrev: > >> On Tue, 16 Aug 2011 15:13:40 +0200, dsimcha wrote: > >>> On 8/16/2011 7:48 AM, Jonas Drewsen wrote: > Hi all, > > This is

Re: CURL review request

2011-08-16 Thread Alix Pexton
On 16/08/2011 20:55, jdrewsen wrote: Den 16-08-2011 16:43, Alix Pexton skrev: On 16/08/2011 12:48, Jonas Drewsen wrote: Hi all, This is a review request for the curl wrapper. Please read the "known issues" in the top of the source file and if possible suggest a solution. We also need somebody

Re: CURL review request

2011-08-16 Thread Alix Pexton
On 16/08/2011 20:44, jdrewsen wrote: Den 16-08-2011 15:54, Alix Pexton skrev: Protocol.onProgress represents transfer statistics using doubles? That is what we get from libcurl I'll let you off then, but just this once ^^ CurlTimeCond, members are all lower case, took me a few goes to wor

Re: CURL review request

2011-08-16 Thread Alix Pexton
On 16/08/2011 17:38, Nick Sabalausky wrote: "Alix Pexton" wrote in message news:j2dsq0$2aht$1...@digitalmars.com... "...returns the number of elements in the buffer that has been filled and is ready to send." -> "...returns the number of elements in the buffer that have been filled and are re

Re: CURL review request

2011-08-16 Thread bearophile
jdrewsen: > etc.c.curl is already in phobos and no binary library for curl is in. I see. I didn't know this. Then it's the good moment to improve this situation. > I disagree on this one though. But please see my reply to jonathan as to > how I see final solution. Most times I'll not use a Ph

Re: CURL review request

2011-08-16 Thread jdrewsen
Den 16-08-2011 19:05, Jimmy Cao skrev: On Tue, Aug 16, 2011 at 10:08 AM, David Nadlinger mailto:s...@klickverbot.at>> wrote: Seems like the reviews are already coming in steadily, but we still have no review manager – if nobody else steps up until tomorrow, I'd volunteer so we can ge

Re: [OT] Re: CURL review request

2011-08-16 Thread jdrewsen
Den 16-08-2011 19:15, Lars T. Kyllingstad skrev: On Tue, 16 Aug 2011 12:26:19 -0400, Nick Sabalausky wrote: "David Nadlinger" wrote in message news:j2e15a$2nsh$1...@digitalmars.com... Seems like the reviews are already coming in steadily, but we still have no review manager - if nobody else s

Re: CURL review request

2011-08-16 Thread jdrewsen
Den 16-08-2011 22:05, bearophile skrev: jdrewsen: Other wrappers in phobos should be in the etc package and the lib binaries should not be included. Just how I feel about it though. Anyone who disagrees? All necessary binaries of the libraries used by all Phobos modules need to be in the zi

Re: CURL review request

2011-08-16 Thread jdrewsen
Den 16-08-2011 21:59, Jonathan M Davis skrev: On Tuesday, August 16, 2011 20:23:19 jdrewsen wrote: Den 16-08-2011 15:13, dsimcha skrev: On 8/16/2011 7:48 AM, Jonas Drewsen wrote: Hi all, This is a review request for the curl wrapper. Please read the "known issues" in the top of the source fil

Re: CURL review request

2011-08-16 Thread bearophile
jdrewsen: > Other wrappers in phobos should be in the > etc package and the lib binaries should not be included. > > Just how I feel about it though. Anyone who disagrees? All necessary binaries of the libraries used by all Phobos modules need to be in the zip of the Windows distribution (and

Re: CURL review request

2011-08-16 Thread Jonathan M Davis
On Tuesday, August 16, 2011 18:47:44 Jacob Carlborg wrote: > On 2011-08-16 15:54, kennytm wrote: > > Jonas Drewsen wrote: > >> Hi all, > >> > >> This is a review request for the curl wrapper. Please read the > >> "known>> > >> issues" in the top of the source file and if possible suggest

Re: CURL review request

2011-08-16 Thread jdrewsen
Den 16-08-2011 16:43, Alix Pexton skrev: On 16/08/2011 12:48, Jonas Drewsen wrote: Hi all, This is a review request for the curl wrapper. Please read the "known issues" in the top of the source file and if possible suggest a solution. We also need somebody for running the review process. Anyon

Re: CURL review request

2011-08-16 Thread Jonathan M Davis
On Tuesday, August 16, 2011 20:23:19 jdrewsen wrote: > Den 16-08-2011 15:13, dsimcha skrev: > > On 8/16/2011 7:48 AM, Jonas Drewsen wrote: > >> Hi all, > >> > >> This is a review request for the curl wrapper. Please read the "known > >> issues" in the top of the source file and if possible suggest

Re: CURL review request

2011-08-16 Thread jdrewsen
Den 16-08-2011 18:38, Nick Sabalausky skrev: "Alix Pexton" wrote in message news:j2dsq0$2aht$1...@digitalmars.com... "...returns the number of elements in the buffer that has been filled and is ready to send." -> "...returns the number of elements in the buffer that have been filled and are r

Re: CURL review request

2011-08-16 Thread jdrewsen
Den 16-08-2011 15:54, Alix Pexton skrev: On 16/08/2011 12:48, Jonas Drewsen wrote: Hi all, This is a review request for the curl wrapper. Please read the "known issues" in the top of the source file and if possible suggest a solution. We also need somebody for running the review process. Anyon

Re: CURL review request

2011-08-16 Thread Martin Nowak
On Tue, 16 Aug 2011 20:48:51 +0200, jdrewsen wrote: Den 16-08-2011 18:55, Martin Nowak skrev: On Tue, 16 Aug 2011 15:13:40 +0200, dsimcha wrote: On 8/16/2011 7:48 AM, Jonas Drewsen wrote: Hi all, This is a review request for the curl wrapper. Please read the "known issues" in the top of t

Re: CURL review request

2011-08-16 Thread jdrewsen
Den 16-08-2011 20:49, dsimcha skrev: == Quote from jdrewsen (jdrew...@nospam.com)'s article Den 16-08-2011 15:13, dsimcha skrev: On 8/16/2011 7:48 AM, Jonas Drewsen wrote: Hi all, This is a review request for the curl wrapper. Please read the "known issues" in the top of the source file and i

Re: CURL review request

2011-08-16 Thread jdrewsen
Den 16-08-2011 15:54, kennytm skrev: Jonas Drewsen wrote: Hi all, This is a review request for the curl wrapper. Please read the "known issues" in the top of the source file and if possible suggest a solution. We also need somebody for running the review process. Anyone? Code: ht

Re: CURL review request

2011-08-16 Thread jdrewsen
Den 16-08-2011 18:55, Martin Nowak skrev: On Tue, 16 Aug 2011 15:13:40 +0200, dsimcha wrote: On 8/16/2011 7:48 AM, Jonas Drewsen wrote: Hi all, This is a review request for the curl wrapper. Please read the "known issues" in the top of the source file and if possible suggest a solution. We

Re: CURL review request

2011-08-16 Thread dsimcha
== Quote from jdrewsen (jdrew...@nospam.com)'s article > Den 16-08-2011 15:13, dsimcha skrev: > > On 8/16/2011 7:48 AM, Jonas Drewsen wrote: > >> Hi all, > >> > >> This is a review request for the curl wrapper. Please read the "known > >> issues" in the top of the source file and if possible sugges

Re: CURL review request

2011-08-16 Thread jdrewsen
Den 16-08-2011 15:13, dsimcha skrev: On 8/16/2011 7:48 AM, Jonas Drewsen wrote: Hi all, This is a review request for the curl wrapper. Please read the "known issues" in the top of the source file and if possible suggest a solution. We also need somebody for running the review process. Anyone?

Re: CURL review request

2011-08-16 Thread jdrewsen
Den 16-08-2011 14:57, Jacob Carlborg skrev: On 2011-08-16 13:48, Jonas Drewsen wrote: Hi all, This is a review request for the curl wrapper. Please read the "known issues" in the top of the source file and if possible suggest a solution. We also need somebody for running the review process. An

Re: [OT] Re: CURL review request

2011-08-16 Thread Lars T. Kyllingstad
On Tue, 16 Aug 2011 12:26:19 -0400, Nick Sabalausky wrote: > "David Nadlinger" wrote in message > news:j2e15a$2nsh$1...@digitalmars.com... >> Seems like the reviews are already coming in steadily, but we still >> have no review manager - if nobody else steps up until tomorrow, I'd >> volunteer so

Re: CURL review request

2011-08-16 Thread Lars T. Kyllingstad
On Tue, 16 Aug 2011 08:53:12 -0400, bearophile wrote: > Jonas Drewsen: > >> Demolish! > > I'd like to try this module. Do you have a compiled curl lib for > Windows? http://curl.haxx.se/download.html -Lars

Re: CURL review request

2011-08-16 Thread Jimmy Cao
On Tue, Aug 16, 2011 at 10:08 AM, David Nadlinger wrote: > Seems like the reviews are already coming in steadily, but we still have no > review manager – if nobody else steps up until tomorrow, I'd volunteer so we > can get the formal review process going. > > David > > > > On 8/16/11 1:48 PM, Jon

Re: CURL review request

2011-08-16 Thread Martin Nowak
On Tue, 16 Aug 2011 15:13:40 +0200, dsimcha wrote: On 8/16/2011 7:48 AM, Jonas Drewsen wrote: Hi all, This is a review request for the curl wrapper. Please read the "known issues" in the top of the source file and if possible suggest a solution. We also need somebody for running the revie

Re: CURL review request

2011-08-16 Thread Jacob Carlborg
On 2011-08-16 15:54, kennytm wrote: Jonas Drewsen wrote: Hi all, This is a review request for the curl wrapper. Please read the "known issues" in the top of the source file and if possible suggest a solution. We also need somebody for running the review process. Anyone? Code: htt

Re: CURL review request

2011-08-16 Thread Nick Sabalausky
"Alix Pexton" wrote in message news:j2dsq0$2aht$1...@digitalmars.com... > > "...returns the number of elements in the buffer that has been filled and > is ready to send." -> "...returns the number of elements in the buffer > that have been filled and are ready to send." > "in the buffer that h

[OT] Re: CURL review request

2011-08-16 Thread Nick Sabalausky
"David Nadlinger" wrote in message news:j2e15a$2nsh$1...@digitalmars.com... > Seems like the reviews are already coming in steadily, but we still have > no review manager - if nobody else steps up until tomorrow, I'd volunteer > so we can get the formal review process going. > Curious: What ex

Re: CURL review request

2011-08-16 Thread David Nadlinger
Seems like the reviews are already coming in steadily, but we still have no review manager – if nobody else steps up until tomorrow, I'd volunteer so we can get the formal review process going. David On 8/16/11 1:48 PM, Jonas Drewsen wrote: Hi all, This is a review request for the curl wrap

Re: CURL review request

2011-08-16 Thread Alix Pexton
On 16/08/2011 12:48, Jonas Drewsen wrote: Hi all, This is a review request for the curl wrapper. Please read the "known issues" in the top of the source file and if possible suggest a solution. We also need somebody for running the review process. Anyone? Code: https://github.com/jcd/phobos/bl

Re: CURL review request

2011-08-16 Thread kennytm
Alix Pexton wrote: > > Some (all?) of the @property members of Protocol are documented as > functions. (Perhaps an artefact of the ddoc mixin issue mentioned before this > section?) > Bug 3445. > Protocol.onProgress represents transfer statistics using doubles? > Unfortunately curl's API u

Re: CURL review request

2011-08-16 Thread Alix Pexton
On 16/08/2011 12:48, Jonas Drewsen wrote: Hi all, This is a review request for the curl wrapper. Please read the "known issues" in the top of the source file and if possible suggest a solution. We also need somebody for running the review process. Anyone? Code: https://github.com/jcd/phobos/bl

Re: CURL review request

2011-08-16 Thread kennytm
Jonas Drewsen wrote: > Hi all, > >This is a review request for the curl wrapper. Please read the "known > issues" in the top of the source file and if possible suggest a solution. > > We also need somebody for running the review process. Anyone? > > Code: > https://github.com/jcd/phob

Re: CURL review request

2011-08-16 Thread dsimcha
On 8/16/2011 7:48 AM, Jonas Drewsen wrote: Hi all, This is a review request for the curl wrapper. Please read the "known issues" in the top of the source file and if possible suggest a solution. We also need somebody for running the review process. Anyone? Code: https://github.com/jcd/phobos/b

Re: CURL review request

2011-08-16 Thread Jacob Carlborg
On 2011-08-16 13:48, Jonas Drewsen wrote: Hi all, This is a review request for the curl wrapper. Please read the "known issues" in the top of the source file and if possible suggest a solution. We also need somebody for running the review process. Anyone? Code: https://github.com/jcd/phobos/bl

Re: CURL review request

2011-08-16 Thread bearophile
Jonas Drewsen: > Demolish! I'd like to try this module. Do you have a compiled curl lib for Windows? Bye, bearophile

Re: CURL review request

2011-08-16 Thread Jacob Carlborg
On 2011-08-16 13:48, Jonas Drewsen wrote: Hi all, This is a review request for the curl wrapper. Please read the "known issues" in the top of the source file and if possible suggest a solution. We also need somebody for running the review process. Anyone? Code: https://github.com/jcd/phobos/bl

CURL review request

2011-08-16 Thread Jonas Drewsen
Hi all, This is a review request for the curl wrapper. Please read the "known issues" in the top of the source file and if possible suggest a solution. We also need somebody for running the review process. Anyone? Code: https://github.com/jcd/phobos/blob/curl-wrapper/etc/curl.d