* build/ALPHA_SE/tests/fast/quick/60.rubytest/alpha/linux/rubytest-ruby
passed.
* build/ALPHA_SE/tests/fast/quick/00.hello/alpha/linux/simple-timing passed.
* build/ALPHA_SE/tests/fast/quick/00.hello/alpha/linux/o3-timing passed.
*
On 2011-01-03 15:31:20, Brad Beckmann wrote:
Hi Nilay,
First, I must say this is an impressive amount of work. You definitely got a
lot done over holiday break. :)
Overall, this set of patches is definitely close, but I want to see if we can
take them a step forward. Also I have a few
Hi Nilay,
On deadlock issue with MESI_CMP_directory :
Yes, this can happen as ruby_tester or Sequencer only reports
*possible* deadlocks. With higher number of processors there is more
contention (and thus latency) and it can mistakenly report deadlock. I
generally look at the protocol
Hi Nilay,
My responses are below:
The main thing I would like to see improved is not having to differentiate
between “entry†and “entry_ptr†in the .sm files. Am I correct
that the only functions in the .sm files that are passed an
“entry_ptr†are “is_valid_ptrâ€,
What threshold do you use?
On Tue, 4 Jan 2011, Arkaprava Basu wrote:
Hi Nilay,
On deadlock issue with MESI_CMP_directory :
Yes, this can happen as ruby_tester or Sequencer only reports *possible*
deadlocks. With higher number of processors there is more contention (and
thus latency)
On Mon, Jan 3, 2011 at 10:41 PM, nathan binkert n...@binkert.org wrote:
So far I've found two oddities with a straightforward implementation of
this
approach:
(1) It breaks down when the target is a prefix of the source:
[ STRIP] ALPHA_SE/m5.fast.unstripped -
instead of
[
[ STRIP] ALPHA_SE/m5.fast - .unstripped
Would it be for just this one, or all? I think that we generally want
to cut and paste the source, not the target, so either way, this
doesn't seem like a great option.
Or I could trim back to the path separator:
[ STRIP]
These are the following step I use:
1. First run with whatever default values of threshold are.
2. If deadlocked, take trace and try to find out is there evident reason
for deadlock or not.
3. If no, double the default threshold value and run again.
4. If the same test passes with larger
On Tue, Jan 4, 2011 at 11:24 AM, nathan binkert n...@binkert.org wrote:
[ STRIP] ALPHA_SE/m5.fast - .unstripped
Would it be for just this one, or all? I think that we generally want
to cut and paste the source, not the target, so either way, this
doesn't seem like a great option.
For
Brad
Is there a reason why each action name follows the pattern combination of
several letters_action performed by the action? The letters used are
not abbreviations of the action performed. Can we use any combination?
Thanks
Nilay
On Tue, 4 Jan 2011, Beckmann, Brad wrote:
Hi Nilay,
My
Hi Nilay,
At one point in time, the combination of several letters at the beginning of
the action name corresponded to the short hand name for the action. The short
hand name is the letter or letter combination that appears in the HTML tables.
SLICC may have once enforced that the
changeset c819526b7c2a in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=c819526b7c2a
description:
Params: Print the IP components in the right order.
diffstat:
src/base/inet.cc | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diffs (14 lines):
diff -r
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/368/
---
Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/369/
---
Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/370/
---
Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/371/
---
Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/372/
---
Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/334/
---
Review request for Default.
Summary
---
This patch changes the manner in
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/369/#review599
---
Ship it!
Looks good. I assume it works.
- Nathan
On 2011-01-04
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/373/
---
Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/374/
---
Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/370/#review600
---
Ship it!
Looks good.
- Nathan
On 2011-01-04 14:41:43, Steve Reinhardt
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/371/#review601
---
Ship it!
- Nathan
On 2011-01-04 14:41:53, Steve Reinhardt wrote:
FYI, I've been working recently on implementing multiple event
queues/threads, and while the actual multi-queue code isn't ready yet, these
patches represent a bunch of preliminary cleanup/setup changes that make it
possible. I'd like to get these committed so I don't have to keep rebasing
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/368/#review604
---
Ship it!
- Nathan
On 2011-01-04 14:40:57, Steve Reinhardt wrote:
FYI, I've been working recently on implementing multiple event
queues/threads, and while the actual multi-queue code isn't ready yet, these
patches represent a bunch of preliminary cleanup/setup changes that make it
possible. I'd like to get these committed so I don't have to keep rebasing
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/374/#review605
---
Ship it!
Maybe it's too much for this diff, but I think you can get rid
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/367/
---
(Updated 2011-01-04 15:02:38.269001)
Review request for Default, Ali Saidi, Gabe
On Tue, Jan 4, 2011 at 2:59 PM, nathan binkert n...@binkert.org wrote:
FYI, I've been working recently on implementing multiple event
queues/threads, and while the actual multi-queue code isn't ready yet,
these
patches represent a bunch of preliminary cleanup/setup changes that make
it
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/334/#review606
---
Hi Nilay,
These changes look good, but don't you also have to use a tbe
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/334/#review607
---
Ship it!
Nevermind my previous statement. I needed to look closer.
A long time ago we thought about putting a m5/system/ directory where
we would put architecture dependent code system code (boot loaders,
alpha console, etc). How do we feel about this? We could move the alpha
code in there now that HP relicensed it. Additionally, I've got a tiny
ARM boot loader
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/367/#review608
---
Hi Nate,
I have a couple questions:
1. Have you looked at the protocol
On 2011-01-04 14:59:52, Nathan Binkert wrote:
Maybe it's too much for this diff, but I think you can get rid of the
global variable and put _curTick in the event queue class. Then you can
put a curTick() accessor into the EventQueue and EventManager classes, and
create a global
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/374/#review610
---
Ship it!
- Ali
On 2011-01-04 14:43:38, Steve Reinhardt wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/367/#review611
---
src/mem/ruby/buffers/MessageBuffer.cc
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/368/#review612
---
Ship it!
- Ali
On 2011-01-04 14:40:57, Steve Reinhardt wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/373/#review613
---
Ship it!
- Ali
On 2011-01-04 14:43:02, Steve Reinhardt wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/372/#review614
---
Ship it!
- Ali
On 2011-01-04 14:42:03, Steve Reinhardt wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/371/#review615
---
Ship it!
- Ali
On 2011-01-04 14:41:53, Steve Reinhardt wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/370/#review616
---
Ship it!
- Ali
On 2011-01-04 14:41:43, Steve Reinhardt wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/369/#review617
---
Ship it!
My only question is does it work? it seems like the if
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/365/#review618
---
It's pretty good. I think Nate's suggestion is great and maybe a little
On 2011-01-04 16:56:58, Ali Saidi wrote:
My only question is does it work? it seems like the if statements don't
translate exactly, but that could just be over-specifying the if (e.g. can
you ever fall out with out any action?).
You're right, the issue is that the old code would
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/366/#review620
---
Ship it!
I think we talked about this and I'm ok with what we ended up
I think we talked about this and I'm ok with what we ended up on the mailing
list... Bonus points if you colorize the output :)...
Blue = '\033[94m'
Yellow = '\033[94m'
Green = '\033[92m'
End = '\0330m'
CCCOMSTR = Blue + ' [ CC] ' + Yellow + '$TRANSFORMATION' + End
Neat idea, but
I want to keep this a purely syntactic change, because I think the semantic
changes are going to require some discussion. For example, my current
next-step patch replaces mainEventQueue with an array of queues (so there is
no single main event queue any more), and uses TLS to implement
A long time ago we thought about putting a m5/system/arch directory where
we would put architecture dependent code system code (boot loaders, alpha
console, etc). How do we feel about this? We could move the alpha code in
there now that HP relicensed it. Additionally, I've got a tiny ARM boot
On 2011-01-04 16:48:28, Ali Saidi wrote:
src/mem/ruby/buffers/MessageBuffer.cc, line 163
http://reviews.m5sim.org/r/367/diff/3/?file=8418#file8418line163
Why continue to comment this out?
Mostly because I didn't do it. I don't like commented code in the tree, and
one of the
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/352/#review625
---
src/base/debug.hh
http://reviews.m5sim.org/r/352/#comment838
This
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/351/#review627
---
Ship it!
- Ali
On 2010-12-21 08:25:03, Nathan Binkert wrote:
On Jan 4, 2011, at 7:56 PM, nathan binkert wrote:
Interesting. If you were going to do this, why do you need accessors at all?
This seems to mean that I shouldn't have created the whole EventManager
thing and had schedule be a per-object thing. TLS scares me, but maybe
that's
On Jan 4, 2011, at 8:15 PM, nathan binkert wrote:
I think we've beat this to death on the mailing list. My only comment is that
before it becomes part of the commit hook, please make sure that you can't
throw anything at it that will cause an exception.
A better thing to do is handle
On 2011-01-04 16:31:01, Brad Beckmann wrote:
Hi Nate,
I have a couple questions:
1. Have you looked at the protocol trace output after your change? Does it
look exactly like it did before? It seems that the output should be the same
based on my brief inspection of your patch, but I
changeset 9f9e10967912 in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=9f9e10967912
description:
Ruby: Updates MOESI Hammer protocol
This patch changes the manner in which data is copied from L1 to L2
cache in
the implementation of the Hammer's cache
On Tue, Jan 4, 2011 at 5:44 PM, nathan binkert n...@binkert.org wrote:
I think we talked about this and I'm ok with what we ended up on the mailing
list... Bonus points if you colorize the output :)...
Blue = '\033[94m'
Yellow = '\033[94m'
Green = '\033[92m'
End = '\0330m'
Just to dive in for a moment here. TLS doesn't scare me. I've looked at a
lot of ways to do the same thing and TLS is so much cleaner than the
alternative getspecific/setspecific.
I was more wondering about the global variable thing (TLS is
essentially a global) more than TLS vs
Neat idea, but you need to check sys.stdout.isatty() and conditionally
add the color. Then you're going to want a way to override that if you're
piping through less :) Seems like we could add a --color option to the
SCons command line.
It actually crossed my mind earlier today to use
Brad, do you have some protocol trace with you? I have seen the trace that
gets generated with the current trace facility using Ruby trace flag. It
prints all the events for all the cache controllers and network routers. If
you prefer, I can send you an example trace. Or you can generate
On 2011-01-04 19:17:43, Nilay Vaish wrote:
src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc, line 194
http://reviews.m5sim.org/r/367/diff/3/?file=8431#file8431line194
Should this not be converted to DPRINTF()?
Perhaps, but that is really a separate change. I don't
So do we want to define a standard set of assert like
macros/functions/whatever? If we're going to go for a fixed format we
should stick that in a header somewhere. I went with asserts because
they pretty conveniently check the result and blow up if there's a
problem, but printing PASS/FAIL
I think we've beat this to death on the mailing list. My only comment is
that before it becomes part of the commit hook, please make sure that you
can't throw anything at it that will cause an exception.
A better thing to do is handle all exceptions in the hook and just return
failure if
62 matches
Mail list logo
