Re: [gentoo-dev] [OT] pkgcore bikeshed (was Portage team)

2014-01-19 Thread Mike Frysinger
On Monday 13 January 2014 09:53:45 Tom Wijsman wrote: On Mon, 13 Jan 2014 16:15:37 +0700 C. Bergström wrote: At the end of the day we have one codebase which is engineered and another which has evolved. Too broad generalization, too much assumption; both can be held as meaning nothing

Re: [gentoo-dev] rfc: revisiting our stabilization policy

2014-01-19 Thread Mike Frysinger
On Friday 17 January 2014 02:02:51 gro...@gentoo.org wrote: Maybe, a good solution is to introduce a special arch, noarch, for such packages (similar to what's done in the rpm world). Then, if a package is ~noarch, it is automatically considered ~arch for all arches. Similar for stable. The

Add a KEYWORD representing any arch (was: Re: [gentoo-dev] rfc: revisiting our stabilization policy)

2014-01-19 Thread Pacho Ramos
El dom, 19-01-2014 a las 03:36 -0500, Mike Frysinger escribió: On Friday 17 January 2014 02:02:51 gro...@gentoo.org wrote: Maybe, a good solution is to introduce a special arch, noarch, for such packages (similar to what's done in the rpm world). Then, if a package is ~noarch, it is

[gentoo-dev] Re: Add a KEYWORD representing any arch

2014-01-19 Thread Ulrich Mueller
On Sun, 19 Jan 2014, Pacho Ramos wrote: El dom, 19-01-2014 a las 03:36 -0500, Mike Frysinger escribió: you mean * ? this already works today (at least with portage): KEYWORDS=~* KEYWORDS=* Currently not allowed by policy: http://devmanual.gentoo.org/keywording/index.html I had

Re: Add a KEYWORD representing any arch (was: Re: [gentoo-dev] rfc: revisiting our stabilization policy)

2014-01-19 Thread Mike Frysinger
On Sunday 19 January 2014 04:28:33 Pacho Ramos wrote: El dom, 19-01-2014 a las 03:36 -0500, Mike Frysinger escribió: On Friday 17 January 2014 02:02:51 gro...@gentoo.org wrote: Maybe, a good solution is to introduce a special arch, noarch, for such packages (similar to what's done in the

Re: [gentoo-dev] Last rites: sys-apps/usleep

2014-01-19 Thread Amadeusz Żołnowski
Dion Moult mo...@gentoo.org writes: # Dion Moult mo...@gentoo.org (19 Jan 2014) # Mask for removal in 30 days. usleep is actually provided part of # app-admin/killproc (bug #467212) sys-apps/usleep Veto. app-admin/killproc isn't even keyworded, yet. (Bug #494254). -- Amadeusz Żołnowski

Re: [gentoo-dev] Last rites: sys-apps/usleep

2014-01-19 Thread Dion Moult
Reverted. Amadeusz Żołnowski aide...@gentoo.org wrote: Dion Moult mo...@gentoo.org writes: # Dion Moult mo...@gentoo.org (19 Jan 2014) # Mask for removal in 30 days. usleep is actually provided part of # app-admin/killproc (bug #467212) sys-apps/usleep Veto. app-admin/killproc isn't even

Re: [gentoo-dev] Re: Add a KEYWORD representing any arch

2014-01-19 Thread Pacho Ramos
El dom, 19-01-2014 a las 10:46 +0100, Ulrich Mueller escribió: On Sun, 19 Jan 2014, Pacho Ramos wrote: El dom, 19-01-2014 a las 03:36 -0500, Mike Frysinger escribió: you mean * ? this already works today (at least with portage): KEYWORDS=~* KEYWORDS=* Currently not

[gentoo-dev] glibc-2.18 heading to ~arch in next ~week

2014-01-19 Thread Mike Frysinger
with glibc-2.17 in stable now and glibc-2.19 release in like ~2 weeks, glibc 2.18 is heading to ~arch. there's been very little reported breakage reported thus far ... i hope it's because there isn't any vs people aren't using it. so if people want to try it out ahead of time, that'd be nice.

Re: [gentoo-dev] rfc: revisiting our stabilization policy

2014-01-19 Thread Thomas Sachau
William Hubbs schrieb: When you say drop keywords do you mean: 1) revert the old version back to ~arch or 2) remove the old version. As a maintainer, I would rather do 2, because I do not want to backport fixes to the old version. William With 1) users would still be using newer

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-lang/ocaml/files: ocaml-4.01.0-pkg-config-ncurses.patch ocaml-3.11.2-Fix-ocamlopt-w.r.t.-binutils-2.21.patch

2014-01-19 Thread Alexis Ballier
please check with maintainers, ie in this case me, before jumping in and pushing, straight to stable, patches to the known to be fragile core part of a whole herd... reviews below On Sat, 18 Jan 2014 13:12:48 + (UTC) Mark Wright (gienah) gie...@gentoo.org wrote: gienah 14/01/18

Re: [gentoo-dev] rfc: formally allow qa to suspend commit rights

2014-01-19 Thread hasufell
either the QA lead or two members of the QA team can require the Infra team to temporarily suspend commit access for the developer -1 to that part That sounds like you are able to make non-trivial decisions without the approval of the lead.

Re: [gentoo-dev] glibc-2.18 heading to ~arch in next ~week

2014-01-19 Thread Robin H. Johnson
On Sun, Jan 19, 2014 at 05:52:48AM -0500, Mike Frysinger wrote: with glibc-2.17 in stable now and glibc-2.19 release in like ~2 weeks, glibc 2.18 is heading to ~arch. there's been very little reported breakage reported thus far ... i hope it's because there isn't any vs people aren't using

Re: [gentoo-dev] rfc: formally allow qa to suspend commit rights

2014-01-19 Thread Denis Dupeyron
On Sat, Jan 18, 2014 at 10:02 PM, William Hubbs willi...@gentoo.org wrote: This is nothing new; the qa team has requested that commit rights be suspended before. I am just proposing that we actually add the parts of the old patch to the glep that spell out when and how this can happen.

Re: [gentoo-dev] rfc: revisiting our stabilization policy

2014-01-19 Thread Christopher Head
On Thu, 16 Jan 2014 23:44:42 +0100 Tom Wijsman tom...@gentoo.org wrote: If I don’t, why do I care if the package is a year old? I lose none of my time to use the old version, since it does all I want; This is under the assumption that the old version has no further implications, which is

Re: [gentoo-dev] RFC: Hosting daily gx86 squashfs images and deltas

2014-01-19 Thread Christopher Head
On Fri, 17 Jan 2014 19:53:44 +0100 Michał Górny mgo...@gentoo.org wrote: Dnia 2014-01-17, o godz. 10:18:58 Alec Warner anta...@gentoo.org napisał(a): On Fri, Jan 17, 2014 at 8:27 AM, Michał Górny mgo...@gentoo.org wrote: Hello, all. I'm using squashfs to hold my Gentoo

[gentoo-dev] Automated Package Removal and Addition Tracker, for the week ending 2014-01-19 23h59 UTC

2014-01-19 Thread Robin H. Johnson
The attached list notes all of the packages that were added or removed from the tree, for the week ending 2014-01-19 23h59 UTC. Removals: app-office/rabbit 2014-01-13 02:33:48 mrueg app-i18n/rskkserv 2014-01-13 02:35:05 mrueg dev-ruby/postgres

Re: [gentoo-dev] rfc: revisiting our stabilization policy

2014-01-19 Thread Tom Wijsman
On Sun, 19 Jan 2014 14:31:57 -0800 Christopher Head ch...@chead.ca wrote: Right, of course things can become incompatible—but the distro handles that by either leaving old enough version of e.g. libraries around that the latest stable versions of their reverse dependencies don’t break, or, in

Re: [gentoo-dev] rfc: formally allow qa to suspend commit rights

2014-01-19 Thread Tom Wijsman
On Sun, 19 Jan 2014 13:22:07 -0700 Denis Dupeyron calc...@gentoo.org wrote: On Sat, Jan 18, 2014 at 10:02 PM, William Hubbs willi...@gentoo.org wrote: This is nothing new; the qa team has requested that commit rights be suspended before. I am just proposing that we actually add the parts

Re: [gentoo-dev] rfc: formally allow qa to suspend commit rights

2014-01-19 Thread Tom Wijsman
On Sun, 19 Jan 2014 13:46:01 +0100 hasufell hasuf...@gentoo.org wrote: either the QA lead or two members of the QA team can require the Infra team to temporarily suspend commit access for the developer -1 to that part That sounds like you are able to make non-trivial decisions without

Re: [gentoo-dev] rfc: formally allow qa to suspend commit rights

2014-01-19 Thread Denis Dupeyron
On Sun, Jan 19, 2014 at 6:01 PM, Tom Wijsman tom...@gentoo.org wrote: It is more of a Do we want QA to delegate this through ComRel or not?. Actually, no. What it is is a Subject was thoroughly discussed in the past, and a decision was made. More than once, in fact. What basis do you have that

Re: [gentoo-dev] rfc: formally allow qa to suspend commit rights

2014-01-19 Thread Alec Warner
On Sat, Jan 18, 2014 at 9:02 PM, William Hubbs willi...@gentoo.org wrote: All, I would like to bring back for discussion an old patch to glep 48 [1] which was suggested by Jorge [2]. That patch evolved into this one [3], and in the council meeting back then [4], parts of it made their way

Re: [gentoo-dev] rfc: formally allow qa to suspend commit rights

2014-01-19 Thread Tom Wijsman
On Sun, 19 Jan 2014 18:22:39 -0700 Denis Dupeyron calc...@gentoo.org wrote: On Sun, Jan 19, 2014 at 6:01 PM, Tom Wijsman tom...@gentoo.org wrote: It is more of a Do we want QA to delegate this through ComRel or not?. Actually, no. What it is is a Subject was thoroughly discussed in the

Re: [gentoo-dev] rfc: formally allow qa to suspend commit rights

2014-01-19 Thread Tom Wijsman
On Sun, 19 Jan 2014 17:24:30 -0800 Alec Warner anta...@gentoo.org wrote: We almost never suspend commit rights. I'm not really finding a situation where this is necessary. Certainly not in the streamlined fashion proposed here. Well, the QA team has been inactive for a while; so, I guess this

Re: [gentoo-dev] glibc-2.18 heading to ~arch in next ~week

2014-01-19 Thread Mike Frysinger
On Sunday 19 January 2014 13:07:24 Robin H. Johnson wrote: On Sun, Jan 19, 2014 at 05:52:48AM -0500, Mike Frysinger wrote: with glibc-2.17 in stable now and glibc-2.19 release in like ~2 weeks, glibc 2.18 is heading to ~arch. there's been very little reported breakage reported thus far ...

[gentoo-dev] ekeyword written in python from scratch

2014-01-19 Thread Mike Frysinger
i finally got annoyed with the perl version (and its output and bugs and limitations) and wrote a new version. it's fairly modular (and has pretty good unittest coverage!?), so if we wanted to look at integrating it into portage or other tools, that should be pretty easy now. at any rate, if

[gentoo-dev] updated s390 VMs

2014-01-19 Thread Mike Frysinger
the awesome folks at Marist College in conjunction with the Linux Foundation have upgraded our s390 VMs to newer hardware. faster/more CPUs, more RAM, and more disk space. it's at the point where we aren't hurting to simply build packages. so if devs are interested in ssh access, feel free

[gentoo-dev] new profiles.desc header documenting profile/keyword policy

2014-01-19 Thread Mike Frysinger
this has all been fairly ad-hoc in the past, so formalize it in the one place that impacts everyone -- profiles.desc. -mike ### # This is a list of valid profiles for each architecture. This file is used by # repoman

Re: [gentoo-portage-dev] [PATCH 1/3] emerge: Deprecate --autounmask

2014-01-19 Thread Pacho Ramos
El dom, 19-01-2014 a las 01:21 +0100, Alexander Berntsen escribió: Remove the --autounmask option from emerge. Please note that removing the option does not mean that the variable used for keeping track of autounmasking is not removed from depgraph.py. If I understand the change correctly (I

Re: [gentoo-portage-dev] Signing off patches

2014-01-19 Thread Mike Frysinger
On Saturday 18 January 2014 17:57:38 Tom Wijsman wrote: On Sat, 18 Jan 2014 08:43:12 -0800 W. Trevor King wrote: On Sat, Jan 18, 2014 at 04:02:02PM +0100, Tom Wijsman wrote: I think the idea is that you shouldn't need to refer to an external resource like the mailing list to understand the

Re: [gentoo-portage-dev] Bugzilla workflow

2014-01-19 Thread Mike Frysinger
On Tuesday 14 January 2014 21:58:38 Tom Wijsman wrote: On Sun, 05 Jan 2014 15:42:48 -0800 Brian Dolbec wrote: 2) start working on a solution, a) if you have significant progress, but need more time, mark it accordingly, assign it to yourself, leave a comment, etc. Assigning it

Re: [gentoo-portage-dev] [PATCH v3] Test for read-only filesystems, bail out during preinst if there are any which will be written to and display a useful error message. Fixes bug 378869.

2014-01-19 Thread Mike Frysinger
On Saturday 18 January 2014 21:00:48 Chris Reffett wrote: --- /dev/null +++ b/pym/portage/util/rochecker.py @@ -0,0 +1,81 @@ +#-*- coding:utf-8 -*- +# Copyright 2014 Gentoo Foundation +# Distributed under the terms of the GNU General Public License v2 + +Methods to check whether Portage is

Re: [gentoo-portage-dev] [PATCH 2/3] emerge: Rename --autounmask-write to --autounmask

2014-01-19 Thread Mike Frysinger
On Saturday 18 January 2014 19:21:11 Alexander Berntsen wrote: Rename --autounmask-write to --autounmask. typically when we delete/rename an option, we give users a heads up. that means a cycle where the old option exists but emits a warning before switching to the new one. then we can

Re: [gentoo-portage-dev] [PATCH v4] Add repoman check to warn if src_prepare/src_configure are used in EAPI 0/1 and if pkg_pretend is used in EAPI 4. Fixes bug 379491.

2014-01-19 Thread Mike Frysinger
Acked-by: Mike Frysinger vap...@gentoo.org btw you should keep the patch summary short. if it goes long, better to move it to the main body. -mike signature.asc Description: This is a digitally signed message part.

Re: [gentoo-portage-dev] [PATCH 3/3] Have repoman deprecate G2CONF for the GNOME team. (bug #482084).

2014-01-19 Thread Mike Frysinger
On Wednesday 15 January 2014 19:07:20 Tom Wijsman wrote: +class DeprecateG2CONF(LineCheck): + repoman_check_name = 'G2CONF.deprecated' + re = re.compile(r'.*G2CONF.*') + + def check(self, num, line): + Run the check on line and return error if there is one +

Re: [gentoo-portage-dev] [PATCH 3/3] Have repoman deprecate G2CONF for the GNOME team. (bug #482084).

2014-01-19 Thread Mike Frysinger
btw, suggestion for commit summary/message: repoman: deprecate G2CONF Deprecate the G2CONF variable as requested by the GNOME team. URL: http://bugs.gentoo.org/482084 -mike signature.asc Description: This is a digitally signed message part.

Re: [gentoo-portage-dev] [PATCH 1/3 v2] Have repoman check if the packages to unpack rare archive formats from SRC_URI are present in DEPEND (bug #205909).

2014-01-19 Thread Mike Frysinger
On Friday 17 January 2014 18:03:57 Tom Wijsman wrote: --- please shorten your commit summary and move more content to the body +getNonSystemArchiveDepends.archivers = { it is super weird to attach to the object like this. some might even say wrong. move it into the class definition. def

Re: [gentoo-portage-dev] [PATCH] Add repoman check to warn if src_prepare/src_configure are used in EAPI 0/1

2014-01-19 Thread Mike Frysinger
On Tuesday 14 January 2014 16:15:48 Tom Wijsman wrote: On Mon, 13 Jan 2014 23:59:11 -0500 Mike Frysinger wrote: we probably should just use dev branches in the main repo, at least for people who have write access to the repo dev/$USERNAME/whatever you want To be more clear, which

Re: [gentoo-portage-dev] [PATCH 1/3] emerge: Deprecate --autounmask

2014-01-19 Thread Alexander Berntsen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 19/01/14 11:23, Alexander Berntsen wrote: emerge --ask foo # This won't -write emerge --autounmask --pretend foo # Same as the above Sorry, the comments here are imprecise. The first-mentioned will *prompt* the user for writing the changes. The

Re: [gentoo-portage-dev] [PATCH 1/3] emerge: Deprecate --autounmask

2014-01-19 Thread Pacho Ramos
El dom, 19-01-2014 a las 11:23 +0100, Alexander Berntsen escribió: On 19/01/14 09:01, Pacho Ramos wrote: If I understand the change correctly (I don't know much about python but, but per the diff, looks like you are dropping the option and making the code behave like it's always 'True'),

Re: [gentoo-portage-dev] [PATCH v3] Test for read-only filesystems, bail out during preinst if there are any which will be written to and display a useful error message. Fixes bug 378869.

2014-01-19 Thread Alexander Berntsen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 19/01/14 10:17, Mike Frysinger wrote: prefer OSes - OS's That's just not proper English. It makes no sense. Please don't prefer that. If for nothing else, then to prevent me from sighing whenever I have to read it. not a new issue, but we

Re: [gentoo-portage-dev] [PATCH 2/3] emerge: Rename --autounmask-write to --autounmask

2014-01-19 Thread Alexander Berntsen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 19/01/14 10:20, Mike Frysinger wrote: typically when we delete/rename an option, we give users a heads up. that means a cycle where the old option exists but emits a warning before switching to the new one. then we can delete it. We should

Re: [gentoo-portage-dev] [PATCH] Add repoman check to warn if src_prepare/src_configure are used in EAPI 0/1

2014-01-19 Thread Mike Gilbert
On Sun, Jan 19, 2014 at 4:44 AM, Mike Frysinger vap...@gentoo.org wrote: Chromium OS for a long time was restricted to EAPI 4 for two reasons -- it had an old portage version (and upgrading to a newer one regressed performance significantly, so we held off until we could figure out why) I am

Re: [gentoo-portage-dev] [PATCH 1/3] emerge: Deprecate --autounmask

2014-01-19 Thread Alexander Berntsen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 19/01/14 17:49, Mike Gilbert wrote: Please give me a way to shut off autounmask entirely no mater what other options I pass to emerge. Tying it to --ask with no way to disable it is not acceptable. - --autounmask=n should do this. I messed

[gentoo-portage-dev] [PATCH] Implement FEATURES=mirror for emerge (bug 498498)

2014-01-19 Thread Sebastian Luther
This was only implemented for the ebuild command before. --- pym/_emerge/Scheduler.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pym/_emerge/Scheduler.py b/pym/_emerge/Scheduler.py index d663e97..2fd4d7e 100644 --- a/pym/_emerge/Scheduler.py +++

Re: [gentoo-portage-dev] [PATCH] Implement FEATURES=mirror for emerge (bug 498498)

2014-01-19 Thread Sebastian Luther
The removed white space was unintentional. Please remove that change before committing that patch.

Re: [gentoo-portage-dev] [PATCH 0/3] Initial fetch() refactoring

2014-01-19 Thread Sebastian Luther
Am 19.01.2014 04:07, schrieb W. Trevor King: I felt like I should actually make a useful contribution to balance the less useful commit-message discussion ;). Browsing through the open Portage bugs, #175612 looked interesting. After I looked at pym/portage/package/ebuild/fetch.py, I decided

Re: [gentoo-portage-dev] [PATCH 0/3] Initial fetch() refactoring

2014-01-19 Thread W. Trevor King
On Sun, Jan 19, 2014 at 09:05:41PM +0100, Sebastian Luther wrote: Am 19.01.2014 04:07, schrieb W. Trevor King: The patches aren't particularly well tested yet. I ran the test suite and got some errors, but they seemed to be related to my non-root invocation, and not due to these changes

Re: [gentoo-portage-dev] [PATCH 3/3] pym/portage/package/ebuild/fetch.py: Factor out _get_uris

2014-01-19 Thread Sebastian Luther
Am 19.01.2014 04:07, schrieb W. Trevor King: +def _get_uris(uris, settings, custom_mirrors=(), locations=()): missing doc string

Re: [gentoo-portage-dev] [PATCH 0/3] Initial fetch() refactoring

2014-01-19 Thread Sebastian Luther
Am 19.01.2014 04:07, schrieb W. Trevor King: The patches aren't particularly well tested yet. I ran the test suite and got some errors, but they seemed to be related to my non-root invocation, and not due to these changes themselves. I thought I'd post my work so far, before digging deeper

[gentoo-portage-dev] [PATCH v2 2/3] pym/portage/package/ebuild/fetch.py: Factor out _get_fetch_resume_size

2014-01-19 Thread W. Trevor King
The current fetch() function is quite long, which makes it hard to know what I can change without adverse side effects. By pulling this logic out of the main function, we get clearer logic in fetch() and more explicit input for the config extraction. --- pym/portage/package/ebuild/fetch.py | 50

[gentoo-portage-dev] [PATCH v2 0/3] Initial fetch() refactoring

2014-01-19 Thread W. Trevor King
Following Sebastian's pyflakes and testing suggestions turned up a few bugs in the _get_uris patch. Changes since v1: Patch #1: * Fixed: summary to: summary and converted some from tabs to spaces where I'd missed them in v1. Patch #3: * Fixed docstrings as for patch

[gentoo-portage-dev] [PATCH v2 3/3] pym/portage/package/ebuild/fetch.py: Factor out _get_uris

2014-01-19 Thread W. Trevor King
The current fetch() function is quite long, which makes it hard to know what I can change without adverse side effects. By pulling this logic out of the main function, we get clearer logic in fetch() and more explicit input for the config extraction. This block was especially complicated, so I

[gentoo-portage-dev] [PATCH v2 1/3] pym/portage/package/ebuild/fetch.py: Factor out _get_checksum_failure_max_tries

2014-01-19 Thread W. Trevor King
The current fetch() function is quite long, which makes it hard to know what I can change without adverse side effects. By pulling this logic out of the main function, we get clearer logic in fetch() and more explicit input for the config extraction. --- pym/portage/package/ebuild/fetch.py | 59

Re: [gentoo-portage-dev] [PATCH 3/3] pym/portage/package/ebuild/fetch.py: Factor out _get_uris

2014-01-19 Thread Alec Warner
On Sat, Jan 18, 2014 at 7:07 PM, W. Trevor King wk...@tremily.us wrote: The current fetch() function is quite long, which makes it hard to know what I can change without adverse side effects. By pulling this logic out of the main function, we get clearer logic in fetch() and more explicit

Re: [gentoo-portage-dev] [PATCH v2 1/3] pym/portage/package/ebuild/fetch.py: Factor out _get_checksum_failure_max_tries

2014-01-19 Thread Alec Warner
On Sun, Jan 19, 2014 at 2:44 PM, Alec Warner anta...@gentoo.org wrote: On Sun, Jan 19, 2014 at 2:14 PM, W. Trevor King wk...@tremily.us wrote: The current fetch() function is quite long, which makes it hard to know what I can change without adverse side effects. By pulling this logic out of

Re: [gentoo-portage-dev] [PATCH 0/3] Initial fetch() refactoring

2014-01-19 Thread Alexander Berntsen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 19/01/14 22:22, Sebastian Luther wrote: The usual doc string style used in portage is: text Please use that for new functions. Also make sure you don't use spaces to indent the last . As mentioned by Mike in another thread, we should

Re: [gentoo-portage-dev] [PATCH 0/3] Initial fetch() refactoring

2014-01-19 Thread Alec Warner
On Sun, Jan 19, 2014 at 2:45 PM, Alexander Berntsen alexan...@plaimi.netwrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 19/01/14 22:22, Sebastian Luther wrote: The usual doc string style used in portage is: text Please use that for new functions. Also make sure you don't

Re: [gentoo-portage-dev] [PATCH 0/3] Initial fetch() refactoring

2014-01-19 Thread Alexander Berntsen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 19/01/14 23:46, Alec Warner wrote: Does pylint or pyflakes point out if you mess it up? Not very successfully in my experience. - -- Alexander alexan...@plaimi.net http://plaimi.net/~alexander -BEGIN PGP SIGNATURE- Version: GnuPG

Re: [gentoo-portage-dev] [PATCH v2 1/3] pym/portage/package/ebuild/fetch.py: Factor out _get_checksum_failure_max_tries

2014-01-19 Thread W. Trevor King
On Sun, Jan 19, 2014 at 02:45:24PM -0800, Alec Warner wrote: On Sun, Jan 19, 2014 at 2:44 PM, Alec Warner anta...@gentoo.org wrote: This function and the next function you wrote are identical. How about making a single function? … def getIntValueFromSettings(settings, key, default):

Re: [gentoo-portage-dev] [PATCH 0/3] Initial fetch() refactoring

2014-01-19 Thread Alec Warner
On Sun, Jan 19, 2014 at 2:50 PM, Alexander Berntsen alexan...@plaimi.netwrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 19/01/14 23:46, Alec Warner wrote: Does pylint or pyflakes point out if you mess it up? Not very successfully in my experience. I'm very against add a bunch

Re: [gentoo-portage-dev] [PATCH 3/3] pym/portage/package/ebuild/fetch.py: Factor out _get_uris

2014-01-19 Thread W. Trevor King
On Sun, Jan 19, 2014 at 02:36:43PM -0800, Alec Warner wrote: On Sat, Jan 18, 2014 at 7:07 PM, W. Trevor King wk...@tremily.us wrote: +def _get_file_uri_tuples(uris): + Return a list of (filename, uri) tuples + As mike noted on another thread: Return a list of (filename,

Re: [gentoo-portage-dev] [PATCH 3/3] pym/portage/package/ebuild/fetch.py: Factor out _get_uris

2014-01-19 Thread W. Trevor King
On Sun, Jan 19, 2014 at 03:06:29PM -0800, W. Trevor King wrote: On Sun, Jan 19, 2014 at 02:36:43PM -0800, Alec Warner wrote: On Sat, Jan 18, 2014 at 7:07 PM, W. Trevor King wk...@tremily.us wrote: + # Order primaryuri_dict values to match that in SRC_URI. + for uris in

Re: [gentoo-portage-dev] [PATCH 0/3] Initial fetch() refactoring

2014-01-19 Thread Alexander Berntsen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 19/01/14 23:54, Alec Warner wrote: I'm very against add a bunch of extra rules that have to be enforced by hand. I want to make it easy to contribute, not more difficult. If bob can run a tool that tells him all the things that are wrong

Re: [gentoo-portage-dev] [PATCH 0/3] Initial fetch() refactoring

2014-01-19 Thread Alec Warner
On Sun, Jan 19, 2014 at 3:51 PM, Alexander Berntsen alexan...@plaimi.netwrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 19/01/14 23:54, Alec Warner wrote: I'm very against add a bunch of extra rules that have to be enforced by hand. I want to make it easy to contribute, not more

Re: [gentoo-portage-dev] [PATCH 1/3] pym/portage/package/ebuild/fetch.py: Factor out _get_checksum_failure_max_tries

2014-01-19 Thread Tom Wijsman
On Sat, 18 Jan 2014 19:07:45 -0800 W. Trevor King wk...@tremily.us wrote: [...SNIP...] + v = int(settings.get(PORTAGE_FETCH_CHECKSUM_TRY_MIRRORS, + default)) + except (ValueError, OverflowError): + writemsg(_(!!! Variable

Re: [gentoo-portage-dev] [PATCH 2/3] pym/portage/package/ebuild/fetch.py: Factor out _get_fetch_resume_size

2014-01-19 Thread Tom Wijsman
On Sat, 18 Jan 2014 19:07:46 -0800 W. Trevor King wk...@tremily.us wrote: +def _get_fetch_resume_size(settings, default='350K'): + v = settings.get(PORTAGE_FETCH_RESUME_MIN_SIZE) + if v is not None: + v = .join(v.split()) + if not v: + #

Re: [gentoo-portage-dev] [PATCH 1/3] pym/portage/package/ebuild/fetch.py: Factor out _get_checksum_failure_max_tries

2014-01-19 Thread W. Trevor King
On Mon, Jan 20, 2014 at 02:26:59AM +0100, Tom Wijsman wrote: On Sat, 18 Jan 2014 19:07:45 -0800 W. Trevor King wk...@tremily.us wrote: [...SNIP...] + v = int(settings.get(PORTAGE_FETCH_CHECKSUM_TRY_MIRRORS, + default)) … The code screams

Re: [gentoo-portage-dev] [PATCH 2/3] pym/portage/package/ebuild/fetch.py: Factor out _get_fetch_resume_size

2014-01-19 Thread W. Trevor King
On Mon, Jan 20, 2014 at 02:41:41AM +0100, Tom Wijsman wrote: There is some duplicate code here, I think the conditions can be rewritten in such way that the duplicate code doesn't take place. Do you want a rewrite squashed into this commit, or as a follow-on commit after this one (which gets a

Re: [gentoo-portage-dev] Signing off patches

2014-01-19 Thread Tom Wijsman
On Sat, 18 Jan 2014 20:15:57 -0800 W. Trevor King wk...@tremily.us wrote: On Sun, Jan 19, 2014 at 02:33:06AM +0100, Tom Wijsman wrote: On Sat, 18 Jan 2014 15:24:59 -0800 W. Trevor King wk...@tremily.us wrote: If it doesn't need to get updated, then it probably already started out

Re: [gentoo-portage-dev] [PATCH 2/3] pym/portage/package/ebuild/fetch.py: Factor out _get_fetch_resume_size

2014-01-19 Thread Tom Wijsman
On Sun, 19 Jan 2014 18:01:23 -0800 W. Trevor King wk...@tremily.us wrote: On Mon, Jan 20, 2014 at 02:41:41AM +0100, Tom Wijsman wrote: There is some duplicate code here, I think the conditions can be rewritten in such way that the duplicate code doesn't take place. Do you want a rewrite

Re: [gentoo-portage-dev] Signing off patches

2014-01-19 Thread W. Trevor King
On Mon, Jan 20, 2014 at 03:09:14AM +0100, Tom Wijsman wrote: On Sat, 18 Jan 2014 20:15:57 -0800 W. Trevor King wrote: On Sun, Jan 19, 2014 at 02:33:06AM +0100, Tom Wijsman wrote: On Sat, 18 Jan 2014 15:24:59 -0800 W. Trevor King wrote: If it doesn't need to get updated, then it probably

Re: [gentoo-portage-dev] [PATCH 1/3 v2] Have repoman check if the packages to unpack rare archive formats from SRC_URI are present in DEPEND (bug #205909).

2014-01-19 Thread Alec Warner
On Sun, Jan 19, 2014 at 6:23 PM, Tom Wijsman tom...@gentoo.org wrote: On Sun, 19 Jan 2014 04:38:31 -0500 Mike Frysinger vap...@gentoo.org wrote: On Friday 17 January 2014 18:03:57 Tom Wijsman wrote: --- please shorten your commit summary and move more content to the body Right, I'm

[gentoo-portage-dev] [PATCH v3 1/4] pym/portage/package/ebuild/fetch.py: Factor out _get_checksum_failure_max_tries

2014-01-19 Thread W. Trevor King
The current fetch() function is quite long, which makes it hard to know what I can change without adverse side effects. By pulling this logic out of the main function, we get clearer logic in fetch() and more explicit input for the config extraction. Following a suggestion by Tom Wijsman, I put

[gentoo-portage-dev] [PATCH v3 4/4] pym/portage/package/ebuild/fetch.py: Flatten conditionals in _get_fetch_resume_size

2014-01-19 Thread W. Trevor King
Make this easier to read by avoiding nested conditionals [1]. [1]: http://article.gmane.org/gmane.linux.gentoo.portage.devel/4058 Reported-by: Tom Wijsman tom...@gentoo.org --- pym/portage/package/ebuild/fetch.py | 30 ++ 1 file changed, 14 insertions(+), 16

Re: [gentoo-portage-dev] [PATCH 2/3] emerge: Rename --autounmask-write to --autounmask

2014-01-19 Thread Mike Frysinger
On Sunday 19 January 2014 05:48:33 Alexander Berntsen wrote: On 19/01/14 10:20, Mike Frysinger wrote: typically when we delete/rename an option, we give users a heads up. that means a cycle where the old option exists but emits a warning before switching to the new one. then we can delete

Re: [gentoo-portage-dev] [PATCH] Add repoman check to warn if src_prepare/src_configure are used in EAPI 0/1

2014-01-19 Thread Mike Frysinger
On Sunday 19 January 2014 11:59:36 Mike Gilbert wrote: On Sun, Jan 19, 2014 at 4:44 AM, Mike Frysinger vap...@gentoo.org wrote: Chromium OS for a long time was restricted to EAPI 4 for two reasons -- it had an old portage version (and upgrading to a newer one regressed performance

Re: [gentoo-portage-dev] [PATCH] Add repoman check to warn if src_prepare/src_configure are used in EAPI 0/1

2014-01-19 Thread Alec Warner
On Sun, Jan 19, 2014 at 9:47 PM, Mike Frysinger vap...@gentoo.org wrote: On Sunday 19 January 2014 11:59:36 Mike Gilbert wrote: On Sun, Jan 19, 2014 at 4:44 AM, Mike Frysinger vap...@gentoo.org wrote: Chromium OS for a long time was restricted to EAPI 4 for two reasons -- it had an old

Re: [gentoo-portage-dev] [PATCH] Add repoman check to warn if src_prepare/src_configure are used in EAPI 0/1

2014-01-19 Thread Mike Frysinger
On Monday 20 January 2014 01:02:31 Alec Warner wrote: Are you still doing crazy crap like disabling all of the portage locking? ;p yes no. we make sure we hold the right locks and don't do operations that otherwise cause problems. then we disable the core lock grabbing :P. the current