Re: [PR] HIVE-29050: Optimize the partition validation in add_partitions [hive]

deniskuzZ commented on code in PR #5910: URL: https://github.com/apache/hive/pull/5910#discussion_r2176576498 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ## @@ -4319,19 +4320,30 @@ private List add_partitions_core(fina

Re: [PR] HIVE-29050: Optimize the partition validation in add_partitions [hive]

deniskuzZ commented on code in PR #5910: URL: https://github.com/apache/hive/pull/5910#discussion_r2176576498 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ## @@ -4319,19 +4320,30 @@ private List add_partitions_core(fina

Re: [PR] HIVE-28667: Error initializing field trimmer instance when starting HS2 (#5879) [hive]

sonarqubecloud[bot] commented on PR #5913: URL: https://github.com/apache/hive/pull/5913#issuecomment-3022045861 ## [](https://sonarcl

Re: [PR] HIVE-29052: Error starting standalone HMS: 'IcebergHouseKeeperServiceclass not found' [hive]

zhangbutao commented on PR #5912: URL: https://github.com/apache/hive/pull/5912#issuecomment-3022060192 Build failed with maven issue `Connect to repository.apache.org:443 [repository.apache.org/37.27.138.133] failed`: ``` [INFO] --

Re: [PR] Add release workflow for HMS docker image [hive]

zhangbutao commented on code in PR #5899: URL: https://github.com/apache/hive/pull/5899#discussion_r2176533453 ## standalone-metastore/metastore-server/pom.xml: ## @@ -492,10 +492,13 @@ - dist - - - docker +add-extra-deps + +

Re: [PR] HIVE-29052: Error starting standalone HMS: 'IcebergHouseKeeperServiceclass not found' [hive]

sonarqubecloud[bot] commented on PR #5912: URL: https://github.com/apache/hive/pull/5912#issuecomment-3021795402 ## [](https://sonarcl

[PR] HIVE-28667: Error initializing field trimmer instance when starting HS2 (#5879) [hive]

zhangbutao opened a new pull request, #5913: URL: https://github.com/apache/hive/pull/5913 ### What changes were proposed in this pull request? ### Why are the changes needed? A cherry-pick for HIVE-28667. Although this patch is a relatively minor

Re: [PR] HIVE-29052: Error starting standalone HMS: 'IcebergHouseKeeperServiceclass not found' [hive]

zhangbutao commented on code in PR #5912: URL: https://github.com/apache/hive/pull/5912#discussion_r2176384535 ## standalone-metastore/metastore-server/src/docker/build.sh: ## @@ -101,6 +101,7 @@ fi cp "$CACHE_DIR/hadoop-$HADOOP_VERSION.tar.gz" "$WORK_DIR/" cp -R "$SOURCE_DI

Re: [PR] HIVE-29052: Error starting standalone HMS: 'IcebergHouseKeeperServiceclass not found' [hive]

zhangbutao commented on code in PR #5912: URL: https://github.com/apache/hive/pull/5912#discussion_r2176384262 ## standalone-metastore/metastore-server/src/docker/build.sh: ## @@ -101,6 +101,7 @@ fi cp "$CACHE_DIR/hadoop-$HADOOP_VERSION.tar.gz" "$WORK_DIR/" cp -R "$SOURCE_DI

Re: [PR] HIVE-22810: Add drop scheduled query IF EXISTS support [hive]

sonarqubecloud[bot] commented on PR #5911: URL: https://github.com/apache/hive/pull/5911#issuecomment-3021665890 ## [](https://sonarcl

Re: [PR] HIVE-28736:Remove DFS_URI authorization for CREATE_TABLE event with n… [hive]

rtrivedi12 commented on PR #5689: URL: https://github.com/apache/hive/pull/5689#issuecomment-3021645569 @saihemanth-cloudera / @nrg4878 Can you please help merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] HIVE-29028: Iceberg: Implement auto compaction [hive]

difin commented on code in PR #5886: URL: https://github.com/apache/hive/pull/5886#discussion_r2176337122 ## itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestIcebergCompactorOnTez.java: ## @@ -21,66 +21,139 @@ import org.apache.hadoop.hive.metastore.Hi

Re: [PR] HIVE-29028: Iceberg: Implement auto compaction [hive]

difin commented on code in PR #5886: URL: https://github.com/apache/hive/pull/5886#discussion_r2176337122 ## itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestIcebergCompactorOnTez.java: ## @@ -21,66 +21,139 @@ import org.apache.hadoop.hive.metastore.Hi

Re: [PR] HIVE-29028: Iceberg: Implement auto compaction [hive]

difin commented on code in PR #5886: URL: https://github.com/apache/hive/pull/5886#discussion_r2176337122 ## itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestIcebergCompactorOnTez.java: ## @@ -21,66 +21,139 @@ import org.apache.hadoop.hive.metastore.Hi

[PR] HIVE-29052: Error starting standalone HMS: 'IcebergHouseKeeperServiceclass not found' [hive]

zhangbutao opened a new pull request, #5912: URL: https://github.com/apache/hive/pull/5912 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How

Re: [PR] HIVE-29028: Iceberg: Implement auto compaction [hive]

difin commented on code in PR #5886: URL: https://github.com/apache/hive/pull/5886#discussion_r2176318613 ## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/TableOptimizer.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

Re: [PR] HIVE-29028: Iceberg: Implement auto compaction [hive]

difin commented on code in PR #5886: URL: https://github.com/apache/hive/pull/5886#discussion_r2176321347 ## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java: ## @@ -428,4 +286,24 @@ public void run() { public void enforceMutex(boolean enableMutex) { th

Re: [PR] HIVE-29028: Iceberg: Implement auto compaction [hive]

difin commented on code in PR #5886: URL: https://github.com/apache/hive/pull/5886#discussion_r2176326871 ## itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorOnTezTest.java: ## @@ -541,4 +543,23 @@ protected void dropTable(String tblName) throws Ex

Re: [PR] HIVE-29028: Iceberg: Implement auto compaction [hive]

difin commented on code in PR #5886: URL: https://github.com/apache/hive/pull/5886#discussion_r2176318222 ## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/AcidTableOptimizer.java: ## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

[PR] HIVE-22810: Add drop scheduled query IF EXISTS support [hive]

Neer393 opened a new pull request, #5911: URL: https://github.com/apache/hive/pull/5911 ### What changes were proposed in this pull request? The changes proposed adds support for IF EXISTS while dropping a Scheduled Query ### Why are the changes needed? User want

Re: [PR] HIVE-27473: Rewrite MetaStoreClients to be composable [hive]

ngsg commented on code in PR #5771: URL: https://github.com/apache/hive/pull/5771#discussion_r2176269578 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java: ## @@ -142,2416 +40,28 @@ * so the readers of the objects in these maps should have the m

Re: [PR] HIVE-27473: Rewrite MetaStoreClients to be composable [hive]

dengzhhu653 commented on code in PR #5771: URL: https://github.com/apache/hive/pull/5771#discussion_r2176224118 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java: ## @@ -142,2416 +40,28 @@ * so the readers of the objects in these maps should hav

Re: [PR] HIVE-29050: Optimize the partition validation in add_partitions [hive]

sonarqubecloud[bot] commented on PR #5910: URL: https://github.com/apache/hive/pull/5910#issuecomment-3021361693 ## [](https://sonarcl

Re: [PR] HIVE-28820: HMS might only creates the external directory and not the managed directory [hive]

github-actions[bot] closed pull request #5696: HIVE-28820: HMS might only creates the external directory and not the managed directory URL: https://github.com/apache/hive/pull/5696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] HIVE-29050: Optimize the partition validation in add_partitions [hive]

dengzhhu653 commented on code in PR #5910: URL: https://github.com/apache/hive/pull/5910#discussion_r2176161301 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ## @@ -4319,19 +4320,30 @@ private List add_partitions_core(fi

Re: [PR] HIVE-29050: Optimize the partition validation in add_partitions [hive]

dengzhhu653 commented on code in PR #5910: URL: https://github.com/apache/hive/pull/5910#discussion_r2176161301 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ## @@ -4319,19 +4320,30 @@ private List add_partitions_core(fi

Re: [PR] HIVE-29050: Optimize the partition validation in add_partitions [hive]

dengzhhu653 commented on PR #5910: URL: https://github.com/apache/hive/pull/5910#issuecomment-3021206520 Performance: java -jar hmsbench.jar --savedata /tmp/benchdata --sanitize -N 1000 -N 1 -o 0302bench_results_http_modified-1.csv -C -d testbench_http --params=100 -M 'addPartitions.

Re: [PR] HIVE-29050: Optimize the partition validation in add_partitions [hive]

dengzhhu653 commented on code in PR #5910: URL: https://github.com/apache/hive/pull/5910#discussion_r2176158742 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ## @@ -4319,19 +4320,30 @@ private List add_partitions_core(fi

Re: [PR] HIVE-29050: Optimize the partition validation in add_partitions [hive]

dengzhhu653 commented on code in PR #5910: URL: https://github.com/apache/hive/pull/5910#discussion_r2176158078 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ## @@ -4319,19 +4320,30 @@ private List add_partitions_core(fi

Re: [PR] HIVE-29050: Optimize the partition validation in add_partitions [hive]

dengzhhu653 commented on code in PR #5910: URL: https://github.com/apache/hive/pull/5910#discussion_r2176155484 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ## @@ -4836,74 +4827,6 @@ private void initializePartitionPara

Re: [PR] HIVE-29028: Iceberg: Implement auto compaction [hive]

sonarqubecloud[bot] commented on PR #5886: URL: https://github.com/apache/hive/pull/5886#issuecomment-3021013096 ## [](https://sonarcl

Re: [PR] HIVE-29016: fixing cache handling for REST catalog; [hive]

sonarqubecloud[bot] commented on PR #5882: URL: https://github.com/apache/hive/pull/5882#issuecomment-3020918534 ## [](https://sonarcl

Re: [PR] HIVE-29016: fixing cache handling for REST catalog; [hive]

henrib commented on code in PR #5882: URL: https://github.com/apache/hive/pull/5882#discussion_r2175641657 ## standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSEventListener.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] HIVE-29016: fixing cache handling for REST catalog; [hive]

henrib commented on code in PR #5882: URL: https://github.com/apache/hive/pull/5882#discussion_r2175597392 ## standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCatalogFactory.java: ## @@ -35,19 +38,33 @@ * Catalog & servlet factory. */ pub

Re: [PR] HIVE-28838: Remove sensitive jdbc properties from explain plan for JdbcStorageHandler tables [hive]

deniskuzZ merged PR #5709: URL: https://github.com/apache/hive/pull/5709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.

Re: [PR] HIVE-29028: Iceberg: Implement auto compaction [hive]

sonarqubecloud[bot] commented on PR #5886: URL: https://github.com/apache/hive/pull/5886#issuecomment-3020133039 ## [](https://sonarcl

Re: [PR] HIVE-29016: fixing cache handling for REST catalog; [hive]

deniskuzZ commented on code in PR #5882: URL: https://github.com/apache/hive/pull/5882#discussion_r2175569578 ## standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCatalogFactory.java: ## @@ -35,19 +38,33 @@ * Catalog & servlet factory. */

Re: [PR] HIVE-28790: ACID deletes are failing with ArrayIndexOutOfBoundsExcept… [hive]

deniskuzZ commented on code in PR #5901: URL: https://github.com/apache/hive/pull/5901#discussion_r2175550264 ## ql/src/test/queries/clientpositive/acid_direct_delete.q: ## @@ -0,0 +1,18 @@ +set hive.mapred.mode=nonstrict; +set hive.support.concurrency=true; +set hive.txn.manage

Re: [PR] HIVE-28790: ACID deletes are failing with ArrayIndexOutOfBoundsExcept… [hive]

kokila-19 commented on code in PR #5901: URL: https://github.com/apache/hive/pull/5901#discussion_r2175519616 ## ql/src/test/queries/clientpositive/acid_direct_delete.q: ## @@ -0,0 +1,18 @@ +set hive.mapred.mode=nonstrict; +set hive.support.concurrency=true; +set hive.txn.manage

Re: [PR] HIVE-28790: ACID deletes are failing with ArrayIndexOutOfBoundsExcept… [hive]

kokila-19 commented on code in PR #5901: URL: https://github.com/apache/hive/pull/5901#discussion_r2175519616 ## ql/src/test/queries/clientpositive/acid_direct_delete.q: ## @@ -0,0 +1,18 @@ +set hive.mapred.mode=nonstrict; +set hive.support.concurrency=true; +set hive.txn.manage

Re: [PR] HIVE-28790: ACID deletes are failing with ArrayIndexOutOfBoundsExcept… [hive]

kokila-19 commented on code in PR #5901: URL: https://github.com/apache/hive/pull/5901#discussion_r2175519616 ## ql/src/test/queries/clientpositive/acid_direct_delete.q: ## @@ -0,0 +1,18 @@ +set hive.mapred.mode=nonstrict; +set hive.support.concurrency=true; +set hive.txn.manage

Re: [PR] HIVE-28790: ACID deletes are failing with ArrayIndexOutOfBoundsExcept… [hive]

kokila-19 commented on code in PR #5901: URL: https://github.com/apache/hive/pull/5901#discussion_r2175519616 ## ql/src/test/queries/clientpositive/acid_direct_delete.q: ## @@ -0,0 +1,18 @@ +set hive.mapred.mode=nonstrict; +set hive.support.concurrency=true; +set hive.txn.manage

Re: [PR] HIVE-28790: ACID deletes are failing with ArrayIndexOutOfBoundsExcept… [hive]

deniskuzZ commented on code in PR #5901: URL: https://github.com/apache/hive/pull/5901#discussion_r2175495556 ## ql/src/test/queries/clientpositive/acid_direct_delete.q: ## @@ -0,0 +1,18 @@ +set hive.mapred.mode=nonstrict; +set hive.support.concurrency=true; +set hive.txn.manage

Re: [PR] HIVE-28790: ACID deletes are failing with ArrayIndexOutOfBoundsExcept… [hive]

deniskuzZ commented on code in PR #5901: URL: https://github.com/apache/hive/pull/5901#discussion_r2175495556 ## ql/src/test/queries/clientpositive/acid_direct_delete.q: ## @@ -0,0 +1,18 @@ +set hive.mapred.mode=nonstrict; +set hive.support.concurrency=true; +set hive.txn.manage

Re: [PR] HIVE-28790: ACID deletes are failing with ArrayIndexOutOfBoundsExcept… [hive]

deniskuzZ commented on code in PR #5901: URL: https://github.com/apache/hive/pull/5901#discussion_r2175263254 ## ql/src/test/queries/clientpositive/acid_direct_delete.q: ## @@ -0,0 +1,18 @@ +set hive.mapred.mode=nonstrict; +set hive.support.concurrency=true; +set hive.txn.manage

Re: [PR] HIVE-28790: ACID deletes are failing with ArrayIndexOutOfBoundsExcept… [hive]

deniskuzZ commented on code in PR #5901: URL: https://github.com/apache/hive/pull/5901#discussion_r2172457324 ## ql/src/test/queries/clientpositive/acid_direct_delete.q: ## @@ -0,0 +1,18 @@ +set hive.mapred.mode=nonstrict; Review Comment: why introduce a new q.test instead o

Re: [PR] HIVE-28790: ACID deletes are failing with ArrayIndexOutOfBoundsExcept… [hive]

deniskuzZ commented on code in PR #5901: URL: https://github.com/apache/hive/pull/5901#discussion_r2172457324 ## ql/src/test/queries/clientpositive/acid_direct_delete.q: ## @@ -0,0 +1,18 @@ +set hive.mapred.mode=nonstrict; Review Comment: why introduce a new q.test instead o

Re: [PR] HIVE-28790: ACID deletes are failing with ArrayIndexOutOfBoundsExcept… [hive]

deniskuzZ commented on code in PR #5901: URL: https://github.com/apache/hive/pull/5901#discussion_r2172457324 ## ql/src/test/queries/clientpositive/acid_direct_delete.q: ## @@ -0,0 +1,18 @@ +set hive.mapred.mode=nonstrict; Review Comment: why introduce a new q.test instead o

Re: [PR] HIVE-28790: ACID deletes are failing with ArrayIndexOutOfBoundsExcept… [hive]

deniskuzZ commented on code in PR #5901: URL: https://github.com/apache/hive/pull/5901#discussion_r2175394235 ## ql/src/test/queries/clientpositive/acid_direct_delete.q: ## @@ -0,0 +1,18 @@ +set hive.mapred.mode=nonstrict; Review Comment: just add 2 lines to the existing tes

Re: [PR] HIVE-28790: ACID deletes are failing with ArrayIndexOutOfBoundsExcept… [hive]

deniskuzZ commented on code in PR #5901: URL: https://github.com/apache/hive/pull/5901#discussion_r2175394235 ## ql/src/test/queries/clientpositive/acid_direct_delete.q: ## @@ -0,0 +1,18 @@ +set hive.mapred.mode=nonstrict; Review Comment: just add 2 lines to the existing tes

Re: [PR] HIVE-28790: ACID deletes are failing with ArrayIndexOutOfBoundsExcept… [hive]

deniskuzZ commented on code in PR #5901: URL: https://github.com/apache/hive/pull/5901#discussion_r2175394235 ## ql/src/test/queries/clientpositive/acid_direct_delete.q: ## @@ -0,0 +1,18 @@ +set hive.mapred.mode=nonstrict; Review Comment: just add 3 lines to the existing tes

Re: [PR] HIVE-28790: ACID deletes are failing with ArrayIndexOutOfBoundsExcept… [hive]

deniskuzZ commented on code in PR #5901: URL: https://github.com/apache/hive/pull/5901#discussion_r2172457324 ## ql/src/test/queries/clientpositive/acid_direct_delete.q: ## @@ -0,0 +1,18 @@ +set hive.mapred.mode=nonstrict; Review Comment: why introduce a new q.test instead o

Re: [PR] HIVE-28790: ACID deletes are failing with ArrayIndexOutOfBoundsExcept… [hive]

deniskuzZ commented on code in PR #5901: URL: https://github.com/apache/hive/pull/5901#discussion_r2172457324 ## ql/src/test/queries/clientpositive/acid_direct_delete.q: ## @@ -0,0 +1,18 @@ +set hive.mapred.mode=nonstrict; Review Comment: why introduce a new q.test instead o

Re: [PR] HIVE-28790: ACID deletes are failing with ArrayIndexOutOfBoundsExcept… [hive]

kokila-19 commented on code in PR #5901: URL: https://github.com/apache/hive/pull/5901#discussion_r2175370009 ## ql/src/test/queries/clientpositive/acid_direct_delete.q: ## @@ -0,0 +1,18 @@ +set hive.mapred.mode=nonstrict; +set hive.support.concurrency=true; +set hive.txn.manage

Re: [PR] HIVE-27473: Rewrite MetaStoreClients to be composable [hive]

sonarqubecloud[bot] commented on PR #5771: URL: https://github.com/apache/hive/pull/5771#issuecomment-3019615370 ## [](https://sonarcl

Re: [PR] HIVE-28790: ACID deletes are failing with ArrayIndexOutOfBoundsExcept… [hive]

deniskuzZ commented on code in PR #5901: URL: https://github.com/apache/hive/pull/5901#discussion_r2172457324 ## ql/src/test/queries/clientpositive/acid_direct_delete.q: ## @@ -0,0 +1,18 @@ +set hive.mapred.mode=nonstrict; Review Comment: why introduce a new q.test instead o

Re: [PR] HIVE-28790: ACID deletes are failing with ArrayIndexOutOfBoundsExcept… [hive]

deniskuzZ commented on code in PR #5901: URL: https://github.com/apache/hive/pull/5901#discussion_r2175263254 ## ql/src/test/queries/clientpositive/acid_direct_delete.q: ## @@ -0,0 +1,18 @@ +set hive.mapred.mode=nonstrict; +set hive.support.concurrency=true; +set hive.txn.manage

Re: [PR] HIVE-28790: ACID deletes are failing with ArrayIndexOutOfBoundsExcept… [hive]

deniskuzZ commented on code in PR #5901: URL: https://github.com/apache/hive/pull/5901#discussion_r2175263254 ## ql/src/test/queries/clientpositive/acid_direct_delete.q: ## @@ -0,0 +1,18 @@ +set hive.mapred.mode=nonstrict; +set hive.support.concurrency=true; +set hive.txn.manage

Re: [PR] HIVE-28790: ACID deletes are failing with ArrayIndexOutOfBoundsExcept… [hive]

kokila-19 commented on code in PR #5901: URL: https://github.com/apache/hive/pull/5901#discussion_r2175269252 ## ql/src/test/queries/clientpositive/acid_direct_delete.q: ## @@ -0,0 +1,18 @@ +set hive.mapred.mode=nonstrict; Review Comment: Agree on that. I will rewrite it.

Re: [PR] HIVE-28790: ACID deletes are failing with ArrayIndexOutOfBoundsExcept… [hive]

deniskuzZ commented on code in PR #5901: URL: https://github.com/apache/hive/pull/5901#discussion_r2175263254 ## ql/src/test/queries/clientpositive/acid_direct_delete.q: ## @@ -0,0 +1,18 @@ +set hive.mapred.mode=nonstrict; +set hive.support.concurrency=true; +set hive.txn.manage

Re: [PR] HIVE-28790: ACID deletes are failing with ArrayIndexOutOfBoundsExcept… [hive]

deniskuzZ commented on code in PR #5901: URL: https://github.com/apache/hive/pull/5901#discussion_r2175263254 ## ql/src/test/queries/clientpositive/acid_direct_delete.q: ## @@ -0,0 +1,18 @@ +set hive.mapred.mode=nonstrict; +set hive.support.concurrency=true; +set hive.txn.manage

Re: [PR] HIVE-28790: ACID deletes are failing with ArrayIndexOutOfBoundsExcept… [hive]

deniskuzZ commented on code in PR #5901: URL: https://github.com/apache/hive/pull/5901#discussion_r2175254456 ## ql/src/test/queries/clientpositive/acid_direct_delete.q: ## @@ -0,0 +1,18 @@ +set hive.mapred.mode=nonstrict; Review Comment: it doesn't need a separate test, it'

Re: [PR] HIVE-29053: _REPLACE_WITH directory are created when running qtest using sysdb [hive]

Aggarwal-Raghav commented on code in PR #5909: URL: https://github.com/apache/hive/pull/5909#discussion_r2175200658 ## cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java: ## @@ -500,6 +500,9 @@ public CommandProcessorResponse processReader(BufferedReader r) throws IOExcepti

Re: [PR] HIVE-28790: ACID deletes are failing with ArrayIndexOutOfBoundsExcept… [hive]

kokila-19 commented on code in PR #5901: URL: https://github.com/apache/hive/pull/5901#discussion_r2175198301 ## ql/src/test/queries/clientpositive/acid_direct_delete.q: ## @@ -0,0 +1,18 @@ +set hive.mapred.mode=nonstrict; Review Comment: As this is a very specific use case,

Re: [PR] HIVE-28790: ACID deletes are failing with ArrayIndexOutOfBoundsExcept… [hive]

kokila-19 commented on code in PR #5901: URL: https://github.com/apache/hive/pull/5901#discussion_r2175191636 ## ql/src/test/queries/clientpositive/acid_direct_delete.q: ## @@ -0,0 +1,18 @@ +set hive.mapred.mode=nonstrict; +set hive.support.concurrency=true; +set hive.txn.manage

Re: [PR] HIVE-28790: ACID deletes are failing with ArrayIndexOutOfBoundsExcept… [hive]

kokila-19 commented on code in PR #5901: URL: https://github.com/apache/hive/pull/5901#discussion_r2175191636 ## ql/src/test/queries/clientpositive/acid_direct_delete.q: ## @@ -0,0 +1,18 @@ +set hive.mapred.mode=nonstrict; +set hive.support.concurrency=true; +set hive.txn.manage

Re: [PR] HIVE-29047: Adjust httpclient5 httpcore dependencies in TestHttpServices [hive]

sonarqubecloud[bot] commented on PR #5907: URL: https://github.com/apache/hive/pull/5907#issuecomment-3019180773 ## [](https://sonarcl

Re: [PR] HIVE-29053: _REPLACE_WITH directory are created when running qtest using sysdb [hive]

okumin commented on code in PR #5909: URL: https://github.com/apache/hive/pull/5909#discussion_r2175023151 ## cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java: ## @@ -500,6 +500,9 @@ public CommandProcessorResponse processReader(BufferedReader r) throws IOExcepti Str

Re: [PR] HIVE-29043: Ban the Jupiter dependency from hive-unit to prevent unit tests from being skipped [hive]

abstractdog merged PR #5894: URL: https://github.com/apache/hive/pull/5894 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apach

Re: [PR] HIVE-29053: _REPLACE_WITH directory are created when running qtest using sysdb [hive]

Aggarwal-Raghav commented on code in PR #5909: URL: https://github.com/apache/hive/pull/5909#discussion_r2174927238 ## cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java: ## @@ -500,6 +500,9 @@ public CommandProcessorResponse processReader(BufferedReader r) throws IOExcepti

Re: [PR] HIVE-27473: Rewrite MetaStoreClients to be composable [hive]

sonarqubecloud[bot] commented on PR #5771: URL: https://github.com/apache/hive/pull/5771#issuecomment-3018664620 ## [](https://sonarcl

Re: [PR] HIVE-29050: Optimize the partition validation in add_partitions [hive]

deniskuzZ commented on code in PR #5910: URL: https://github.com/apache/hive/pull/5910#discussion_r2174510541 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ## @@ -4319,19 +4320,30 @@ private List add_partitions_core(fina

Re: [PR] HIVE-29050: Optimize the partition validation in add_partitions [hive]

deniskuzZ commented on code in PR #5910: URL: https://github.com/apache/hive/pull/5910#discussion_r2174510541 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ## @@ -4319,19 +4320,30 @@ private List add_partitions_core(fina

Re: [PR] HIVE-28667: Error initializing field trimmer instance when starting HS2 [hive]

zabetak commented on PR #5879: URL: https://github.com/apache/hive/pull/5879#issuecomment-3018307554 Many thanks for the reviews @ngsg @okumin ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] HIVE-29050: Optimize the partition validation in add_partitions [hive]

sonarqubecloud[bot] commented on PR #5910: URL: https://github.com/apache/hive/pull/5910#issuecomment-3018319147 ## [](https://sonarcl

Re: [PR] HIVE-28667: Error initializing field trimmer instance when starting HS2 [hive]

zabetak merged PR #5879: URL: https://github.com/apache/hive/pull/5879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.or

Re: [PR] HIVE-29051: TestTezTPCDS30TBPerfCliDriver leaks Postgres container causing intermittent failures elsewhere [hive]

zabetak commented on PR #5908: URL: https://github.com/apache/hive/pull/5908#issuecomment-3018301048 Many thanks for the review @zhangbutao ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] HIVE-29050: Optimize the partition validation in add_partitions [hive]

deniskuzZ commented on code in PR #5910: URL: https://github.com/apache/hive/pull/5910#discussion_r2174532551 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ## @@ -4836,74 +4827,6 @@ private void initializePartitionParame

Re: [PR] HIVE-29051: TestTezTPCDS30TBPerfCliDriver leaks Postgres container causing intermittent failures elsewhere [hive]

zabetak merged PR #5908: URL: https://github.com/apache/hive/pull/5908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.or

Re: [PR] HIVE-29050: Optimize the partition validation in add_partitions [hive]

deniskuzZ commented on code in PR #5910: URL: https://github.com/apache/hive/pull/5910#discussion_r2174520359 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ## @@ -4319,19 +4320,30 @@ private List add_partitions_core(fina

Re: [PR] HIVE-29050: Optimize the partition validation in add_partitions [hive]

deniskuzZ commented on code in PR #5910: URL: https://github.com/apache/hive/pull/5910#discussion_r2174516062 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ## @@ -4319,19 +4320,30 @@ private List add_partitions_core(fina

Re: [PR] HIVE-29050: Optimize the partition validation in add_partitions [hive]

deniskuzZ commented on code in PR #5910: URL: https://github.com/apache/hive/pull/5910#discussion_r2174516062 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ## @@ -4319,19 +4320,30 @@ private List add_partitions_core(fina

Re: [PR] HIVE-29050: Optimize the partition validation in add_partitions [hive]

deniskuzZ commented on code in PR #5910: URL: https://github.com/apache/hive/pull/5910#discussion_r2174503696 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ## @@ -4264,13 +4264,15 @@ public boolean equals(Object obj) {

Re: [PR] HIVE-29050: Optimize the partition validation in add_partitions [hive]

deniskuzZ commented on code in PR #5910: URL: https://github.com/apache/hive/pull/5910#discussion_r2174495278 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ## @@ -4292,17 +4294,16 @@ private List add_partitions_core(fina

Re: [PR] HIVE-29050: Optimize the partition validation in add_partitions [hive]

deniskuzZ commented on code in PR #5910: URL: https://github.com/apache/hive/pull/5910#discussion_r2174464799 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ## @@ -4693,8 +4696,9 @@ public int add_partitions_pspec(final L

Re: [PR] HIVE-29050: Optimize the partition validation in add_partitions [hive]

deniskuzZ commented on code in PR #5910: URL: https://github.com/apache/hive/pull/5910#discussion_r2174479410 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ## @@ -4693,8 +4696,9 @@ public int add_partitions_pspec(final L

Re: [PR] HIVE-29050: Optimize the partition validation in add_partitions [hive]

deniskuzZ commented on code in PR #5910: URL: https://github.com/apache/hive/pull/5910#discussion_r2174479410 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ## @@ -4693,8 +4696,9 @@ public int add_partitions_pspec(final L

Re: [PR] HIVE-29050: Optimize the partition validation in add_partitions [hive]

deniskuzZ commented on code in PR #5910: URL: https://github.com/apache/hive/pull/5910#discussion_r2174464799 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ## @@ -4693,8 +4696,9 @@ public int add_partitions_pspec(final L

Re: [PR] HIVE-29050: Optimize the partition validation in add_partitions [hive]

deniskuzZ commented on code in PR #5910: URL: https://github.com/apache/hive/pull/5910#discussion_r2174464799 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ## @@ -4693,8 +4696,9 @@ public int add_partitions_pspec(final L

Re: [PR] HIVE-29050: Optimize the partition validation in add_partitions [hive]

deniskuzZ commented on code in PR #5910: URL: https://github.com/apache/hive/pull/5910#discussion_r2174464799 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ## @@ -4693,8 +4696,9 @@ public int add_partitions_pspec(final L

Re: [PR] HIVE-29047: Adjust httpclient5 httpcore dependencies in TestHttpServices [hive]

richardantal commented on PR #5907: URL: https://github.com/apache/hive/pull/5907#issuecomment-3018140069 I rebased the change on top of master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Add release workflow for HMS docker image [hive]

deniskuzZ commented on code in PR #5899: URL: https://github.com/apache/hive/pull/5899#discussion_r2174454345 ## standalone-metastore/metastore-server/pom.xml: ## @@ -492,10 +492,13 @@ - dist - - - docker +add-extra-deps + +

Re: [PR] HIVE-29047: Adjust httpclient5 httpcore dependencies in TestHttpServices [hive]

richardantal commented on code in PR #5907: URL: https://github.com/apache/hive/pull/5907#discussion_r2174403180 ## iceberg/pom.xml: ## @@ -74,6 +74,16 @@ org.apache.iceberg iceberg-core ${iceberg.version} + + +org.apache.