view, visit https://gwt-review.googlesource.com/2840
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib610bb27cefb3d405e2126417008f4134743e723
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gok
Goktug Gokdogan has posted comments on this change.
Change subject: Removes JavaScriptException dependency from
c.g.gwt.core.shared.
..
Patch Set 1:
(1 comment)
File
7605cec1b3ea09e
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan
Gerrit-Reviewer: Brian Slesinsky
Gerrit-Reviewer: Goktug Gokdogan
Gerrit-Reviewer: Jens Nehlmeier
Gerrit-Reviewer: Leeroy Jenkins
Gerrit-Reviewer: Matthew Dempsky
Gerrit-Reviewer: Thomas B
Goktug Gokdogan has posted comments on this change.
Change subject: Introduces generic Composite widgets.
..
Patch Set 2:
(6 comments)
File user/src/com/google/gwt/user
Goktug Gokdogan has submitted this change and it was merged.
Change subject: Makes GWT.runAsync to always run async.
..
Makes GWT.runAsync to always run async.
Fixes issue 5560
Change-Id
Goktug Gokdogan has submitted this change and it was merged.
Change subject: Removes GWTTestCase.supportsAsync.
..
Removes GWTTestCase.supportsAsync.
GWTTestCase.supportsAsync was just another artifact of Benchmark infra that
Goktug Gokdogan has uploaded a new change for review.
https://gwt-review.googlesource.com/2840
Change subject: Removes JavaScriptException dependency from
c.g.gwt.core.shared.
..
Removes JavaScriptException dependency
Goktug Gokdogan has uploaded a new change for review.
https://gwt-review.googlesource.com/2781
Change subject: Removes GWTTestCase.supportsAsync.
..
Removes GWTTestCase.supportsAsync.
GWTTestCase.supportsAsync was just
Goktug Gokdogan has posted comments on this change.
Change subject: Introduces generic Composite widgets.
..
Patch Set 2:
Yes, we haven't discussed =)
The idea behind is some composite scenarios you want you delega
rit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan
Gerrit-Reviewer: Brian Slesinsky
Gerrit-Reviewer: Goktug Gokdogan
Gerrit-Reviewer: Leeroy Jenkins
Gerrit-Reviewer: Matthew Dempsky
Gerrit-Reviewer: Thomas Broyer
--
--
http://groups.google.com/group/Goo
Goktug Gokdogan has posted comments on this change.
Change subject: Introduces generic Composite widgets.
..
Patch Set 1:
(2 comments)
Sending a new patch without TypedXYZ.
PTAL
Goktug Gokdogan has posted comments on this change.
Change subject: Add SafeUri overloads for setting properties used for
navigation
..
Patch Set 4:
Yeah, making it more discoverable looks worthwhile.
Perhaps, you would
Goktug Gokdogan has posted comments on this change.
Change subject: Adds isStandalone to ImageResource so Image can used an
UnclippedState.
..
Patch Set 5:
(2 comments)
I hate gerrit when "Add comment" doesn
Goktug Gokdogan has posted comments on this change.
Change subject: Adds isStandalone to ImageResource so Image can used an
UnclippedState.
..
Patch Set 7: Code-Review+2
--
To view, visit https://gwt
Goktug Gokdogan has posted comments on this change.
Change subject: Add SafeUri overloads for setting properties used for
navigation
..
Patch Set 4:
Matthew, can you do the change if Thomas doesn't have any other con
tings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia55b41c6978a7d2824ceeb3289dc48fe05bf117b
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan
Gerrit-Reviewer: Goktug Gokdogan
Gerrit-Reviewer: Leeroy Jenkins
Gerrit-Reviewer: Roberto Lublin
Goktug Gokdogan has posted comments on this change.
Change subject: Makes GWT.runAsync to always run async.
..
Patch Set 1:
(3 comments)
File user/src/com/google/gwt/core
Goktug Gokdogan has uploaded a new change for review.
https://gwt-review.googlesource.com/2770
Change subject: Makes GWT.runAsync to always run async.
..
Makes GWT.runAsync to always run async.
Fixes issue 5560
Change-Id
Goktug Gokdogan has posted comments on this change.
Change subject: Adds isStandalone to ImageResource so Image can used an
UnclippedState.
..
Patch Set 5:
(2 comments
Goktug Gokdogan has posted comments on this change.
Change subject: Add SafeUri overloads for setting properties used for
navigation
..
Patch Set 4:
Actually I'm not much concerned about the breaking part, it is an
Goktug Gokdogan has posted comments on this change.
Change subject: Add SafeUri overloads for setting properties used for
navigation
..
Patch Set 4:
Clearing looks like a pretty common use case for the ugly setXXX((String
Goktug Gokdogan has posted comments on this change.
Change subject: Introduces a common SerializableThrowable as public API.
..
Patch Set 5:
If it is blocking you, I think it is fine to just drop it (you might need
to fix
Goktug Gokdogan has posted comments on this change.
Change subject: Introduces a common SerializableThrowable as public API.
..
Patch Set 5:
(1 comment)
I think there are 2 misunderstandings:
1. This is not introducing a new
Goktug Gokdogan has posted comments on this change.
Change subject: Introduces a common SerializableThrowable as public API.
..
Patch Set 5:
FYI, if we are putting a hard rule on this, according to our internal build
file
Goktug Gokdogan has posted comments on this change.
Change subject: Introduces a common SerializableThrowable as public API.
..
Patch Set 5:
For this scenarion, I think the class is not loaded in server side so JVM
won&#
Goktug Gokdogan has posted comments on this change.
Change subject: Introduces a common SerializableThrowable as public API.
..
Patch Set 5:
@Thomas: I don't think it is ideal but also I dont think it would cause any
e
Goktug Gokdogan has posted comments on this change.
Change subject: Merge BUILD files from google/pu.
..
Patch Set 1:
These are the boring files. You are always welcome to join our team and see
the cool stuff =)
--
To
Goktug Gokdogan has posted comments on this change.
Change subject: Adds the remaining (and more complex) Java 7 new language
features.
..
Patch Set 1:
(9 comments
Goktug Gokdogan has abandoned this change.
Change subject: Removes duplicate method dispatchers generated by
GWTTestCase.
..
Abandoned
Submitted. Thanks!
--
To view, visit https://gwt-review.googlesource.com/2590
To
Goktug Gokdogan has abandoned this change.
Change subject: Verify that Timer has not been canceled before firing
..
Abandoned
Submitted. Thanks!
--
To view, visit https://gwt-review.googlesource.com/2511
To unsubscribe
Goktug Gokdogan has abandoned this change.
Change subject: Fix Stack trace collection for iOS: first element was
dropped.
..
Abandoned
Submitted. Thanks.
--
To view, visit https://gwt-review.googlesource.com/2010
To
Goktug Gokdogan has posted comments on this change.
Change subject: Removes duplicate method dispatchers generated by
GWTTestCase.
..
Patch Set 3:
I'll submitting this change if there are no more comments?
--
To
Ok, I'll send out an alternative CL when I get the chance.
On Tue, Apr 30, 2013 at 6:22 AM, Thomas Broyer wrote:
>
>
> On Tuesday, April 30, 2013 10:27:32 AM UTC+2, Goktug Gokdogan wrote:
>>
>> Most appealing reason towards not adding generics to Composite is keep
On Sat, Apr 27, 2013 at 4:32 AM, Jens wrote:
> So what is the gotcha?
>>
>
>> First of all old code will give warnings due to missing generic type in
>> Composite. Also classes that doesn't need to enhance the type information
>> will still need to provide a type for Composite, this includes most
Goktug Gokdogan has posted comments on this change.
Change subject: Added missing JUnit tests to JUnitSuite.
..
Patch Set 1: Code-Review+1
Thanks!
--
To view, visit https://gwt-review.googlesource.com/2620
To unsubscribe
Goktug Gokdogan has posted comments on this change.
Change subject: Added missing compiler options to JUnitShell.
..
Patch Set 3:
(3 comments)
Woaw so fast!
You guys should leave it here for a while so that other people can
I experimented with Composite last week. There was no damage in Google3 -
at least I didn't notice any.
ResizeComposite might have a few but should be easy to fix.
I'll coordinate with Roberto though there shouldn't be any implications
related Java 7 as this change is only relates to raw types.
On Sat, Apr 27, 2013 at 1:57 AM, Thomas Broyer wrote:
>
>
> On Friday, April 26, 2013 6:59:32 AM UTC+2, Goktug Gokdogan wrote:
>>
>> I would like to get your feedback for fixing following issue:
>>
>> https://code.google.com/p/**google-web-tool
Goktug Gokdogan has posted comments on this change.
Change subject: Introduces generic Composite widgets.
..
Patch Set 1:
(6 comments)
Just to be clear, I'm not oppose to add generics to Composite itself. I
Goktug Gokdogan has posted comments on this change.
Change subject: Introduces generic Composite widgets.
..
Patch Set 1:
Thomas, I sent an email to gwt contributors list that discusses the
advantages and disadvantages
I would like to get your feedback for fixing following issue:
https://code.google.com/p/google-web-toolkit/issues/detail?id=4665
With generic Composite classes we can introduce other type-safe helper
composites like FocusComposite or PanelComposite (see the patch). This will
reduce boilerplate w
Goktug Gokdogan has posted comments on this change.
Change subject: Removes duplicate method dispatchers generated by
GWTTestCase.
..
Patch Set 3: Verified+1
PTAL.
--
To view, visit https://gwt-review.googlesource.com
Goktug Gokdogan has uploaded a new patch set (#3).
Change subject: Removes duplicate method dispatchers generated by
GWTTestCase.
..
Removes duplicate method dispatchers generated by GWTTestCase.
This also adds test cases
Goktug Gokdogan has posted comments on this change.
Change subject: Removes duplicate method dispatchers generated by
GWTTestCase.
..
Patch Set 2: Verified-1
Opps, this actually doesn't work with static functions :(
A
Goktug Gokdogan has posted comments on this change.
Change subject: Introduces generic Composite widgets.
..
Patch Set 1:
One other option (which was my starting point) is just to add generics
directly to Composite and
Goktug Gokdogan has uploaded a new change for review.
https://gwt-review.googlesource.com/2582
Change subject: Introduces generic Composite widgets.
..
Introduces generic Composite widgets.
Fixes issue 4665.
Adds
Goktug Gokdogan has uploaded a new patch set (#2).
Change subject: Removes duplicate method dispatchers generated by
GWTTestCase.
..
Removes duplicate method dispatchers generated by GWTTestCase.
This also adds test cases
Goktug Gokdogan has posted comments on this change.
Change subject: Removes dublicate method dispatchers generated by
GWTTestCase.
..
Patch Set 1:
(3 comments)
Commit
Goktug Gokdogan has uploaded a new change for review.
https://gwt-review.googlesource.com/2590
Change subject: Removes dublicate method dispatchers generated by
GWTTestCase.
..
Removes dublicate method dispatchers
Goktug Gokdogan has posted comments on this change.
Change subject: Verify that Timer has not been canceled before firing
..
Patch Set 4: Code-Review+1
--
To view, visit https://gwt-review.googlesource.com/2511
To unsubscribe
Goktug Gokdogan has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 4:
(1 comment)
As I noted earlier in my comments, I agree with Brian.
With the added removeAllChildren
Goktug Gokdogan has posted comments on this change.
Change subject: Avoid creating anonymous inner classes with wildcard type
parameters.
..
Patch Set 1:
(1 comment)
Sorry, I forgot to publish this one before
Goktug Gokdogan has posted comments on this change.
Change subject: Avoid creating anonymous inner classes with wildcard type
parameters.
..
Patch Set 3:
(3 comments
Goktug Gokdogan has posted comments on this change.
Change subject: Avoid creating anonymous inner classes with wildcard type
parameters.
..
Patch Set 2:
(9 comments
Goktug Gokdogan has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 2:
(3 comments)
Daniel, can you also respond to other concerns?
It is a good idea to respond every
Goktug Gokdogan has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 1:
(2 comments)
File user/src/com/google/gwt/user
Goktug Gokdogan has posted comments on this change.
Change subject: Add methods to HasTreeItems
..
Patch Set 1: Code-Review+1
(9 comments)
Nit comments on javadoc style.
Although it is breaking change I guess it is safe to
Goktug Gokdogan has posted comments on this change.
Change subject: Verify that Timer has not been canceled before firing
..
Patch Set 3:
(2 comments)
File user/src/com
Goktug Gokdogan has posted comments on this change.
Change subject: add StringBuffer/Builder.reverse
..
Patch Set 4: Code-Review+1
--
To view, visit https://gwt-review.googlesource.com/2431
To unsubscribe, visit https://gwt
Goktug Gokdogan has abandoned this change.
Change subject: Changes error messaging in devmode.js.
..
Abandoned
Submitted.
--
To view, visit https://gwt-review.googlesource.com/2481
To unsubscribe, visit https://gwt
Goktug Gokdogan has uploaded a new change for review.
https://gwt-review.googlesource.com/2481
Change subject: Changes error messaging in devmode.js.
..
Changes error messaging in devmode.js.
This change makes sure we show
Cool!
dev+htmlunit combination is the fastest internally so you might consider
running it more frequently to get even quicker feedback.
On Thu, Apr 11, 2013 at 3:44 PM, Matthew Dempsky wrote:
> Status update: I've moved gwt-ci.dempsky.org to a new VPS with more RAM
> and swap (and better uptime,
Goktug Gokdogan has posted comments on this change.
Change subject: Avoid creating anonymous inner classes with wildcard type
parameters.
..
Patch Set 1:
(2 comments
Goktug Gokdogan has abandoned this change.
Change subject: Avoid implicit inter-dependencies between DOM, History,
Window and Widgets through BaseListenerWrapper by moving things to where
they're used.
..
Aban
Goktug Gokdogan has posted comments on this change.
Change subject: Allow @UIHandler annotated methods to be private.
..
Patch Set 2:
Actually we discussed this internally and we have an agreement on our side
to add the
Goktug Gokdogan has posted comments on this change.
Change subject: Widget Iterator now throws NoSuchElementExceptions
correctly.
..
Patch Set 5: Code-Review+1
(1 comment
Goktug Gokdogan has posted comments on this change.
Change subject: Allow @UIHandler annotated methods to be private.
..
Patch Set 2:
I think there are optimization steps in JS which can reduce the code bloat.
Roberto, can
Goktug Gokdogan has posted comments on this change.
Change subject: add StringBuffer/Builder.reverse
..
Patch Set 3:
(1 comment)
File user/src/com/google/gwt/core/client
Goktug Gokdogan has posted comments on this change.
Change subject: Allow @UIHandler annotated methods to be private.
..
Patch Set 2:
If somebody thinks that a field/method needs to be package visible for
uibinder then they
Goktug Gokdogan has posted comments on this change.
Change subject: Allow @UIHandler annotated methods to be private.
..
Patch Set 2:
Actually, I encouraged this solution so I will try to answer.
I think enabling private
Goktug Gokdogan has posted comments on this change.
Change subject: add StringBuffer/Builder.reverse
..
Patch Set 1:
(5 comments)
File user/src/com/google/gwt/core/client
Goktug Gokdogan has posted comments on this change.
Change subject: Widget Iterator now throws NoSuchElementExceptions
correctly.
..
Patch Set 2:
(7 comments)
File user
Goktug Gokdogan has abandoned this change.
Change subject: Cut dependency from c.g.g.http on c.g.g.user by no longer
using Timer
..
Abandoned
Submitted.
--
To view, visit https://gwt-review.googlesource.com/1160
To
Goktug Gokdogan has posted comments on this change.
Change subject: Avoid implicit inter-dependencies between DOM, History,
Window and Widgets through BaseListenerWrapper by moving things to where
they're used.
..
Goktug Gokdogan has abandoned this change.
Change subject: Adds ability to continue testing rest of the module on
compile errors.
..
Abandoned
Submitted.
--
To view, visit https://gwt-review.googlesource.com/2400
To
Goktug Gokdogan has posted comments on this change.
Change subject: Workaround for resolving mouse button on mouse move in
Firefox
..
Patch Set 2:
Opps, I just checked the version field :)
--
To view, visit https://gwt
Goktug Gokdogan has posted comments on this change.
Change subject: Workaround for resolving mouse button on mouse move in
Firefox
..
Patch Set 2:
It looks like a bug for an unreleased version of Firefox. I don't thi
Goktug Gokdogan has posted comments on this change.
Change subject: Adds isStandalone to ImageResource so Image can used an
UnclippedState.
..
Patch Set 3: Verified-1 -Code-Review
UiBinderTest (only with htmlunit
Goktug Gokdogan has posted comments on this change.
Change subject: Break dependency from History to user.DOM, using dom.DOM
instead.
..
Patch Set 7:
Submitted.
--
To view, visit https://gwt-review.googlesource.com/1242
Goktug Gokdogan has posted comments on this change.
Change subject: Adds ability to continue testing rest of the module on
compile errors.
..
Patch Set 2:
(1 comment
Goktug Gokdogan has abandoned this change.
Change subject: Removes obsolete way of identifying test classes in module.
..
Abandoned
Submitted.
--
To view, visit https://gwt-review.googlesource.com/2371
To unsubscribe, visit
Goktug Gokdogan has abandoned this change.
Change subject: Refactors c.g.gwt.logging to use SerializableThrowable.
..
Abandoned
Submitted.
--
To view, visit https://gwt-review.googlesource.com/2310
To unsubscribe, visit
Goktug Gokdogan has abandoned this change.
Change subject: Refactors c.g.gwt.junit to use common SerializableThrowable
& StacktraceDeobfuscator.
..
Abandoned
Submitted.
--
To view, visit https:/
Goktug Gokdogan has posted comments on this change.
Change subject: Adds ability to continue testing rest of the module on
compile errors.
..
Patch Set 2:
This was previous behavior and I broke it with my code generator
Goktug Gokdogan has uploaded a new patch set (#2).
Change subject: Adds ability to continue testing rest of the module on
compile errors.
..
Adds ability to continue testing rest of the module on compile errors.
With this
Goktug Gokdogan has posted comments on this change.
Change subject: Adds ability to continue testing rest of the module on
compile errors.
..
Patch Set 1:
I gave up and dropped the test case as it is causing tck validation
Goktug Gokdogan has posted comments on this change.
Change subject: Adds ability to continue testing rest of the module on
compile errors.
..
Patch Set 1:
Newly added non-compiling test case poisons the build and causes
Goktug Gokdogan has uploaded a new change for review.
https://gwt-review.googlesource.com/2400
Change subject: Adds ability to continue testing rest of the module on
compile errors.
..
Adds ability to continue testing
Goktug Gokdogan has uploaded a new patch set (#2).
Change subject: Removes obsolete way of identifying test classes in module.
..
Removes obsolete way of identifying test classes in module.
Actually, I hope this is obsolete
Goktug Gokdogan has posted comments on this change.
Change subject: Removes obsolute way of identifying test classes in module.
..
Patch Set 1:
(3 comments)
Commit Message
e.com/2290
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1e1021bc99ac88ea6d9d47c3d23c83e79a896213
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan
Gerrit-Reviewer: Brian Slesinsky
Ge
Goktug Gokdogan has posted comments on this change.
Change subject: Refactors c.g.gwt.junit to use common SerializableThrowable
& StacktraceDeobfuscator.
..
Patch Set 2:
(8 comm
Goktug Gokdogan has posted comments on this change.
Change subject: Refactors c.g.gwt.logging to use SerializableThrowable.
..
Patch Set 1:
(1 comment)
File
user/src/com
Goktug Gokdogan has uploaded a new patch set (#2).
Change subject: Refactors c.g.gwt.logging to use SerializableThrowable.
..
Refactors c.g.gwt.logging to use SerializableThrowable.
Change-Id
Goktug Gokdogan has posted comments on this change.
Change subject: Refactors c.g.gwt.logging to use SerializableThrowable.
..
Patch Set 1:
(8 comments)
File user/src/com
Goktug Gokdogan has uploaded a new change for review.
https://gwt-review.googlesource.com/2371
Change subject: Removes obsolute way of identifying test classes in module.
..
Removes obsolute way of identifying test classes
Goktug Gokdogan has abandoned this change.
Change subject: Moves c.g.gwt.logging to common StackTraceDeobfuscator.
..
Abandoned
Submitted.
--
To view, visit https://gwt-review.googlesource.com/2300
To unsubscribe, visit
Goktug Gokdogan has posted comments on this change.
Change subject: Refactors c.g.gwt.junit to use common SerializableThrowable
& StacktraceDeobfuscator.
..
Patch Set 2:
(1 com
Goktug Gokdogan has uploaded a new patch set (#2).
Change subject: Refactors c.g.gwt.junit to use common SerializableThrowable
& StacktraceDeobfuscator.
..
Refactors c.g.gwt.junit to use common SerializableThrow
Goktug Gokdogan has posted comments on this change.
Change subject: Refactors c.g.gwt.junit to use common SerializableThrowable
& StacktraceDeobfuscator.
..
Patch Set 1:
(5 comm
501 - 600 of 749 matches
Mail list logo
