Re: [gwt-contrib] tests

2012-06-20 Thread John Tamplin
On Wed, Jun 20, 2012 at 6:48 AM, Eric Ayers wrote: > Now, the problem with diagnosing this is that the file is set to be > deleted on exit. So after the program exits, you can't see how > ridiculously huge the file might have been. To test that theory, you > could try commenting out this line t

Re: [gwt-contrib] tests

2012-06-19 Thread John Tamplin
I have had periodic failures like this that go away when I re-run it. -- John A. Tamplin Software Engineer (GWT), Google -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] tests

2012-06-09 Thread John Tamplin
On Sat, Jun 9, 2012 at 10:26 PM, Stephen Haberman < stephen.haber...@gmail.com> wrote: > So, is "ant test" supposed to run to completion on a reasonable > dev machine? I don't know that I've ever had it work, and so don't > generally run it. > I don't run it that often (we have a distributed test

Re: [gwt-contrib] Re: Re r11031 "running a static GWT app directly from the code server"

2012-06-08 Thread John Tamplin
On Fri, Jun 8, 2012 at 2:26 PM, Brian Slesinsky wrote: > I'm definitely interested in getting simple servlets to run in Super > Dev Mode in a way similar to classic Dev Mode. I haven't investigated, > so I don't know if it's better to reuse the existing implementation or > write a fresh one and l

Re: [gwt-contrib] Re: safari isOrHasChild impl

2012-06-07 Thread John Tamplin
On Thu, Jun 7, 2012 at 4:40 PM, Thomas Broyer wrote: > AFAICT, Safari 2 is no longer part of the supported browsers list, so my > take on it would be to clean-up the codebase and remove every > safari2-specific path. > There are overall a lot of cleanup (remove event listeners for instance, > whi

[gwt-contrib] Re: Use shared.GWT to avoid ClassNotFoundExceptions (issue1722803)

2012-05-31 Thread John Tamplin
On Thu, May 31, 2012 at 12:58 PM, Rajeev Dayal wrote: > Seeing test failures when I patch this in. See attachment. I remember seeing that before (and unrelated to the GWT.create changes) -- are you sure you are up to date? If you are, then we need to track down the bad JSNI reference and see w

Re: [gwt-contrib] com.google.gwt.core.client.GWTBridge

2012-05-30 Thread John Tamplin
On Wed, May 30, 2012 at 7:09 PM, Jens wrote: > You could integrate Macker (http://innig.net/macker/index.html) into your > GWT ant script and define a rule that checks for any reference from > *.server.* to *.client.* packages. May be helpful to detect such > "violations". > There is a ton of st

Re: [gwt-contrib] com.google.gwt.core.client.GWTBridge

2012-05-30 Thread John Tamplin
On Tue, May 29, 2012 at 4:43 PM, Jimo wrote: > I rebuilt GWT with the latest in the source tree and am now getting a > class not found exception for com.google.gwt.core.client.GWTBridge in my > servlet RPC implementation. Should that class exist in gwt-servlet.jar? > When I add it to that jar fil

[gwt-contrib] Re: RFC: i18n APIs as they are made available to shared code

2012-05-11 Thread John Tamplin
On Fri, May 11, 2012 at 1:10 PM, Brian Slesinsky wrote: > This isn't going to work because the threadlocal isn't set up yet, and > even if it were, each HTTP request could have a different locale. If > you create a new Foo for each request, you could just remove "static" > and call GWT.create() on

[gwt-contrib] Re: RFC: i18n APIs as they are made available to shared code

2012-05-10 Thread John Tamplin
On Thu, May 10, 2012 at 9:08 PM, Brian Slesinsky wrote: > Okay, so GwtServletBase along with GWT.create() is a new, > undocumented, minimal server-side environment that nobody knows about > yet. (I'm not seeing any usages in google3.) Correct, but since it was just committed Tuesday and the only

[gwt-contrib] Re: RFC: i18n APIs as they are made available to shared code

2012-05-10 Thread John Tamplin
On Thu, May 10, 2012 at 7:23 PM, Brian Slesinsky wrote: > Could you explain how GWT.create() works on the server? How does it > decide what to create? Could we configure it to call into Guice? > See http://code.google.com/p/google-web-toolkit/source/detail?r=10968 for the implementation of server

[gwt-contrib] RFC: i18n APIs as they are made available to shared code

2012-05-10 Thread John Tamplin
The existing i18n APIs have evolved over a long period of time as needs arose, so there is wide variety in the APIs. For example, some of them you get an instance by calling GWT.create (eg Messages), others have singleton instances (eg CurrencyList), others have static factory methods (eg NumberFo

[gwt-contrib] Re: Fix this->window confusion in DevMode (issue1620805)

2012-05-08 Thread John Tamplin
On Tue, May 8, 2012 at 3:23 PM, wrote: > True, although my assumption is that since this is a DevMode-only > behavior (null becomes window), we're actually doing everyone a favor by > fixing the behavior to match web mode, and in doing so highlighting > previously-missed/potential bugs in their a

[gwt-contrib] Re: Fix this->window confusion in DevMode (issue1620805)

2012-05-08 Thread John Tamplin
On Tue, May 8, 2012 at 2:38 PM, wrote: > > We had to roll this back because it broke a bunch of test code >> > > Cool, I saw that, was wondering what had happened. > > > I think that this patch is in the right, but the test code was not >> carefully written >> > > Good, I was hoping you thought

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

2012-05-04 Thread John Tamplin
On Fri, May 4, 2012 at 2:44 PM, wrote: > it looks like there's disagreement on the implementation >> > > My recollection is that zhuyi's original patch used a static variable to > store the "do we serialize final fields or not" state. However, the > variable is a per-module configuration, so put

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

2012-05-04 Thread John Tamplin
On Fri, May 4, 2012 at 12:15 PM, wrote: > Was debating whether this one should go in for GWT 2.5, but my > inclination is to skip it. Please let me know if anyone feels strongly > about this. > > http://gwt-code-reviews.**appspot.com/1380807/ > It ha

[gwt-contrib] Re: Add support for soft permutations to SingleScriptLinker. (issue1678803)

2012-04-05 Thread John Tamplin
On Thu, Apr 5, 2012 at 5:01 PM, wrote: > On 2012/04/05 20:44:10, jat wrote: > >> It seems like there should be some test for this to make sure it keeps >> > working. > >> Could you extend SingleScriptLinkerTest to make sure that it handles >> > collapsing > >> soft permutations? >> > > Sure. Can

Re: [gwt-contrib] Synchronous RPC

2012-02-28 Thread John Tamplin
On Tue, Feb 28, 2012 at 12:02 PM, Deepak Patil wrote: > any comments about this ? Sorry, digging through the generated JS code is hard to follow, and there are library functions referenced but not included that would help clarify a few things. If I understand correctly, the gist is to pass a st

Re: [gwt-contrib] Synchronous RPC

2012-02-20 Thread John Tamplin
On Mon, Feb 20, 2012 at 4:05 AM, Deepak Patil wrote: > (Author of openwaf.com) > > Using asynchronous RPC (GWT.runAsync) forces developer to split there code > int two parts. It becomes difficult if you want to do some sequential RPC . BTW, runAsync is totally different from RPC -- it is about c

Re: [gwt-contrib] Re: LinkedHashMap.clone()

2012-01-30 Thread John Tamplin
On Sat, Jan 28, 2012 at 12:07 PM, Irfan Adilovic wrote: > I would like to submit unit tests that test the fixes, but I cannot > bring the tests to fail with the unfixed version of LinkedHashMap (and > LinkedHashSet, which is affected in the same way, btw). > >try { > dstMap = (LinkedHashM

Re: [gwt-contrib] Re: Add the missing plugins/xpcom/prebuilt/ff90/include/IOOPHM. (issue1631804)

2012-01-27 Thread John Tamplin
On Fri, Jan 27, 2012 at 6:17 PM, Chris Conroy wrote: > It's generated from xpidl, no? So it's just been unchanging since 36. Not > guaranteed forever, but might be worth making it a build rule for if > GECKO_VERSION in some range, then use this one. If it changes, code will > have to update behin

Re: [gwt-contrib] Re: GWT HOSTING ISSUE

2012-01-24 Thread John Tamplin
On Wed, Jan 25, 2012 at 12:47 AM, Nitheesh Chandran < nithe...@dotentreprise.com> wrote: > *Discard The previous error messages * > > Refer this > > [Tue Jan 24 04:26:47 2012] [error] [client 14.140.69.18] File does not > exist: /home/spectrum/public_html/program/rpctesting/greet, referer: > http

Re: [gwt-contrib] Re: GWT HOSTING ISSUE

2012-01-24 Thread John Tamplin
On Wed, Jan 25, 2012 at 12:25 AM, Nitheesh Chandran < nithe...@dotentreprise.com> wrote: > I tried to host a sample default GWT application which uses RPC . I did > not do any changes in the program because GWT default program uses RPC > service for getting a reply from the server. This program ru

Re: [gwt-contrib] Re: GWT HOSTING ISSUE

2012-01-24 Thread John Tamplin
On Tue, Jan 24, 2012 at 11:46 PM, Nitheesh Chandran < nithe...@dotentreprise.com> wrote: > Please reply > > On Jan 24, 12:40 pm, Nitheesh Chandran > wrote: > > We need a help. Has anyone hosted GWT application to an external web > > server ? Remote procedure call is not working on the server. The

Re: [gwt-contrib] Improvement to HistoryImpl

2012-01-24 Thread John Tamplin
On Tue, Jan 24, 2012 at 10:28 AM, ALAA MURAD wrote: > > Some other people having the same problem, please also look at this : > > > http://stackoverflow.com/questions/8851193/window-location-hash-assignation-painfully-slow-in-ie8 > The answer on that page is that you only see the slowdown if you

Re: [gwt-contrib] LinkedHashMap.clone()

2012-01-24 Thread John Tamplin
On Mon, Jan 23, 2012 at 10:51 PM, Irfan Adilovic wrote: > I have a feeling the code was added with the intention to be enabled, > but never was, as nobody came to actually "implementing" > LinkedHashMap.clone(). What's the official situation on this? Should I > file a bug and submit a patch? > I

Re: [gwt-contrib] Improvement to HistoryImpl

2012-01-24 Thread John Tamplin
On Mon, Jan 23, 2012 at 9:06 PM, ALAA MURAD wrote: > I already did a test project and I replicated the class and modified it, > in my test both history token and changed event received the correct token. > Yes, but the question is if there is existing code out there that will notice that the U

Re: [gwt-contrib] Improvement to HistoryImpl

2012-01-23 Thread John Tamplin
On Mon, Jan 23, 2012 at 5:00 PM, Aladdin wrote: > This is simply will pass the event to the app for processing, then it > will later change it in the browser. > > > What do you guys think ? That seems likely to break existing code that expects by the time the event is fired the browser has been

Re: [gwt-contrib] GWT support for Application Servers

2012-01-19 Thread John Tamplin
On Wed, Jan 18, 2012 at 3:42 PM, SergeZ wrote: > Hi everyone ! Is there any other application server, probably a > lightweight one, except Jetty, which allows developers to debug GWT > code in a hosted mode ? > > In particular, is it possible to debug it on the WebSphere Application > Server and

Re: [gwt-contrib] int vs Integer and the impact of "final"

2012-01-19 Thread John Tamplin
On Thu, Jan 19, 2012 at 4:41 AM, Alexander Orlov wrote: > In Java, *Integer* is an object and can be set to null whereas *int *is a > primitive and cannot be set to null. > > In RequestFactory only the wrapped versions of primitives (= objects) are > allowed. So you might use *Boolean* and *Intege

[gwt-contrib] Re: Adding support for Typed Arrays (issue1621803)

2012-01-10 Thread John Tamplin
In the process of testing it, I found http://code.google.com/p/chromium/issues/detail?id=109785 :) -- John A. Tamplin Software Engineer (GWT), Google -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding support for Typed Arrays (issue1621803)

2012-01-07 Thread John Tamplin
On Sat, Jan 7, 2012 at 3:03 PM, wrote: > That's it. I'd probably call the client class JsoTypedArray so it's > harder to mix it up with shared.TypedArray (particularly when you use > facilities provided by your IDE to automatically insert the 'import' > clauses). Also, giving the client class a s

Re: [gwt-contrib] Typed Arrays and WebGL

2011-12-27 Thread John Tamplin
I haven't looked at the code yet, but one big thing is how does it handle browsers that don't support it? Traditionally core GWT only supported things that could at least be emulated everywhere, though "recently" some things like Canvas were added which introduced a partial support model. It woul

Re: [gwt-contrib] Tutorial for GWT request factory and Android

2011-12-19 Thread John Tamplin
On Mon, Dec 19, 2011 at 9:17 AM, Shrivallabh wrote: > Hi Folks, > > I have an existing app built on GWT 2.4 which makes use of GWT request > factory. > > I am planning to write an android app that exposes a subset of > functionality and has a different look and feel. > > However, the means to fet

Re: [gwt-contrib] Just wondering about the protocol for code commits.....

2011-12-07 Thread John Tamplin
On Wed, Dec 7, 2011 at 3:58 PM, karthik reddy wrote: > I have tacitly presumed that a LGTM from the reviewers is kinda > mandatory for a commit to be made. However, I have just noticed a commit > made today without a explicit LGTM. Since GWT code is committed to an internal system which also

Re: [gwt-contrib] Re: Add SourceMap support to GWT (issue1558803)

2011-11-25 Thread John Tamplin
On Fri, Nov 25, 2011 at 4:39 PM, wrote: > On 2011/09/23 21:55:56, cromwellian wrote: > > I can't compile because "${gwt.tools.lib}/jscomp/**sourcemap-rebased.jar" > is missing. Where to get it or how can I create this jar? > > http://gwt-code-reviews.**appspot.com/1558803/

Re: [gwt-contrib] Re: FF8 Devmode Plugin (issue1589803)

2011-11-11 Thread John Tamplin
On Fri, Nov 11, 2011 at 5:16 AM, wrote: > I'll reiterate my question: is there any plan to move to js-ctypes? or > is there some better alternative? or are binary components and > recompiling every 6 weeks a necessary evil? > > I mean, have you looked at the problem yet? and if so what's the > ou

Re: [gwt-contrib] How to build the GWT plugin?

2011-11-04 Thread John Tamplin
On Wed, Nov 2, 2011 at 3:33 PM, salaba wrote: > I am seeing some error messages print out, so wanted to debug what is > the issue. > > I am using Chrome, so I tried in the directory plugins/webkit/ > $ ant > Buildfile: build.xml > > BUILD FAILED > It complains: Cannot find ../common.ant.xml > The

Re: [gwt-contrib] Re: More control over split point fragments

2011-10-05 Thread John Tamplin
On Wed, Oct 5, 2011 at 12:52 PM, John Patterson wrote: > That seems likes a step in the right direction - but ideally there would be > some algorithm that can put common code into new shared fragments. I'm sure > its a lot harder than I imagine to handle all the permutations and load > sequences.

Re: [gwt-contrib] Re: IE + SSL + Image.setURL throws an Operation Exception at runtime

2011-09-20 Thread John Tamplin
On Tue, Sep 20, 2011 at 4:20 AM, DaveC wrote: > There was also another runtime Exception being thrown - this time the > culprit was the iFrame for GWT History (the exception was thrown at > the point the iframe's document was being accessed)... it was unused > and removing it fixed the problem. >

Re: [gwt-contrib] Hosted mode without plugin

2011-09-15 Thread John Tamplin
On Thu, Sep 15, 2011 at 2:44 PM, Marcin Wiśnicki wrote: > Is this blocking strictly necessary or would it suffice to simulate it > with continuation passing ? > The problem is the original call site is written as a blocking call, and ultimately may have originated from Java. Ie: void foo() {

Re: [gwt-contrib] Hosted mode without plugin

2011-09-15 Thread John Tamplin
On Tue, Sep 13, 2011 at 9:06 AM, Marcin Wiśnicki wrote: > Would it be technically possible to implement hosted mode without > using browser plugin ? > I'm thinking about sending messages straight from JavaScript over XHR/ > Comet/WebSocket to embedded Jetty server and interacting with JS > engine

Re: [gwt-contrib] less name mangling

2011-09-08 Thread John Tamplin
On Thu, Sep 8, 2011 at 1:36 PM, Stephen Haberman wrote: > For some reason when I put it in, I thought it would be easy to come > back later and fix. But that is not turning out to be the case. > > I really expected qualifiedRef to be a "regular" compound name, e.g. > [foo, Bar$Zaz], but instead i

Re: [gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

2011-09-01 Thread John Tamplin
On Thu, Sep 1, 2011 at 11:56 AM, wrote: > Thinking about it some more; it would be the easiest if GWT just started > serializing final fields across the board, and only skipped them if they > were marked with a GwtTransient. > That is basically what the current patch does (except for ignoring s

[gwt-contrib] Re: Minor dev/build.xml cleanup (issue1524804)

2011-08-24 Thread John Tamplin
On Wed, Aug 24, 2011 at 3:30 PM, wrote: > > http://gwt-code-reviews.**appspot.com/1524804/diff/1/**dev/build.xml > File dev/build.xml (left): > > http://gwt-code-reviews.**appspot.com/1524804/diff/1/** > dev/build.xml#oldcode113

Re: [gwt-contrib] Re: Changes setters/clearers com.google.gwt.dom.client.Style to return Style instead of void (issue1530803)

2011-08-22 Thread John Tamplin
On Tue, Aug 23, 2011 at 12:17 AM, Daniel Bell wrote: > Just out of curiosity, does this have to defeat the compiler optimisations? > Isn't it known at compile time that those setters will always return the > same Style instance? In that sense, from the compiler's point of view, isn't > the situati

Re: [gwt-contrib] Dollar sign and binary types

2011-05-27 Thread John Tamplin
On Fri, May 27, 2011 at 12:53 PM, Scott Blum wrote: > On Fri, May 27, 2011 at 10:12 AM, John Tamplin wrote: > >> I don't think that solves the problem -- let's say we store Foo/Bar$Baz >> internally and convert it to a source name where needed. How do we know >

Re: [gwt-contrib] Dollar sign and binary types

2011-05-27 Thread John Tamplin
On Fri, May 27, 2011 at 10:03 AM, Scott Blum wrote: > What John said. Blame Java for the fact that with some lookup oracle, it's > impossible to distinguish the cases. We've always assumed that users would > not use '$' in class names in places where it matters. > > That being said, let's assum

Re: [gwt-contrib] Dollar sign and binary types

2011-05-27 Thread John Tamplin
On Fri, May 27, 2011 at 4:45 AM, Grzegorz Kossakowski < grzegorz.kossakow...@gmail.com> wrote: > 2011/5/26 Eric Ayers : > > Unfortunately, I tried removing the replace('$',".") and it failed > > miserably. Looking at it in the debugger, those really are binary names. > > e.g.: > > com.google.gwt.

Re: [gwt-contrib] Re: Creating a default Locator for RequestFactoryServlet

2011-05-26 Thread John Tamplin
On Thu, May 26, 2011 at 2:23 PM, Thomas Broyer wrote: > How about simply using a ServiceLayerDecorator that overrides > resolveLocator, delegating to super.resolveLocator and, if it returns null > then return the "default locator" instead? > > If it were in a separate annotation, you could simply

Re: [gwt-contrib] Dollar sign and binary types

2011-05-26 Thread John Tamplin
On Thu, May 26, 2011 at 2:03 PM, Grzegorz Kossakowski < grzegorz.kossakow...@gmail.com> wrote: > > The problematic place for me is ReplaceBindings.java, lines 154-155: > > > >// Rebinds are always on a source type name. > >String reqType = type.getName().replace('$', '.'); > > Any comment

Re: [gwt-contrib] gwtc classpath

2011-05-24 Thread John Tamplin
On Tue, May 24, 2011 at 9:33 AM, Grzegorz Kossakowski < grzegorz.kossakow...@gmail.com> wrote: > 2011/5/24 Eric Ayers : > > Yes, that class does read bytecode, but the source of the bytecode isn't > > usually compiled .class files from the classpath, its the result of > running > > JDT on the sour

Re: [gwt-contrib] Integer calculation errors

2011-05-16 Thread John Tamplin
On Sat, May 7, 2011 at 6:12 PM, Kenneth Jorgensen wrote: > I've been writing a cryptographic library for GWT (available at > https://bitbucket.org/kennethjor/tovikov) and I ran into a few strange > problems when dealing with integers. I will not be able to post code > to reproduce the errors, simp

Re: [gwt-contrib] Re: Force locale to en_US for "user" unit tests (issue1430801)

2011-05-07 Thread John Tamplin
On Thu, May 5, 2011 at 3:58 AM, Thomas Broyer wrote: > What I don't understand is that the tests are actually exercising > DateTimeFormat, which is completely "emulated" and "controlled", and not > subject to the browser's locale (or at least it *shouldn't* be, AIUI). > For the 2010-02-01 vs. 201

[gwt-contrib] Re: Disabling test for null on getBrowserById for DOM elements without DTD when running on Chrome 11 (issue1440801)

2011-05-06 Thread John Tamplin
LGTM -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Re: Fix a class of compiler bugs related to staticImpl. (issue1428804)

2011-04-27 Thread John Tamplin
On Wed, Apr 27, 2011 at 2:57 PM, Scott Blum wrote: > If the Java MethodInliner kept call counts, I would have special-cased it > to allow inlining the static into the instance when it's the only caller. > But since call counts aren't already computed, I decided it would be best > to try it out a

[gwt-contrib] Re: Create a utility class for checking assignability of types for use (issue1420808)

2011-04-22 Thread John Tamplin
On Fri, Apr 22, 2011 at 3:45 AM, wrote: > I wrote it down yesterday evening, and the method is now gone, but > anyway: > > http://gwt-code-reviews.appspot.com/1420808/diff/1/user/src/com/google/gwt/uibinder/rebind/TypeOracleUtils.java > File user/src/com/google/gwt/uibinder/rebind/TypeOracleUti

[gwt-contrib] Re: Adds back Util.toHexString() and Util.hex4() as deprecated methods. (issue1420802)

2011-04-18 Thread John Tamplin
LGTM -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] GWT Private/Protected Members

2011-04-09 Thread John Tamplin
On Mon, Apr 4, 2011 at 12:10 PM, Clécio Varjão wrote: > One of the most frustrating thing in OO is private methods. Specially > in an "open source" software, I believe there should not be private > methods (or avoided, and use only for essential code- e.g. > manipulating private fields). Protected

[gwt-contrib] Re: Fixes to cldr eclipse projects in GWT. (issue1410802)

2011-04-08 Thread John Tamplin
LGTM -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Changes the eclipse formatter to put a space between [] and { in an (issue1411801)

2011-04-08 Thread John Tamplin
LGTM -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Re: Autoformat the api-checker tool source (issue1405801)

2011-04-05 Thread John Tamplin
On Tue, Apr 5, 2011 at 8:35 PM, Ray Ryan wrote: > I don't think it's reasonable to ask Eric to tweak the auto formatter. We > had that conversation already. He's just doing the same thing we have > eclipse configured to do, right? > Well, my understanding of the changes made to the formatter sett

Re: [gwt-contrib] Re: RR: Promoting RequestFactory to a higher package

2011-03-25 Thread John Tamplin
On Fri, Mar 25, 2011 at 5:34 PM, Andrés Testi wrote: > +1 for this! > > Are there similar plans for com.google.gwt.i18n? > GWT's i18n seems inextricably tied to GWT, so I don't see any reason to move it out. Most of the classes for the infrastructure have been placed in the server package, and e

Re: [gwt-contrib] How do I submit a patch with binary files?

2011-03-24 Thread John Tamplin
On Thu, Mar 24, 2011 at 10:14 AM, Jeff Larsen wrote: > I've got a patch for TabLayoutPanel which will allow for handling tabs that > scroll off the viewable area. For this I've got some horrifically ugly > images that I created with MSPaint. How do I include those in a patch? SVN > patches are ju

Re: [gwt-contrib] Questions on the process of issue fixing.

2011-03-23 Thread John Tamplin
On Fri, Mar 18, 2011 at 6:44 PM, Antoine DESSAIGNE < antoine.dessai...@gmail.com> wrote: > Also I created new string messages that needs to be translated, but I > didn't do anything to allow GWT contributors to translate it. I can do the > French translation, but should I simply create the _FR.pro

Re: [gwt-contrib] Questions on the process of issue fixing.

2011-03-18 Thread John Tamplin
On Fri, Mar 18, 2011 at 1:31 PM, Antoine DESSAIGNE < antoine.dessai...@gmail.com> wrote: > Also, I have a more technical question: what's the right way to handle CSS > and messages in the client.ui package: CssResource (with new CSS files) and > Constants ? > Can you describe what it is you want

Re: [gwt-contrib] Re: Promotes Gin's AsyncProvider to GWT, along with a more general (issue1387801)

2011-03-16 Thread John Tamplin
On Mon, Mar 14, 2011 at 12:37 PM, Ray Ryan wrote: > [+google-...@googlegroups.com] > > What dependency? DI is a pattern, not a commitment to a particular > framework. That said, I agree that taking AsyncProvider from Gin is a bit > presumptuous. I meant to include the gin community on this patch

[gwt-contrib] Re: add ie9 user.agent with fallback binding to ie8. (in preparation for ie9 support). (issue1369808)

2011-03-08 Thread John Tamplin
LGTM -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Typo in javadocs

2011-03-08 Thread John Tamplin
On Tue, Mar 8, 2011 at 6:11 AM, T wrote: > This is just a tiny issue, so I don't want to involve issuetracking. > I'm dealing with i18n translation, so I decided to generate properties > from default locale. I've annotated my constants with @Generate as > provided in: > > http://google-web-toolki

Re: [gwt-contrib] Re: A Class that creates a string hash out of the public API of a (issue1359802)

2011-02-17 Thread John Tamplin
On Wed, Feb 16, 2011 at 11:57 PM, Scott Blum wrote: > To give some context, this signature is used for the purpose of deciding if > a class's API has changed... *as far as other Java source files are > concerned for the purposes of running javac*. It has no effect on > TypeOracle or the data pre

[gwt-contrib] Re: Change the DevModeOptions page to use the xs linker due to recent Chrome extension permissions c... (issue1356803)

2011-02-15 Thread John Tamplin
On Tue, Feb 15, 2011 at 4:03 PM, Chris Conroy wrote: > Sorry, didn't see your comment in time for the commit. I just used the > same fix Kelly applied in SpeedTracer. I don't think it really matters > strongly either way. As I understand it, the xs linker will soon be deprecated since the xsifr

Re: [gwt-contrib] Re: Eclipse autoformatter update: allow assignments to wrap. (issue1354803)

2011-02-11 Thread John Tamplin
On Fri, Feb 11, 2011 at 1:51 PM, wrote: > Well, I personally like the way it looks: > > this.myPackage = StringInterner.get().intern( > (myPackage.length() == 0) ? "" : (myPackage + '.')); > > becomes: > > this.myPackage = > StringInterner.get().intern( > (myPackage.length() ==

Re: [gwt-contrib] Re: Follow on to svn r8671, which made the GWT code style allow whitespace (issue1346803)

2011-02-09 Thread John Tamplin
On Wed, Feb 9, 2011 at 2:25 PM, Ray Ryan wrote: > Okay, ready for re-review. > > Less ambitious now. Allows foo.bar().baz().bang().imagineManyOfThese("hi > mom"); to wrap as: > > foo.bar().baz().bang() > .imagineManyOfThese("hi mom"); > > instead of what happens now: > > foo.bar().baz()

Re: [gwt-contrib] Re: Follow on to svn r8671, which made the GWT code style allow whitespace (issue1346803)

2011-02-09 Thread John Tamplin
On Wed, Feb 9, 2011 at 10:43 AM, wrote: > I did a spot check. There is one odd thing that happens with the new > settings on eclipse 3.5 (found in JsCatchScope) > > @Override > protected JsName findExistingNameNoRecurse(String ident) { >if (name.getIdent().equals(ident)) { > return na

[gwt-contrib] Re: fix for NPVariant numbers. (new webkit v8 bindings give us doubles for ints) (issue1277801)

2011-01-11 Thread John Tamplin
On Tue, Jan 11, 2011 at 6:21 PM, Fabio Valbuena wrote: > I have been using a 'custom' build android webkit with a couple of > workarounds and the double issue is actually quite minor in the android > case; I am using a change that works around the double issue. Right, but wouldn't this allow yo

Re: [gwt-contrib] Re: DevMode generates a default web.xml when tags are present and no web.xml exists. (issue1266801)

2011-01-07 Thread John Tamplin
On Fri, Jan 7, 2011 at 1:11 PM, wrote: > I don't see any problem with the code. > > Is this really something we want to happen by default?  I'm concerned it > will be baffling to a user why a web.xml gets created only some of the > time.  It seems to me that an external tool that could parse xml

Re: [gwt-contrib] Re: UiBinder. Support for TreeItems. (issue1233803)

2011-01-05 Thread John Tamplin
On Wed, Jan 5, 2011 at 1:09 PM, Ray Ryan wrote: > There is an existing overload that accepts a string and interprets it as > HTML, so that's not an option. And asking Konstantin to add a new > addItemText(String) method seems too far outside the scope of this patch. > Ok, we can always add it to

Re: [gwt-contrib] Re: UiBinder. Support for TreeItems. (issue1233803)

2011-01-05 Thread John Tamplin
On Wed, Jan 5, 2011 at 12:47 PM, Ray Ryan wrote: > Taking this a bit further, if we're going to be playing with interfaces we > might as well go the whole nine yards: > > interface IsTreeItem { > TreeItem asTreeItem(); > } > > interface HasTreeItems { > void addItem(IsTreeItem); > void addI

Re: [gwt-contrib] Re: Add a warning in GWTTestCase to help users that accidentally run a GWT JUnit Test as a JUnit Test. (issue1224801)

2010-12-21 Thread John Tamplin
On Tue, Dec 21, 2010 at 11:09 AM, wrote: > On 2010/12/16 19:43:39, rdayal wrote: > >> Is this system property required? >> > > This is a tough one, because I don't think it's strictly required, but > the devjar has things such as the GWT devmode bridge and the GWT > compiler. Can you think of a c

Re: [gwt-contrib] Re: Breaking change proposed: future proofing Activity in 2.1.1

2010-12-08 Thread John Tamplin
On Wed, Dec 8, 2010 at 2:17 PM, Ray Ryan wrote: > Basically we don't know exactly how we want to change the thing, but have a > feeling something will be needed. Re: composition or delegation, it always > happens, but I'm not sure that's a concrete issue yet. We could introduce an > IsActivity in

Re: [gwt-contrib] Re: Isolates the portion of TypeOracleMediator that (issue1188802)

2010-12-07 Thread John Tamplin
On Tue, Dec 7, 2010 at 3:11 PM, wrote: > On 2010/12/07 13:53:13, alexander.mitin wrote: >> >> You cannot build the TypeOracle using the class bytes using the > > classpath only, >> >> because of the re-rooted resources which have no compiled classes near > > the >> >> source file. > > Good point.

Re: [gwt-contrib] Breaking change proposed: future proofing Activity in 2.1.1

2010-12-03 Thread John Tamplin
On Fri, Dec 3, 2010 at 2:58 PM, Patrick Julien wrote: > I don't know since I don't know what your plans are, will just have to > trust you. > > That being said, the Activity interface is currently really nice and > it doesn't tie us down to a single class for inheritance. I have been very happy

[gwt-contrib] Re: Issue 5663: DoubleParser rounds values to integers (issue1170801)

2010-12-01 Thread John Tamplin
On Wed, Dec 1, 2010 at 11:52 AM, Ray Ryan wrote: > I'll get it in today, thanks very much for the patch. > > I suspect this is the cause of > http://code.google.com/p/google-web-toolkit/issues/detail?id=5460 > Note if you are going to take care of the patch, you need to make sure the double comp

Re: [gwt-contrib] Re: Enhancement: DateTimeFormat: Add format/formatYear parameter to guess century on yyyy

2010-12-01 Thread John Tamplin
On Wed, Dec 1, 2010 at 11:50 AM, HerrB92 wrote: > Err, yes ... I don't ever want a 2-digit year, also. > > I have people, that enter "10" and expect to get "2010". Currently, > you will get "0010" (with a "" pattern). > > But I think, I get the point: If there is textfield and a user enters >

Re: [gwt-contrib] Enhancement: DateTimeFormat: Add format/formatYear parameter to guess century on yyyy

2010-12-01 Thread John Tamplin
On Wed, Dec 1, 2010 at 8:46 AM, HerrB92 wrote: > I'm sorry, I don't know if there is and this is the right place to > place an enhancement wish. So, thank you for reading... ;-) > > If a parsed date contains only a 2-digit year, then the century will > be guessed based on the current century +/-

Re: [gwt-contrib] Re: r9277 committed - Removing reference to designTime.getProvidedField()

2010-11-29 Thread John Tamplin
On Mon, Nov 29, 2010 at 6:43 PM, Ray Ryan wrote: > Yes. > > So who is taking care of merging in the requiring changes from trunk? -- John A. Tamplin Software Engineer (GWT), Google -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Re: r9277 committed - Removing reference to designTime.getProvidedField()

2010-11-25 Thread John Tamplin
Then other pieces of the change were not integrated, as this was preventing the 2.1 branch from building. On Nov 25, 2010 8:12 AM, "Konstantin.Scheglov" < konstantin.scheg...@gmail.com> wrote: > > No! > This change breaks @UiField(provided=true) support in GWT Designer, > important feature which we

[gwt-contrib] Re: Issues 5479, 5507 and 5571 (and a few other editor-related tweaks) (issue1099801)

2010-11-18 Thread John Tamplin
On Thu, Nov 18, 2010 at 2:35 PM, wrote: > @jat, I'll be on vacation from tomorrow through Thanksgiving. Will you > be able to land this for Thomas, and get it on to the 2.1.1 branch while > I'm gone? Sure. -- John A. Tamplin Software Engineer (GWT), Google -- http://groups.google.com/group/

[gwt-contrib] Re: Add README step to use the Google Web Toolkit SDK in the gwt-user project so that users can run ... (issue966802)

2010-11-17 Thread John Tamplin
On Wed, Nov 17, 2010 at 2:43 PM, Rajeev Dayal wrote: > No, I don't think it will. I think the nature will be ignored. But let me > verify that before putting my foot in my mouth. It has been a while so I don't remember what version, but I definitely recall having to manually edit a project file

[gwt-contrib] Re: Patch for Issue 5588: Fix Ant warning about includeantruntime not being set (issue1105801)

2010-11-15 Thread John Tamplin
On Mon, Nov 15, 2010 at 1:08 PM, Hilco Wijbenga wrote: > In 1.8.0, it doesn't seem to affect older Ants (I just ran the build > with 1.7.0). > > On a side note, I'm not clear why we can't mandate a particular Ant > version. Ant 1.8.1 still works with JDK1.4 so no issues there. It's a > best practi

[gwt-contrib] Re: Patch for Issue 5588: Fix Ant warning about includeantruntime not being set (issue1105801)

2010-11-15 Thread John Tamplin
On Mon, Nov 15, 2010 at 12:30 PM, Hilco Wijbenga wrote: > See > http://ant.1045680.n5.nabble.com/warning-includeantruntime-was-not-set-td2639463.html > for more details. > > In short, by default Ant includes its own JARs on 's classpath. > This means the effective classpath depends on where the b

Re: [gwt-contrib] Re: Would GWT and/or incubator be interested in Run Time UiBinding

2010-11-15 Thread John Tamplin
On Mon, Nov 15, 2010 at 11:42 AM, TedM wrote: > The current implementation has the following functionality > > 1. dynamic forms > 2. dynamic workflow > 3. submission of form data > 4. submission of attachments > 5. client and server validation > > And UI editor on the way. > > But the current impl

Re: [gwt-contrib] Re: Update the npapi plugin to support OSX. (issue1036801)

2010-10-20 Thread John Tamplin
On Wed, Oct 20, 2010 at 3:25 PM, Arthur Kalmenson wrote: > Is this coming with GWT 2.1? I'm guessing this is a Chrome Extension > for Mac OS X > The plugins are updated independently of GWT itself, and this can be used with GWT 2.0 as well. Note that Chrome on both Mac and Linux have the sam

Re: [gwt-contrib] Re: Test timeout in JUnitShell ? (GWT 2.0.0)

2010-10-20 Thread John Tamplin
On Wed, Oct 20, 2010 at 9:22 AM, Ed wrote: > I couldn't hold back investigating a bit more. > Like described in my last post, the timeout" always" occurred/started > in a GWTTestCase class that contained two test cases that involve RPC > calls. > > I did split up these test cases such that they h

Re: [gwt-contrib] announce: cross-site RPC using script tag.

2010-10-19 Thread John Tamplin
On Tue, Oct 19, 2010 at 5:25 AM, Артём wrote: > It can be tedious to write a script tag handling JSNI every time you > want to communicate with a trusted third-party server via script tag > (unless, of course, you're using jQuery or similar library on the > page, but even then the error handling

Re: [gwt-contrib] GWT 2.1 RC1 javadoc

2010-10-16 Thread John Tamplin
Ok, I think all the javadoc is updated -- I had to break it into 18 pieces. Sigh. -- John A. Tamplin Software Engineer (GWT), Google -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] GWT 2.1 RC1 javadoc

2010-10-15 Thread John Tamplin
On Fri, Oct 15, 2010 at 7:32 PM, Thomas Broyer wrote: > Thanks John! Sorry, I keep getting failures on the big commit. I will try again later tonight, and if that doesn't work I will break it up into multiple commits. -- John A. Tamplin Software Engineer (GWT), Google -- http://groups.google

Re: [gwt-contrib] GWT 2.1 RC1 javadoc

2010-10-15 Thread John Tamplin
On Fri, Oct 15, 2010 at 5:58 PM, Thomas Broyer wrote: > Could anyone please update the online 2.1 javadoc at > http://google-web-toolkit.googlecode.com/svn/javadoc/2.1/index.html to > RC1 ? > > (to tell the truth, I'm updating my blog posts about places and > activities and either I keep the links

Re: [gwt-contrib] Selection Cell Option value vs Display Value

2010-10-13 Thread John Tamplin
On Wed, Oct 13, 2010 at 12:10 PM, John LaBanca wrote: > Sound reasonable.  Can you open an issue to create a ValueSelectionCell that > takes an arbitrary type T and a SafeHtmlRenderer to convert the type T to a > String. A simpler option would be to accept Map with the "key" the select value and

Re: [gwt-contrib] Re: Test timeout in JUnitShell ? (GWT 2.0.0)

2010-10-05 Thread John Tamplin
On Tue, Oct 5, 2010 at 10:12 AM, Ed wrote: > I found the servlet you meant: JUnitHostImpl > I see that the url that touches this servlet is correctly forwarded by > the proxy and received by this servlet when debugging in Eclipse: > The url that touches it: / > com.bv.gwt.profile.intern.ProfileGw

  1   2   3   4   5   6   7   >