http://code.google.com/p/google-web-toolkit/wiki/Editors
What's missing? What's unclear? If you have been using the Editor
framework, what gotchas have you run into?
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/972801/diff/1/8
File
samples/validation/src/com/google/gwt/sample/validation/server/GreetingServiceImpl.java
(right):
http://gwt-code-reviews.appspot.com/972801/diff/1/8#newcode41
samples/validation/src/com/google/gwt/sample/validation/server/GreetingServiceIm
Post-weekend ping.
http://gwt-code-reviews.appspot.com/975801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr,
Description:
Deprecate DeferredCommand and IncrementalCommand.
Add MockScheduler.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/982802/show
Affected files:
M user/src/com/google/gwt/core/client/Scheduler.java
A user/src/com
Reviewers: rjrjr,
Description:
Add graceful failure when a client sends a deleted EntityProxy in a
request.
Resolves GWT issue 5403.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/986802/show
Affected files:
A user/src/com/google/gwt/requestfactory
LGTM
http://gwt-code-reviews.appspot.com/988801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM.
http://gwt-code-reviews.appspot.com/980801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr,
Description:
Resolve GWT issue 5364.
Enable RequestFactoryPolymorphicTest.
Consolidate base-type code in ModelUtils.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/992801/show
Affected files:
M user/src/com/google/gwt/editor
On Wed, Oct 13, 2010 at 6:46 PM, Ray Ryan wrote:
> Do we know what happens to the rest of the chain if someone actually tries
> to call such a method?
The server explodes because there's no analogous code to compute the
base type for TypeVariable method parameters. I'm going to submit the
client
http://gwt-code-reviews.appspot.com/975801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/975801/diff/1/2
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DynaTableRf.java
(right):
http://gwt-code-reviews.appspot.com/975801/diff/1/2#newcode67
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DynaTableRf.java:67:
Thanks for doing this.
LGTM, with nits.
http://gwt-code-reviews.appspot.com/1002801/diff/1/2
File user/src/com/google/gwt/editor/client/AutoBean.java (right):
http://gwt-code-reviews.appspot.com/1002801/diff/1/2#newcode57
user/src/com/google/gwt/editor/client/AutoBean.java:57: * @return the
ta
How does the user override the heuristic if it chooses incorrectly?
http://gwt-code-reviews.appspot.com/993801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr,
Description:
Resolve GWT issue 5361.
Document the GwtEvents associated with a RequestFactory.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/988802/show
Affected files:
M
user/src/com/google/gwt/requestfactory/client
Updated.
http://gwt-code-reviews.appspot.com/988802/diff/1/3
File user/src/com/google/gwt/requestfactory/shared/RequestFactory.java
(right):
http://gwt-code-reviews.appspot.com/988802/diff/1/3#newcode33
user/src/com/google/gwt/requestfactory/shared/RequestFactory.java:33: *
successfully persist
On Thu, Oct 14, 2010 at 8:17 PM, Patrick Julien wrote:
> As a follow up this, the internal persist() method isn't called on
> these modified entities either.
Chained persistence is explicitly outside the RequestFactory design
because RequestFactory doesn't know anything about persistence.
Introdu
Fix copyright header and LGTM
http://gwt-code-reviews.appspot.com/1013801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr,
Description:
Add a JRE-compatible version of AutoBeans that uses reflection.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/991802/show
Affected files:
M user/src/com/google/gwt/editor/Editor.gwt.xml
D user/src/com/google/gwt
Reviewers: rjrjr,
Description:
Refactor EntityCodex so that it can be used as shared code.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1029801/show
Affected files:
M user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java
M
LGTM, just nits.
http://gwt-code-reviews.appspot.com/972801/diff/8001/9007
File
samples/validation/src/com/google/gwt/sample/validation/server/GreetingServiceImpl.java
(right):
http://gwt-code-reviews.appspot.com/972801/diff/8001/9007#newcode66
samples/validation/src/com/google/gwt/sample/valid
On Wed, Oct 20, 2010 at 11:34 AM, Tim Murison wrote:
> Any updates on this issue?
I am burning down the server code this week.
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Pointer to a design doc? What is this used for?
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1040802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rice,
Message:
Review requested.
Description:
Reimplement RequestFactory client vs. domain validation using classfile
analysis to support better DevMode refresh semantics.
Patch by: bobv
Review by: rice
Please review this at http://gwt-code-reviews.appspot.com/1049801/show
Reviewers: rjrjr,
Description:
Fix RequestFactoryInterfaceValidator when analyzing interfaces with
static initializers.
Resolves GWT issue 5481.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1056801/show
Affected files:
M
user/src/com/google/gwt
LGTM
http://gwt-code-reviews.appspot.com/1058801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Thu, Oct 28, 2010 at 6:26 PM, Unnur Gretarsdottir wrote:
> Bob - why is the event listener not installed by default in non roo apps? I
> think it was when I originally added this code (although it has been a
> while)
There is no good default behavior in this case; authentication almost
seems t
Reviewers: rjrjr, rchandia,
Description:
Overhaul the RequestFactory server code.
Move AutoBeans to a top-level package and add AutoBeanCodex.
Make RequestFactory usable from non-GWT code.
Patch by: bobv
Revwie by: rjrjr, rchandia
Please review this at http://gwt-code-reviews.appspot.com
Thank you for continuing to provide feedback.
> It just happened to me that if the goal is support for polymorphism (as
> suggested by the javadoc on
> SimpleRequestProcessor.ServiceLayer#getClientType), then maybe the
> getClientType method should take a Class argument that the returned
> object
Thanks for the patch. I'll integrate this after the server overhaul
lands.
http://gwt-code-reviews.appspot.com/1068801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
to AutoBeanVisitor.
Add support to AutoBean and AutoBeanCodex for Map properties.
Add @PropertyName annotation to decrease the size of the RF payload.
http://code.google.com/p/google-web-toolkit/wiki/AutoBean
Patch by: bobv
Review by: rjrjr, rchandia
Please review this at http://gwt-code
Just to be explicit, this is just the first in a series of patches to
graduate RequestFactory from toy status into something that's usable
with real systems.
http://code.google.com/p/google-web-toolkit/wiki/RequestFactory_2_1_1
On Fri, Nov 5, 2010 at 11:21 AM, Patrick Julien wrote:
> I think thi
Rodrigo, do you have any cycles to take a look at this client-side
validation patch?
> http://gwt-code-reviews.appspot.com/1085801/show
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
AutoBean.getFactory().
Ensure AutoBean types referenced only via List or Map parameterizations
are creatable.
Use string constants for encoding enums and allow control over the field
token used.
Patch by: bobv
Review by: rchandia, jasonhall
Suggested by: jasonhall
Please review this at http://gwt
http://gwt-code-reviews.appspot.com/1096801/diff/1/2
File
user/src/com/google/gwt/autobean/client/impl/AbstractAutoBeanFactory.java
(right):
http://gwt-code-reviews.appspot.com/1096801/diff/1/2#newcode43
user/src/com/google/gwt/autobean/client/impl/AbstractAutoBeanFactory.java:43:
protected Map>
LGTM
http://gwt-code-reviews.appspot.com/1098801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
> Is this a known issue and is there a workaround I can try?
Are the problematic types only reachable from the RequestFactory
interface through a parameterized List or Set?
http://code.google.com/p/google-web-toolkit/issues/detail?id=5559
--
Bob Vawter
Google Web Toolkit Team
--
http://grou
> If anything I'm putting this out there in the hopes there's a better
> way, or that at least it's considered within the upcoming design of
> RequestFactory in 2.1.1
The code is starting to make its way into trunk. The request
processing code is now separated from all of the reflection /
domain-
/google-web-toolkit/wiki/RequestFactory_2_1_1
Patch by: bobv
Review by: rchandia,rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1108802/show
Affected files:
M
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/console/HttpClientTransport.java
M
samples/dynatablerf
Has anyone looked at applying this to RequestFactory? Would it be
sufficient for the RequestTransport to maintain the token state?
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I guess the big question is whether or not the XSRF protection is a
function of the payload envelope or needs deeper support. If it can
be done at the transport layer, extending DefaultRequestTransport
seems like easy way to mix it in.
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.goo
LGTM
http://gwt-code-reviews.appspot.com/1098801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Thanks for the review, will submit with ValueProxy validation strategy
previously discussed.
http://gwt-code-reviews.appspot.com/1108802/diff/1/20
File
user/src/com/google/gwt/requestfactory/server/RequestFactoryInterfaceValidator.java
(right):
http://gwt-code-reviews.appspot.com/1108802/diff/1
:
Allow EntityProxy, ValueProxy, or any simple value type to be used as an
entity's id and version values.
Allow RequestFactory to work with inner classes to make self-contained
tests
easier to write.
Resolves issue 5368.
Patch by: bobv
Review by: rchandia, rjrjr
Please review this at http:
http://gwt-code-reviews.appspot.com/1127801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
The only real change between the first and second patches in is
ReflectiveServiceLayer.getFind().
http://gwt-code-reviews.appspot.com/1127801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
into shared.impl, since that's where all
of the uses are.
Description:
Add Locator API to allow arbitrary domain types to be used with
RequestFactory.
Refactor ServiceLayer API to allow extension through decoration.
Miscellaneous javadoc cleanups.
Issue 5111.
Patch by: bobv
Review by: rchandia,r
Couldn't this be deferred to a LocatorProvider (or whichever its
name)?
New patch uploaded that resolves and instantiates Locators through the
ServiceLayer API.
http://gwt-code-reviews.appspot.com/1130801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rchandia, rjrjr,
Description:
Rework the way OperationMessages are processed to allow all domain
objects to be loaded at once.
http://code.google.com/p/google-web-toolkit/wiki/RequestFactory_2_1_1
Patch by: bobv
Review by: rchandia,rjrjr
Please review this at http://gwt-code
Reviewers: rchandia,
Description:
Fix covariant return types for methods declared in domain objects.
Issue 5512.
Patch by: bobv
Review by: rchandia
Please review this at http://gwt-code-reviews.appspot.com/1136801/show
Affected files:
M
user/src/com/google/gwt/requestfactory/server
Reviewers: rchandia,
Description:
Add a test for issue 5134 to ensure that RequestFactory interfaces can
be extended.
Patch by: bobv
Review by: rchandia
Reported by: pjulien
Please review this at http://gwt-code-reviews.appspot.com/1138801/show
Affected files:
A user/test/com/google/gwt
http://gwt-code-reviews.appspot.com/1136801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rchandia, cramsdale,
Description:
Add ProxySerializer API to provide EntityProxy persistence primitives.
Issue 5523.
http://code.google.com/p/google-web-toolkit/wiki/RequestFactory_2_1_1
Patch by: bobv
Review by: rchandia, cramsdale
Please review this at http://gwt-code
The change to AbstractRequestContext is almost entirely code-moves.
Several private methods were made package-protected and makePayload()
was split into smaller methods.
In order to exercise the ProxySerializer as much as possible, all return
values in RequestFactoryTest are serialized locally an
Feedback implemented.
http://gwt-code-reviews.appspot.com/1148801/diff/1/3
File user/src/com/google/gwt/autobean/shared/AutoBeanUtils.java (right):
http://gwt-code-reviews.appspot.com/1148801/diff/1/3#newcode290
user/src/com/google/gwt/autobean/shared/AutoBeanUtils.java:290: return
true;
On 201
http://gwt-code-reviews.appspot.com/1148801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rchandia, rjrjr, tbroyer,
Description:
Ensure RequestFactory is UTF-8 clean.
Refactor existing RPC Unicode tests to allow re-use by RequestFactory.
Issue 5474.
Patch by: bobv, tbroyer
Review by: rchandia
Reported by: diego.dupin
Please review this at http://gwt-code
LGTM, nits.
http://gwt-code-reviews.appspot.com/1159801/diff/1/2
File
user/src/com/google/gwt/editor/client/adapters/ListEditorWrapper.java
(right):
http://gwt-code-reviews.appspot.com/1159801/diff/1/2#newcode33
user/src/com/google/gwt/editor/client/adapters/ListEditorWrapper.java:33:
private f
Reviewers: rchandia,
Description:
Eliminate hotspots in ProxyAutoBean code by memoizing data.
Patch by: bobv
Review by: rchandia
Please review this at http://gwt-code-reviews.appspot.com/1161801/show
Affected files:
M user/src/com/google/gwt/autobean/server/MethodPropertyContext.java
M
Reviewers: rchandia, rjrjr,
Description:
Add ServiceLocator API to allow service methods to be invoked on
non-static methods.
http://code.google.com/p/google-web-toolkit/wiki/RequestFactory_2_1_1
Issue 5680.
Patch by: bobv
Review by: rchandia,rjrjr
Please review this at http://gwt-code
http://gwt-code-reviews.appspot.com/1162801/diff/1/2
File
user/src/com/google/gwt/requestfactory/server/LocatorServiceLayer.java
(right):
http://gwt-code-reviews.appspot.com/1162801/diff/1/2#newcode31
user/src/com/google/gwt/requestfactory/server/LocatorServiceLayer.java:31:
* Adds support to th
LGTM
http://gwt-code-reviews.appspot.com/1163801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rchandia, rjrjr,
Description:
Add a definitive test for enum properties in RequestFactory.
Issue 5448.
Patch by: bobv
Review by: rchandia,rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1164801/show
Affected files:
M user/test/com/google/gwt/requestfactory/client
Reviewers: rchandia, rjrjr,
Description:
Remove dependency on dev.Util class in DynaTableRf sample code.
Issue 5681.
Patch by: bobv
Review by: rchandia, rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1164802/show
Affected files:
M
samples/dynatablerf/src/com/google/gwt
Reviewers: rjrjr, rchandia,
Description:
Support up-casting subclasses of java.util.Date (e.g. java.sql.Date).
Issue 5675.
Patch by: bobv
Review by: rjrjr, rchandia
Please review this at http://gwt-code-reviews.appspot.com/1177801/show
Affected files:
M tools/api-checker/config
LGTM.
It seems like I will get inconsistent property values and a result I
don't
expect. This could also happen if my upstream modules add a new
inherit of
EmulateJsStack, so just upgrading a dependency could introduce
different
behavior.
The tag only imports a gwt.xml file once.
Reviewers: rchandia, rjrjr,
Description:
Suppress redundant PERSIST updates.
Issue 5674.
Patch by: bobv
Review by: rchandia
Please review this at http://gwt-code-reviews.appspot.com/1196801/show
Affected files:
M
user/src/com/google/gwt/requestfactory/shared/impl
Reviewers: rjrjr, rchandia,
Description:
Propagate WriteOperation.DELETE to EntityProxyChange handlers.
Re-enable a disabled test.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1199801/show
Affected files:
M
user/src/com/google/gwt
Reviewers: rjrjr,
Description:
Disallow persisted entities with null version properties because it
breaks RequestFactory update semantics.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1201801/show
Affected files:
M
user/src/com/google/gwt
LGTM.
Why is log4j.properties in this patch?
http://gwt-code-reviews.appspot.com/1200801/diff/3001/4002
File
samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseReportList.java
(right):
http://gwt-code-reviews.appspot.com/1200801/diff/3001/4002#newcode98
samples/expense
Reviewers: rjrjr,
Description:
Allow @Editor.Path("") as a valid annotation to indicate that a
sub-editor should be aliased to the object being edited by its parent
object.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1205801/show
Affe
Reviewers: rjrjr,
Description:
Add some missing docs for RPC utility class.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1207801/show
Affected files:
M user/src/com/google/gwt/user/server/rpc/RPC.java
Index: user/src/com/google/gwt/user/server
On Fri, Dec 10, 2010 at 3:35 AM, Thomas Broyer wrote:
> Will this be merged to releases/2.1 ? (and if so, do you think it'll be part
> of the 2.1.1-rc1 ?)
I have integrated r9401 into the GWT 2.1 branch, although it will not
be part of the RC.
--
Bob Vawter
Google Web Toolkit Team
--
http://g
Reviewers: rjrjr, rchandia,
Description:
Ensure that primitive values can be used as RequestFactory proxy
properties.
Make RequestFactoryInterfaceValidator stricter in handling mismatches.
Issue 5357.
Patch by: bobv
Review by: rjrjr, rchandia
Please review this at http://gwt-code
Implementation LGTM, just expand the test a bit and commit.
http://gwt-code-reviews.appspot.com/1214801/diff/20001/21004
File user/src/com/google/gwt/resources/Resources.gwt.xml (right):
http://gwt-code-reviews.appspot.com/1214801/diff/20001/21004#newcode83
user/src/com/google/gwt/resources/Res
Reviewers: rjrjr,
Description:
Make InstanceRequest usable with value objects by changing the
parameterization to BaseProxy.
Add test for above.
Fix bug in RequestFactoryInterfaceValidator where validateProxy()
wouldn't actually validate.
Issue 5678.
Patch by: bobv
Review by: rjrjr
P
On Mon, Dec 20, 2010 at 11:44 AM, Thomas Broyer wrote:
> But how do you explain the difference in display then between
> OptionalFieldEditor (which also appears to work OK in DynaTableRf) and our
> copy without LeafValueEditor?
> (looks like I'll have to debug it; hopefully looking at the generate
Reviewers: jbrosenberg,
Description:
Ensure that enum types reachable through AutoBean method
parameterizations are included in the EnumMap.
Patch by: bobv
Review by: jbrosenberg
Please review this at http://gwt-code-reviews.appspot.com/1240801/show
Affected files:
M user/src/com/google/gwt
The mix of explicit vs. implicit dependency tracking is confusing. You
have an explicit requirements.addConfigurationProperty(), but the
@Source-file tracking is implicit via
ResourceContext.getResourcesForMethod().
The SupportsGeneratorResourceCaching interface makes sense, but the
HasFindableR
(The reply function doesn't publish comments)
http://gwt-code-reviews.appspot.com/1236801/diff/1/3
File user/src/com/google/gwt/resources/ext/ResourceContext.java (right):
http://gwt-code-reviews.appspot.com/1236801/diff/1/3#newcode147
user/src/com/google/gwt/resources/ext/ResourceContext.java:
On Mon, Dec 20, 2010 at 3:10 PM, Matt Moriarity
wrote:
> I'm attempting to switch to using RequestFactory instead of GWT-RPC and
> manually creating DTOs. It's been going pretty well, except I've hit one
> use-case that is just a brick wall.
>
> I have a panel that is an Editor which uses a
> Requ
On Tue, Dec 21, 2010 at 7:24 PM, Cory wrote:
> (cross posted from users list as this is most likely more relevant to this
> list, being a possible bug)
What sequence of client-side API calls did you make in order to get a
payload with no invocations?
--
Bob Vawter
Google Web Toolkit Team
--
h
Added an issue for this:
http://code.google.com/p/google-web-toolkit/issues/detail?id=5794
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Added an issue for this:
http://code.google.com/p/google-web-toolkit/issues/detail?id=5793
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rchandia,
Description:
Fix an NPE in SimpleRequestProcessor when a client request has no
invocations.
Issue 5793.
Patch by: bobv
Review by: rchandia
Found by: cory.prowse
Please review this at http://gwt-code-reviews.appspot.com/1242801/show
Affected files:
M
user/src/com
ogle/gwt/requestfactory/client/testing/MockRequestFactoryEditorDriver.java:149:
// TODO Auto-generated method stub
On 2011/01/06 22:31:02, Nick Chalko wrote:
Remove TODO
Done.
Description:
Add support for mapping ConstraintViolation objects into
SimpleBeanEditor.
Patch by: bobv
Review by: rjrjr
Reviewers: rjrjr, Nick Chalko,
Description:
Move the validation test cases that depend on reflection out of a
client-scoped package.
This will remove a spurious compile error.
Fix MinValidatorForStringTest.
Patch by: bobv
Review by: rjrjr, nchalko
Please review this at http://gwt-code
Attached to http://code.google.com/p/google-web-toolkit/issues/detail?id=5873
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1287801/diff/1/2
File
dev/core/src/com/google/gwt/dev/shell/rewrite/RewriteSingleJsoImplDispatches.java
(right):
http://gwt-code-reviews.appspot.com/1287801/diff/1/2#newcode272
dev/core/src/com/google/gwt/dev/shell/rewrite/RewriteSingleJsoImplDispatches.
Reviewers: rjrjr, tbroyer,
Description:
Re-roll r9549 with a fix that ensures that sub-editors of a
LeafValueEditor will be ignored.
Patch by: t.broyer, bobv
Review by: bobv, rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1295801/show
Affected files:
M user/src/com/google
On Fri, Jan 14, 2011 at 5:56 PM, Thomas Broyer wrote:
> (well, now I have 5 open issues with RequestFactory assigned to me by my
> team, let's see if they're RF issues of –much more likely– issues with
> either "user code" or my heavy use of ServiceLayerDecorator)
Feedback is the breakfast of cha
Updated this patch with a hack to ApiChecker that allows it to find the
external javax.validation source jars.
http://gwt-code-reviews.appspot.com/1260801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr,
Description:
Implement an isDirty() method for Editor framework drivers.
Issue 5881.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1306801/show
Affected files:
M user/src/com/google/gwt/editor/client/EditorDelegate.java
M user
On Thu, Jan 20, 2011 at 10:00 PM, Ray Ryan wrote:
> Bob, did this land?
r9562
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr,
Description:
Allow Editor framework to handle primitive types.
Issue 5864.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1312802/show
Affected files:
M user/src/com/google/gwt/editor/rebind/model/EditorModel.java
M user/test
Why maintain both modes of operation? There's more code and more stuff
to test when JSONP is a more general solution than XHR.
http://gwt-code-reviews.appspot.com/1310801/diff/1/3
File user/src/com/google/gwt/jsonp/client/JsonpRequest.java (right):
http://gwt-code-reviews.appspot.com/1310801/di
Reviewers: rjrjr,
Description:
Allows isBoolean() properties to be handled correctly by AutoBeanCodex.
Issue 5902.
Moves all method-to-property computations into BeanMethod and
JBeanMethod utiliy enums.
Patch by: bobv
Review by: rjrjr
Reported by: jasonhall
Please review this at http://gwt
The automatic resolution of @Source files is too magic and doesn't
address external resources. The whole HasFindableResourceDependencies
looks unnecessary and doesn't jive with how the rest of the inputs to a
ResourceGenerator are tracked.
http://gwt-code-reviews.appspot.com/1236801/diff/39001/
Argh. I forgot about this and it wasn't on a 2.3 issue tracker. I'll
merge the extra things that this fixes into the patch I sent out.
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
701 - 800 of 832 matches
Mail list logo
