Hello Tim
I think I have found where the problem is.
When I ran the test with latest code, the test failed again on my machine.
How lucky am I :)
The failure trace[1] tells us it fails because of ServerSocketChannel.accept().
Message The socket is marked as nonblocking operation would block
Andrew Zhang wrote:
Hello everyone,
I noticed there are several FIXMEs in MappedByteBufferAdapter.java, which
are related to synchronization issue.
Following FIXME is for getChar() method:
// FIXME Need synchronization as far as the update of this.position is
concerned of the following
Tim Ellison wrote:
Paulex Yang wrote:
Tim,
Are you looking at this FileTest now?
I have not had time, so if you can fix them then please go ahead.
I've looked over this test, and
basically I think it's the test itself can be improved. If 8.3 filename
is disabled, the
Hi Stepan,
I tried serialization test framework, and found it's really easy to use. :)
Here I have a small question: why TestCase is designed as first parameter?
If I understand correctly, it's used to parse exception name. So is it the
same if we simply pass the String or Class of the object
Andrew Zhang wrote:
Hello Tim
I think I have found where the problem is.
When I ran the test with latest code, the test failed again on my machine.
How lucky am I :)
Lucky dog :)
The failure trace[1] tells us it fails because of
ServerSocketChannel.accept().
Message The socket is
Geir Magnusson Jr wrote:
do we have a list of the intermittent failures?
They are reported each time to the commit list.
Regards,
Tim
--
Tim Ellison ([EMAIL PROTECTED])
IBM Java technology centre, UK.
-
Terms of use :
No objection.
Regards,
Tim
Nathan Beyer wrote:
http://issues.apache.org/jira/browse/HARMONY-719
This issue identifies a valid bug in java.lang.String and good patch to fix
it. Does anyone have any objections to applying this patch or any comments?
-Nathan
--
Tim Ellison
Richard Liang wrote:
Hello Andrew,
IMHO, if the spec does not require a class thread-safe explicitly, we
may regard the class as thread-unsafe. Correct me if I'm wrong ;-)
I agree -- you may assume unsafe unless spec'd otherwise.
Regards,
Tim
Andrew Zhang wrote:
Hello everyone,
I
Andrew Zhang wrote:
On 7/1/06, Alex Blewitt [EMAIL PROTECTED] wrote:
On 01/07/06, Andrew Zhang [EMAIL PROTECTED] wrote:
Agree. But there are always exceptions. Some toString methods have to
contain some key information as spec required, for example, the size or
index.
Can you give
Nathan Beyer wrote:
Cool, I'll use that instead. Is there any way to eliminate the junit library
dependency from the command-line?
Put the JUnit library into your Ant installation's 'lib' directory.
Regards,
Tim
-Original Message-
From: George Harley [mailto:[EMAIL PROTECTED]
Sent:
Mikhail Loenko wrote:
For the example I've started this thread with it seems that complying
the spec is
more appropriate there. But probably there are other examples that
caused that the doc was worded the given way
George and Tim could you please comment?
What is the concrete example?
Nathan Beyer wrote:
How are other projects handling this? My opinion is that tests, which are
expected and know to pass should always be running and if they fail and the
failure can be independently recreated, then it's something to be posted on
the list, if trivial (typo in build file?), or
Mikhail Loenko wrote:
That means that all the API tests will be in the bootclasspath when
impl/bootclasspath tests run? Will this run be clear enough?
No I don't think that will be clear.
So can you describe how the bootclasspath and classpath are set up for
running each set of tests? Maybe
I didn't find the exact reason why this happens, looks like a drlvm ant
scripts work differently.
It could be a side effect of the recent adoption of DRLVM build for
classlib binaries. The trick is that drlvm should put it's own
hythread library into the deploy JRE.
Before that change drlvm
Hello,
One special case: I'd suggest to test that if you specify some text as
an constructor argument to a subclass of Throwable, then toString()
contains that text.
On 7/3/06, Tim Ellison [EMAIL PROTECTED] wrote:
Andrew Zhang wrote:
On 7/1/06, Alex Blewitt [EMAIL PROTECTED] wrote:
On
Hello,
There's one example that shows that not only code may contain bugs,
but documentation also:
1.5.0 spec [1] says about java.io.BufferedWriter.write(String, int, int)
If the value of the len parameter is negative then no characters are
written. This is contrary to the specification of
In 1.4.2 it was a bug, but in 1.5.0 it's a feature. :-) What a difference a
doc makes ...
Chris
On Monday 03 July 2006 14:12, Anton Luht wrote:
Hello,
There's one example that shows that not only code may contain bugs,
but documentation also:
1.5.0 spec [1] says about
On 3 July 2006 at 15:14, Andrey Chernyshev [EMAIL PROTECTED]
wrote:
I didn't find the exact reason why this happens, looks like a drlvm
ant scripts work differently.
It could be a side effect of the recent adoption of DRLVM build
for classlib binaries. The trick is that drlvm should put
Maybe it's called javadoc bug or spec bug. :)
On 7/3/06, Chris Gray [EMAIL PROTECTED] wrote:
In 1.4.2 it was a bug, but in 1.5.0 it's a feature. :-) What a difference
a
doc makes ...
Chris
On Monday 03 July 2006 14:12, Anton Luht wrote:
Hello,
There's one example that shows that not only
On Monday 03 July 2006 14:33, Andrew Zhang wrote:
Maybe it's called javadoc bug or spec bug. :)
Looks to me very like oops, our implementation isn't according to spec,
better change the spec. To be fair to Sun, fixing the implementation could
have broken existing code (maybe it did, hence the
All: support classes, impl-classpath, impl-boot, api-classpath, and
api-boot tests
are compiled into separate directories.
Support classes are compiled first, tests are compiled with support classes in
the classpath.
When the tests are running, support classes are accessible the same way as
the
Mikhail Loenko wrote:
All: support classes, impl-classpath, impl-boot, api-classpath, and
api-boot tests
are compiled into separate directories.
( TestNG looking better by the hour eh? ;-) )
Support classes are compiled first, tests are compiled with support
classes in
the classpath.
Hello,
I've been thinking how we could achieve a better separation between
VM and classlibs. I've looked how the drlvm is currently built and
works with classlib: the most of dependencies are located in the
drlvm's VMI module, which is implementation of a native interface between
vm and class
Andrey Chernyshev wrote:
On 6/29/06, Geir Magnusson Jr [EMAIL PROTECTED] wrote:
Andrey Chernyshev wrote:
Hello,
In addition to the already proposed generic tasks like 5.0 support or
concurrent GC mentioned by Ivan, I'd like to add some more specific
things that might be interesting
Is this the case where we have two 'categories'?
1) tests that never worked
2) tests that recently broke
I think that a #2 should never persist for more than one build
iteration, as either things get fixed or backed out. I suppose then we
are really talking about category #1, and that we
Ah ha...I already do that, so all is well. It seems my lack of Ant knowledge
is showing. Are we ready to move to Maven 2 yet? :)
-Original Message-
From: Tim Ellison [mailto:[EMAIL PROTECTED]
Sent: Monday, July 03, 2006 4:14 AM
To: harmony-dev@incubator.apache.org
Subject: Re:
I think that the details should be considered in this, but I'd rather us
follow the RI (and log it as a difference from the spec) if we have
some inkling that user code will be affected by it.
geir
Mikhail Loenko wrote:
Do I undersyand correctly that even when spec says e.g.
that Exception1
Why?
Nathan Beyer wrote:
Ah ha...I already do that, so all is well. It seems my lack of Ant knowledge
is showing. Are we ready to move to Maven 2 yet? :)
-Original Message-
From: Tim Ellison [mailto:[EMAIL PROTECTED]
Sent: Monday, July 03, 2006 4:14 AM
To:
Tim Ellison wrote:
Andrew Zhang wrote:
On 7/1/06, Alex Blewitt [EMAIL PROTECTED] wrote:
On 01/07/06, Andrew Zhang [EMAIL PROTECTED] wrote:
Agree. But there are always exceptions. Some toString methods have to
contain some key information as spec required, for example, the size or
index.
(He's only teasing you, don't take the bait!)
Geir Magnusson Jr wrote:
Why?
Nathan Beyer wrote:
Ah ha...I already do that, so all is well. It seems my lack of Ant knowledge
is showing. Are we ready to move to Maven 2 yet? :)
-Original Message-
From: Tim Ellison [mailto:[EMAIL
Andrey Chernyshev wrote:
I didn't find the exact reason why this happens, looks like a drlvm ant
scripts work differently.
It could be a side effect of the recent adoption of DRLVM build for
classlib binaries.
Most likely. :)
The trick is that drlvm should put it's own
hythread
Mark Hindess wrote:
On 3 July 2006 at 15:14, Andrey Chernyshev [EMAIL PROTECTED]
wrote:
(a) Do a quick-fix in build.xml / deploy.copy_classlib target - add a
filter which will will exclude hythr from copying;
(b) More graceful fix - split the process.components target in
build.xml into
Interesting - couldn't you promote this fix as a minor performance
improvement as well to knock out would would be a pointless instanceof
in the case of ?
public boolean contentEquals(CharSequence cs) {
if (cs == null) {
throw new NPE;
}
if (cs.length() != count) {
return
Just checking :)
I'm sitting here on a work holiday trying to catch up...
geir
Tim Ellison wrote:
(He's only teasing you, don't take the bait!)
Geir Magnusson Jr wrote:
Why?
Nathan Beyer wrote:
Ah ha...I already do that, so all is well. It seems my lack of Ant knowledge
is showing. Are
On 7/3/06, Mark Hindess [EMAIL PROTECTED] wrote:
On 3 July 2006 at 15:14, Andrey Chernyshev [EMAIL PROTECTED]
wrote:
I didn't find the exact reason why this happens, looks like a drlvm
ant scripts work differently.
It could be a side effect of the recent adoption of DRLVM build
for
Based on what I've seen of the excluded tests, category 1 is the predominate
case. This could be validated by looking at old revisions in SVN.
-Nathan
-Original Message-
From: Geir Magnusson Jr [mailto:[EMAIL PROTECTED]
Is this the case where we have two 'categories'?
1) tests
Andrey Chernyshev wrote:
(a) Do a quick-fix in build.xml / deploy.copy_classlib target - add a
filter which will will exclude hythr from copying;
Verified.
The Andrey's suggestion worked out (patch below).
To make the smoke tests pass on Linux I had to further apply more patches:
* fix
The concern I would have about this is the scenario where it actually is a
StringBuffer, especially an empty StringBuffer. The point of the instanceof
check and delegation to the contentEquals(StringBuffer) is to maintain
synchronization guarantees of StringBuffer. If we call the 'length()' before
Geir Magnusson Jr skrev den 28-06-2006 10:25:
Next step - dlrvm :)
That's excellent. Did all the tests pass for classlib?
Working on it... Doesn't get much done these days.
Can you document this procedure either on the wiki or send as a patch
for the website?
Yes. I think
On Monday 03 July 2006 22:12 Salikh Zakirov wrote:
Andrey Chernyshev wrote:
(a) Do a quick-fix in build.xml / deploy.copy_classlib target - add a
filter which will will exclude hythr from copying;
Verified.
The Andrey's suggestion worked out (patch below).
To make the smoke tests pass
Thorbjørn Ravn Andersen wrote:
Geir Magnusson Jr skrev den 28-06-2006 10:25:
Next step - dlrvm :)
That's excellent. Did all the tests pass for classlib?
Working on it... Doesn't get much done these days.
Can you document this procedure either on the wiki or send as a patch
Nathan Beyer wrote:
The concern I would have about this is the scenario where it actually is a
StringBuffer, especially an empty StringBuffer. The point of the instanceof
check and delegation to the contentEquals(StringBuffer) is to maintain
synchronization guarantees of StringBuffer. If we
-Original Message-
From: Geir Magnusson Jr [mailto:[EMAIL PROTECTED]
Nathan Beyer wrote:
The concern I would have about this is the scenario where it actually is
a
StringBuffer, especially an empty StringBuffer. The point of the
instanceof
check and delegation to the
To whoever can handle it,
I've updated the dependencies and Compiler class to use a new version of the
Eclipse compiler JAR. The final 3.2 release was shipped the other day.
Sorry for the inconvenience.
-Nathan
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
Alex,
Sorry for taking so long to answer your questions below. Please see
the response inline.
Weldon
On 6/27/06, Alex Astapchuk [EMAIL PROTECTED] wrote:
AFAIR from the recent thread, to implement WB for MMTk support, I have
to emit calls of
org.mmtk.plan.PlanLocal.writeBarrier(
Nathan Beyer wrote:
Based on what I've seen of the excluded tests, category 1 is the predominate
case. This could be validated by looking at old revisions in SVN.
I'm sure that is true, I'm just saying that the build system 'normal'
state is that all enabled tests pass. My concern was over
Nathan Beyer wrote:
To whoever can handle it,
I've updated the dependencies and Compiler class to use a new version of the
Eclipse compiler JAR. The final 3.2 release was shipped the other day.
Sorry for the inconvenience.
Thanks Nathan.
I've just updated the Linux build machine, but
Andrey Chernyshev wrote:
I'm not sure it is just a name clash problem - drlvm won't give the
hythread library if the class lib hadn't requested it.
The classlib builds it's own copy of the hythread library, so there is
no need for a compatible VM to rebuild it or provide it.
VMs are free to
Gregory Shimansky wrote:
Hello
Today I've found the reason of why drlvm currently cannot use jar files
signed
with jarsigner in classpath. When it is done it throws SecurityException:
K00ec :) . The reason is that SHA1 provider cannot be found by security API
to check the signature.
Geir Magnusson Jr wrote:
Indeed not. Should we just use an ant filter and a property to set this?
Does your IDE cope with this? It will require testing exclusively via
Ant I think.
Regards,
Tim
geir
[EMAIL PROTECTED] wrote:
Author: tellison
Date: Fri Jun 30 00:49:45 2006
New
Can you get your IDE to invoke ant?
Tim Ellison wrote:
Geir Magnusson Jr wrote:
Indeed not. Should we just use an ant filter and a property to set this?
Does your IDE cope with this? It will require testing exclusively via
Ant I think.
Regards,
Tim
geir
[EMAIL PROTECTED] wrote:
Nathan Beyer wrote:
-Original Message-
From: Geir Magnusson Jr [mailto:[EMAIL PROTECTED]
Nathan Beyer wrote:
The concern I would have about this is the scenario where it actually is
a
StringBuffer, especially an empty StringBuffer. The point of the
instanceof
check and
Hello George,
Agree. We shall always following RI when throwing exception. But Harmony
developer could discuss specific problems on mailing list if he/she
feels uncomfortable. ;-)
George Harley wrote:
Mikhail Loenko wrote:
For the example I've started this thread with it seems that
Geir Magnusson Jr wrote:
Tim Ellison wrote:
Andrew Zhang wrote:
On 7/1/06, Alex Blewitt [EMAIL PROTECTED] wrote:
On 01/07/06, Andrew Zhang [EMAIL PROTECTED] wrote:
Agree. But there are always exceptions. Some toString methods have to
contain some key information as
54 matches
Mail list logo
