I have made fix[1] for unused category (only java code). If nobody
has objections I could fix other caterogies.
[1] http://issues.apache.org/jira/browse/HARMONY-1926
2006/10/20, Nathan Beyer [EMAIL PROTECTED]:
I've been trying to work through many of the warnings, module by
module. Most of
Denis Kishenko wrote:
I have made fix[1] for unused category (only java code). If nobody
has objections I could fix other caterogies.
[1] http://issues.apache.org/jira/browse/HARMONY-1926
See Nathan's comments about unused vars -- they cannot be fixed safely
with the Java wizard. Unused
On 10/20/06, Tim Ellison [EMAIL PROTECTED] wrote:
Denis Kishenko wrote:
I have made fix[1] for unused category (only java code). If nobody
has objections I could fix other caterogies.
[1] http://issues.apache.org/jira/browse/HARMONY-1926
See Nathan's comments about unused vars -- they
Almost all unused variables are local. Only two of them are class
fields and they are not using in native code. Build and all tests are
successful.
2006/10/20, Tim Ellison [EMAIL PROTECTED]:
Denis Kishenko wrote:
I have made fix[1] for unused category (only java code). If nobody
has
Denis Kishenko wrote:
Almost all unused variables are local. Only two of them are class
fields and they are not using in native code. Build and all tests are
successful.
Thanks Denis!
Regards,
Tim
--
Tim Ellison ([EMAIL PROTECTED])
IBM Java technology centre, UK.
Added patch for SUID wanings to the same issue.H-1926
2006/10/20, Tim Ellison [EMAIL PROTECTED]:
Denis Kishenko wrote:
Almost all unused variables are local. Only two of them are class
fields and they are not using in native code. Build and all tests are
successful.
Thanks Denis!
Regards,
Nathan Beyer wrote:
I added a compiler arg to the main 'build-java.xml' compile to disable
all of the warnings.
Thanks a lot, Nathan, but how about also add that arg to build-test.xml?
I think the ECJ probably feels more unhappy with the test cases:).
This should take care of the warnings.
I looked at adding the nowarn arg for the tests, but 'build-test.xml'
doesn't have a single large compile statement like 'buid-java.xml'
does. The arg would need to be added to the compile-test of every
module's build, which can be done, I was just feeling lazy at the
moment, sorry. :( Also, I
I also worried about a lot of warnings and I think warnings like these
can be fixed
last\modules\concurrent\standard\src\main\java\java\util\concurrent\ConcurrentHashMap.java
[javac] (at line 26)
[javac] import java.io.ObjectInputStream;
[javac]
+1
I never know if it's something important or not.
On 10/19/06, Denis Kishenko [EMAIL PROTECTED] wrote:
I also worried about a lot of warnings and I think warnings like these
can be fixed
last\modules\concurrent\standard\src\main\java\java\util\concurrent\ConcurrentHashMap.java
[javac]
Nathan has turned off all warnings. I suggest that we start to turn
them back on incrementally and fix the warnings we see.
Regards,
Tim
Denis Kishenko wrote:
I also worried about a lot of warnings and I think warnings like these
can be fixed
I've been trying to work through many of the warnings, module by
module. Most of the warnings fall into the following categories.
* serial - Serializable classes that don't have explicit serialVersionUID fields
* unchecked - missing type variables, mostly collection references
* unused - unused
coolio - thx
Nathan Beyer wrote:
I added a compiler arg to the main 'build-java.xml' compile to disable
all of the warnings.
This should take care of the warnings.
-Nathan
On 10/18/06, Geir Magnusson Jr. [EMAIL PROTECTED] wrote:
Can we just shut them off for now? it's a good project for
You have patience I can only dream about...
geir
Nathan Beyer wrote:
I've been trying to work through many of the warnings, module by
module. Most of the warnings fall into the following categories.
* serial - Serializable classes that don't have explicit
serialVersionUID fields
* unchecked
These messages aren't getting through on the commits list on due to the
large number of warnings since switching to ecj. I've modified the
summary process so that it ignores these for the moment.
Hopefully this means that the failure messages that haven't been making
the commits list will start
Can we just shut them off for now? it's a good project for someone to
go and clean those up, but there's no need for all of us to see them.
geir
Mark Hindess wrote:
These messages aren't getting through on the commits list on due to the
large number of warnings since switching to ecj. I've
I added a compiler arg to the main 'build-java.xml' compile to disable
all of the warnings.
This should take care of the warnings.
-Nathan
On 10/18/06, Geir Magnusson Jr. [EMAIL PROTECTED] wrote:
Can we just shut them off for now? it's a good project for someone to
go and clean those up, but
17 matches
Mail list logo