[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856119#comment-16856119
]
Ayush Saxena commented on HDFS-14545:
-
Thanx [~elgoiri] for putting this up.
I had a
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856136#comment-16856136
]
Íñigo Goiri commented on HDFS-14545:
Oops, we had a concurrent patch here :)
Anyway,
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856189#comment-16856189
]
Hadoop QA commented on HDFS-14545:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856256#comment-16856256
]
Ayush Saxena commented on HDFS-14545:
-
Mine is just a draft, Well I felt we should ge
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856267#comment-16856267
]
Íñigo Goiri commented on HDFS-14545:
My question at this point is if we go for sendin
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856272#comment-16856272
]
Ayush Saxena commented on HDFS-14545:
-
Yes, that seems correct, the both of these sho
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856298#comment-16856298
]
Íñigo Goiri commented on HDFS-14545:
I think it is better to follow the router philos
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856514#comment-16856514
]
Ayush Saxena commented on HDFS-14545:
-
I have drafted a patch, with getting response
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856564#comment-16856564
]
Hadoop QA commented on HDFS-14545:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856847#comment-16856847
]
Íñigo Goiri commented on HDFS-14545:
Thanks [~ayushtkn] for [^HDFS-14545-HDFS-13891-0
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856848#comment-16856848
]
Íñigo Goiri commented on HDFS-14545:
[~shenyinjie] please take a look too.
> RBF: Ro
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16857034#comment-16857034
]
Ayush Saxena commented on HDFS-14545:
-
Thanx [~elgoiri] for the comments
uploaded v03
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16857113#comment-16857113
]
Hadoop QA commented on HDFS-14545:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16857161#comment-16857161
]
Íñigo Goiri commented on HDFS-14545:
It looks like the failure test is related to the
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16857243#comment-16857243
]
Íñigo Goiri commented on HDFS-14545:
To make it a little more compact, we can also do
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16857266#comment-16857266
]
Ayush Saxena commented on HDFS-14545:
-
Have uploaded v4 handling the failure, And cha
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16857282#comment-16857282
]
Íñigo Goiri commented on HDFS-14545:
Most of the exceptions come from the constructor
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16857305#comment-16857305
]
Hadoop QA commented on HDFS-14545:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16857593#comment-16857593
]
Ayush Saxena commented on HDFS-14545:
-
Well, I enclosed the constructor creation part
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16857596#comment-16857596
]
Ayush Saxena commented on HDFS-14545:
-
Well, {{TestRouterWithSecureStartup}} reported
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16857649#comment-16857649
]
Hadoop QA commented on HDFS-14545:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16857770#comment-16857770
]
Hadoop QA commented on HDFS-14545:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16857857#comment-16857857
]
Íñigo Goiri commented on HDFS-14545:
Thanks [~ayushtkn] for pushing the update.
* For
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16857950#comment-16857950
]
Ayush Saxena commented on HDFS-14545:
-
Uploaded v07 with said changes.
> RBF: Router
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858002#comment-16858002
]
Íñigo Goiri commented on HDFS-14545:
Just a minor thing, we could also make getNewCon
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858015#comment-16858015
]
Hadoop QA commented on HDFS-14545:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858016#comment-16858016
]
Ayush Saxena commented on HDFS-14545:
-
Yetus Doesn't have any complains.
uploaded v08
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858041#comment-16858041
]
Íñigo Goiri commented on HDFS-14545:
You can use ProxyAndInfo instead of ProxyAndInfo
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858046#comment-16858046
]
Íñigo Goiri commented on HDFS-14545:
Sorry, one more thing.
To make it closer to the
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858060#comment-16858060
]
Ayush Saxena commented on HDFS-14545:
-
We can't rename to newConnection(), Since ther
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858082#comment-16858082
]
Hadoop QA commented on HDFS-14545:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858156#comment-16858156
]
Íñigo Goiri commented on HDFS-14545:
True, they have the same signature.
Actually, as
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858274#comment-16858274
]
Ayush Saxena commented on HDFS-14545:
-
Merged the two methods into one. Just checking
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858305#comment-16858305
]
Hadoop QA commented on HDFS-14545:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858802#comment-16858802
]
Íñigo Goiri commented on HDFS-14545:
Thanks [~ayushtkn] for the updates.
I'm good wit
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858830#comment-16858830
]
Ayush Saxena commented on HDFS-14545:
-
Thanx [~elgoiri]
I know we weren't having th
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858873#comment-16858873
]
Íñigo Goiri commented on HDFS-14545:
Let's go for this then.
[~lukmajercak] can you t
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858912#comment-16858912
]
Lukas Majercak commented on HDFS-14545:
---
ConnectionPool lines 410, 411. Would be ni
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859061#comment-16859061
]
Ayush Saxena commented on HDFS-14545:
-
Thanx [~lukmajercak] fo the review.
Handled co
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859070#comment-16859070
]
Hadoop QA commented on HDFS-14545:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859840#comment-16859840
]
Shen Yinjie commented on HDFS-14545:
Thanks [~ayushtkn] for implementing this ! patc
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863822#comment-16863822
]
Lukas Majercak commented on HDFS-14545:
---
Thanks [~ayushtkn], LGTM
> RBF: Router sh
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864275#comment-16864275
]
Íñigo Goiri commented on HDFS-14545:
+1 on [^HDFS-14545-HDFS-13891-10.patch].
Commit
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864280#comment-16864280
]
Íñigo Goiri commented on HDFS-14545:
Thanks [~ayushtkn] for working on this and [~she
[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16871637#comment-16871637
]
Hudson commented on HDFS-14545:
---
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #
45 matches
Mail list logo