2012/1/19 Ángel González keis...@gmail.com:
Actually, why couldn't mingw be supported one day?
(supposing someone did the work to change half the PHP_WIN defines to
PHP_MSVC)
Too painful, somehow buggy (while it is way better lately) but the
main reason is total lack of binary compatibility
Hi,
On Fri, 2011-11-18 at 16:06 -0500, Daniel Convissor wrote:
The length property is what's tripping up my unit tests. I'm building
PHP 5.4 from svn for both tests. The only difference between them is
the with-mysqli declaration. Here is a table summarizing the situation:
type
Am 19.01.2012 13:50, schrieb Johannes Schlüter:
On Fri, 2011-11-18 at 16:06 -0500, Daniel Convissor wrote:
The length property is what's tripping up my unit tests. I'm building
PHP 5.4 from svn for both tests. The only difference between them is
the with-mysqli declaration. Here is a table
Hi,
I fixed https://bugs.php.net/bug.php?id=52078, I would like to add the test
improvement to the 5.4 branch also, is it ok to commit, or should I wait
the release with it?
see http://svn.php.net/viewvc?view=revisionrevision=322460
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu
I guess 5.4 branch is under code freeze.
http://marc.info/?l=php-internalsm=132617955007428w=2
On Thu, Jan 19, 2012 at 5:07 PM, Ferenc Kovacs tyr...@gmail.com wrote:
Hi,
I fixed https://bugs.php.net/bug.php?id=52078, I would like to add the
test
improvement to the 5.4 branch also, is it ok
And this is why I asked it.
The following may be considered for inclusion:
- Unit tests test fixes
..
Please still ask RMs for approval prior to committing even if your patch
falls into these categories.
On Thu, Jan 19, 2012 at 8:12 PM, Rafael Kassner kass...@gmail.com wrote:
I guess 5.4
Gentlemen:
On Thu, Jan 19, 2012 at 02:09:12PM +0100, Ulf Wendel wrote:
Am 19.01.2012 13:50, schrieb Johannes Schlüter:
Your server seems to be configured for UTF-8 by default. In my tests the
behavior for both libraries (myslqnd libmsql) is the same if you mind
the character set (use SET
Hi!
I fixed https://bugs.php.net/bug.php?id=52078, I would like to add the test
improvement to the 5.4 branch also, is it ok to commit, or should I wait
the release with it?
Please hold it, we are announcing RC6 soon and plan to release in 2
weeks, in this period I'd like to keep the SVN as
Am 19.01.2012 20:27, schrieb Daniel Convissor:
Gentlemen:
On Thu, Jan 19, 2012 at 02:09:12PM +0100, Ulf Wendel wrote:
Am 19.01.2012 13:50, schrieb Johannes Schlüter:
Your server seems to be configured for UTF-8 by default. In my tests the
behavior for both libraries (myslqnd libmsql) is
Hi:
On Thu, Jan 19, 2012 at 02:27:05PM -0500, Daniel Convissor wrote:
On Thu, Jan 19, 2012 at 02:09:12PM +0100, Ulf Wendel wrote:
Am 19.01.2012 13:50, schrieb Johannes Schlüter:
Your server seems to be configured for UTF-8 by default. In my tests the
behavior for both libraries (myslqnd
On Thu, Jan 19, 2012 at 8:30 PM, Stas Malyshev smalys...@sugarcrm.comwrote:
Hi!
I fixed
https://bugs.php.net/bug.php?**id=52078https://bugs.php.net/bug.php?id=52078,
I would like to add the test
improvement to the 5.4 branch also, is it ok to commit, or should I wait
the release with
Hi all,
I've implemented a patch (attached to the bug, but in a gist as well
here https://gist.github.com/1641725 ) that implements a hash_pbkdf2()
function. The patch also slightly refactors hash_hmac() to split out
a little bit of common functionality (since pbkdf2 relies upon hmac).
Hi!
We'll be announcing RC6 very soon, and we're planning the final release
for February 2nd. The two weeks in between are meant for testing and
finding out any critical issues that could prevent us from releasing 5.4.0.
If we have none of these, we will proceed with the release. To ensure
Hi,
great to see progress!
I have some small questions, please don't feel offended, I just want to
know and understand:
- According to this website there are still 94 test failures in 5.4 .
Can you confirm all of them are minor problems?
http://gcov.php.net/viewer.php?version=PHP_5_4
- There
Hi internals
After five release candidates we are reaching the end of the RC phase.
If we do not encounter critical bugs in the next two weeks, then this
6th RC will be tagged as 5.4.0 final.
You can download the packages from:
http://downloads.php.net/stas
The Windows team provides
Hi!
- According to this website there are still 94 test failures in 5.4 .
Can you confirm all of them are minor problems?
http://gcov.php.net/viewer.php?version=PHP_5_4
Most of them appear so, I'll go through them again to be sure and
encourage others to do so too and raise red flags if
Excerpts from Stas Malyshev's message of Thu Jan 19 16:08:28 -0800 2012:
Hi!
- According to this website there are still 94 test failures in 5.4 .
Can you confirm all of them are minor problems?
http://gcov.php.net/viewer.php?version=PHP_5_4
Most of them appear so, I'll go through them
Hi!
These tests should be skipped or marked as XFAIL on platforms they are
known to fail on. Better to have no test than one that cannot be relied
upon. All supported platforms should pass with 0 fails. These intentional
Of course they should, and you (or anybody else) are welcome to make the
Hi Stats,
I would like to commit session adaption patch to 5.4, since it
does not change current session module behavior by default
and affected application can be protected by changing php.ini
setting. As you already know, it requires structure changes and
it would be binary incompatible if add
Hi!
I would like to commit session adaption patch to 5.4, since it
does not change current session module behavior by default
and affected application can be protected by changing php.ini
setting. As you already know, it requires structure changes and
it would be binary incompatible if add it
I added a patch to bug #60809. If it's ok I can commit it.
Pierrick
On 19 January 2012 20:55, Stas Malyshev smalys...@sugarcrm.com wrote:
Hi!
I would like to commit session adaption patch to 5.4, since it
does not change current session module behavior by default
and affected application
I just open a new thread just for this bug.
If one of the RM could please confirm that I can commit the patch to
the PHP5.4 branch.
Thanks
Pierrick
Index: NEWS
===
--- NEWS(revision 322482)
+++ NEWS(working copy)
@@
Hi Stats,
Ok, I'll hold committing to 5.4, but commit it only to trunk.
Any comments form anyone? for committing to trunk?
Patch details and user land counter measure are in RFC.
https://wiki.php.net/rfc/strict_sessions
BTW, if we hold this patch, I think we should write patch that does
not
Hi Stats,
Even if this bug is marked as bogus in bug DB, I think this bug needed
to be fixed for 5.4.
https://bugs.php.net/bug.php?id=38104
It seems this bug causes problem with IE that not keeping session correctly.
From RFC 6250
-
Servers SHOULD NOT include more than one
Hi Stas,
I did run the test of bug #55871 and got memory leaks. This patch
remove them. Could you please review the patch and if it is Ok i'll
commit it to 5.4
Thanks
Pierrick
Index: NEWS
===
--- NEWS(revision 322482)
+++
On 1/19/2012 5:29 AM, Pierre Joye wrote:
2012/1/19 Ángel González keis...@gmail.com:
Such binaries wouldn't be compatible with IIS, but mingw seems preferible
to the legacy VC6 for use with the oficial Apache binaries.
A couple of things to remember; msvcrt.dll is quite actively maintained,
Just updated and tried to compile, getting this:
make: *** No rule to make target
`/opt/php-core/trunk-accessor/ext/hash/hash_salsa.c', needed by
`ext/hash/hash_salsa.lo'. Stop.
I see that commit 322421 removed the hash_salsa.c but perhaps the Makefile
didn't get updated? Anyone else seeing
On 01/19/2012 08:20 PM, Clint M Priest wrote:
Just updated and tried to compile, getting this:
make: *** No rule to make target
`/opt/php-core/trunk-accessor/ext/hash/hash_salsa.c', needed by
`ext/hash/hash_salsa.lo'. Stop.
I see that commit 322421 removed the hash_salsa.c but perhaps
Hi!
Even if this bug is marked as bogus in bug DB, I think this bug needed
to be fixed for 5.4.
https://bugs.php.net/bug.php?id=38104
It seems this bug causes problem with IE that not keeping session correctly.
It looks like pretty rare scenario and doesn't seem to require any core
changes
Hi!
Hi Stats,
Ok, I'll hold committing to 5.4, but commit it only to trunk.
Any comments form anyone? for committing to trunk?
Patch details and user land counter measure are in RFC.
Re-reading the discussion, I see that the question of why we need
separate validator handler is still
Hi!
I did run the test of bug #55871 and got memory leaks. This patch
remove them. Could you please review the patch and if it is Ok i'll
commit it to 5.4
Please hold it for now. It's not a critical issue, if we'd have another
RC for different reason, we can also have it in as it doesn't
Hey Pierre,
I was wondering if you'd be willing to pitch a rollback of r300894
post-code-freeze. If not, I'll start writing error detection code
to accomodate for PHP 5.4 :^)
Thanks,
Edward
Excerpts from Edward Z. Yang's message of Sun Jan 08 11:41:50 -0500 2012:
Hello Pierre,
The whole
32 matches
Mail list logo
