[GitHub] flink issue #5069: [FLINK-8149][kinesis] Replace usages of deprecated Serial...

2017-11-30 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5069 Ah, I just realized that my comment on the last review is irrelevant, since `org.apache.flink.streaming.util.serialization.SerializationSchema` extends `org.apache.flink.api.common.serialization.Ser

[jira] [Commented] (FLINK-8149) Replace usages of deprecated SerializationSchema

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272298#comment-16272298 ] ASF GitHub Bot commented on FLINK-8149: --- Github user tzulitai commented on the issue

[GitHub] flink issue #5102: [FLINK-7762, FLINK-8167] Clean up and harden WikipediaEdi...

2017-11-30 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5102 LGTM. +1 to merge this now, and we think about removing the source as well as reworking the doc example to not use it (I think it might be nice to directly kick off the docs with an intro e

[jira] [Commented] (FLINK-7762) Make WikipediaEditsSourceTest a proper test

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272313#comment-16272313 ] ASF GitHub Bot commented on FLINK-7762: --- Github user tzulitai commented on the issue

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-11-30 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r154009420 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java --- @@ -584,4 +587,60 @@ static CloseRequest readFrom(@

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272320#comment-16272320 ] ASF GitHub Bot commented on FLINK-7416: --- Github user zhijiangW commented on a diff i

[GitHub] flink pull request #5017: [FLINK-8076] Upgrade KinesisProducer to 0.10.6 to ...

2017-11-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5017 ---

[jira] [Commented] (FLINK-8076) Upgrade KinesisProducer to 0.10.6 to set properties approperiately

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272322#comment-16272322 ] ASF GitHub Bot commented on FLINK-8076: --- Github user asfgit closed the pull request

[GitHub] flink pull request #5075: [hotfix] [docs] Fix typos in State Backends doc

2017-11-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5075 ---

[jira] [Commented] (FLINK-8149) Replace usages of deprecated SerializationSchema

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272321#comment-16272321 ] ASF GitHub Bot commented on FLINK-8149: --- Github user asfgit closed the pull request

[GitHub] flink pull request #5069: [FLINK-8149][kinesis] Replace usages of deprecated...

2017-11-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5069 ---

[jira] [Commented] (FLINK-8076) Upgrade KinesisProducer to 0.10.6 to set properties approperiately

2017-11-30 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272335#comment-16272335 ] Tzu-Li (Gordon) Tai commented on FLINK-8076: Merged! 1.5: be913100d8657c7a0ac

[jira] [Resolved] (FLINK-8076) Upgrade KinesisProducer to 0.10.6 to set properties approperiately

2017-11-30 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai resolved FLINK-8076. Resolution: Fixed Release Note: The AWS KPL version used in the Kinesis connect

[jira] [Resolved] (FLINK-8149) Replace usages of deprecated SerializationSchema

2017-11-30 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai resolved FLINK-8149. Resolution: Fixed > Replace usages of deprecated SerializationSchema > -

[jira] [Commented] (FLINK-8149) Replace usages of deprecated SerializationSchema

2017-11-30 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272341#comment-16272341 ] Tzu-Li (Gordon) Tai commented on FLINK-8149: Merged: 1.5 - a744d4bf39f8bb365c

[jira] [Updated] (FLINK-7694) Port JobMetricsHandler to new REST handler

2017-11-30 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-7694: Labels: flip-6 (was: flip6) > Port JobMetricsHandler to new REST handler >

[GitHub] flink pull request #5104: [FLINK-8172][network] Write directly to memorySegm...

2017-11-30 Thread pnowojski
GitHub user pnowojski opened a pull request: https://github.com/apache/flink/pull/5104 [FLINK-8172][network] Write directly to memorySegment in RecordSerializer This increases throughput of network stack by factor of 2, because previously method getMemorySegment() was called twice p

[jira] [Commented] (FLINK-8172) Remove unnecessary synchronisation in RecordSerializer

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272358#comment-16272358 ] ASF GitHub Bot commented on FLINK-8172: --- GitHub user pnowojski opened a pull request

[jira] [Created] (FLINK-8176) Dispatcher does not start SubmittedJobGraphStore

2017-11-30 Thread Gary Yao (JIRA)
Gary Yao created FLINK-8176: --- Summary: Dispatcher does not start SubmittedJobGraphStore Key: FLINK-8176 URL: https://issues.apache.org/jira/browse/FLINK-8176 Project: Flink Issue Type: Bug

[jira] [Assigned] (FLINK-8176) Dispatcher does not start SubmittedJobGraphStore

2017-11-30 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao reassigned FLINK-8176: --- Assignee: Gary Yao > Dispatcher does not start SubmittedJobGraphStore > -

[jira] [Updated] (FLINK-8176) Dispatcher does not start SubmittedJobGraphStore

2017-11-30 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-8176: Description: {{Dispatcher}} never calls start on its {{SubmittedJobGraphStore}} instance. Hence, when a Job

[GitHub] flink issue #4988: [FLINK-8030] Instantiate JobMasterRestEndpoint in JobClus...

2017-11-30 Thread shuai-xu
Github user shuai-xu commented on the issue: https://github.com/apache/flink/pull/4988 This pr is very helpful for us. Thank you. I have tried it on our cluster with yarn job mode,and it works well. My only suggestion is to change the default value of rest.address to 0.0.0.0 instead

[jira] [Commented] (FLINK-8030) Start JobMasterRestEndpoint in JobClusterEntrypoint

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272420#comment-16272420 ] ASF GitHub Bot commented on FLINK-8030: --- Github user shuai-xu commented on the issue

[jira] [Updated] (FLINK-8176) Dispatcher does not start SubmittedJobGraphStore

2017-11-30 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-8176: Labels: flip-6 (was: ) > Dispatcher does not start SubmittedJobGraphStore > ---

[jira] [Created] (FLINK-8177) Flink cannot be built for Hadoop 2.9.0

2017-11-30 Thread Fabian Hueske (JIRA)
Fabian Hueske created FLINK-8177: Summary: Flink cannot be built for Hadoop 2.9.0 Key: FLINK-8177 URL: https://issues.apache.org/jira/browse/FLINK-8177 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-8172) Remove unnecessary synchronisation in RecordSerializer

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272437#comment-16272437 ] ASF GitHub Bot commented on FLINK-8172: --- Github user NicoK commented on a diff in th

[GitHub] flink pull request #5104: [FLINK-8172][network] Write directly to memorySegm...

2017-11-30 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5104#discussion_r154024973 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningRecordSerializer.java --- @@ -107,6 +110,7 @@ public Seria

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-11-30 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r154026730 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java --- @@ -584,4 +587,60 @@ static CloseRequest readFrom(@Supp

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272440#comment-16272440 ] ASF GitHub Bot commented on FLINK-7416: --- Github user NicoK commented on a diff in th

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272445#comment-16272445 ] ASF GitHub Bot commented on FLINK-7416: --- Github user NicoK commented on a diff in th

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-11-30 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r154027406 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -283,10 +283,13 @@ public String t

[GitHub] flink pull request #4761: [FLINK-7748][network] properly use the TaskEventDi...

2017-11-30 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4761#discussion_r154023066 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/ResultPartitionWriter.java --- @@ -34,12 +31,10 @@ * The {@link

[GitHub] flink pull request #4761: [FLINK-7748][network] properly use the TaskEventDi...

2017-11-30 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4761#discussion_r154027358 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGateTest.java --- @@ -325,9 +325,10 @@ public void

[GitHub] flink pull request #4761: [FLINK-7748][network] properly use the TaskEventDi...

2017-11-30 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4761#discussion_r154027456 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/DummyEnvironment.java --- @@ -190,4 +191,8 @@ public InputGate getInput

[jira] [Commented] (FLINK-7748) remove event listener behaviour from ResultPartitionWriter

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272447#comment-16272447 ] ASF GitHub Bot commented on FLINK-7748: --- Github user pnowojski commented on a diff i

[jira] [Commented] (FLINK-7748) remove event listener behaviour from ResultPartitionWriter

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272450#comment-16272450 ] ASF GitHub Bot commented on FLINK-7748: --- Github user pnowojski commented on a diff i

[jira] [Commented] (FLINK-7748) remove event listener behaviour from ResultPartitionWriter

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272452#comment-16272452 ] ASF GitHub Bot commented on FLINK-7748: --- Github user pnowojski commented on a diff i

[jira] [Commented] (FLINK-7748) remove event listener behaviour from ResultPartitionWriter

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272448#comment-16272448 ] ASF GitHub Bot commented on FLINK-7748: --- Github user pnowojski commented on a diff i

[GitHub] flink pull request #4761: [FLINK-7748][network] properly use the TaskEventDi...

2017-11-30 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4761#discussion_r154023982 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -671,7 +671,7 @@ else if (current == ExecutionState.CANCELING)

[GitHub] flink pull request #4761: [FLINK-7748][network] properly use the TaskEventDi...

2017-11-30 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4761#discussion_r154025597 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/TaskEventDispatcherTest.java --- @@ -0,0 +1,168 @@ +/* + * Licensed to t

[GitHub] flink pull request #4761: [FLINK-7748][network] properly use the TaskEventDi...

2017-11-30 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4761#discussion_r154021028 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/iterative/task/IterationHeadTask.java --- @@ -223,8 +225,10 @@ private void readInitialSolu

[GitHub] flink pull request #4761: [FLINK-7748][network] properly use the TaskEventDi...

2017-11-30 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4761#discussion_r154026050 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/TaskEventDispatcherTest.java --- @@ -0,0 +1,168 @@ +/* + * Licensed to t

[jira] [Commented] (FLINK-7748) remove event listener behaviour from ResultPartitionWriter

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272446#comment-16272446 ] ASF GitHub Bot commented on FLINK-7748: --- Github user pnowojski commented on a diff i

[jira] [Commented] (FLINK-7748) remove event listener behaviour from ResultPartitionWriter

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272451#comment-16272451 ] ASF GitHub Bot commented on FLINK-7748: --- Github user pnowojski commented on a diff i

[jira] [Commented] (FLINK-7748) remove event listener behaviour from ResultPartitionWriter

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272449#comment-16272449 ] ASF GitHub Bot commented on FLINK-7748: --- Github user pnowojski commented on a diff i

[GitHub] flink pull request #5071: [FLINK-7907][docs] The metrics documentation missi...

2017-11-30 Thread yew1eb
Github user yew1eb commented on a diff in the pull request: https://github.com/apache/flink/pull/5071#discussion_r154031899 --- Diff: docs/monitoring/metrics.md --- @@ -94,8 +94,8 @@ Alternatively you can also use your own `Counter` implementation: {% highlight java %}

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-11-30 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r154031923 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java --- @@ -208,8 +244,79 @@ public voi

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272466#comment-16272466 ] ASF GitHub Bot commented on FLINK-7416: --- Github user zhijiangW commented on a diff i

[jira] [Commented] (FLINK-7907) Flink Metrics documentation missing Scala examples

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272465#comment-16272465 ] ASF GitHub Bot commented on FLINK-7907: --- Github user yew1eb commented on a diff in t

[jira] [Created] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-11-30 Thread Piotr Nowojski (JIRA)
Piotr Nowojski created FLINK-8178: - Summary: Introduce not threadsafe write only BufferBuilder Key: FLINK-8178 URL: https://issues.apache.org/jira/browse/FLINK-8178 Project: Flink Issue Type:

[GitHub] flink issue #5104: [FLINK-8172][network] Write directly to memorySegment in ...

2017-11-30 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/5104 2 times improvement is for network stack only. With other things in play (like even simple operators) it will be smaller. As we discussed offline, I didn't want tightening up the connectio

[jira] [Commented] (FLINK-8172) Remove unnecessary synchronisation in RecordSerializer

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272496#comment-16272496 ] ASF GitHub Bot commented on FLINK-8172: --- Github user pnowojski commented on the issu

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-11-30 Thread pnowojski
GitHub user pnowojski opened a pull request: https://github.com/apache/flink/pull/5105 [FLINK-8178][network] Introduce not threadsafe write only BufferBuilder This pr depends on #5104 While Buffer class is used in multithreaded context it requires synchronisation. Previousl

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272500#comment-16272500 ] ASF GitHub Bot commented on FLINK-8178: --- GitHub user pnowojski opened a pull request

[GitHub] flink issue #5103: [FLINK-7595] [Savepoints] Allow removing stateless operat...

2017-11-30 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5103 👍 looks good. Can I merge this or do you want to go ahead? ---

[jira] [Commented] (FLINK-7595) Removing stateless task from task chain breaks savepoint restore

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272508#comment-16272508 ] ASF GitHub Bot commented on FLINK-7595: --- Github user aljoscha commented on the issue

[jira] [Created] (FLINK-8179) Convert CharSequence to String when registering / converting a Table

2017-11-30 Thread Fabian Hueske (JIRA)
Fabian Hueske created FLINK-8179: Summary: Convert CharSequence to String when registering / converting a Table Key: FLINK-8179 URL: https://issues.apache.org/jira/browse/FLINK-8179 Project: Flink

[jira] [Commented] (FLINK-8173) InvalidProgramException: Table program cannot be compiled. This is a bug. Please file an issue.

2017-11-30 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272512#comment-16272512 ] Fabian Hueske commented on FLINK-8173: -- Yes, you should change {{toAppendStream[org.a

[jira] [Comment Edited] (FLINK-8173) InvalidProgramException: Table program cannot be compiled. This is a bug. Please file an issue.

2017-11-30 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272512#comment-16272512 ] Fabian Hueske edited comment on FLINK-8173 at 11/30/17 10:51 AM: ---

[jira] [Comment Edited] (FLINK-8173) InvalidProgramException: Table program cannot be compiled. This is a bug. Please file an issue.

2017-11-30 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272512#comment-16272512 ] Fabian Hueske edited comment on FLINK-8173 at 11/30/17 10:52 AM: ---

[GitHub] flink issue #5103: [FLINK-7595] [Savepoints] Allow removing stateless operat...

2017-11-30 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5103 feel free to merge it. ---

[jira] [Commented] (FLINK-7595) Removing stateless task from task chain breaks savepoint restore

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272537#comment-16272537 ] ASF GitHub Bot commented on FLINK-7595: --- Github user zentol commented on the issue:

[GitHub] flink pull request #5106: TestCommit

2017-11-30 Thread zhanglibing1990
GitHub user zhanglibing1990 opened a pull request: https://github.com/apache/flink/pull/5106 TestCommit *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible w

[GitHub] flink pull request #5106: TestCommit

2017-11-30 Thread zhanglibing1990
Github user zhanglibing1990 closed the pull request at: https://github.com/apache/flink/pull/5106 ---

[GitHub] flink pull request #4761: [FLINK-7748][network] properly use the TaskEventDi...

2017-11-30 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4761#discussion_r154067761 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/ResultPartitionWriter.java --- @@ -34,12 +31,10 @@ * The {@link Res

[jira] [Commented] (FLINK-7748) remove event listener behaviour from ResultPartitionWriter

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272630#comment-16272630 ] ASF GitHub Bot commented on FLINK-7748: --- Github user NicoK commented on a diff in th

[GitHub] flink issue #5103: [FLINK-7595] [Savepoints] Allow removing stateless operat...

2017-11-30 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5103 merged into `release-1.4` ---

[jira] [Commented] (FLINK-7595) Removing stateless task from task chain breaks savepoint restore

2017-11-30 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272638#comment-16272638 ] Aljoscha Krettek commented on FLINK-7595: - Fixed on release-1.4 in df58722f08b8fa8

[jira] [Commented] (FLINK-7595) Removing stateless task from task chain breaks savepoint restore

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272637#comment-16272637 ] ASF GitHub Bot commented on FLINK-7595: --- Github user aljoscha commented on the issue

[jira] [Commented] (FLINK-8177) Flink cannot be built for Hadoop 2.9.0

2017-11-30 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272650#comment-16272650 ] Stephan Ewen commented on FLINK-8177: - A temporary workaround is skipping the test sco

[jira] [Commented] (FLINK-7881) flink can't deployed on yarn with ha

2017-11-30 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272673#comment-16272673 ] Aljoscha Krettek commented on FLINK-7881: - [~djh4230] Does [~till.rohrmann]'s sugg

[jira] [Commented] (FLINK-8177) Flink cannot be built for Hadoop 2.9.0

2017-11-30 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272679#comment-16272679 ] Aljoscha Krettek commented on FLINK-8177: - I simply changed the test to not extend

[jira] [Comment Edited] (FLINK-8177) Flink cannot be built for Hadoop 2.9.0

2017-11-30 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272679#comment-16272679 ] Aljoscha Krettek edited comment on FLINK-8177 at 11/30/17 1:44 PM: -

[GitHub] flink pull request #4761: [FLINK-7748][network] properly use the TaskEventDi...

2017-11-30 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4761#discussion_r154080335 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/DummyEnvironment.java --- @@ -190,4 +191,8 @@ public InputGate getInputGate

[jira] [Commented] (FLINK-7748) remove event listener behaviour from ResultPartitionWriter

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272690#comment-16272690 ] ASF GitHub Bot commented on FLINK-7748: --- Github user NicoK commented on a diff in th

[jira] [Updated] (FLINK-8176) Dispatcher does not start SubmittedJobGraphStore

2017-11-30 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-8176: Component/s: YARN > Dispatcher does not start SubmittedJobGraphStore > -

[jira] [Updated] (FLINK-5506) Java 8 - CommunityDetection.java:158 - java.lang.NullPointerException

2017-11-30 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-5506: Description: Reporting this here as per Vasia's advice. I am having the following problem wh

[jira] [Comment Edited] (FLINK-5506) Java 8 - CommunityDetection.java:158 - java.lang.NullPointerException

2017-11-30 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182713#comment-16182713 ] Aljoscha Krettek edited comment on FLINK-5506 at 11/30/17 3:29 PM: -

[jira] [Commented] (FLINK-8158) Rowtime window inner join emits late data

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272808#comment-16272808 ] ASF GitHub Bot commented on FLINK-8158: --- Github user fhueske commented on the issue:

[GitHub] flink issue #5094: [FLINK-8158] [table] Fix rowtime window inner join emits ...

2017-11-30 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/5094 Yes, the records emitted in your test are late. But the reason for that is that also records that you give into the join are already late. You set the watermarks on both input to `6000` and subsequen

[jira] [Commented] (FLINK-8158) Rowtime window inner join emits late data

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272850#comment-16272850 ] ASF GitHub Bot commented on FLINK-8158: --- Github user hequn8128 commented on the issu

[GitHub] flink issue #5094: [FLINK-8158] [table] Fix rowtime window inner join emits ...

2017-11-30 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/5094 Ops... finally understand what you mean. Thank your very much for your explain. @fhueske @xccui . I will close this pr :) ---

[jira] [Commented] (FLINK-8158) Rowtime window inner join emits late data

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272853#comment-16272853 ] ASF GitHub Bot commented on FLINK-8158: --- Github user hequn8128 closed the pull reque

[GitHub] flink pull request #5094: [FLINK-8158] [table] Fix rowtime window inner join...

2017-11-30 Thread hequn8128
Github user hequn8128 closed the pull request at: https://github.com/apache/flink/pull/5094 ---

[GitHub] flink issue #5094: [FLINK-8158] [table] Fix rowtime window inner join emits ...

2017-11-30 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/5094 No worries! It's always good to have another pair of eyes looking over complex logic like this :-) ---

[jira] [Commented] (FLINK-8158) Rowtime window inner join emits late data

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272854#comment-16272854 ] ASF GitHub Bot commented on FLINK-8158: --- Github user fhueske commented on the issue:

[GitHub] flink issue #5094: [FLINK-8158] [table] Fix rowtime window inner join emits ...

2017-11-30 Thread xccui
Github user xccui commented on the issue: https://github.com/apache/flink/pull/5094 Never mind~ Thanks for reminding me of the ideas :-) ---

[jira] [Commented] (FLINK-8158) Rowtime window inner join emits late data

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272857#comment-16272857 ] ASF GitHub Bot commented on FLINK-8158: --- Github user xccui commented on the issue:

[GitHub] flink pull request #5099: [FLINK-8080][metrics] Remove need for "metrics.rep...

2017-11-30 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5099#discussion_r154122694 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/MetricOptions.java --- @@ -25,20 +25,9 @@ public class MetricOptions {

[GitHub] flink pull request #5099: [FLINK-8080][metrics] Remove need for "metrics.rep...

2017-11-30 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5099#discussion_r154121821 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryConfiguration.java --- @@ -43,8 +46,8 @@ private static

[jira] [Commented] (FLINK-8080) Remove need for "metrics.reporters"

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272879#comment-16272879 ] ASF GitHub Bot commented on FLINK-8080: --- Github user greghogan commented on a diff i

[jira] [Commented] (FLINK-8080) Remove need for "metrics.reporters"

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272880#comment-16272880 ] ASF GitHub Bot commented on FLINK-8080: --- Github user greghogan commented on a diff i

[GitHub] flink pull request #5107: [FLINK-8176][flip6] Start SubmittedJobGraphStore i...

2017-11-30 Thread GJL
GitHub user GJL opened a pull request: https://github.com/apache/flink/pull/5107 [FLINK-8176][flip6] Start SubmittedJobGraphStore in Dispatcher ## What is the purpose of the change The FLIP-6 dispatcher never calls `start()` on its SubmittedJobGraphStore instance. Hence, wh

[jira] [Commented] (FLINK-8176) Dispatcher does not start SubmittedJobGraphStore

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272890#comment-16272890 ] ASF GitHub Bot commented on FLINK-8176: --- GitHub user GJL opened a pull request:

[GitHub] flink pull request #5107: [FLINK-8176][flip6] Start SubmittedJobGraphStore i...

2017-11-30 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5107#discussion_r154128004 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java --- @@ -246,5 +258,11 @@ protected JobManagerRunner createJobManag

[jira] [Commented] (FLINK-8176) Dispatcher does not start SubmittedJobGraphStore

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272898#comment-16272898 ] ASF GitHub Bot commented on FLINK-8176: --- Github user GJL commented on a diff in the

[jira] [Closed] (FLINK-8027) Generalize existing rest handlers to work with arbitrary RestfulGateway

2017-11-30 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-8027. Resolution: Fixed Fixed via b0bd65db9bb9d41ad85634d08dc8b9dae2cfa8dd > Generalize existing rest han

[GitHub] flink pull request #4985: [FLINK-8027] Generalize existing rest handlers to ...

2017-11-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4985 ---

[GitHub] flink issue #4935: [Flink-7945][Metrics&connector]Fix per partition-lag metr...

2017-11-30 Thread Aitozi
Github user Aitozi commented on the issue: https://github.com/apache/flink/pull/4935 Hi, @tzulitai After i read kafkaConsumer code again, i found that the per partition kafka lag metric is register in method `FetchManagerMetrics#recordPartitionLag` But the when the client get the

[jira] [Commented] (FLINK-8027) Generalize existing rest handlers to work with arbitrary RestfulGateway

2017-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272947#comment-16272947 ] ASF GitHub Bot commented on FLINK-8027: --- Github user asfgit closed the pull request

  1   2   >