Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2836#discussion_r89130533
--- Diff: flink-streaming-connectors/flink-connector-kafka-0.9/pom.xml ---
@@ -192,7 +193,9 @@ under the License
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2836#discussion_r89130119
--- Diff: pom.xml ---
@@ -93,6 +93,7 @@ under the License.
1C
true
log4j-test.properties
+ -Xms256m
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2836#discussion_r89130486
--- Diff: flink-streaming-connectors/flink-connector-cassandra/pom.xml ---
@@ -49,7 +50,9 @@ under the License
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2836#discussion_r89129818
--- Diff: pom.xml ---
@@ -955,9 +996,10 @@ under the License.
${flink.reuseForks
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2766
Thanks for the PR, @EronWright. I think @uce is most familiar with the
network layer. Just wondering from a first quick look, if the code removes
duplicate implementation of network components
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2839
[FLINK-5071][yarn] adjust vcore validation check
The check didn't take the virtual core settings configured in the Flink
configuration into account.
You can merge this pull request into a Git
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2795
That's completely reasonable. For 1.2, should we change the way
`getRuntimeContext().getUserCodeClassLoader()` works for per-job Yarn clusters?
Should it return the system class loader
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2795
Thanks. +1 for reverting then!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2703
I'll merge the changes once the comments have been addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2703
It is easier for the review process when you push fixups commits to pull
requests. Usually we fixup the commits when merging to master.
---
If your project is set up for it, you can reply
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2795
Thanks for the PR @uce! Could you explain how the user would retrieve the
user class loader to load classes during runtime? Is the user class loader
exposed to the user?
---
If your project is set up
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2708
Thanks @greghogan! The changes look good.
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2708
@greghogan It would be helpful to look at the Yarn container files which
include the container environment variables. This would help us to figure out
why the recursive `**` is not working. Another
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2703
Thanks for the PR! Jenkins CI is currently broken but Travis CI passed.
Looks good to me but would be great if you could take a look @EronWright.
---
If your project is set up for it, you can reply
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2708#discussion_r86545553
--- Diff: flink-dist/src/main/flink-bin/yarn-bin/yarn-session.sh ---
@@ -35,14 +33,15 @@ JVM_ARGS="$JVM_ARGS -Xmx512m"
# Flink
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2425
Thank you for the changes. I wonder, could we remove the cookie header
completely for Netty or the BlobServer in case the authorization is turned off?
The Netty protocol has a `MAGIC_NUMBER` which
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2749
[FLINK-3813][yarn] wait for CLI to complete before checking output
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink FLINK-3813
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r86340045
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -788,75 +719,125 @@ private void logAndSysout(String message
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r86324769
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -54,24 +58,36 @@
// constructor in order
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r86321320
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -64,26 +64,25 @@
static final String
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r86322286
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -120,6 +136,15 @@ static LengthFieldBasedFrameDecoder
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r86321008
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -64,26 +64,25 @@
static final String
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r86323404
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServerConnection.java
---
@@ -101,6 +102,14 @@ public void run
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2745
[yarn] fix debug string displayed for failed applications
Merging for `master` and `release-1.1`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2741
Added a test case to verify the error reporting.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2741
[FLINK-4998][yarn] fail if too many task slots are configured
This fails the deployment of the Yarn application if the number of task
slots are configured to be larger than the maximum virtual cores
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2734
Thanks for your PR @vijikarthi! I'll try to check it out as soon as
possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2732
CC @rmetzger @aljoscha Could you take a look at the changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2732
Rebased to the latest changes on the master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2732
[FLINK-4272] Create a JobClient for job control and monitoring
Also includes: [FLINK-4274] Expose new JobClient in the DataSet/DataStream
API
- rename JobClient class to JobClientActorUtils
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2718#discussion_r85523016
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/TimestampedFileInputSplitTest.java
---
@@ -90,4 +112,60 @@ public void
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2718
I think we should get rid of the magic `EOF` split. We should simply set a
flag in the reader to stop reading. Until then, this looks like a good fix.
---
If your project is set up for it, you can
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2618
Merged. Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2692
Pushed a minor change to check which jars are required in case the cluster
is used to execute multiple jobs with different dependencies. Merigng after a
local Travis run.
---
If your project is set up
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2618
Looks good @kl0u. Could you push the rebased version?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2425
CC @uce to check out the network layer changes. This is a very sensitive
and performance critical part of Flink. We should be very sure nothing breaks
it with the changes.
@vijikarthi Please
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r85175840
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -108,6 +111,11 @@
private final Options ALL_OPTIONS
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2692
Thanks for checking out the changes.
Yes, it is handled correctly. Indeed, I started off just thinking about the
user-provided jar but then discovered that the `PackagedProgram` extracts
nested
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2425
@vijikarthi I haven't forgotten about your PR. Thanks for the feedback.
I'll get back to you today.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2692
[FLINK-4913][yarn] include user jar in system class loader
When deploying a Yarn cluster for a single job, this change
pre-configures the cluster to include the user jar(s) on all nodes
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2657#discussion_r84689078
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -202,101 +205,125 @@ public void shutDown() throws
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2671#discussion_r84689568
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/ContinuousEventTimeTrigger.java
---
@@ -99,8 +111,12 @@ public
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2671
Thanks for having a look @aljoscha. Thanks again for the PR @manuzhang.
Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2669#discussion_r84509867
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterConfiguration.java
---
@@ -96,11 +101,20 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2669#discussion_r84509754
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterConfiguration.java
---
@@ -96,11 +101,20 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2669#discussion_r84508885
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterConfiguration.java
---
@@ -162,4 +180,63 @@ public String toString
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2655#discussion_r84506385
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/ResourceManagerJobMasterTest.java
---
@@ -145,6 +171,10 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2655#discussion_r84507291
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/util/TestingFatalErrorHandler.java
---
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2657#discussion_r84501182
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -202,101 +205,125 @@ public void shutDown() throws
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2657#discussion_r84501742
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -471,6 +498,149 @@ public void shutDownCluster(final
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2657#discussion_r84500048
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -202,101 +205,125 @@ public void shutDown() throws
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2651
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2657#discussion_r84500271
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -202,101 +205,125 @@ public void shutDown() throws
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2657#discussion_r84501555
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -471,6 +498,149 @@ public void shutDownCluster(final
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2657#discussion_r84500666
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -202,101 +205,125 @@ public void shutDown() throws
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2657#discussion_r84502118
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -471,6 +498,149 @@ public void shutDownCluster(final
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2671#discussion_r84463868
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/ContinuousEventTimeTrigger.java
---
@@ -99,8 +111,12 @@ public
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2667
Thank you for your contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2671#discussion_r84465826
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/ContinuousEventTimeTrigger.java
---
@@ -88,9 +96,13 @@ public
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2671#discussion_r84465211
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/ContinuousEventTimeTrigger.java
---
@@ -88,9 +96,13 @@ public
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2671#discussion_r84464275
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/ContinuousEventTimeTrigger.java
---
@@ -45,6 +45,12
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2671#discussion_r84464167
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/ContinuousEventTimeTrigger.java
---
@@ -88,9 +96,13 @@ public
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2662#discussion_r84448541
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -975,6 +981,32 @@ private int handleArgException(Exception e
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2662#discussion_r84448442
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/ProgramParametrizationException.java
---
@@ -0,0 +1,46 @@
+/*
+ * Licensed
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r84276796
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
---
@@ -43,16 +41,18
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r84288975
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
---
@@ -347,34 +328,17 @@ public
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2667#discussion_r84290827
--- Diff: flink-contrib/docker-flink/docker-compose.yml ---
@@ -20,16 +20,20 @@ version: "2"
services:
jobmanager:
im
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r84279968
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
---
@@ -189,7 +186,7 @@ public
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r84281147
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/RichFileInputSplit.java
---
@@ -0,0 +1,153
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r84284953
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/RichFileInputSplitTest.java
---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r84288776
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/RichFileInputSplit.java
---
@@ -0,0 +1,153
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r84288567
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/RichFileInputSplit.java
---
@@ -0,0 +1,153
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r84285924
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/RichFileInputSplit.java
---
@@ -0,0 +1,153
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r84288480
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/RichFileInputSplit.java
---
@@ -0,0 +1,153
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r84285533
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/RichFileInputSplit.java
---
@@ -0,0 +1,153
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r84280372
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
---
@@ -199,44 +196,39 @@ public
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2667#discussion_r84242539
--- Diff: flink-contrib/docker-flink/docker-compose.yml ---
@@ -20,16 +20,20 @@ version: "2"
services:
jobmanager:
im
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2618
Thanks for updating the description. Let take a look at the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2657
This doesn't compile currently. Do you prefer if I review the PRs
individually or review the commits in this PR?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2667#discussion_r84242735
--- Diff: flink-contrib/docker-flink/docker-compose.sh ---
@@ -0,0 +1,4 @@
+#!/bin/sh
--- End diff --
Could we name this file `bluemix-docker
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2667#discussion_r84242416
--- Diff: flink-contrib/docker-flink/docker-compose.yml ---
@@ -20,16 +20,20 @@ version: "2"
services:
jobmanager:
im
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2667#discussion_r84241679
--- Diff: flink-contrib/docker-flink/docker-entrypoint.sh ---
@@ -20,11 +20,19 @@
if [ "$1" = "jobmanager" ]; then
echo &
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2662
Thanks for the PR @greghogan! Having a custom exception for missing
arguments to a user program is a good approach. However, it requires the author
of the program to use the custom exception. At least
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2659
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2660
[FLINK-4833] properly log exceptions in CountMinHeavyHitter
This logs the underlying exception properly which could help us to find the
exact cause of the reported problems.
You can merge this pull
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2618
Could you please elaborate on the changes you made to the
`ContinuousFileReaderOperator`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84030548
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyConfig.java
---
@@ -91,6 +94,14 @@ public NettyConfig
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84039282
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1008,6 +1008,9 @@ class JobManager(
case
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84020724
--- Diff: docs/setup/cli.md ---
@@ -217,6 +217,8 @@ Action "run" compiles and runs
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84041338
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -108,6 +111,11 @@
private final Options ALL_OPTIONS
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84035467
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -492,19 +553,22 @@ public void readFrom(ByteBuf buffer
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84032194
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -57,24 +61,37 @@
// constructor in order
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84026759
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobCache.java ---
@@ -272,4 +284,8 @@ private void closeSilently(Closeable closeable
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84036664
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestProtocol.java
---
@@ -30,16 +30,29 @@
private
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84035178
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -369,21 +423,24 @@ void readFrom(ByteBuf buffer) throws
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84033402
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -57,24 +61,37 @@
// constructor in order
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84034881
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -369,21 +423,24 @@ void readFrom(ByteBuf buffer) throws
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84029158
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobUtils.java ---
@@ -393,6 +399,24 @@ static void copyFromRecoveryPath(String recoveryPath
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84035615
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -527,13 +591,17 @@ void readFrom(ByteBuf buffer) throws
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84034660
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -226,8 +277,9 @@ ByteBuf write(ByteBufAllocator
101 - 200 of 1762 matches
Mail list logo
