[GitHub] [hbase] Apache-HBase commented on pull request #2812: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit

2020-12-23 Thread GitBox
Apache-HBase commented on pull request #2812: URL: https://github.com/apache/hbase/pull/2812#issuecomment-750793725 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35

[GitHub] [hbase] Apache-HBase commented on pull request #2812: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit

2020-12-23 Thread GitBox
Apache-HBase commented on pull request #2812: URL: https://github.com/apache/hbase/pull/2812#issuecomment-750792519 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 34

[GitHub] [hbase] Apache-HBase commented on pull request #2811: HBASE-25443 Improve the experience of using the Master webpage by cha…

2020-12-23 Thread GitBox
Apache-HBase commented on pull request #2811: URL: https://github.com/apache/hbase/pull/2811#issuecomment-750792360 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s

[GitHub] [hbase] Apache-HBase commented on pull request #2812: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit

2020-12-23 Thread GitBox
Apache-HBase commented on pull request #2812: URL: https://github.com/apache/hbase/pull/2812#issuecomment-750792223 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28

[GitHub] [hbase] Apache-HBase commented on pull request #2811: HBASE-25443 Improve the experience of using the Master webpage by cha…

2020-12-23 Thread GitBox
Apache-HBase commented on pull request #2811: URL: https://github.com/apache/hbase/pull/2811#issuecomment-750791062 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42

[GitHub] [hbase] ZhaoBQ opened a new pull request #2812: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit

2020-12-23 Thread GitBox
ZhaoBQ opened a new pull request #2812: URL: https://github.com/apache/hbase/pull/2812 [HBASE-25439](https://issues.apache.org/jira/browse/HBASE-25439) Add a new unit 'BYTE' to pretty print value of size, such as MAX_FILESIZE, MEMSTORE_FLUSHSIZE

[jira] [Updated] (HBASE-23898) Add trace support for simple apis in async client

2020-12-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23898: -- Description: The asynchronous hbase client framework (HBASE-16833) was added in HBase 2.0 and doesn't

[jira] [Updated] (HBASE-23898) Add trace support for simple apis in async client

2020-12-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23898: -- Summary: Add trace support for simple apis in async client (was: Add traces in async client) > Add t

[jira] [Updated] (HBASE-23898) Add traces in async client

2020-12-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23898: -- Summary: Add traces in async client (was: [OpenTracing] Add traces in async client) > Add traces in

[jira] [Updated] (HBASE-23898) Add traces in async client

2020-12-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23898: -- Description: The asynchronous hbase client framework (HBASE-16833) was added in HBase 2.0 and doesn't

[GitHub] [hbase] Apache-HBase commented on pull request #2810: HBASE-25441:add security check for stopServer

2020-12-23 Thread GitBox
Apache-HBase commented on pull request #2810: URL: https://github.com/apache/hbase/pull/2810#issuecomment-750766195 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 4

[GitHub] [hbase] Apache-HBase commented on pull request #2810: HBASE-25441:add security check for stopServer

2020-12-23 Thread GitBox
Apache-HBase commented on pull request #2810: URL: https://github.com/apache/hbase/pull/2810#issuecomment-750761701 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s

[GitHub] [hbase] Apache-HBase commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
Apache-HBase commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750758632 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29

[GitHub] [hbase] Apache-HBase commented on pull request #2808: HBASE-25424 Find a way to config OpenTelemetry tracing without direct…

2020-12-23 Thread GitBox
Apache-HBase commented on pull request #2808: URL: https://github.com/apache/hbase/pull/2808#issuecomment-750756778 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s

[jira] [Updated] (HBASE-25432) we should add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25432: -- Summary: we should add security checks for setTableStateInMeta and fixMeta (was: we should add security check

[jira] [Updated] (HBASE-25441) Unauthorized client can shutdown the regionserver

2020-12-23 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25441: -- Priority: Critical (was: Blocker) > Unauthorized client can shutdown the regionserver > -

[jira] [Updated] (HBASE-25432) we should add security checks for stopServer

2020-12-23 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25432: -- Summary: we should add security checks for stopServer (was: we should add security checks for setTableStateIn

[GitHub] [hbase] Apache-HBase commented on pull request #2800: HBASE-25249 Adding StoreContext

2020-12-23 Thread GitBox
Apache-HBase commented on pull request #2800: URL: https://github.com/apache/hbase/pull/2800#issuecomment-750751712 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 55

[GitHub] [hbase] Apache-HBase commented on pull request #2800: HBASE-25249 Adding StoreContext

2020-12-23 Thread GitBox
Apache-HBase commented on pull request #2800: URL: https://github.com/apache/hbase/pull/2800#issuecomment-750750054 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12

[GitHub] [hbase] lujiefsi commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
lujiefsi commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750747992 Due to verifyDenied do not handle the RemoteWithExtrasException, so the AccessDeniedException are warpped and could not be seen by test. I have fixed it. --

[GitHub] [hbase] Apache-HBase commented on pull request #2811: HBASE-25443 Improve the experience of using the Master webpage by cha…

2020-12-23 Thread GitBox
Apache-HBase commented on pull request #2811: URL: https://github.com/apache/hbase/pull/2811#issuecomment-750746081 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37

[jira] [Updated] (HBASE-25443) Improve the experience of using the Master webpage by change the loading process of snapshot list to asynchronous

2020-12-23 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuoyue Huang updated HBASE-25443: -- Attachment: image-2020-12-24-13-17-17-213.png > Improve the experience of using the Master web

[jira] [Commented] (HBASE-25443) Improve the experience of using the Master webpage by change the loading process of snapshot list to asynchronous

2020-12-23 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254404#comment-17254404 ] Zhuoyue Huang commented on HBASE-25443: --- Has been successfully tested locally !im

[GitHub] [hbase] GeorryHuang opened a new pull request #2811: HBASE-25443 Improve the experience of using the Master webpage by cha…

2020-12-23 Thread GitBox
GeorryHuang opened a new pull request #2811: URL: https://github.com/apache/hbase/pull/2811 …nge the loading process of snapshot list to asynchronous 1. The MasterStatusTmpl.jamon does not load the snapshots list. 2. Asynchronously request the snapshots list and fill the response h

[jira] [Created] (HBASE-25443) Improve the experience of using the Master webpage by change the loading process of snapshot list to asynchronous

2020-12-23 Thread Zhuoyue Huang (Jira)
Zhuoyue Huang created HBASE-25443: - Summary: Improve the experience of using the Master webpage by change the loading process of snapshot list to asynchronous Key: HBASE-25443 URL: https://issues.apache.org/jira/b

[GitHub] [hbase] lujiefsi edited a comment on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
lujiefsi edited a comment on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750731066 > > @virajjasani > > I try to use code "hbck = TEST_UTIL.getConnection(USER_NONE).getHbck()" to gain the hbck, but UT still failed to pass. So I perfer to commit this PR

[GitHub] [hbase] lujiefsi edited a comment on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
lujiefsi edited a comment on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750731066 > > @virajjasani > > I try to use code "hbck = TEST_UTIL.getConnection(USER_NONE).getHbck()" to gain the hbck, but UT still failed to pass. So I perfer to commit this PR

[GitHub] [hbase] lujiefsi commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
lujiefsi commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750732797 > (hahaha, sorry. I'm overlapping with Duo :) ) > > > I try to use code "hbck = TEST_UTIL.getConnection(USER_NONE).getHbck()" to gain the hbck, but UT still failed to pass.

[GitHub] [hbase] lujiefsi commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
lujiefsi commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750732297 > (hahaha, sorry. I'm overlapping with Duo :) ) > > > I try to use code "hbck = TEST_UTIL.getConnection(USER_NONE).getHbck()" to gain the hbck, but UT still failed to pass.

[GitHub] [hbase] Apache-HBase commented on pull request #2810: HBASE-25441:add security check for stopServer

2020-12-23 Thread GitBox
Apache-HBase commented on pull request #2810: URL: https://github.com/apache/hbase/pull/2810#issuecomment-750731217 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29

[GitHub] [hbase] lujiefsi commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
lujiefsi commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750731066 > > @virajjasani > > I try to use code "hbck = TEST_UTIL.getConnection(USER_NONE).getHbck()" to gain the hbck, but UT still failed to pass. So I perfer to commit this PR witho

[GitHub] [hbase] lujiefsi commented on pull request #2810: HBASE-25441:add security check for stopServer

2020-12-23 Thread GitBox
lujiefsi commented on pull request #2810: URL: https://github.com/apache/hbase/pull/2810#issuecomment-750724569 @virajjasani @Apache9 @joshelser I found that there are also some other API has annotation "ADMIN_QOS" on RSRPCServices ,like executeProcedures clearSlowLogsResponses, shou

[GitHub] [hbase] lujiefsi opened a new pull request #2810: HBASE-25441:add security check for stopServer

2020-12-23 Thread GitBox
lujiefsi opened a new pull request #2810: URL: https://github.com/apache/hbase/pull/2810 We miss securiry check before stopServer on RS, which make unauthorized client can shutdown RS. The message after fix is: ERROR RuntimeError: org.apache.hadoop.hbase.security.AccessDeniedExceptio

[jira] [Updated] (HBASE-25441) Unauthorized client can shutdown the regionserver

2020-12-23 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25441: -- Description: (was: In think all the shutdowncomand  should gothrough master, by this we can authorize the

[jira] [Created] (HBASE-25442) Refactor MultiVersionConcurrencyControl: replace readWaiters.notifyAll() with WriteEntry.notify()

2020-12-23 Thread Yulin Niu (Jira)
Yulin Niu created HBASE-25442: - Summary: Refactor MultiVersionConcurrencyControl: replace readWaiters.notifyAll() with WriteEntry.notify() Key: HBASE-25442 URL: https://issues.apache.org/jira/browse/HBASE-25442

[GitHub] [hbase] Apache-HBase commented on pull request #2808: HBASE-25424 Find a way to config OpenTelemetry tracing without direct…

2020-12-23 Thread GitBox
Apache-HBase commented on pull request #2808: URL: https://github.com/apache/hbase/pull/2808#issuecomment-750719534 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29

[jira] [Work started] (HBASE-23898) [OpenTracing] Add traces in async client

2020-12-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-23898 started by Duo Zhang. - > [OpenTracing] Add traces in async client >

[jira] [Resolved] (HBASE-23757) [OpenTracing] Migrate from HTrace to OpenTracing (Java code)

2020-12-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-23757. --- Resolution: Won't Fix > [OpenTracing] Migrate from HTrace to OpenTracing (Java code) > -

[jira] [Updated] (HBASE-23757) [OpenTracing] Migrate from HTrace to OpenTracing (Java code)

2020-12-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23757: -- Status: Open (was: Patch Available) > [OpenTracing] Migrate from HTrace to OpenTracing (Java code) >

[jira] [Assigned] (HBASE-23898) [OpenTracing] Add traces in async client

2020-12-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-23898: - Assignee: Duo Zhang (was: Wei-Chiu Chuang) > [OpenTracing] Add traces in async client > --

[GitHub] [hbase] Apache9 closed pull request #1210: HBASE-23757. [OpenTracing] Migrate from HTrace to OpenTracing (Java code)

2020-12-23 Thread GitBox
Apache9 closed pull request #1210: URL: https://github.com/apache/hbase/pull/1210 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [hbase] Apache9 commented on pull request #1210: HBASE-23757. [OpenTracing] Migrate from HTrace to OpenTracing (Java code)

2020-12-23 Thread GitBox
Apache9 commented on pull request #1210: URL: https://github.com/apache/hbase/pull/1210#issuecomment-750712186 We plan to go with open telemetry for now. This is an automated message from the Apache Git Service. To respond to

[jira] [Resolved] (HBASE-23756) [OpenTracing] Add OpenTracing dependency and helper methods

2020-12-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-23756. --- Resolution: Won't Fix > [OpenTracing] Add OpenTracing dependency and helper methods > --

[GitHub] [hbase] Apache-HBase commented on pull request #2808: HBASE-25424 Find a way to config OpenTelemetry tracing without direct…

2020-12-23 Thread GitBox
Apache-HBase commented on pull request #2808: URL: https://github.com/apache/hbase/pull/2808#issuecomment-750711730 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28

[GitHub] [hbase] infraio commented on a change in pull request #2808: HBASE-25424 Find a way to config OpenTelemetry tracing without direct…

2020-12-23 Thread GitBox
infraio commented on a change in pull request #2808: URL: https://github.com/apache/hbase/pull/2808#discussion_r548355972 ## File path: conf/hbase-env.sh ## @@ -142,3 +142,7 @@ # Override text processing tools for use by these launch scripts. # export GREP="${GREP-grep}" # e

[GitHub] [hbase] Apache9 closed pull request #1202: HBASE-23756. [OpenTracing] Add OpenTracing dependency and helper methods.

2020-12-23 Thread GitBox
Apache9 closed pull request #1202: URL: https://github.com/apache/hbase/pull/1202 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [hbase] Apache9 commented on pull request #1202: HBASE-23756. [OpenTracing] Add OpenTracing dependency and helper methods.

2020-12-23 Thread GitBox
Apache9 commented on pull request #1202: URL: https://github.com/apache/hbase/pull/1202#issuecomment-750711513 We plan to go with open telemetry for now. This is an automated message from the Apache Git Service. To respond to

[jira] [Updated] (HBASE-23756) [OpenTracing] Add OpenTracing dependency and helper methods

2020-12-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23756: -- Status: Open (was: Patch Available) > [OpenTracing] Add OpenTracing dependency and helper methods > -

[GitHub] [hbase] joshelser edited a comment on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
joshelser edited a comment on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750710601 (hahaha, sorry. I'm overlapping with Duo :) ) > I try to use code "hbck = TEST_UTIL.getConnection(USER_NONE).getHbck()" to gain the hbck, but UT still failed to pas

[jira] [Updated] (HBASE-25441) Unauthorized client can shutdown the regionserver

2020-12-23 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25441: -- Description: In think all the shutdowncomand  should gothrough master, by this we can authorize the user reque

[GitHub] [hbase] joshelser commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
joshelser commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750710601 > I try to use code "hbck = TEST_UTIL.getConnection(USER_NONE).getHbck()" to gain the hbck, but UT still failed to pass. So I perfer to commit this PR without UT as its patch wo

[GitHub] [hbase] Apache9 commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
Apache9 commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750710595 > @virajjasani > I try to use code "hbck = TEST_UTIL.getConnection(USER_NONE).getHbck()" to gain the hbck, but UT still failed to pass. So I perfer to commit this PR without UT

[GitHub] [hbase] Apache9 commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
Apache9 commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750710121 I think the fix is OK for now. Checked HBASE-19400, we want to move the permission check out of a CP but it is only half done... -

[jira] [Updated] (HBASE-25441) Unauthorized client can shutdown the regionserver

2020-12-23 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25441: -- Description: In think all the shutcomand  should gothrough master, by this we can authorize the user request.

[jira] [Updated] (HBASE-25441) Unauthorized client can shutdown the regionserver

2020-12-23 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25441: -- Description: In think all the shutcomand  should gothrough master, by this we can  > Unauthorized client can

[GitHub] [hbase] Apache-HBase commented on pull request #2800: HBASE-25249 Adding StoreContext

2020-12-23 Thread GitBox
Apache-HBase commented on pull request #2800: URL: https://github.com/apache/hbase/pull/2800#issuecomment-750707146 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 55

[jira] [Updated] (HBASE-25439) Add BYTE unit in PrettyPrinter.Unit

2020-12-23 Thread Baiqiang Zhao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Baiqiang Zhao updated HBASE-25439: -- Affects Version/s: 3.0.0-alpha-1 > Add BYTE unit in PrettyPrinter.Unit >

[jira] [Created] (HBASE-25441) Unauthorized client can shutdown the regionserver

2020-12-23 Thread lujie (Jira)
lujie created HBASE-25441: - Summary: Unauthorized client can shutdown the regionserver Key: HBASE-25441 URL: https://issues.apache.org/jira/browse/HBASE-25441 Project: HBase Issue Type: Bug

[jira] [Commented] (HBASE-24725) Add RC number to the description in nexus staging repository

2020-12-23 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254358#comment-17254358 ] Michael Stack commented on HBASE-24725: --- You can set the description when doing th

[GitHub] [hbase] Apache-HBase commented on pull request #2800: HBASE-25249 Adding StoreContext

2020-12-23 Thread GitBox
Apache-HBase commented on pull request #2800: URL: https://github.com/apache/hbase/pull/2800#issuecomment-750694698 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29

[jira] [Commented] (HBASE-25440) create-release fails download of artifacts on gcp

2020-12-23 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254324#comment-17254324 ] Michael Stack commented on HBASE-25440: --- Was unable to figure gpg-agent forwarding

[GitHub] [hbase] taklwu commented on a change in pull request #2800: HBASE-25249 Adding StoreContext

2020-12-23 Thread GitBox
taklwu commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r548317844 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -246,6 +234,8 @@ private AtomicLong compactedCellsSize =

[GitHub] [hbase] Apache-HBase commented on pull request #2800: HBASE-25249 Adding StoreContext

2020-12-23 Thread GitBox
Apache-HBase commented on pull request #2800: URL: https://github.com/apache/hbase/pull/2800#issuecomment-750543803 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 13

[GitHub] [hbase] taklwu commented on a change in pull request #2800: HBASE-25249 Adding HStoreContext

2020-12-23 Thread GitBox
taklwu commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r548286395 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -1236,18 +1248,19 @@ private HFileContext createFileContext

[GitHub] [hbase] taklwu commented on a change in pull request #2800: HBASE-25249 Adding HStoreContext

2020-12-23 Thread GitBox
taklwu commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r548281843 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -246,6 +234,8 @@ private AtomicLong compactedCellsSize =

[jira] [Commented] (HBASE-25440) create-release fails download of artifacts on gcp

2020-12-23 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254254#comment-17254254 ] Michael Stack commented on HBASE-25440: --- Setting the iptables rule doesn't help th

[jira] [Commented] (HBASE-25438) Update create-release mvn in Dockerfile; its 3.6.0; make it 3.6.3

2020-12-23 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254252#comment-17254252 ] Michael Stack commented on HBASE-25438: --- I tried adding: {{diff --git a/dev-suppor

[jira] [Created] (HBASE-25440) create-release fails download of artifacts on gcp

2020-12-23 Thread Michael Stack (Jira)
Michael Stack created HBASE-25440: - Summary: create-release fails download of artifacts on gcp Key: HBASE-25440 URL: https://issues.apache.org/jira/browse/HBASE-25440 Project: HBase Issue Typ

[GitHub] [hbase] Apache-HBase commented on pull request #2800: HBASE-25249 Adding HStoreContext

2020-12-23 Thread GitBox
Apache-HBase commented on pull request #2800: URL: https://github.com/apache/hbase/pull/2800#issuecomment-750473295 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 34

[GitHub] [hbase] saintstack commented on a change in pull request #2800: HBASE-25249 Adding HStoreContext

2020-12-23 Thread GitBox
saintstack commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r548213446 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -246,6 +234,8 @@ private AtomicLong compactedCellsSiz

[GitHub] [hbase] z-york commented on a change in pull request #2800: HBASE-25249 Adding HStoreContext

2020-12-23 Thread GitBox
z-york commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r548209948 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -246,6 +234,8 @@ private AtomicLong compactedCellsSize =

[GitHub] [hbase] z-york commented on a change in pull request #2800: HBASE-25249 Adding HStoreContext

2020-12-23 Thread GitBox
z-york commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r548200446 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -246,6 +234,8 @@ private AtomicLong compactedCellsSize =

[GitHub] [hbase] taklwu commented on a change in pull request #2800: HBASE-25249 Adding HStoreContext

2020-12-23 Thread GitBox
taklwu commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r548126048 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -246,6 +234,8 @@ private AtomicLong compactedCellsSize =

[GitHub] [hbase] taklwu commented on a change in pull request #2800: HBASE-25249 Adding HStoreContext

2020-12-23 Thread GitBox
taklwu commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r548162792 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreUtils.java ## @@ -136,4 +140,26 @@ public static OptionalLong getMaxSequ

[GitHub] [hbase] Apache-HBase commented on pull request #2808: HBASE-25424 Find a way to config OpenTelemetry tracing without direct…

2020-12-23 Thread GitBox
Apache-HBase commented on pull request #2808: URL: https://github.com/apache/hbase/pull/2808#issuecomment-750431882 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 14s

[GitHub] [hbase] taklwu commented on a change in pull request #2800: HBASE-25249 Adding HStoreContext

2020-12-23 Thread GitBox
taklwu commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r548126048 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -246,6 +234,8 @@ private AtomicLong compactedCellsSize =

[GitHub] [hbase] Apache-HBase commented on pull request #2804: HBASE-25437 Update refguide RC section; point at the dev-tools/create…

2020-12-23 Thread GitBox
Apache-HBase commented on pull request #2804: URL: https://github.com/apache/hbase/pull/2804#issuecomment-750386712 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28

[GitHub] [hbase] virajjasani commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
virajjasani commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750383118 > Above code is the test code, but i found that RPCServe still use admin user > > _protected void requirePermission(String request, Permission.Action perm) throws IOExce

[GitHub] [hbase] lujiefsi commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
lujiefsi commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750382791 By the way, i do not find any UT about rpcPreCheck, we need one. This is an automated message from the Apache Git

[GitHub] [hbase] lujiefsi edited a comment on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
lujiefsi edited a comment on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750380940 @virajjasani I try to use code "hbck = TEST_UTIL.getConnection(USER_NONE).getHbck()" to gain the hbck, but UT still failed to pass. So I perfer to commit this PR wit

[GitHub] [hbase] lujiefsi commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
lujiefsi commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750380940 @virajjasani I try to use code "hbck = TEST_UTIL.getConnection(USER_NONE).getHbck()" to gain the hbck, but UT still failed to pass. So I perfer to commit this PR without UT

[GitHub] [hbase] Apache-HBase commented on pull request #2804: HBASE-25437 Update refguide RC section; point at the dev-tools/create…

2020-12-23 Thread GitBox
Apache-HBase commented on pull request #2804: URL: https://github.com/apache/hbase/pull/2804#issuecomment-750380562 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 22

[GitHub] [hbase] Apache-HBase commented on pull request #2804: HBASE-25437 Update refguide RC section; point at the dev-tools/create…

2020-12-23 Thread GitBox
Apache-HBase commented on pull request #2804: URL: https://github.com/apache/hbase/pull/2804#issuecomment-750380248 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42

[GitHub] [hbase] Apache-HBase commented on pull request #2808: HBASE-25424 Find a way to config OpenTelemetry tracing without direct…

2020-12-23 Thread GitBox
Apache-HBase commented on pull request #2808: URL: https://github.com/apache/hbase/pull/2808#issuecomment-750374678 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 9m 22

[GitHub] [hbase] Apache-HBase commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
Apache-HBase commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750363141 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 28

[GitHub] [hbase] Apache-HBase commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
Apache-HBase commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750359871 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 27

[GitHub] [hbase] lujiefsi edited a comment on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
lujiefsi edited a comment on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750342006 @virajjasani I will add a test case, ther still a problem for unit test, i will figure it out. _public void testUnauthorizedSetTableStateInMeta() throws Except

[GitHub] [hbase] lujiefsi edited a comment on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
lujiefsi edited a comment on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750342006 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [hbase] lujiefsi edited a comment on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
lujiefsi edited a comment on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750342006 @virajjasani I will add a test case, but i find that there maybe a bug in RPC for test. _public void testUnauthorizedSetTableStateInMeta() throws Exception {

[GitHub] [hbase] lujiefsi edited a comment on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
lujiefsi edited a comment on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750342006 @virajjasani I will add a test case, but i find that there maybe a bug in RPC for test. _public void testUnauthorizedSetTableStateInMeta() throws Exception {

[GitHub] [hbase] lujiefsi edited a comment on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
lujiefsi edited a comment on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750342006 @virajjasani I will add a test case, but i find that there maybe a bug in RPC for test. _public void testUnauthorizedSetTableStateInMeta() throws Exception {

[GitHub] [hbase] lujiefsi edited a comment on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
lujiefsi edited a comment on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750342006 @virajjasani I will add a test case, but i find that there maybe a bug in RPC for test, i will figure it out and push later. _public void testUnauthorizedSetTabl

[GitHub] [hbase] lujiefsi edited a comment on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
lujiefsi edited a comment on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750342006 @virajjasani I will add a test case, but i find that there maybe a bug in RPC for test, i will figure it out and push later. _public void testUnauthorizedSetTabl

[GitHub] [hbase] lujiefsi edited a comment on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
lujiefsi edited a comment on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750342006 @virajjasani I will add a test case, but i find that there maybe a bug in RPC for test, i will figure it out and push later. public void testUnauthorizedSetTable

[GitHub] [hbase] lujiefsi edited a comment on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
lujiefsi edited a comment on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750342006 @virajjasani I will add a test case, but i find that there maybe a bug in RPC for test, i will figure it out and push later. `public void testUnauthorizedSetTabl

[GitHub] [hbase] lujiefsi edited a comment on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
lujiefsi edited a comment on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750342006 @virajjasani I will add a test case, but i find that there maybe a bug in RPC for test, i will figure it out and push later. ` public void testUnauthorizedSetTa

[GitHub] [hbase] lujiefsi edited a comment on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
lujiefsi edited a comment on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750342006 @virajjasani I will add a test case, but i find that there maybe a bug in RPC for test, i will figure it out and push later. ` public void testUnauthorizedSetTa

[GitHub] [hbase] lujiefsi removed a comment on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
lujiefsi removed a comment on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750340911 > TestAccessController This is an automated message from the Apache Git Service. To respond to th

[GitHub] [hbase] lujiefsi commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
lujiefsi commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750342006 @virajjasani I will add a test case, but i find that there maybe a bug in RPC for test, i will figure it out and push later.

[GitHub] [hbase] lujiefsi closed pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-23 Thread GitBox
lujiefsi closed pull request #2809: URL: https://github.com/apache/hbase/pull/2809 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

  1   2   >