Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

igoradulian closed pull request #9793: #9073 Junit 4 tests switched to JUnit 5 URL: https://github.com/apache/iceberg/pull/9793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

igoradulian commented on PR #9793: URL: https://github.com/apache/iceberg/pull/9793#issuecomment-2126211802 @nastra please review last changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1600580363 ## data/src/test/java/org/apache/iceberg/data/avro/TestSingleMessageEncoding.java: ## @@ -87,8 +86,10 @@ public void testByteBufferRoundTrip() throws Exception {

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1600578495 ## data/src/test/java/org/apache/iceberg/data/TestLocalScan.java: ## @@ -401,15 +391,15 @@ public void testProjectWithMissingFilterColumn() { } results.forEa

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1600577333 ## data/src/test/java/org/apache/iceberg/data/TestLocalScan.java: ## @@ -281,36 +271,33 @@ public void testFullScan() { expected.addAll(file3FirstSnapshotRecords);

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1600577909 ## data/src/test/java/org/apache/iceberg/data/TestLocalScan.java: ## @@ -326,15 +313,17 @@ private void verifyProjectIdColumn(Iterable results) { Lists.transfo

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1600575976 ## data/src/test/java/org/apache/iceberg/data/TestLocalScan.java: ## @@ -266,12 +255,13 @@ public void testRandomData() throws IOException { append.commit();

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1600575335 ## data/src/test/java/org/apache/iceberg/data/TestLocalScan.java: ## @@ -60,15 +53,15 @@ import org.apache.iceberg.types.Types; import org.apache.iceberg.util.DateTime

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1600574151 ## data/src/test/java/org/apache/iceberg/data/TestLocalScan.java: ## @@ -32,21 +32,14 @@ import java.io.IOException; import java.nio.ByteBuffer; import java.nio.ByteO

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1600572291 ## data/src/test/java/org/apache/iceberg/data/TestGenericRecord.java: ## @@ -35,7 +34,7 @@ public void testGetNullValue() { GenericRecord record = GenericRecord.cre

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1600568625 ## data/src/test/java/org/apache/iceberg/data/TestDataFileIndexStatsFilters.java: ## @@ -94,24 +94,24 @@ public void createTableAndData() throws IOException {

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1600568625 ## data/src/test/java/org/apache/iceberg/data/TestDataFileIndexStatsFilters.java: ## @@ -94,24 +94,24 @@ public void createTableAndData() throws IOException {

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

igoradulian commented on PR #9793: URL: https://github.com/apache/iceberg/pull/9793#issuecomment-2111021027 @nastra please review last updates -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1584318949 ## data/src/test/java/org/apache/iceberg/data/orc/TestOrcRowIterator.java: ## @@ -59,17 +58,14 @@ public class TestOrcRowIterator { } } - @Rule public Tempora

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1584318220 ## data/src/test/java/org/apache/iceberg/data/parquet/TestGenericReadProjection.java: ## @@ -32,7 +32,7 @@ public class TestGenericReadProjection extends TestReadProjec

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1584317050 ## data/src/test/java/org/apache/iceberg/data/avro/TestGenericReadProjection.java: ## @@ -32,7 +32,7 @@ public class TestGenericReadProjection extends TestReadProjectio

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1584314134 ## data/src/test/java/org/apache/iceberg/data/avro/TestSingleMessageEncoding.java: ## @@ -87,8 +86,12 @@ public void testByteBufferRoundTrip() throws Exception {

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1584317050 ## data/src/test/java/org/apache/iceberg/data/avro/TestGenericReadProjection.java: ## @@ -32,7 +32,7 @@ public class TestGenericReadProjection extends TestReadProjectio

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1584316540 ## data/src/test/java/org/apache/iceberg/data/orc/TestGenericReadProjection.java: ## @@ -33,7 +33,8 @@ public class TestGenericReadProjection extends TestReadProjection

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1584310664 ## data/src/test/java/org/apache/iceberg/data/TestLocalScan.java: ## @@ -378,11 +368,11 @@ public void testProjectWithSchema() { GenericRecord.create(schema)

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1584312612 ## data/src/test/java/org/apache/iceberg/data/TestMetricsRowGroupFilterTypes.java: ## @@ -282,28 +286,33 @@ public TestMetricsRowGroupFilterTypes( this.skipValue =

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1584310161 ## data/src/test/java/org/apache/iceberg/data/TestLocalScan.java: ## @@ -345,7 +335,7 @@ public void testProjectWithSchema() { expected.addAll(file3FirstSnapshotRec

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1584309569 ## data/src/test/java/org/apache/iceberg/data/TestLocalScan.java: ## @@ -281,36 +271,34 @@ public void testFullScan() { expected.addAll(file3FirstSnapshotRecords);

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1584308953 ## data/src/test/java/org/apache/iceberg/data/TestLocalScan.java: ## @@ -266,12 +255,13 @@ public void testRandomData() throws IOException { append.commit();

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1584253188 ## data/src/test/java/org/apache/iceberg/data/TestLocalScan.java: ## @@ -77,19 +70,15 @@ public class TestLocalScan { private static final Configuration CONF = new Co

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1584252010 ## data/src/test/java/org/apache/iceberg/data/TestLocalScan.java: ## @@ -32,21 +32,14 @@ import java.io.IOException; import java.nio.ByteBuffer; import java.nio.ByteO

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1584251085 ## data/src/test/java/org/apache/iceberg/data/TestGenericRecord.java: ## @@ -55,7 +54,7 @@ public void testGetIncorrectClassInstance() { record.set(0, 10L);

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1584248713 ## data/src/test/java/org/apache/iceberg/data/TestDataFileIndexStatsFilters.java: ## @@ -243,10 +240,11 @@ public void testEqualityDeletePlanningStatsNullValueWithAllNu

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1584249241 ## data/src/test/java/org/apache/iceberg/data/TestDataFileIndexStatsFilters.java: ## @@ -217,10 +214,11 @@ public void testEqualityDeletePlanningStatsFilter() throws IO

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1584247912 ## data/src/test/java/org/apache/iceberg/data/TestDataFileIndexStatsFilters.java: ## @@ -163,10 +163,9 @@ public void testPositionDeletePlanningPathFilter() throws IOEx

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1584247912 ## data/src/test/java/org/apache/iceberg/data/TestDataFileIndexStatsFilters.java: ## @@ -163,10 +163,9 @@ public void testPositionDeletePlanningPathFilter() throws IOEx

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1584247169 ## data/src/test/java/org/apache/iceberg/data/TestDataFileIndexStatsFilters.java: ## @@ -189,10 +187,10 @@ public void testEqualityDeletePlanningStats() throws IOExcept

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1584246393 ## data/src/test/java/org/apache/iceberg/data/TestDataFileIndexStatsFilters.java: ## @@ -217,10 +214,11 @@ public void testEqualityDeletePlanningStatsFilter() throws IO

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1584244839 ## data/src/test/java/org/apache/iceberg/data/TestDataFileIndexStatsFilters.java: ## @@ -217,10 +214,11 @@ public void testEqualityDeletePlanningStatsFilter() throws IO

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1584243797 ## data/src/test/java/org/apache/iceberg/data/TestDataFileIndexStatsFilters.java: ## @@ -217,10 +214,11 @@ public void testEqualityDeletePlanningStatsFilter() throws IO

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1584242454 ## data/src/test/java/org/apache/iceberg/data/TestDataFileIndexStatsFilters.java: ## @@ -94,24 +94,24 @@ public void createTableAndData() throws IOException {

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1584240147 ## data/src/test/java/org/apache/iceberg/data/DataTestHelpers.java: ## @@ -43,7 +42,9 @@ public static void assertEquals(Types.StructType struct, Record expected, Recor

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

igoradulian commented on PR #9793: URL: https://github.com/apache/iceberg/pull/9793#issuecomment-2084436773 @nastra, please review recent changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568292423 ## data/src/test/java/org/apache/iceberg/data/TestReadProjection.java: ## @@ -76,20 +78,21 @@ public void testSpecialCharacterProjection() throws Exception { Rec

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568271659 ## data/src/test/java/org/apache/iceberg/data/TestReadProjection.java: ## @@ -31,16 +34,14 @@ import org.apache.iceberg.types.Comparators; import org.apache.iceberg.ty

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568270818 ## data/src/test/java/org/apache/iceberg/data/TestLocalScan.java: ## @@ -281,36 +272,36 @@ public void testFullScan() { expected.addAll(file3FirstSnapshotRecords);

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568270613 ## data/src/test/java/org/apache/iceberg/data/TestLocalScan.java: ## @@ -281,36 +272,36 @@ public void testFullScan() { expected.addAll(file3FirstSnapshotRecords);

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568270029 ## data/src/test/java/org/apache/iceberg/data/TestLocalScan.java: ## @@ -266,12 +254,15 @@ public void testRandomData() throws IOException { append.commit();

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568268561 ## data/src/test/java/org/apache/iceberg/data/TestLocalScan.java: ## @@ -32,21 +32,14 @@ import java.io.IOException; import java.nio.ByteBuffer; import java.nio.ByteO

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568268169 ## data/src/test/java/org/apache/iceberg/data/TestLocalScan.java: ## @@ -60,15 +62,12 @@ import org.apache.iceberg.types.Types; import org.apache.iceberg.util.DateTime

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568268169 ## data/src/test/java/org/apache/iceberg/data/TestLocalScan.java: ## @@ -60,15 +62,12 @@ import org.apache.iceberg.types.Types; import org.apache.iceberg.util.DateTime

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568267658 ## data/src/test/java/org/apache/iceberg/data/TestDataFileIndexStatsFilters.java: ## @@ -189,10 +188,11 @@ public void testEqualityDeletePlanningStats() throws IOExcept

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568267490 ## data/src/test/java/org/apache/iceberg/data/TestDataFileIndexStatsFilters.java: ## @@ -163,10 +163,10 @@ public void testPositionDeletePlanningPathFilter() throws IOE

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568266969 ## data/src/test/java/org/apache/iceberg/data/TestDataFileIndexStatsFilters.java: ## @@ -137,9 +135,11 @@ public void testPositionDeletePlanningPath() throws IOExceptio

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568265618 ## data/src/test/java/org/apache/iceberg/data/TestDataFileIndexStatsFilters.java: ## @@ -94,24 +93,23 @@ public void createTableAndData() throws IOException {

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568264984 ## data/src/test/java/org/apache/iceberg/data/TestDataFileIndexStatsFilters.java: ## @@ -68,9 +67,9 @@ public class TestDataFileIndexStatsFilters { private DataFile d

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568264243 ## data/src/test/java/org/apache/iceberg/data/TestDataFileIndexStatsFilters.java: ## @@ -58,7 +57,7 @@ public class TestDataFileIndexStatsFilters { Types.Nest

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568263803 ## data/src/test/java/org/apache/iceberg/data/DeleteReadTests.java: ## @@ -45,10 +38,12 @@ import org.apache.iceberg.util.Pair; import org.apache.iceberg.util.StructLi

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568262204 ## data/src/test/java/org/apache/iceberg/data/DataTestHelpers.java: ## @@ -84,16 +86,15 @@ private static void assertEquals(Type type, Object expected, Object actual) {

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568261644 ## data/src/test/java/org/apache/iceberg/data/DataTestHelpers.java: ## @@ -43,7 +42,9 @@ public static void assertEquals(Types.StructType struct, Record expected, Recor

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568263144 ## data/src/test/java/org/apache/iceberg/data/DataTestHelpers.java: ## @@ -84,16 +86,15 @@ private static void assertEquals(Type type, Object expected, Object actual) {

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568260729 ## data/src/test/java/org/apache/iceberg/data/TestGenericRecord.java: ## @@ -35,7 +34,7 @@ public void testGetNullValue() { GenericRecord record = GenericRecord.cre

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568261957 ## data/src/test/java/org/apache/iceberg/data/DataTestHelpers.java: ## @@ -56,7 +57,8 @@ public static void assertEquals(Types.ListType list, List expected, List a p

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568261117 ## data/src/test/java/org/apache/iceberg/data/DataTest.java: ## @@ -21,6 +21,7 @@ import static org.apache.iceberg.types.Types.NestedField.optional; import static org.

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568260531 ## data/src/test/java/org/apache/iceberg/data/TestGenericReaderDeletes.java: ## @@ -18,28 +18,23 @@ */ package org.apache.iceberg.data; -import static org.assertj.c

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

igoradulian commented on PR #9793: URL: https://github.com/apache/iceberg/pull/9793#issuecomment-2059879886 @nastra please review the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1555319681 ## data/src/test/java/org/apache/iceberg/RecordWrapperTest.java: ## @@ -103,11 +103,11 @@ public void testNestedSchema() { } private void generateAndValidate(Sch

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1555322359 ## data/src/test/java/org/apache/iceberg/data/TestDataFileIndexStatsFilters.java: ## @@ -137,9 +135,11 @@ public void testPositionDeletePlanningPath() throws IOExceptio

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

igoradulian commented on PR #9793: URL: https://github.com/apache/iceberg/pull/9793#issuecomment-2041857202 @nastra I updated PR, please review it and let me know if further changes are needed. BTW, some tests don't pass and I didn't touch tests that are dependant on tests and classes from

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on PR #9793: URL: https://github.com/apache/iceberg/pull/9793#issuecomment-2034605250 > @nastra yes, I'm gonna made changes you proposed. In majority changes I switched Junit4 to Junit5 not AssertJ because it was said to switch to Junit5. Anyway, thank you for your comments

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

igoradulian commented on PR #9793: URL: https://github.com/apache/iceberg/pull/9793#issuecomment-2034574140 @nastra yes, I'm gonna made changes you proposed. In majority changes I switched Junit4 to Junit5 not AssertJ because it was said to switch to Junit5. Anyway, thank you for your comme

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1549453971 ## data/src/test/java/org/apache/iceberg/data/avro/TestSingleMessageEncoding.java: ## @@ -122,7 +123,7 @@ public void testSchemaEvolution() throws Exception { dec

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1549450840 ## data/src/test/java/org/apache/iceberg/data/DeleteReadTests.java: ## @@ -108,11 +112,8 @@ public void writeTestDataFile() throws IOException { records.add(record.

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1549452602 ## data/src/test/java/org/apache/iceberg/data/TestGenericRecord.java: ## @@ -19,12 +19,12 @@ package org.apache.iceberg.data; import static org.apache.iceberg.types.

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1549452056 ## data/src/test/java/org/apache/iceberg/data/TestGenericReaderDeletes.java: ## @@ -38,7 +38,8 @@ public class TestGenericReaderDeletes extends DeleteReadTests { @

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1549451494 ## data/src/test/java/org/apache/iceberg/data/TestDataFileIndexStatsFilters.java: ## @@ -85,33 +84,25 @@ public void createTableAndData() throws IOException { recor

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1549445167 ## data/src/test/java/org/apache/iceberg/data/DeleteReadTests.java: ## @@ -108,11 +112,8 @@ public void writeTestDataFile() throws IOException { records.add(record.

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1549444931 ## data/src/test/java/org/apache/iceberg/data/DeleteReadTests.java: ## @@ -18,6 +18,7 @@ */ package org.apache.iceberg.data; + Review Comment: unnecessary newli

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1547543252 ## data/src/test/java/org/apache/iceberg/data/DataTestHelpers.java: ## @@ -84,16 +86,16 @@ private static void assertEquals(Type type, Object expected, Object actual) {

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on PR #9793: URL: https://github.com/apache/iceberg/pull/9793#issuecomment-2025343375 @igoradulian are you planning on updating this PR? There are a bunch of import changes that would need to be reverted. Also make sure to run `./gradlew spotlessApply` locally. -- This i

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1543077889 ## data/src/test/java/org/apache/iceberg/TestGenericAppenderFactory.java: ## @@ -18,13 +18,13 @@ */ package org.apache.iceberg; +import com.google.common.collect.Im

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1502443431 ## data/src/test/java/org/apache/iceberg/data/DataTest.java: ## @@ -31,7 +32,8 @@ import org.apache.iceberg.types.Types.MapType; import org.apache.iceberg.types.Types.

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1502440260 ## data/src/test/java/org/apache/iceberg/data/DeleteReadTests.java: ## @@ -70,7 +73,10 @@ public abstract class DeleteReadTests { public static final PartitionSpec DA

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1502439647 ## data/src/test/java/org/apache/iceberg/data/DeleteReadTests.java: ## @@ -45,11 +46,13 @@ import org.apache.iceberg.util.Pair; import org.apache.iceberg.util.StructLi

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1502439184 ## data/src/test/java/org/apache/iceberg/data/DataTestHelpers.java: ## @@ -43,7 +42,7 @@ public static void assertEquals(Types.StructType struct, Record expected, Recor

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1502436883 ## data/src/test/java/org/apache/iceberg/TestMergingMetrics.java: ## @@ -30,13 +30,14 @@ import java.util.concurrent.atomic.AtomicLong; import java.util.concurrent.ato