dajac commented on a change in pull request #10141:
URL: https://github.com/apache/kafka/pull/10141#discussion_r586194412
##
File path: core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala
##
@@ -812,6 +812,26 @@ object ReassignPartitionsCommand extends Logging {
dajac commented on pull request #10234:
URL: https://github.com/apache/kafka/pull/10234#issuecomment-789522482
@chia7712 Thanks for the review. I just pushed a commit to address your
comment. Could you take another look?
Thi
rhauch commented on pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#issuecomment-789526689
@ijuma, I ran `./gradlew clean install releaseTarGz -x signArchives` (which
is still in the README) and it failed with:
```
* What went wrong:
Task 'signArchives' not fou
rhauch commented on pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#issuecomment-789538085
A few more things regarding `./gradlewAll publish` or `./gradlewAll install`:
1. Using `./gradlewAll publish` or `./gradlewAll install` does not appear to
publish source, t
rhauch edited a comment on pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#issuecomment-789538085
A few more things regarding `./gradlewAll publishToMavenLocal ` or
`./gradlewAll install`:
1. Using `./gradlewAll publish` or `./gradlewAll install` does not appear
rhauch edited a comment on pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#issuecomment-789538085
A few more things regarding `./gradlewAll publishToMavenLocal ` or
`./gradlewAll install`:
1. These do not appear to publish source, test or test source JARs to the
rhauch edited a comment on pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#issuecomment-789538085
A few more things regarding `./gradlewAll publishToMavenLocal ` or
`./gradlewAll install`:
1. These do not appear to publish source, test or test source JARs to the
rhauch edited a comment on pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#issuecomment-789538085
A few more things regarding `./gradlewAll publishToMavenLocal ` or
`./gradlewAll install`:
1. These do not appear to publish source, test or test source JARs to the
rhauch edited a comment on pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#issuecomment-789538085
A few more things regarding `./gradlewAll publishToMavenLocal ` or
`./gradlewAll install`:
1. These do not appear to publish source, test or test source JARs to the
chia7712 commented on a change in pull request #10252:
URL: https://github.com/apache/kafka/pull/10252#discussion_r586208095
##
File path: core/src/main/scala/kafka/server/metadata/MetadataPartitions.scala
##
@@ -124,8 +125,30 @@ class MetadataPartitionsBuilder(val brokerId: In
chia7712 commented on a change in pull request #10234:
URL: https://github.com/apache/kafka/pull/10234#discussion_r586270002
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java
##
@@ -145,24 +145,21 @@ public LeaderAndIsrResponse getEr
dajac commented on a change in pull request #10234:
URL: https://github.com/apache/kafka/pull/10234#discussion_r586285455
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java
##
@@ -145,24 +145,21 @@ public LeaderAndIsrResponse getError
chia7712 commented on a change in pull request #10234:
URL: https://github.com/apache/kafka/pull/10234#discussion_r586289230
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java
##
@@ -145,24 +145,21 @@ public LeaderAndIsrResponse getEr
dajac commented on a change in pull request #10234:
URL: https://github.com/apache/kafka/pull/10234#discussion_r586310444
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java
##
@@ -145,24 +145,21 @@ public LeaderAndIsrResponse getError
dajac commented on pull request #10234:
URL: https://github.com/apache/kafka/pull/10234#issuecomment-789621268
@chia7712 I just pushed another small commit to fix/improve
`LeaderAndIsrRequestTest#testGetErrorResponse`. It was not testing all the
versions as claimed. I have also added asser
nicodds commented on pull request #10207:
URL: https://github.com/apache/kafka/pull/10207#issuecomment-789623547
ehy @mjsax, sorry for the delay! I updated the PR
This is an automated message from the Apache Git Service.
To r
Giri created KAFKA-12404:
Summary: Provision to propagate error message from Authorizer to
clients
Key: KAFKA-12404
URL: https://issues.apache.org/jira/browse/KAFKA-12404
Project: Kafka
Issue Type:
priyavj08 commented on pull request #7898:
URL: https://github.com/apache/kafka/pull/7898#issuecomment-789662902
@dongjinleekr really appreciate your guidance here. thanks for the patch.
If I chose to not to move to this patch right away, can you please confirm
that this vulnerabi
chia7712 commented on a change in pull request #10234:
URL: https://github.com/apache/kafka/pull/10234#discussion_r586390524
##
File path:
clients/src/test/java/org/apache/kafka/common/requests/LeaderAndIsrRequestTest.java
##
@@ -59,18 +61,41 @@ public void testUnsupportedVers
chia7712 commented on a change in pull request #10078:
URL: https://github.com/apache/kafka/pull/10078#discussion_r586408680
##
File path: clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java
##
@@ -201,7 +201,7 @@ public short oldestVersion() {
public Lis
dongjinleekr commented on pull request #7898:
URL: https://github.com/apache/kafka/pull/7898#issuecomment-789735966
@priyavj08 I'm sorry that I can't be certain. But as far as I know, any
project with log4j 1.2.7 is not safe. (It is why I have been working on this
issue.)
+1. I also
dongjinleekr edited a comment on pull request #7898:
URL: https://github.com/apache/kafka/pull/7898#issuecomment-784202224
Sorry for being late. Finally, here it is! I succeeded to backport this
feature to the latest 2.7.0 release. (commit 466b798412)
- working branch:
[kafka-2.7+lo
satishd commented on a change in pull request #10173:
URL: https://github.com/apache/kafka/pull/10173#discussion_r586499056
##
File path:
clients/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataManager.java
##
@@ -0,0 +1,200 @@
+/*
+ * Licensed to the
Alexander created KAFKA-12405:
-
Summary: Broker without active topics still involved in
coordinating consumer group
Key: KAFKA-12405
URL: https://issues.apache.org/jira/browse/KAFKA-12405
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-12405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander updated KAFKA-12405:
--
Description:
Short description:
Broker without active topics and with inconsistent data still involve
[
https://issues.apache.org/jira/browse/KAFKA-12405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander updated KAFKA-12405:
--
Summary: Inconsistent broker without active topics still involved in
coordinating consumer group (was
ijuma commented on pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#issuecomment-789798301
Thanks for testing @rhauch!
> @ijuma, I ran `./gradlew clean install releaseTarGz -x signArchives`
(which is still in the README) and it failed with:
The readme was w
[
https://issues.apache.org/jira/browse/KAFKA-12405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander updated KAFKA-12405:
--
Description:
Short description:
Broker without active topics and with inconsistent data still involve
[
https://issues.apache.org/jira/browse/KAFKA-12405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander updated KAFKA-12405:
--
Description:
Short description:
Broker without active topics and with inconsistent data still involve
[
https://issues.apache.org/jira/browse/KAFKA-12405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander updated KAFKA-12405:
--
Description:
Short description:
Broker without active topics and with inconsistent data still involve
chia7712 commented on a change in pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#discussion_r586524651
##
File path: build.gradle
##
@@ -933,49 +953,49 @@ project(':core') {
':connect:runtime:genSinkConnectorConfigDocs',
':
chia7712 commented on pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#issuecomment-789819700
The libs in distribution get changed.
### before
https://user-images.githubusercontent.com/6234750/109832849-ba19b280-7c7b-11eb-8a8a-9190f72a9ef7.png";>
### afte
ijuma commented on a change in pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#discussion_r586553246
##
File path: build.gradle
##
@@ -933,49 +953,49 @@ project(':core') {
':connect:runtime:genSinkConnectorConfigDocs',
':con
ijuma commented on a change in pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#discussion_r586553980
##
File path: build.gradle
##
@@ -933,49 +953,49 @@ project(':core') {
':connect:runtime:genSinkConnectorConfigDocs',
':con
chia7712 commented on a change in pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#discussion_r586554506
##
File path: build.gradle
##
@@ -933,49 +953,49 @@ project(':core') {
':connect:runtime:genSinkConnectorConfigDocs',
':
ijuma commented on a change in pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#discussion_r586569305
##
File path: build.gradle
##
@@ -933,49 +953,49 @@ project(':core') {
':connect:runtime:genSinkConnectorConfigDocs',
':con
[
https://issues.apache.org/jira/browse/KAFKA-12405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander updated KAFKA-12405:
--
Description:
Short description:
Broker without active topics and with inconsistent data still involve
spena commented on a change in pull request #10211:
URL: https://github.com/apache/kafka/pull/10211#discussion_r586578441
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java
##
@@ -282,6 +284,21 @@ public boolean commitNeeded() {
junrao merged pull request #10173:
URL: https://github.com/apache/kafka/pull/10173
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
chia7712 commented on a change in pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#discussion_r586597356
##
File path: build.gradle
##
@@ -1833,27 +1848,30 @@ project(':jmh-benchmarks') {
apply plugin: 'com.github.johnrengelman.shadow'
shadowJar {
-
[
https://issues.apache.org/jira/browse/KAFKA-9548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao resolved KAFKA-9548.
Fix Version/s: 3.0.0
Resolution: Fixed
merged the PR to trunk
> SPI - RemoteStorageManager and Remo
spena commented on a change in pull request #10211:
URL: https://github.com/apache/kafka/pull/10211#discussion_r586605597
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -1136,6 +1144,22 @@ public boolean commitNeeded() {
rhauch commented on a change in pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#discussion_r586619026
##
File path: build.gradle
##
@@ -1987,28 +2005,30 @@ project(':connect:json') {
archivesBaseName = "connect-json"
dependencies {
-compile proj
rhauch commented on a change in pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#discussion_r586623841
##
File path: build.gradle
##
@@ -2026,52 +2043,53 @@ project(':connect:runtime') {
archivesBaseName = "connect-runtime"
dependencies {
-
-comp
hachikuji commented on a change in pull request #10184:
URL: https://github.com/apache/kafka/pull/10184#discussion_r586632247
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
##
@@ -541,6 +575,64 @@ static void validateNewTopicNam
jsancio opened a new pull request #10253:
URL: https://github.com/apache/kafka/pull/10253
Append to the log in one batch when handling:
1. Client quota changes
2. Configuration changes
3. Feature changes
4. Topic creation
*More detailed description of your change,
ijuma commented on a change in pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#discussion_r586642475
##
File path: build.gradle
##
@@ -1987,28 +2005,30 @@ project(':connect:json') {
archivesBaseName = "connect-json"
dependencies {
-compile proje
hachikuji commented on a change in pull request #10252:
URL: https://github.com/apache/kafka/pull/10252#discussion_r586643126
##
File path: core/src/main/scala/kafka/server/metadata/MetadataPartitions.scala
##
@@ -204,9 +248,10 @@ class MetadataPartitionsBuilder(val brokerId: I
wcarlson5 commented on a change in pull request #10211:
URL: https://github.com/apache/kafka/pull/10211#discussion_r586622218
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java
##
@@ -282,6 +284,21 @@ public boolean commitNeeded()
hachikuji commented on a change in pull request #10252:
URL: https://github.com/apache/kafka/pull/10252#discussion_r586646515
##
File path: core/src/main/scala/kafka/server/metadata/MetadataPartitions.scala
##
@@ -172,23 +203,36 @@ class MetadataPartitionsBuilder(val brokerId:
mjsax commented on pull request #10207:
URL: https://github.com/apache/kafka/pull/10207#issuecomment-789936874
@nicodds -- Thinking about this again, I am actually wondering why the value
must be smaller then `max.poll.interval.ms` ? If a tasks idles, we should will
call `poll()` frequentl
mjsax commented on pull request #10131:
URL: https://github.com/apache/kafka/pull/10131#issuecomment-789939535
We have a larger PR in-progress that changes the gradle file significantly,
and I expect conflicts (#10203). Wondering if we can just merge this PR or if
it would be better to mer
mjsax commented on a change in pull request #10131:
URL: https://github.com/apache/kafka/pull/10131#discussion_r586651685
##
File path: build.gradle
##
@@ -1528,8 +1523,7 @@ project(':streams') {
':streams:upgrade-system-tests-24:test',
':streams:upgra
mjsax commented on a change in pull request #10131:
URL: https://github.com/apache/kafka/pull/10131#discussion_r586652341
##
File path: streams-examples/.gitignore
##
@@ -0,0 +1 @@
+/bin/
Review comment:
Just curious. Why do we need this?
---
ijuma commented on a change in pull request #10131:
URL: https://github.com/apache/kafka/pull/10131#discussion_r586670861
##
File path: build.gradle
##
@@ -1403,12 +1403,7 @@ project(':streams') {
dependencies {
compile project(':clients')
-// this dependency shou
ijuma commented on a change in pull request #10131:
URL: https://github.com/apache/kafka/pull/10131#discussion_r586671249
##
File path: build.gradle
##
@@ -974,8 +974,8 @@ project(':core') {
from(project(':streams:streams-scala').configurations.runtime) {
into("libs/") }
mjsax commented on a change in pull request #10042:
URL: https://github.com/apache/kafka/pull/10042#discussion_r586676476
##
File path:
streams/src/test/java/org/apache/kafka/streams/tools/StreamsResetterTest.java
##
@@ -76,6 +79,30 @@ public void
testResetToSpecificOffsetWhe
abbccdda commented on pull request #10240:
URL: https://github.com/apache/kafka/pull/10240#issuecomment-789965233
New system test run:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4414/
This is an automa
hachikuji commented on a change in pull request #10252:
URL: https://github.com/apache/kafka/pull/10252#discussion_r586693956
##
File path: core/src/main/scala/kafka/server/metadata/MetadataPartitions.scala
##
@@ -124,8 +125,30 @@ class MetadataPartitionsBuilder(val brokerId: I
hachikuji commented on a change in pull request #10252:
URL: https://github.com/apache/kafka/pull/10252#discussion_r586695760
##
File path: core/src/main/scala/kafka/server/metadata/MetadataPartitions.scala
##
@@ -124,8 +125,30 @@ class MetadataPartitionsBuilder(val brokerId: I
abbccdda commented on a change in pull request #10211:
URL: https://github.com/apache/kafka/pull/10211#discussion_r586687918
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/TaskMetadata.java
##
@@ -32,10 +34,22 @@
private final Set topicPartitions
hachikuji commented on a change in pull request #10252:
URL: https://github.com/apache/kafka/pull/10252#discussion_r586709124
##
File path: core/src/main/scala/kafka/server/metadata/MetadataPartitions.scala
##
@@ -124,8 +125,30 @@ class MetadataPartitionsBuilder(val brokerId: I
mjsax commented on a change in pull request #10150:
URL: https://github.com/apache/kafka/pull/10150#discussion_r586703617
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamImplTest.java
##
@@ -792,12 +802,24 @@ public void
shouldNotAllowNul
mjsax commented on a change in pull request #10131:
URL: https://github.com/apache/kafka/pull/10131#discussion_r586711923
##
File path: build.gradle
##
@@ -974,8 +974,8 @@ project(':core') {
from(project(':streams:streams-scala').configurations.runtime) {
into("libs/") }
mimaison merged pull request #10185:
URL: https://github.com/apache/kafka/pull/10185
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ijuma commented on a change in pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#discussion_r586713849
##
File path: build.gradle
##
@@ -1833,27 +1848,30 @@ project(':jmh-benchmarks') {
apply plugin: 'com.github.johnrengelman.shadow'
shadowJar {
-
ijuma commented on a change in pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#discussion_r586713849
##
File path: build.gradle
##
@@ -1833,27 +1848,30 @@ project(':jmh-benchmarks') {
apply plugin: 'com.github.johnrengelman.shadow'
shadowJar {
-
ijuma commented on a change in pull request #10131:
URL: https://github.com/apache/kafka/pull/10131#discussion_r586715706
##
File path: build.gradle
##
@@ -974,8 +974,8 @@ project(':core') {
from(project(':streams:streams-scala').configurations.runtime) {
into("libs/") }
hachikuji commented on a change in pull request #10252:
URL: https://github.com/apache/kafka/pull/10252#discussion_r586724166
##
File path: core/src/main/scala/kafka/server/metadata/MetadataPartitions.scala
##
@@ -172,23 +203,36 @@ class MetadataPartitionsBuilder(val brokerId:
hachikuji commented on a change in pull request #10252:
URL: https://github.com/apache/kafka/pull/10252#discussion_r586728427
##
File path:
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala
##
@@ -222,9 +216,16 @@ class BrokerMetadataListener(brokerId: Int
hachikuji commented on a change in pull request #10252:
URL: https://github.com/apache/kafka/pull/10252#discussion_r586724166
##
File path: core/src/main/scala/kafka/server/metadata/MetadataPartitions.scala
##
@@ -172,23 +203,36 @@ class MetadataPartitionsBuilder(val brokerId:
cmccabe commented on a change in pull request #10184:
URL: https://github.com/apache/kafka/pull/10184#discussion_r586739230
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
##
@@ -541,6 +575,64 @@ static void validateNewTopicNames
wcarlson5 commented on a change in pull request #10211:
URL: https://github.com/apache/kafka/pull/10211#discussion_r586728619
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java
##
@@ -282,6 +284,21 @@ public boolean commitNeeded()
David Arthur created KAFKA-12406:
Summary: Fix broker-side client quotas in Raft mode
Key: KAFKA-12406
URL: https://issues.apache.org/jira/browse/KAFKA-12406
Project: Kafka
Issue Type: Bug
mumrah opened a new pull request #10254:
URL: https://github.com/apache/kafka/pull/10254
This PR adds DescribeClientQuota RPC as a supported RPC of the raft broker.
It also fixes the case where an empty set of entity filters in non-strict mode
should return _all_ quota entities. Previously
mumrah commented on a change in pull request #10253:
URL: https://github.com/apache/kafka/pull/10253#discussion_r586756040
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ControllerResult.java
##
@@ -28,15 +28,21 @@
class ControllerResult {
private final
abbccdda edited a comment on pull request #10240:
URL: https://github.com/apache/kafka/pull/10240#issuecomment-789965233
New system test run:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4415/
This is an
mumrah merged pull request #9992:
URL: https://github.com/apache/kafka/pull/9992
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-9296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17294831#comment-17294831
]
Cruz Fernandez commented on KAFKA-9296:
---
I'm seeing a very similar error on my Kafk
mumrah commented on pull request #9872:
URL: https://github.com/apache/kafka/pull/9872#issuecomment-790050150
This was merged to trunk as
https://github.com/apache/kafka/commit/f40a82e05440e579c69363dc62c2dd9c8520eb02
This i
mumrah closed pull request #9872:
URL: https://github.com/apache/kafka/pull/9872
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jsancio commented on a change in pull request #10253:
URL: https://github.com/apache/kafka/pull/10253#discussion_r586813520
##
File path: metadata/src/test/java/org/apache/kafka/metalog/LocalLogManager.java
##
@@ -371,8 +371,21 @@ public void register(MetaLogListener listener)
jsancio commented on a change in pull request #10253:
URL: https://github.com/apache/kafka/pull/10253#discussion_r586814226
##
File path: metadata/src/main/java/org/apache/kafka/metalog/LocalLogManager.java
##
@@ -328,8 +328,21 @@ public void register(MetaLogListener listener)
jsancio commented on a change in pull request #10253:
URL: https://github.com/apache/kafka/pull/10253#discussion_r586814323
##
File path: metadata/src/main/java/org/apache/kafka/metalog/LocalLogManager.java
##
@@ -328,8 +328,21 @@ public void register(MetaLogListener listener)
mimaison commented on pull request #9950:
URL: https://github.com/apache/kafka/pull/9950#issuecomment-790111206
Test failures are not related:
```
JDK 8 /
org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testOneWayReplicationWithAutoOffsetSync()
JDK 11
mimaison merged pull request #9950:
URL: https://github.com/apache/kafka/pull/9950
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
[
https://issues.apache.org/jira/browse/KAFKA-12170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison updated KAFKA-12170:
---
Fix Version/s: (was: 2.7.1)
3.0.0
> Connect Cast cannot deal with fie
rhauch commented on a change in pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#discussion_r586853160
##
File path: build.gradle
##
@@ -1987,28 +2005,30 @@ project(':connect:json') {
archivesBaseName = "connect-json"
dependencies {
-compile proj
jolshan commented on pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#issuecomment-790133100
waiting on https://github.com/apache/kafka/pull/9758 before proceeding since
this PR touches a lot of the same files.
mjsax commented on a change in pull request #10131:
URL: https://github.com/apache/kafka/pull/10131#discussion_r586863239
##
File path: build.gradle
##
@@ -974,8 +974,8 @@ project(':core') {
from(project(':streams:streams-scala').configurations.runtime) {
into("libs/") }
mjsax commented on a change in pull request #10131:
URL: https://github.com/apache/kafka/pull/10131#discussion_r586863239
##
File path: build.gradle
##
@@ -974,8 +974,8 @@ project(':core') {
from(project(':streams:streams-scala').configurations.runtime) {
into("libs/") }
ijuma commented on a change in pull request #10131:
URL: https://github.com/apache/kafka/pull/10131#discussion_r586868205
##
File path: build.gradle
##
@@ -974,8 +974,8 @@ project(':core') {
from(project(':streams:streams-scala').configurations.runtime) {
into("libs/") }
hachikuji commented on pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#issuecomment-790152137
@jolshan In `Log.completeSwapOperations`, we have the following comment:
```
// We create swap files for two cases:
// (1) Log cleaning where multiple segment
mjsax commented on a change in pull request #10131:
URL: https://github.com/apache/kafka/pull/10131#discussion_r586900476
##
File path: build.gradle
##
@@ -974,8 +974,8 @@ project(':core') {
from(project(':streams:streams-scala').configurations.runtime) {
into("libs/") }
junrao commented on a change in pull request #10184:
URL: https://github.com/apache/kafka/pull/10184#discussion_r586880128
##
File path: core/src/test/scala/unit/kafka/server/ControllerApisTest.scala
##
@@ -18,19 +18,26 @@
package unit.kafka.server
Review comment:
This
jolshan commented on pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#issuecomment-790175685
@hachikuji thanks for the review. Just to clarify, you are suggesting
updating/changing
```
val oldSegments = logSegments(swapSegment.baseOffset,
swapSegment.readNextOffset)
ableegoldman commented on a change in pull request #10131:
URL: https://github.com/apache/kafka/pull/10131#discussion_r586918859
##
File path: build.gradle
##
@@ -974,8 +974,8 @@ project(':core') {
from(project(':streams:streams-scala').configurations.runtime) {
into("lib
mjsax commented on a change in pull request #9744:
URL: https://github.com/apache/kafka/pull/9744#discussion_r586727033
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java
##
@@ -289,4 +291,33 @@ Cancellable schedule(final Duration inte
ableegoldman commented on pull request #10251:
URL: https://github.com/apache/kafka/pull/10251#issuecomment-790226079
Call for review also any of @lct45 @wcarlson5 @swist @mjsax
This is an automated message from the Apache
hachikuji commented on a change in pull request #10184:
URL: https://github.com/apache/kafka/pull/10184#discussion_r586979443
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
##
@@ -349,6 +359,29 @@ public void replay(PartitionCha
1 - 100 of 135 matches
Mail list logo
