dajac merged PR #14850:
URL: https://github.com/apache/kafka/pull/14850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
[
https://issues.apache.org/jira/browse/KAFKA-15061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-15061.
-
Fix Version/s: 3.7.0
Resolution: Fixed
> CoordinatorPartitionWriter should reuse buffer
>
dajac merged PR #14885:
URL: https://github.com/apache/kafka/pull/14885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dajac merged PR #14896:
URL: https://github.com/apache/kafka/pull/14896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dajac merged PR #14915:
URL: https://github.com/apache/kafka/pull/14915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
apoorvmittal10 commented on PR #14924:
URL: https://github.com/apache/kafka/pull/14924#issuecomment-1840118739
@AndrewJSchofield @mjsax @wcarlson5 @philipnee - Minor PR to exclude client
`client_id` label in metrics.
--
This is an automated message from the Apache Git Service.
To respond
apoorvmittal10 opened a new pull request, #14924:
URL: https://github.com/apache/kafka/pull/14924
Changes in the PR are to support excluding `client_id` label when sending
telemetry metrics.
Some of the labels/tags which are present in metric should be skipped while
collecting teleme
Apoorv Mittal created KAFKA-15972:
-
Summary: Add support to exclude labels in client telemetry
Key: KAFKA-15972
URL: https://issues.apache.org/jira/browse/KAFKA-15972
Project: Kafka
Issue Typ
cmccabe merged PR #14918:
URL: https://github.com/apache/kafka/pull/14918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
ashwinpankaj commented on PR #14910:
URL: https://github.com/apache/kafka/pull/14910#issuecomment-1840012911
> LGTM
Thanks @wcarlson5 !! - can you please merge this commit ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
pprovenzano commented on code in PR #14863:
URL: https://github.com/apache/kafka/pull/14863#discussion_r1414875644
##
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##
@@ -2016,6 +2021,70 @@ ListPartitionReassignmentsResponseData
listPartitio
DL1231 opened a new pull request, #14923:
URL: https://github.com/apache/kafka/pull/14923
The PR resolve issue
[KAFKA-15866](https://issues.apache.org/jira/browse/KAFKA-15866), the current
OffsetFetchRequestState error handling uses nested if-else, which is quite
different, stylistically,
github-actions[bot] commented on PR #14333:
URL: https://github.com/apache/kafka/pull/14333#issuecomment-1839944197
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
[
https://issues.apache.org/jira/browse/KAFKA-15866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lan Ding reassigned KAFKA-15866:
Assignee: Lan Ding
> Refactor OffsetFetchRequestState Error handling to be more consistent with
showuon commented on code in PR #14832:
URL: https://github.com/apache/kafka/pull/14832#discussion_r1414765630
##
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##
@@ -283,8 +283,38 @@ class BrokerTopicMetrics(name: Option[String], configOpt:
java.util.Optional[Kaf
apoorvmittal10 commented on PR #14843:
URL: https://github.com/apache/kafka/pull/14843#issuecomment-1839895007
@mjsax Build passed with known flaky tests, not related to PR changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
mjsax opened a new pull request, #14922:
URL: https://github.com/apache/kafka/pull/14922
This PR is on top of https://github.com/apache/kafka/pull/14908
Only second commit to be reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1414752935
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -183,6 +183,10 @@ public NetworkClientDelegate.PollResult poll
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1414752641
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1376,6 +1425,66 @@ private void subscribeInternal(Collection
topi
soarez commented on PR #14903:
URL: https://github.com/apache/kafka/pull/14903#issuecomment-1839871090
@cmccabe thanks for having a look.
I've made the following changes:
* Replaced the use of `prepend` with `append` in `propagateDirectoryFailure`
* Moved `communicationInFli
Owen-CH-Leung commented on PR #14891:
URL: https://github.com/apache/kafka/pull/14891#issuecomment-1839853774
> Hm.. given this is the TopicCommandIntegrationTest I think we should
keep the parts testing the topic command tool.
Thanks for your feedback! Do you mean we should keep
soarez commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1414728861
##
core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala:
##
@@ -197,11 +197,14 @@ class BrokerLifecycleManagerTest {
result
}
- def poll[T](
lihaosky commented on code in PR #14714:
URL: https://github.com/apache/kafka/pull/14714#discussion_r1414713123
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/GraphTest.java:
##
@@ -394,6 +394,106 @@ public void testDeterministic() {
}
jolshan commented on code in PR #14774:
URL: https://github.com/apache/kafka/pull/14774#discussion_r1414713239
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -349,146 +468,68 @@ class GroupMetadataManager(brokerId: Int,
consu
cmccabe commented on code in PR #14838:
URL: https://github.com/apache/kafka/pull/14838#discussion_r1414713000
##
metadata/src/main/java/org/apache/kafka/image/loader/MetadataLoader.java:
##
@@ -347,7 +347,7 @@ private void maybePublishMetadata(MetadataDelta delta,
MetadataImag
gharris1727 commented on PR #14917:
URL: https://github.com/apache/kafka/pull/14917#issuecomment-1839818405
I tested out adding a MiniTrogdorCluster start/stop in a `@BeforeAll` method
in the test, and I'm getting reliable test passes at about 20% CPU, where
before it was consistent failure
junrao commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1414711941
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -366,8 +379,27 @@ class BrokerLifecycleManager(
new BrokerRegistrationResponseHandler())
cmccabe commented on code in PR #14838:
URL: https://github.com/apache/kafka/pull/14838#discussion_r1414710963
##
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##
@@ -354,6 +356,25 @@ public ControllerResult
registerBroker(
throw ne
cmccabe commented on code in PR #14838:
URL: https://github.com/apache/kafka/pull/14838#discussion_r1414710963
##
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##
@@ -354,6 +356,25 @@ public ControllerResult
registerBroker(
throw ne
jolshan commented on code in PR #14774:
URL: https://github.com/apache/kafka/pull/14774#discussion_r1414710936
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -941,39 +857,129 @@ class ReplicaManager(val config: KafkaConfig,
}
}
- private def partition
jolshan commented on code in PR #14774:
URL: https://github.com/apache/kafka/pull/14774#discussion_r1414708109
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -708,23 +708,40 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
-if (authorizedR
junrao commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1414708239
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -366,8 +379,27 @@ class BrokerLifecycleManager(
new BrokerRegistrationResponseHandler())
jolshan commented on code in PR #14774:
URL: https://github.com/apache/kafka/pull/14774#discussion_r1414708109
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -708,23 +708,40 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
-if (authorizedR
cmccabe commented on code in PR #14838:
URL: https://github.com/apache/kafka/pull/14838#discussion_r1414705968
##
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##
@@ -284,7 +286,7 @@ ReplicaPlacer replicaPlacer() {
public void activate() {
cmccabe commented on code in PR #14838:
URL: https://github.com/apache/kafka/pull/14838#discussion_r1414704931
##
server-common/src/main/java/org/apache/kafka/common/DirectoryId.java:
##
@@ -121,8 +122,38 @@ public static Map createAssignmentMap(int[]
replicas, Uuid[] dire
junrao commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1414704903
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -166,6 +166,19 @@ class BrokerLifecycleManager(
*/
private var registered = false
+ /**
jolshan commented on code in PR #14845:
URL: https://github.com/apache/kafka/pull/14845#discussion_r1414703024
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -180,7 +185,78 @@ public OffsetMetadataManager build() {
/*
cmccabe commented on PR #14902:
URL: https://github.com/apache/kafka/pull/14902#issuecomment-1839805443
I don't see why `BrokerHeartbeatManager` needs to know about directories at
all. Its function is to identify brokers that haven't hearbeated in a while, so
they can be fenced. But that do
cmccabe commented on code in PR #14902:
URL: https://github.com/apache/kafka/pull/14902#discussion_r1414698623
##
metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java:
##
@@ -91,8 +102,15 @@ static class BrokerHeartbeatState {
*/
priv
cmccabe commented on code in PR #14902:
URL: https://github.com/apache/kafka/pull/14902#discussion_r1414699020
##
metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java:
##
@@ -107,6 +125,13 @@ int id() {
return id;
}
+/**
cmccabe commented on code in PR #14902:
URL: https://github.com/apache/kafka/pull/14902#discussion_r1414698623
##
metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java:
##
@@ -91,8 +102,15 @@ static class BrokerHeartbeatState {
*/
priv
jolshan commented on code in PR #14845:
URL: https://github.com/apache/kafka/pull/14845#discussion_r1414697270
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java:
##
@@ -187,8 +190,6 @@ public CoordinatorResult
commitOffset(
cmccabe commented on code in PR #14902:
URL: https://github.com/apache/kafka/pull/14902#discussion_r1414696645
##
core/src/main/scala/kafka/server/ControllerApis.scala:
##
@@ -1070,11 +1070,27 @@ class ControllerApis(
}
def handleAssignReplicasToDirs(request: RequestChan
jolshan commented on code in PR #14845:
URL: https://github.com/apache/kafka/pull/14845#discussion_r1414694924
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##
@@ -675,25 +675,25 @@ public void testValidateOffsetCommit() {
jolshan commented on code in PR #14845:
URL: https://github.com/apache/kafka/pull/14845#discussion_r1414694054
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorShardTest.java:
##
@@ -293,7 +326,11 @@ public void testReplayOffsetCommit() {
ableegoldman commented on code in PR #14735:
URL: https://github.com/apache/kafka/pull/14735#discussion_r1414691022
##
streams/src/main/java/org/apache/kafka/streams/processor/StandbyUpdateListener.java:
##
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
jolshan commented on code in PR #14845:
URL: https://github.com/apache/kafka/pull/14845#discussion_r1414690648
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java:
##
@@ -1615,4 +1618,127 @@ public void testDeleteGroupsWhenNotSt
jolshan commented on code in PR #14845:
URL: https://github.com/apache/kafka/pull/14845#discussion_r1414690195
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -833,13 +835,15 @@ public void validateOffsetCommit(
mjsax commented on code in PR #14714:
URL: https://github.com/apache/kafka/pull/14714#discussion_r1414683411
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareGraphConstructorTest.java:
##
@@ -97,6 +98,17 @@ private int getCost(final TaskI
junrao commented on PR #14811:
URL: https://github.com/apache/kafka/pull/14811#issuecomment-1839774186
Just merged a related PR https://github.com/apache/kafka/pull/14767.
Re-triggering the tests to make sure there are no new issues.
--
This is an automated message from the Apache Git Ser
junrao closed pull request #14811: KAFKA-15831: KIP-1000 protocol and admin
client
URL: https://github.com/apache/kafka/pull/14811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
artemlivshits commented on code in PR #14774:
URL: https://github.com/apache/kafka/pull/14774#discussion_r141457
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -708,23 +708,40 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
-if (autho
junrao merged PR #14767:
URL: https://github.com/apache/kafka/pull/14767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
cmccabe commented on PR #14903:
URL: https://github.com/apache/kafka/pull/14903#issuecomment-1839768073
> Instead, CommunicationEvent.run() should gracefully handle running when
communicationInFlight = true Probably by doing nothing.
This also implies that `scheduleNextCommunicationAf
junrao commented on PR #14767:
URL: https://github.com/apache/kafka/pull/14767#issuecomment-1839767052
@apoorvmittal10 : Thanks for triaging the tests. Merging the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
mjsax commented on code in PR #14626:
URL: https://github.com/apache/kafka/pull/14626#discussion_r1414568376
##
streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalSegmentIterator.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
cmccabe commented on PR #14903:
URL: https://github.com/apache/kafka/pull/14903#issuecomment-1839747217
Thanks for looking at this, @soarez .
I don't think `nextSchedulingShouldBeImmediate` should be reset to false
until the `CommunicationEvent` is run.
I also think we should b
soarez commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1414647339
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -166,6 +166,19 @@ class BrokerLifecycleManager(
*/
private var registered = false
+ /**
soarez commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1414633539
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -453,79 +490,73 @@ class BrokerLifecycleManager(
val message =
response.responseBody().
jolshan commented on code in PR #14845:
URL: https://github.com/apache/kafka/pull/14845#discussion_r1414627867
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -180,7 +185,78 @@ public OffsetMetadataManager build() {
/*
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1414627626
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1376,6 +1425,66 @@ private void subscribeInternal(Collection
topi
soarez commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1414626881
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -366,8 +379,27 @@ class BrokerLifecycleManager(
new BrokerRegistrationResponseHandler())
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1414626549
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerRebalanceListenerMethodName.java:
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Softw
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1414625883
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -650,7 +693,7 @@ boolean reconcile() {
jolshan commented on code in PR #14845:
URL: https://github.com/apache/kafka/pull/14845#discussion_r1414621182
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -180,7 +185,78 @@ public OffsetMetadataManager build() {
/*
efgpinto closed pull request #7539: KAFKA-6968: Adds calls to listener on
rebalance of MockConsumer
URL: https://github.com/apache/kafka/pull/7539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eduardo Pinto reassigned KAFKA-6968:
Assignee: (was: Eduardo Pinto)
> Call RebalanceListener in MockConsumer
>
[
https://issues.apache.org/jira/browse/KAFKA-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793049#comment-17793049
]
Eduardo Pinto commented on KAFKA-6968:
--
Unassigning myself due to lack of bandwidth
jolshan commented on code in PR #14845:
URL: https://github.com/apache/kafka/pull/14845#discussion_r1414610034
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -180,7 +185,78 @@ public OffsetMetadataManager build() {
/*
efgpinto closed pull request #8430: KAFKA-9631: Fix support for optional fields
in MockAdminClient
URL: https://github.com/apache/kafka/pull/8430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
efgpinto commented on PR #8430:
URL: https://github.com/apache/kafka/pull/8430#issuecomment-1839682362
No bandwidth to revisit this. Closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-9631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793048#comment-17793048
]
Eduardo Pinto commented on KAFKA-9631:
--
I don't have the capacity to work on this an
[
https://issues.apache.org/jira/browse/KAFKA-9631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eduardo Pinto reassigned KAFKA-9631:
Assignee: (was: Eduardo Pinto)
> MockAdminClient doesn't handle CreateTopics optional
gharris1727 commented on code in PR #14293:
URL: https://github.com/apache/kafka/pull/14293#discussion_r1414605900
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/DedicatedMirrorIntegrationTest.java:
##
@@ -314,6 +356,23 @@ private void
awaitConnect
cmccabe commented on PR #14918:
URL: https://github.com/apache/kafka/pull/14918#issuecomment-1839616178
> Thanks @cmccabe. Is the impact of this bug that we weren't reporting the
two metrics LatestSnapshotGeneratedBytes and LatestSnapshotGeneratedAgeMs?
Unfortunately, yes that was the
gharris1727 commented on code in PR #14562:
URL: https://github.com/apache/kafka/pull/14562#discussion_r1414514216
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java:
##
@@ -394,9 +399,16 @@ public void validateConnectorConfig(Map
connectorPro
C0urante commented on code in PR #14293:
URL: https://github.com/apache/kafka/pull/14293#discussion_r1414541177
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorHerder.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
lihaosky opened a new pull request, #14921:
URL: https://github.com/apache/kafka/pull/14921
Tests for HAAssignor and StickyAssignor.
This PR is on top of https://github.com/apache/kafka/pull/14714
--
This is an automated message from the Apache Git Service.
To respond to the mes
dajac commented on code in PR #14885:
URL: https://github.com/apache/kafka/pull/14885#discussion_r1414553902
##
core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala:
##
@@ -126,57 +129,63 @@ class CoordinatorPartitionWriter[T](
val magic = logCon
philipnee opened a new pull request, #14920:
URL: https://github.com/apache/kafka/pull/14920
When closing the consumer we need to perform a few tasks
1. If auto-commit is enabled, send an autocommit and block until completed
2. Invoke all offsetCommitCallbacks and ensure all inflight co
[
https://issues.apache.org/jira/browse/KAFKA-13988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-13988:
--
Fix Version/s: 3.6.2
> Mirrormaker 2 auto.offset.reset=latest not working
> --
dajac commented on code in PR #14885:
URL: https://github.com/apache/kafka/pull/14885#discussion_r1414550451
##
core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala:
##
@@ -66,6 +65,10 @@ class CoordinatorPartitionWriter[T](
compressionType: Compressio
mumrah opened a new pull request, #14919:
URL: https://github.com/apache/kafka/pull/14919
This patch adds two cases to EventHandlerExceptionInfo for exceptions thrown
by the log layer. Prior to this change, the log could throw a
CorruptRecordException and the QuorumController would not trea
C0urante merged PR #14567:
URL: https://github.com/apache/kafka/pull/14567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
C0urante commented on PR #14567:
URL: https://github.com/apache/kafka/pull/14567#issuecomment-1839519217
Thanks Greg!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
mumrah commented on PR #14918:
URL: https://github.com/apache/kafka/pull/14918#issuecomment-1839514024
Thanks @cmccabe. Is the impact of this bug that we weren't reporting the two
metrics LatestSnapshotGeneratedBytes and LatestSnapshotGeneratedAgeMs?
--
This is an automated message from
cadonna commented on code in PR #14878:
URL: https://github.com/apache/kafka/pull/14878#discussion_r1414503110
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestManagers.java:
##
@@ -157,6 +157,7 @@ protected RequestManagers create() {
philipnee commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1414525826
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1376,6 +1425,66 @@ private void subscribeInternal(Collection
top
jolshan commented on code in PR #14885:
URL: https://github.com/apache/kafka/pull/14885#discussion_r1414519712
##
core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala:
##
@@ -66,6 +65,10 @@ class CoordinatorPartitionWriter[T](
compressionType: Compress
apoorvmittal10 commented on PR #14843:
URL: https://github.com/apache/kafka/pull/14843#issuecomment-1839503610
@mjsax I have resolved the conflicts and build is triggered. Please let me
know if PR something else need to be handled or PR can be merged, once build
succeeds.
cc: @philipnee
cadonna commented on code in PR #14879:
URL: https://github.com/apache/kafka/pull/14879#discussion_r1414512071
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -292,6 +297,90 @@ public void
testValidateConsumerGroupHea
cmccabe opened a new pull request, #14918:
URL: https://github.com/apache/kafka/pull/14918
Fix a bug where we weren't properly exposing SnapshotEmitterMetrics. Add a
test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
jeffkbkim commented on code in PR #14885:
URL: https://github.com/apache/kafka/pull/14885#discussion_r1414507880
##
core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala:
##
@@ -66,6 +65,10 @@ class CoordinatorPartitionWriter[T](
compressionType: Compre
[
https://issues.apache.org/jira/browse/KAFKA-15645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison updated KAFKA-15645:
---
Parent: KAFKA-14525
Issue Type: Sub-task (was: Task)
> Move ReplicationQuotasTestRi
jolshan commented on code in PR #14885:
URL: https://github.com/apache/kafka/pull/14885#discussion_r1414500105
##
core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala:
##
@@ -66,6 +65,10 @@ class CoordinatorPartitionWriter[T](
compressionType: Compress
jolshan commented on code in PR #14885:
URL: https://github.com/apache/kafka/pull/14885#discussion_r1414508061
##
core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala:
##
@@ -126,57 +129,63 @@ class CoordinatorPartitionWriter[T](
val magic = logC
mimaison merged PR #14914:
URL: https://github.com/apache/kafka/pull/14914
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
jolshan commented on code in PR #14885:
URL: https://github.com/apache/kafka/pull/14885#discussion_r1414500105
##
core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala:
##
@@ -66,6 +65,10 @@ class CoordinatorPartitionWriter[T](
compressionType: Compress
jolshan commented on code in PR #14885:
URL: https://github.com/apache/kafka/pull/14885#discussion_r1414500105
##
core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala:
##
@@ -66,6 +65,10 @@ class CoordinatorPartitionWriter[T](
compressionType: Compress
mimaison commented on code in PR #14914:
URL: https://github.com/apache/kafka/pull/14914#discussion_r1414498206
##
docs/ops.html:
##
@@ -3570,7 +3572,7 @@ 6.9 ZooKeeper
Stable version
- The current stable branch is 3.5. Kafka is regularly updated to include the
latest rel
1 - 100 of 242 matches
Mail list logo
