rreddy-22 commented on PR #16068:
URL: https://github.com/apache/kafka/pull/16068#issuecomment-2141348418
There are two tests failing in GroupMetadataManagerTest, will look into it
tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
ableegoldman commented on code in PR #15790:
URL: https://github.com/apache/kafka/pull/15790#discussion_r1621827532
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/SinkNode.java:
##
@@ -58,8 +60,21 @@ public void addChild(final ProcessorNode
child) {
abhijeetk88 commented on code in PR #16071:
URL: https://github.com/apache/kafka/pull/16071#discussion_r1621675519
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -6597,6 +6597,79 @@ class ReplicaManagerTest {
))
}
}
+
+ @Test
+ def test
abhijeetk88 commented on PR #15625:
URL: https://github.com/apache/kafka/pull/15625#issuecomment-2141192632
Thanks @chia7712 @jolshan . Apologies for the miss.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
github-actions[bot] commented on PR #15355:
URL: https://github.com/apache/kafka/pull/15355#issuecomment-2141172395
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
gongxuanzhang commented on code in PR #16097:
URL: https://github.com/apache/kafka/pull/16097#discussion_r1621586240
##
checkstyle/suppressions.xml:
##
@@ -361,4 +361,7 @@
+
+
Review Comment:
I think checkstyle should consistent with auto format . If you open
gongxuanzhang commented on code in PR #16097:
URL: https://github.com/apache/kafka/pull/16097#discussion_r1621586240
##
checkstyle/suppressions.xml:
##
@@ -361,4 +361,7 @@
+
+
Review Comment:
I think checkstyle should consistent with auto format . If you open
gongxuanzhang commented on code in PR #16097:
URL: https://github.com/apache/kafka/pull/16097#discussion_r1621614857
##
build.gradle:
##
@@ -787,6 +800,12 @@ subprojects {
skipProjects = [ ":jmh-benchmarks", ":trogdor" ]
skipConfigurations = [ "zinc" ]
}
+
+ afterE
[
https://issues.apache.org/jira/browse/KAFKA-16861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850899#comment-17850899
]
TengYao Chi commented on KAFKA-16861:
-
I will handle this issue :)
> Don't convert
rreddy-22 commented on code in PR #16068:
URL: https://github.com/apache/kafka/pull/16068#discussion_r1621587957
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilderTest.java:
##
@@ -585,34 +586,34 @@ public void
testRea
gongxuanzhang commented on code in PR #16097:
URL: https://github.com/apache/kafka/pull/16097#discussion_r1621586240
##
checkstyle/suppressions.xml:
##
@@ -361,4 +361,7 @@
+
+
Review Comment:
I think checkstyle should consistent with auto format . If you open
gongxuanzhang commented on code in PR #16097:
URL: https://github.com/apache/kafka/pull/16097#discussion_r1621584578
##
build.gradle:
##
@@ -47,7 +47,7 @@ plugins {
// Updating the shadow plugin version to 8.1.1 causes issue with signing and
publishing the shadowed
// art
satishd commented on PR #15820:
URL: https://github.com/apache/kafka/pull/15820#issuecomment-2141069773
@abhijeetk88 Can you resolve the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
satishd merged PR #16146:
URL: https://github.com/apache/kafka/pull/16146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
satishd commented on PR #16146:
URL: https://github.com/apache/kafka/pull/16146#issuecomment-2141065172
A few failing tests are unrelated to the change. Merging this change to the
trunk to unblock the test failures.
--
This is an automated message from the Apache Git Service.
To respond t
jolshan commented on code in PR #15968:
URL: https://github.com/apache/kafka/pull/15968#discussion_r1621535872
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java:
##
@@ -610,7 +611,9 @@ private void handleProduceResponse(ClientResponse response,
Ma
jolshan commented on code in PR #15968:
URL: https://github.com/apache/kafka/pull/15968#discussion_r1621535872
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java:
##
@@ -610,7 +611,9 @@ private void handleProduceResponse(ClientResponse response,
Ma
ableegoldman commented on code in PR #16147:
URL: https://github.com/apache/kafka/pull/16147#discussion_r1621532246
##
streams/src/main/java/org/apache/kafka/streams/processor/assignment/TaskAssignmentUtils.java:
##
@@ -481,10 +479,24 @@ private static int getCrossRackTrafficCos
showuon commented on code in PR #16085:
URL: https://github.com/apache/kafka/pull/16085#discussion_r1621524702
##
core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala:
##
@@ -4251,6 +4251,22 @@ class UnifiedLogTest {
assertEquals(new LogOffsetMetadata(14, -1L, -1),
log.
rreddy-22 commented on code in PR #16068:
URL: https://github.com/apache/kafka/pull/16068#discussion_r1621518800
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GroupSpecImpl.java:
##
@@ -18,48 +18,60 @@
import org.apache.kafka.common.Uuid;
+i
rreddy-22 commented on code in PR #16068:
URL: https://github.com/apache/kafka/pull/16068#discussion_r1621508931
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GroupSpec.java:
##
@@ -39,4 +41,20 @@ public interface GroupSpec {
* Fals
jolshan commented on code in PR #16120:
URL: https://github.com/apache/kafka/pull/16120#discussion_r1621497961
##
core/src/test/java/kafka/test/ClusterInstance.java:
##
@@ -159,9 +158,7 @@ default Set supportedGroupProtocols() {
Set supportedGroupProtocols = new HashSet
jolshan commented on code in PR #16120:
URL: https://github.com/apache/kafka/pull/16120#discussion_r1621496853
##
metadata/src/test/java/org/apache/kafka/controller/QuorumFeaturesTest.java:
##
@@ -74,7 +74,7 @@ public void testDefaultFeatureMapWithUnstable() {
for (Feat
pasharik commented on code in PR #15830:
URL: https://github.com/apache/kafka/pull/15830#discussion_r1621488481
##
core/src/main/scala/kafka/admin/AclCommand.scala:
##
@@ -115,8 +115,6 @@ object AclCommand extends Logging {
val aclBindings = acls.map(acl => new AclBin
jolshan commented on code in PR #16120:
URL: https://github.com/apache/kafka/pull/16120#discussion_r1621487824
##
core/src/test/java/kafka/test/ClusterInstance.java:
##
@@ -159,9 +158,7 @@ default Set supportedGroupProtocols() {
Set supportedGroupProtocols = new HashSet
soarez commented on PR #15945:
URL: https://github.com/apache/kafka/pull/15945#issuecomment-2140953114
There are some conflicts that need addressing, and the JDK 21 pipeline
didn't run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
soarez commented on code in PR #15945:
URL: https://github.com/apache/kafka/pull/15945#discussion_r1621485662
##
metadata/src/main/java/org/apache/kafka/image/publisher/BrokerRegistrationTracker.java:
##
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
apourchet commented on code in PR #16129:
URL: https://github.com/apache/kafka/pull/16129#discussion_r1621479244
##
streams/src/main/java/org/apache/kafka/streams/processor/assignment/TaskAssignmentUtils.java:
##
@@ -244,18 +271,112 @@ public static Map
optimizeRackAwareStandby
apourchet opened a new pull request, #16147:
URL: https://github.com/apache/kafka/pull/16147
This PR takes care of making the call back
to`TaskAssignor.onAssignmentComputed`.
It also contains a change to the public AssignmentConfigs API, as well as
some simplifications of the StickyT
ableegoldman merged PR #16129:
URL: https://github.com/apache/kafka/pull/16129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
ableegoldman commented on PR #16129:
URL: https://github.com/apache/kafka/pull/16129#issuecomment-2140934597
Test failures are unrelated. Merging to trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
ableegoldman commented on code in PR #16129:
URL: https://github.com/apache/kafka/pull/16129#discussion_r1621467009
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##
@@ -555,18 +556,21 @@ private ApplicationState buildApplica
[
https://issues.apache.org/jira/browse/KAFKA-16863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850869#comment-17850869
]
Matthias J. Sax commented on KAFKA-16863:
-
I think `traffic_cost` was on purpose
junrao commented on PR #15625:
URL: https://github.com/apache/kafka/pull/15625#issuecomment-2140919323
@jolshan : Thanks for pointing this out. Sorry that I didn't look at the
test results carefully before merging.
--
This is an automated message from the Apache Git Service.
To respond to
jolshan merged PR #16130:
URL: https://github.com/apache/kafka/pull/16130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
jolshan commented on code in PR #16130:
URL: https://github.com/apache/kafka/pull/16130#discussion_r1621463208
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -449,8 +449,8 @@ object KafkaConfig {
/** Internal Configurations **/
// This indicates wheth
jolshan commented on PR #16130:
URL: https://github.com/apache/kafka/pull/16130#issuecomment-2140914372
I filed https://issues.apache.org/jira/browse/KAFKA-16866 for the one
failure and that is getting fixed separately.
As for the others, looks like they are frequent flakes. I will g
[
https://issues.apache.org/jira/browse/KAFKA-16792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850215#comment-17850215
]
Kirk True edited comment on KAFKA-16792 at 5/30/24 9:41 PM:
[
https://issues.apache.org/jira/browse/KAFKA-16792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850215#comment-17850215
]
Kirk True edited comment on KAFKA-16792 at 5/30/24 9:40 PM:
[
https://issues.apache.org/jira/browse/KAFKA-16792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850215#comment-17850215
]
Kirk True edited comment on KAFKA-16792 at 5/30/24 9:34 PM:
jolshan commented on code in PR #16088:
URL: https://github.com/apache/kafka/pull/16088#discussion_r1621445974
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java:
##
@@ -144,216 +133,137 @@ protected GroupAssignm
jolshan commented on code in PR #16088:
URL: https://github.com/apache/kafka/pull/16088#discussion_r1621442335
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformAssignor.java:
##
@@ -66,21 +66,19 @@ public GroupAssignment assign(
Grou
[
https://issues.apache.org/jira/browse/KAFKA-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Strickland updated KAFKA-16858:
Attachment: proto.proto
> Flatten SMT throws NPE
> --
>
>
[
https://issues.apache.org/jira/browse/KAFKA-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850866#comment-17850866
]
Adam Strickland commented on KAFKA-16858:
-
*
{quote}Are you able to provide an
[
https://issues.apache.org/jira/browse/KAFKA-16047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850864#comment-17850864
]
Edoardo Comar commented on KAFKA-16047:
---
[~gharris1727]
I see that for a common p
chia7712 opened a new pull request, #16146:
URL: https://github.com/apache/kafka/pull/16146
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgr
[
https://issues.apache.org/jira/browse/KAFKA-16866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16866:
--
Assignee: Chia-Ping Tsai
> RemoteLogManagerTest.testCopyQuotaManagerConfig failing
>
chia7712 commented on PR #15625:
URL: https://github.com/apache/kafka/pull/15625#issuecomment-2140866041
@jolshan I file https://github.com/apache/kafka/pull/16146 to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
jolshan commented on code in PR #16088:
URL: https://github.com/apache/kafka/pull/16088#discussion_r1621424229
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java:
##
@@ -71,63 +69,54 @@ public class OptimizedUnif
[
https://issues.apache.org/jira/browse/KAFKA-16833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16833:
--
Assignee: Alyssa Huang
> Cluster missing topicIds from equals and hashCode, Partition
[
https://issues.apache.org/jira/browse/KAFKA-16833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16833.
Fix Version/s: 3.8.0
Resolution: Fixed
> Cluster missing topicIds from equals and h
chia7712 merged PR #16062:
URL: https://github.com/apache/kafka/pull/16062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #16062:
URL: https://github.com/apache/kafka/pull/16062#issuecomment-2140856964
The failed test is traced by
https://issues.apache.org/jira/browse/KAFKA-16866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jolshan commented on code in PR #16088:
URL: https://github.com/apache/kafka/pull/16088#discussion_r1621422471
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java:
##
@@ -144,216 +133,137 @@ protected GroupAssignm
jolshan commented on code in PR #16088:
URL: https://github.com/apache/kafka/pull/16088#discussion_r1621421194
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java:
##
@@ -144,216 +133,137 @@ protected GroupAssignm
chia7712 merged PR #16066:
URL: https://github.com/apache/kafka/pull/16066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-16047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Edoardo Comar reassigned KAFKA-16047:
-
Assignee: Edoardo Comar
> Source connector with EOS enabled have some InitProducerId re
chia7712 commented on PR #16109:
URL: https://github.com/apache/kafka/pull/16109#issuecomment-2140831052
@OmniaGM nice idea but we need to fix conflicts first :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dongnuo123 commented on code in PR #16145:
URL: https://github.com/apache/kafka/pull/16145#discussion_r1621405276
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -325,24 +325,12 @@ private Group validateOffsetCommit(
dongnuo123 commented on code in PR #16145:
URL: https://github.com/apache/kafka/pull/16145#discussion_r1621403173
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/classic/ClassicGroup.java:
##
@@ -857,6 +857,7 @@ public void validateOffsetCommit(
chia7712 merged PR #16112:
URL: https://github.com/apache/kafka/pull/16112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
kirktrue closed pull request #16031: KAFKA-16200: Enforce that RequestManager
implementations respect user-provided timeout
URL: https://github.com/apache/kafka/pull/16031
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
dongnuo123 opened a new pull request, #16145:
URL: https://github.com/apache/kafka/pull/16145
During online migration, there could be ConsumerGroup that has members that
uses the classic protocol. In the current implementation, `STALE_MEMBER_EPOCH`
could be thrown in ConsumerGroup offset fe
gharris1727 commented on code in PR #15513:
URL: https://github.com/apache/kafka/pull/15513#discussion_r1621400369
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamOuterJoinTest.java:
##
@@ -737,12 +739,12 @@ public void runOuterJoin(final Stream
brenden20 commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1621395136
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -327,8 +339,11 @@ void testEnsureEventsAreCompleted() {
Justine Olshan created KAFKA-16866:
--
Summary: RemoteLogManagerTest.testCopyQuotaManagerConfig failing
Key: KAFKA-16866
URL: https://issues.apache.org/jira/browse/KAFKA-16866
Project: Kafka
I
brenden20 commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1621386306
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -149,20 +157,28 @@ public void testStartupAndTearDown() thr
jolshan commented on PR #15625:
URL: https://github.com/apache/kafka/pull/15625#issuecomment-2140804438
Can we look at testCopyQuotaManagerConfig() –
kafka.log.remote.RemoteLogManagerTest? It seems like it is failing pretty
consistently.
--
This is an automated message from the Apache G
brenden20 commented on PR #16124:
URL: https://github.com/apache/kafka/pull/16124#issuecomment-2140800759
@kirktrue thank you for the suggestions, I have implemented and pushed your
suggestions. Let me know if everything looks good!
--
This is an automated message from the Apache Git Serv
chia7712 commented on PR #16112:
URL: https://github.com/apache/kafka/pull/16112#issuecomment-2140786920
@ahmedryasser Thanks for your contribution. Could you please add "MINOR: "
to your title?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
cmccabe commented on code in PR #15945:
URL: https://github.com/apache/kafka/pull/15945#discussion_r1621372420
##
metadata/src/main/java/org/apache/kafka/image/publisher/BrokerRegistrationTracker.java:
##
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
chia7712 commented on PR #16116:
URL: https://github.com/apache/kafka/pull/16116#issuecomment-2140785638
@OmniaGM Sorry that please fix the conflicts again :_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
chia7712 commented on code in PR #16097:
URL: https://github.com/apache/kafka/pull/16097#discussion_r1621368550
##
build.gradle:
##
@@ -787,6 +800,12 @@ subprojects {
skipProjects = [ ":jmh-benchmarks", ":trogdor" ]
skipConfigurations = [ "zinc" ]
}
+
+ afterEvalua
gharris1727 commented on code in PR #16095:
URL: https://github.com/apache/kafka/pull/16095#discussion_r1621349710
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##
@@ -231,6 +231,12 @@ private synchronized void onFailure(Throwable t) {
chia7712 commented on code in PR #16097:
URL: https://github.com/apache/kafka/pull/16097#discussion_r1621358471
##
checkstyle/suppressions.xml:
##
@@ -361,4 +361,7 @@
+
+
Review Comment:
why we need this change?
##
build.gradle:
##
@@ -1007
[
https://issues.apache.org/jira/browse/KAFKA-16518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850851#comment-17850851
]
Muralidhar Basani commented on KAFKA-16518:
---
[~jsancio] have one short questio
chia7712 commented on code in PR #16133:
URL: https://github.com/apache/kafka/pull/16133#discussion_r1621350440
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -675,7 +677,7 @@ object DynamicLogConfig {
// Exclude message.format.version for now since we n
dajac commented on PR #16120:
URL: https://github.com/apache/kafka/pull/16120#issuecomment-2140752725
The build does not seem to start… I am not sure why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
kirktrue commented on PR #16115:
URL: https://github.com/apache/kafka/pull/16115#issuecomment-2140747685
@brenden20, as mentioned on another one of your PRs, there's a checkstyle
violation here. You can run this command locally to avoid waiting for the CI
infrastructure to catch it:
dajac commented on code in PR #16120:
URL: https://github.com/apache/kafka/pull/16120#discussion_r1621344907
##
server-common/src/main/java/org/apache/kafka/server/common/GroupVersion.java:
##
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
kirktrue commented on PR #16124:
URL: https://github.com/apache/kafka/pull/16124#issuecomment-2140745523
The test failures are unrelated, FWIW.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kirktrue commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1621342452
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -53,89 +39,111 @@
import org.junit.jupiter.params.provider.
dajac merged PR #16139:
URL: https://github.com/apache/kafka/pull/16139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
kirktrue commented on PR #16140:
URL: https://github.com/apache/kafka/pull/16140#issuecomment-2140741298
Looks like there are some checkstyle failures due to the use of wildcard
imports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kirktrue commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1621334851
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -1290,4 +1290,4 @@ static class MemberInfo {
this.me
chia7712 commented on code in PR #15989:
URL: https://github.com/apache/kafka/pull/15989#discussion_r1621334504
##
connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaConfigBackingStoreMockitoTest.java:
##
@@ -1184,6 +1185,141 @@ public void
testRestoreRestartRe
kirktrue commented on code in PR #16124:
URL: https://github.com/apache/kafka/pull/16124#discussion_r1621332051
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -478,6 +478,23 @@ public void resetTimer() {
this
[
https://issues.apache.org/jira/browse/KAFKA-16802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris resolved KAFKA-16802.
-
Fix Version/s: 3.8.0
Resolution: Fixed
> Move build.gradle java version information insid
gharris1727 merged PR #16135:
URL: https://github.com/apache/kafka/pull/16135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apa
chia7712 commented on PR #16042:
URL: https://github.com/apache/kafka/pull/16042#issuecomment-2140664027
> The test names are testDescribeLogDirsWithoutAnyPartitionTopic and
testDescribeLogDirs.
It seems to me the method needs to come with the guarantee:
`DescribeLogDirsTopic` should
[
https://issues.apache.org/jira/browse/KAFKA-15305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850834#comment-17850834
]
Chia-Ping Tsai commented on KAFKA-15305:
{quote}
So seems we also need to make s
dajac merged PR #16128:
URL: https://github.com/apache/kafka/pull/16128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
kirktrue commented on PR #16031:
URL: https://github.com/apache/kafka/pull/16031#issuecomment-2140558404
I'm going to close and reopen to force another build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
kirktrue closed pull request #16031: KAFKA-16200: Enforce that RequestManager
implementations respect user-provided timeout
URL: https://github.com/apache/kafka/pull/16031
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
kirktrue commented on PR #16031:
URL: https://github.com/apache/kafka/pull/16031#issuecomment-2140558063
@lianetm—relevant test failures have been addressed. There are three
unrelated test failures from flaky tests.
--
This is an automated message from the Apache Git Service.
To respond t
rreddy-22 commented on code in PR #16068:
URL: https://github.com/apache/kafka/pull/16068#discussion_r1621207749
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/MemberSubscriptionSpecImpl.java:
##
@@ -18,105 +18,63 @@
import org.apache.kafka.com
rreddy-22 commented on code in PR #16068:
URL: https://github.com/apache/kafka/pull/16068#discussion_r1621196989
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GroupSpec.java:
##
@@ -39,4 +41,20 @@ public interface GroupSpec {
* Fals
rreddy-22 commented on code in PR #16068:
URL: https://github.com/apache/kafka/pull/16068#discussion_r1621186636
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GroupSpec.java:
##
@@ -39,4 +41,20 @@ public interface GroupSpec {
* Fals
rreddy-22 commented on code in PR #16068:
URL: https://github.com/apache/kafka/pull/16068#discussion_r1621186636
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GroupSpec.java:
##
@@ -39,4 +41,20 @@ public interface GroupSpec {
* Fals
jolshan commented on code in PR #16130:
URL: https://github.com/apache/kafka/pull/16130#discussion_r1621089819
##
core/src/test/scala/unit/kafka/tools/StorageToolTest.scala:
##
@@ -354,6 +354,7 @@ Found problem:
MetadataVersion.LATEST_PRODUCTION,
Map(TestFeatur
1 - 100 of 204 matches
Mail list logo
