[jira] [Assigned] (KAFKA-18926) `KafkaPrincipalBuilder` should extend `KafkaPrincipalSerde`

2025-06-17 Thread Szu-Yung Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szu-Yung Wang reassigned KAFKA-18926: - Assignee: Szu-Yung Wang (was: Chia-Ping Tsai) > `KafkaPrincipalBuilder` should extend

[jira] [Created] (KAFKA-19415) Improve fairness of partition fetch order when clients fetch data to avoid partition starvation

2025-06-17 Thread corkitse (Jira)
corkitse created KAFKA-19415: Summary: Improve fairness of partition fetch order when clients fetch data to avoid partition starvation Key: KAFKA-19415 URL: https://issues.apache.org/jira/browse/KAFKA-19415

Re: [PR] KAFKA-18966: Change controller_num_nodes_override to override_num_isolated_controllers [kafka]

2025-06-17 Thread via GitHub
github-actions[bot] commented on PR #19194: URL: https://github.com/apache/kafka/pull/19194#issuecomment-2982569513 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] MINOR Capture heap dump after OOM on CI [kafka]

2025-06-17 Thread via GitHub
github-actions[bot] commented on PR #19031: URL: https://github.com/apache/kafka/pull/19031#issuecomment-2982569410 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] [WIP] KAFKA-18877: Add an mechanism to find cases where we accessed variables from the wrong thread. [kafka]

2025-06-17 Thread via GitHub
github-actions[bot] commented on PR #19231: URL: https://github.com/apache/kafka/pull/19231#issuecomment-2982537704 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18379: Enforce resigned cannot transition to any other state in same epoch [kafka]

2025-06-17 Thread via GitHub
github-actions[bot] commented on PR #19236: URL: https://github.com/apache/kafka/pull/19236#issuecomment-2982537665 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-19306: Migrate LogCompactionTester to tools module [kafka]

2025-06-17 Thread via GitHub
github-actions[bot] commented on PR #19905: URL: https://github.com/apache/kafka/pull/19905#issuecomment-2982537336 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] Bump requests from 2.31.0 to 2.32.4 in /tests [kafka]

2025-06-17 Thread via GitHub
github-actions[bot] commented on PR #19940: URL: https://github.com/apache/kafka/pull/19940#issuecomment-2982537292 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-19395 - Updated Junit and mockito version and license information in NOTICE-binary for Jakarta RESTful Web Services Project [kafka]

2025-06-17 Thread via GitHub
github-actions[bot] commented on PR #19943: URL: https://github.com/apache/kafka/pull/19943#issuecomment-2982537276 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[PR] KAFKA-19414: Remove 2PC public APIs from 4.1 until release (KIP-939) [kafka]

2025-06-17 Thread via GitHub
rreddy-22 opened a new pull request, #19985: URL: https://github.com/apache/kafka/pull/19985 We are removing some of the previously added public APIs until KIP-939 is ready to use. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (KAFKA-19414) Remove Public APIs from 4.1

2025-06-17 Thread Ritika Reddy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ritika Reddy updated KAFKA-19414: - Affects Version/s: 4.1.0 > Remove Public APIs from 4.1 > --- > >

[jira] [Updated] (KAFKA-19414) Remove Public APIs from 4.1

2025-06-17 Thread Ritika Reddy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ritika Reddy updated KAFKA-19414: - Priority: Blocker (was: Major) > Remove Public APIs from 4.1 > --- > >

[jira] [Created] (KAFKA-19414) Remove Public APIs from 4.1

2025-06-17 Thread Ritika Reddy (Jira)
Ritika Reddy created KAFKA-19414: Summary: Remove Public APIs from 4.1 Key: KAFKA-19414 URL: https://issues.apache.org/jira/browse/KAFKA-19414 Project: Kafka Issue Type: Sub-task

[jira] [Resolved] (KAFKA-19082) Client side changes to enable 2PC

2025-06-17 Thread Ritika Reddy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ritika Reddy resolved KAFKA-19082. -- Resolution: Fixed > Client side changes to enable 2PC > - > >

Re: [PR] KAFKA-19324: Make org.apache.kafka.common.test.TestUtils package-private to prevent cross-module access [kafka]

2025-06-17 Thread via GitHub
chia7712 commented on code in PR #19884: URL: https://github.com/apache/kafka/pull/19884#discussion_r2153472694 ## test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/junit/RaftClusterInvocationContext.java: ## @@ -71,6 +71,41 @@ public class RaftClusterIn

Re: [PR] KAFKA-19356: Prevent new consumer fetch assigned partitions not in explicit subscription [kafka]

2025-06-17 Thread via GitHub
DL1231 commented on code in PR #19983: URL: https://github.com/apache/kafka/pull/19983#discussion_r2153469078 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/SubscriptionStateTest.java: ## @@ -113,6 +116,54 @@ public void partitionAssignmentChangeOnTopicSubs

Re: [PR] KAFKA-19239 Rewrite IntegrationTestUtils by java [kafka]

2025-06-17 Thread via GitHub
chia7712 commented on code in PR #19776: URL: https://github.com/apache/kafka/pull/19776#discussion_r2153459442 ## core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala: ## @@ -556,9 +557,11 @@ class ClientQuotasRequestTest(cluster: ClusterInstance) { private

Re: [PR] KAFKA-18884: Move TransactionMetadata to transaction-coordinator module [kafka]

2025-06-17 Thread via GitHub
chia7712 commented on PR #19699: URL: https://github.com/apache/kafka/pull/19699#issuecomment-2982320867 convert this PR to draft to wait for KAFKA-15370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-19407 Fix potential IllegalStateException when appending to timeIndex [kafka]

2025-06-17 Thread via GitHub
ocadaruma commented on code in PR #19972: URL: https://github.com/apache/kafka/pull/19972#discussion_r2153218635 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -192,8 +192,13 @@ public void sanityCheck(boolean timeIndexFileNewlyCreated) t

Re: [PR] initial POC of disk full implementation [kafka]

2025-06-17 Thread via GitHub
neerajr0 closed pull request #19984: initial POC of disk full implementation URL: https://github.com/apache/kafka/pull/19984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] initial POC of disk full implementation [kafka]

2025-06-17 Thread via GitHub
neerajr0 opened a new pull request, #19984: URL: https://github.com/apache/kafka/pull/19984 Rough draft of disk full implementation based on design from @clolov. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-19400: Update AddRaftVoterRequest RPC to version 1 [kafka]

2025-06-17 Thread via GitHub
kevin-wu24 commented on code in PR #19982: URL: https://github.com/apache/kafka/pull/19982#discussion_r2153376114 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -374,26 +428,104 @@ public void testAddVoter() throws Exception { ap

Re: [PR] KAFKA-19400: Update AddRaftVoterRequest RPC to version 1 [kafka]

2025-06-17 Thread via GitHub
kevin-wu24 commented on code in PR #19982: URL: https://github.com/apache/kafka/pull/19982#discussion_r2153376114 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -374,26 +428,104 @@ public void testAddVoter() throws Exception { ap

Re: [PR] KAFKA-19400: Update AddRaftVoterRequest RPC to version 1 [kafka]

2025-06-17 Thread via GitHub
kevin-wu24 commented on code in PR #19982: URL: https://github.com/apache/kafka/pull/19982#discussion_r2153374075 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -374,26 +428,104 @@ public void testAddVoter() throws Exception { ap

Re: [PR] KAFKA-19400: Update AddRaftVoterRequest RPC to version 1 [kafka]

2025-06-17 Thread via GitHub
ahuang98 commented on code in PR #19982: URL: https://github.com/apache/kafka/pull/19982#discussion_r2153357990 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -374,26 +428,104 @@ public void testAddVoter() throws Exception { apiV

Re: [PR] KAFKA-19400: Update AddRaftVoterRequest RPC to version 1 [kafka]

2025-06-17 Thread via GitHub
ahuang98 commented on code in PR #19982: URL: https://github.com/apache/kafka/pull/19982#discussion_r2153356832 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -374,26 +428,104 @@ public void testAddVoter() throws Exception { apiV

Re: [PR] KAFKA-19400: Update AddRaftVoterRequest RPC to version 1 [kafka]

2025-06-17 Thread via GitHub
ahuang98 commented on code in PR #19982: URL: https://github.com/apache/kafka/pull/19982#discussion_r2153340326 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -374,26 +428,104 @@ public void testAddVoter() throws Exception { apiV

Re: [PR] KAFKA-19400: Update AddRaftVoterRequest RPC to version 1 [kafka]

2025-06-17 Thread via GitHub
ahuang98 commented on code in PR #19982: URL: https://github.com/apache/kafka/pull/19982#discussion_r2153340326 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -374,26 +428,104 @@ public void testAddVoter() throws Exception { apiV

Re: [PR] MINOR: Refactor createResponseConfig to avoid collection copy and conversion [kafka]

2025-06-17 Thread via GitHub
yunchipang commented on code in PR #19867: URL: https://github.com/apache/kafka/pull/19867#discussion_r2153326295 ## core/src/main/scala/kafka/server/ConfigHelper.scala: ## @@ -86,19 +81,34 @@ class ConfigHelper(metadataCache: MetadataCache, config: KafkaConfig, configRepo

[jira] [Updated] (KAFKA-19021) Broker should not be allowed to be promoted to controller

2025-06-17 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-19021: --- Fix Version/s: 4.2.0 (was: 4.1.0) > Broker sh

Re: [PR] KAFKA-19397: Not relaying on metadata to map between topic id and name. [kafka]

2025-06-17 Thread via GitHub
kirktrue commented on code in PR #19964: URL: https://github.com/apache/kafka/pull/19964#discussion_r2153260298 ## clients/src/main/java/org/apache/kafka/common/TopicIdPartition.java: ## @@ -78,6 +78,22 @@ public TopicPartition topicPartition() { return topicPartition;

Re: [PR] KAFKA-19367: Follow up bug fix [kafka]

2025-06-17 Thread via GitHub
jolshan merged PR #19976: URL: https://github.com/apache/kafka/pull/19976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-19356: Prevent new consumer fetch assigned partitions not in explicit subscription [kafka]

2025-06-17 Thread via GitHub
kirktrue commented on code in PR #19983: URL: https://github.com/apache/kafka/pull/19983#discussion_r2153244230 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchCollector.java: ## @@ -155,7 +155,10 @@ private Fetch fetchRecords(final CompletedFetch next

Re: [PR] KAFKA-19411: Fix deleteAcls bug which allows more deletions than max records per user op [kafka]

2025-06-17 Thread via GitHub
ahuang98 commented on code in PR #19974: URL: https://github.com/apache/kafka/pull/19974#discussion_r2153241182 ## metadata/src/main/java/org/apache/kafka/controller/AclControlManager.java: ## @@ -199,13 +203,14 @@ AclDeleteResult deleteAclsForFilter(AclBindingFilter filter,

Re: [PR] KAFKA-19411: Fix deleteAcls bug which allows more deletions than max records per user op [kafka]

2025-06-17 Thread via GitHub
cmccabe commented on code in PR #19974: URL: https://github.com/apache/kafka/pull/19974#discussion_r2153238326 ## metadata/src/main/java/org/apache/kafka/controller/AclControlManager.java: ## @@ -199,13 +203,14 @@ AclDeleteResult deleteAclsForFilter(AclBindingFilter filter,

Re: [PR] KAFKA-19078: Implement automatic controller addition to cluster metadata partition [kafka]

2025-06-17 Thread via GitHub
kevin-wu24 commented on code in PR #19589: URL: https://github.com/apache/kafka/pull/19589#discussion_r2153236002 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -3306,6 +3383,22 @@ private UpdateRaftVoterRequestData buildUpdateVoterRequest() {

Re: [PR] KAFKA-19407 Fix potential IllegalStateException when appending to timeIndex [kafka]

2025-06-17 Thread via GitHub
ocadaruma commented on code in PR #19972: URL: https://github.com/apache/kafka/pull/19972#discussion_r2153218635 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -192,8 +192,13 @@ public void sanityCheck(boolean timeIndexFileNewlyCreated) t

Re: [PR] KAFKA-19297: Refactor AsyncKafkaConsumer's use of Java Streams APIs in critical sections [kafka]

2025-06-17 Thread via GitHub
kirktrue commented on code in PR #19917: URL: https://github.com/apache/kafka/pull/19917#discussion_r2153170900 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -84,16 +84,21 @@ public TopicMetadataRequestManager(final

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

2025-06-17 Thread via GitHub
jolshan commented on PR #17022: URL: https://github.com/apache/kafka/pull/17022#issuecomment-2981743810 Ok -- I'm back. I think the thing that wasn't sitting right for me, and what I realized from our discussion with the producer ID overflow is whether this is the right place to make the ch

Re: [PR] KAFKA-19297: Refactor AsyncKafkaConsumer's use of Java Streams APIs in critical sections [kafka]

2025-06-17 Thread via GitHub
lianetm commented on code in PR #19917: URL: https://github.com/apache/kafka/pull/19917#discussion_r2153086039 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -84,16 +84,21 @@ public TopicMetadataRequestManager(final L

[jira] [Updated] (KAFKA-19223) Explicit HWM replication

2025-06-17 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-19223: --- Fix Version/s: 4.1.0 > Explicit HWM replication > --

[jira] [Resolved] (KAFKA-18818) Significant delay in Metadata Update After Admin Client Operations in KRaft Mode

2025-06-17 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio resolved KAFKA-18818. Resolution: Fixed > Significant delay in Metadata Update After Adm

[jira] [Resolved] (KAFKA-19223) Explicit HWM replication

2025-06-17 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio resolved KAFKA-19223. Resolution: Fixed > Explicit HWM replication > ---

[jira] [Resolved] (KAFKA-14145) Faster propagation of high-watermark in KRaft topic partitions

2025-06-17 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio resolved KAFKA-14145. Resolution: Fixed > Faster propagation of high-watermark in KRaft

[jira] [Updated] (KAFKA-18818) Significant delay in Metadata Update After Admin Client Operations in KRaft Mode

2025-06-17 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-18818: --- Fix Version/s: 4.1.0 > Significant delay in Metadata Update After Ad

[jira] [Resolved] (KAFKA-18751) Complete delayed FETCH request when HWM is increased.

2025-06-17 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio resolved KAFKA-18751. Resolution: Fixed > Complete delayed FETCH request when HWM is inc

Re: [PR] KAFKA-19407 Fix potential IllegalStateException when appending to timeIndex [kafka]

2025-06-17 Thread via GitHub
chia7712 commented on code in PR #19972: URL: https://github.com/apache/kafka/pull/19972#discussion_r2152939051 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -192,8 +192,13 @@ public void sanityCheck(boolean timeIndexFileNewlyCreated) th

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

2025-06-17 Thread via GitHub
mjsax commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2152880201 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -790,14 +790,34 @@ public synchronized void maybeTransitionToErrorSta

Re: [PR] KAFKA-14145; Faster KRaft HWM replication [kafka]

2025-06-17 Thread via GitHub
jsancio merged PR #19800: URL: https://github.com/apache/kafka/pull/19800 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-19367: Follow up bug fix [kafka]

2025-06-17 Thread via GitHub
jolshan commented on code in PR #19976: URL: https://github.com/apache/kafka/pull/19976#discussion_r2152736969 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -977,10 +977,9 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

[PR] KAFKA-19356: Prevent new consumer fetch assigned partitions not in explicit subscription [kafka]

2025-06-17 Thread via GitHub
lianetm opened a new pull request, #19983: URL: https://github.com/apache/kafka/pull/19983 Fix to ensure assigned partitions whose topics are not in the consumer explicit subscription are considered not fetchable (so that no records are returned on poll for them) This scenario could

[jira] [Resolved] (KAFKA-19350) don't propagate the error caused by CreateTopicPolicy to FatalFaultHandler

2025-06-17 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19350. Fix Version/s: 4.2.0 Resolution: Fixed > don't propagate the error caused by Create

Re: [PR] KAFKA-19350 Don't propagate the error caused by CreateTopicPolicy to FatalFaultHandler [kafka]

2025-06-17 Thread via GitHub
chia7712 merged PR #19857: URL: https://github.com/apache/kafka/pull/19857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

2025-06-17 Thread via GitHub
jolshan commented on PR #17022: URL: https://github.com/apache/kafka/pull/17022#issuecomment-2981092997 Hey thanks. I took a step back and I'm wondering if this is the right approach. Let me try to get back to you on this -- I need to get a better idea of the whole flow. The discussions on

Re: [PR] KAFKA-19042 Move ProducerSendWhileDeletionTest to client-integration-tests module [kafka]

2025-06-17 Thread via GitHub
chia7712 merged PR #19971: URL: https://github.com/apache/kafka/pull/19971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19397: Not relaying on metadata to map between topic id and name. [kafka]

2025-06-17 Thread via GitHub
OmniaGM commented on code in PR #19964: URL: https://github.com/apache/kafka/pull/19964#discussion_r2152719515 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -855,7 +860,7 @@ private void sendProduceRequest(long now, int destination, sho

Re: [PR] KAFKA-19239 Rewrite IntegrationTestUtils by java [kafka]

2025-06-17 Thread via GitHub
chia7712 commented on code in PR #19776: URL: https://github.com/apache/kafka/pull/19776#discussion_r2152714907 ## server-common/src/test/java/org/apache/kafka/server/IntegrationTestUtils.java: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] KAFKA-19397: Not relaying on metadata to map between topic id and name. [kafka]

2025-06-17 Thread via GitHub
OmniaGM commented on code in PR #19964: URL: https://github.com/apache/kafka/pull/19964#discussion_r2152691409 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -855,7 +860,7 @@ private void sendProduceRequest(long now, int destination, sho

Re: [PR] KAFKA-19397: Not relaying on metadata to map between topic id and name. [kafka]

2025-06-17 Thread via GitHub
OmniaGM commented on code in PR #19964: URL: https://github.com/apache/kafka/pull/19964#discussion_r2152693786 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -855,7 +860,7 @@ private void sendProduceRequest(long now, int destination, sho

Re: [PR] KAFKA-19078: Implement automatic controller addition to cluster metadata partition [kafka]

2025-06-17 Thread via GitHub
kevin-wu24 commented on code in PR #19589: URL: https://github.com/apache/kafka/pull/19589#discussion_r2152693217 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientAutoJoinTest.java: ## @@ -0,0 +1,307 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-19397: Not relaying on metadata to map between topic id and name. [kafka]

2025-06-17 Thread via GitHub
chia7712 commented on code in PR #19964: URL: https://github.com/apache/kafka/pull/19964#discussion_r2152687163 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -855,7 +860,7 @@ private void sendProduceRequest(long now, int destination, sh

[jira] [Updated] (KAFKA-19412) Extended AuthorizerIntegrationTest to cover StreamsGroupHeartbeat

2025-06-17 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-19412: Component/s: streams > Extended AuthorizerIntegrationTest to cover StreamsGroupHeartbeat >

Re: [PR] KAFKA-19397: Not relaying on metadata to map between topic id and name. [kafka]

2025-06-17 Thread via GitHub
OmniaGM commented on PR #19964: URL: https://github.com/apache/kafka/pull/19964#issuecomment-2980999168 I have added some test in ProducerSendWhileDeletionTest to cover recreation while producing as well hope this will be enough to cover these cases. -- This is an automated message from t

Re: [PR] KAFKA-19397: Not relaying on metadata to map between topic id and name. [kafka]

2025-06-17 Thread via GitHub
OmniaGM commented on code in PR #19964: URL: https://github.com/apache/kafka/pull/19964#discussion_r2152668819 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -855,7 +860,7 @@ private void sendProduceRequest(long now, int destination, sho

[PR] KAFKA-19400: Update AddRaftVoterRequest RPC to version 1 [kafka]

2025-06-17 Thread via GitHub
kevin-wu24 opened a new pull request, #19982: URL: https://github.com/apache/kafka/pull/19982 Add the `ackWhenCommitted` boolean field to the `AddRaftVoterRequest` RPC, and bump the RPC's version to 1. - The default value of `ackWhenCommitted` is `true`, and in this case the leader w

Re: [PR] KAFKA-19397: Not relaying on metadata to map between topic id and name. [kafka]

2025-06-17 Thread via GitHub
OmniaGM commented on code in PR #19964: URL: https://github.com/apache/kafka/pull/19964#discussion_r2152650081 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -609,7 +607,14 @@ private void handleProduceResponse(ClientResponse response, M

Re: [PR] KAFKA-19397: Not relaying on metadata to map between topic id and name. [kafka]

2025-06-17 Thread via GitHub
OmniaGM commented on code in PR #19964: URL: https://github.com/apache/kafka/pull/19964#discussion_r2152650081 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -609,7 +607,14 @@ private void handleProduceResponse(ClientResponse response, M

Re: [PR] KAFKA-14145; Faster KRaft HWM replication [kafka]

2025-06-17 Thread via GitHub
jsancio commented on code in PR #19800: URL: https://github.com/apache/kafka/pull/19800#discussion_r2150833728 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -386,6 +385,11 @@ private void onUpdateLeaderHighWatermark( // records still held i

Re: [PR] MINOR: replace test "catch exception" by assertThrows [kafka]

2025-06-17 Thread via GitHub
chia7712 merged PR #19975: URL: https://github.com/apache/kafka/pull/19975 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19397: Not relaying on metadata to map between topic id and name. [kafka]

2025-06-17 Thread via GitHub
OmniaGM commented on code in PR #19964: URL: https://github.com/apache/kafka/pull/19964#discussion_r2152625330 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -609,7 +607,14 @@ private void handleProduceResponse(ClientResponse response, M

Re: [PR] KAFKA-19315: Move ControllerMutationQuotaManager to server module [kafka]

2025-06-17 Thread via GitHub
chia7712 commented on code in PR #19807: URL: https://github.com/apache/kafka/pull/19807#discussion_r2152573554 ## server/src/main/java/org/apache/kafka/server/PermissiveControllerMutationQuota.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] MINOR: Refactor createResponseConfig to avoid collection copy and conversion [kafka]

2025-06-17 Thread via GitHub
chia7712 commented on code in PR #19867: URL: https://github.com/apache/kafka/pull/19867#discussion_r2152560647 ## core/src/main/scala/kafka/server/ConfigHelper.scala: ## @@ -86,19 +81,34 @@ class ConfigHelper(metadataCache: MetadataCache, config: KafkaConfig, configRepo

Re: [PR] KAFKA-19297: Refactor AsyncKafkaConsumer's use of Java Streams APIs in critical sections [kafka]

2025-06-17 Thread via GitHub
kirktrue commented on code in PR #19917: URL: https://github.com/apache/kafka/pull/19917#discussion_r2152538609 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerRebalanceListenerInvoker.java: ## @@ -103,11 +114,14 @@ public Exception invokePartitionsR

[PR] KAFKA-19413: Extended AuthorizerIntegrationTest to cover StreamsGroupDescribe [kafka]

2025-06-17 Thread via GitHub
lucasbru opened a new pull request, #19981: URL: https://github.com/apache/kafka/pull/19981 Extending test coverage of authorization for streams group RPC StreamsGroupDescribe. The RPC requires DESCRIBE GROUP and DESCRIBE TOPIC permissions for all topics. -- This is an automated mes

Re: [PR] KAFKA-19413: Extended AuthorizerIntegrationTest to cover StreamsGroupDescribe [kafka]

2025-06-17 Thread via GitHub
Copilot commented on code in PR #19981: URL: https://github.com/apache/kafka/pull/19981#discussion_r2152531189 ## core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala: ## @@ -225,7 +227,9 @@ class AuthorizerIntegrationTest extends AbstractAuthorizerIntegrat

[jira] [Updated] (KAFKA-14410) Allow connect runtime to run multiple versions of a connector.

2025-06-17 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14410: Fix Version/s: 4.1.0 > Allow connect runtime to run multiple versions of a connector. > -

Re: [PR] KAFKA-14895: [2/N] Move AddPartitionsToTxnManager files to java [kafka]

2025-06-17 Thread via GitHub
chia7712 merged PR #19933: URL: https://github.com/apache/kafka/pull/19933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-14895) Move AddPartitionsToTxnManager files to java

2025-06-17 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-14895. Fix Version/s: 4.2.0 Resolution: Fixed > Move AddPartitionsToTxnManager files to ja

Re: [PR] MINOR: Restore original behavior of GroupAuthorizerIntegrationTest [kafka]

2025-06-17 Thread via GitHub
chia7712 commented on code in PR #19968: URL: https://github.com/apache/kafka/pull/19968#discussion_r2152461008 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/security/GroupAuthorizerIntegrationTest.java: ## @@ -255,15 +280,15 @@ public void testUna

Re: [PR] MINOR: add lower case lister name integration test [kafka]

2025-06-17 Thread via GitHub
chia7712 merged PR #19932: URL: https://github.com/apache/kafka/pull/19932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19412: Extended AuthorizerIntegrationTest to cover StreamsGroupHeartbeat [kafka]

2025-06-17 Thread via GitHub
lucasbru merged PR #19978: URL: https://github.com/apache/kafka/pull/19978 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19397: Not relaying on metadata to map between topic id and name. [kafka]

2025-06-17 Thread via GitHub
chia7712 commented on code in PR #19964: URL: https://github.com/apache/kafka/pull/19964#discussion_r2152340372 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -609,7 +607,14 @@ private void handleProduceResponse(ClientResponse response,

[PR] KAFKA-19259: Async consumer fetch intermittent delays on console consumer [kafka]

2025-06-17 Thread via GitHub
kirktrue opened a new pull request, #19980: URL: https://github.com/apache/kafka/pull/19980 There’s a difference in the two consumers’ `pollForFetches()` methods in this case: `ClassicKafkaConsumer` doesn't block waiting for data in the fetch buffer, but `AsyncKafkaConsumer` does. In

Re: [PR] KAFKA-18627: Deprecated "org.apache.kafka.disallowed.login.modules" [kafka]

2025-06-17 Thread via GitHub
chia7712 commented on code in PR #18683: URL: https://github.com/apache/kafka/pull/18683#discussion_r2152310283 ## clients/src/test/java/org/apache/kafka/common/security/JaasContextTest.java: ## @@ -252,6 +254,32 @@ public void testDisallowedLoginModulesSystemProperty() throws

Re: [PR] KAFKA-19397: Not relaying on metadata to map between topic id and name. [kafka]

2025-06-17 Thread via GitHub
OmniaGM commented on code in PR #19964: URL: https://github.com/apache/kafka/pull/19964#discussion_r2152281872 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -609,7 +607,22 @@ private void handleProduceResponse(ClientResponse response, M

Re: [PR] KAFKA-19397: Not relaying on metadata to map between topic id and name. [kafka]

2025-06-17 Thread via GitHub
OmniaGM commented on code in PR #19964: URL: https://github.com/apache/kafka/pull/19964#discussion_r2152280065 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -609,7 +607,22 @@ private void handleProduceResponse(ClientResponse response, M

Re: [PR] KAFKA-19397: Not relaying on metadata to map between topic id and name. [kafka]

2025-06-17 Thread via GitHub
OmniaGM commented on code in PR #19964: URL: https://github.com/apache/kafka/pull/19964#discussion_r2152276755 ## clients/src/main/java/org/apache/kafka/common/TopicIdPartition.java: ## @@ -78,6 +78,18 @@ public TopicPartition topicPartition() { return topicPartition;

Re: [PR] KAFKA-19412: Extended AuthorizerIntegrationTest to cover StreamsGroupHeartbeat [kafka]

2025-06-17 Thread via GitHub
lucasbru commented on code in PR #19978: URL: https://github.com/apache/kafka/pull/19978#discussion_r2152165317 ## core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala: ## @@ -3612,6 +3659,200 @@ class AuthorizerIntegrationTest extends AbstractAuthorizerInt

Re: [PR] KAFKA-19407 Fix potential IllegalStateException when appending to timeIndex [kafka]

2025-06-17 Thread via GitHub
mauhiz commented on code in PR #19972: URL: https://github.com/apache/kafka/pull/19972#discussion_r2152124321 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -192,8 +192,13 @@ public void sanityCheck(boolean timeIndexFileNewlyCreated) thro

[PR] MINOR: Add entity types in streams group RPCs [kafka]

2025-06-17 Thread via GitHub
lucasbru opened a new pull request, #19979: URL: https://github.com/apache/kafka/pull/19979 These can be used to implement transformations on top of the RPC definitions. Group IDs were already marked. This PR additionally adds the entityType for all error messages and topic names. -- Thi

Re: [PR] MINOR: replace test "catch exception" by assertThrows [kafka]

2025-06-17 Thread via GitHub
DL1231 commented on code in PR #19975: URL: https://github.com/apache/kafka/pull/19975#discussion_r2152115911 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -1974,12 +1974,9 @@ public void testCloseShouldBeIdempotent(GroupProtocol group

Re: [PR] KAFKA-19412: Extended AuthorizerIntegrationTest to cover StreamsGroupHeartbeat [kafka]

2025-06-17 Thread via GitHub
bbejeck commented on code in PR #19978: URL: https://github.com/apache/kafka/pull/19978#discussion_r2152093035 ## core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala: ## @@ -3612,6 +3659,200 @@ class AuthorizerIntegrationTest extends AbstractAuthorizerInte

[jira] [Commented] (KAFKA-15207) ProducerIdManager#generateProducerId() should return different error code for newer clients

2025-06-17 Thread Abhi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17979918#comment-17979918 ] Abhi commented on KAFKA-15207: -- Please update if this ticket is resolved. > ProducerIdMana

Re: [PR] KAFKA-19350 Don't propagate the error caused by CreateTopicPolicy to FatalFaultHandler [kafka]

2025-06-17 Thread via GitHub
johnny94 commented on code in PR #19857: URL: https://github.com/apache/kafka/pull/19857#discussion_r2152065446 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -871,6 +871,13 @@ private ApiError maybeCheckCreateTopicPolicy(Supplier

Re: [PR] KAFKA-19407 Fix potential IllegalStateException when appending to timeIndex [kafka]

2025-06-17 Thread via GitHub
ocadaruma commented on code in PR #19972: URL: https://github.com/apache/kafka/pull/19972#discussion_r2152051478 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -192,8 +192,13 @@ public void sanityCheck(boolean timeIndexFileNewlyCreated) t

Re: [PR] KAFKA-19407 Fix potential IllegalStateException when appending to timeIndex [kafka]

2025-06-17 Thread via GitHub
ocadaruma commented on code in PR #19972: URL: https://github.com/apache/kafka/pull/19972#discussion_r2152051478 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -192,8 +192,13 @@ public void sanityCheck(boolean timeIndexFileNewlyCreated) t

Re: [PR] KAFKA-19412: Extended AuthorizerIntegrationTest to cover StreamsGroupHeartbeat [kafka]

2025-06-17 Thread via GitHub
Copilot commented on code in PR #19978: URL: https://github.com/apache/kafka/pull/19978#discussion_r2152001964 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2792,11 +2792,19 @@ class KafkaApis(val requestChannel: RequestChannel, if (responseData.stat

[PR] KAFKA-19412: Extended AuthorizerIntegrationTest to cover StreamsGroupHeartbeat [kafka]

2025-06-17 Thread via GitHub
lucasbru opened a new pull request, #19978: URL: https://github.com/apache/kafka/pull/19978 Extending test coverage of authorization for streams group RPC StreamsGroupHeartbeat. The RPC requires READ GROUP and DESCRIBE TOPIC permissions for all topics. For creating internal topics, we req

[jira] [Assigned] (KAFKA-19412) Extended AuthorizerIntegrationTest to cover StreamsGroupHeartbeat

2025-06-17 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-19412: -- Assignee: Lucas Brutschy > Extended AuthorizerIntegrationTest to cover StreamsGroupHe

[jira] [Assigned] (KAFKA-19413) Extended AuthorizerIntegrationTest to cover StreamsGroupDescribe

2025-06-17 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-19413: -- Assignee: Lucas Brutschy > Extended AuthorizerIntegrationTest to cover StreamsGroupDe

  1   2   >