Re: libksane, KSaneCore and QT_NO_KEYWORDS

ions? Switching to Q_EMIT was done in KF because "emit" is going to be used by the STL in C++20 and later: https://lists.qt-project.org/pipermail/development/2020-February/038812.html https://en.cppreference.com/w/cpp/io/basic_osyncstream/emit Thanks for all clarification and/or explanation! Cheers, Tobias Regards, Ahmad Samir OpenPGP_signature Description: OpenPGP digital signature

Re: New releases for bugfixes

at that branch to find what extra commits their downstream packages don't have yet Regards, Ahmad Samir OpenPGP_signature Description: OpenPGP digital signature

Re: Notice of impending change to Gitlab CI

! This is especially good news for KIO (and possibly other frameworks with unittests that make heavy use of I/O operations). Regards, Ahmad Samir OpenPGP_signature Description: OpenPGP digital signature

Re: Incubating app (Git Klient)

On 22/8/22 18:10, samuel ammonius wrote: Sorry. I was just trying to help. What would the right action be? That would be following the steps at https://community.kde.org/Incubator (Which what Hamed Masafi appears to be doing, first step is posting to this ML). Regards, Ahmad Samir

[Heads-up] ECM 5.96 KDECompilerSettings will add -Werror=undef to GCC/Clang build flags

/kdepim-runtime/-/commit/05a0e5bbfbb06ed6aa88640f25f563cf7e5b1330 [1]https://invent.kde.org/frameworks/extra-cmake-modules/-/commit/25bbb2a4776d36b542857709bb0448a7ea030b59 Regards Ahmad Samir

Re: KF 5.95-rc1 delayed

On 5/6/22 21:26, Ahmad Samir wrote: [...] Could be an issue due to change in https://invent.kde.org/frameworks/knewstuff/-/merge_requests/178 KNewStuff header install locations: https://invent.kde.org/utilities/yakuake/-/merge_requests/61 https://invent.kde.org/games/ksirk/-/merge_requests/9

Re: KF 5.95-rc1 delayed

/ksirk/-/merge_requests/9 -- Ahmad Samir

5.94 respin request: Commit fixing bug in KFileWidget

Due to a (my) previous refactoring in KFileWidget the "show full path" action in KUrlNavigator didn't work any more. https://invent.kde.org/frameworks/kio/-/commit/f2ef14ad1be7e9c87c3a21569ff94a99cd5d4c93 Thanks, Ahmad Samir

Re: The KIPI fate

ed and how much. This would solve (at least in part) the problem described above. -- Ahmad Samir

Re: RFC: Frameworks headers install location

ote_431116 [2] https://invent.kde.org/frameworks/syntax-highlighting/-/merge_requests/305 Thanks, Ahmad Samir On Tue, Apr 5, 2022 at 4:19 PM Ahmad Samir wrote: Hello. - In KF5, ECM, magically, added /usr/include/KF5/ to the CMake targets interface include directories (IIUC for reasons of backwards

RFC: Frameworks headers install location

the argument for this is mitigated by the fact that all our namespaces are CamelCase If we agree with that change this will be for KF6 so as not to break source compatibility for KF5. Best regards, Ahmad Samir

KIdleTime commit fixing crash

Hello. Please include: https://invent.kde.org/frameworks/kidletime/-/commit/cd5040684723b87c7ba5b7cc1b1a63402902a641 in 5.93. Thanks, Ahmad Samir

Re: Submitting KTextTemplate for KF6

an example of submitting a new Framework: https://mail.kde.org/pipermail/kde-frameworks-devel/2019-April/084057.html The relevant Grantlee task on the KF6 workboard: https://phabricator.kde.org/T14887 Best regards Ahmad Samir

Re: Gitlab Bugzilla integration

and will become available the next day. Thanks, Ben Cooksley KDE Sysadmin Good work. That should come in handy. :-) Thanks! -- Ahmad Samir

Re: KF6 meeting notes 2022-01-04

ally need to get that into KF and released. - KCM specific QML files should be moved to KCMUtils https://phabricator.kde.org/T13970 - can be closed Topics to discuss in a slightly larger scope: - solution for the QTextCodec problem - determine hard KF6 blocker tasks -- Ahmad Samir

KF6 meeting notes

Due to only a few making it to the meeting, we didn't discuss any major tasks. An open question, are we going to have a meeting next week? What with Christmas and all? Regards, Ahmad Samir

Re: State of server-side retrace of KDE crashes?

urself, or send patches." Regards, Ahmad Samir

Re: Merge stable to master vs cherry-picking

master git snapshot (e.g. OpenSuse Tumbleweed, or other distros that cater to that workflow, i.e. a rolling distro with frequent master git builds). [...] Regards, -- Ahmad Samir

Re: Merge stable to master vs cherry-picking

r. Cheers, sandro -- Ahmad Samir

Re: Merge stable to master vs cherry-picking

g. Konsole, usually it's fixed on master then backported to stable. So, give it a shot the next time you're fixing something in PIM? (a practical proof is the best kind). :) -- Ahmad Samir

Re: drag/drop into dolphin window - help?

. If this is on wayland, then it sounds like https://invent.kde.org/frameworks/kio/-/merge_requests/619 ? -- Ahmad Samir

Re: How do you label code to be deleted in KF6?

of examples in the repos already. -- Ahmad Samir

Reminder: KF6 weekly meeting

Hello. As was said in the last meeting's notes, the time of the meeting has been changed to 17:00 CET (due to DST change in continental Europe), so that's 16:00 UTC. Have a good day. -- Ahmad Samir

Correction to git script to create a work branch

-d refs/heads/origin/master see this excellent https://stackoverflow.com/a/26046933 post for explanation (I am not a git expert, but that worked, AFAICS). Anyway, the script has been fixed to bail out early if it's called without an arg. Sorry for the inconvenience. :) -- Ahmad Samir

Debugging io-slaves

(when io-slaves aren't forked). Regards, Ahmad Samir

Re: 5.87 respin request

On 10/4/21 14:01, David Faure wrote: On lundi 4 octobre 2021 13:22:22 CEST Ahmad Samir wrote: On 10/3/21 08:29, Ahmad Samir wrote: Please include https://invent.kde.org/frameworks/kwidgetsaddons/-/commit/99d8dca607327ebf 0b6d2f3cff089207c61d7276 Fixes https://bugs.kde.org/show_bug.cgi?id

Re: 5.87 respin request

On 10/3/21 08:29, Ahmad Samir wrote: Please include https://invent.kde.org/frameworks/kwidgetsaddons/-/commit/99d8dca607327ebf0b6d2f3cff089207c61d7276 Fixes https://bugs.kde.org/show_bug.cgi?id=442332 Regards, Ahmad Samir And https://invent.kde.org/frameworks/kwidgetsaddons/-/commit

5.87 respin request

Please include https://invent.kde.org/frameworks/kwidgetsaddons/-/commit/99d8dca607327ebf0b6d2f3cff089207c61d7276 Fixes https://bugs.kde.org/show_bug.cgi?id=442332 Regards, Ahmad Samir

Re: KF API Documentation proposed, small, addition

On 09/09/2021 23:34, Friedrich W. H. Kossebau wrote: Am Donnerstag, 9. September 2021, 23:23:29 CEST schrieb Ahmad Samir: On 09/09/2021 22:47, Friedrich W. H. Kossebau wrote: Am Donnerstag, 9. September 2021, 22:35:05 CEST schrieb Ahmad Samir: On 09/09/2021 22:24, Friedrich W. H. Kossebau

Re: KF API Documentation proposed, small, addition

On 09/09/2021 22:47, Friedrich W. H. Kossebau wrote: Am Donnerstag, 9. September 2021, 22:35:05 CEST schrieb Ahmad Samir: On 09/09/2021 22:24, Friedrich W. H. Kossebau wrote: Am Donnerstag, 9. September 2021, 21:45:33 CEST schrieb Ahmad Samir: On 30/08/2021 16:35, Friedrich W. H. Kossebau

Re: KF API Documentation proposed, small, addition

On 09/09/2021 22:24, Friedrich W. H. Kossebau wrote: Am Donnerstag, 9. September 2021, 21:45:33 CEST schrieb Ahmad Samir: On 30/08/2021 16:35, Friedrich W. H. Kossebau wrote: Thanks for pushing this here. Am Montag, 30. August 2021, 14:17:42 CEST schrieb Ahmad Samir: Open question: in which

Re: KF API Documentation proposed, small, addition

On 30/08/2021 16:35, Friedrich W. H. Kossebau wrote: Thanks for pushing this here. Am Montag, 30. August 2021, 14:17:42 CEST schrieb Ahmad Samir: I would like to add the following to: https://community.kde.org/Frameworks/Frameworks_Documentation_Policy#Documen t_the_Classes One can use

Please include this in 5.86

Fixes KMountPoint::findByPath(): https://invent.kde.org/frameworks/kio/-/commit/147193f5661173d24d75f6558e5607d3418f6c71 Thanks, Ahmad Samir

KF API Documentation proposed, small, addition

/typewriter font face, typically e.g. @c true, @c false, @c setSomeValue(); for multiple words you'll have to use: multiple words * @copydoc to copy the docs of a different method, e.g. if one method overloads another -- Ahmad Samir

Re: RFC: Konsole profile groups

On 31/07/2021 14:30, Konstantin Kharlamov wrote: On Sat, 2021-07-31 at 13:49 +0200, Ahmad Samir wrote: Hello. Is anyone using Konsole profile groups? that is to say, any objections if that code is removed from Konsole? I've never used them, and I don't have any precise idea how they're

RFC: Konsole profile groups

. regards, -- Ahmad Samir

Heads-up: kioslaves .so libs have been renamed

-dir, as most of us do) or from your kdesrc-build installation; so you may want to clear up that situation. That leads to interesting issue, as kioslave5 binary could pick either kf5/kio/file.so or kf5/kio/kio_file.so and you get weird results. Have a good day. -- Ahmad Samir

Re: Porting notes / deprecation docs

t in my usual editor of choice). FWIW, there is supposed to be a KF6 meeting soon[1]. Not sure if we'll start this week or the next one though. [1] https://mail.kde.org/pipermail/kde-frameworks-devel/2021-July/118028.html Thanks! Cheers, Frederik -- Ahmad Samir

Re: Weekly KF6 meeting poll

On 09/07/2021 19:08, Ahmad Samir wrote: On 29/06/2021 16:48, Ahmad Samir wrote: Hello, as was discussed during the KF6 BoF at Akademy, David Edmundson (aka "David 2", not to be confused with "David 1" aka "4" or David 3, aka "the David who still has all

Re: Weekly KF6 meeting poll

On 29/06/2021 16:48, Ahmad Samir wrote: Hello, as was discussed during the KF6 BoF at Akademy, David Edmundson (aka "David 2", not to be confused with "David 1" aka "4" or David 3, aka "the David who still has all the hair on his head"... sorry,

Weekly KF6 meeting poll

ll as a way to find a more suitable time for the weekly KF6 meeting (that we used to have on Saturdays 13:00 UTC), apparently the link might have gone too far under the radar in the KF6 meeting notes that were posted to this ML by Volker. So here it is, please vote: https://doodle.com/poll/94646r75keyxgqkx Have a good day. -- Ahmad Samir

Re: KF5 modules development branches now build in C++17 mode (but keep public headers compatible)

, it does make sense to disable compiler specific extensions. Cheers, Albert > -- Ahmad Samir

Pushing and creating a merge request from the command line

a good day. -- Ahmad Samir

Weekly meeting reminder

/project/board/310/, we're supposed to whittle it down if we want to finally, branch for KF6, no rush, but it should hopefully happen at some point, preferably during our lifetimes. :) All are welcome to join, even if you just want to listen/see how things are done in KDE. Have a good day. -- Ahmad

Re: Progress is good for us but bad for documentation

not find it. Is this an effort with universal scope, or is there a limit? Obviously you are at least talking about the wikis. Are you also (at the current time) talking about other websites and/or application handbooks? Cheers, Johannes ... and API docs :) -- Ahmad Samir

Re: Can we get tags and tarballs for the KDE Qt patch collection

-source Qt release, i.e. deal with it like any other project whose upstream hasn't made any new releases in a long time, but there are new commits in git; I am sure most distro packagers have seen one or two cases as such. My 2p. Have a good day. -- Ahmad Samir

KF6 weekly meeting

things are done in KDE. Have a good day. -- Ahmad Samir

KF6 weekly meeting

stuff are discussed, maybe there is a task there that has your name on it, something that intrigues you and you'd like to work on ...etc. Have a good day. -- Ahmad Samir

KF6 weekly meeting

to take this chance to thank Luigi, who somehow can keep track of all the tasks being discussed and posts the meeting notes on this ML every week o/). Have a good day. -- Ahmad Samir

T14471: Make Qt 5.15.0 to 5.15.2 for frameworks

ahmadsamir added a comment. Anything other than the methods that were added for "portability at the expense of performance", should be OK, famous last words™. :) I've been bitten twice by the QStringView API in Qt5, it has too many surprises, basically because upstream decided to make

KF6 weekly meeting reminder

trying to chisel away at the ever growing KF6 tasks board https://phabricator.kde.org/project/board/310/ Have a good day. -- Ahmad Samir

Re: Including instead of , does it upset POSIX?

On 21/04/2021 15:34, Ahmad Samir wrote: On 21/04/2021 15:20, Harald Sitter wrote: To conclude this our verdict is to always use the modern headers? I am re-checking the rest of the frameworks that failed the first time around; Albert already reported that it built for him locally

Re: Including instead of , does it upset POSIX?

and if the CI doesn't barf on any of it, then my conclusion is it's OK so far. -- Ahmad Samir

Re: Including instead of , does it upset POSIX?

. Thanks for re-checking. Cheers, Albert -- Ahmad Samir

Re: Including instead of , does it upset POSIX?

On 14/04/2021 22:20, Albert Astals Cid wrote: El dimecres, 14 d’abril de 2021, a les 15:13:09 (CEST), Ahmad Samir va escriure: Hello :) A week or so ago I created an MR to include instead of in KIO[1]. From /usr/include/c++/10/cerrno: /** @file cerrno * This is a Standard C

Including instead of , does it upset POSIX?

we use stuff specifically with the expectation that they will behave as documented from a POSIX or linux POV (such as signal safety in kcrash) [1] https://invent.kde.org/frameworks/kio/-/merge_requests/397 -- Ahmad Samir

Saturday, 2021-04-11 KF6 meeting notes

drawback on using a list of KCMs instead of a single KCM. What we forgot to do is pick the tasks for discussion for the next meeting, so if you have suggestions please post them somewhere (on this ML would work best). -- Ahmad Samir

Request for wide spread testing

day. -- Ahmad Samir

clang-format section added to the coding style guide

so that it doesn't mangle your code) Have a good day. :) -- Ahmad Samir

D27224: add Kongress icon

ahmadsamir added a comment. Hello. FWIW, I would also close/abandon this diff :) (nice icon BTW). REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27224 To: mbruchert, dkardarakos, #vdg, ndavis Cc: ahmadsamir, ndavis, kde-frameworks-devel, LeGast00n, cblack,

Re: Retiring

to warrant a patch to fix it :) -- Ahmad Samir

Re: RFC: Switching to min Qt version 5.14 for KF on December 14th

5.13 is essentially unavailable" That's why team jumped to 5.14 directly, don't know the details however. [...] -- Ahmad Samir

T8349: Improve Places panel usability and presentation

ahmadsamir added subscribers: sitter, ahmadsamir. ahmadsamir added a comment. ATM, the behaviour is that if you go to /foo/bar/baz/ and "bar" is present in the places panel, then while you're at baz or any of its sub-folders then "bar" is highlighted in the places panel, i.e the "closest"

Re: CI Breakage in Solid on FreeBSD

/solid/-/merge_requests/17 merged and now we wait to see what the CI will say :) -- Ahmad Samir

Re: Dropping the moderation by default flag

sent an email there and it was postponed due to moderation. Given that kde-core-devel and kde-frameworks-devel are similar, could you please set that same setting for kde-core-devel too? Thanks. :) -- Ahmad Samir

Re: stale MR triaging - you can help!

'Blocked' added so future triage runs will skip them.» -- Ahmad Samir

"Approve"ing an MR

d by bshah at https://gitlab.com/gitlab-org/gitlab/-/issues/231351 Have a good day :) -- Ahmad Samir

"Approve"ing an MR

d by bshah at https://gitlab.com/gitlab-org/gitlab/-/issues/231351 Have a good day :) -- Ahmad Samir

Re: KIO on Android Failure

to guard it with !defind(Q_OS_ANDROID). Should hopefully be fixed by https://invent.kde.org/frameworks/kio/-/merge_requests/107 . -- Ahmad Samir

Re: Porting a project to KDE

/listinfo/kde-devel follow the instructions there to unsubscribe. Have a good day. -- Ahmad Samir

D28460: Add KCModuleData as base class for plugin

ahmadsamir closed this revision. ahmadsamir added a comment. Has been moved to https://invent.kde.org/frameworks/kcmutils/-/merge_requests/10 REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28460 To: bport, #plasma, ervin Cc: ahmadsamir, meven, broulik,

D28460: Add KCModuleData as base class for plugin

ahmadsamir added inline comments. INLINE COMMENTS > kcmoduleloader.cpp:164 > + > +QVariantList args2(args.cbegin(), args.cend()); > + Hello. This breaks the build for Qt 5.12 on the CI, (the min. required version in KF is still 5.12):

D28774: [KFontRequester] Port from QFontDialog to KFontChooserDialog

ahmadsamir added a comment. In D28774#676000 , @volkov wrote: > Why not add support for `QPlatformTheme::FontDialog` in `KdePlatformTheme::createPlatformDialogHelper()`? Sorry about the late reply; I had looked into the platformtheme

Re: Who merges Merge Requests, and when?

e it? Does a reviewer merge it? Personally, I'd wait for one of the reviewers to merge it; but it happens that sometimes a reviewer has already said "change this and that then merge it" in which case, you can go ahead and merge it. I hope that helps (and that my understanding of the issue isn't wrong :)). -- Ahmad Samir

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

ahmadsamir added a comment. @blaze, (I couldn't find your user name at invent.kde.org); FYI: https://invent.kde.org/network/falkon/-/merge_requests/7 REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D28880 To: ahmadsamir, #frameworks, dfaure, blaze Cc:

D29017: WIP: Introduce three new methods that return all "entries" in a folder

ahmadsamir abandoned this revision. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D29017 To: ahmadsamir, #frameworks, dfaure Cc: blaze, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29017: WIP: Introduce three new methods that return all "entries" in a folder

ahmadsamir reopened this revision. ahmadsamir marked an inline comment as done. ahmadsamir added a comment. Move to gitlab https://invent.kde.org/frameworks/kwallet/-/merge_requests/2 REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D29017 To: ahmadsamir, #frameworks,

D29810: Don't use the setenv function after fork

ahmadsamir added a comment. In D29810#674824 , @jpalecek wrote: > In D29810#674815 , @dfaure wrote: > > > This breaks FreeBSD compilation. Please check:

D29017: WIP: Introduce three new methods that return all "entries" in a folder

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R311:1a19afb6a06d: WIP: Introduce three new methods that return all entries in a folder (authored by ahmadsamir).

D29017: WIP: Introduce three new methods that return all "entries" in a folder

ahmadsamir added a comment. In D29017#664279 , @blaze wrote: > Check this commit message https://phabricator.kde.org/R32:f56cdda54b7f88b119f2c7cfb2f534b4fe74478f Sorry for the delay. We applied a workable hack in

D29362: [KCharSelect] Initially give focus to the search lineedit

ahmadsamir added a comment. Moved to https://invent.kde.org/frameworks/kwidgetsaddons/-/merge_requests/2 REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D29362 To: ahmadsamir, #frameworks, cfeck Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,

D29362: [KCharSelect] Initially give focus to the search lineedit

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R236:c0c93cc0fcb5: [KCharSelect] Initially give focus to the search lineedit (authored by ahmadsamir). REPOSITORY R236

D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error

ahmadsamir added inline comments. INLINE COMMENTS > kopenwithdialog.cpp:1009 > +if (QDir::isAbsolutePath(binaryName)) { > +QFileInfo fi(binaryName); > +if (fi.exists() && !fi.isExecutable()) { It's created on the next line. Anyway my initial comment

D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error

ahmadsamir added inline comments. INLINE COMMENTS > broulik wrote in kopenwithdialog.cpp:1008 > Actually, that doesn't exist https://doc.qt.io/qt-5.15/qfileinfo.html#isAbsolute ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29445 To: broulik, #frameworks, #vdg Cc:

D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs

ahmadsamir added a comment. This wasn't landed on master, but rather phabricator is confused by me pushing to work/ branch on gitlab :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29782 To: ahmadsamir, #frameworks, dfaure, sitter Cc: kde-frameworks-devel,

D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:f2984ff28e72: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs (authored by ahmadsamir). CHANGED

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

ahmadsamir added a comment. I guess a proper fix will need to revert part of this to have the KModuleInfo ctor that took a KService not use KPluginInfo internally; better still, of course, is having the KPluginInfo ctor work for the case of X-KDE-ServiceTypes=SystemSettingsExternalApp, (I

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

ahmadsamir added a comment. systemsettings uses KCModuleInfo::service() to check whether the moduleinfo is valid[1], the problem is creating a KPluginInfo from the KService based on a .desktop file with X-KDE-ServiceTypes=SystemSettingsExternalApp fails because it doesn't seem to have valid

D28673: [PackageUrlInterceptor] Make QRegularExpression static

ahmadsamir commandeered this revision. ahmadsamir added a reviewer: broulik. ahmadsamir added a comment. Should be handled by https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/2 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D28673: [PackageUrlInterceptor] Make QRegularExpression static

ahmadsamir abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28673 To: ahmadsamir, #plasma, broulik Cc: ahmadsamir, bruns, pino, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham

D29800: Fix URL being passed as argument when launching a .desktop file

ahmadsamir added a comment. In D29800#672399 , @fvogt wrote: > Landed to invent - hopefully correctly: https://invent.kde.org/frameworks/kio/commit/84e9372f4fa2636f57dc456ac2fa2be271d6a7ec LGTM. REPOSITORY R241 KIO REVISION DETAIL

D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog

ahmadsamir added a comment. In D29558#672395 , @dfaure wrote: > Not committed after all. It was committed, as I had it when I did git pull, but you lucked out, it seemed to have been eaten by the migration to gitlab somehow; I had to

D29787: Fix krununittest

ahmadsamir added a comment. In D29787#672139 , @dfaure wrote: > Let's hope the CI has xterm installed I doubt it. Maybe we'll need to pick "ls" instead, even if that will look weird. The CI seems to have xterm available as the unit

D29787: Fix krununittest

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ef7708d1f5ec: Fix krununittest (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29787?vs=82975=83011 REVISION DETAIL

D29610: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems

This revision was automatically updated to reflect the committed changes. Closed by commit R241:bed09e39fe24: [kio_file] Handle renaming file A to a on FAT32 filesystems (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29610?vs=82750=83010

D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs

ahmadsamir added a comment. I've just realised, we won't get an error with an http url; in that case we return the url the statjob was called on as-is and cancel the job. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29782 To: ahmadsamir, #frameworks, dfaure, sitter

D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs

ahmadsamir added a comment. In D29782#672157 , @dfaure wrote: > Can you add a unittest for a KIO::mostLocalUrl() in testtrash.cpp (which is :local, so it should work) I don't see where the trash ioslave sets UDS_LOCAL_PATH; I think it

D29787: Fix krununittest

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY After 6452a34cf01d03d316 ,

D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs

ahmadsamir updated this revision to Diff 82974. ahmadsamir retitled this revision from "[StatJob] Change mostLocalUrl to only handle protocols with Class=:local" to "[StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs". ahmadsamir edited the summary of this revision. ahmadsamir

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

ahmadsamir added a comment. In D29385#671987 , @dfaure wrote: > That's the point, a NFS mount *is* a local URL, so we do use QFile for it. And then it takes forever because the kernel has to talk over a socket to answer us. > Yes this is

  1   2   3   4   5   6   7   8   9   10   >