Re: [kvm-devel] [PATCH 5/9] KVM: Adds ability to signal userspace using a file-descriptor

2007-05-17 Thread Avi Kivity
Davide Libenzi wrote: > On Wed, 16 May 2007, Avi Kivity wrote: > > >> IMO doing eventfd_fget() asap is best. I much prefer refcounted pointers to >> handles in the kernel: it's easier to see what things point to, and there is >> to context needed for dere

Re: [kvm-devel] OOPS in kernel driver

2007-05-17 Thread Avi Kivity
Adam Majer wrote: > Hi, > > I'm using a somewhat "old" kernel with KVM (KVM included in the kernel). > I think it may be KVM-17 or something like that. Anyway, I got an OOPS > in the module while attempting to install Windows Server 2003 Standard > Edition 32-bit. > > I just started it with > kvm

Re: [kvm-devel] [PATCH] Handle #SS(0), caused by address size override in vm86 mode

2007-05-17 Thread Avi Kivity
Kamble, Nitin A wrote: > Hi Avi, > > I was playing with KVM while booting SuSE Linux 10.1 on it. And I > found it was bailing out with #SS fault. I root caused it to the > address size override opcode (0x67) from a mov instruction from the > boot loader. > The attached patch handles the #SS(0)

Re: [kvm-devel] Regression in latest git-HEAD

2007-05-17 Thread Avi Kivity
Makoto Dei wrote: > Hello, > > I have the same problem with Linux which is using isolinux, > such as Ubuntu. I checked the BIOS in the latest KVM and > I found that it seemed to be missing the following change. > > http://bochs.cvs.sourceforge.net/bochs/bochs/bios/rombios.c?view=log#rev1.172 > >

Re: [kvm-devel] Gentoo livecd amd64 not working?

2007-05-17 Thread Avi Kivity
Wink Saville wrote: >> Please provide a link to the livecd you used. >> > http://bouncer.gentoo.org/fetch/gentoo-2007.0-livecd/amd64/ > > I'm using bridging to connect guest to host and use the following > commands: > > 1) qemu-img create -f qcow gentoo-amd64.img 20G > > 2) qemu-system-x86_64 . -h

Re: [kvm-devel] [PATCH] lighweight VM Exit

2007-05-17 Thread Avi Kivity
Dong, Eddie wrote: > Avi Kivity wrote: > >>> Here it is. >>> >>> >> It's broken; your binutils is probably too old. >> >> >> >>> Can u also send me your bootstrap and flat so that I can try here? >>>

Re: [kvm-devel] [PATCH] lighweight VM Exit

2007-05-17 Thread Avi Kivity
Avi Kivity wrote: > Dong, Eddie wrote: >> Avi Kivity wrote: >> >>>> Here it is. >>>> >>>> >>> It's broken; your binutils is probably too old. >>> >>> >>> >>>> Can u also send

Re: [kvm-devel] [PATCH] Disable stack protector in test suite

2007-05-17 Thread Avi Kivity
Anthony Liguori wrote: > The cc-option is originally from Linux. Applied, thanks. -- error compiling committee.c: too many arguments to function - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the

[kvm-devel] [Fwd: 2.6.22-rc1-mm1: strange GPF when panicing under kvm]

2007-05-17 Thread Avi Kivity
Fitzhardinge <[EMAIL PROTECTED]> To: Avi Kivity <[EMAIL PROTECTED]>, Andi Kleen <[EMAIL PROTECTED]> CC: Andrew Morton <[EMAIL PROTECTED]>, Linux Kernel Mailing List <[EMAIL PROTECTED]> When I boot 2.6.22-rc1-mm1 under kvm, but forget to specify a root

Re: [kvm-devel] [PATCH 5/9] KVM: Adds ability to signal userspace using a file-descriptor

2007-05-20 Thread Avi Kivity
Davide Libenzi wrote: > On Thu, 17 May 2007, Avi Kivity wrote: > > >> Davide Libenzi wrote: >> >>> On Wed, 16 May 2007, Avi Kivity wrote: >>> >>> >>> >>>> IMO doing eventfd_fget() asap is best. I much prefer r

Re: [kvm-devel] [PATCH] MSR_EFER acceleration for lighweight VM Exit

2007-05-20 Thread Avi Kivity
Dong, Eddie wrote: > Avi: > > This patch is to avoid saving and restoring of msr_efer on > lightweight vmexit. > > With this patch, the Kernel build get 10% increasement for > 64bits on 64 bits, > and 5-8% increasement for 32bits on 64 bits. > Vmexit.flat can see ~1185 cycle

Re: [kvm-devel] 2 Bugs found for compilation on 32 Bit machine

2007-05-20 Thread Avi Kivity
Daniel Hecken wrote: > Hello, > > I have an Intel Core 2 Duo running Ubuntu Feisty 2.6.20-15 in 32 Bit > mode. If I try to compile kvm-trunk ( kvm-24-gfbfe1dc ) and the modules > from git ( v2.6.22-rc1-gf552bf6 ) I get a few compiler errors and the > compiler stops. > > Please find attached 2 patch

Re: [kvm-devel] New VT-D spec available

2007-05-20 Thread Avi Kivity
Nakajima, Jun wrote: > An updated specification (Rev 1.0 update) of Intel(r) virtualization > technology for Directed I/O is now available on Intel web site: > > http://download.intel.com/technology/computing/vptech/Intel(r)_VT_for_Di > rect_IO.pdf > > The specification update includes DMA remapp

Re: [kvm-devel] [PATCH/RFC] KVM: Adds support for halting in the kernel

2007-05-20 Thread Avi Kivity
Gregory Haskins wrote: > Hi All, > > I was thinking about some of the issues that we are dealing with > w.r.t. signalling a sleeping userspace (eventfd, signals, etc). I was > wondering if perhaps we were looking at the problem the wrong way. Can we > perform halts in the kernel and the

Re: [kvm-devel] KVM configuration for headless speachless guest VMs?

2007-05-20 Thread Avi Kivity
Dimitry Golubovsky wrote: > Hi, > > I am going to use KVM on a headless machine with sound never on (even > not compiled in the kernel). > > I'm just curious if there is a possibility to build the kvm-qemu > without all this sound/video stuff (or with minimum of it). In > particular, without alsa a

Re: [kvm-devel] [PATCH 0/9] in-kernel APIC v6 (kernel side)

2007-05-20 Thread Avi Kivity
Gregory Haskins wrote: > 2) Moved eventfd patch to end of series and dropped it from the public release > (for now). We dont technically need to signal userspace if PIT is enabled > since this wakes us up anyway. We can defer the eventfd/in-kernel-halt > conversation for later. > The PIT will

Re: [kvm-devel] [PATCH] fix a typo

2007-05-20 Thread Avi Kivity
Dong, Eddie wrote: > Seems a typo leaking our eyes :-( > > > Fixing a typo which mixes X86_64 and CONFIG_X86_64 and block 64 > bits guest now. > > Ouch. Applied & pushed. Thanks. -- error compiling committee.c: too many arguments to function --

Re: [kvm-devel] [PATCH] MSR_EFER acceleration for lighweight VM Exit

2007-05-20 Thread Avi Kivity
Dong, Eddie wrote: > Here is the reformatted one, with the patch 64bits guest Kernel Build > performance > on my platform exceeds Xen by ~7%. > Hey, this came earlier than I expected :) > > +#define msr_efer_save_restore_bits(x) ((x).data & > EFER_SAVE_RESTORE_BITS) > + > This needs to b

Re: [kvm-devel] [PATCH] MSR_EFER acceleration for lighweight VM Exit

2007-05-20 Thread Avi Kivity
Dong, Eddie wrote: > [EMAIL PROTECTED] wrote: > >> Try again. >> > Wrong attachment. Please use this one. > > Applied & thanks. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.

Re: [kvm-devel] 1 Bug found for compiling on 32 Bit machine

2007-05-21 Thread Avi Kivity
Daniel Hecken wrote: > Hello, > > I have found an issue for compiling on 32 Bit machines in > v2.6.22-rc1-g1ab29f3. > > I'm not sure if I have set the #ifdef CONFIG_X86_64 at the right place. > Please have a look at it. With this patch v2.6.22-rc1-g1ab29f3 compiles > und runs fine. > > v2.6.22-

Re: [kvm-devel] [RFC]kvm: swapout guest page

2007-05-21 Thread Avi Kivity
Shaohua Li wrote: > Hi, > I saw some discussions on the topic but no progress. I did an > experiment to make guest page be allocated dynamically and swap out. > please see attachment patches. It's not yet for merge but I'd like get > some suggestions and help. Patches (against kvm-19) work here but

Re: [kvm-devel] [RFC]kvm: swapout guest page

2007-05-21 Thread Avi Kivity
Carsten Otte wrote: > Shaohua Li wrote: > >> +EXPORT_SYMBOL(delete_from_swap_cache); >> +EXPORT_SYMBOL(move_to_swap_cache); >> +EXPORT_SYMBOL(lookup_swap_cache); >> +EXPORT_SYMBOL(read_swap_cache_async); >> +EXPORT_SYMBOL(get_swap_page); >> +EXPORT_SYMBOL(swap_free); >> +EXPORT_SYMBOL(add_to_pag

Re: [kvm-devel] [RFC]kvm: swapout guest page

2007-05-21 Thread Avi Kivity
Carsten Otte wrote: > Avi Kivity wrote: >> For one thing, kvm uses page->private to store its rmap information. >> This is lost if regular mappings are used. >> >> More importantly, both the regular address space and kvm will want to >> be called when a pag

Re: [kvm-devel] [RFC]kvm: swapout guest page

2007-05-21 Thread Avi Kivity
Carsten Otte wrote: > >> An example: suppose host pfn 7 is allocated as guest pfn 8 (and >> therefore, userspace address 0x8000). Suppose further the guest maps >> guest pfn 8 to guest virtual 0x1 and guest virtal 0x11000. >> Aren't there three tlbs you need to shoot down? host virtual >

Re: [kvm-devel] qemu/kvm seems to take ALSA all for itself?

2007-05-21 Thread Avi Kivity
David Abrahams wrote: > When I have windows XP running under kvm, I get > > [EMAIL PROTECTED]:/tmp$ aplay /usr/share/sounds/gaim/receive.wav > ALSA lib pcm_dmix.c:864:(snd_pcm_dmix_open) unable to open slave > aplay: main:550: audio open error: Device or resource busy > > As soon as I shut

Re: [kvm-devel] [RFC]kvm: swapout guest page

2007-05-21 Thread Avi Kivity
Carsten Otte wrote: > Avi Kivity wrote: >> Interesting. And if you have multiple guest virtual to guest >> physical translations, the hardware knows to flush them when the host >> virtual to host physical entry is flushed? > Yes, the cpu flushes all of them. > Ooh,

Re: [kvm-devel] [PATCH/RFC 7/9] Virtual network guest device driver

2007-05-21 Thread Avi Kivity
Anthony Liguori wrote: >> >> In a PV environment why not just pass an initial cookie/hash/whatever >> as a command-line argument/register/memory-space to the underlying >> kernel? >> > > You can't pass a command line argument to Windows (at least, not easily > AFAIK). You could get away with

Re: [kvm-devel] New VT-D spec available

2007-05-22 Thread Avi Kivity
Nakajima, Jun wrote: > I agree that it's straightforward to handle those page tables. The > question is interrupt remapping, i.e. how to inject particular external > interupts to the vm that is reposible for the interrupts without > impacting the kernel code. We are considering the irq chip infrast

Re: [kvm-devel] PIT weirdness

2007-05-22 Thread Avi Kivity
Gregory Haskins wrote: > Hi all, > I found some strangeness with the PIT emulation while working on this APIC > code that I can't quite explain. So I thought I would ping the list to see > if anyone knowledgable can tell me what is happening. > > I am seeing two interrupts coming from the

Re: [kvm-devel] [PATCH/RFC 7/9] Virtual network guest device driver

2007-05-23 Thread Avi Kivity
Eric Van Hensbergen wrote: > On 5/22/07, Christoph Hellwig <[EMAIL PROTECTED]> wrote: >> > >> > I didn't think we were talking about the general case, I thought we >> > were discussing the PV case. >> > >> >> In case of KVM no one is speaking of pure PV. >> > > Why not? It seems worthwhile to come

Re: [kvm-devel] 1 Bug found for compiling on 32 Bit machine

2007-05-23 Thread Avi Kivity
Daniel Hecken wrote: > Avi Kivity schrieb: > >> Daniel Hecken wrote: >> >>> Hello, >>> >>> I have found an issue for compiling on 32 Bit machines in >>> v2.6.22-rc1-g1ab29f3. >>> >>> I'm not sure if I have set th

Re: [kvm-devel] [PATCH/RFC 7/9] Virtual network guest device driver

2007-05-23 Thread Avi Kivity
Christoph Hellwig wrote: > On Tue, May 22, 2007 at 10:00:42AM -0700, ron minnich wrote: > >> On 5/22/07, Eric Van Hensbergen <[EMAIL PROTECTED]> wrote: >> >> >>> I'm not opposed to supporting emulation environments, just don't make >>> a large pile of crap the default like Xen -- and having

Re: [kvm-devel] [PATCH/RFC 7/9] Virtual network guest device driver

2007-05-23 Thread Avi Kivity
ron minnich wrote: > On 5/22/07, Eric Van Hensbergen <[EMAIL PROTECTED]> wrote: > > >> I'm not opposed to supporting emulation environments, just don't make >> a large pile of crap the default like Xen -- and having to integrate >> PCI probing code in my guest domains is a large pile of crap. >>

Re: [kvm-devel] [PATCH/RFC 7/9] Virtual network guest device driver

2007-05-23 Thread Avi Kivity
Nakajima, Jun wrote: > BTW, I'm presenting this at OLS: > http://www.linuxsymposium.org/2007/view_abstract.php?content_key=192 > > This uses direct paging mode today. > Are there patches available anywhere? -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.

Re: [kvm-devel] [PATCH/RFC 7/9] Virtual network guest device driver

2007-05-23 Thread Avi Kivity
Carsten Otte wrote: > I have been closely following thisvery interresting discussion. Here's > my summary: > - PV capabilities is something we'll want > - being able to surface virtual devices to the guest as PCI is > preferable to Windows > - we need an additional way to surface virtual devices

Re: [kvm-devel] qemu/kvm seems to take ALSA all for itself?

2007-05-23 Thread Avi Kivity
David Abrahams wrote: > on Mon May 21 2007, Avi Kivity > wrote: > > >> David Abrahams wrote: >> >>> When I have windows XP running under kvm, I get >>> >>> [EMAIL PROTECTED]:/tmp$ aplay /usr/share/sounds/gaim/receive.wav >>

Re: [kvm-devel] qemu/kvm seems to take ALSA all for itself?

2007-05-23 Thread Avi Kivity
Jon wrote: > On Mon, May 21, 2007 at 08:37:48AM -0700, Shahar Frank wrote: > > >> You have to make QEMU use ALSA as your sound system and specify a >> mixer device for input and output. This can be done using some >> environment variables that should be set before the qemu binary is >> run. >

Re: [kvm-devel] kvm slides at NLUUG?

2007-05-23 Thread Avi Kivity
Jun Koi wrote: > Hi Avi, > > Could you make your slides/paper at NLUGG available? > (http://www.nluug.nl/events/vj07/) > The paper should be available as part of the Proceedings. I looked and couldn't find it on the site, maybe you can drop them an email and ask if it is available online. --

Re: [kvm-devel] kvm-22 and Vista support

2007-05-23 Thread Avi Kivity
Jorge Lucángeli Obes wrote: > I had some time on my hands lately and tried to debug this a little. I > found that there's actually something showing in dmesg: > > [ 3872.221039] emulation failed but !mmio_needed? rip 9a12 0f 09 66 25 > > Does that help? I'm running kvm-24 now, but the exception sti

Re: [kvm-devel] kvm slides at NLUUG?

2007-05-23 Thread Avi Kivity
Jun Koi wrote: > On 5/23/07, Lucas Bonnet <[EMAIL PROTECTED]> wrote: > >> Avi Kivity a écrit : >> >>> The paper should be available as part of the Proceedings. I looked and >>> couldn't find it on the site, maybe you can drop them

[kvm-devel] [ANNOUNCE] kvm-25 release

2007-05-23 Thread Avi Kivity
Regular readers of this column will not be surprised to hear that kvm-25 is much faster than earlier versions. Changes since kvm-24: - massive performance increase (Eddie Dong) - regenerate bios from latest bochs sources, hopefully fixing a regression with some guests - some testsuite work (Anthon

Re: [kvm-devel] qemu/kvm seems to take ALSA all for itself?

2007-05-23 Thread Avi Kivity
David Abrahams wrote: >>> "For ALSA 1.0.9rc2 and higher you don't need to setup dmix. Dmix is >>> enabled as default for soundcards which don't support hw mixing." >>> >>> I've found this to be the case on my laptop, where I use: >>> >>> export QEMU_AUDIO_DRV=alsa >>> export QEMU_AUDIO_DAC_FIXED_F

Re: [kvm-devel] [ANNOUNCE] kvm-25 release

2007-05-24 Thread Avi Kivity
Laurent Vivier wrote: > Compilation fails on my system (Debian etch on x86_64) > > gcc -I /home/vivierl/kvm-25/kernel/include -MMD -MF test/.bootstrap.d -g > -fomit-frame-pointer -Wall -m64 -fno-stack-protector -std=gnu99 > -ffreestanding -c -nostdlib -o test/bootstrap.o test/bootstrap.S > test/

Re: [kvm-devel] [PATCH 10/10] KVM: Adds support for halting in the kernel

2007-05-24 Thread Avi Kivity
Gregory Haskins wrote: > Halting in userspace requires a relatively cumbersome mechanism to signal the > halted VCPU. Implementing halt in kernel should be relatively straight > forward and it eliminates the need for the signaling > > /* > + * The vCPU has executed a HLT instruction with in-kerne

Re: [kvm-devel] [PATCH 00/10] in-kernel APIC v7 (kernel side)

2007-05-24 Thread Avi Kivity
Gregory Haskins wrote: > I am pleased to announce v7 of the patch series. This includes v6 with the > following changes: > Doesn't apply. Can you rebase to HEAD? > 1) Minor bug fixes/cleanup > 2) Added better support for level-sensitive interrupts > 3) Now officially includes in-kernel HLT s

Re: [kvm-devel] [PATCH 00/10] in-kernel APIC v7 (kernel side)

2007-05-24 Thread Avi Kivity
Li, Xin B wrote: > So you will check in the patch soon? > Yes. Still need to test AMD and some odd guests. > Really a good news since this will be the base for enabling SMP. > SMP, faster paravirt drivers, TPR shadow on vmx... -- error compiling committee.c: too many arguments to functi

Re: [kvm-devel] KVM Windows keyboard layout

2007-05-24 Thread Avi Kivity
Uwe Kubosch wrote: > Hi all! > > KVM is great! > > I am successfully running Windows Xp on KVM-24 in Fedora 7 test 4. I > have even connected a CDROM drive, which was a bit of hassle. > > One problem I have is keyboard layout. I need a Norwegian keyboard > layout to work, and I have installed thi

Re: [kvm-devel] KVM Windows keyboard layout

2007-05-24 Thread Avi Kivity
Uwe Kubosch wrote: > On Thu, 2007-05-24 at 12:55 +0300, Avi Kivity wrote: > >>> One problem I have is keyboard layout. I need a Norwegian keyboard >>> layout to work, and I have installed this in the Linux host and in the >>> Windows XP guest, but no Norwegia

Re: [kvm-devel] KVM Windows keyboard layout

2007-05-24 Thread Avi Kivity
Uwe Kubosch wrote: > If I skip the virt-manager, and start from the command line, could you > give me an example for using sdl? Something like > > qemu-kvm > > qemu-kvm is the right program to use, right? > > > qemu-kvm -m 1024 For virtual machine with 1024MB RAM. -- error compiling comm

[kvm-devel] [PATCH 2/7] HOTPLUG: Adapt cpuset hotplug callback to CPU_DYING

2007-05-24 Thread Avi Kivity
CPU_DYING is called in atomic context, so don't try to take any locks. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- kernel/cpuset.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/kernel/cpuset.c b/kernel/cpuset.c index f57854b..d4ab1c6 100644 -

[kvm-devel] [PATCH 3/7] HOTPLUG: Adapt thermal throttle to CPU_DYING

2007-05-24 Thread Avi Kivity
CPU_DYING is notified in atomic context, so no taking mutexes here. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- arch/i386/kernel/cpu/mcheck/therm_throt.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/i386/kernel/cpu/mcheck/therm_throt.c b/arc

[kvm-devel] [PATCH 5/7] KVM: Keep track of which cpus have virtualization enabled

2007-05-24 Thread Avi Kivity
By keeping track of which cpus have virtualization enabled, we prevent double-enable or double-disable during hotplug, which is a very fatal oops. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm_main.c | 47 +++ 1 files chang

[kvm-devel] [PATCH 6/7] KVM: Tune hotplug/suspend IPIs

2007-05-24 Thread Avi Kivity
The hotplug IPIs can be called from the cpu on which we are currently running on, so use on_one_cpu(). Similarly, drop on_each_cpu() for the suspend/resume callbacks, as we're in atomic context here and only one cpu is up anyway. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> ---

[kvm-devel] [PATCH 0/7] KVM: Suspend and cpu hotplug fixes

2007-05-24 Thread Avi Kivity
The following patchset makes kvm more robust wrt cpu hotunplug, and makes suspend-to-ram actually work. Suspend-to-disk benefits from the cpu hotunplug improvements as well. The major issue is that KVM wants to disable the virtualization extensions at a point in time when no user processes are sc

[kvm-devel] [PATCH 1/7] HOTPLUG: Add CPU_DYING notifier

2007-05-24 Thread Avi Kivity
on is called in atomic context on the doomed cpu. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- include/linux/notifier.h |3 +++ kernel/cpu.c | 16 ++-- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/include/linux/notifier.h b/include/linux

[kvm-devel] [PATCH 7/7] KVM: Use CPU_DYING for disabling virtualization

2007-05-24 Thread Avi Kivity
Only at the CPU_DYING stage can we be sure that no user process will be scheduled onto the cpu and oops when trying to use virtualization extensions. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm_main.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff

[kvm-devel] [PATCH 4/7] SMP: Implement on_one_cpu()

2007-05-24 Thread Avi Kivity
This defines on_one_cpu() which is similar to smp_call_function_single() except that it works if cpu happens to be the current cpu. Can also be seen as a complement to on_each_cpu() (which also doesn't treat the current cpu specially). Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> -

Re: [kvm-devel] [PATCH 10/10] KVM: Adds support for halting in the kernel

2007-05-24 Thread Avi Kivity
Gregory Haskins wrote: > > >> We have a specialized signal mask for the kernel, and it is already in >> effect here. See KVM_SET_SIGNAL_MASK. >> >> > > KVM_SET_SIGNAL_MASK is precisely what I was trying to counteract ;). > Basically I was thinking that userspace could have set some a

Re: [kvm-devel] [PATCH 10/10] KVM: Adds support for halting in the kernel

2007-05-24 Thread Avi Kivity
Gregory Haskins wrote: > So as long as any appropriate signal will kick the HLT out of this > wait-queue, we are ok. It sounds like I can just get rid of the sigprocmask > all together and this will work? Yes. -- error compiling committee.c: too many arguments to function

Re: [kvm-devel] [PATCH 0/7] KVM: Suspend and cpu hotplug fixes

2007-05-24 Thread Avi Kivity
Avi Kivity wrote: > The following patchset makes kvm more robust wrt cpu hotunplug, and > makes suspend-to-ram actually work. Suspend-to-disk benefits from > the cpu hotunplug improvements as well. > > Here's the patchset diffstat in case anyone's interested: ar

Re: [kvm-devel] [PATCH 4/7] SMP: Implement on_one_cpu()

2007-05-24 Thread Avi Kivity
Heiko Carstens wrote: > On Thu, May 24, 2007 at 03:10:12PM +0300, Avi Kivity wrote: > >> This defines on_one_cpu() which is similar to smp_call_function_single() >> except that it works if cpu happens to be the current cpu. Can also be >> seen as a complement to o

Re: [kvm-devel] [PATCH 4/7] SMP: Implement on_one_cpu()

2007-05-24 Thread Avi Kivity
Roland Dreier wrote: > I don't see any documented restrictions about preemption being > disabled when this function is called, but... > > > +int on_one_cpu(int cpu, void (*func) (void *info), void *info, > > + int retry, int wait) > > +{ > > + int ret; > > + int this_cpu; > > + > >

Re: [kvm-devel] [PATCH 0/9] in-kernel APIC v8 (kernel side)

2007-05-24 Thread Avi Kivity
Gregory Haskins wrote: > Passes the usual tests, and offers an 11% speedup. There is another > enhancement not included here (coming shortly) which exposes another 12% > speedup over this as well. Stay tuned > > This fails on amd, locks up completely. Bisecting now. lapic.c needs a #include

Re: [kvm-devel] [PATCH 0/9] in-kernel APIC v8 (kernel side)

2007-05-24 Thread Avi Kivity
Avi Kivity wrote: > Gregory Haskins wrote: >> Passes the usual tests, and offers an 11% speedup. There is another >> enhancement not included here (coming shortly) which exposes another 12% >> speedup over this as well. Stay tuned >> >> > This fails on amd,

Re: [kvm-devel] [PATCH 0/9] in-kernel APIC v8 (kernel side)

2007-05-24 Thread Avi Kivity
Gregory Haskins wrote: >>>> On Thu, May 24, 2007 at 10:58 AM, in message <[EMAIL PROTECTED]>, >>>> > Avi Kivity <[EMAIL PROTECTED]> wrote: > >> Avi Kivity wrote: >> >>> Gregory Haskins wrote: >>> &

Re: [kvm-devel] [PATCH 0/7] KVM: Suspend and cpu hotplug fixes

2007-05-25 Thread Avi Kivity
Shaohua Li wrote: > On Thu, 2007-05-24 at 20:10 +0800, Avi Kivity wrote: > >> The following patchset makes kvm more robust wrt cpu hotunplug, and >> makes suspend-to-ram actually work. Suspend-to-disk benefits from >> the cpu hotunplug improvements as well. >>

Re: [kvm-devel] [PATCH 0/7] KVM: Suspend and cpu hotplug fixes

2007-05-27 Thread Avi Kivity
Avi Kivity wrote: > I estimate that that take_cpu_down will run for about a millisecond if > there are a few hundred vcpus which have last run on the dying cpu (and > that's an extreme case, which is not expected in normal operation). I measured vmclear time on an uncached vmcs (

[kvm-devel] [ANNOUNCE] kvm-26 release

2007-05-27 Thread Avi Kivity
This is a minor release for compile fixes while we hash out the apic-on-amd problems. Changes since kvm-25: - implement wbinvd emulation, triggered by Windows Vista - compile fixes (Markus Rechberger, me) Notes: If you use the modules from kvm-26, you can use any version of Linux from 2.6.9 u

Re: [kvm-devel] [PATCH 4/9] KVM: Adds ability to preempt an executing VCPU

2007-05-27 Thread Avi Kivity
Gregory Haskins wrote: > static void kvm_vcpu_irqsink_init(struct kvm_vcpu *vcpu) > diff --git a/drivers/kvm/svm.c b/drivers/kvm/svm.c > index a9d917a..c79bfc0 100644 > --- a/drivers/kvm/svm.c > +++ b/drivers/kvm/svm.c > @@ -1544,9 +1544,43 @@ static int svm_vcpu_run(struct kvm_vcpu *vcpu, struct

Re: [kvm-devel] Kernel panic when loading kvm-amd

2007-05-29 Thread Avi Kivity
Anthony Liguori wrote: > Pär Andersson wrote: > >> Hi. >> >> I am getting a kernel panic when loading the kvm-amd module. I have talked a >> little about this with aliguori on IRC and according to him the panic occurs >> when KVM enables EFER.SVME. >> >> > > I find this very odd. Sett

Re: [kvm-devel] guest PTE write emulation

2007-05-29 Thread Avi Kivity
Dong, Eddie wrote: > Not sure if we should use PT_USER_MASK | PT_WRITABLE_MASK here. > > diff --git a/drivers/kvm/paging_tmpl.h b/drivers/kvm/paging_tmpl.h > index 6dd0da9..183d4ca 100644 > --- a/drivers/kvm/paging_tmpl.h > +++ b/drivers/kvm/paging_tmpl.h > @@ -213,7 +213,7 @@ static void FNAME(upd

Re: [kvm-devel] guest PTE write emulation

2007-05-29 Thread Avi Kivity
Dong, Eddie wrote: > BTW, in kvm_mmu_pte_write, I feel a little bit stranger for following > code: > > > >>level = page->role.level; >>npte = 1; >>if (page->role.glevels == PT32_ROOT_LEVEL) { >>page_offset <<= 1; /* 32-

Re: [kvm-devel] kvm-26 support disabled error

2007-05-29 Thread Avi Kivity
(अमेय) Ameya (पाळंदे) Palande wrote: > Hi, > > Sorry for the previous error report. > > Actually I upgraded ubuntu kernel and forgot to remove > default kvm modules which come with kernel. > > Now its working properly. > > But it seems to be a problem with 2 different installation > locations for k

Re: [kvm-devel] State of current pv_ops backend for KVM?

2007-05-29 Thread Avi Kivity
Anthony Liguori wrote: > Howdy, > > Does anyone know what the state of a pv_ops backend for KVM is? I > know Ingo has an implementation that implements CR3 caching but I > don't see any branches in Avi's git tree. > > Perhaps we should try for a simple pv_ops backend for 2.6.23 seeing as > how

[kvm-devel] [GIT PULL] KVM cpu hotplug fixes

2007-05-29 Thread Avi Kivity
about a cpu going away at a point in time where it's still alive, but not running any user processes. Such a notification does not exist today, so the patchset adds it as a new CPU_DYING notification. The patchset is against 2.6.22-rc3. Shortlog: Avi Kivity (7): HOTPLUG: Add CPU_

Re: [kvm-devel] State of current pv_ops backend for KVM?

2007-05-29 Thread Avi Kivity
Anthony Liguori wrote: > Avi Kivity wrote: >> Anthony Liguori wrote: >>> Howdy, >>> >>> Does anyone know what the state of a pv_ops backend for KVM is? I >>> know Ingo has an implementation that implements CR3 caching but I >>> don't se

Re: [kvm-devel] suspend to ram problem

2007-05-29 Thread Avi Kivity
(अमेय) Ameya (पाळंदे) Palande wrote: > Hi, > > When we can expect suspend to ram will work ? > Kernel I am using is : 2.6.20-16-generic > Kvm - 26 > Intel VT T2300 on dell inspiron e1505 / 6400 laptop. > Suspend to ram works on at least one laptop. If it doesn't work for you, try the patch in

Re: [kvm-devel] State of current pv_ops backend for KVM?

2007-05-29 Thread Avi Kivity
Anthony Liguori wrote: >>> >>> That's a bit more ambitious than I was thinking. I would be very >>> happy with a pv timer, interrupt controller, and some basic CPU >>> optimizations. I'm still not convinced the perf benefits of direct >>> paging justify the annoyances that come with it (guests

Re: [kvm-devel] Kernel panic when loading kvm-amd

2007-05-29 Thread Avi Kivity
Huang2, Wei wrote: > SVM looks available on your machine. If possible, could you provide dmidecode > information (type "dmidecode") for further verification? I know that some > vendors disabled SVM feature in BIOS last year. But this was pretty rare. > Maybe you can check whether BIOS has an opt

Re: [kvm-devel] SMP support of MMU

2007-05-29 Thread Avi Kivity
Dong, Eddie wrote: > Avi: > I noticed the current MMU data structure is defined as per VCPU > such as: > > struct kvm_vcpu { > . > struct list_head free_pages; > struct kvm_mmu_page page_header_buf[KVM_NUM_MMU_PAGES]; > . > } > > This is a hot topics

Re: [kvm-devel] Kernel panic when loading kvm-amd

2007-05-29 Thread Avi Kivity
Huang2, Wei wrote: > As far as I know, there is no special way to detect BIOS-disabled SVM. BIOS > should always trap #GP on writing SVME bit. So the way you suggested should > work. > > Okay. How does the bios disable svm? -- Do not meddle in the internals of kernels, for they are subtle

Re: [kvm-devel] State of current pv_ops backend for KVM?

2007-05-29 Thread Avi Kivity
Rusty Russell wrote: > On Tue, 2007-05-29 at 17:00 +0300, Avi Kivity wrote: > >> Anthony Liguori wrote: >> >>> Avi Kivity wrote: >>> >>>> I think we should aim for a full direct paging implementation, where >>>> the cr3

Re: [kvm-devel] guest PTE write emulation

2007-05-30 Thread Avi Kivity
Dong, Eddie wrote: > Avi Kivity wrote: > >> On a pte update, npte will always be 1. On a pde update, we won't do >> anything in mmu_pte_write_new_pte because it doesn't handle >> pdes. If we >> extend it to handle pdes, then we need either to modify

Re: [kvm-devel] [PATCH 1/3] KVM paravirt_ops infrastructure

2007-05-31 Thread Avi Kivity
Rusty Russell wrote: > Two versions, size *and* ret? This seems like overkill... > > I think we ought to move away from version numbers and use feature availability flags instead. >> + if (rc) { >> + printk(KERN_INFO "paravirt KVM unavailable\n"); >> > > Double-print

Re: [kvm-devel] [PATCH 3/3] Eliminate read_cr3 on TLB flush

2007-05-31 Thread Avi Kivity
Anthony Liguori wrote: >>> >>> >> For KVM, it should be okay as well. But we can replace two CR4 accesses >> with just one hypercall. >> >> > > I was thinking the same thing :-) > > I was actually thinking about adding a hypercall to set/clear a bit in a > control register. Th

Re: [kvm-devel] pre-cleanup for SMP: move mmu cache to be VM bais

2007-05-31 Thread Avi Kivity
Dong, Eddie wrote: > Move per VCPU mmu_memory_cache to be VM basis. > > Your opnion? > > Eddie > > diff --git a/drivers/kvm/kvm.h b/drivers/kvm/kvm.h > index 0632d0b..77989b4 100644 > --- a/drivers/kvm/kvm.h > +++ b/drivers/kvm/kvm.h > @@ -300,11 +300,6 @@ struct kvm_vcpu { > > struct kvm_

Re: [kvm-devel] pre-cleanup for SMP: move mmu cache to be VM bais

2007-05-31 Thread Avi Kivity
Dong, Eddie wrote: > Yes, We will provide other pathes for real SMP support. This one is just > for pre-movement. > BTW, at bigening, our SMP work may start with big lock (only one VCPU > get accessing to shadow PT), and then gradually move to fine lock, and > we expect to start SMP debug next week

Re: [kvm-devel] CPUID emulation

2007-05-31 Thread Avi Kivity
Stephane Eranian wrote: > Hello, > > Looking at kvm-26, it seems that the CPUID values as seen by the guest OS > are still hardcoded for i386/x86-64 at least. > > For performance counter virtualization, the guest needs to see the *actual* > family/model information in order to correctly program the

Re: [kvm-devel] CPUID emulation

2007-05-31 Thread Avi Kivity
Stephane Eranian wrote: >> >> The main issue is migration (and save/restore). If you migrate to a >> host with fewer capabilities, applications may fail when they use >> unavailable instructions that they successfully detected earlier. >> >> > In the case of heterogeneous migration, clearly

Re: [kvm-devel] CPUID emulation

2007-05-31 Thread Avi Kivity
Stephane Eranian wrote: >> >> If the guest cpuid is set to a least common denominator, it should work. >> >> > There is no common denominator between a P4 and Intel Core 2 Duo for the > performance counters. So you cannot simply use a generic member of family > 15 to fake the guest cpuid runnn

Re: [kvm-devel] [PATCH RFC 3/3] virtio infrastructure: example block driver

2007-05-31 Thread Avi Kivity
Carsten Otte wrote: > Troy Benjegerdes wrote: > >> This kind of a claim needs some benchmark data to document it. >> > We've implemented both for our vdisk driver on 390. At least on our > platform, merging in the host is preferable because vmenter/vmexit is > very fast and we would merge

Re: [kvm-devel] Mac-Address uniqueness

2007-05-31 Thread Avi Kivity
H. Peter Anvin wrote: > Axel Kittenberger wrote: > >> Unfortunally all machines detect the same ethernet address >> '52:54:00:12:34:56'. Which you can guess what i means, networking comes >> and goes whatever machine last the ethernet address got hold of from the >> gateway. I tried specifing

[kvm-devel] [GIT PULL][RESEND] KVM cpu hotplug fixes

2007-05-31 Thread Avi Kivity
about a cpu going away at a point in time where it's still alive, but not running any user processes. Such a notification does not exist today, so the patchset adds it as a new CPU_DYING notification. The patchset is against 2.6.22-rc3. Shortlog: Avi Kivity (7): HOTPLUG: Add CPU_

Re: [kvm-devel] compile error

2007-05-31 Thread Avi Kivity
Zhao, Yunfeng wrote: > > I met an error when i build latest KVM on rhel5. > > Seems asm/cmpxchg.h is not in the kernel before 2.6.22. > > How can I fix the issue? > > > Add a kernel/include/linux/asm/cmpxchg.h, which defines set_64bit() for both i386 and x86_64. -- Do not meddle in the inter

Re: [kvm-devel] [GIT PULL][RESEND] KVM cpu hotplug fixes

2007-06-01 Thread Avi Kivity
Linus Torvalds wrote: > Don't send me pull requests like this. And absolutely do NOT send them as > resends. I just get grumpy. > > If all the added code had been KVM-only, I might not care. But when the > bulk of the code touches core files, you had better explain why this is so > important th

Re: [kvm-devel] [PATCH RFC 1/3] virtio infrastructure

2007-06-01 Thread Avi Kivity
Rusty Russell wrote: > This attempts to implement a "virtual I/O" layer which should allow > common drivers to be efficiently used across most virtual I/O > mechanisms. It will no-doubt need further enhancement. > > The details of probing the device are left to hypervisor-specific > code: it simpl

Re: [kvm-devel] [GIT PULL][RESEND] KVM cpu hotplug fixes

2007-06-02 Thread Avi Kivity
Jun Koi wrote: > Hi Avi, > > On 6/2/07, Avi Kivity <[EMAIL PROTECTED]> wrote: >> Linus Torvalds wrote: >> > Don't send me pull requests like this. And absolutely do NOT send >> them as >> > resends. I just get grumpy. >> > >> >

Re: [kvm-devel] [PATCH RFC 1/3] virtio infrastructure

2007-06-02 Thread Avi Kivity
Rusty Russell wrote: > On Sat, 2007-06-02 at 09:30 +0300, Avi Kivity wrote: > >> Rusty Russell wrote: >> >>> + * virtio_ops - virtio abstraction layer >>> + * @add_outbuf: prepare to send data to the other end: >>> + * vdev: the virtio_devic

Re: [kvm-devel] [PATCH] make some functions/vars static

2007-06-03 Thread Avi Kivity
Nguyen Anh Quynh wrote: > This patch turns some local functions and variables in hypercall.c > static. > > Signed-off-by: Nguyen Anh Quynh <[EMAIL PROTECTED]> Applied, thanks. Please give patch attachments real names; and if you end them with ".patch", I think gmail will add the magic necessary

Re: [kvm-devel] [PATCH] Use symbol insted of number

2007-06-03 Thread Avi Kivity
Nguyen Anh Quynh wrote: > This patch makes hypercall.c use symbol instead of number with > hypercall-ioport-size. Applied, thanks. -- error compiling committee.c: too many arguments to function - This SF.net email is spon

<    8   9   10   11   12   13   14   15   >