Re: Glyphs for Kievan Notation (issue 4951062)

2011-09-21 Thread Janek Warchoł
2011/9/21 Graham Percival gra...@percival-music.ca: On Tue, Sep 20, 2011 at 10:27:02PM -0400, Aleksandr Andreev wrote: /home/sasha/lilypond-git/build/out/lybook-db/snippet-names-5304161007275961614.ly Does anyone have any idea what could be going on? What's in the above file?  It'll probably

Re: Glyphs for Kievan Notation (issue 4951062)

2011-09-21 Thread m...@apollinemike.com
On Sep 21, 2011, at 8:02 AM, Janek Warchoł wrote: 2011/9/21 Graham Percival gra...@percival-music.ca: On Tue, Sep 20, 2011 at 10:27:02PM -0400, Aleksandr Andreev wrote: /home/sasha/lilypond-git/build/out/lybook-db/snippet-names-5304161007275961614.ly Does anyone have any idea what could be

Re: GOP-PROP 10: scheme indentation

2011-09-21 Thread Jan Nieuwenhuizen
David Kastrup writes: The main problem is that it is catastrophic with regard to rebasing, and still rather disruptive with regard to merging. +1 Personally, I'd prefer it if we focused on solving rather than creating real problems. +1 Also, I'm not going to start the C++ indentation

PATCH: Doc: NR Clarify finer point of repeat unfold

2011-09-21 Thread Peekay Ex
http://codereview.appspot.com/5075047/ This is for tracker issue 1801. Explain as an example, that \repeat unfold 2 {music expression} is not always the same as writing out the music expression twice - especially in a \relative context -- -- James

Re: Implement optional music function arguments (issue 5023044)

2011-09-21 Thread David Kastrup
carl.d.soren...@gmail.com writes: I'd be lying if I said I understood everything going on here, but I think I get the gist. Same here. I like moving this way! I like the approach of simplifying things. I like having optional predicates, and optional predicates with defaults. I will

Re: Glyphs for Kievan Notation (issue 4951062)

2011-09-21 Thread Peekay Ex
Hello, 2011/9/21 m...@apollinemike.com m...@apollinemike.com: On Sep 21, 2011, at 8:02 AM, Janek Warchoł wrote: 2011/9/21 Graham Percival gra...@percival-music.ca: On Tue, Sep 20, 2011 at 10:27:02PM -0400, Aleksandr Andreev wrote:

Re: PATCH: Countdown to 20110921

2011-09-21 Thread David Kastrup
Graham Percival gra...@percival-music.ca writes: On Mon, Sep 19, 2011 at 09:29:32PM -0600, Colin Campbell wrote: For 22:00 MDT Wednesday September 21, and *far* too early for an Autumnal equinox! As an experiment, I have changed all (hopefully?) of these issues from Patch-review to

Re: PATCH: Countdown to 20110921

2011-09-21 Thread Janek Warchoł
2011/9/21 David Kastrup d...@gnu.org: Graham Percival gra...@percival-music.ca writes: On Mon, Sep 19, 2011 at 09:29:32PM -0600, Colin Campbell wrote:    For 22:00 MDT Wednesday September 21, and *far* too early for an Autumnal    equinox! As an experiment, I have changed all (hopefully?)

Re: Glyphs for Kievan Notation (issue 4951062)

2011-09-21 Thread Janek Warchoł
2011/9/21 Peekay Ex pkx1...@gmail.com: Hello, 2011/9/21 m...@apollinemike.com m...@apollinemike.com: On Sep 21, 2011, at 8:02 AM, Janek Warchoł wrote: Out of curiosity i searched for snippet-names-5304161007275961614.ly file in build/out/lybook-db/ and... it doesn't exist.  In fact i

Doc: add a note about \relative f to notation (issue 1909) (issue 5096046)

2011-09-21 Thread janek . lilypond
Reviewers: , Message: http://lists.gnu.org/archive/html/lilypond-devel/2011-09/msg00331.html http://code.google.com/p/lilypond/issues/detail?id=1909 Description: Doc: add a note about \relative f to notation Please review this at http://codereview.appspot.com/5096046/ Affected files: M

Doc: NR Clarify finer point of repeat unfold (issue 5075047)

2011-09-21 Thread janek . lilypond
LGTM. From what i see, the surprise in this behaviour comes from two meanings of music expression - it can be understood as a piece of ly input or a piece of music. Shall we write a sentence about this difference? I.e. Using \repeat unfold is equal to writing out a fragment of music several

Re: Doc: add a note about \relative f to notation (issue 1909) (issue 5096046)

2011-09-21 Thread dak
http://codereview.appspot.com/5096046/diff/1/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): http://codereview.appspot.com/5096046/diff/1/Documentation/notation/pitches.itely#newcode258 Documentation/notation/pitches.itely:258: If you carefully consider

Re: PATCH: Countdown to 20110921

2011-09-21 Thread David Kastrup
Janek Warchoł janek.lilyp...@gmail.com writes: 2011/9/21 David Kastrup d...@gnu.org: Graham Percival gra...@percival-music.ca writes: On Mon, Sep 19, 2011 at 09:29:32PM -0600, Colin Campbell wrote:    For 22:00 MDT Wednesday September 21, and *far* too early for an Autumnal    equinox!

Re: Doc: NR Clarify finer point of repeat unfold (issue 5075047)

2011-09-21 Thread David Kastrup
janek.lilyp...@gmail.com writes: LGTM. From what i see, the surprise in this behaviour comes from two meanings of music expression - it can be understood as a piece of ly input or a piece of music. Shall we write a sentence about this difference? I.e. Using \repeat unfold is equal to

Re: do we want special versions of the accidentals for use with text?

2011-09-21 Thread Werner LEMBERG
For figured bass, the situation is different: Here we use LilyPond's digit font, which is completely under our control, and having accidentals fitting those digits better is a good thing. I will prepare shorter versions of accidentals. Thanks! Would you help me with writing code that

Re: do we want special versions of the accidentals for use with text?

2011-09-21 Thread m...@apollinemike.com
On Sep 21, 2011, at 10:05 AM, Werner LEMBERG wrote: For figured bass, the situation is different: Here we use LilyPond's digit font, which is completely under our control, and having accidentals fitting those digits better is a good thing. I will prepare shorter versions of accidentals.

Rietveld workflow problems

2011-09-21 Thread David Kastrup
Just wanted to throw this observation out: the current work on optional arguments is one area where working with Rietveld is getting really strained. The reason is that Rietveld just supports discussing and improving a single patch/commit. The current patch series consists of one infrastructure

Re: Doc: NR Clarify finer point of repeat unfold (issue 5075047)

2011-09-21 Thread Janek Warchoł
2011/9/21 David Kastrup d...@gnu.org: janek.lilyp...@gmail.com writes: LGTM. From what i see, the surprise in this behaviour comes from two meanings of music expression - it can be understood as a piece of ly input or a piece of music.  Shall we write a sentence about this difference? I.e.

Re: Rietveld workflow problems

2011-09-21 Thread m...@apollinemike.com
On Sep 21, 2011, at 10:27 AM, David Kastrup wrote: Just wanted to throw this observation out: the current work on optional arguments is one area where working with Rietveld is getting really strained. The reason is that Rietveld just supports discussing and improving a single patch/commit.

Doc: Added note to CG about disable-optimizing (issue 5081048)

2011-09-21 Thread tdanielsmusic
LGTM, with one comment http://codereview.appspot.com/5081048/diff/1/Documentation/contributor/regressions.itexi File Documentation/contributor/regressions.itexi (right): http://codereview.appspot.com/5081048/diff/1/Documentation/contributor/regressions.itexi#newcode143

Re: engraver question: how to define an array to store events?

2011-09-21 Thread Marc Hohl
Am 20.09.2011 08:59, schrieb Marc Hohl: Hello list, while trying to get more insight into the engraver stuff, I encountered a problem. I hope I can explain it: I need some kind of a array of vectors: Nevermind - smells like the wrong way to go ;-) I think I found a more generic solution.

Re: Rietveld workflow problems

2011-09-21 Thread David Kastrup
m...@apollinemike.com m...@apollinemike.com writes: On Sep 21, 2011, at 10:27 AM, David Kastrup wrote: Just wanted to throw this observation out: the current work on optional arguments is one area where working with Rietveld is getting really strained. The reason is that Rietveld just

Re: Doc: Added note to CG about disable-optimizing (issue 5081048)

2011-09-21 Thread tdanielsmusic
On 2011/09/21 08:43:09, Trevor Daniels wrote: But if you leave the configure option in it should be ./configure. Ah, that was a bit simplistic. In-tree and out-of-tree builds are different wrt configure, I think. http://codereview.appspot.com/5081048/

Re: bookOutputName broken

2011-09-21 Thread David Kastrup
Neil Puttock n.putt...@gmail.com writes: On 20 September 2011 21:50, Benkő Pál benko@gmail.com wrote: I don't know what to do, could you help me? The attached patch works for me (haven't run make check on it though). I have taken the liberty of pushing it after looking it through (I

Re: Doc: Added note to CG about disable-optimizing (issue 5081048)

2011-09-21 Thread Peekay Ex
On Wed, Sep 21, 2011 at 10:01 AM, tdanielsmu...@googlemail.com wrote: On 2011/09/21 08:43:09, Trevor Daniels wrote: But if you leave the configure option in it should be ./configure. Ah, that was a bit simplistic.  In-tree and out-of-tree builds are different wrt configure, I think.

Re: Rietveld workflow problems

2011-09-21 Thread Peekay Ex
Hello, On Wed, Sep 21, 2011 at 9:35 AM, m...@apollinemike.com m...@apollinemike.com wrote: For what it's worth, I run into the same problem from time to time - I recently sent an e-mail to the list about a 1-line patch to fix kneed beams that I needed to apply for other work. So, and this

Re: Doc: add a note about \relative f to notation (issue 1909) (issue 5096046)

2011-09-21 Thread pkx166h
Suggestion to text. http://codereview.appspot.com/5096046/diff/1/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): http://codereview.appspot.com/5096046/diff/1/Documentation/notation/pitches.itely#newcode263 Documentation/notation/pitches.itely:263: Janek,

Re: Doc: add a note about \relative f to notation (issue 1909) (issue 5096046)

2011-09-21 Thread David Kastrup
pkx1...@gmail.com writes: Suggestion to text. http://codereview.appspot.com/5096046/diff/1/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): http://codereview.appspot.com/5096046/diff/1/Documentation/notation/pitches.itely#newcode263

Re: Rietveld workflow problems

2011-09-21 Thread David Kastrup
Peekay Ex pkx1...@gmail.com writes: Hello, On Wed, Sep 21, 2011 at 9:35 AM, m...@apollinemike.com m...@apollinemike.com wrote: For what it's worth, I run into the same problem from time to time - I recently sent an e-mail to the list about a 1-line patch to fix kneed beams that I needed

Re: Rietveld workflow problems

2011-09-21 Thread Peekay Ex
Hello, On Wed, Sep 21, 2011 at 11:45 AM, David Kastrup d...@gnu.org wrote: Peekay Ex pkx1...@gmail.com writes: Hello, On Wed, Sep 21, 2011 at 9:35 AM, m...@apollinemike.com m...@apollinemike.com wrote: For what it's worth, I run into the same problem from time to time - I recently sent

Re: Glyphs for Kievan Notation (issue 4951062)

2011-09-21 Thread Reinhold Kainhofer
Am Wednesday, 21. September 2011, 04:27:02 schrieb Aleksandr Andreev: Unfortunately, I cannot get my documentation to build. As was suggested earlier, I nuked my build folder and redid everything from the beginning (configure.sh, make all, touch, make doc). However, make doc errors out with

Re: Rietveld workflow problems

2011-09-21 Thread m...@apollinemike.com
On Sep 21, 2011, at 1:00 PM, Peekay Ex wrote: Hello, On Wed, Sep 21, 2011 at 11:45 AM, David Kastrup d...@gnu.org wrote: Peekay Ex pkx1...@gmail.com writes: Hello, On Wed, Sep 21, 2011 at 9:35 AM, m...@apollinemike.com m...@apollinemike.com wrote: For what it's worth, I run into

Re: Rietveld workflow problems

2011-09-21 Thread Reinhold Kainhofer
Am Wednesday, 21. September 2011, 12:45:17 schrieb David Kastrup: Because it doesn't make sense to combine unrelated patches in that manner. You can't find them in the history then, and if the large patch gets applied or reverted, the independent small patch has to go along. To submit a

Re: Rietveld workflow problems

2011-09-21 Thread David Kastrup
Reinhold Kainhofer reinh...@kainhofer.com writes: Am Wednesday, 21. September 2011, 12:45:17 schrieb David Kastrup: Because it doesn't make sense to combine unrelated patches in that manner. You can't find them in the history then, and if the large patch gets applied or reverted, the

Re: Glyphs for Kievan Notation (issue 4951062)

2011-09-21 Thread Aleksandr Andreev
What's in the above file? It'll probably contain 5-10 other filename Yes. All the different snippets seem to have something to do with percussion. Aleks ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Rietveld workflow problems

2011-09-21 Thread Janek Warchoł
2011/9/21 David Kastrup d...@gnu.org: Reinhold Kainhofer reinh...@kainhofer.com writes: Am Wednesday, 21. September 2011, 12:45:17 schrieb David Kastrup: Because it doesn't make sense to combine unrelated patches in that manner.  You can't find them in the history then, and if the large patch

Re: Rietveld workflow problems

2011-09-21 Thread Reinhold Kainhofer
Am Wednesday, 21. September 2011, 10:52:37 schrieb David Kastrup: Perhaps it would be nice if we found a way to play with Gerrit, supposedly a git-based system similar to Rietveld. I looked at gerrit a while ago. If you want to take a look at it: http://server.kainhofer.com:8088/ Here is a

Re: Glyphs for Kievan Notation (issue 4951062)

2011-09-21 Thread Peekay Ex
Hello, On Wed, Sep 21, 2011 at 1:09 PM, Aleksandr Andreev aleksandr.andr...@gmail.com wrote: What's in the above file?  It'll probably contain 5-10 other filename Yes. All the different snippets seem to have something to do with percussion. Aleks

Re: Doc: Added note to CG about disable-optimizing (issue 5081048)

2011-09-21 Thread ColinPKCampbell
http://codereview.appspot.com/5081048/diff/1/Documentation/contributor/regressions.itexi File Documentation/contributor/regressions.itexi (right): http://codereview.appspot.com/5081048/diff/1/Documentation/contributor/regressions.itexi#newcode143 Documentation/contributor/regressions.itexi:143:

Re: Rietveld workflow problems

2011-09-21 Thread David Kastrup
Reinhold Kainhofer reinh...@kainhofer.com writes: Am Wednesday, 21. September 2011, 10:52:37 schrieb David Kastrup: Perhaps it would be nice if we found a way to play with Gerrit, supposedly a git-based system similar to Rietveld. I looked at gerrit a while ago. If you want to take a look at

Re: Rietveld workflow problems

2011-09-21 Thread Reinhold Kainhofer
Am Wednesday, 21. September 2011, 15:04:05 schrieb David Kastrup: Reinhold Kainhofer reinh...@kainhofer.com writes: Am Wednesday, 21. September 2011, 10:52:37 schrieb David Kastrup: Perhaps it would be nice if we found a way to play with Gerrit, supposedly a git-based system similar to

Re: Rietveld workflow problems

2011-09-21 Thread Janek Warchoł
2011/9/21 Reinhold Kainhofer reinh...@kainhofer.com: Am Wednesday, 21. September 2011, 15:04:05 schrieb David Kastrup: Reinhold Kainhofer reinh...@kainhofer.com writes: Am Wednesday, 21. September 2011, 10:52:37 schrieb David Kastrup: Perhaps it would be nice if we found a way to play with

Re: Rietveld workflow problems

2011-09-21 Thread David Kastrup
Reinhold Kainhofer reinh...@kainhofer.com writes: Am Wednesday, 21. September 2011, 15:04:05 schrieb David Kastrup: Reinhold Kainhofer reinh...@kainhofer.com writes: Am Wednesday, 21. September 2011, 10:52:37 schrieb David Kastrup: Perhaps it would be nice if we found a way to play with

Re: we need organizers

2011-09-21 Thread Phil Holmes
- Original Message - From: Janek Warchoł janek.lilyp...@gmail.com I might be willing to do this (since there are no other volunteers). Can i see this web app? Private email sent. -- Phil Holmes ___ lilypond-devel mailing list

Re: Glyphs for Kievan Notation (issue 4951062)

2011-09-21 Thread Phil Holmes
- Original Message - From: Janek Warchoł janek.lilyp...@gmail.com [snip] It's the first time i tried compiling docs, so i may have screwed something. Here's what i did: rm -r build sh autogen.sh --noconfigure mkdir -p build/ cd build/ ../configure make make doc

Re: Rietveld workflow problems

2011-09-21 Thread Janek Warchoł
2011/9/21 David Kastrup d...@gnu.org: Reinhold Kainhofer reinh...@kainhofer.com writes: In gerrit you really need to clean up your patches before you submit them for review. I typically have lots of small commits in a branch when I upload a patch to rietveld. git-cl will simply take the diff

CG updates

2011-09-21 Thread Phil Holmes
I've added a few updates to the CG concerning regression tests - it answers some FAQs that have come up about regtest comparison. I took the liberty of a direct push as 173c86fbf69abf076ec9c16147c1bf106c52b541 -- Phil Holmes ___ lilypond-devel

Re: Rietveld workflow problems

2011-09-21 Thread Carl Sorensen
On 9/21/11 6:48 AM, Reinhold Kainhofer reinh...@kainhofer.com wrote: Am Wednesday, 21. September 2011, 10:52:37 schrieb David Kastrup: Perhaps it would be nice if we found a way to play with Gerrit, supposedly a git-based system similar to Rietveld. I looked at gerrit a while ago. If you

Re: PATCH: Countdown to 20110921

2011-09-21 Thread Graham Percival
On Wed, Sep 21, 2011 at 08:31:51AM +0200, David Kastrup wrote: Graham Percival gra...@percival-music.ca writes: As an experiment, I have changed all (hopefully?) of these issues from Patch-review to Patch-countdown. You can see the complete list here:

Re: Rietveld workflow problems

2011-09-21 Thread Graham Percival
On Wed, Sep 21, 2011 at 10:39:01AM +0100, Peekay Ex wrote: So, and this is a genuine question, why do you need to make a tiny patch so that a (next) larger patch works. Why not include the tiny patch in your larger patch (if that makes sense)? Remember when you were first learning doc stuff,

Problem with make

2011-09-21 Thread Phil Holmes
On my fast build system, I can't currently get a successful make. Abort changes, pull, clean build directory. The build ends with: make[2]: Entering directory `/media/IntelSSD/lilypond/lilypond-git/build/Documentation/topdocs' LILYPOND_VERSION=2.15.13 [snip options] out/NEWS.tely

Re: New alist to replace special characters. (issue 4553056)

2011-09-21 Thread bordage . bertrand
New patch set. I hope this is ready for to be pushed, now. http://codereview.appspot.com/4553056/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Problem with make

2011-09-21 Thread Graham Percival
On Wed, Sep 21, 2011 at 05:13:00PM +0100, Phil Holmes wrote: On my fast build system, I can't currently get a successful make. Abort changes, pull, clean build directory. The build ends with: ... As you see, the problem is a missing AUTHORS.texi. The odd thing is that on previous make runs,

Re: Glyphs for Kievan Notation (issue 4951062)

2011-09-21 Thread Janek Warchoł
2011/9/21 Peekay Ex pkx1...@gmail.com: Hello, On Wed, Sep 21, 2011 at 1:09 PM, Aleksandr Andreev aleksandr.andr...@gmail.com wrote: What's in the above file?  It'll probably contain 5-10 other filename Yes. All the different snippets seem to have something to do with percussion. You did

Re: Rietveld workflow problems

2011-09-21 Thread Keith OHara
David Kastrup dak at gnu.org writes: The reason is that Rietveld just supports discussing and improving a single patch/commit. A counterexample http://codereview.appspot.com/4830064/ More complicated sets can benefit from Reitveld's ability to load patch sets relative to different

Implement define-event-function (issue 5083045)

2011-09-21 Thread dak
Reviewers: , Message: This allows defining music functions that can be used as directionless events, a frequently made request. It may be noted that the amount of code needed for implementing this functionality is not exactly staggering given the current infrastructure in lexer and parser.

GOP-PROP 9: behavior of make doc (final)

2011-09-21 Thread Graham Percival
I forgot to send the final version here. It was added to the CG, and nobody complained about the final versions being in the CG, but I should have still sent it for the email archives. http://lilypond.org/doc/v2.15/Documentation/contributor/gop_002dprop-9-_002d-behavior-of-make-doc ** summary

Re: Implement define-event-function (issue 5083045)

2011-09-21 Thread reinhold . kainhofer
I haven't looked at the code itself, but a regtest is definitely missing from the patch. http://codereview.appspot.com/5083045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Causes lily to fail during regtests if binary is unoptimized. (issue 5067042)

2011-09-21 Thread percival . music . ca
Not acceptable in current form because it would cause GUB to fail a build. I suggest an alternate make target for this type of build. http://codereview.appspot.com/5067042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Doc: Added note to CG about disable-optimizing (issue 5081048)

2011-09-21 Thread percival . music . ca
http://codereview.appspot.com/5081048/diff/1/Documentation/contributor/regressions.itexi File Documentation/contributor/regressions.itexi (right): http://codereview.appspot.com/5081048/diff/1/Documentation/contributor/regressions.itexi#newcode143 Documentation/contributor/regressions.itexi:143:

Re: Implement define-event-function (issue 5083045)

2011-09-21 Thread David Kastrup
reinhold.kainho...@gmail.com writes: I haven't looked at the code itself, but a regtest is definitely missing from the patch. http://codereview.appspot.com/5083045/ Writing regtests is one of my least favorite occupations. This feature has been requested so often that I'd appreciate

Re: Doc: add a note about \relative f to notation (issue 1909) (issue 5096046)

2011-09-21 Thread percival . music . ca
http://codereview.appspot.com/5096046/diff/1/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): http://codereview.appspot.com/5096046/diff/1/Documentation/notation/pitches.itely#newcode258 Documentation/notation/pitches.itely:258: If you carefully consider

Re: Doc: NR Clarify finer point of repeat unfold (issue 5075047)

2011-09-21 Thread percival . music . ca
LGTM. http://codereview.appspot.com/5075047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: bookOutputName broken

2011-09-21 Thread Benkő Pál
Neil, David, I don't know what to do, could you help me? The attached patch works for me (haven't run make check on it though). I have taken the liberty of pushing it after looking it through thanks to both of you: the patch works and I've learnt something about LilyPond again. p

Re: Implement define-event-function (issue 5083045)

2011-09-21 Thread Reinhold Kainhofer
Am Wednesday, 21. September 2011, 21:26:54 schrieb David Kastrup: reinhold.kainho...@gmail.com writes: I haven't looked at the code itself, but a regtest is definitely missing from the patch. http://codereview.appspot.com/5083045/ Writing regtests is one of my least favorite

Re: Implement define-event-function (issue 5083045)

2011-09-21 Thread n . puttock
On 2011/09/21 19:40:37, reinhold_kainhofer.com wrote: Huh? How do you verify that your feature works at all? I'm sure you are using some simple test file for this. So, simply take that file, add a \header { doctitle=some short description } and you're done. The example David's posted

Re: Unifies mensural ligatures with blot-diameter. (issue 5030053)

2011-09-21 Thread benko . pal
On 2011/09/18 19:55:47, Bertrand Bordage wrote: Another update that fixes some variable errors. It now passes make. thanks Bertrand, this is great work; I can now print flexae just the default way! (so long I had to use non-default viewers and lpr commands.) p

Re: New alist to replace special characters. (issue 4553056)

2011-09-21 Thread n . puttock
http://codereview.appspot.com/4553056/diff/106003/Documentation/included/special-characters.ly File Documentation/included/special-characters.ly (right): http://codereview.appspot.com/4553056/diff/106003/Documentation/included/special-characters.ly#newcode1

Re: Unifies mensural ligatures with blot-diameter. (issue 5030053)

2011-09-21 Thread n . puttock
http://codereview.appspot.com/5030053/diff/2004/lily/mensural-ligature.cc File lily/mensural-ligature.cc (right): http://codereview.appspot.com/5030053/diff/2004/lily/mensural-ligature.cc#newcode74 lily/mensural-ligature.cc:74: = (me-layout ()-get_dimension (ly_symbol2scm (blot-diameter)));

Re: Implement define-event-function (issue 5083045)

2011-09-21 Thread dak
On 2011/09/21 19:44:46, Neil Puttock wrote: On 2011/09/21 19:40:37, http://reinhold_kainhofer.com wrote: Huh? How do you verify that your feature works at all? I'm sure you are using some simple test file for this. So, simply take that file, add a \header { doctitle=some short

Re: Implement define-event-function (issue 5083045)

2011-09-21 Thread n . puttock
http://codereview.appspot.com/5083045/diff/1/scm/c++.scm File scm/c++.scm (right): http://codereview.appspot.com/5083045/diff/1/scm/c++.scm#newcode38 scm/c++.scm:38: (define-public (event? x) I'd prefer a less vague name for this since it's going to conflict with the stream event predicate

Re: Progress on loose columns. (issue 4841052)

2011-09-21 Thread n . puttock
LGTM. http://codereview.appspot.com/4841052/diff/25001/input/regression/spacing-loose-polyphony.ly File input/regression/spacing-loose-polyphony.ly (right): http://codereview.appspot.com/4841052/diff/25001/input/regression/spacing-loose-polyphony.ly#newcode1

Re: Terminates outside_staff_callback early if a grob is outside a slur's X-extent (issue 5056041)

2011-09-21 Thread n . puttock
Needs a regression test. This might do: \relative c'' { \set strokeFingerOrientations = #'(up) \override StrokeFinger #'avoid-slur = #'outside a-\rightHandFinger #2 16( b) } http://codereview.appspot.com/5056041/diff/1/lily/slur.cc File lily/slur.cc (right):

GOP-PROP 10: scheme indentation

2011-09-21 Thread Graham Percival
I've added make it work like emacs to the proposal. http://lilypond.org/~graham/gop/gop_10.html ** Proposal summary Speaking academically, scheme code style is a “solved problem”. Let’s pick one of the existing solutions, and let a computer deal with this. Humans should not waste their time,

Re: Rietveld workflow problems

2011-09-21 Thread Graham Percival
On Wed, Sep 21, 2011 at 09:27:39AM -0600, Carl Sorensen wrote: On 9/21/11 6:48 AM, Reinhold Kainhofer reinh...@kainhofer.com wrote: I looked at gerrit a while ago. If you want to take a look at it: http://server.kainhofer.com:8088/ Gerrit is certainly an option, although I'm not encouraged

Re: GOP-PROP 13: patch management tools

2011-09-21 Thread Graham Percival
On Tue, Sep 20, 2011 at 09:32:55AM +0100, Trevor Daniels wrote: Graham Percival wrote Tuesday, September 20, 2011 12:09 AM * 1-5 hours: automatically switch any Patch-review to Patch-needs_work if there are any non-LGTM comments. Hmm. There are often comments which don't

Re: New alist to replace special characters. (issue 4553056)

2011-09-21 Thread bordage . bertrand
Thanks a lot, Neil. Could you have a last look at the Scheme files? I'm not sure of the indentation. I created a new scm/text.scm file for the definitions I couldn't put elsewhere. Bertrand http://codereview.appspot.com/4553056/ ___ lilypond-devel

Re: GOP-PROP 13: patch management tools

2011-09-21 Thread Graham Percival
On Tue, Sep 20, 2011 at 09:04:39PM +0200, Janek Warchoł wrote: My impression is that the main problem is the duplicancy of data and e-mail threads. Over and over again i'm getting lost, for example: I can't see that going away. - email is the most convenient option for quick discussion -

Re: Implement define-event-function (issue 5083045)

2011-09-21 Thread dak
http://codereview.appspot.com/5083045/diff/1/scm/c++.scm File scm/c++.scm (right): http://codereview.appspot.com/5083045/diff/1/scm/c++.scm#newcode38 scm/c++.scm:38: (define-public (event? x) On 2011/09/21 21:32:30, Neil Puttock wrote: I'd prefer a less vague name for this since it's going to

Re: GOP-PROP 13: patch management tools

2011-09-21 Thread Graham Percival
On Tue, Sep 20, 2011 at 07:05:04AM -0600, Colin Campbell wrote: The remaining case is where there are no comments when a countdown expires. I've been taking that as silence implying consent, but with no assurance that anyone has actually reviewed the patch. Yes, that's correct. Think of the

Re: Implement define-event-function (issue 5083045)

2011-09-21 Thread dak
http://codereview.appspot.com/5083045/diff/1/scm/c++.scm File scm/c++.scm (right): http://codereview.appspot.com/5083045/diff/1/scm/c++.scm#newcode38 scm/c++.scm:38: (define-public (event? x) On 2011/09/21 22:14:40, dak wrote: On 2011/09/21 21:32:30, Neil Puttock wrote: I'd prefer a less

Re: Glyphs for Kievan Notation (issue 4951062)

2011-09-21 Thread aleksandr . andreev
Updated Documentation/notation/notation-appendices.itely to show new glyphs, reflecting comments by Neil. http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Problem with make

2011-09-21 Thread David Kastrup
pkx1...@gmail.com pkx1...@gmail.com writes: hello, On Wed, Sep 21, 2011 at 05:13:00PM +0100, Phil Holmes wrote: On my fast build system, I can't currently get a successful make. Abort changes, pull, clean build directory. The build ends with: ... As you see, the problem is a missing

Re: Implement define-event-function (issue 5083045)

2011-09-21 Thread dak
Ok, I have made this based off origin/master, and I moved the stuff to using ly:event? instead of event? (not really addressing Neil's issue at all, merely for somewhat more symmetry to ly:music?). Untested. http://codereview.appspot.com/5083045/ ___

Re: Implement define-event-function (issue 5083045)

2011-09-21 Thread dak
If this can be verified as working, it might go on the patch countdown, barring comments that require addressing. Note that ly:event? is not part of the public API of define-event-function: if ly:event?'s function name changes at some later point of time, uses of define-event-function will not

Re: Glyphs for Kievan Notation (issue 4951062)

2011-09-21 Thread Aleksandr Andreev
Yet another rm -fdr build/ and re-run of make, etc., eliminated my original problem with snippets. Now, my make doc command crashes with the same error message that Janek is getting. Looks like there's a missing file web.texi. Aleks ___

Re: GOP-PROP 13: patch management tools

2011-09-21 Thread Colin Campbell
On 11-09-21 04:13 PM, Graham Percival wrote: On Tue, Sep 20, 2011 at 09:04:39PM +0200, Janek Warchoł wrote: My impression is that the main problem is the duplicancy of data and e-mail threads. Over and over again i'm getting lost, for example: I can't see that going away. - email is the most

Re: Problem with make

2011-09-21 Thread Graham Percival
On Thu, Sep 22, 2011 at 01:59:53AM +0200, David Kastrup wrote: David Kastrup d...@gnu.org writes: pkx1...@gmail.com pkx1...@gmail.com writes: hello, On Wed, Sep 21, 2011 at 05:13:00PM +0100, Phil Holmes wrote: On my fast build system, I can't currently get a successful make. Abort

Re: GOP-PROP 13: patch management tools

2011-09-21 Thread Carl Sorensen
On 9/21/11 9:25 PM, Colin Campbell c...@shaw.ca wrote: On 11-09-21 04:13 PM, Graham Percival wrote: On Tue, Sep 20, 2011 at 09:04:39PM +0200, Janek Warchoł wrote: One thing comes to my mind: there is some code revieving tool on Google Code. I remember that i saw it being used in some other

Re: GOP-PROP 13: patch management tools

2011-09-21 Thread Graham Percival
On Wed, Sep 21, 2011 at 09:25:45PM -0600, Colin Campbell wrote: I'm solidly with Janek here, Graham. As it sits, a person wanting to follow the trail of a (bug/issue/enhancement request) has to find the thing on two separate web-sites, where developers log in despite your comment above, using

PATCH: Countdown to 20110923

2011-09-21 Thread Colin Campbell
For 20:00 CDT Friday September 23 (no, the time is not a typo: I'll be visiting my Mother in Ontario, and hope to borrow her browser) Issue 935 http://code.google.com/p/lilypond/issues/detail?id=935: Enhancement: optional arguments in music functions - R 5023044

Re: Glyphs for Kievan Notation (issue 4951062)

2011-09-21 Thread Janek Warchoł
2011/9/21 Phil Holmes m...@philholmes.net: - Original Message - From: Janek Warchoł janek.lilyp...@gmail.com [snip] It's the first time i tried compiling docs, so i may have screwed something.  Here's what i did:   rm -r build   sh autogen.sh --noconfigure   mkdir -p build/  

Re: Rietveld workflow problems

2011-09-21 Thread Janek Warchoł
2011/9/21 Carl Sorensen c_soren...@byu.edu: On 9/21/11 6:48 AM, Reinhold Kainhofer reinh...@kainhofer.com wrote: Am Wednesday, 21. September 2011, 10:52:37 schrieb David Kastrup: Perhaps it would be nice if we found a way to play with Gerrit, supposedly a git-based system similar to Rietveld.

Re: Glyphs for Kievan Notation (issue 4951062)

2011-09-21 Thread Graham Percival
On Thu, Sep 22, 2011 at 06:22:13AM +0200, Janek Warchoł wrote: Overnight i tried making doc on current master and it failed too. ef8dd3eaee73588faf1a6687407a6fda60cff591 worked perfectly in ubuntu 10.04 (not quite lilydev) for me a few hours ago. 63cfd5548c42a98c7dae43f1f92e67772969e53c worked

Re: lilypond-book-preamble: Automatically set the eps backend, since we require it anyway (issue 5038045)

2011-09-21 Thread percival . music . ca
LGTM http://codereview.appspot.com/5038045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: PATCH: Countdown to 20110923

2011-09-21 Thread Graham Percival
On Wed, Sep 21, 2011 at 10:17:59PM -0600, Colin Campbell wrote: For 20:00 CDT Friday September 23 (no, the time is not a typo: I'll be visiting my Mother in Ontario, and hope to borrow her browser) I've just nuked two of those because there's existing complaints/suggestions on Rietveld.

Re: GOP-PROP 10: scheme indentation

2011-09-21 Thread Janek Warchoł
2011/9/21 Graham Percival gra...@percival-music.ca: On Wed, Sep 21, 2011 at 08:20:39AM +0200, Jan Nieuwenhuizen wrote: David Kastrup writes: Personally, I'd prefer it if we focused on solving rather than creating real problems. +1 Automatic indentation *does* solve real problems.  Take

Re: Glyphs for Kievan Notation (issue 4951062)

2011-09-21 Thread Janek Warchoł
2011/9/22 Graham Percival gra...@percival-music.ca: On Thu, Sep 22, 2011 at 06:22:13AM +0200, Janek Warchoł wrote: Overnight i tried making doc on current master and it failed too. ef8dd3eaee73588faf1a6687407a6fda60cff591 worked perfectly in ubuntu 10.04 (not quite lilydev) for me a few