On Fri, 2018-10-12 at 02:23:13 UTC, Yogesh Narayan Gaur wrote:
> Add entry for mt35xu512aba Micron NOR flash.
> This flash is having uniform sector erase size of 128KB, have
> support of FSR(flag status register), flash size is 64MB and
> supports 4-byte commands.
>
> Signed-off-by: Yogesh Gaur
On Fri, 2018-10-12 at 02:23:08 UTC, Yogesh Narayan Gaur wrote:
> Some MICRON related macros in spi-nor domain were ST.
> Rename entries related to STMicroelectronics under macro SNOR_MFR_ST.
>
> Added entry of MFR Id for Micron flashes, 0x002C.
>
> Signed-off-by: Yogesh Gaur
> Reviewed-by:
On Fri, 2018-11-16 at 17:46:37 UTC, wrote:
> There are uniform, non-uniform and flexible erase flash configurations.
>
> The non-uniform erase types, are the erase types that can _not_ erase
> the entire flash by their own.
>
> As the code was, in case flashes had flexible erase capabilities
>
On Fri, 2018-11-16 at 17:46:37 UTC, wrote:
> There are uniform, non-uniform and flexible erase flash configurations.
>
> The non-uniform erase types, are the erase types that can _not_ erase
> the entire flash by their own.
>
> As the code was, in case flashes had flexible erase capabilities
>
On Fri, 9 Nov 2018 10:30:41 +0530
Naga Sureshkumar Relli wrote:
> +static int anfc_setup_data_interface(struct nand_chip *chip, int csline,
> + const struct nand_data_interface *conf)
> +{
> + struct anfc_nand_controller *nfc = to_anfc(chip->controller);
> +
On Fri, 9 Nov 2018 10:30:41 +0530
Naga Sureshkumar Relli wrote:
> +static int anfc_setup_data_interface(struct nand_chip *chip, int csline,
> + const struct nand_data_interface *conf)
> +{
> + struct anfc_nand_controller *nfc = to_anfc(chip->controller);
> +
On Tue, 20 Nov 2018 12:48:46 +0100
Krzysztof Kozlowski wrote:
> On Tue, 20 Nov 2018 at 11:33, Miquel Raynal wrote:
> >
> > Hi Krzysztof,
> >
> > Krzysztof Kozłowski wrote on Tue, 20 Nov 2018
> > 10:46:33 +0100:
> >
> > > Hi all,
> > >
> > > Since few days linux-next has problem on Freescale
On Tue, 20 Nov 2018 12:48:46 +0100
Krzysztof Kozlowski wrote:
> On Tue, 20 Nov 2018 at 11:33, Miquel Raynal wrote:
> >
> > Hi Krzysztof,
> >
> > Krzysztof Kozłowski wrote on Tue, 20 Nov 2018
> > 10:46:33 +0100:
> >
> > > Hi all,
> > >
> > > Since few days linux-next has problem on Freescale
On Tue, 20 Nov 2018 07:02:08 +
Naga Sureshkumar Relli wrote:
> >
> > Can you please run nandbiterrs (availaible in mtd-utils). I fear your
> > device won't pass the test.
> Yes, nandbiterror test is passing till 24bit, after that it is failing.
Can you paste the output of nandbiterrs
On Tue, 20 Nov 2018 07:02:08 +
Naga Sureshkumar Relli wrote:
> >
> > Can you please run nandbiterrs (availaible in mtd-utils). I fear your
> > device won't pass the test.
> Yes, nandbiterror test is passing till 24bit, after that it is failing.
Can you paste the output of nandbiterrs
On Fri, 2018-11-16 at 14:25:49 UTC, thor.tha...@linux.intel.com wrote:
> From: Thor Thayer
>
> The current Cadence QSPI driver caused a kernel panic sporadically
> when writing to QSPI. The problem was caused by writing more bytes
> than needed because the QSPI operated on 4 bytes at a time.
>
On Fri, 2018-11-16 at 14:25:49 UTC, thor.tha...@linux.intel.com wrote:
> From: Thor Thayer
>
> The current Cadence QSPI driver caused a kernel panic sporadically
> when writing to QSPI. The problem was caused by writing more bytes
> than needed because the QSPI operated on 4 bytes at a time.
>
On Mon, 19 Nov 2018 12:41:10 +
vitor wrote:
> Hi Coling,
>
>
> Thanks for your report.
>
> On 16/11/18 18:42, Colin King wrote:
> > From: Colin Ian King
> >
> > The masking operation on status is using a bitwise 'or' rather than
> > a bitwise 'and' operator, and hence the result is
On Mon, 19 Nov 2018 12:41:10 +
vitor wrote:
> Hi Coling,
>
>
> Thanks for your report.
>
> On 16/11/18 18:42, Colin King wrote:
> > From: Colin Ian King
> >
> > The masking operation on status is using a bitwise 'or' rather than
> > a bitwise 'and' operator, and hence the result is
On Mon, 19 Nov 2018 16:12:41 +0100
Marek Vasut wrote:
> On 11/19/2018 03:43 PM, Boris Brezillon wrote:
> > On Mon, 19 Nov 2018 15:14:07 +0100
> > Marek Vasut wrote:
> >
> >> On 11/19/2018 03:10 PM, Boris Brezillon wrote:
> >>> On Mon, 19 Nov 20
On Mon, 19 Nov 2018 16:12:41 +0100
Marek Vasut wrote:
> On 11/19/2018 03:43 PM, Boris Brezillon wrote:
> > On Mon, 19 Nov 2018 15:14:07 +0100
> > Marek Vasut wrote:
> >
> >> On 11/19/2018 03:10 PM, Boris Brezillon wrote:
> >>> On Mon, 19 Nov 20
On Mon, 19 Nov 2018 15:14:07 +0100
Marek Vasut wrote:
> On 11/19/2018 03:10 PM, Boris Brezillon wrote:
> > On Mon, 19 Nov 2018 14:49:31 +0100
> > Marek Vasut wrote:
> >
> >> On 11/19/2018 11:01 AM, Mason Yang wrote:
> >>> Document the bindings u
On Mon, 19 Nov 2018 15:14:07 +0100
Marek Vasut wrote:
> On 11/19/2018 03:10 PM, Boris Brezillon wrote:
> > On Mon, 19 Nov 2018 14:49:31 +0100
> > Marek Vasut wrote:
> >
> >> On 11/19/2018 11:01 AM, Mason Yang wrote:
> >>> Document the bindings u
On Mon, 19 Nov 2018 14:49:31 +0100
Marek Vasut wrote:
> On 11/19/2018 11:01 AM, Mason Yang wrote:
> > Document the bindings used by the Renesas R-Car D3 RPC controller.
> >
> > Signed-off-by: Mason Yang
> > ---
> > .../devicetree/bindings/spi/spi-renesas-rpc.txt| 33
> >
On Mon, 19 Nov 2018 14:49:31 +0100
Marek Vasut wrote:
> On 11/19/2018 11:01 AM, Mason Yang wrote:
> > Document the bindings used by the Renesas R-Car D3 RPC controller.
> >
> > Signed-off-by: Mason Yang
> > ---
> > .../devicetree/bindings/spi/spi-renesas-rpc.txt| 33
> >
On Mon, 19 Nov 2018 12:35:42 +
vitor wrote:
> Hi Boris,
>
> On 16/11/18 13:16, Boris Brezillon wrote:
> > On Fri, 16 Nov 2018 12:31:42 +
> > vitor wrote:
> >
> >> Hi Boris,
> >>
> >>
> >> On 15/11/18 19:00, Boris Brezillo
On Mon, 19 Nov 2018 12:35:42 +
vitor wrote:
> Hi Boris,
>
> On 16/11/18 13:16, Boris Brezillon wrote:
> > On Fri, 16 Nov 2018 12:31:42 +
> > vitor wrote:
> >
> >> Hi Boris,
> >>
> >>
> >> On 15/11/18 19:00, Boris Brezillo
On Mon, 19 Nov 2018 09:58:46 +0100
Bartosz Golaszewski wrote:
> niedz., 18 lis 2018 o 17:03 Boris Brezillon
> napisał(a):
> >
> > On Tue, 13 Nov 2018 15:01:08 +0100
> > Bartosz Golaszewski wrote:
> >
> > > As far as merging of this series goes: I'd li
On Mon, 19 Nov 2018 09:58:46 +0100
Bartosz Golaszewski wrote:
> niedz., 18 lis 2018 o 17:03 Boris Brezillon
> napisał(a):
> >
> > On Tue, 13 Nov 2018 15:01:08 +0100
> > Bartosz Golaszewski wrote:
> >
> > > As far as merging of this series goes: I'd li
On Mon, 19 Nov 2018 06:20:28 +
Naga Sureshkumar Relli wrote:
> H Boris,
>
> > -Original Message-
> > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com]
> > Sent: Monday, November 19, 2018 1:13 AM
> > To: Naga Sureshkumar Relli
> >
On Mon, 19 Nov 2018 06:20:28 +
Naga Sureshkumar Relli wrote:
> H Boris,
>
> > -Original Message-
> > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com]
> > Sent: Monday, November 19, 2018 1:13 AM
> > To: Naga Sureshkumar Relli
> >
On Thu, 15 Nov 2018 09:34:16 +
Naga Sureshkumar Relli wrote:
> Hi Boris & Miquel,
>
> I am updating the driver by addressing your comments, and I have one concern,
> especially in anfc_read_page_hwecc(),
> there I am checking for erased pages bit flips.
> Since Arasan NAND controller
On Thu, 15 Nov 2018 09:34:16 +
Naga Sureshkumar Relli wrote:
> Hi Boris & Miquel,
>
> I am updating the driver by addressing your comments, and I have one concern,
> especially in anfc_read_page_hwecc(),
> there I am checking for erased pages bit flips.
> Since Arasan NAND controller
On Thu, 15 Nov 2018 15:26:48 +0100
Johan Hovold wrote:
> On Tue, Oct 23, 2018 at 08:51:17PM +0200, Boris Brezillon wrote:
> > On Tue, 23 Oct 2018 13:28:09 -0500
> > Rob Herring wrote:
> >
> > > On Mon, Aug 27, 2018 at 4:44 AM Johan Hovold wrote:
> > &g
On Thu, 15 Nov 2018 15:26:48 +0100
Johan Hovold wrote:
> On Tue, Oct 23, 2018 at 08:51:17PM +0200, Boris Brezillon wrote:
> > On Tue, 23 Oct 2018 13:28:09 -0500
> > Rob Herring wrote:
> >
> > > On Mon, Aug 27, 2018 at 4:44 AM Johan Hovold wrote:
> > &g
On Sat, 2018-11-17 at 03:43:27 UTC, Olof Johansson wrote:
> PAGE_READ is used by RISC-V arch code included through mm headers,
> and it makes sense to bring in a prefix on these in the driver.
>
> drivers/mtd/nand/raw/qcom_nandc.c:153: warning: "PAGE_READ" redefined
> #define PAGE_READ 0x2
>
On Sat, 2018-11-17 at 03:43:27 UTC, Olof Johansson wrote:
> PAGE_READ is used by RISC-V arch code included through mm headers,
> and it makes sense to bring in a prefix on these in the driver.
>
> drivers/mtd/nand/raw/qcom_nandc.c:153: warning: "PAGE_READ" redefined
> #define PAGE_READ 0x2
>
On Fri, 2018-11-09 at 16:56:56 UTC, wrote:
> The entire smpt array is initialized with data read from sfdp,
> there is no need to init it with zeroes before.
>
> Signed-off-by: Tudor Ambarus
Applied to http://git.infradead.org/linux-mtd.git spi-nor/next, thanks.
Boris
On Fri, 2018-11-09 at 16:56:56 UTC, wrote:
> The entire smpt array is initialized with data read from sfdp,
> there is no need to init it with zeroes before.
>
> Signed-off-by: Tudor Ambarus
Applied to http://git.infradead.org/linux-mtd.git spi-nor/next, thanks.
Boris
On Thu, 15 Nov 2018 00:07:10 -0500
Huijin Park wrote:
> From: "huijin.park"
>
> This patch casts the "len" parameter to an unsigned int.
Hm, that's not really what this patch actually. Actually it avoids the
cast from an int to an unsigned int.
> The callers of erase_write() pass the "len"
On Thu, 15 Nov 2018 00:07:10 -0500
Huijin Park wrote:
> From: "huijin.park"
>
> This patch casts the "len" parameter to an unsigned int.
Hm, that's not really what this patch actually. Actually it avoids the
cast from an int to an unsigned int.
> The callers of erase_write() pass the "len"
On Fri, 2018-11-09 at 16:56:52 UTC, wrote:
> Don't overwrite the errno from spi_nor_read_raw().
>
> Signed-off-by: Tudor Ambarus
Applied to http://git.infradead.org/linux-mtd.git mtd/fixes, thanks.
Boris
On Fri, 2018-11-09 at 16:56:52 UTC, wrote:
> Don't overwrite the errno from spi_nor_read_raw().
>
> Signed-off-by: Tudor Ambarus
Applied to http://git.infradead.org/linux-mtd.git mtd/fixes, thanks.
Boris
ser fails. In case of failing, each optional parser is responsible
> to roll back to the previously known spi_nor data.
>
> Fixes: b038e8e3be72 ("mtd: spi-nor: parse SFDP Sector Map Parameter Table")
> Reported-by: Yogesh Gaur
> Suggested-by: Boris Brezillon
>
ser fails. In case of failing, each optional parser is responsible
> to roll back to the previously known spi_nor data.
>
> Fixes: b038e8e3be72 ("mtd: spi-nor: parse SFDP Sector Map Parameter Table")
> Reported-by: Yogesh Gaur
> Suggested-by: Boris Brezillon
>
r manufacturers, misrepresent smpt
> array fields.
>
> Fixes: b038e8e3be72 ("mtd: spi-nor: parse SFDP Sector Map Parameter Table")
> Suggested-by: Boris Brezillon
> Signed-off-by: Tudor Ambarus
Applied to http://git.infradead.org/linux-mtd.git mtd/fixes, thanks.
Boris
r manufacturers, misrepresent smpt
> array fields.
>
> Fixes: b038e8e3be72 ("mtd: spi-nor: parse SFDP Sector Map Parameter Table")
> Suggested-by: Boris Brezillon
> Signed-off-by: Tudor Ambarus
Applied to http://git.infradead.org/linux-mtd.git mtd/fixes, thanks.
Boris
On Fri, 2018-11-09 at 16:56:54 UTC, wrote:
> spi_nor_read_raw() calls nor->read() which might be implemented
> by the m25p80 driver. m25p80 uses the spi-mem layer which requires
> DMA-able in/out buffers. Pass kmalloc'ed dma buffer to spi_nor_read_raw().
>
> Fixes: b038e8e3be72 ("mtd: spi-nor:
On Fri, 2018-11-09 at 16:56:54 UTC, wrote:
> spi_nor_read_raw() calls nor->read() which might be implemented
> by the m25p80 driver. m25p80 uses the spi-mem layer which requires
> DMA-able in/out buffers. Pass kmalloc'ed dma buffer to spi_nor_read_raw().
>
> Fixes: b038e8e3be72 ("mtd: spi-nor:
On Thu, 15 Nov 2018 11:43:05 +
Schrempf Frieder wrote:
> On 15.11.18 07:22, Yogesh Narayan Gaur wrote:
> > Hi Frieder,
> >
> > With below patch on top of your v5, Read/Write/Erase on CS1 is working fine
> > for me.
>
> Ok, are you sure, that AHB read is working too with this patch?
>
On Thu, 15 Nov 2018 11:43:05 +
Schrempf Frieder wrote:
> On 15.11.18 07:22, Yogesh Narayan Gaur wrote:
> > Hi Frieder,
> >
> > With below patch on top of your v5, Read/Write/Erase on CS1 is working fine
> > for me.
>
> Ok, are you sure, that AHB read is working too with this patch?
>
On Thu, 15 Nov 2018 14:04:00 +0100
Miquel Raynal wrote:
> Hi Liang,
>
> Liang Yang wrote on Thu, 15 Nov 2018 19:25:07
> +0800:
>
> > Hi Boris,
> >
> > I have implemented dma access base on these helpers you provided below.
> > we prepare to send v7 version now, so when will these helpers be
On Thu, 15 Nov 2018 14:04:00 +0100
Miquel Raynal wrote:
> Hi Liang,
>
> Liang Yang wrote on Thu, 15 Nov 2018 19:25:07
> +0800:
>
> > Hi Boris,
> >
> > I have implemented dma access base on these helpers you provided below.
> > we prepare to send v7 version now, so when will these helpers be
On Thu, 15 Nov 2018 10:54:39 +
wrote:
> Hi, Liu, Boris, Cyrille,
>
> On 11/14/2018 03:51 PM, Boris Brezillon wrote:
> > On Wed, 14 Nov 2018 20:56:05 +0800
> > Liu Xiang wrote:
> >
> >> In is25lp256, the DWORD1 of JEDEC Basic Flash Parameter Header
>
On Thu, 15 Nov 2018 10:54:39 +
wrote:
> Hi, Liu, Boris, Cyrille,
>
> On 11/14/2018 03:51 PM, Boris Brezillon wrote:
> > On Wed, 14 Nov 2018 20:56:05 +0800
> > Liu Xiang wrote:
> >
> >> In is25lp256, the DWORD1 of JEDEC Basic Flash Parameter Header
>
On Wed, 14 Nov 2018 06:10:47 +
YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/i3c/master/i3c-master-cdns.c: In function 'cdns_i3c_master_do_daa':
> drivers/i3c/master/i3c-master-cdns.c:1137:16: warning:
> variable 'old_i3c_scl_lim' set but not used
On Wed, 14 Nov 2018 06:10:47 +
YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/i3c/master/i3c-master-cdns.c: In function 'cdns_i3c_master_do_daa':
> drivers/i3c/master/i3c-master-cdns.c:1137:16: warning:
> variable 'old_i3c_scl_lim' set but not used
On Wed, 14 Nov 2018 20:55:18 +0800
Liu Xiang wrote:
> The is25lp256 supports 4-byte opcodes and quad output.
>
> Suggested-by: Boris Brezillon
> Signed-off-by: Liu Xiang
This one looks good. Tudor, can you have a look?
> ---
> drivers/mtd/spi-nor/spi-nor.c | 2 +-
&g
On Wed, 14 Nov 2018 20:55:18 +0800
Liu Xiang wrote:
> The is25lp256 supports 4-byte opcodes and quad output.
>
> Suggested-by: Boris Brezillon
> Signed-off-by: Liu Xiang
This one looks good. Tudor, can you have a look?
> ---
> drivers/mtd/spi-nor/spi-nor.c | 2 +-
&g
size in spi_nor_parse_sfdp().
>
> Suggested-by: Boris Brezillon
> Signed-off-by: Liu Xiang
> ---
> drivers/mtd/spi-nor/spi-nor.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 3eba13a..77eaf2
size in spi_nor_parse_sfdp().
>
> Suggested-by: Boris Brezillon
> Signed-off-by: Liu Xiang
> ---
> drivers/mtd/spi-nor/spi-nor.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 3eba13a..77eaf2
On Wed, 14 Nov 2018 10:43:00 +
Yogesh Narayan Gaur wrote:
> Hi Frieder,
>
> [..]
> > >
> > > Ok, I will have a look at what could make the chip selection fail in
> > > case of AHB read.
> >
> > Could you try with this change applied:
> >
> > @@ -503,7 +503,7 @@ static void
On Wed, 14 Nov 2018 10:43:00 +
Yogesh Narayan Gaur wrote:
> Hi Frieder,
>
> [..]
> > >
> > > Ok, I will have a look at what could make the chip selection fail in
> > > case of AHB read.
> >
> > Could you try with this change applied:
> >
> > @@ -503,7 +503,7 @@ static void
On Thu, 8 Nov 2018 08:16:53 -0800
Eric Anholt wrote:
> The extra to_v3d_bo() calls came from copying this from the vc4
> driver, which stored the cma gem object in the structs.
>
> Signed-off-by: Eric Anholt
Reviewed-by: Boris Brezillon
> ---
> drivers/gpu/drm/
On Thu, 8 Nov 2018 08:16:53 -0800
Eric Anholt wrote:
> The extra to_v3d_bo() calls came from copying this from the vc4
> driver, which stored the cma gem object in the structs.
>
> Signed-off-by: Eric Anholt
Reviewed-by: Boris Brezillon
> ---
> drivers/gpu/drm/
On Mon, 12 Nov 2018 17:54:16 +0100
Boris Brezillon wrote:
> +Wolfram to give some inputs on the DMA issue.
>
> On Mon, 12 Nov 2018 17:13:51 +0100
> Miquel Raynal wrote:
>
> > Hello,
> >
> > Boris Brezillon wrote on Tue, 6 Nov 2018
> > 11:22:06 +0100:
&
On Mon, 12 Nov 2018 17:54:16 +0100
Boris Brezillon wrote:
> +Wolfram to give some inputs on the DMA issue.
>
> On Mon, 12 Nov 2018 17:13:51 +0100
> Miquel Raynal wrote:
>
> > Hello,
> >
> > Boris Brezillon wrote on Tue, 6 Nov 2018
> > 11:22:06 +0100:
&
+Wolfram to give some inputs on the DMA issue.
On Mon, 12 Nov 2018 17:13:51 +0100
Miquel Raynal wrote:
> Hello,
>
> Boris Brezillon wrote on Tue, 6 Nov 2018
> 11:22:06 +0100:
>
> > On Tue, 6 Nov 2018 18:00:37 +0800
> > Liang Yang wrote:
> >
> > >
+Wolfram to give some inputs on the DMA issue.
On Mon, 12 Nov 2018 17:13:51 +0100
Miquel Raynal wrote:
> Hello,
>
> Boris Brezillon wrote on Tue, 6 Nov 2018
> 11:22:06 +0100:
>
> > On Tue, 6 Nov 2018 18:00:37 +0800
> > Liang Yang wrote:
> >
> > >
On Mon, 12 Nov 2018 11:55:36 +0100
Martin Lund wrote:
> Hi Naga,
>
> Just a few review comments for the v12 version.
>
> On Fri, Nov 9, 2018 at 6:00 AM Naga Sureshkumar Relli
> wrote:
> > +#define PKT_OFST 0x00
> > +#define PKT_CNT_SHIFT 12
> > +
> > +#define
On Mon, 12 Nov 2018 11:55:36 +0100
Martin Lund wrote:
> Hi Naga,
>
> Just a few review comments for the v12 version.
>
> On Fri, Nov 9, 2018 at 6:00 AM Naga Sureshkumar Relli
> wrote:
> > +#define PKT_OFST 0x00
> > +#define PKT_CNT_SHIFT 12
> > +
> > +#define
On Mon, 12 Nov 2018 10:46:45 +
Schrempf Frieder wrote:
> On 08.11.18 09:34, Boris Brezillon wrote:
> > On Wed, 7 Nov 2018 16:36:13 +
> > Schrempf Frieder wrote:
> >
> >> Hi Olof,
> >>
> >> On 07.11.18 17:20, Olof Johansson wrote
On Mon, 12 Nov 2018 10:46:45 +
Schrempf Frieder wrote:
> On 08.11.18 09:34, Boris Brezillon wrote:
> > On Wed, 7 Nov 2018 16:36:13 +
> > Schrempf Frieder wrote:
> >
> >> Hi Olof,
> >>
> >> On 07.11.18 17:20, Olof Johansson wrote
Hi Liu,
On Fri, 24 Aug 2018 22:41:41 +0800
Liu Xiang wrote:
> The is25lp256 supports 4-byte opcodes and quad output.
> In is25lp256, the DWORD1 of JEDEC Basic Flash Parameter Header
> is 0xfff920e5. So the DWORD1[18:17] Address Bytes bits are 0b00,
> means that 3-Byte only addressing. Now this
Hi Liu,
On Fri, 24 Aug 2018 22:41:41 +0800
Liu Xiang wrote:
> The is25lp256 supports 4-byte opcodes and quad output.
> In is25lp256, the DWORD1 of JEDEC Basic Flash Parameter Header
> is 0xfff920e5. So the DWORD1[18:17] Address Bytes bits are 0b00,
> means that 3-Byte only addressing. Now this
On Wed, 2018-08-15 at 17:02:26 UTC, "Gustavo A. R. Silva" wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 114857 ("Missing break in switch")
> Addresses-Coverity-ID: 114858 ("Missing break in
On Wed, 2018-08-15 at 17:02:26 UTC, "Gustavo A. R. Silva" wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 114857 ("Missing break in switch")
> Addresses-Coverity-ID: 114858 ("Missing break in
On Thu, 2018-08-09 at 16:05:13 UTC, "Gustavo A. R. Silva" wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 402015 ("Missing break in switch")
> Addresses-Coverity-ID: 402016 ("Missing break in
On Thu, 2018-08-09 at 16:05:13 UTC, "Gustavo A. R. Silva" wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 402015 ("Missing break in switch")
> Addresses-Coverity-ID: 402016 ("Missing break in
On Tue, 2018-09-11 at 12:42:34 UTC, Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to spelling mistake in the Kconfig text
>
> Signed-off-by: Colin Ian King
Applied to http://git.infradead.org/linux-mtd.git mtd/next, thanks.
Thanks!
On Tue, 2018-09-11 at 12:42:34 UTC, Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to spelling mistake in the Kconfig text
>
> Signed-off-by: Colin Ian King
Applied to http://git.infradead.org/linux-mtd.git mtd/next, thanks.
Thanks!
Hi Naga,
Just a preliminary review. I still think we have problems with how you
execute NAND operations. You seem to assume that read/write operation
are always page write/read operation with a size aligned on a page
size. This is wrong, either the controller is able to execute the exact
Hi Naga,
Just a preliminary review. I still think we have problems with how you
execute NAND operations. You seem to assume that read/write operation
are always page write/read operation with a size aligned on a page
size. This is wrong, either the controller is able to execute the exact
On Fri, 9 Nov 2018 10:30:39 +0530
Naga Sureshkumar Relli wrote:
> This patch adds the dts binding document for arasan nand flash controller
>
> Signed-off-by: Naga Sureshkumar Relli
> ---
> Changes in v12:
> - Removed interrupt-parent description as it is implied as suggested by
>Rob
On Fri, 9 Nov 2018 10:30:39 +0530
Naga Sureshkumar Relli wrote:
> This patch adds the dts binding document for arasan nand flash controller
>
> Signed-off-by: Naga Sureshkumar Relli
> ---
> Changes in v12:
> - Removed interrupt-parent description as it is implied as suggested by
>Rob
On Thu, 8 Nov 2018 14:48:11 +
wrote:
> +
> >>>
> >>> Maybe I missed something but it sounds like this change is just
> >>> optimizing the SPMT parsing a bit, and to be honest, I'm not sure this
> >>> is really needed. Most of the time, smpt_len will be rather small, so
> >>>
On Thu, 8 Nov 2018 14:48:11 +
wrote:
> +
> >>>
> >>> Maybe I missed something but it sounds like this change is just
> >>> optimizing the SPMT parsing a bit, and to be honest, I'm not sure this
> >>> is really needed. Most of the time, smpt_len will be rather small, so
> >>>
On Wed, 7 Nov 2018 23:16:19 +0100
Richard Weinberger wrote:
> +/**
> + * ubi_bitflip_check - Check an eraseblock for bitflips and scrub it if
> needed.
> + * @ubi: UBI device description object
> + * @pnum: the physical eraseblock to schedule
> + * @force_scrub: force scrubbing if non-zero,
On Wed, 7 Nov 2018 23:16:19 +0100
Richard Weinberger wrote:
> +/**
> + * ubi_bitflip_check - Check an eraseblock for bitflips and scrub it if
> needed.
> + * @ubi: UBI device description object
> + * @pnum: the physical eraseblock to schedule
> + * @force_scrub: force scrubbing if non-zero,
On Thu, 8 Nov 2018 13:58:45 +
wrote:
> On 11/08/2018 02:54 PM, Boris Brezillon wrote:
> > On Thu, 8 Nov 2018 11:07:11 +
> > wrote:
> >
> >> The map selector is limited to a maximum of 8 bits, allowing
> >> for a maximum of 256 possible map confi
On Thu, 8 Nov 2018 13:58:45 +
wrote:
> On 11/08/2018 02:54 PM, Boris Brezillon wrote:
> > On Thu, 8 Nov 2018 11:07:11 +
> > wrote:
> >
> >> The map selector is limited to a maximum of 8 bits, allowing
> >> for a maximum of 256 possible map confi
On Thu, 8 Nov 2018 13:54:47 +0100
Boris Brezillon wrote:
> > - while (i < smpt_len) {
> > + for (nmaps = 0; i < smpt_len; nmaps++) {
> > + /*
> > +* The map selector is limited to a maximum of 8 bits, allowing
> > +
On Thu, 8 Nov 2018 13:54:47 +0100
Boris Brezillon wrote:
> > - while (i < smpt_len) {
> > + for (nmaps = 0; i < smpt_len; nmaps++) {
> > + /*
> > +* The map selector is limited to a maximum of 8 bits, allowing
> > +
On Thu, 8 Nov 2018 11:07:18 +
wrote:
> Use GFP_DMA to ensure that the memory we allocate for transfers in
> nor->read() can be DMAed.
See my comment on patch 5.
On Thu, 8 Nov 2018 11:07:18 +
wrote:
> Use GFP_DMA to ensure that the memory we allocate for transfers in
> nor->read() can be DMAed.
See my comment on patch 5.
On Thu, 8 Nov 2018 11:07:16 +
wrote:
> spi_nor_read_raw() calls nor->read() which might be implemented
> by the m25p80 driver. m25p80 uses the spi-mem layer which requires
> DMA-able in/out buffers. Pass kmalloc'ed dma buffer to spi_nor_read_raw().
>
> Signed-off-by: Tudor Ambarus
> ---
>
On Thu, 8 Nov 2018 11:07:16 +
wrote:
> spi_nor_read_raw() calls nor->read() which might be implemented
> by the m25p80 driver. m25p80 uses the spi-mem layer which requires
> DMA-able in/out buffers. Pass kmalloc'ed dma buffer to spi_nor_read_raw().
>
> Signed-off-by: Tudor Ambarus
> ---
>
rrently in use.
>
> Suggested-by: Boris Brezillon
I don't remember suggesting this :-).
> Signed-off-by: Tudor Ambarus
> ---
> drivers/mtd/spi-nor/spi-nor.c | 15 +--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/spi
rrently in use.
>
> Suggested-by: Boris Brezillon
I don't remember suggesting this :-).
> Signed-off-by: Tudor Ambarus
> ---
> drivers/mtd/spi-nor/spi-nor.c | 15 +--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/spi
ndaries in case software, or manufacturers, misrepresent smpt
> array fields.
>
> Suggested-by: Boris Brezillon
> Signed-off-by: Tudor Ambarus
I think we should consider this patch as a fix. Would you mind adding a
Fixes tag?
> ---
> drivers/mtd/spi-nor/spi-nor.c | 39 +++
ndaries in case software, or manufacturers, misrepresent smpt
> array fields.
>
> Suggested-by: Boris Brezillon
> Signed-off-by: Tudor Ambarus
I think we should consider this patch as a fix. Would you mind adding a
Fixes tag?
> ---
> drivers/mtd/spi-nor/spi-nor.c | 39 +++
ngs
Arnd Bergmann (1):
mtd: docg3: don't set conflicting BCH_CONST_PARAMS option
Boris Brezillon (4):
mtd: nand: Fix nanddev_neraseblocks()
mtd: spi-nor: Reset nor->addr_width when SFDP parsing failed
mtd: sa1100:
ngs
Arnd Bergmann (1):
mtd: docg3: don't set conflicting BCH_CONST_PARAMS option
Boris Brezillon (4):
mtd: nand: Fix nanddev_neraseblocks()
mtd: spi-nor: Reset nor->addr_width when SFDP parsing failed
mtd: sa1100:
On Wed, 7 Nov 2018 20:42:08 +
Hi Colin,
Colin King wrote:
> From: Colin Ian King
>
> Currently max_read_ds is being updated twice, which is incorrect.
> The second assignment should be to max_write_ds instead. Fix this.
>
> Detected by CoverityScan, CID#1475379 ("Unused value")
>
>
On Wed, 7 Nov 2018 20:42:08 +
Hi Colin,
Colin King wrote:
> From: Colin Ian King
>
> Currently max_read_ds is being updated twice, which is incorrect.
> The second assignment should be to max_write_ds instead. Fix this.
>
> Detected by CoverityScan, CID#1475379 ("Unused value")
>
>
601 - 700 of 10969 matches
Mail list logo
